[PATCH v4] openvswitch: Remove padding from packet before L3+ conntrack processing

2018-01-31 Thread Ed Swierk
rim the skb to the L3 length before higher-layer processing. Signed-off-by: Ed Swierk <eswi...@skyportsystems.com> --- net/openvswitch/conntrack.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntra

[PATCH v3 2/2] openvswitch: Remove padding from packet before L3+ conntrack processing

2018-01-22 Thread Ed Swierk
L3+ conntrack processing. Signed-off-by: Ed Swierk <eswi...@skyportsystems.com> --- net/openvswitch/conntrack.c | 4 1 file changed, 4 insertions(+) diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c index d558e88..1d24709 100644 --- a/net/openvswitch/conntrack.c ++

[PATCH v3 1/2] skbuff: Add skb_network_trim

2018-01-22 Thread Ed Swierk
netfilter hooks. Currently the openvswitch receive path does not perform such trimming, which will be fixed by the next patch. In preparation, this patch adds a generic skb_network_trim() function. Signed-off-by: Ed Swierk <eswi...@skyportsystems.com> --- include/linux/skbuff.h | 2 ++ net/co

Re: [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

2018-01-08 Thread Ed Swierk
On 1/6/18 10:57, Pravin Shelar wrote: > On Fri, Jan 5, 2018 at 10:59 PM, Ed Swierk <eswi...@skyportsystems.com> wrote: >> >> >> On Jan 5, 2018 22:17, "Pravin Shelar" <pshe...@ovn.org> wrote: >> >> On Fri, Jan 5, 2018 at 3:20 PM, Ed Swierk &

Re: [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

2018-01-05 Thread Ed Swierk
On Thu, Jan 4, 2018 at 7:36 PM, Pravin Shelar <pshe...@ovn.org> wrote: > On Wed, Jan 3, 2018 at 7:49 PM, Ed Swierk <eswi...@skyportsystems.com> wrote: >> On Fri, Dec 22, 2017 at 3:31 PM, Pravin Shelar <pshe...@ovn.org> wrote: >>> On Thu, Dec

Re: [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

2018-01-03 Thread Ed Swierk
On Fri, Dec 22, 2017 at 3:31 PM, Pravin Shelar <pshe...@ovn.org> wrote: > On Thu, Dec 21, 2017 at 7:17 AM, Ed Swierk <eswi...@skyportsystems.com> wrote: >> IPv4 and IPv6 packets may arrive with lower-layer padding that is not >> included in the L3 length. For example, a

Re: [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

2017-12-22 Thread Ed Swierk
On Fri, Dec 22, 2017 at 3:31 PM, Pravin Shelar <pshe...@ovn.org> wrote: > On Thu, Dec 21, 2017 at 7:17 AM, Ed Swierk <eswi...@skyportsystems.com> wrote: >> IPv4 and IPv6 packets may arrive with lower-layer padding that is not >> included in the L3 length. For example, a

[PATCH v2 RESEND] openvswitch: Trim off padding before L3+ netfilter processing

2017-12-21 Thread Ed Swierk
onntrack and nf_nat is that skb->len reflects the length of the L3 header and payload, so there is no need to refer back to ip_hdr->tot_len or ipv6_hdr->payload_len. This change brings OVS into line with other netfilter users, trimming IPv4 and IPv6 packets prior to L3+ netfilter processing. Si

[PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

2017-12-21 Thread Ed Swierk
onntrack and nf_nat is that skb->len reflects the length of the L3 header and payload, so there is no need to refer back to ip_hdr->tot_len or ipv6_hdr->payload_len. This change brings OVS into line with other netfilter users, trimming IPv4 and IPv6 packets prior to L3+ netfilter processing. Si

Re: [PATCH] openvswitch: Trim off padding before L3 conntrack processing

2017-12-14 Thread Ed Swierk
On Wed, Dec 13, 2017 at 4:58 PM, Pravin Shelar <pshe...@ovn.org> wrote: > On Tue, Dec 12, 2017 at 8:17 AM, Ed Swierk <eswi...@skyportsystems.com> wrote: >> A short IPv4 packet may have up to 6 bytes of padding following the IP >> payload when received on an Ethernet

Re: [PATCH] veth: Optionally pad packets to minimum Ethernet length

2017-12-12 Thread Ed Swierk
On Tue, Dec 12, 2017 at 10:34 AM, Stephen Hemminger wrote: > Why not add to netdevsim rather than cluttering up a normal driver > with test support. We just pulled a bunch of test stuff out of dummy > for the same reason. My test setup to trigger an openvswitch

[PATCH] openvswitch: Trim off padding before L3 conntrack processing

2017-12-12 Thread Ed Swierk
his change, OVS conntrack trims IPv4 and IPv6 packets prior to L3 processing. Signed-off-by: Ed Swierk <eswi...@skyportsystems.com> --- net/openvswitch/conntrack.c | 17 + 1 file changed, 17 insertions(+) diff --git a/net/openvswitch/conntrack.c b/net/openvswitch

[PATCH] veth: Optionally pad packets to minimum Ethernet length

2017-12-12 Thread Ed Swierk
leave it off by default. Enable padding only when the otherwise unused IFF_AUTOMEDIA flag is set (e.g. by writing 0x5003 to flags in sysfs). Signed-off-by: Ed Swierk <eswi...@skyportsystems.com> --- drivers/net/veth.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ve

Disable all network protocols on an interface?

2016-11-14 Thread Ed Swierk
I have a Linux kernel 4.4 system hosting a number of kvm VMs. Physical interface eth0 connects to an 802.1Q trunk port on an external switch. Each VM has a virtual interface (e1000 or virtio-net) connected to the physical NIC through a macvtap interface and a VLAN interface; traffic between the

Improving OCTEON II 10G Ethernet performance

2016-08-24 Thread Ed Swierk
I'm trying to migrate from the Octeon SDK to a vanilla Linux 4.4 kernel for a Cavium OCTEON II (CN6880) board running in 64-bit little-endian mode. So far I've gotten most of the hardware features I need working, including XAUI/RXAUI, USB, boot bus and I2C, with a fairly small set of patches.

Re: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Ed Swierk
On 12/13/07, Andrew Morton [EMAIL PROTECTED] wrote: Does this patch actually fix any observeable problem? Without the patch, ifconfig down leaves the physical link up, which confuses datacenter users who expect the link lights both on the NIC and the switch to go out when they bring an interface

[updated PATCH] forcedeth: power down phy when interface is down

2007-09-21 Thread Ed Swierk
On 9/19/07, Ayaz Abdulla [EMAIL PROTECTED] wrote: It seems that you are powering down the phy even if WOL is enabled. Right; I've updated the patch to skip powering down the phy when wol is enabled. Secondly, can you powerdown the phy at the same time you start performing autoneg restart?

[PATCH] forcedeth: power down phy when interface is down

2007-09-18 Thread Ed Swierk
Bring the physical link down when the interface is down, by placing the PHY in power-down state. This mirrors the behavior of other drivers including e1000 and tg3. Signed-off-by: Ed Swierk [EMAIL PROTECTED] forcedeth-phy-power-down.patch Description: Binary data

[PATCH] forcedeth: no link is informational

2007-09-18 Thread Ed Swierk
Log no link during initialization at KERN_INFO as it's not an error, and occurs every time the interface comes up (when the forcedeth-phy-power-down patch is applied). Signed-off-by: Ed Swierk [EMAIL PROTECTED] forcedeth-open-no-link-printk.patch Description: Binary data

Re: [PATCH] Configurable tap interface MTU

2007-09-12 Thread Ed Swierk
On 9/11/07, Herbert Xu [EMAIL PROTECTED] wrote: Please make it 65535 without an Ethernet header and 65521 with an Ethernet header. Here is a revised patch that allows MTUs up to 65535 for tap interfaces and up to 65521 for tun interfaces. (If I set the MTU to 65521 on a tun interface, ping

[PATCH] Configurable tap interface MTU

2007-09-11 Thread Ed Swierk
the value used by the e1000 driver, so it seems like a safe upper limit. Signed-off-by: Ed Swierk [EMAIL PROTECTED] --- tap-change-mtu.patch Description: Binary data