Re: [PATCH v2] ath10k: transmit queued frames after waking queues

2018-05-23 Thread Erik Stromdahl
On 05/22/2018 11:15 PM, Niklas Cassel wrote: Earlier we observed performance issues in calling push_pending from each tx completion. IMHO this change may introduce the same problem again. I prefer functional TX over performance issues, but I agree that it is unfortunate that SDIO doesn't u

Re: ath10k: ret used but uninitialized (was: Re: ath10k: add initial SDIO support)

2017-07-06 Thread Erik Stromdahl
With gcc 4.1.2: drivers/net/wireless/ath/ath10k/sdio.c: In function ‘ath10k_sdio_mbox_rxmsg_pending_handler’: drivers/net/wireless/ath/ath10k/sdio.c:676: warning: ‘ret’ may be used uninitialized in this function + + *done = true; + + /* Copy the lookahead obtained from the HTC regis

Re: [PATCH] mac80211_hwsim: Added vendor echo command

2016-06-25 Thread Erik Stromdahl
that you don't want the hwsim driver bloated with definitions that does not belong there. Is there any reason why hwsim uses the QCA vendor id? Perhaps it would be best if the hwsim driver would define its own vendor id? On 06/24/2016 10:47 PM, Jouni Malinen wrote: On Fri, Jun 24, 2016

[PATCH] mac80211_hwsim: Added vendor echo command

2016-06-24 Thread Erik Stromdahl
The purpose of the echo command is to provide a test facility for user space programs. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/mac80211_hwsim.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mac80211_hwsim.c