Re: [PATCH v2 net-next 03/12] net: mscc: ocelot: better error handling in ocelot_xtr_irq_handler

2021-02-13 Thread Florian Fainelli
ed by using "goto" instead of repeated "break" statements. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 5/5] net: dsa: propagate extack to .port_vlan_filtering

2021-02-13 Thread Florian Fainelli
Also netlink extack includes the module that emitted the message, which means that it's easier to figure out which ones are driver-generated errors as opposed to command misuse. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 4/5] net: dsa: propagate extack to .port_vlan_add

2021-02-13 Thread Florian Fainelli
support for printf format specifier in netlink extack), I chose to keep the messages in full form to the kernel log only, and leave it up to individual driver maintainers to move more messages to extack. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 3/5] net: bridge: propagate extack through switchdev_port_attr_set

2021-02-13 Thread Florian Fainelli
: Florian Fainelli -- Florian

Re: [PATCH net-next 2/5] net: bridge: propagate extack through store_bridge_parm

2021-02-13 Thread Florian Fainelli
us to propagate the extack argument to br_vlan_set_default_pvid, br_vlan_set_proto and br_vlan_filter_toggle, and from there, further up in br_changelink from br_netlink.c. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 1/5] net: bridge: remove __br_vlan_filter_toggle

2021-02-13 Thread Florian Fainelli
On 2/13/2021 12:43, Vladimir Oltean wrote: From: Vladimir Oltean This function is identical with br_vlan_filter_toggle. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

[PATCH net-next v2 3/3] net: phy: broadcom: Allow BCM54210E to configure APD

2021-02-12 Thread Florian Fainelli
when there is no energy on the cable. Signed-off-by: Florian Fainelli --- drivers/net/phy/broadcom.c | 8 +--- include/linux/brcmphy.h| 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c index 3ce266ab521b

[PATCH net-next v2 1/3] net: phy: broadcom: Avoid forward for bcm54xx_config_clock_delay()

2021-02-12 Thread Florian Fainelli
Avoid a forward declaration by moving the callers of bcm54xx_config_clock_delay() below its body. Signed-off-by: Florian Fainelli --- drivers/net/phy/broadcom.c | 74 +++--- 1 file changed, 36 insertions(+), 38 deletions(-) diff --git a/drivers/net/phy

[PATCH net-next v2 2/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Florian Fainelli
driver private structure instead to store that flag instead of canibalizing one from phydev->dev_flags for that purpose. Signed-off-by: Florian Fainelli --- drivers/net/phy/broadcom.c | 19 --- include/linux/brcmphy.h| 21 - 2 files changed, 24 insertions(+),

[PATCH net-next v2 0/3] net: phy: broadcom: Cleanups and APD

2021-02-12 Thread Florian Fainelli
ual hardware - added a patch to remove a forward declaration - do additional flags cleanup Florian Fainelli (3): net: phy: broadcom: Avoid forward for bcm54xx_config_clock_delay() net: phy: broadcom: Remove unused flags net: phy: broadcom: Allow BCM54210E to configure APD drivers/net/

Re: [PATCH net-next 2/3] net: phy: broadcom: Fix RXC/TXC auto disabling

2021-02-12 Thread Florian Fainelli
On 2/12/2021 5:14 PM, Florian Fainelli wrote: > > > On 2/12/2021 5:11 PM, Vladimir Oltean wrote: >> On Fri, Feb 12, 2021 at 12:57:20PM -0800, Florian Fainelli wrote: >>> When support for optionally disabling the TXC was introduced, bit 2 was >>> used to do tha

Re: [PATCH net-next 1/2] net: phy: broadcom: Set proper 1000BaseX/SGMII interface mode for BCM54616S

2021-02-12 Thread Florian Fainelli
On 2/12/2021 5:45 PM, Robert Hancock wrote: > On Fri, 2021-02-12 at 17:26 -0800, Florian Fainelli wrote: >> >> On 2/12/2021 4:28 PM, 'Robert Hancock' via BCM-KERNEL-FEEDBACK-LIST,PDL >> wrote: >>> The default configuration for the BCM54616S PHY may n

Re: [PATCH net-next v2 1/2] net: phy: broadcom: Set proper 1000BaseX/SGMII interface mode for BCM54616S

2021-02-12 Thread Florian Fainelli
ces provided by Bel-Fuse: > > https://www.belfuse.com/resources/datasheets/powersolutions/ds-bps-sfp-1gbt-05-series.pdf > https://www.belfuse.com/resources/datasheets/powersolutions/ds-bps-sfp-1gbt-06-series.pdf > > Signed-off-by: Robert Hancock Acked-by: Florian Fainelli -- Florian

Re: [PATCH net-next v2 2/2] net: phy: broadcom: Do not modify LED configuration for SFP module PHYs

2021-02-12 Thread Florian Fainelli
odifying the LED settings will cause the LOS output to > malfunction. Skip this configuration for PHYs which are bound to an SFP > bus. > > Signed-off-by: Robert Hancock Acked-by: Florian Fainelli -- Florian

Re: [PATCH net-next 1/2] net: phy: broadcom: Set proper 1000BaseX/SGMII interface mode for BCM54616S

2021-02-12 Thread Florian Fainelli
On 2/12/2021 4:28 PM, 'Robert Hancock' via BCM-KERNEL-FEEDBACK-LIST,PDL wrote: > The default configuration for the BCM54616S PHY may not match the desired > mode when using 1000BaseX or SGMII interface modes, such as when it is on > an SFP module. Add code to explicitly set the correct mode usin

Re: [PATCH net-next 2/2] net: phy: broadcom: Do not modify LED configuration for SFP module PHYs

2021-02-12 Thread Florian Fainelli
BCM5482_SHD_LEDS1_LED3(BCM_LED_MULTICOLOR_LINK_ACT); > + bcm_phy_write_exp(phydev, BCM_EXP_MULTICOLOR, val); Not sure I can come up with a better solution but this should probably be made conditional upon the specific SFP module, or a set of specific SFP modules, whether we can convey those details via a Device Tree property or by doing a SFP ID lookup. Acked-by: Florian Fainelli -- Florian

Re: [PATCH net-next 1/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Florian Fainelli
On 2/12/2021 5:14 PM, Vladimir Oltean wrote: > On Fri, Feb 12, 2021 at 05:08:58PM -0800, Florian Fainelli wrote: >> That's right, tg3 drove a lot of the Broadcom PHY driver changes back >> then, I also would like to rework the way we pass flags towards PHY >> driver

Re: [PATCH net-next 2/3] net: phy: broadcom: Fix RXC/TXC auto disabling

2021-02-12 Thread Florian Fainelli
On 2/12/2021 5:11 PM, Vladimir Oltean wrote: > On Fri, Feb 12, 2021 at 12:57:20PM -0800, Florian Fainelli wrote: >> When support for optionally disabling the TXC was introduced, bit 2 was >> used to do that operation but the datasheet for 50610M from 2009 does >> not show b

Re: [PATCH net-next 1/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Florian Fainelli
On 2/12/2021 4:56 PM, Vladimir Oltean wrote: > On Fri, Feb 12, 2021 at 12:57:19PM -0800, Florian Fainelli wrote: >> We have a number of unused flags defined today and since we are scarce >> on space and may need to introduce new flags in the future remove and >> shift eve

[PATCH net-next 1/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Florian Fainelli
We have a number of unused flags defined today and since we are scarce on space and may need to introduce new flags in the future remove and shift every existing flag down into a contiguous assignment. No functional change. Signed-off-by: Florian Fainelli --- include/linux/brcmphy.h | 22

[PATCH net-next 3/3] net: phy: broadcom: Allow BCM54210E to configure APD

2021-02-12 Thread Florian Fainelli
BCM54210E/BCM50212E has been verified to work correctly with the auto-power down configuration done by bcm54xx_adjust_rxrefclk(), add it to the list of PHYs working. Signed-off-by: Florian Fainelli --- drivers/net/phy/broadcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net

[PATCH net-next 2/3] net: phy: broadcom: Fix RXC/TXC auto disabling

2021-02-12 Thread Florian Fainelli
("tg3 / broadcom: Optionally disable TXC if no link") Signed-off-by: Florian Fainelli --- include/linux/brcmphy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h index da7bf9dfef5b..3dd8203cf780 100644 --- a/inc

[PATCH net-next 0/3] net: phy: broadcom: APD improvements

2021-02-12 Thread Florian Fainelli
This patch series cleans up the brcmphy.h header and its numerous unused phydev->dev_flags, fixes the RXC/TXC clock disabling bit and allows the BCM54210E PHY to utilize APD. Thanks! Florian Fainelli (3): net: phy: broadcom: Remove unused flags net: phy: broadcom: Fix RXC/TXC auto disabl

Re: [PATCH 0/4] Bug fixes to amd-xgbe driver

2021-02-12 Thread Florian Fainelli
On 2/12/2021 10:00 AM, Shyam Sundar S K wrote: > General fixes on amd-xgbe driver are addressed in this series, mostly > on the mailbox communication failures and improving the link stability > of the amd-xgbe device. > > Shyam Sundar S K (4): > amd-xgbe: Reset the PHY rx data path when mailb

Re: [PATCH 4/4] amd-xgbe: Fix network fluctuations when using 1G BELFUSE SFP

2021-02-12 Thread Florian Fainelli
On 2/12/2021 10:00 AM, Shyam Sundar S K wrote: > Frequent link up/down events can happen when a Bel Fuse SFP part is > connected to the amd-xgbe device. Try to avoid the frequent link > issues by resetting the PHY as documented in Bel Fuse SFP datasheets. > > Signed-off-by: Sudheesh Mavila > S

Re: [PATCH v5 net-next 06/10] net: dsa: act as passthrough for bridge port flags

2021-02-12 Thread Florian Fainelli
NOWN of > PORT_CTL0, which has the exact same bit index. I have left the > implementations separate though, for the only reason that the names are > different enough to confuse me, since I am not able to double-check with > a user manual. The multicast flooding setting for 6185 is in a different > register than for 6352 though. > > Signed-off-by: Vladimir Oltean > --- Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 net-next 07/10] net: dsa: felix: restore multicast flood to CPU when NPI tagger reinitializes

2021-02-12 Thread Florian Fainelli
rom the default > ocelot tagger towards ocelot-8021q and then again towards ocelot, > multicast flooding towards the CPU port module will be disabled. > > Fixes: e21268efbe26 ("net: dsa: felix: perform switch setup for tag_8021q") > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 net-next 05/10] net: switchdev: pass flags and mask to both {PRE_,}BRIDGE_FLAGS attributes

2021-02-12 Thread Florian Fainelli
they are forced to reject it during > the deferred BRIDGE_FLAGS attribute, where the rejection is currently > ignored. > > This patch also changes drivers to make use of the "mask" field for edge > detection when possible. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 net-next 03/10] net: bridge: don't print in br_switchdev_set_port_flag

2021-02-12 Thread Florian Fainelli
layer higher than in > switchdev, which also allows us to silently ignore the offloading of > flags if that is ever needed in the future. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli I suppose the slight "loss" of information on which port failed the operation

Re: [PATCH v5 net-next 02/10] net: bridge: offload all port flags at once in br_setport

2021-02-12 Thread Florian Fainelli
e would be no attempt to revert the partial state in > any way. Arguably, if the user changes more than one flag through the > same netlink command, this one _should_ be all or nothing, which means > it should be passed through switchdev as all or nothing. > > Signed-off-by: Vladimir

Re: [PATCH v4 net-next 1/9] net: switchdev: propagate extack to port attributes

2021-02-11 Thread Florian Fainelli
o Schimmel Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 5.12 8/8] net: broadcom: bcm4908_enet: fix endianness in xmit code

2021-02-11 Thread Florian Fainelli
On 2/11/21 4:12 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > Use le32_to_cpu() for reading __le32 struct field filled by hw. > > Signed-off-by: Rafał Miłecki Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 5.12 7/8] net: broadcom: bcm4908_enet: fix received skb length

2021-02-11 Thread Florian Fainelli
On 2/11/21 4:12 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > Use ETH_FCS_LEN instead of magic value and drop incorrect + 2 > > Signed-off-by: Rafał Miłecki Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 5.12 6/8] net: broadcom: bcm4908_enet: fix minor typos

2021-02-11 Thread Florian Fainelli
On 2/11/21 4:12 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > 1. Fix "ensable" typo noticed by Andrew > 2. Fix chipset name in the struct net_device_ops variable > > Suggested-by: Andrew Lunn > Signed-off-by: Rafał Miłecki > Reviewed-by: Andrew Lu

Re: [PATCH net-next 5.12 5/8] net: broadcom: bcm4908_enet: drop "inline" from C functions

2021-02-11 Thread Florian Fainelli
On 2/11/21 4:12 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > It seems preferred to let compiler optimize code if applicable. > While at it drop unused enet_umac_maskset(). > > Suggested-by: Andrew Lunn > Signed-off-by: Rafał Miłecki > Reviewed-by: Andrew Lun

Re: [PATCH net-next 5.12 3/8] net: broadcom: rename BCM4908 driver & update DT binding

2021-02-11 Thread Florian Fainelli
On 2/11/21 4:12 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > compatible string was updated to match normal naming convention so > update driver as well > > Signed-off-by: Rafał Miłecki Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 5.12 4/8] net: broadcom: bcm4908_enet: drop unneeded memset()

2021-02-11 Thread Florian Fainelli
On 2/11/21 4:12 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > dma_alloc_coherent takes care of zeroing allocated memory > > Suggested-by: Andrew Lunn > Signed-off-by: Rafał Miłecki > Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 5.12 2/8] dt-bindings: net: bcm4908-enet: include ethernet-controller.yaml

2021-02-11 Thread Florian Fainelli
On 2/11/21 4:12 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > It should be /included/ by every Ethernet controller binding. It adds > support for various generic properties. > > Suggested-by: Rob Herring > Signed-off-by: Rafał Miłecki Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 5.12 1/8] dt-bindings: net: rename BCM4908 Ethernet binding

2021-02-11 Thread Florian Fainelli
On 2/11/21 4:12 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > Rob pointed out that a normal convention is "brcm,bcm4908-enet" so > update whole binding to match it. > > Suggested-by: Rob Herring > Signed-off-by: Rafał Miłecki Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH] enetc: auto select PHYLIB and MDIO_DEVRES

2021-02-11 Thread Florian Fainelli
On 2/11/21 8:09 AM, Tong Zhang wrote: > FSL_ENETC_MDIO use symbols from PHYLIB and MDIO_DEVRES, however they are > not auto selected. > > ERROR: modpost: "__mdiobus_register" > [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined! > ERROR: modpost: "mdiobus_unregister" > [drivers/n

Re: [PATCH net-next] net: ipconfig: avoid use-after-free in ic_close_devs

2021-02-10 Thread Florian Fainelli
> through its lowers, only ic_dev->dev, structure which isn't ever freed. > So, by keeping ic_dev->dev in a variable assigned prior to freeing > ic_dev, we can avoid all use-after-free issues. > > Fixes: 46acf7bdbc72 ("Revert "net: ipv4: handle DSA enabled master n

Re: [PATCH v3 net-next 10/11] net: mscc: ocelot: offload bridge port flags to device

2021-02-10 Thread Florian Fainelli
earning > in ocelot_init_port. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Alexandre Belloni Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 net-next 09/11] net: mscc: ocelot: use separate flooding PGID for broadcast

2021-02-10 Thread Florian Fainelli
of > broadcast packets, to allow configuring it individually. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 net-next 06/11] net: dsa: kill .port_egress_floods overengineering

2021-02-10 Thread Florian Fainelli
_mrouter is created. > > Functionally speaking, we simply move the calls to .port_egress_floods > one step lower, in the two drivers that implement it: mv88e6xxx and b53, > so things should work just as before. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 net-next 04/11] net: dsa: configure proper brport flags when ports leave the bridge

2021-02-10 Thread Florian Fainelli
neric .port_bridge_flags. > > Previous attempts to code up this logic have been in the common bridge > layer, but as pointed out by Ido Schimmel, there are corner cases that > are missed when doing that: > https://patchwork.kernel.org/project/netdevbpf/patch/20210209151936.97382-5-olte...@gmail.com/ > > So, at least for now, let's leave DSA in charge of setting port flags > before and after the bridge join and leave. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 net-next 01/11] net: switchdev: propagate extack to port attributes

2021-02-10 Thread Florian Fainelli
o Schimmel Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next] net: phy: introduce phydev->port

2021-02-10 Thread Florian Fainelli
On 2/10/21 3:20 AM, Michael Walle wrote: > > Am 2021-02-09 17:38, schrieb Michael Walle: >> --- a/drivers/net/phy/phy.c >> +++ b/drivers/net/phy/phy.c >> @@ -308,7 +308,7 @@ void phy_ethtool_ksettings_get(struct phy_device >> *phydev, >> if (phydev->interface == PHY_INTERFACE_MODE_MOCA) >>   

Re: [PATCH net-next v3 4/4] net: dsa: xrs700x: add HSR offloading support

2021-02-09 Thread Florian Fainelli
On 2/9/2021 5:02 PM, George McCollister wrote: > Add offloading for HSR/PRP (IEC 62439-3) tag insertion, tag removal > forwarding and duplication supported by the xrs7000 series switches. > > Only HSR v1 and PRP v1 are supported by the xrs7000 series switches (HSR > v0 is not). > > Signed-off-

Re: [PATCH net-next v3 3/4] net: dsa: add support for offloading HSR

2021-02-09 Thread Florian Fainelli
t; > Signed-off-by: George McCollister Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next] net: phy: introduce phydev->port

2021-02-09 Thread Florian Fainelli
orting PORT_MII to either PORT_TP or PORT_FIBRE; > except for the genphy fallback driver. > > Suggested-by: Andrew Lunn > Signed-off-by: Michael Walle Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 1/2] net: dsa: xrs700x: fix unused warning for of_device_id

2021-02-09 Thread Florian Fainelli
t-variable] >static const struct of_device_id xrs700x_i2c_dt_ids[] = { > > Reported-by: kernel test robot > Signed-off-by: George McCollister Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 net-next 07/11] net: dsa: kill .port_egress_floods overengineering

2021-02-09 Thread Florian Fainelli
On 2/9/21 12:37 PM, Vladimir Oltean wrote: > On Tue, Feb 09, 2021 at 05:19:32PM +0200, Vladimir Oltean wrote: >> From: Vladimir Oltean >> >> The bridge offloads the port flags through a single bit mask using >> switchdev, which among others, contains learning and flooding settings. >> >> The commi

Re: [PATCH net-next 2/2] net: dsa: xrs700x: use of_match_ptr() on xrs700x_mdio_dt_ids

2021-02-09 Thread Florian Fainelli
McCollister Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH] net: phy: broadcom: remove BCM5482 1000BX support

2021-02-08 Thread Florian Fainelli
On 2/8/21 1:35 PM, Michael Walle wrote: > It is nowhere used in the kernel. It also seems to be lacking the > proper fiber advertise flags. Remove it. > > Signed-off-by: Michael Walle Acked-by: Florian Fainelli -- Florian

Re: [PATCH net-next] net: dsa: allow port mirroring towards foreign interfaces

2021-02-05 Thread Florian Fainelli
the CPU > port and let the mirred action deal with them in software. Reviewed-by: Florian Fainelli How does the mirred action deal with that case? How does it know that packets delivered to the DSA master should be sent towards a foreign address, do I need to set-up two mirred rules? One that

[PATCH ethtool] gitignore: Ignore .dirstamp

2021-02-04 Thread Florian Fainelli
Signed-off-by: Florian Fainelli --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index c4df588c37ea..0b7a71b58b7e 100644 --- a/.gitignore +++ b/.gitignore @@ -30,3 +30,4 @@ test-*.trs .*.swp *.patch +.dirstamp -- 2.25.1

Re: [PATCH net] net: dsa: call teardown method on probe failure

2021-02-04 Thread Florian Fainelli
rs") > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next] net: dsa: bcm_sf2: Check egress tagging of CFP rule with proper accessor

2021-02-03 Thread Florian Fainelli
be32 > warning: cast from restricted __be32 > warning: cast from restricted __be32 > warning: cast from restricted __be32 > warning: cast from restricted __be32 > warning: restricted __be32 degrades to integer > > Signed-off-by: Vladimir Oltean Acked-by: Florian Fainelli -- Florian

Re: About PHY_INTERFACE_MODE_REVMII

2021-02-02 Thread Florian Fainelli
On 2/1/21 4:53 PM, Vladimir Oltean wrote: > Hi Florian, > > Thanks for the quick answer! > > On Mon, Feb 01, 2021 at 04:26:36PM -0800, Florian Fainelli wrote: >> It depends on the level of control that you have and expect more on that >> below. > >> That is

Re: About PHY_INTERFACE_MODE_REVMII

2021-02-01 Thread Florian Fainelli
On 2/1/21 1:45 PM, Vladimir Oltean wrote: > Hi Florian, > > I was looking at > > commit 2cc70ba4cf5f97a7cf08063d2fae693d36b462eb > Author: Florian Fainelli > Date: Tue May 28 04:07:21 2013 + > > phy: add reverse MII PHY connection type > >

Re: [PATCH net-next 1/2] net: dsa: hellcreek: Report VLAN table occupancy

2021-01-31 Thread Florian Fainelli
AN size 4096 occ 4 unit entry dpipe_tables none > > Signed-off-by: Kurt Kanzenbach Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 2/2] net: dsa: hellcreek: Report FDB table occupancy

2021-01-31 Thread Florian Fainelli
4096 occ 2 unit entry dpipe_tables none > | name FDB size 256 occ 6 unit entry dpipe_tables none > > Suggested-by: Florian Fainelli > Signed-off-by: Kurt Kanzenbach Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 0/8] net: dsa: microchip: DSA driver support for LAN937x switch

2021-01-28 Thread Florian Fainelli
On 1/27/2021 10:41 PM, Prasanna Vengateshan wrote: > LAN937x is a Multi-Port 100BASE-T1 Ethernet Physical Layer switch > compliant with the IEEE 802.3bw-2015 specification. The device > provides 100 Mbit/s transmit and receive capability over a single > Unshielded Twisted Pair (UTP) cable. LAN

Re: [PATCH net-next 0/4] Automatically manage DSA master interface state

2021-01-27 Thread Florian Fainelli
On 1/27/2021 5:30 PM, Vladimir Oltean wrote: > On Wed, Jan 27, 2021 at 05:03:23PM -0800, Florian Fainelli wrote: >> I really like all patches but number #2, though I don't believe there >> are existing use cases besides you one you described where it makes >> se

Re: [PATCH v7 net-next 08/11] net: dsa: allow changing the tag protocol via the "tagging" device attribute

2021-01-27 Thread Florian Fainelli
will first tear down the tagging protocol >> for all switches in the tree attached to that DSA master, then will >> attempt setup with the new tagger. >> >> Writing will fail quickly with -EOPNOTSUPP for drivers that don't >> support .set_tag_protocol, since that

Re: [PATCH net-next 4/4] Revert "net: ipv4: handle DSA enabled master network devices"

2021-01-27 Thread Florian Fainelli
[ 15.498481] nameserver0=8.8.8.8 > [ 15.627542] fsl_enetc :00:00.0 eth0: Link is Down > [ 15.690903] mscc_felix :00:00.5 swp0: Link is Down > [ 15.745216] mscc_felix :00:00.5 swp1: Link is Down > [ 15.800498] mscc_felix :00:00.5 swp2: Link is Down > [ 15.858143] ALSA device list: > [ 15.861420] No soundcards found. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 2/4] net: dsa: automatically bring user ports down when master goes down

2021-01-27 Thread Florian Fainelli
er_port() ?? >>> >>> That ! seems odd. >> >> Oops, that's something that I refactored at the last minute after I >> prototyped the idea from: >> if (!dsa_is_user_port(dp->ds, dp->index)) >> continue; >> because it looked uglier that way. > > I was guessing it would be something like that. With that fixed: > > Reviewed-by: Andrew Lunn When you fix it: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 3/4] Revert "net: Have netpoll bring-up DSA management interface"

2021-01-27 Thread Florian Fainelli
in DSA to > handle the situation where the DSA master must be brought up. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 1/4] net: dsa: automatically bring up DSA master when opening user port

2021-01-27 Thread Florian Fainelli
emove DSA-specific workarounds, like systemd-networkd with BindCarrier: > https://github.com/systemd/systemd/issues/7478 > > And we can finally remove one of the 2 bullets in the "Common pitfalls > using DSA setups" chapter. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 0/4] Automatically manage DSA master interface state

2021-01-27 Thread Florian Fainelli
On 1/26/2021 5:00 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > This patch series adds code that makes DSA open the master interface > automatically whenever one user interface gets opened, either by the > user, or by various networking subsystems: netconsole, nfsroot. > With that in

Re: [PATCH V2 1/1] net: dsa: rtl8366rb: standardize init jam tables

2021-01-27 Thread Florian Fainelli
rays. Each entry contains 2 u16 values. > This change makes it easier to understand how the jam tables are used > and also makes it possible for a single function to handle all of them, > removing some duplicated code. > > Signed-off-by: Lorenzo Carletti Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH V2 1/1] net: dsa: rtl8366rb: standardize init jam tables

2021-01-27 Thread Florian Fainelli
On 1/27/2021 12:06 PM, Lorenzo Carletti wrote: > Many thanks for telling me that and for showing me how this works. > I find both very useful. > I'll be sure to follow the guidelines more carefully next time. One of those guidelines is no top-posting and make sure you use a plaintext format for

Re: [patch net-next v2] net: dsa: mv88e6xxx: Make global2 support mandatory

2021-01-26 Thread Florian Fainelli
gain. > > Make global 2 support always compiled in. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH V3 1/6] net: stmmac: remove redundant null check for ptp clock

2021-01-26 Thread Florian Fainelli
ork >> Development ; dl-linux-imx ; >> Andrew Lunn ; Florian Fainelli >> Subject: Re: [PATCH V3 1/6] net: stmmac: remove redundant null check for ptp >> clock >> >> On Tue, Jan 26, 2021 at 7:05 AM Joakim Zhang >> wrote: >>> >>> Remove r

Re: [PATCH] dsa: mv88e6xxx: Make global2 support mandatory

2021-01-23 Thread Florian Fainelli
On 1/23/2021 7:06 PM, Jakub Kicinski wrote: > On Sat, 23 Jan 2021 21:51:48 +0100 Andrew Lunn wrote: >> Early generations of the mv88e6xxx did not have the global 2 >> registers. In order to keep the driver slim, it was decided to make >> the code for these registers optional. Over time, more gen

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Florian Fainelli
On 1/22/2021 5:01 PM, Sergej Bauer wrote: > On Saturday, January 23, 2021 3:01:47 AM MSK Florian Fainelli wrote: >> On 1/22/2021 3:58 PM, Sergej Bauer wrote: >>> On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: >>>>>>> @@ -1000,8 +1005,10

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Florian Fainelli
On 1/22/2021 3:58 PM, Sergej Bauer wrote: > On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > lan743x_adapter *adapter)> > > struct net_device *netdev = adapter->netdev; > > phy_stop(netd

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Florian Fainelli
On 1/22/2021 1:42 PM, Sergej Bauer wrote: > From: sba...@blackbox.su > > v1->v2: > switch to using of fixed_phy as was suggested by Andrew and Florian > also features-related parts are removed > > Previous versions can be found at: > v1: > initial version > https://lkml.org/l

Re: [RFC PATCH net-next 2/3] net: hsr: add DSA offloading support

2021-01-22 Thread Florian Fainelli
On 1/22/2021 9:56 AM, Florian Fainelli wrote: > > > On 1/22/2021 7:59 AM, George McCollister wrote: >> Add support for offloading of HSR/PRP (IEC 62439-3) tag insertion >> tag removal, duplicate generation and forwarding on DSA switches. >> >> Use a new net

Re: [RFC PATCH net-next 2/3] net: hsr: add DSA offloading support

2021-01-22 Thread Florian Fainelli
On 1/22/2021 7:59 AM, George McCollister wrote: > Add support for offloading of HSR/PRP (IEC 62439-3) tag insertion > tag removal, duplicate generation and forwarding on DSA switches. > > Use a new netdev_priv_flag IFF_HSR to indicate that a device is an HSR > device so DSA can tell them apart

Re: [PATCH v6 net-next 07/10] net: dsa: allow changing the tag protocol via the "tagging" device attribute

2021-01-21 Thread Florian Fainelli
with -EOPNOTSUPP for drivers that don't > support .set_tag_protocol, since that is checked during the deletion > phase. It is assumed that all switches within the same DSA tree use the > same driver, and therefore either all have .set_tag_protocol implemented, > or none do. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 net-next 05/10] net: mscc: ocelot: don't use NPI tag prefix for the CPU port module

2021-01-20 Thread Florian Fainelli
tch > makes the inj_prefix and xtr_prefix variables apply only to the NPI > port (which the switchdev ocelot_vsc7514 driver does not use). > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 net-next 04/10] net: mscc: ocelot: reapply bridge forwarding mask on bonding join/leave

2021-01-20 Thread Florian Fainelli
was already taken in > ocelot_bridge_stp_state_set. Also, we can rename "i" into "lag", to make > it more clear what is it that we're iterating through. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Alexandre Belloni Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 net-next 06/10] net: dsa: document the existing switch tree notifiers and add a new one

2021-01-20 Thread Florian Fainelli
oves dsa_broadcast (a top-level function) to dsa2.c, > where it really belonged in the first place, but had no companion so it > stood with dsa_port_notify. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 net-next 07/10] net: dsa: allow changing the tag protocol via the "tagging" device attribute

2021-01-20 Thread Florian Fainelli
On 1/20/2021 6:36 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Currently DSA exposes the following sysfs: > $ cat /sys/class/net/eno2/dsa/tagging > ocelot > > which is a read-only device attribute, introduced in the kernel as > commit 98cdb4807123 ("net: dsa: Expose tagging protocol

Re: [PATCH v5 net-next 08/10] net: dsa: felix: convert to the new .{set,del}_tag_protocol DSA API

2021-01-20 Thread Florian Fainelli
od to all ports except ocelot->num_phys_ports (the CPU port > module). All we change is that we use a read-modify-write to only add > the CPU port module to the unknown unicast replicator, as opposed to > doing a full write to the register. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 net-next 09/10] net: dsa: add a second tagger for Ocelot switches based on tag_8021q

2021-01-20 Thread Florian Fainelli
can be changed via the following device attribute: > > echo ocelot-8021q > /sys/class//dsa/tagging > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 net-next 10/10] net: dsa: felix: perform switch setup for tag_8021q

2021-01-20 Thread Florian Fainelli
, this configuration would be impossible for the user to do. Also, > due to the same reason, it is impossible for the user to inadvertently > delete these rules using tc. These rules do not collide in any way with > tc-flower, they just consume some TCAM space, which is something we can &

Re: [PATCH net-next V2] net: dsa: microchip: Adjust reset release timing to match reference reset circuit

2021-01-20 Thread Florian Fainelli
for 100 ms which fits the constraint with a bit of extra >>> space. >>> >>> Fixes: 5b797980908a ("net: dsa: microchip: Implement recommended >>> reset timing") >>> Reviewed-by: Florian Fainelli >>> Signed-off-by: Marek Vasut >>

Re: [PATCH net-next v7 3/3] net: add sysfs attribute to control napi threaded mode

2021-01-20 Thread Florian Fainelli
On 1/19/2021 7:34 PM, Wei Wang wrote: > This patch adds a new sysfs attribute to the network device class. > Said attribute provides a per-device control to enable/disable the > threaded mode for all the napi instances of the given network device. > User sets it to 1 or 0 to enable or disable th

Re: [PATCH] net: systemport: free dev before on error path

2021-01-19 Thread Florian Fainelli
orrect, but not the Fixes tag, it should be: Fixes: 31bc72d97656 ("net: systemport: fetch and use clock resources") Acked-by: Florian Fainelli -- Florian

Re: [PATCH net-next] net: dsa: microchip: Adjust reset release timing to match reference reset circuit

2021-01-19 Thread Florian Fainelli
n the > original 100uS for the switch itself to come out of reset. Simply > msleep() for 100 mS which fits the constraint with a bit of extra > space. This is nitpicking but the unit symbol for seconds is 's', not 'S' which is for Siemens. With that fixed: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next V2] net: dsa: microchip: ksz8795: Fix KSZ8794 port map again

2021-01-19 Thread Florian Fainelli
d of > TOTOAL_PORT_NUM") > Signed-off-by: Marek Vasut > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: Michael Grzeschik > Cc: Jakub Kicinski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v4 net-next 11/16] net: mscc: ocelot: use DIV_ROUND_UP helper in ocelot_port_inject_frame

2021-01-19 Thread Florian Fainelli
On 1/19/2021 3:07 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > This looks a bit nicer than the open-coded "(x + 3) % 4" idiom. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v4 net-next 13/16] net: mscc: ocelot: export struct ocelot_frame_info

2021-01-19 Thread Florian Fainelli
mation from the > Extraction Frame Header. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next] net: dsa: Fix off by one in dsa_loop_port_vlan_add()

2021-01-19 Thread Florian Fainelli
; cannot be > 4094 because it is checked earlier. > > Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver") > Signed-off-by: Dan Carpenter Acked-by: Florian Fainelli -- Florian

Re: [PATCH net] net: dsa: b53: fix an off by one in checking "vlan->vid"

2021-01-19 Thread Florian Fainelli
on > and it has "dev->num_vlans" elements. > > Fixes: a2482d2ce349 ("net: dsa: b53: Plug in VLAN support") > Signed-off-by: Dan Carpenter Acked-by: Florian Fainelli -- Florian

Re: [PATCH v3 net-next 05/15] net: mscc: ocelot: stop returning IRQ_NONE in ocelot_xtr_irq_handler

2021-01-18 Thread Florian Fainelli
gned-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net v2 2/2] sh_eth: Make PHY access aware of Runtime PM to fix reboot crash

2021-01-18 Thread Florian Fainelli
e > device is suspended, causing undefined behavior, which may crash the > system. > > Fix this by wrapping the PHY bitbang accessors in the sh_eth driver by > wrappers that take care of Runtime PM, to resume the device when needed. > > Reported-by: Wolfram Sang > Suggested-by: Andrew Lunn > Signed-off-by: Geert Uytterhoeven Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net v2 1/2] mdio-bitbang: Export mdiobb_{read,write}()

2021-01-18 Thread Florian Fainelli
On 1/18/2021 7:06 AM, Geert Uytterhoeven wrote: > Export mdiobb_read() and mdiobb_write(), so Ethernet controller drivers > can call them from their MDIO read/write wrappers. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Florian Fainelli -- Florian

<    1   2   3   4   5   6   7   8   9   10   >