Quoting Wang Chen:
| (This patch base on "PATCH 2/3".)
|
| UDP_MIB_INERRORS increment is in different way for IPv4
| and IPv6. For the consistence, change UDP6_INC_STATS_USER
| to UDP6_INC_STATS_BH.
|
| Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
| ---
| udp.c |2 +-
| 1 files changed, 1 in
| (This patch base on "PATCH 1/3".)
|
| Since we have macro IS_UDPLITE, we can use it.
|
| Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
| ---
Acked-by: Gerrit Renker <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
Thanks again for all the work.
| UdpInDatagrams can be confusing because it counts packets that
| might be dropped later.
| Move UdpInDatagrams into recvmsg() as allowed by the RFC.
|
| Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
| ---
Acked-by: Gerrit Renker <[EMAIL PROTECT
Thank you for doing this work, there is a small comment below.
| --- linux-2.6.24.rc3.org/Documentation/networking/udplite.txt 2007-11-19
12:37:40.0 +0800
| +++ linux-2.6.24.rc3/Documentation/networking/udplite.txt 2007-11-28
18:35:29.0 +0800
| @@ -236,7 +236,7 @@
|
|Th
| If there is no socket filter, a bad checksum udp packet will be queued and
| ready for user to read. At the same time the InDatagrams is increased.
| So we need to decrement InDatagrams when recvmsg() or poll() notice the
| bad checksum.
|
| Seems Gerrit had fix it a year ago.(http://lkml.org/lk
Arnaldo, Al Viro, and Yoshifuji -
sorry for having wasted your time with this one. You are right, that was
complete nonsense.
I don't know where my mind was - even my test program used to `prove' this was
screwed up.
So nothing wrong here and thank you very much for your clarifying comments.
Quoting YOSHIFUJI Hideaki:
|
| > [TCP]: break missing at end of switch statement
| >
| > Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
| > ---
| > --- a/net/ipv4/tcp_input.c
| > +++ b/net/ipv4/tcp_input.c
| > @@ -3129,6 +3129,7 @@ static voi
Quoting Al Viro:
| On Mon, Oct 01, 2007 at 01:32:43PM +0100, Gerrit Renker wrote:
| > [TCP]: break missing at end of switch statement
| >
| > Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
| > ---
| > --- a/net/ipv4/tcp_input.c
| > +++ b/net/ipv4/tcp_input.c
[TCP]: break missing at end of switch statement
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
---
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -3129,6 +3129,7 @@ static void tcp_reset(struct sock *sk)
return;
d
With the davem-2.6.24 tree I get the following Oops in the e100 driver (cribbed
from console):
Code: 6c ff ff ff 8b 48 0c ba 01 00 00 00 89 f0 e8 1b f2 ff ff c7 86 9c 00 00 00
01 00 00 00 e9 4e ff ff ff 89 d0 e8 b3 f8 0b 00 eb 8e <0f> 0b eb fe 55 89
e5
56 53 83 ec 0c 8b 98 dc 01 00 0
Yoshifuji-san,
a few weeks earlier I enquired about the IPV6_PKTINFO socket option to get at
the
destination address of datagrams, where you replied that this option is
`deprecated'.
There are three problems:
1. On i386 it works as described in section 4 of RFC 3542, using
IPV6_RECVPKTINFO
| That is, someone needs to send a patch to the upstream manpages
| maintainer and fix the documentation to actually describe what the
| code does.
|
If it is simply replacing IPV6_PKTINFO with IPV6_RECVPKTINFO then I'd be happy
to do this.
Anything more complicated than that - it would be go
Quoting YOSHIFUJI Hideaki / 吉藤英明:
| Current IPV6_PKTINFO is not equal to IPV6_RECVPKTINFO
| but a sticky option to set source address / interface
| for outgoing packet.
Thanks for the update, but there is no `current' IPV6_PKTINFO - set/getsockopt()
on this will result in ENOPROTOOPT.
Manpage d
that this
works as
expected from the API.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
---
--- a/net/ipv6/ipv6_sockglue.c
+++ b/net/ipv6/ipv6_sockglue.c
@@ -315,6 +315,7 @@ static int do_ipv6_setsockopt(struct sock *sk, int level,
int optname,
retv = 0;
2.17 of RFC
2525: both are entitled "Failure to RST on close with data pending", the
differences in text body amount to a typo and minor sentence change.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
---
net/ipv4/tcp.c| 14 ++
net/ipv4/tcp_output.c |
Since CCID3 avoids sending 0-byte data packets (cf. ccid3_hc_tx_send_packet),
testing for zero-payload length, as performed by ccid3_hc_tx_update_s, is
redundant - hence removed by this patch.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Acked-by: Ian McDonald <[EMAIL PROTECTED]>
No code change at all.
This splits ccid3.c into a RX and a TX section, so that the file has an
organisation similar to the other ones (e.g. packet_history.{h,c}).
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Acked-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carv
,
R_sample=176us, X=24886363
Had the previous variant been used, w_init would have been as low as 24.
Committer note: removed unneeded cast to unsigned long long that was
causing a compiler warning on 64bit architectures.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Acked-b
fixed by reusing the new dccp_delta_seqno function.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Acked-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/dccp.h |4 +---
1 files changed, 1 insertions(+), 3 deletion
;= 0.
For all values excluding y = (x + 2^47) % 2^48, the equivalence is clear to
see.
When y = (x + 2^47) % 2^48 then !before(x, y) returned false in the new
definition.
However, 'dccp_delta_seqno(x, (x+2^47) % 2^48) >= 0' also returns false; hence
we
have full equivalence.
Sign
sequence arithmetic:
--48 bit complement
--modulo-48 addition and modulo-48 subtraction
--dccp_inc_seqno now a special case of add48
Constants renamed following a suggestion by Arnaldo.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Acked-by: Ian McDonald <[EMAIL
' b nor b `before' a
This implements http://www.mail-archive.com/dccp@vger.kernel.org/msg01153.html
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Acked-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net
disappears. (Note: we could have used dccp_delta_seqno, but
Arnaldo's concept of using shift and subtraction requires fewer operations).
The patch further defines after48 as a macro, since it is in actual fact just
before48 with the parameters swapped (this mirrors the TCP solution).
Signed-of
sequence arithmetic:
--48 bit complement
--modulo-48 addition and modulo-48 subtraction
--dccp_inc_seqno now a special case of add48
Constants renamed following a suggestion by Arnaldo.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Acked-by: Ian McDonald <[EMAIL
Please can you reconsider the patch regarding the accept_queue
http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.22.git;a=commit;h=8488df894d05d6fa41c2bd298c335f944bb0e401
It disallows to set a `backlog' argument to listen(2) of zero. Using
a zero backlog is often done (e.g. ttcp), and disa
| > Since the old definition is not used in the way "before(x, y) &&
!before(y, x)", but rather in the
| > fashion "before(x, y)" or "after(y, x)", the main advantage of the new
definition is that it makes
| > this type of use a safe case.
|
| This is not true because
|
| if (befor
Quoting Herbert Xu:
| On Fri, Jan 05, 2007 at 11:51:16AM +, Gerrit Renker wrote:
| >
| > | 2) Change before/after such that before(x, x+2^31) == !before(x+2^31,
x).
| > This is what the new definition does: in the old definition we always have
that
| > before(x, x+2^3
| > The key point where the new definition differs from the old is that _the
relation_
| > before(x,y) is unambiguous: the case "before(x,y) && before(y,x)" will no
longer occur.
|
| This is highly dependent on how the before macro is used in actual code.
| There is nothing to suggest that
licitly requires the old definition in order
to work correctly.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
---
diff --git a/include/net/tcp.h b/include/net/tcp.h
index b7d8317..cd8fa0c 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -242,7 +242,7 @@ extern int tcp_memory_pres
| > With the implementation now, the output of before(x,y) is reliable: it
returns true
| > if (and only if) x is indeed `before' y.
|
| Sorry but I don't think you've answered my question.
|
| Let y = (x + 2^31) % 2^32, how is making
|
| before(x, y) == before(y, x) == 0
|
| an
| > previous code had the form (this is copied from 2.6.17-mm1 original):
| >
| >size = 0;
| >sk_for_each(sk2, node, list)
| >if (++size >= best_size_so_far)
| >goto next;
| >
Hi Herbert,
| >> While looking at DCCP sequence numbers, I stumbled over a problem with
| >> the following definition of before in tcp.h:
| >>
| >> static inline int before(__u32 seq1, __u32 seq2)
| >> {
| >> return (__s32)(seq1-seq2) < 0;
| >> }
| >>
| >> Problem: This definit
Hi Dave,
first of all - I take my hat off to such astuteness in the light of a mailing
list with an average of 100 postings per day and a massive throughput of patch
submissions. It is clearly awesome to be able to relate individual changes
in light of such a massive flood of patches.
However, I
Hi David,
many thanks for taking the matter seriously and investigating
it further.
| I went over this patch and analysis a dozen times, because I
| couldn't believe something like this has been broken for
| so long :-)
It gave me some grief too, when I looked at DCCP sequence numbers %-)
RFC
is achieved by testing whether seq2-seq1 > 0 (using signed
32-bit arithmetic).
I attach a patch to codify this. Also the `after' relation is basically
a redefinition of `before', it is now defined as a macro after before.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
-
Quoting David Miller:
| > if (level == SOL_UDP || level == SOL_UDPLITE)
| > - return do_udpv6_setsockopt(sk, level, optname, optval,
optlen);
| > + return udp_lib_setsockopt(sk, level, optname, optval, optlen,
| > + udp_v6_p
}_push_pending_frames,
since for the second argument (struct udp_sock *up) it always holds that
up = udp_sk(sk); where sk is the first function argument.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
---
include/net/udp.h |5 ++
net/ipv4/udp.c| 30 -
net/ipv6/udp.c
ake udp_push_pending_frames static
udp_push_pending_frames is only referenced within
net/ipv4/udp.c and hence can remain static.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
---
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index 227655c..ac613ed 100644
--- a/net/ipv4/udp.c
+++ b
Quoting Andi Kleen:
| On Tuesday 14 November 2006 09:49, Gerrit Renker wrote:
| > [UDP]: Reduce size of shared code
| >
| > This patch reduces size of source code files by moving
| > some of the smaller functions shared by UDP and UDP-Lite
| > into the header file udp_impl.h
Hi David,
please find attached, in two subsequent emails,
the following two patches:
Patch 1/2: UDP-Lite support for IPv4/IPv6 with
consolidated code for UDP and UDP-Lite
processing.
This is the modified UDP-Lite patch, exactly in the requested
format: UDP and UDP-Lite now
[UDP]: Reduce size of shared code
This patch reduces size of source code files by moving
some of the smaller functions shared by UDP and UDP-Lite
into the header file udp_impl.h, and in-lining these.
It is an optimisation and applies on top of the previous
UDP-Lite patch.
Signed-off-by: Gerrit
Quoting Arnaldo Carvalho de Melo:
| On 11/10/06, James Morris <[EMAIL PROTECTED]> wrote:
| > I wonder if this facility can be integrated more generally into the kernel
| > as a kernel hacking option, as this is not the only protocol which people
| > are developing.
| >
|
| See:
|
http://
| > It is not a huge problem to change this, but it will also mean a
non-trivial redesign.
| > With regards to Stephen's email, can you/Stephen please indicate whether
| >
| >(a) configurable or not (CONFIG_IP_UDPLITE)?
| >(b) re-design as separate object file or not?
| >(c) ...
Quoting Stephen Hemminger:
| On Fri, 10 Nov 2006 16:09:20 +
| Gerrit Renker <[EMAIL PROTECTED]> wrote:
|
| > [NET/IPv4]: Support for the UDP-Lite protocol (RFC 3828)
| >
| > This adds support for UDP-Lite to the IPv4 stack, provided as an extension
| > to the e
| > This code is does too much inlining (like existing network code).
| > Should it be made configurable?
|
| It doesn't get built at all if you check his patches :-)
See previous posting.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PR
Quoting David Miller:
|
| I can't apply any of this Gerrit.
|
| What makes net/ipv4/udplite.c get built at all? I see no
| changes to net/ipv4/Makefile, so you must have stuffed up
| the generation of your patches.
This is a misunderstanding: udplite.o will never be built,
it is #included
/statistics support in /proc/net/snmp and /proc/net/udplite
* shared API with extensions for partial checksum coverage
* consolidation of shared code
Signed-off-by: Gerrit Renker <[EMAIL PROTEC
[NET]: UDP-Lite Documentation and basic XFRM/Netfilter support
This provides
* API documentation for UDP-Lite
* basic xfrm support
* basic netfilter support for IPv4 and IPv6 (LOG target)
Signed-off-by: Gerrit Renker <[EMAIL PROTEC
error cases
* consolidation of shared code
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
--
include/net/ipv6.h | 12 +
include/net/transp_v6.h |2
net/ipv6/af_inet6.c | 21 +
tocol to
tcp_v4_conn_request() [ cf. top of tcp_v6_conn_request()]
2) The first argument, `struct sock *sk' of tcp_v{4,6}_init_sequence() is
never used.
Patch has been tested.
Signed-off-by: Gerrit Renker <
Quoting Chris Lalancette:
| Hello,
| I realized that all of the packets that go from the crashing machine to
the netdump server have a zero checksum.
| Assuming that this is just an oversight, attached is a simple patch to
compute the UDP checksum in netpoll_send_udp.
|
| Signed
Someone any ideas regarding the following bug report,
which happened on
* a dual-Pentium-3 server with SMP enabled
* latest davem-2.6 (pulled yesterday)
* nfs-utils 1.0.10
* lock validation turned on
If this is not enough information please point out what
is missing.
--
[UDPv6]: Support for UDP-Litev6 (RFC 3828).
* consolidated with UDP basis
* basic xfrm/netfilter support
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
--
include/net/ipv6.h| 12 +
include/net/transp_v6.h |2
net/ipv6/af_inet6.c
re no further objections or code comments, I propose this for
inclusion in 2.6.20.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
--
Documentation/networking/udplite.txt | 281281 + 0 - 0 !
include/linux/in.h |11 + 0 - 0 !
include/lin
Miscellaneous files to support UDP-Lite, including basic
xfrm and netfilter support.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
---
Documentation/networking/udplite.txt | 291 +++
include/net/xfrm.h |2
net/ipv4/netfilter/ipt
anges.
The v4 side remains the same as before - apart from some re-shuffling
to integrate it with v6.
Before submitting, I have checked compilation on a small bouquet of
different architectures (worked ok, no compile or run problems).
Thanks again,
Gerrit
Signed-off-by: Gerrit Renker &l
This provides consolidated UDP-Lite support over IPv6.
Changes to net/ipv6/udp.c reflect those in net/ipv4/udp.c.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
---
include/net/ipv6.h | 10 +
include/net/transp_v6.h |3
net/ipv6/af_inet6.c |3
net/ipv6/
| > csum_copy_err:
| > - UDP_INC_STATS_BH(UDP_MIB_INERRORS);
| > + UDP_INC_STATS_BH(UDP_MIB_INERRORS, is_udplite);
| > + UDP_DEC_STATS_BH(UDP_MIB_INDATAGRAMS, is_udplite);
|
| I'm not a big fan at all of these "statistic corrections"
| we're starting to place in various spots.
I am not
to add the missing DCCP-specific code, it does seem
better
to replace the dead part with a FIXME. This is done by the patch below, applies
to
davem-net2.6 and has been tested to compile.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
--
ipv6.c | 23 ++-
1 file chan
Stupid me, it should read 4 * 255 = 1020, not 8 * 255; this is
fixed below.
--
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h
index 272e858..adabf3e 100644
--- a/net/dccp/dccp.h
+++ b/net/dccp/dccp.h
@@ -40,12 +40,17 @@ extern void dccp_tw_deschedule(struct in
extern void dccp_time_wait(struct
[DCCP]: current upper limit for option length is 128 bytes;
much less than actually possible. This patch sets a safe upper
bound on option length of 992, under worst-case assumptions.
This patches against the 2.6.19 tree by David.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
---
Quoting Ian McDonald:
| Set initial packet size to defaults as existing code doesn't work
| as set_sockopt occurs after initialisation so dccps_packet_size
| is of no use really.
Please see comments to patch 5/7; rather than setting a default,
ccid3hc{rx,tx}_s should be derived from incoming/out
| This removes DCCP_SOCKOPT_PACKET_SIZE for two reasons:
| * the current code doesn't work
| * tx and rx should be different (introduced in former patch)
Agree that DCCP_SOCKOPT_PACKET_SIZE is redundant, patch looks good and
has been tested.
Acked-by: Gerrit Renker <[EMAIL P
| This creates two new socket options DCCP_SOCKOPT_TX_PACKET_SIZE
| and DCCP_SOCKOPT_RX_PACKET_SIZE. DCCP_SOCKOPT_PACKET_SIZE doesn't
| work and packet size should be set independently on two half
| connections.
I disagree with this solution: it solves one problem by introducing two
new ones:
have done this also. Thank you for checking.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
--
Documentation/networking/dccp.txt |8 +---
include/linux/dccp.h |6 +-
net/dccp/ipv4.c |3 ---
net/dccp/proto.c | 11 +
_UDPLITE_H */
diff --git a/net/ipv4/udplite.c b/net/ipv4/udplite.c
new file mode 100644
index 000..7f6498d
--- /dev/null
+++ b/net/ipv4/udplite.c
@@ -0,0 +1,186 @@
+/*
+ * UDPLITE An implementation of the UDP-Lite protocol (RFC 3828).
+ *
+ * Version: $Id: udplite.c,v 1.24 2006/
Hi David,
please find enclosed for review the proposed changes to integrate UDP-Lite
code with UDP.
Please disregard all earlier patches, I have been putting in more hard work to
consolidate the code further, also with regard to expanding to UDP(-Lite) v6.
(Reductions are drastic: udplite.c is sl
and rejecting packets also
works.
+
+
+ VII) MAINTAINER ADDRESS
+
+ The UDP-Lite patch was developed at
+ University of Aberdeen
+Electronics Research Group
+Department of Engineering
+Fraser Noble Building
+
Basic xfrm and netfilter support for UDP-Lite:
* matching of UDP-Lite packets
* LOG support
* header file support
--
include/net/xfrm.h|2 ++
net/ipv4/netfilter/ipt_LOG.c | 11 ---
net/ipv4/xfrm4_policy.c |1 +
net/ipv6/netfilter/ip6t_LOG.c | 10 ++
Sorry kmail garbled this, clean text below.
- Gerrit
--
diff --git a/net/dccp/Kconfig b/net/dccp/Kconfig
index 859e335..2c345c0 100644
--- a/net/dccp/Kconfig
+++ b/net/dccp/Kconfig
@@ -4,9 +4,9 @@ menu "DCCP Configuration (EXPERIMENTAL)"
config IP_DCCP
tristate "The DCCP Protocol (EXPERI
Informational
RFC, RFC 2923 on 2000-09-22.
All references verified; patches against stable and Torvald's tree.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
--
dccp/Kconfig |4 ++--
dccp/ackvec.c | 12 ++--
dccp/ackvec.h |3 +--
dccp/ccids/Kco
rvice codes can be set
via socket options as before.
This patch has been tested using various client/server configurations
(including listening on multiple service codes) and patches against
Torvalds' tree.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
--
Documentation/networking
Hi,
| if (!sk->sk_filter && skb->ip_summed != CHECKSUM_UNNECESSARY) {
|
| IPv6 doesn't do this, so I think delete condition 'sk->sk_filter' is better.
| Do you think so?
I think the sk->sk_filter is there for a good reason. If you delete it, that
routine
is forced to always compute UDP ch
This has been raised earlier, cf.
http://bugzilla.kernel.org/show_bug.cgi?id=6660
Wei Yongjun wrote:
| When I send a UDP datagrams with checksum error to target, I found that:
| Under IPv6, counter udpInErrors increased, but under IPv4 counter
| udpInDatagrams increased. I lookup into the sour
Hi David,
thank you very much for taking time to revise the code
and for the detailed comments.
| The amount of code duplication is absolutely enormous and
| totally unnecessary.
You are right.
So far I thought it better to keep UDP and UDP-Lite separate but an
intelligent code integration d
Quoting Herbert Xu:
| > case SO_NO_CHECK:
| > - sk->sk_no_check = valbool;
| > + /* UDP-Lite (RFC 3828) mandates checksumming,
| > + * hence user must not enable this option. */
| > + if (
RFC 3828-compliant kernel support for UDP-Lite over IPv4.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: William Stanislaus <[EMAIL PROTECTED]>
---
include/net/xfrm.h |2
net/ipv4/Makefile |1
net/ipv4/af_inet.c | 17
net/ipv4/proc.c| 33 -
net/ip
particular ACKS & NAKS
or application.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: William Stanislaus <[EMAIL PROTECTED]>
---
Documentation/networking/udplite.txt | 334 +++
include/linux/in.h |1
includ
RFC 3828-compliant kernel support for UDP-Lite over IPv6.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: William Stanislaus <[EMAIL PROTECTED]>
---
net/ipv6/Makefile |1
net/ipv6/af_inet6.c |8
net/ipv6/proc.c | 22
net/ipv6/udpli
without error on AMD, i386/i686, SMP (server and
desktop PC). Use CONFIG_IP_UDPLITE=y to enable.
Please CC: any feedback/discussion to [EMAIL PROTECTED]
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: William Stanislaus <[EMAIL PROTECTED]>
---
Documentatio
The IPv4 part of the UDP-Lite extension.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: William Stanislaus <[EMAIL PROTECTED]>
---
core/sock.c|7
ipv4/Makefile |1
ipv4/af_inet.c | 95 +++
ipv4/proc.c| 37 +
ipv4/udpl
The IPv6 part of the UDP-Lite extension.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: William Stanislaus <[EMAIL PROTECTED]>
---
include/net/ipv6.h | 11
include/net/transp_v6.h |4
net/ipv6/Makefile |1
net/ipv6/af_inet6.c | 36 +
net
I would greatly value comments on a suggestion made earlier by Yoshifuji
regarding sharing code between udp.c and udplite.c which I am pursuing.
I reduced diffs between ipv4/udp{,lite}.c to the minimum possible and
performed a line-by-line comparison between udp.c and udplite.c.
Result: out of 4
no complaints.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
---
include/net/snmp.h |2 ++
include/net/udp.h |1 +
net/ipv4/udp.c |1 +
3 files changed, 4 insertions(+)
diff -Nurp a/include/net/snmp.h b/include/net/snmp.h
--- a/include/net/snmp.h2006-06-05
Quoting David Miller:
|
| > Fix: Move the `UDP_INC_STATS_BH(UDP_MIB_INDATAGRAMS)' statement from
| >udp_queue_rcv_skb to udp_recvmsg. Now InDatagrams only counts those
| >datagrams which were really delivered (as per RFC 2013).
| >
|
| Unfortunately this breaks NFS and
Quoting David Miller:
| From: Gerrit Renker <[EMAIL PROTECTED]>
| Date: Thu, 8 Jun 2006 21:09:33 +0100
|
| > That is why I held back regarding the IPv6 port:
|
| It's not like an ipv6 port is such a big pile of work.
|
I see the point and will port to v6 (have asked coll
Quoting James Morris:
| On Thu, 8 Jun 2006, David Miller wrote:
|
| > > Understood. Please, anyone, disregard or un-apply the previous
| > > UDP-Lite patch. A revised patch will be prepared and posted as soon
| > > as testing permits.
| >
| > Nobody is going to integrate your patch anywhe
Quoting Alan Cox:
| Ar Iau, 2006-06-08 am 11:50 +0100, ysgrifennodd Gerrit Renker:
| > + UDP-Lite introduces a new socket type, the SOCK_LDGRAM (note the L) for
| > + lightweight, connection-less services. These are the socket options:
|
| This is not the intended use of the sock
This problem involves MIB counter inaccuracies triggered by
failed UDP checksums.
Problem: ip_local_deliver_finish calls udp_rcv, which calls
udp_queue_rcv_skb.
Unless the sk_filter is set, the checksum of the incoming
UDP datagram is not verified. If there are no othe
101 - 189 of 189 matches
Mail list logo
