Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

Hi John, On 4/12/18 12:02 am, John Crispin wrote: On 03/12/2018 15:00, René van Dorst wrote: Quoting Bjørn Mork : Greg Ungerer writes: The following change helped alot, but I still get some problems under sustained load and some types of port setups. Still trying to figure out what exactly

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

Hi Bjorn, On 3/12/18 9:34 pm, Bjørn Mork wrote: [ fixed Johns address - the openwrt.org email was apparently never restored? ] Greg Ungerer writes: The following change helped alot, but I still get some problems under sustained load and some types of port setups. Still trying to figure out

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

This driver is clearly capable of supporting the mt7621 ethernet ports. No need for the staging driver. Regards Greg Not a big deal, as you can see. There is of course a reason I didn't submit this here yet: It is by no means finished... But it works. And I have both GMACs working with this driver,

Re: [PATCH 3/3] dt-bindings: net: dsa: add new bindings MT7530

Hi Florian, On 1/12/18 3:41 am, Florian Fainelli wrote: Hi Greg, On 11/29/2018 11:57 PM, g...@kernel.org wrote: From: Greg Ungerer Add descriptive entries for the new bindings introduced to support the MT7530 implementation in the MediaTek MT7621 SoC. New bindings added for: mediatek

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

descriptor buffers, so there is enough room in them. And glancing around the driver I don't see it using the MTU to restrict the receive packaet size (though I may be missing it). I have a patchset i will be posting soon to do this automatically. That would be good. Regards Greg

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

that, consider the DSA header as part of the VLAN header. Other vendors, there is no way i've found to get hadware offload of checksumming working. Thanks for the tips, I will try out the master mtu change too. Regards Greg

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

promising. Thanks Greg

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

using the 7621 (and maybe other devices?). The other change required is to set the 7530 MFC register CPU port number and enable bit. Hi Greg, Good to see that more people are working on the MT7621 device [1]. So I added Bjorn to the CC. Nice, thanks for the pointers. I am also working

Re: [PATCH bpf] bpf: Fix integer overflow in queue_stack_map_alloc.

out if it is the case. > The vulnerability is discovered with the assistance of syzkaller. > > Reported-by: Wei Wu > To: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: netdev > Cc: Eric Dumazet > Cc: Greg KH > Signed-off-by: Wei Wu > --- > kernel/bpf/queue_stack_maps

Re: Application of f8b39039cbf2a15f ("net: fs_enet: do not call phy_stop() in interrupts") to 4.9 and 4.14 stable

what initially observed in > 4.9. > > The fix has been in mainline since 4.15 And it was released in 4.9.136 and 4.14.80 already :) thanks, greg k-h

Re: [PATCH stable 4.9 v2 00/29] backport of IP fragmentation fixes

nelli/linux/commits/fragment-stack-v4.9-v2 > > > > > > Changes in v2: > > > > > > - drop "net: sk_buff rbnode reorg" > > > - added original "ip: use rb trees for IP frag queue." commit > > > > Eric, does this look reasonable to you? > > Yes, thanks a lot Florian. Wonderful, all now queued up, thanks! greg k-h

Re: [PATCH stable 4.4 V2 0/6] fix SegmentSmack in stable branch (CVE-2018-5390)

On Wed, Sep 26, 2018 at 10:21:21PM +0200, Greg KH wrote: > On Tue, Sep 25, 2018 at 10:10:15PM +0800, maowenan wrote: > > Hi Greg: > > > > can you review this patch set? > > It is still in the queue, don't worry. It will take some more time to > properly review

Re: [PATCH v3 00/30] backport of IP fragmentation fixes

ested normal IP fragmentation with iperf3 and malicious IP fragments > with fragmentsmack. Under fragmentation attack (700Kpps) the original > 4.14.69 consumes 97% CPU; with this patch it drops to 5%. All now queued up, thanks for doing the backport. greg k-h

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

On Thu, Aug 16, 2018 at 05:24:09PM +0200, Greg KH wrote: > On Thu, Aug 16, 2018 at 02:33:56PM +0200, Michal Kubecek wrote: > > On Thu, Aug 16, 2018 at 08:05:50PM +0800, maowenan wrote: > > > On 2018/8/16 19:39, Michal Kubecek wrote: > > > > > > > >

Re: [PATCH 0/2] staging: Fix some warnings from strncpy()

iles changed, 3 insertions(+), 3 deletions(-) I'm guessing you will send a second set of this patch series, right? This one is now dropped, thanks. greg k-h

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

ngs, you should not be running a 4.4 kernel, use 4.14 or newer please. thanks, greg k-h

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

le > preserving nice performance when using the original segmentsmack > testcase (with increased packet ratio). Ok, for now I've applied Takashi's fix to the 4.4 stable queue and will push out a new 4.4-rc later tonight. Can everyone standardize on that and test and let me know if it does, or does not, fix the reported issues? If not, we can go from there and evaluate this much larger patch series. But let's try the simple thing first. thanks, greg k-h

Re: [PATCH stable 4.4 1/9] Revert "tcp: detect malicious patterns in tcp_collapse_ofo_queue()"

On Thu, Aug 16, 2018 at 09:55:42AM +0800, maowenan wrote: > > > On 2018/8/15 21:18, Greg KH wrote: > > On Wed, Aug 15, 2018 at 09:21:00PM +0800, Mao Wenan wrote: > >> This reverts commit dc6ae4dffd656811dee7151b19545e4cd839d378. > > > > I need a

Re: [PATCH stable 4.4 0/9] fix SegmentSmack (CVE-2018-5390)

On Wed, Aug 15, 2018 at 03:24:32PM +0200, Greg KH wrote: > On Wed, Aug 15, 2018 at 09:20:59PM +0800, Mao Wenan wrote: > > There are five patches to fix CVE-2018-5390 in latest mainline > > branch, but only two patches exist in stable 4.4 and 3.18: > > dc6ae4d tcp: dete

Re: [PATCH stable 4.4 4/9] tcp: use an RB tree for ooo receive queue

On Wed, Aug 15, 2018 at 09:21:03PM +0800, Mao Wenan wrote: > From: Yaogong Wang > > Over the years, TCP BDP has increased by several orders of magnitude, > and some people are considering to reach the 2 Gbytes limit. > > Even with current window scale limit of 14, ~1 Gbytes maps to ~740,000 >

Re: [PATCH stable 4.4 6/9] tcp: avoid collapses in tcp_prune_queue() if possible

licious peers. > > Better not attempt anything before full queue capacity is reached, > forcing attacker to spend lots of resource and allow us to more > easily detect the abuse. > > Signed-off-by: Eric Dumazet > Acked-by: Soheil Hassas Yeganeh > Acked-by: Yuchung Cheng &

Re: [PATCH stable 4.4 5/9] tcp: free batches of packets in tcp_prune_ofo_queue()

3fedda ("tcp: refine tcp_prune_ofo_queue() to not drop all > packets") > Signed-off-by: Eric Dumazet > Reported-by: Juha-Matti Tilli > Acked-by: Yuchung Cheng > Acked-by: Soheil Hassas Yeganeh > Signed-off-by: David S. Miller > Signed-off-by: root root? And commit id? thanks, greg k-h

Re: [PATCH stable 4.4 9/9] tcp: add tcp_ooo_try_coalesce() helper

On Wed, Aug 15, 2018 at 09:21:08PM +0800, Mao Wenan wrote: > From: Eric Dumazet > > In case skb in out_or_order_queue is the result of > multiple skbs coalescing, we would like to get a proper gso_segs > counter tracking, so that future tcp_drop() can report an accurate > number. > > I chose to

Re: [PATCH stable 4.4 0/9] fix SegmentSmack (CVE-2018-5390)

ixed patches in > mainline, > good news is that ksoftirqd is turn to about 20%, which is the same with > mainline now. Thanks for doing this work, I had some questions on the individual patches. Can you address them and resend? thanks, greg k-h

Re: [PATCH stable 4.4 8/9] tcp: call tcp_drop() from tcp_data_queue_ofo()

On Wed, Aug 15, 2018 at 09:21:07PM +0800, Mao Wenan wrote: > From: Eric Dumazet > > In order to be able to give better diagnostics and detect > malicious traffic, we need to have better sk->sk_drops tracking. > > Fixes: 9f5afeae5152 ("tcp: use an RB tree for ooo receive queue") > Signed-off-by:

Re: [PATCH stable 4.4 3/9] tcp: increment sk_drops for dropped rx packets

re of listeners drops. > > Signed-off-by: Eric Dumazet > Signed-off-by: David S. Miller > Signed-off-by: Mao Wenan What is the upstream git commit id for this? thanks, greg k-h

Re: [PATCH stable 4.4 7/9] tcp: detect malicious patterns in tcp_collapse_ofo_queue()

lows, and revert to tcp_prune_ofo_queue() which > will be less expensive. > > In the future, we might add the possibility of terminating flows > that are proven to be malicious. > > Signed-off-by: Eric Dumazet > Acked-by: Soheil Hassas Yeganeh > Signed-off-by: David S. Mil

Re: [PATCH stable 4.4 2/9] Revert "tcp: avoid collapses in tcp_prune_queue() if possible"

On Wed, Aug 15, 2018 at 09:21:01PM +0800, Mao Wenan wrote: > This reverts commit 5fbec4801264cb3279ef6ac9c70bcbe2aaef89d5. > --- Same here for description and signed off by. thanks, greg k-h

Re: [PATCH stable 4.4 1/9] Revert "tcp: detect malicious patterns in tcp_collapse_ofo_queue()"

On Wed, Aug 15, 2018 at 09:21:00PM +0800, Mao Wenan wrote: > This reverts commit dc6ae4dffd656811dee7151b19545e4cd839d378. I need a reason why, and a signed-off-by line :( thanks, greg k-h

Re: [PATCH 4.9-stable] tcp: add tcp_ooo_try_coalesce() helper

On Thu, Aug 09, 2018 at 08:37:13PM +0800, maowenan wrote: > > > On 2018/8/7 21:22, Greg KH wrote: > > On Sat, Aug 04, 2018 at 10:10:00AM +0100, David Woodhouse wrote: > >> From: Eric Dumazet > >> > >> commit 58152ecbbcc6a0ce7fddd5bf5f6ee5

Re: [PATCH 4.9-stable] tcp: add tcp_ooo_try_coalesce() helper

h > Acked-by: Yuchung Cheng > Signed-off-by: David S. Miller > Signed-off-by: David Woodhouse > --- > net/ipv4/tcp_input.c | 23 +-- > 1 file changed, 21 insertions(+), 2 deletions(-) Now applied, thanks, greg k-h

Re: [PATCH 3.18.y] Fix compilation error backporting upstream commit 9fc12023d6f5

0, > + fl4.flowi4_mark = vmark ? skb->mark : 0; > if (!fib_lookup(net, , )) > return FIB_RES_PREFSRC(net, res); > } else { Thanks, but I fixed this about 6 hours ago, right? greg k-h

Re: [PATCH net 0/5] tcp: more robust ooo handling

don't work on the 4.9 -stable backports, so I personally have > no idea. > > I submitted for 4.17 and 4.14 Ok, then it's my fault :) Odds are it did not apply and so I didn't backport it. If you think it should be there, please provide a working backport. thanks, greg k-h

Re: 862591bf4("xfrm: skip policies marked as dead while rehashing")

policies when rebuilding hash tables") > 862591bf4f("xfrm: skip policies marked as dead while rehashing") > > [1] > https://syzkaller.appspot.com/bug?id=1c11a638b7d27e871aa297f3b4d5fd5bc90f0cb4 Both now queued up, thanks. greg k-h

Re: Incomplete fix for be9c798 / 7b2ee50 hv_netvsc: common detach logic?

lower device is being changed. And enabled > only after sub channels are setup. This avoids issue where it could > be that a packet was being sent while subchannel was not initialized. > > Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug") > Sign

Re: [Patch net-next] netdev-FAQ: clarify DaveM's position for stable backports

On Mon, Jun 04, 2018 at 11:07:19AM -0700, Cong Wang wrote: > Per discussion with David at netconf 2018, let's clarify > DaveM's position of handling stable backports in netdev-FAQ. > > This is important for people relying on upstream -stable > releases. > > Cc: sta...@vger.

Re: [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies"

Jason Gunthorpe wrote: On Fri, May 25, 2018 at 05:32:52PM -0700, Greg Thelen wrote: On Fri, May 25, 2018 at 2:32 PM Arnd Bergmann wrote: > Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn depends > on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this

Re: 4.16 issue with mbim modem and ping with size > 14552 bytes

On Mon, May 28, 2018 at 09:58:01AM +0200, Daniele Palmas wrote: > 2018-05-25 0:54 GMT+02:00 Daniele Palmas <dnl...@gmail.com>: > > Hi Greg, > > > > 2018-05-24 17:53 GMT+02:00 Greg KH <gre...@linuxfoundation.org>: > >> On Thu, May 24, 2018 at 05:04:49P

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

On Fri, May 18, 2018 at 11:27:56AM +0200, Florian Westphal wrote: > Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > > On Thu, May 17, 2018 at 12:42:00PM +0200, Jan Engelhardt wrote: > > > > > > On Thursday 2018-05-17 12:09, Greg Kroah-Hartman wrot

Re: [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies"

ib_dealloc_pd' > Fixes: 9533b292a7ac ("IB: remove redundant INFINIBAND kconfig dependencies") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Greg Thelen <gthe...@google.com> Sorry for the 9533b292a7ac problem. At this point the in release cycle, I think A

Re: [PATCH 1/7] core, dma-direct: add a flag 32-bit dma limits

On Fri, May 25, 2018 at 06:23:07PM +0200, Christoph Hellwig wrote: > On Fri, May 25, 2018 at 04:50:12PM +0200, Greg Kroah-Hartman wrote: > > On Fri, May 25, 2018 at 04:35:06PM +0200, Christoph Hellwig wrote: > > > Various PCI bridges (VIA PCI, Xilinx PCIe) limit DMA to only

Re: [PATCH 1/7] core, dma-direct: add a flag 32-bit dma limits

For the patch, no objection from me: Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

Re: 4.16 issue with mbim modem and ping with size > 14552 bytes

properly when tethering my phone through to my laptop. So this might be a network provider issue :) thanks, greg k-h

Re: [V9fs-developer] [PATCH] net/9p: fix error path of p9_virtio_probe

off-by: Jean-Philippe Brucker <jean-philippe.bruc...@arm.com> > --- Reviewed-by: Greg Kurz <gr...@kaod.org> > net/9p/trans_virtio.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c > ind

Re: [PATCH v3 net-next 0/2] bpfilter

On Wed, May 23, 2018 at 01:26:48PM -0400, David Miller wrote: > From: Alexei Starovoitov > Date: Mon, 21 May 2018 19:22:28 -0700 > > > v2->v3: > > - followed Luis's suggestion and significantly simplied first patch > > with shmem_kernel_file_setup+kernel_write. Added kdoc for

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

On Fri, May 18, 2018 at 11:27:56AM +0200, Florian Westphal wrote: > Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > > On Thu, May 17, 2018 at 12:42:00PM +0200, Jan Engelhardt wrote: > > > > > > On Thursday 2018-05-17 12:09, Greg Kroah-Hartman wrot

Re: Request for -stable inclusion: time stamping fix for nfp

On Thu, May 17, 2018 at 08:32:02PM +0200, Willy Tarreau wrote: > Adding Greg here. > > Greg, apparently a backport of 46f1c52e66db is needed in 4.9 according > to the thread below. It was merged in 4.13 so 4.14 already has it. Thanks for the notice, now queued up. greg k-h

Re: [PATCH] net: ethernet: ti: cpsw: fix packet leaking in dual_mac mode

/ti' failed > make[5]: *** [drivers/net/ethernet/ti] Error 2 > Now dropped, it's nice to see I got 3 reports about this :) greg k-h

Re: net: ieee802154: 6lowpan: fix frag reassembly

On Thu, May 17, 2018 at 04:16:20PM +0200, Stefan Schmidt wrote: > Hello Greg. > > On 17.05.2018 10:59, Greg KH wrote: > > On Mon, May 14, 2018 at 05:22:18PM +0200, Stefan Schmidt wrote: > >> Hello. > >> > >> > >> Please apply f18fa5de5ba7f1d6

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

On Thu, May 17, 2018 at 12:42:00PM +0200, Jan Engelhardt wrote: > > On Thursday 2018-05-17 12:09, Greg Kroah-Hartman wrote: > >> > --- a/net/netfilter/x_tables.c > >> > +++ b/net/netfilter/x_tables.c > >> > @@ -1183,11 +1183,10 @@ struct xt_table_info

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

On Thu, May 17, 2018 at 02:55:42AM -0700, Eric Dumazet wrote: > > > On 05/17/2018 02:34 AM, Greg Kroah-Hartman wrote: > > When allocating a xt_table_info structure, we should be clearing out the > > full amount of memory that was allocated, not just the "header" o

[PATCH v2] netfilter: properly initialize xt_table_info structure

When allocating a xt_table_info structure, we should be clearing out the full amount of memory that was allocated, not just the "header" of the structure. Otherwise odd values could be passed to userspace, which is not a good thing. Cc: stable <sta...@vger.kernel.org> Signed-of

Re: [PATCH] netfilter: properly initialize xt_table_info structure

On Thu, May 17, 2018 at 10:59:51AM +0200, Michal Kubecek wrote: > On Thu, May 17, 2018 at 10:44:42AM +0200, Greg Kroah-Hartman wrote: > > When allocating a xt_table_info structure, we should be clearing out the > > full amount of memory that was allocated, not j

Re: net: ieee802154: 6lowpan: fix frag reassembly

v4.17-rc1~148^2~20^2~11 Also, it did not get backported to 4.16.y, so I don't see how it is needed in 4.16-stable. To verify this, I tried applying the patch, and it totally fails to apply to the 4.16.y tree. So are you _sure_ you want/need this in 4.16? If so, can you provide a working backpo

[PATCH] netfilter: properly initialize xt_table_info structure

When allocating a xt_table_info structure, we should be clearing out the full amount of memory that was allocated, not just the "header" of the structure. Otherwise odd values could be passed to userspace, which is not a good thing. Cc: stable <sta...@vger.kernel.org> Signed-of

Re: [PATCH 41/42] tty: replace ->proc_fops with ->proc_show

On Wed, May 16, 2018 at 11:43:45AM +0200, Christoph Hellwig wrote: > Just set up the show callback in the tty_operations, and use > proc_create_single_data to create the file without additional > boilerplace code. > > Signed-off-by: Christoph Hellwig <h...@lst.de> Reviewed-b

Re: [PATCH v4 1/1] drivers core: multi-threading device shutdown

efactor this to be at least 2 patches? One that moves code around to comon functions to make the second patch, that adds the new functionality, easier to review and understand? And I echo the "don't use kerneldoc for static functions" review comment, that's not needed at all. thanks, greg k-h

Re: net: ieee802154: 6lowpan: fix frag reassembly

eue it up later this week in the next release after these go out on Wednesday. thanks, greg k-h

Re: [PATCH v3 0/1] multi-threading device shutdown

nly using one thread. > > Since, nothing else is running on the machine by the device_shutdown() > s called, there is no reason not to utilize all the available CPU > resources. Ah, we can hope so. I bet this is going to break something, so can we have some way of turning it on/off dynamically for when it does? thanks, greg k-h

Re: Please apply 3f1e53abff84c (" netfilter: ebtables: don't attempt to allocate 0-sized compat array") to v4.14.y and later

On Wed, May 09, 2018 at 06:26:29AM -0700, Guenter Roeck wrote: > Hi Greg, > > Commit 3f1e53abff84c fixes commit 7d7d7e02111e9 ("("netfilter: compat: reject > huge > allocation requests"), which has found its way into 4.14.y and 4.16.y. > This causes syzcaller

Re: WARNING in kernfs_add_one

On Sat, May 05, 2018 at 10:43:45AM -0700, Eric Dumazet wrote: > > > On 05/05/2018 09:40 AM, Greg KH wrote: > > On Sat, May 05, 2018 at 08:47:02AM -0700, syzbot wrote: > >> Hello, > >> > >> syzbot found the following crash on: > >> > >

Re: WARNING in kernfs_add_one

RSI: 20b3dfc8 RDI: 0005 > RBP: 7fff808f3e10 R08: 0002 R09: 7fff80003534 > R10: R11: 0246 R12: > R13: 0006 R14: R15: > Dumping ftrace buffer: >(ftrace buffer empty) > Kernel Offset: disabled > Rebooting in 86400 seconds.. Any ideas? thanks, greg k-h

Re: Request for stable 4.14.x inclusion: net: don't call update_pmtu unconditionally

On Tue, May 01, 2018 at 12:15:37AM +0200, Thomas Deutschmann wrote: > Hi, > > On 2018-04-30 20:22, Greg KH wrote: > > The geneve hunk doesn't apply at all to the 4.14.y tree, so I think > > someone has a messed up tree somewhere... > > > > I'll go look into this

Re: Request for stable 4.14.x inclusion: net: don't call update_pmtu unconditionally

On Fri, Apr 27, 2018 at 07:43:52PM +0100, Eddie Chapman wrote: > On 27/04/18 19:07, Thomas Deutschmann wrote: > > Hi Greg, > > > > first, we need to cherry-pick another patch first: > > > From 52a589d51f1008f62569bf89e95b26221ee76690 Mon Sep 17 00:00:00 200

Re: Request for stable 4.14.x inclusion: net: don't call update_pmtu unconditionally

On Fri, Apr 27, 2018 at 07:43:52PM +0100, Eddie Chapman wrote: > On 27/04/18 19:07, Thomas Deutschmann wrote: > > Hi Greg, > > > > first, we need to cherry-pick another patch first: > > > From 52a589d51f1008f62569bf89e95b26221ee76690 Mon Sep 17 00:00:00 200

Re: Request for stable 4.14.x inclusion: net: don't call update_pmtu unconditionally

On Fri, Apr 27, 2018 at 03:51:25PM +0200, Greg KH wrote: > On Fri, Apr 27, 2018 at 02:20:07PM +0200, Thomas Deutschmann wrote: > > On 2018-04-22 23:50, Thomas Deutschmann wrote: > > > Hi, > > > > > > please add > > > > > >> From f15ca723

Re: Request for stable 4.14.x inclusion: net: don't call update_pmtu unconditionally

net> > > > > to 4.14.x. > > > > This fixes NULL derefs caused by a93bf0ff4490 ("vxlan: update > > skb dst pmtu on tx path"), which was backported to 4.14.24. > > *ping* - Not yet applied and not yet queued. Is there a problem with the > patch which prevents a cherry-pick for 4.14.x? This looks like an "obvious" fix for me to pick up. Dave, any objections for me just grabbing it as-is? thanks, greg k-h

Re: [PATCH stable v4.4+] r8152: add Linksys USB3GIGV1 id

sys > > Signed-off-by: Grant Grundler <grund...@chromium.org> > Reviewed-by: Douglas Anderson <diand...@chromium.org> > Signed-off-by: David S. Miller <da...@davemloft.net> > [krzk: Rebase on v4.4] Also added to 4.9.y, thanks. greg k-h

Re: [PATCH 09/15] net: irda: pxaficp_ir: remove the dmaengine compat need

This file is no longer in Linus's tree :) thanks, greg k-h

Re: [PATCH net-next v4 1/3] vmcore: add API to collect hardware dump in second kernel

d as ELF notes to /proc/vmcore Which exact "device drivers" are you referring to here? thanks, greg k-h

[PATCH 4.4 004/190] x86/asm: Dont use RBP as a temporary register in csum_partial_copy_generic()

lad Yasevich <vyasev...@gmail.com> Cc: linux-s...@vger.kernel.org Cc: netdev <netdev@vger.kernel.org> Cc: syzkaller <syzkal...@googlegroups.com> Link: http://lkml.kernel.org/r/4b03a961efda5ec9bfe46b7b9c9ad72d1efad343.1493909486.git.jpoim...@redhat.com Signed-off-by: Ingo Molnar &

[PATCH 4.9 005/310] x86/asm: Dont use RBP as a temporary register in csum_partial_copy_generic()

lad Yasevich <vyasev...@gmail.com> Cc: linux-s...@vger.kernel.org Cc: netdev <netdev@vger.kernel.org> Cc: syzkaller <syzkal...@googlegroups.com> Link: http://lkml.kernel.org/r/4b03a961efda5ec9bfe46b7b9c9ad72d1efad343.1493909486.git.jpoim...@redhat.com Signed-off-by: Ingo Molnar &

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

On Wed, Apr 11, 2018 at 04:11:00PM +0800, Jia-Ju Bai wrote: > > > On 2018/4/11 16:03, Greg KH wrote: > > On Wed, Apr 11, 2018 at 03:17:10PM +0800, Jia-Ju Bai wrote: > > > > > > On 2018/4/11 14:41, Greg KH wrote: > > > > On Wed, Apr 1

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

On Wed, Apr 11, 2018 at 03:17:10PM +0800, Jia-Ju Bai wrote: > > > On 2018/4/11 14:41, Greg KH wrote: > > On Wed, Apr 11, 2018 at 09:29:34AM +0800, Jia-Ju Bai wrote: > > > stir421x_fw_upload() is never called in atomic context. > > > > > > The

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

1 insertion(+), 1 deletion(-) Please, at the very least, work off of Linus's tree. There is no drivers/staging/irda/ anymore :) thanks, greg k-h

Re: [PATCH] Patch to replace DEFINE_SEMAPHORE with DEFINE_BINARY_SEMAPHORE

e kernel, sorry. email is now deleted. greg k-h

Re: [PATCH] net: fec: set dma_coherent_mask

iver and the system continue to function normally. As per the warning the coherent_dma_mask is not set on this device. There is nothing special about the DMA memory coherency on this hardware so we can just set the mask to 32bits in the platform data for the FEC ethernet devices. Signed-off-by: Greg

Re: [PATCH] net: fec: set dma_coherent_mask

Hi Geert, On 27/03/18 22:59, Geert Uytterhoeven wrote: > On Mon, Mar 26, 2018 at 3:36 PM, Greg Ungerer <g...@linux-m68k.org> wrote: >> As of commit 205e1b7f51e4 ("dma-mapping: warn when there is no >> coherent_dma_mask") the Freescale FEC driver is issuing the

[PATCH] net: fec: set dma_coherent_mask

g special about the DMA memory coherency on this hardware so we can just set the mask to 32bits during probe. Signed-off-by: Greg Ungerer <g...@linux-m68k.org> --- drivers/net/ethernet/freescale/fec_main.c | 2 ++ 1 file changed, 2 insertions(+) Is this the best way to handle this problem? Comments

[PATCH 4.9 015/177] time: Change posix clocks ops interfaces to use timespec64

Cc: Richard Cochran <richardcoch...@gmail.com> Cc: john.stu...@linaro.org Link: http://lkml.kernel.org/r/1490555058-4603-3-git-send-email-deepa.ker...@gmail.com Signed-off-by: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Sasha Levin <alexander.le...@microsoft.com> Signed-o

[PATCH 4.4 11/97] time: Change posix clocks ops interfaces to use timespec64

Cc: Richard Cochran <richardcoch...@gmail.com> Cc: john.stu...@linaro.org Link: http://lkml.kernel.org/r/1490555058-4603-3-git-send-email-deepa.ker...@gmail.com Signed-off-by: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Sasha Levin <alexander.le...@microsoft.com> Signed-o

Re: [net-next] intel: add SPDX identifiers to all the Intel drivers

out stuff like that, please talk to your corporate lawyers, they will be glad to talk to you all about what defines "copyright" :) thanks, greg "I talk to too many lawyers..." k-h

Re: [PATCH 12/28] net: convert datagram_poll users tp ->poll_mask

aging/irda/net/af_irda.c | 6 +++--- irda is now gone in linux-next, but that's an easy thing to handle when merging. Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

Re: [PATCH 28/28] random: convert to ->poll_mask

nged, 15 insertions(+), 12 deletions(-) Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

Re: [PATCH 06/28] aio: implement IOCB_CMD_POLL

eff Moyer <jmo...@redhat.com> Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

Re: [PATCH 05/28] fs: introduce new ->get_poll_head and ->poll_mask methods

h Hellwig <h...@lst.de> Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

Re: [PATCH 03/28] fs: update documentation to mention __poll_t

On Wed, Mar 21, 2018 at 08:40:07AM +0100, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

Re: [PATCH 04/28] fs: add new vfs_poll and file_can_poll helpers

On Wed, Mar 21, 2018 at 08:40:08AM +0100, Christoph Hellwig wrote: > These abstract out calls to the poll method in preparation for changes > in how we poll. Yeah!!! > > Signed-off-by: Christoph Hellwig <h...@lst.de> > Reviewed-by: Darrick J. Wong <darrick.w...@oracle

Re: [PATCH 02/28] fs: cleanup do_pollfd

. Wong <darrick.w...@oracle.com> Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

Re: [PATCH 01/28] fs: unexport poll_schedule_timeout

On Wed, Mar 21, 2018 at 08:40:05AM +0100, Christoph Hellwig wrote: > No users outside of select.c. > > Signed-off-by: Christoph Hellwig <h...@lst.de> > Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

[PATCH 3.18 34/68] MIPS: BPF: Quit clobbering callee saved registers in JIT code.

s.org> Signed-off-by: Sasha Levin <alexander.le...@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- arch/mips/net/bpf_jit.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) --- a/arch/mips/net/bpf_jit.c +++ b/arch/mi

[PATCH 4.4 062/134] MIPS: BPF: Quit clobbering callee saved registers in JIT code.

s.org> Signed-off-by: Sasha Levin <alexander.le...@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- arch/mips/net/bpf_jit.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) --- a/arch/mips/net/bpf_jit.c +++ b/arch/mi

[PATCH 4.4 063/134] MIPS: BPF: Fix multiple problems in JIT skb access helpers.

: linux-m...@linux-mips.org Cc: netdev@vger.kernel.org Cc: linux-ker...@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/15747/ Signed-off-by: Ralf Baechle <r...@linux-mips.org> Signed-off-by: Sasha Levin <alexander.le...@microsoft.com> Signed-off-by: Greg Kroah-Hartman &

[PATCH 4.9 129/241] MIPS: BPF: Quit clobbering callee saved registers in JIT code.

s.org> Signed-off-by: Sasha Levin <alexander.le...@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- arch/mips/net/bpf_jit.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) --- a/arch/mips/net/bpf_jit.c +++ b/arch/mi

[PATCH 4.9 130/241] MIPS: BPF: Fix multiple problems in JIT skb access helpers.

: linux-m...@linux-mips.org Cc: netdev@vger.kernel.org Cc: linux-ker...@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/15747/ Signed-off-by: Ralf Baechle <r...@linux-mips.org> Signed-off-by: Sasha Levin <alexander.le...@microsoft.com> Signed-off-by: Greg Kroah-Hartman &

Re: [PATCH] ncpfs: memory corruption in ncp_read_kernel()

el.c > +++ b/drivers/staging/ncpfs/ncplib_kernel.c Ugh, I have like 2 more months before I delete this code :) Anyway, nice find, and fix, I'll go queue it up now, thanks. greg k-h

Re: [PATCH v2 1/2] sysfs: symlink: export sysfs_create_link_nowarn()

inelli <f.faine...@gmail.com> > Cc: Andrew Lunn <and...@lunn.ch> > Fixes: a3995460491d ("net: phy: Relax error checking on sysfs_create_link()") This specific patch doesn't fix anything, it just _allows_ it to be fixed in the second patch :) Anyway, just

Re: [PATCH 2/2] net: phy: relax error checking when creating sysfs link netdev->phydev

> + /* non-fatal - some net drivers can use one netdevice > + * with more then one phy > + */ What about devices that do not have more than one phy and this call fails for? Shouldn't you check for that? thanks, greg k-h

Re: [PATCH 46/47] staging: irda: remove bfin_sir driver

lete mode 100644 drivers/staging/irda/drivers/bfin_sir.h I just deleted all of drivers/staging/irda/ earlier today :) thanks, greg k-h

Re: [PATCH v5 1/6] staging: fsl-dpaa2/ethsw: Add APIs for DPSW object

se the correct SPDX identifiers for all of the new files, instead of all of this horrid boiler-plate code? That will save me time when I have to go delete all of this in the near future :) Also, why dual license it? Are you _SURE_ you want to do that, and are totally aware of all of the crazy issues surrounding it? Hint, it almost never means what you might think it does, and I have yet to know of anyone doing anything "real" with any dual-licensed Linux kernel code. Remember, BSD is not the license you want/need for GPL header files that are exposed to userspace... thanks, greg k-h

  1   2   3   4   5   6   7   >