Re: [PATCH net v3] net/sched: cbs: Fix not adding cbs instance to list

2019-09-24 Thread Guedes, Andre
Hi Vinicius, > On Sep 23, 2019, at 10:04 PM, Vinicius Costa Gomes > wrote: > > The problem happens because that when offloading is enabled, the cbs > instance is not added to the list. > > Also, the current code doesn't handle correctly the case when offload > is disabled without removing the

Re: [PATCH 3/5] net: sched: taprio: Fix null pointer deref bug

2019-04-23 Thread Guedes, Andre
> On Apr 22, 2019, at 12:36 PM, Cong Wang wrote: > > On Mon, Apr 22, 2019 at 12:24 PM Guedes, Andre wrote: >> >> >>> On Apr 22, 2019, at 11:07 AM, Cong Wang wrote: >>> >>> On Mon, Apr 22, 2019 at 11:04 AM Cong Wang wrote: >>

Re: [PATCH 3/5] net: sched: taprio: Fix null pointer deref bug

2019-04-22 Thread Guedes, Andre
> On Apr 22, 2019, at 11:07 AM, Cong Wang wrote: > > On Mon, Apr 22, 2019 at 11:04 AM Cong Wang wrote: >> >> On Fri, Apr 19, 2019 at 6:06 PM Andre Guedes wrote: >>> >>> If 'entry' is NULL we WARN_ON() but dereference the pointer anyway, >>> generating a null pointer dereference bug. This pa

Re: [PATCH 0/5] Taprio qdisc fixes

2019-04-22 Thread Guedes, Andre
Hi David, > On Apr 20, 2019, at 8:46 PM, David Miller wrote: > > From: Andre Guedes > Date: Fri, 19 Apr 2019 17:00:47 -0700 > >> This series contains some minor improvements (patches 1 and 2) and >> fixes (patches 3-5) to taprio qdisc. > > This series does not apply cleanly at all to the net

Re: [next-queue PATCH v8 0/6] TSN: Add qdisc based config interface for CBS

2017-10-16 Thread Guedes, Andre
+Jeff Since this patchset also touches the IGB driver, Jeff suggested we merged it into his tree and he'd make a pull-request to your net-next tree. @Jeff, are we moving with this approach or should David apply the patchset to his net-next tree directly? Thanks, Andre On Mon, 2017-10-16 at 20:

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-10-02 Thread Guedes, Andre
Hi all, On Mon, 2017-10-02 at 12:45 -0600, Levi Pearson wrote: > Hi Rodney, > > Some archives seem to have threaded it, but I have CC'd the > participants I saw in the original discussion thread since they may > not otherwise notice it amongst the normal traffic. > > On Fri, Sep 29, 2017 at 2:44

Re: [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-27 Thread Guedes, Andre
On Wed, 2017-09-27 at 15:57 -0700, Jesus Sanchez-Palencia wrote: > Hi, > > > On 09/27/2017 02:14 PM, Vinicius Costa Gomes wrote: > > Hi, > > > > Cong Wang writes: > > > > > On Tue, Sep 26, 2017 at 4:39 PM, Vinicius Costa Gomes > > > wrote: > > > > +static int cbs_init(struct Qdisc *sch, struc

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-07 Thread Guedes, Andre
On Thu, 2017-09-07 at 18:18 +0200, Henrik Austad wrote: > On Thu, Sep 07, 2017 at 05:53:15PM +0200, Richard Cochran wrote: > > On Thu, Sep 07, 2017 at 05:27:51PM +0200, Henrik Austad wrote: > > > On Thu, Sep 07, 2017 at 02:40:18PM +0200, Richard Cochran wrote: > > > And if you want to this driver t

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-07 Thread Guedes, Andre
Hi Henrik, Thanks for your feedback! I'll address some of your comments below. On Thu, 2017-09-07 at 07:34 +0200, Henrik Austad wrote: > > As for the shapers config interface: > > > >  * CBS (802.1Qav) > > > >    This patchset is proposing a new qdisc called 'cbs'. Its 'tc' cmd line > > is: > >