Re: [PATCH] pktgen: fix error message with wrong function name

2020-09-01 Thread Gustavo A. R. Silva
ode()") Acked-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > net/core/pktgen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/pktgen.c b/net/core/pktgen.c > index 95f4c6b8f51a..44fdbb9c6e53 100644 > --- a/net/core/pktgen.c >

Re: [PATCH][next] atmel: Use fallthrough pseudo-keyword

2020-08-27 Thread Gustavo A. R. Silva
On Thu, Aug 27, 2020 at 01:09:33PM +, Kalle Valo wrote: > "Gustavo A. R. Silva" wrote: > > > Replace the existing /* fall through */ comments and its variants with > > the new pseudo-keyword macro fallthrough[1]. > > > > [1] > > https://www.ke

Re: [PATCH v2 2/4] brcmfmac: drop unnecessary "fallthrough" comments

2020-08-26 Thread Gustavo A. R. Silva
Hi, There is a patch that address this, already: https://lore.kernel.org/lkml/20200821063758.GA17783@embeddedor/ Thanks -- Gustavo On 8/27/20 01:04, Dmitry Osipenko wrote: > There is no need to insert the "fallthrough" comment if there is nothing > in-between of case switches. Hence let's remov

[PATCH][next] atmel: Use fallthrough pseudo-keyword

2020-08-20 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net

[PATCH][next] carl9170: Use fallthrough pseudo-keyword

2020-08-20 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net

[PATCH][next] rtw88: Use fallthrough pseudo-keyword

2020-08-20 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net

[PATCH][next] mwifiex: Use fallthrough pseudo-keyword

2020-08-20 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net

[PATCH][next] b43legacy: Use fallthrough pseudo-keyword

2020-08-20 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net

[PATCH][next] b43: Use fallthrough pseudo-keyword

2020-08-20 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net

[PATCH][next] iwlegacy: Use fallthrough pseudo-keyword

2020-08-20 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net

[PATCH][next] brcmfmac: Use fallthrough pseudo-keyword

2020-08-20 Thread Gustavo A. R. Silva
-through Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 -- .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 8 drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c | 2 +- drivers/net/wireless/broadcom/brcm80211

[PATCH][next] orinoco: Use fallthrough pseudo-keyword

2020-08-20 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net

[PATCH][next] prism54: Use fallthrough pseudo-keyword

2020-08-20 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net

[PATCH][next] rt2x00: Use fallthrough pseudo-keyword

2020-08-20 Thread Gustavo A. R. Silva
-through Signed-off-by: Gustavo A. R. Silva --- .../net/wireless/ralink/rt2x00/rt2400pci.c| 2 +- .../net/wireless/ralink/rt2x00/rt2500pci.c| 2 +- .../net/wireless/ralink/rt2x00/rt2800lib.c| 42 +-- .../net/wireless/ralink/rt2x00/rt2800mmio.c | 1 - .../net

[PATCH][next] rtlwifi: Use fallthrough pseudo-keyword

2020-08-20 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net

[PATCH][next] iwlwifi: Use fallthrough pseudo-keyword

2020-08-20 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net

[PATCH][next] mediatek: Use fallthrough pseudo-keyword

2020-08-20 Thread Gustavo A. R. Silva
-through Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/mediatek/mt76/mt7603/dma.c | 2 +- drivers/net/wireless/mediatek/mt76/mt7603/mac.c | 4 ++-- drivers/net/wireless/mediatek/mt76/mt7615/mac.c | 6 +++--- drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 2

Re: [PATCH net-next] net/mlx5: remove erroneous fallthrough

2020-08-03 Thread Gustavo A. R. Silva
et_sset_count() warn: ignoring unreachable code. > > Signed-off-by: Dan Carpenter Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethe

Re: [PATCH][next] net/sched: cls_u32: Use struct_size() helper

2020-07-31 Thread Gustavo A. R. Silva
On 7/31/20 18:50, David Miller wrote: > From: "Gustavo A. R. Silva" > Date: Thu, 30 Jul 2020 11:03:14 -0500 > >> Make use of the struct_size() helper, in multiple places, instead >> of an open-coded version in order to avoid any potential type >> mistakes

[PATCH][next] vhost: Use flex_array_size() helper in copy_from_user()

2020-07-31 Thread Gustavo A. R. Silva
. Signed-off-by: Gustavo A. R. Silva --- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 74d135ee7e26..1a22a254abe4 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -1405,7 +1405,7 @@ static

[PATCH][next] net/sched: cls_u32: Use struct_size() helper

2020-07-30 Thread Gustavo A. R. Silva
Make use of the struct_size() helper, in multiple places, instead of an open-coded version in order to avoid any potential type mistakes and protect against potential integer overflows. Also, remove unnecessary object identifier size. Signed-off-by: Gustavo A. R. Silva --- net/sched/cls_u32.c

Re: [PATCH][next] mlxsw: spectrum_cnt: Use flex_array_size() helper in memcpy()

2020-07-30 Thread Gustavo A. R. Silva
On 7/30/20 04:21, Ido Schimmel wrote: > On Wed, Jul 29, 2020 at 05:58:03PM -0500, Gustavo A. R. Silva wrote: >> Make use of the flex_array_size() helper to calculate the size of a >> flexible array member within an enclosing structure. >> >> This helper offers defense

[PATCH][next] net/sched: act_pedit: Use flex_array_size() helper in memcpy()

2020-07-29 Thread Gustavo A. R. Silva
. Signed-off-by: Gustavo A. R. Silva --- net/sched/act_pedit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c index 66986db062ed..c158bfed86d5 100644 --- a/net/sched/act_pedit.c +++ b/net/sched/act_pedit.c @@ -436,8 +436,7 @@ static

[PATCH][next] mlxsw: spectrum_cnt: Use flex_array_size() helper in memcpy()

2020-07-29 Thread Gustavo A. R. Silva
, remove unnecessary pointer identifier sub_pool. Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/mellanox/mlxsw/spectrum_cnt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_cnt.c b/drivers/net/ethernet/mellanox

[PATCH][next] dmaengine: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
-through Signed-off-by: Gustavo A. R. Silva --- drivers/dma/amba-pl08x.c| 10 +- drivers/dma/fsldma.c| 2 +- drivers/dma/imx-dma.c | 2 +- drivers/dma/iop-adma.h | 12 ++-- drivers/dma/nbpfaxi.c | 2 +- drivers/dma/pl330.c | 10

[PATCH][next] ath6kl: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net

[PATCH][next] ath5k: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net

[PATCH][next] ath11k: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
-through Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/ath11k/core.c | 2 +- drivers/net/wireless/ath/ath11k/dp.c| 2 +- drivers/net/wireless/ath/ath11k/dp_rx.c | 3 +-- drivers/net/wireless/ath/ath11k/mac.c | 22 +++--- 4 files changed, 14 insertions

[PATCH][next] ath10k: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
-through Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/ath10k/core.c | 2 +- drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +- drivers/net/wireless/ath/ath10k/htt_tx.c | 6 +++--- drivers/net/wireless/ath/ath10k/mac.c| 18 +- drivers/net/wireless/ath

[PATCH][next] ath9k: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net

[PATCH][next] staging: qlge: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/staging

[PATCH][next] net/mlx5: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
-through Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 ++-- .../net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c| 2 +- drivers/net/ethernet/mellanox/mlx5/core

[PATCH][next] net/mlx4: Use fallthrough pseudo-keyword

2020-07-27 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net

Re: [PATCH][next] wil6210: Avoid the use of one-element array

2020-07-24 Thread Gustavo A. R. Silva
On 7/23/20 01:43, Kalle Valo wrote: > "Gustavo A. R. Silva" writes: > >> Friendly ping: who can take this? :) > > I'll take this if it's ok. I have been just busy due to vacation period. > Thanks, Kalle. :) -- Gustavo

Re: [PATCH][next] net: qed_hsi.h: Avoid the use of one-element array

2020-07-22 Thread Gustavo A. R. Silva
On 7/22/20 20:13, David Miller wrote: > From: "Gustavo A. R. Silva" > Date: Wed, 22 Jul 2020 13:58:52 -0500 > >> One-element arrays are being deprecated[1]. Replace the one-element >> array with a simple value type '__le32 reserved1'[2], once i

Re: [PATCH][next] wil6210: Avoid the use of one-element array

2020-07-22 Thread Gustavo A. R. Silva
On 7/22/20 14:40, Johannes Berg wrote: > On Wed, 2020-07-15 at 16:57 -0500, Gustavo A. R. Silva wrote: >> One-element arrays are being deprecated[1]. Replace the one-element >> array with a simple value type 'u8 reserved'[2], once this is just >> a placeholder

[PATCH][next] net: qed_hsi.h: Avoid the use of one-element array

2020-07-22 Thread Gustavo A. R. Silva
test robot Link: https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/qed_hsi-20200718.md Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/qlogic/qed/qed_hsi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qe

Re: [PATCH][next] wil6210: Avoid the use of one-element array

2020-07-22 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this? :) Thanks -- Gustavo On 7/15/20 16:57, Gustavo A. R. Silva wrote: > One-element arrays are being deprecated[1]. Replace the one-element > array with a simple value type 'u8 reserved'[2], once this is just > a placeholder for alignm

[PATCH][next] bna: bfi.h: Avoid the use of one-element array

2020-07-22 Thread Gustavo A. R. Silva
obot Link: https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/bfi-20200718.md Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/brocade/bna/bfi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/brocade/bna/bfi.h b/drivers/ne

[PATCH][next] tg3: Avoid the use of one-element array

2020-07-22 Thread Gustavo A. R. Silva
test robot Link: https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/tg3-20200718.md Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/broadcom/tg3.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/tg3.h b/drivers/ne

[PATCH][next] wil6210: Avoid the use of one-element array

2020-07-15 Thread Gustavo A. R. Silva
nk: https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/wil6210-20200715.md Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/wil6210/wmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/wil6210/wmi.h b/drivers/net/wi

[PATCH] Bluetooth: RFCOMM: Use fallthrough pseudo-keyword

2020-07-08 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- net/bluetooth

[PATCH] Bluetooth: core: Use fallthrough pseudo-keyword

2020-07-08 Thread Gustavo A. R. Silva
-fall-through Signed-off-by: Gustavo A. R. Silva --- net/bluetooth/hci_event.c | 4 ++-- net/bluetooth/hci_sock.c | 3 +-- net/bluetooth/l2cap_core.c | 19 +-- net/bluetooth/l2cap_sock.c | 4 ++-- net/bluetooth/mgmt.c | 4 ++-- net/bluetooth/smp.c| 2 +- 6 files

[PATCH v2][next] netfilter: Use fallthrough pseudo-keyword

2020-07-08 Thread Gustavo A. R. Silva
-fall-through Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Update subject line. - Remove unnecessary comments. net/bridge/netfilter/ebtables.c | 2 +- net/netfilter/ipset/ip_set_core.c | 2 +- net/netfilter/nf_conntrack_h323_asn1.c | 6 +++--- net/netfilter

Re: [PATCH][next] Bluetooth: Use fallthrough pseudo-keyword

2020-07-08 Thread Gustavo A. R. Silva
is the case. > > > > [1] > > https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > > > Signed-off-by: Gustavo A. R. Silva > > --- > > drivers/bluetooth/bcm203x.c | 2 +- > > drivers/

Re: [PATCH][next] netfilter: nf_tables: Use fallthrough pseudo-keyword

2020-07-08 Thread Gustavo A. R. Silva
On Wed, Jul 08, 2020 at 06:09:31PM +0200, Pablo Neira Ayuso wrote: > On Tue, Jul 07, 2020 at 02:47:17PM -0500, Gustavo A. R. Silva wrote: > > Replace the existing /* fall through */ comments and its variants with > > the new pseudo-keyword macro fallthrough[1]. Also, remove unnec

Re: [PATCH][next] net/sched: Use fallthrough pseudo-keyword

2020-07-08 Thread Gustavo A. R. Silva
On Tue, Jul 07, 2020 at 03:48:05PM -0700, David Miller wrote: > From: "Gustavo A. R. Silva" > Date: Tue, 7 Jul 2020 12:21:38 -0500 > > > Replace the existing /* fall through */ comments and its variants with > > the new pseudo-keyword macro fallthrough[1]. Al

[PATCH][next] iwlwifi: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/intel/iwlwifi/dvm/mac80211.c |2 +- drivers/net/wireless/intel/iwlwifi/dvm/rx.c |6 +++--- drivers/net/wireless/intel/iwlwifi/dvm/scan.c |2 +- drivers/net/wireless/intel/iwlwifi/dvm/sta.c |2

[PATCH][next] mac80211: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/mac80211_hwsim.c |2 +- net/mac80211/cfg.c|6 +++--- net/mac80211/chan.c |2 +- net/mac80211/ht.c |4 ++-- net/mac80211/ibss.c |4

[PATCH] mt76: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/mediatek/mt76/mt7603/dma.c |2 +- drivers/net/wireless/mediatek/mt76/mt7603/mac.c |4 ++-- drivers/net/wireless/mediatek/mt76/mt7615/mac.c |6 +++--- drivers/net/wireless/mediatek/mt76/mt7615/mcu.c |2

[PATCH][next] Bluetooth: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/bluetooth/bcm203x.c | 2 +- drivers/bluetooth/bluecard_cs.c | 2 -- drivers/bluetooth/hci_ll.c | 2 +- drivers/bluetooth/hci_qca.c | 8 +--- net/bluetooth/hci_event.c | 4 ++-- net/bluetooth/hci_sock.c

[PATCH][next] netfilter: nf_tables: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
-fall-through Signed-off-by: Gustavo A. R. Silva --- net/bridge/netfilter/ebtables.c |2 +- net/netfilter/ipset/ip_set_core.c |2 +- net/netfilter/nf_conntrack_h323_asn1.c |6 +++--- net/netfilter/nf_conntrack_proto.c |2 +- net/netfilter/nf_conntrack_proto_tcp.c

[PATCH][next] net/sched: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
-fall-through Signed-off-by: Gustavo A. R. Silva --- net/sched/act_csum.c |3 ++- net/sched/act_ct.c |2 +- net/sched/sch_cbq.c |2 +- net/sched/sch_drr.c |2 +- net/sched/sch_ets.c |2 +- net/sched/sch_fq_codel.c |2 +- net/sched/sch_fq_pie.c

[PATCH][next] net: ipv6: Use struct_size() helper and kcalloc()

2020-06-22 Thread Gustavo A. R. Silva
the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva --- include/net/rpl.h | 6 -- net/ipv6/exthdrs.c | 2 +- net/ipv6/rpl_iptunnel.c | 3 +-- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/include/net/rpl.h b/include/net/rpl.h

[PATCH][next] net: dsa: sja1105: Use struct_size() in kzalloc()

2020-06-19 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83 Signed-off-by: Gustavo A. R. Silva

[PATCH][next] cxgb4: Use struct_size() helper

2020-06-19 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83 Signed-off-by: Gustavo A. R. Silva

[PATCH][next] ice: Use struct_size() helper

2020-06-19 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83 Signed-off-by: Gustavo A. R. Silva

[PATCH][next] net: stmmac: selftests: Use struct_size() in kzalloc()

2020-06-19 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83 Signed-off-by: Gustavo A. R. Silva

[PATCH][next] ethernet: ti: am65-cpsw-qos: Use struct_size() in devm_kzalloc()

2020-06-19 Thread Gustavo A. R. Silva
/issues/83 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/ti/am65-cpsw-qos.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/ti/am65-cpsw-qos.c b/drivers/net/ethernet/ti/am65-cpsw-qos.c index 32eac04468bb..3bdd4dbcd2ff 100644 --- a/drivers

[PATCH][next] net/sched: cls_u32: Use struct_size() in kzalloc()

2020-06-18 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva --- net/sched/cls_u32.c | 4 +--- 1 file changed, 1

[PATCH][next] taprio: Use struct_size() in kzalloc()

2020-06-18 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. Also, remove unnecessary variable _size_. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva --- net/sched

[PATCH][next] tipc: Use struct_size() helper

2020-06-18 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva --- net/tipc/link.c | 8 net/tipc/msg.h | 6

[PATCH][next] mISDN: hfcsusb: Use struct_size() helper

2020-06-17 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva --- drivers/isdn/hardware/mISDN/hfcsusb.c | 3 +-- 1 file

[PATCH][next] enetc: Use struct_size() helper in kzalloc()

2020-06-17 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/freescale/enetc/enetc.c | 6

[PATCH][next] net: stmmac: selftests: Use struct_size() helper in kzalloc()

2020-06-16 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c

[PATCH][next] ath10k: wmi: Use struct_size() helper in ath10k_wmi_alloc_skb()

2020-06-16 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. Also, remove unnecessary variable _len_. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva --- drivers/net

[PATCH][next] ethtool: ioctl: Use array_size() in copy_to_user()

2020-06-15 Thread Gustavo A. R. Silva
Signed-off-by: Gustavo A. R. Silva --- net/ethtool/ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c index b5df90c981c2..be3ed24bfe03 100644 --- a/net/ethtool/ioctl.c +++ b/net/ethtool/ioctl.c @@ -1918,7 +1918,7 @@ static int

[PATCH] liquidio: Replace vmalloc_node + memset with vzalloc_node and use array_size

2020-06-15 Thread Gustavo A. R. Silva
Coccinelle and, audited and fixed manually. Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/cavium/liquidio/request_manager.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/cavium

[PATCH net-next v3] ice: Replace one-element arrays with flexible-arrays

2020-05-27 Thread Gustavo A. R. Silva
x undefined behaviour") Signed-off-by: Gustavo A. R. Silva --- Changes in v3: - We still can simply the code even more by using offsetof() just once. :) Changes in v2: - Use offsetof(struct ice_aqc_sw_rules_elem, pdata) instead of sizeof(struct ice_aqc_sw_rules_elem) -

[PATCH v2][net-next] ice: Replace one-element arrays with flexible-arrays

2020-05-27 Thread Gustavo A. R. Silva
x undefined behaviour") Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Use offsetof(struct ice_aqc_sw_rules_elem, pdata) instead of sizeof(struct ice_aqc_sw_rules_elem) - sizeof(((struct ice_aqc_sw_rules_elem *)0)->pdata) - Update changelog text. .../net/ethernet/intel/ice/ice_

[PATCH][next] ice: Replace one-element arrays with flexible-arrays

2020-05-26 Thread Gustavo A. R. Silva
32932f ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva --- .../net/ethernet/intel/ice/ice_adminq_cmd.h | 6 ++--- drivers/net/ethernet/intel/ice/ice_switch.c | 22 +-- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/ne

Re: [PATCH] Bluetooth: L2CAP: Replace zero-length array with flexible-array

2020-05-18 Thread Gustavo A. R. Silva
On Mon, May 18, 2020 at 09:58:22AM +0200, Marcel Holtmann wrote: > > > > Signed-off-by: Gustavo A. R. Silva > > --- > > include/net/bluetooth/l2cap.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > patch has been applied to bluetooth-next tree. > Thanks, Marcel. -- Gustavo

[PATCH] Bluetooth: L2CAP: Replace zero-length array with flexible-array

2020-05-13 Thread Gustavo A. R. Silva
lso help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-of

Re: [PATCH net-next 1/2] ath10k: fix gcc-10 zero-length-bounds warnings

2020-05-09 Thread Gustavo A. R. Silva
Arnd, On Sat, May 09, 2020 at 02:06:32PM +0200, Arnd Bergmann wrote: > gcc-10 started warning about out-of-bounds access for zero-length > arrays: > > In file included from drivers/net/wireless/ath/ath10k/core.h:18, > from drivers/net/wireless/ath/ath10k/htt_rx.c:8: > drivers/net

[PATCH] team: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
lso help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-of

[PATCH] ipv6: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
lso help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-of

[PATCH] net: atarilance: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
lso help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-of

[PATCH] net/mlx5: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
lso help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-of

[PATCH] IB/mlx4: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
lso help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-of

[PATCH] libbpf: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
lso help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-of

[PATCH] carl9170: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
lso help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-of

[PATCH] wcn36xx: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
lso help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-of

[PATCH] wil6210: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
lso help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-of

Re: [PATCH] ath10k: Replace zero-length array with flexible-array

2020-05-06 Thread Gustavo A. R. Silva
Kalle, On 5/5/20 02:51, Kalle Valo wrote: > > Fails to apply, please rebase on top of ath.git master branch. > > error: patch failed: drivers/net/wireless/ath/ath10k/pci.h:182 > error: drivers/net/wireless/ath/ath10k/pci.h: patch does not apply > stg import: Diff does not apply cleanly > > Pat

[PATCH v2] ath10k: Replace zero-length array with flexible-array

2020-05-06 Thread Gustavo A. R. Silva
lso help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-of

[PATCH][next] rndis_wlan: Remove logically dead code

2020-05-05 Thread Gustavo A. R. Silva
ead, hence is never executed and can be removed. As a consequence, the rest of the related code can be refactored a bit. Notice that this code has been out there since March 2010. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html Signed-off-by: Gustavo A. R. Silva --- In case this is actually

[PATCH] ath6kl: Replace zero-length array with flexible-array

2020-05-04 Thread Gustavo A. R. Silva
lso help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-of

[PATCH] ath10k: Replace zero-length array with flexible-array

2020-05-04 Thread Gustavo A. R. Silva
lso help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-of

[PATCH] ath11k: Replace zero-length array with flexible-array

2020-05-04 Thread Gustavo A. R. Silva
lso help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-of

Re: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings

2020-05-04 Thread Gustavo A. R. Silva
On 5/4/20 06:54, Kalle Valo wrote: > "Gustavo A. R. Silva" writes: > >> Hi Arnd, >> >> On 4/30/20 16:30, Arnd Bergmann wrote: >>> gcc-10 started warning about out-of-bounds access for zero-length >>> arrays: >>> >&g

Re: linux-next: manual merge of the mlx5-next tree with the kspp-gustavo tree

2020-04-30 Thread Gustavo A. R. Silva
Stephen, On 4/30/20 22:30, Gustavo A. R. Silva wrote: >> This is now a conflict between the net-next and kspp-gustavo trees. >> > > Thanks for reporting this. I think the best solution, for now, is to remove > the > changes from my tree. I'll do it right away. >

Re: linux-next: manual merge of the mlx5-next tree with the kspp-gustavo tree

2020-04-30 Thread Gustavo A. R. Silva
Hi Stephen, On 4/30/20 22:12, Stephen Rothwell wrote: > Hi all, > > On Wed, 29 Apr 2020 12:06:25 +1000 Stephen Rothwell > wrote: >> >> Today's linux-next merge of the mlx5-next tree got a conflict in: >> >> include/linux/mlx5/mlx5_ifc.h >> >> between commit: >> >> 3ba225b506a2 ("treewide: R

Re: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings

2020-04-30 Thread Gustavo A. R. Silva
Hi Arnd, On 4/30/20 16:30, Arnd Bergmann wrote: > gcc-10 started warning about out-of-bounds access for zero-length > arrays: > > In file included from drivers/net/wireless/ath/ath10k/core.h:18, > from drivers/net/wireless/ath/ath10k/htt_rx.c:8: > drivers/net/wireless/ath/ath10k/

Re: [PATCHv2 1/1] net: rds: add service level support in rds-info

2019-09-02 Thread Gustavo A. R. Silva
Hi, On 8/23/19 8:04 PM, Zhu Yanjun wrote: [..] > diff --git a/net/rds/ib.c b/net/rds/ib.c > index ec05d91..45acab2 100644 > --- a/net/rds/ib.c > +++ b/net/rds/ib.c > @@ -291,7 +291,7 @@ static int rds_ib_conn_info_visitor(struct rds_connection > *conn, > void *

[PATCH] net/af_iucv: mark expected switch fall-throughs

2019-07-29 Thread Gustavo A. R. Silva
in accordance with what GCC is expecting to find. Reported-by: Geert Uytterhoeven Signed-off-by: Gustavo A. R. Silva --- net/iucv/af_iucv.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index 09e1694b6d34..ebb62a4ebe30 100

Re: [PATCH][next] iwlwifi: d3: Use struct_size() helper

2019-05-14 Thread Gustavo A. R. Silva
On 5/14/19 12:16 AM, Luciano Coelho wrote: > > Thanks! Applied to our internal tree and it will reach the mainline > following our normal upstreaming process. > Awesome. :) Thanks, Luciano. -- Gustavo

[PATCH net-next] cxgb4/cxgb4vf_main: Mark expected switch fall-through

2019-04-24 Thread Gustavo A. R. Silva
, the code comment is modified in accordance with what GCC is expecting to find. This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] wil6210: fix potential out-of-bounds read

2019-04-15 Thread Gustavo A. R. Silva
On 4/15/19 12:24 PM, me...@codeaurora.org wrote: > On 2019-04-15 17:56, Gustavo A. R. Silva wrote: >> Notice that *rc* can evaluate to up to 5, include/linux/netdevice.h: >> >> enum gro_result { >>     GRO_MERGED, >>     GRO_MERGED_FREE, >>

Re: [mt76/mt7603/mac] Question about missing variable assignment

2019-03-03 Thread Gustavo A. R. Silva
On 3/3/19 4:05 AM, Felix Fietkau wrote: > On 2019-03-02 22:10, Gustavo A. R. Silva wrote: >> Hi all, >> >> The following piece of code in >> drivers/net/wireless/mediatek/mt76/mt7603/mac.c >> is missing a variable assignment before line 1058. Notice that there

Re: [PATCH] isdn: mISDN: Fix potential NULL pointer dereference of kzalloc

2019-03-02 Thread Gustavo A. R. Silva
On 3/2/19 3:20 PM, Aditya Pakki wrote: > Allocating memory via kzalloc for phi may fail and causes a > NULL pointer dereference. This patch avoids such a scenario. > Was this detected by Coccinelle? If so, please mention it in the commit log. Thanks -- Gustavo > Signed-off-by: Aditya Pakki

<    1   2   3   4   5   6   7   8   >