).
Heiner Kallweit (3):
r8169: remove unneeded rpm ops in rtl_shutdown
r8169: improve runtime pm in rtl8169_check_link_status
r8169: improve runtime pm in general and suspend unused ports
drivers/net/ethernet/realtek/r8169.c | 44 ++--
1 file changed, 17 insertions
Am 04.01.2018 um 12:44 schrieb Russell King - ARM Linux:
> On Thu, Jan 04, 2018 at 08:00:53AM +0100, Heiner Kallweit wrote:
>> Parameter mask of phy_modify() holds the bits to be cleared.
>> In the mentioned commit parameter mask seems to be inverted in
>> few cases, what IMO
Parameter mask of phy_modify() holds the bits to be cleared.
In the mentioned commit parameter mask seems to be inverted in
few cases, what IMO is wrong (see example).
Maybe I miss something, could you please check?
And somehow related:
When adding such helpers, wouldn't it make sense to add
Am 22.12.2017 um 11:14 schrieb Andrew Lunn:
> On Thu, Dec 21, 2017 at 09:50:39PM +0100, Heiner Kallweit wrote:
>> Dealing with link partner abilities is handled by phylib, so let's
>> just trigger autonegotiation here.
>>
>> Signed-off-by: Heiner Kallweit <hkallwe...
Am 22.12.2017 um 11:00 schrieb Andrew Lunn:
>> static int rtl8168_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
>> {
>> -struct rtl8168_private *tp = netdev_priv(dev);
>> -struct mii_ioctl_data *data = if_mii(ifr);
>> +if (!netif_running(dev))
>> +return
Am 22.12.2017 um 10:57 schrieb Andrew Lunn:
> On Thu, Dec 21, 2017 at 09:50:28PM +0100, Heiner Kallweit wrote:
>> Use genphy_soft_reset instead of open coding the soft reset.
>
> Hi Heiner
>
> At this point, you have swapped over the phylib. Does one of the
> drivers in
Am 21.12.2017 um 22:16 schrieb David Miller:
> From: Heiner Kallweit <hkallwe...@gmail.com>
> Date: Thu, 21 Dec 2017 21:38:11 +0100
>
>> This experimental series separates drivers for PCI / PCIE NIC's and
>> adds initial phylib support to the separated r8168 driv
Function rtl8169_rx_missed() does nothing on MAC versions > 06,
therefore remove it.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8168.c | 23 ---
1 file changed, 23 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r
All supported chips provide a MII interface, therefore some callbacks
can be removed from struct rtl8169_private.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8168.c | 46 +---
1 file changed, 16 insertions(
All PHY's of the supported chips are MII-compatible, therefore let
phylib do the work.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/Kconfig | 1 +
drivers/net/ethernet/realtek/r8168.c | 152 +++
2 files change
After separation from the r8169 driver, replace 8169 with 8168 in all
relevant symbols.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8168.c | 1066 +-
1 file changed, 533 insertions(+), 533 deletions(-)
diff
After switching to phylib we don't need most elements of
struct mii_if_info any longer.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8168.c | 37 +++-
1 file changed, 7 insertions(+), 30 deletions(-)
diff --git a/d
Use phy_ethtool_get/set_link_ksettings instead of open coding these
ethtool ops.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8168.c | 50 +++-
1 file changed, 3 insertions(+), 47 deletions(-)
diff --git a/drive
Use genphy_soft_reset instead of open coding the soft reset.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8168.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8168.c
b/drive
Remove further code which is replaced by phylib.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8168.c | 60
1 file changed, 60 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8168.c
b/drivers/net/et
Instead of accessing mdio_ops directly use phy_read/write in these
helpers.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8168.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8168.c
b/drive
Remove TBI mode support needed for MAC version 01 only.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8168.c | 123 ++-
1 file changed, 6 insertions(+), 117 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r
Dealing with link partner abilities is handled by phylib, so let's
just trigger autonegotiation here.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8168.c | 26 +-
1 file changed, 1 insertion(+), 25 deletions(-)
diff
Switch to phy_ethtool_nway_reset.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/Kconfig | 1 -
drivers/net/ethernet/realtek/r8168.c | 9 +
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/realtek/Kcon
Use phy_mii_ioctl for handling the ioctl's.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8168.c | 25 +++--
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8168.c
b/drivers/net/et
Let's use the speed information as maintained by phylib instead of
reading it directly from a register.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8168.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/d
Remove magic register handling used on MAC version 05 and 06 only.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8168.c | 27 ---
1 file changed, 27 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8168.c
b/drive
All these PHY basics are handled by phylib, so let's remove this code.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8168.c | 92
1 file changed, 92 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r816
Remove code which is specific to MAC version 01 - 06.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8168.c | 302 +--
1 file changed, 5 insertions(+), 297 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r816
l identifies as RTL8211E and has
certain support already (w/o firmware).
Heiner Kallweit (18):
r8169: split driver to one for the non-PCIE cards (r8169) and one for the
PCIE cards (r8168)
r8168: remove code specific to MAC version 01 - 06
r8168: remove magic register handling used on MA
Am 21.11.2017 um 02:34 schrieb Andrew Lunn:
> Hi Heiner
>
> Do you have access to the data sheet?
>
> I had a quick look through the driver. It would be nice to refactor it
> to follow the usual Linux conventions:
>
> Turn the MDIO read/write functions into an MDIO bus driver.
>
> Move the PHY
Add pcim_set_mwi(), a device-managed version of pci_set_mwi().
First user is the Realtek r8169 driver.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
Acked-by: Bjorn Helgaas <bhelg...@google.com>
---
v2:
- Reorder calls
- Adjust and commit message
---
drivers/pci/
netif_napi_del is called implicitely by free_netdev, therefore we
don't have to do it explicitely.
When the probe error path is reached, the net_device isn't
registered yet. Therefore reordering the call to netif_napi_del
shouldn't cause any issues.
Signed-off-by: Heiner Kallweit <hkal
Simplify probe error path and remove callback by using device-managed
functions.
rtl_disable_msi isn't needed any longer because the release callback
of pcim_enable_device does this implicitely.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
v2:
- no changes
---
drivers/net/et
Probe error path and remove callback can be significantly simplified
by using device-managed functions. To be able to do this in the r8169
driver we need a device-managed version of pci_set_mwi first.
v2:
Change patch 1 based on Björn's review comments and add his Acked-by.
Heiner Kallweit (3
Introduce a device-managed version of pci_set_mwi. First user is the
Realtek r8169 driver.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/pci/pci.c | 29 +
include/linux/pci.h | 1 +
2 files changed, 30 insertions(+)
diff --git a/drive
Simplify probe error path and remove callback by using device-managed
functions.
rtl_disable_msi isn't needed any longer because the release callback
of pcim_enable_device does this implicitely.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8169.
netif_napi_del is called implicitely by free_netdev, therefore we
don't have to do it explicitely.
When the probe error path is reached, the net_device isn't
registered yet. Therefore reordering the call to netif_napi_del
shouldn't cause any issues.
Signed-off-by: Heiner Kallweit <hkal
Probe error path and remove callback can be significantly simplified
by using device-managed functions. To be able to do this in the r8169
driver we need a device-managed version of pci_set_mwi first.
Heiner Kallweit (3):
PCI: introduce device-managed version of pci_set_mwi
r8169: switch
Am 04.12.2017 um 01:02 schrieb Stephen Rothwell:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/net/phy/broadcom.c:391:12: warning: 'bcm5482_read_status' defined but
> not used [-Wunused-function]
> static
Previous patch mistakenly removed three chip-specific config settings.
Add them again.
Fixes: 80274abafc60 "net: phy: remove generic settings for callbacks
config_aneg and read_status from drivers"
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/phy/broad
Am 01.12.2017 um 21:42 schrieb David Miller:
> From: Heiner Kallweit <hkallwe...@gmail.com>
> Date: Thu, 30 Nov 2017 23:47:52 +0100
>
>> Remove generic settings for callbacks config_aneg and read_status
>> from drivers.
>>
When re-testing I just figured out tha
.
Tested on a Odroid-C2 with RTL8211F phy in interrupt mode.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/phy/phy.c | 19 ++-
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index b37
if more people could test this.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
Acked-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
---
drivers/net/phy/phy.c | 26 ++
include/linux/phy.h | 1 -
2 files changed, 2 insertions(+), 25 deletions(-)
diff
Remove generic settings for callbacks config_aneg and read_status
from drivers.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
---
drivers/net/phy/amd.c| 2 --
drivers/net/phy/at803x.c | 6 --
drivers
implement
the mandatory calls. If a driver doesn't do so we'd just get a NPE.
With this patch this potential issue doesn't exit any longer.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
---
drivers/net/phy/phy.c | 5 -
i
Am 15.11.2017 um 22:56 schrieb Florian Fainelli:
> On 11/15/2017 01:42 PM, Heiner Kallweit wrote:
>> read_status and config_aneg are the only mandatory callbacks and most
>> of the time the generic implementation is used by drivers.
>> So make the core fall back to the generi
Am 16.11.2017 um 10:51 schrieb Ard Biesheuvel:
> On 15 November 2017 at 22:19, Heiner Kallweit <hkallwe...@gmail.com> wrote:
>> Am 15.11.2017 um 23:04 schrieb Florian Fainelli:
>>> On 11/12/2017 01:08 PM, Heiner Kallweit wrote:
>>>> After commits c974bdbc3e &
Am 21.11.2017 um 02:34 schrieb Andrew Lunn:
> Hi Heiner
Hi Andrew,
>
> Do you have access to the data sheet?
>
Not to more recent ones. I only have two older data sheets for early
members of the rtl8169 family.
> I had a quick look through the driver. It would be nice to refactor it
> to
Adjust the code to use the same green settings as in the latest
vendor driver.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
v2:
- replace magic numbers with constants
---
drivers/net/ethernet/realtek/r8169.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drive
was moved to the current place in 2011).
The patch was tested on a Zotac Mini-PC with a RTL8111E-VL chip.
Before the patch EEE was disabled, now it's properly advertised and
works fine.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
v2:
- no changes
---
drivers/net/ethernet/real
Adjust the code to use the same green settings as in the latest
vendor driver.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8169.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/realtek/r8169.c
b/drivers/net/et
was moved to the current place in 2011).
The patch was tested on a Zotac Mini-PC with a RTL8111E-VL chip.
Before the patch EEE was disabled, now it's properly advertised and
works fine.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/realtek/r8169.c | 12 ++--
Am 18.11.2017 um 22:33 schrieb Heiner Kallweit:
> I have a Zotac Mini-PC with a RTL8111E-VL and just by chance figured out
> that EEE is disabled on the link between my EEE-capable switch and
> this device.
>
> After a little investigating I found that from the beginning o
I have a Zotac Mini-PC with a RTL8111E-VL and just by chance figured out
that EEE is disabled on the link between my EEE-capable switch and
this device.
After a little investigating I found that from the beginning of this
driver advertising of EEE was disabled: See rtl8168e_2_hw_phy_config,
line
Am 15.11.2017 um 23:04 schrieb Florian Fainelli:
> On 11/12/2017 01:08 PM, Heiner Kallweit wrote:
>> After commits c974bdbc3e "net: phy: Use threaded IRQ, to allow IRQ from
>> sleeping devices" and 664fcf123a30 "net: phy: Threaded interrupts allow
>> some simp
Remove generic settings for callbacks config_aneg and read_status
from drivers.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/phy/amd.c| 2 --
drivers/net/phy/at803x.c | 6 --
drivers/net/phy/bcm-cygnus.c | 2 --
drivers/net/phy/bcm63xx.c
implement
the mandatory calls. If a driver doesn't do so we'd just get a NPE.
With this patch this potential issue doesn't exit any longer.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/phy/phy.c | 5 -
include/linux/phy.h | 33 ++---
2
.
Tested on a Odroid-C2 with RTL8211F phy in interrupt mode.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/phy/phy.c | 19 ++-
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index b37
if more people could test this.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/phy/phy.c | 26 ++
include/linux/phy.h | 1 -
2 files changed, 2 insertions(+), 25 deletions(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 2
0.
Because register INSR needs to be accessed via page 0xa43 I assumed
that register INER needs to be accessed via some page too.
Some brute force check resulted in page 0xa42 being the right one.
With this patch the phy is working properly in interrupt mode.
Signed-off-by: Heiner Kallweit <hkallwe
As reported by Corentin Labbe before:
stmmac in the latest next kernel is broken also on meson8b.
The following commit seems to create the trouble:
6deee2221e11 "net: stmmac: prepare dma op mode config for multiple queues"
I also get queue timeout errors.
Rgds, Heiner
Most likely a copy & paste error in referenced commit.
Restore the debug message to what it was before.
Fixes: f573c0b9c4e0 ("stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst
to platform structure")
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
v2:
- Do
Am 02.02.2017 um 03:20 schrieb Phil Reid:
> On 2/02/2017 05:05, Heiner Kallweit wrote:
>> I can only imagine that this message ended up there by a copy & paste
>> mistake. The same message appears correctly a few lines later, but
>> here it doesn't make sense.
>>
&g
I can only imagine that this message ended up there by a copy & paste
mistake. The same message appears correctly a few lines later, but
here it doesn't make sense.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1
Chips like Amlogic S905GXBB are supported by this driver but don't
have support for PTP. Add a separate warning for missing HW support
to differentiate it from other actual failures.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main
As documented in Documentation/devicetree/bindings/net/ethernet.txt,
in RGMII_ID and RGMII_TXID mode the MAC should not add a tx delay.
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 16 +---
1 file chan
Am 15.01.2017 um 19:23 schrieb Joe Perches:
> On Sun, 2017-01-15 at 19:17 +0100, Heiner Kallweit wrote:
>> Don't use netdev_info and friends before the net_device is registered.
>> This avoids ugly messages like
>> "meson8b-dwmac c941.ethernet (unnamed net_device) (un
Don't use netdev_info and friends before the net_device is registered.
This avoids ugly messages like
"meson8b-dwmac c941.ethernet (unnamed net_device) (uninitialized):
Enable RX Mitigation via HW Watchdog Timer"
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
driv
Don't use netdev_info and friends before the net_device is registered.
This avoids ugly messages like
"meson8b-dwmac c941.ethernet (unnamed net_device) (uninitialized):
Enable RX Mitigation via HW Watchdog Timer"
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
driv
401 - 465 of 465 matches
Mail list logo
