Re: [PATCH v2] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-14 Thread Igor Plyatov
. * The Energy Detect Power-Down mode enabled again in the end of procedure to * save approximately 220 mW of power if cable is unplugged. */ Nice. Only one nitpick: ... _is_ enabled again... Changed in [PATCH v3]. Best wishes. -- Igor Plyatov -- To unsubscribe from this list: send the line

[PATCH v3] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-14 Thread Igor Plyatov
improved to acquire ENERGYON bit. Its previous algorythm still not reliable on 100 % and sometimes skip cable plugging. Signed-off-by: Igor Plyatov --- drivers/net/phy/smsc.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/net/phy

Re: [PATCH v2] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-14 Thread Igor Plyatov
metimes skip cable plugging. > > Signed-off-by: Igor Plyatov > --- > drivers/net/phy/smsc.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c > index c0f6479..8559ff1 100644 >

Re: [PATCH] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-13 Thread Igor Plyatov
Dear David and Joe, thank you for patch review! Please look at email with subject "[PATCH v2] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging" Best wishes. -- Igor Plyatov From: Joe Perches Date: Thu, 13 Aug 2015 10:15:15 -0700 On Thu, 2015-08-1

[PATCH v2] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-13 Thread Igor Plyatov
improved to acquire ENERGYON bit. Its previous algorythm still not reliable on 100 % and sometimes skip cable plugging. Signed-off-by: Igor Plyatov --- drivers/net/phy/smsc.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/smsc.c b/drivers

Re: [PATCH] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-13 Thread Igor Plyatov
Dear Joe, On Thu, 2015-08-13 at 16:12 +0300, Igor Plyatov wrote: * Due to HW bug, LAN8700 sometimes does not detect presence of energy in the Ethernet cable in Energy Detect Power-Down mode (e.g while EDPWRDOWN bit is set, the ENERGYON bit does not asserted sometimes). This is a common

[PATCH] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-13 Thread Igor Plyatov
improved to acquire ENERGYON bit. Its previous algorythm still not reliable on 100 % and sometimes skip cable plugging. Signed-off-by: Igor Plyatov --- drivers/net/phy/smsc.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/smsc.c b/drivers

Buggy cable detection on i.MX51, fec driver and LAN8700 PHY

2015-07-27 Thread Igor Plyatov
after 10-20 unplugging/plugging. The issue was tested and exists on kernels from linux-3.8.5 till current linux-4.2-rc4-cbfe8fa6cd672011c755c3cd85c9ffd4e2d10a6f. Same tests was made with different versions of the Barebox bootloader and cable detection works flawless. Please, help to resolve i