On Mon, Aug 06, 2007 at 05:19:03PM -0400, Chuck Ebbert wrote:
On 08/06/2007 04:42 PM, Jean-Baptiste Vignaud wrote:
Mmm, bad news, after 4 hours of intensive network stressing, one of the 2
3com card failed with the latest fedora kernel.
Aug 6 22:31:09 loki kernel: NETDEV WATCHDOG:
On Tue, Aug 07, 2007 at 09:46:36AM +0200, Marcin Ślusarz wrote:
2007/8/6, Ingo Molnar [EMAIL PROTECTED]:
(..)
please try Jarek's second patch too - there was a missing unmask.
Ingo
--
Subject: genirq: fix simple and fasteoi irq handlers
From: Jarek Poplawski
On Tue, Aug 07, 2007 at 10:10:34AM +0200, Jean-Baptiste Vignaud wrote:
BTW: Jean-Babtiste, could you send or point to you current configs?
Oops! I'm very sorry for misspelling!
I mean at least proc/interrupts, but with dmesg and .config it would
be even better. (I assume this last report
On Tue, Aug 07, 2007 at 11:21:07AM +0200, Jean-Baptiste Vignaud wrote:
* interrupts (i use irqbalance, but problem was the same without)
I wonder if you tried without SMP too?
No i did not. Do you think that this can be a problem ?
To test with no SMP, do i need to recompile kernel or
On Tue, Aug 07, 2007 at 11:37:01AM +0200, Marcin Ślusarz wrote:
2007/8/7, Jarek Poplawski [EMAIL PROTECTED]:
On Tue, Aug 07, 2007 at 09:46:36AM +0200, Marcin Ślusarz wrote:
Network card still locks up (tested on 2.6.22.1). I had to upload more
data than usual (~350 MB vs ~1-100 MB
On Mon, Aug 06, 2007 at 01:43:48PM -0400, Chuck Ebbert wrote:
On 08/06/2007 03:03 AM, Ingo Molnar wrote:
But, since level types don't need this retriggers too much I think
this don't mask interrupts by default idea should be rethinked:
is there enough gain to risk such hard to diagnose
On Tue, Aug 07, 2007 at 11:52:46AM +0200, Jarek Poplawski wrote:
On Tue, Aug 07, 2007 at 11:37:01AM +0200, Marcin Ślusarz wrote:
2007/8/7, Jarek Poplawski [EMAIL PROTECTED]:
On Tue, Aug 07, 2007 at 09:46:36AM +0200, Marcin Ślusarz wrote:
Network card still locks up (tested on 2.6.22.1
On Tue, Aug 07, 2007 at 02:13:39PM +0200, Jarek Poplawski wrote:
On Tue, Aug 07, 2007 at 11:52:46AM +0200, Jarek Poplawski wrote:
On Tue, Aug 07, 2007 at 11:37:01AM +0200, Marcin Ślusarz wrote:
...
No, i don't need a break. I'll have more time in next weeks.
Great! So, I'll try to send
, there should be at least possibility to turn this off for
level types in config (it should be a visible option, so people could
find try this before writing for help or changing a network card).
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp 2.6.23-rc1-/kernel/irq/chip.c 2.6.23
On Mon, Aug 06, 2007 at 08:14:59AM +0200, Ingo Molnar wrote:
* Jarek Poplawski [EMAIL PROTECTED] wrote:
Subject: genirq: fix simple and fasteoi irq handlers
After the genirq: do not mask interrupts by default patch interrupts
should be disabled not immediately upon request
Ravnborg about kconfig's select evilness,
dependencies and the future (slightly corrected).
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
Cc: Sam Ravnborg [EMAIL PROTECTED]
---
diff -Nu9r 2.6.23-rc1-/Documentation/kbuild/kconfig-language.txt
2.6.23-rc1/Documentation/kbuild/kconfig
On Thu, Aug 02, 2007 at 10:59:23AM -0500, Matt Mackall wrote:
On Thu, Aug 02, 2007 at 11:00:08AM +0200, Jarek Poplawski wrote:
On Wed, Aug 01, 2007 at 09:02:19PM -0500, Matt Mackall wrote:
...
How about cc:ing the netpoll maintainer?
Is there a new one or do you suggest possibility
On Fri, Aug 03, 2007 at 01:57:00PM +0200, Marcin Ślusarz wrote:
...
I'll test this patch tomorrow (and confirm that the last one from Ingo
works fine) and report results on monday (sorry, no internet at home
since I moved out of city :|).
So, you are a lucky guy! I have only no internet at
On Fri, Aug 03, 2007 at 10:04:08AM +0200, Ingo Molnar wrote:
* Jarek Poplawski [EMAIL PROTECTED] wrote:
I can't guarantee this is all needed to fix this bug, but I think this
patch is necessary here.
hmmm ... very interesting! Now _this_ is something we'd like to see
tested. Could
On Wed, Aug 01, 2007 at 09:02:19PM -0500, Matt Mackall wrote:
On Wed, Aug 01, 2007 at 11:59:21AM +0200, Jarek Poplawski wrote:
On Tue, Jul 31, 2007 at 05:05:00PM +0200, Gabriel C wrote:
Jarek Poplawski wrote:
On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote:
Jarek Poplawski
On Thu, Aug 02, 2007 at 04:02:21PM +0530, Satyam Sharma wrote:
Hi,
On Thu, 2 Aug 2007, Sam Ravnborg wrote:
...
endif # NETDEVICES
config NETPOLL
depends on NETDEVICES
def_bool NETCONSOLE
config NETPOLL_TRAP
bool Netpoll
On Thu, Aug 02, 2007 at 05:26:12PM +0530, Satyam Sharma wrote:
...
Whoops, I only said that in humour, probably should've snuck in a
smiley or two. Definitely not blaming anybody. Apologies to anyone
who felt offended, sorry, nothing such was intended, I assure.
I see you probably didn't
-mentioned change in irq handling.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp 2.6.23-rc1-/kernel/irq/chip.c 2.6.23-rc1/kernel/irq/chip.c
--- 2.6.23-rc1-/kernel/irq/chip.c 2007-07-09 01:32:17.0 +0200
+++ 2.6.23-rc1/kernel/irq/chip.c2007-08-02 20:42:38.0
On Tue, Jul 31, 2007 at 05:05:00PM +0200, Gabriel C wrote:
Jarek Poplawski wrote:
On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote:
Jarek Poplawski wrote:
On 28-07-2007 20:42, Gabriel C wrote:
Andrew Morton wrote:
On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C [EMAIL PROTECTED
On 28-07-2007 20:42, Gabriel C wrote:
Andrew Morton wrote:
On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C [EMAIL PROTECTED] wrote:
Hi,
I got this compile error with a randconfig (
http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ).
...
net/core/netpoll.c: In function
On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote:
Jarek Poplawski wrote:
On 28-07-2007 20:42, Gabriel C wrote:
Andrew Morton wrote:
On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C [EMAIL PROTECTED] wrote:
Hi,
I got this compile error with a randconfig (
http
On Tue, Jul 31, 2007 at 06:44:52AM -0500, Jason Wessel wrote:
...
kgdboe is completely useless without a network card that has a polling
driver. It seems to me that the simple and easy fix is to set it to
depend on NETDEVICES but allow it to use select on NETPOLL.
Maybe I miss your point
On Mon, Jul 30, 2007 at 09:29:38AM +0200, Marcin Ślusarz wrote:
...
ps: I retested all patches posted in this thread on top of 2.6.22.1
and behavior from 2.6.21.3 didn't changed. My next tests will be on
2.6.22.x only.
Marcin,
I see you're quite busy, but if after testing this next Ingo's
On Thu, Jul 26, 2007 at 10:31:20AM +0200, Ingo Molnar wrote:
...
yeah. The patch below enables sw-resend on x86, to test the theory
whether the APIC-driven hardware-vector-resend code has some problem.
I think Marcin is using x86_64 (Athlon 64) yet.
Jarek P.
-
To unsubscribe from this list:
On Thu, Jul 26, 2007 at 09:16:10AM +0200, Marcin Ślusarz wrote:
2007/7/25, Thomas Gleixner [EMAIL PROTECTED]:
(...)
I've tested Jarek's patch, 2 Ingo's patches (2nd and 3rd) and Thomas'
patch (one patch at time of course) - all of them fixed the problem,
but the last one flooded my logs
On Thu, Jul 26, 2007 at 10:10:31AM +0200, Thomas Gleixner wrote:
On Thu, 2007-07-26 at 10:13 +0200, Jarek Poplawski wrote:
...
PS: Now, it seems to me Thomas could be the nearest. BTW, could somebody
give me some tip, how these re-triggered interrupts are skipped on dev's
reset before
On Thu, Jul 26, 2007 at 10:13:26AM +0200, Jarek Poplawski wrote:
...
So, everything is clear - any changes are good!
Except the signed-off ones...
Oops! Marcin's patch was both signed-off and good.
So, there is probably something more...
Sorry Marcin,
Jarek P.
-
To unsubscribe from this list
interrupts on the APIC bus deadlocking the transmit path.
Quite hairy but the chip simply wasn't designed for SMP and you can't
even ACK an interrupt without risking corrupting other parallel
activities on the chip.
Alan
--
From: Jarek Poplawski [EMAIL PROTECTED]
Subject: lib8390
On Wed, Jul 25, 2007 at 02:19:31AM +0200, Thomas Gleixner wrote:
On Tue, 2007-07-24 at 22:04 +0200, Ingo Molnar wrote:
Marcin, could you try the patch below too? [without having any other
patch applied.] It basically turns the critical section into an irqs-off
critical section and thus
On Wed, Jul 25, 2007 at 02:19:31AM +0200, Thomas Gleixner wrote:
...
Looking into the IO_APIC code, the resend via send_IPI_self() happens
unconditionally. So the resend is done for level and edge interrupts.
This makes the problem more mysterious.
The code in question lib8390.c does
On Mon, Jul 23, 2007 at 07:44:58AM +0200, Marcin Ślusarz wrote:
Ok, I've bisected this problem and found that this patch broke my NIC:
76d2160147f43f982dfe881404cfde9fd0a9da21 is first bad commit
commit 76d2160147f43f982dfe881404cfde9fd0a9da21
Author: Ingo Molnar [EMAIL PROTECTED]
Date:
On 18-07-2007 20:50, Oleg Verych wrote:
Hallo.
I have a very strange problem.
[]
Any advise on how to debug this will be very appreciated. Thanks.
Thanks...
You're quite welcome...
Cheers,
Jarek P.
PS: Oleg, no offence, but are you sure this was the right problem
and the right list?
-
On 22-07-2007 09:05, David Miller wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Thu, 19 Jul 2007 17:27:47 +0100
Please revisit the requirements that netconsole needs and redesign
it from scratch. The existing code is causing too much breakage.
Can it be done without breaking the
On Mon, Jul 23, 2007 at 07:44:58AM +0200, Marcin Ślusarz wrote:
Ok, I've bisected this problem and found that this patch broke my NIC:
Congratulations!
76d2160147f43f982dfe881404cfde9fd0a9da21 is first bad commit
commit 76d2160147f43f982dfe881404cfde9fd0a9da21
Author: Ingo Molnar [EMAIL
On Mon, Jul 16, 2007 at 08:45:05PM +0300, Ranko Zivojnovic wrote:
...
[NET] gen_estimator deadlock fix
-Fixes ABBA deadlock noted by Patrick McHardy [EMAIL PROTECTED]:
There is at least one ABBA deadlock, est_timer() does:
read_lock(est_lock)
spin_lock(e-stats_lock) (which is
On Tue, Jul 17, 2007 at 02:01:48PM +0200, Patrick McHardy wrote:
...
Thanks,
Jarek P.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 13, 2007 at 03:42:31PM +0200, Jarek Poplawski wrote:
...
On Fri, Jul 13, 2007 at 03:26:42PM +0300, Ranko Zivojnovic wrote:
I've been a bit tight on time today, and only now I see that maybe
you have done too much. Of course, you can do it your way, but I
think it should be easier
On Fri, Jul 13, 2007 at 10:55:08AM +0200, Jarek Poplawski wrote:
On Thu, Jul 12, 2007 at 03:54:32PM +0200, Olaf Kirch wrote:
...
One thing I was a little worried about was whether dev-npinfo can
go away all of a sudden. It's really just protected by an rcu_readlock...
...
BTW, I don't think
On Thu, Jul 12, 2007 at 08:48:45PM +0300, Ranko Zivojnovic wrote:
...
Ok - here's the patch for a review - it compiles clean ... and that's as
much as it has been tested - I'll try give it a run later today or
definitely tomorrow.
...
Ranko, you have some powers!
Alas, I definitely need more
On Fri, Jul 13, 2007 at 03:26:42PM +0300, Ranko Zivojnovic wrote:
On Fri, 2007-07-13 at 14:17 +0200, Jarek Poplawski wrote:
On Thu, Jul 12, 2007 at 08:48:45PM +0300, Ranko Zivojnovic wrote:
...
Ok - here's the patch for a review - it compiles clean ... and that's as
much as it has been
On Thu, Jul 12, 2007 at 03:54:32PM +0200, Olaf Kirch wrote:
Hi Jarek,
On Thursday 12 July 2007 14:59, Jarek Poplawski wrote:
+#ifdef CONFIG_NETPOLL
+ /* Prevent race with netpoll - yes, this is a kludge.
+ * But at least it doesn't penalize the non-netpoll
+ * code path
On Wed, Jul 11, 2007 at 04:41:37PM +0300, Ranko Zivojnovic wrote:
Fixes ABBA deadlock noted by Patrick McHardy [EMAIL PROTECTED]:
There is at least one ABBA deadlock, est_timer() does:
read_lock(est_lock)
spin_lock(e-stats_lock) (which is dev-queue_lock)
and qdisc_destroy calls
On Thu, Jul 12, 2007 at 12:18:23PM +0300, Ranko Zivojnovic wrote:
On Thu, 2007-07-12 at 09:37 +0200, Jarek Poplawski wrote:
On Wed, Jul 11, 2007 at 04:41:37PM +0300, Ranko Zivojnovic wrote:
Signed-off-by: Ranko Zivojnovic [EMAIL PROTECTED]
Maybe it's only my issue, but it seems
Hi!
I'm really sorry I couldn't write this sooner.
Below are a few of my doubts:
On 10-07-2007 12:44, Olaf Kirch wrote:
On Tuesday 10 July 2007 00:27, David Miller wrote:
I'm happy to entertain this kind of solution, but we really
need to first have an interface to change multiple bits
at a
On Mon, Jul 09, 2007 at 07:43:40PM +0300, Ranko Zivojnovic wrote:
On Mon, 2007-07-09 at 15:52 +0200, Patrick McHardy wrote:
Ranko Zivojnovic wrote:
Patrick, I've taken liberty to try and implement this myself. Attached
is the whole new
On Tue, Jul 10, 2007 at 01:09:07PM +0300, Ranko Zivojnovic wrote:
On Tue, 2007-07-10 at 09:34 +0200, Jarek Poplawski wrote:
On Mon, Jul 09, 2007 at 07:43:40PM +0300, Ranko Zivojnovic wrote:
On Mon, 2007-07-09 at 15:52 +0200, Patrick McHardy wrote:
Ranko Zivojnovic wrote:
Patrick
On Tue, Jul 10, 2007 at 02:20:12PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
On Tue, Jul 10, 2007 at 01:09:07PM +0300, Ranko Zivojnovic wrote:
However I decided not to use _rcu based iteration neither the
rcu_read_lock() after going through the RCU documentation and a bunch
On Tue, Jul 10, 2007 at 03:10:34PM +0200, Jarek Poplawski wrote:
On Tue, Jul 10, 2007 at 02:20:12PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
On Tue, Jul 10, 2007 at 01:09:07PM +0300, Ranko Zivojnovic wrote:
However I decided not to use _rcu based iteration neither
On Sat, Jul 07, 2007 at 05:10:54PM +0200, Patrick McHardy wrote:
On Sat, 7 Jul 2007, Ranko Zivojnovic wrote:
On Fri, 2007-07-06 at 16:21 +0200, Patrick McHardy wrote:
There is at least one ABBA deadlock, est_timer does:
read_lock(est_lock)
spin_lock(e-stats_lock) (which is dev-queue_lock)
On Fri, Jul 06, 2007 at 04:16:18PM +0300, Ranko Zivojnovic wrote:
On Fri, 2007-07-06 at 14:47 +0200, Jarek Poplawski wrote:
On Fri, Jul 06, 2007 at 08:45:23AM +0200, Jarek Poplawski wrote:
On Fri, Jul 06, 2007 at 09:08:43AM +0300, Ranko Zivojnovic wrote:
...
In order to get
On Thu, Jul 05, 2007 at 06:59:25PM +0300, Ranko Zivojnovic wrote:
On Thu, 2007-07-05 at 17:34 +0300, Ranko Zivojnovic wrote:
Anyhow - I am currently running 2.6.22-rc6-mm1 + sch_htb patch and
running a test script that always managed to reproduce the problem
within half hour - so far it
- Forwarded message from Ranko Zivojnovic [EMAIL PROTECTED] -
Date: Thu, 05 Jul 2007 18:59:25 +0300
From: Ranko Zivojnovic [EMAIL PROTECTED]
Subject: Re: + gen_estimator-fix-locking-and-timer-related-bugs.patch added
to -mm tree
To: Jarek Poplawski [EMAIL PROTECTED]
Cc: [EMAIL
On Fri, Jul 06, 2007 at 08:14:20AM +0200, Jarek Poplawski wrote:
...
This new lockup bug you have just found needs some time
to figure out. BTW, I wonder if you had lockdep on
(CONFIG_PROVE_LOCKING or CONFIG_LOCK_ALLOC)?
Should be:
(CONFIG_PROVE_LOCKING or CONFIG_DEBUG_LOCK_ALLOC)?
Jarek P
On Fri, Jul 06, 2007 at 09:08:43AM +0300, Ranko Zivojnovic wrote:
On Thu, 2007-07-05 at 18:59 +0300, Ranko Zivojnovic wrote:
On Thu, 2007-07-05 at 17:34 +0300, Ranko Zivojnovic wrote:
Anyhow - I am currently running 2.6.22-rc6-mm1 + sch_htb patch and
running a test script that always
On Thu, Jul 05, 2007 at 03:06:40PM +0200, Andi Kleen wrote:
On Thu, Jul 05, 2007 at 02:28:50PM +0200, Jarek Poplawski wrote:
I wonder if it's very unsound to think about a one way list
of destructors. Of course, not owners could only clean their
private allocations. Woudn't this save some
On Thu, Jul 05, 2007 at 04:28:47PM +0400, Evgeniy Polyakov wrote:
Hi, Jarek.
On Thu, Jul 05, 2007 at 02:28:50PM +0200, Jarek Poplawski ([EMAIL PROTECTED])
wrote:
I wonder if it's very unsound to think about a one way list
of destructors. Of course, not owners could only clean
On Fri, Jul 06, 2007 at 11:08:35AM +0200, Jarek Poplawski wrote:
...
BSDs were sometimes recommended for specific jobs like mail etc.
but usually linux better fitted the needs. Especially well linux
appeared for an internet gateway/router/firewall/antispam thing,
and the main reasons were
On Fri, Jul 06, 2007 at 08:45:23AM +0200, Jarek Poplawski wrote:
On Fri, Jul 06, 2007 at 09:08:43AM +0300, Ranko Zivojnovic wrote:
...
In order to get that parameter out of the way - I will make the same
test on a real machine.
BTW, maybe it would be better to try with something more stable
It looks like a timer function can be running and rearm
the timer after removing a ipv6 module.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp 2.6.22-rc7-/net/ipv6/addrconf.c 2.6.22-rc7/net/ipv6/addrconf.c
--- 2.6.22-rc7-/net/ipv6/addrconf.c 2007-07-02 09:03:29.0
was prepared on 2.6.22-rc7 with my neighbouring
PATCH 1/2, but they could be applied independently too.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp 2.6.22-rc7-1_2/net/ipv6/addrconf.c 2.6.22-rc7-2_2/net/ipv6/addrconf.c
--- 2.6.22-rc7-1_2/net/ipv6/addrconf.c 2007-07-05 12:33
On 05-07-2007 12:08, Andi Kleen wrote:
...
The traditional standpoint was that having your own large skb pools
is not recommended because you won't interact well with the
rest of the system running low on memory and you tieing up
memory.
Essentially you would recreate all the problems
On Thu, Jul 05, 2007 at 04:28:47PM +0400, Evgeniy Polyakov wrote:
Hi, Jarek.
On Thu, Jul 05, 2007 at 02:28:50PM +0200, Jarek Poplawski ([EMAIL PROTECTED])
wrote:
I wonder if it's very unsound to think about a one way list
of destructors. Of course, not owners could only clean
On Thu, Jul 05, 2007 at 03:06:40PM +0200, Andi Kleen wrote:
On Thu, Jul 05, 2007 at 02:28:50PM +0200, Jarek Poplawski wrote:
I wonder if it's very unsound to think about a one way list
of destructors. Of course, not owners could only clean their
private allocations. Woudn't this save some
On Thu, Jul 05, 2007 at 02:37:40PM -0700, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Thu, 5 Jul 2007 13:12:46 +0200
It looks like a timer function can be running and rearm
the timer after removing a ipv6 module.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED
On Mon, Jul 02, 2007 at 09:52:26AM +0200, Jarek Poplawski wrote:
From my recent patch:
#1
Until kernel ver. 2.6.21 (including) cancel_rearming_delayed_work()
required a work function should always (unconditionally) rearm with
delay 0 - otherwise it would endlessly
On Tue, Jul 03, 2007 at 11:47:18PM -0700, David Miller wrote:
...
I plan to apply this patch, don't worry about it :)
Now I'm really worried! Don't you evere sleep?
Good night,
Jarek P.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
On Wed, Jul 04, 2007 at 08:41:59AM +0200, Jarek Poplawski wrote:
...
They were done on your request but it looks like Andrew
is waiting on something...
Andrew,
This time I'm not sorry for my English because I've just
found I could speak Chiefly Midland and Southern U.S..
Jarek P
On 21-06-2007 12:58, Mark Hannessen wrote:
Hi list,
I have some trouble getting my network card to run.
when I run dmesg I can clearly see it being detected
eth0: VIA Rhine II at 0xee006000, 00:e0:c5:54:88:a8, IRQ 11.
eth0: MII PHY found at address 1, status 0x786d advertising 05e1 Link
As noticed by Jarek Poplawski [EMAIL PROTECTED], the timer removal in
gen_kill_estimator races with the timer function rearming the timer.
Check whether the timer list is empty before rearming the timer
in the timer function to fix this.
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
Acked
On Sun, Jul 01, 2007 at 09:35:58PM +0400, Oleg Nesterov wrote:
Jarek Poplawski wrote:
#1
Until kernel ver. 2.6.21 (including) cancel_rearming_delayed_work()
required a work function should always (unconditionally) rearm with
delay 0 - otherwise it would endlessly loop
.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp 2.6.22-rc7-/net/core/netpoll.c 2.6.22-rc7/net/core/netpoll.c
--- 2.6.22-rc7-/net/core/netpoll.c 2007-07-02 09:03:27.0 +0200
+++ 2.6.22-rc7/net/core/netpoll.c 2007-07-02 09:32:34.0 +0200
@@ -72,8 +72,7 @@ static
from netpoll_cleanup().
PS: This patch was prepared on 2.6.22-rc7 with my other today's patch:
netconsole: fix soft lockup ...
Noticed-by: Oleg Nesterov [EMAIL PROTECTED]
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp 2.6.22-rc7-plus-revert1-/net/core/netpoll.c
2.6.22-rc7-plus
On Mon, Jul 02, 2007 at 01:24:08PM +0400, Oleg Nesterov wrote:
On 07/02, Jarek Poplawski wrote:
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -72,7 +72,8 @@ static void queue_process(struct work_struct *work)
netif_tx_unlock(dev
On Thu, Jun 28, 2007 at 02:55:51PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
On Thu, Jun 28, 2007 at 02:23:36PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
@@ -202,7 +201,6 @@ void gen_kill_estimator(struct gnet_stats_basic
*bstats,
struct gen_estimator *est
On Fri, Jun 29, 2007 at 09:02:41AM +0200, Jarek Poplawski wrote:
...
same *bstats *rate_est more than once (or max twice if we let
to add, change remove them independently).
...but this doesn't look sensible at all!
So, maybe, if we would need something counted with two intervals
On Fri, Jun 29, 2007 at 10:50:20AM +0200, Jean-Baptiste Vignaud wrote:
Update...
I did 2 tests :
1) booted with option acpi=off
It booted correctly, i managed to get some load on one of the card
and after a while (10 minutes i guess) the Timeout occurs. Side effect,
at the same moment the
is only initialized once.
[NET]: gen_estimator: fix locking and timer related bugs
As noticed by Jarek Poplawski [EMAIL PROTECTED], the timer removal in
gen_kill_estimator races with the timer function rearming the timer.
Additionally there are a few more related problems that seem
On Wed, Jun 27, 2007 at 04:53:48PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
On Wed, Jun 27, 2007 at 01:44:08PM +0200, Patrick McHardy wrote:
BTW, maybe I look at this too short, but is this del_timer()
in gen_kill_estimator() enough? I cannot see nothing against
a timer just
On Wed, Jun 27, 2007 at 05:25:45PM +0200, Patrick McHardy wrote:
...
Additionally there are a few more related problems that seem to be
relicts from the timer when the estimator was qdisc specific and
could rely on the rtnl or dev-qdisc_lock:
- the check whether the list is empty and a timer
On Thu, Jun 28, 2007 at 08:54:48AM +0200, Jarek Poplawski wrote:
...
@@ -215,10 +213,7 @@ void gen_kill_estimator(struct gnet_stats_basic
*bstats,
write_unlock_bh(est_lock);
kfree(est);
- killed
On Thu, Jun 28, 2007 at 02:23:36PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
@@ -202,7 +201,6 @@ void gen_kill_estimator(struct gnet_stats_basic
*bstats,
struct gen_estimator *est, **pest;
for (idx=0; idx = EST_MAX_INTERVAL; idx++) {
- int killed = 0
On Thu, Jun 28, 2007 at 02:24:55PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
BTW #2, I hope it's about some new policy, but I cannot see
any #ifdef CONFIG_NET_ESTIMATOR in this sch_htb patch.
One of my previous patches for 2.6.23 killed that option,
the code was always compiled
On Thu, Jun 28, 2007 at 02:55:51PM +0200, Patrick McHardy wrote:
...
Its overkill in that case. The concurrent additions and removals
can't happen.
Then the changelog needs one more change. Plus, maybe - btw,
1 line about this at the beginning of the file?
Jarek P.
-
To unsubscribe from this
Jean-Baptiste Vignaud [EMAIL PROTECTED],
marcin.slusarz [EMAIL PROTECTED],
shemminger [EMAIL PROTECTED]
Subject: Re: [PATCH] 8139cp dev-tx_timeout
References: [EMAIL PROTECTED] [EMAIL PROTECTED]
In-Reply-To: [EMAIL PROTECTED]
On 27-06-2007 10:36, Jeff Garzik wrote:
[EMAIL PROTECTED] wrote:
(second try! sorry)
On 27-06-2007 10:36, Jeff Garzik wrote:
[EMAIL PROTECTED] wrote:
Hello All,
We have been experimenting a couple of interface hangs with the 8139cp
driver. It appears that the tx buffer stops transmitting and never starts
up again in some yet unknown conditions. To be
On 25-06-2007 11:28, Patrick McHardy wrote:
...
It is. This patch I had originally planned for 2.6.23 switches HTB
to the generic estimator, which shouldn't suffer from this.
BTW, maybe I look at this too short, but is this del_timer()
in gen_kill_estimator() enough? I cannot see nothing
On Wed, Jun 27, 2007 at 01:44:08PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
On 25-06-2007 11:28, Patrick McHardy wrote:
...
It is. This patch I had originally planned for 2.6.23 switches HTB
to the generic estimator, which shouldn't suffer from this.
BTW, maybe I look
On Wed, Jun 27, 2007 at 02:10:13PM +0200, Jarek Poplawski wrote:
...
- So if it's not only about kindness, feel free to do it
+ So if it's only about kindness, feel free to do it
Sorry!
Jarek P.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
On Tue, Jun 26, 2007 at 08:10:17AM +0200, Marcin Ślusarz wrote:
...
I reproduced it on minimal config:
...
Hm... This method is usable if you can find such minimal config
with which the bug cannot be reproduced. Then you can add more
until the bug is back. Of course, this takes time...
We know
On Fri, Jun 22, 2007 at 10:56:44AM +0200, Marcin Ślusarz wrote:
...
When I disable on-board network card in BIOS (controlled by skge)
ne2k-pci card is still locking up. So I think it's strictly ne2k-pci
card bug. I made some tests and I know how to reproduce it fast (on my
machine) - just make
On 16-06-2007 23:35, Marcin .lusarz wrote:
hi
after upgrading kernel from 2.6.20 to 2.6.21.3 i'm experiencing really
strange problem - my _both_ network cards dies after random uptime -
sometimes it's a few minutes, sometimes hours, sometimes it does not
happen for a couple of days...
today
On Mon, Jun 18, 2007 at 08:10:00AM -0700, Stephen Hemminger wrote:
On Mon, 18 Jun 2007 13:08:49 +0200
Jarek Poplawski [EMAIL PROTECTED] wrote:
...
It looks like skge driver enables different device than probbed.
Maybe you've something old/wrong about eth0/eth1 in /etc configs?
More likely
On Mon, Jun 18, 2007 at 08:10:00AM -0700, Stephen Hemminger wrote:
On Mon, 18 Jun 2007 13:08:49 +0200
Jarek Poplawski [EMAIL PROTECTED] wrote:
On 16-06-2007 23:35, Marcin .lusarz wrote:
hi
after upgrading kernel from 2.6.20 to 2.6.21.3 i'm experiencing really
strange problem - my
On Tue, Jun 12, 2007 at 01:02:33PM +0200, Jarek Poplawski wrote:
...
Of course such a problem should preferably be fixed by somebody who
knows the code (alas I don't know netconsole), to be sure all needed
cancels are still done after this change. I hope Jason's patch is
right but I'm a little
On Tue, May 29, 2007 at 12:56:28AM -0700, Andrew Morton wrote:
On Sat, 26 May 2007 17:40:12 +0200 Folkert van Heusden [EMAIL PROTECTED]
wrote:
When trying to remove the netconsole module, I got the following kernel
output after a while (couple of minutes iirc):
[525720.117293] BUG:
On Tue, May 15, 2007 at 10:47:25PM -0700, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Wed, 16 May 2007 07:40:00 +0200
After initializing dev-_xmit_lock register_netdevice()
sets lockdep class according to dev-type.
Idea of this patch - by David Miller
On Tue, May 15, 2007 at 11:17:51PM -0700, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Wed, 16 May 2007 08:17:32 +0200
BTW - I think some patch on vlan cannot do any harm (at
least like this previous of mine - with only ppp
considered), and maybe this all could
On Tue, May 15, 2007 at 12:49:47PM +0400, Yuriy N. Shkandybin wrote:
I've patched 2.6.22-rc1 and there was no warnings from lock debugger.
Jura
Many thanks, Jura!
It seems reality is sometimes merciful...
On the other hand I wonder, how all this could stay so long:
a configuration similar
PROTECTED]
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp 2.6.22-/net/core/dev.c 2.6.22/net/core/dev.c
--- 2.6.22-/net/core/dev.c 2007-05-14 20:26:16.0 +0200
+++ 2.6.22/net/core/dev.c 2007-05-16 07:35:22.0 +0200
@@ -116,6 +116,7 @@
#include linux
On Tue, May 15, 2007 at 12:49:47PM +0400, Yuriy N. Shkandybin wrote:
I've patched 2.6.22-rc1 and there was no warnings from lock debugger.
So, you mean only this one patch - without previous vlan patch?
Very interesting...
Thanks once more,
Jarek P.
-
To unsubscribe from this list: send the
301 - 400 of 612 matches
Mail list logo
