Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

2021-04-01 Thread Jason Wang
在 2021/3/31 下午4:11, Michael S. Tsirkin 写道: On Mon, Mar 29, 2021 at 11:06:09AM +0200, Eric Dumazet wrote: On Mon, Mar 29, 2021 at 10:52 AM Xuan Zhuo wrote: On Wed, 13 Jan 2021 08:18:19 -0800, Eric Dumazet wrote: From: Eric Dumazet Both virtio net and napi_get_frags() allocate skbs with a

Re: [PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver

2021-03-26 Thread Jason Wang
在 2021/3/26 下午2:56, Yongji Xie 写道: On Fri, Mar 26, 2021 at 2:16 PM Jason Wang wrote: 在 2021/3/26 下午1:14, Yongji Xie 写道: + } + map->bounce_page = page; + + /* paired with vduse_domain_map_page() */ + smp_mb(); So this is suspicious. It's better to explain like, we n

Re: [PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver

2021-03-25 Thread Jason Wang
在 2021/3/25 下午3:38, Yongji Xie 写道: On Thu, Mar 25, 2021 at 12:53 PM Jason Wang wrote: 在 2021/3/24 下午3:39, Yongji Xie 写道: On Wed, Mar 24, 2021 at 11:54 AM Jason Wang wrote: 在 2021/3/15 下午1:37, Xie Yongji 写道: This implements an MMU-based IOMMU driver to support mapping kernel dma buffer

Re: [PATCH v5 09/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-24 Thread Jason Wang
在 2021/3/24 下午4:55, Yongji Xie 写道: On Wed, Mar 24, 2021 at 12:43 PM Jason Wang wrote: 在 2021/3/15 下午1:37, Xie Yongji 写道: This VDUSE driver enables implementing vDPA devices in userspace. Both control path and data path of vDPA devices will be able to be handled in userspace. In the

Re: [PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver

2021-03-24 Thread Jason Wang
在 2021/3/24 下午3:39, Yongji Xie 写道: On Wed, Mar 24, 2021 at 11:54 AM Jason Wang wrote: 在 2021/3/15 下午1:37, Xie Yongji 写道: This implements an MMU-based IOMMU driver to support mapping kernel dma buffer into userspace. The basic idea behind it is treating MMU (VA->PA) as IOMMU (IOVA->PA

Re: [PATCH v5 10/11] vduse: Add config interrupt support

2021-03-23 Thread Jason Wang
在 2021/3/15 下午1:37, Xie Yongji 写道: This patch introduces a new ioctl VDUSE_INJECT_CONFIG_IRQ to support injecting config interrupt. Signed-off-by: Xie Yongji I suggest to squash this into path 9. Other looks good. Thanks --- drivers/vdpa/vdpa_user/vduse_dev.c | 24 ++

Re: [PATCH v5 09/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-23 Thread Jason Wang
在 2021/3/15 下午1:37, Xie Yongji 写道: This VDUSE driver enables implementing vDPA devices in userspace. Both control path and data path of vDPA devices will be able to be handled in userspace. In the control path, the VDUSE driver will make use of message mechnism to forward the config operation

Re: [PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver

2021-03-23 Thread Jason Wang
在 2021/3/15 下午1:37, Xie Yongji 写道: This implements an MMU-based IOMMU driver to support mapping kernel dma buffer into userspace. The basic idea behind it is treating MMU (VA->PA) as IOMMU (IOVA->PA). The driver will set up MMU mapping instead of IOMMU mapping for the DMA transfer so that the u

Re: [PATCH v5 07/11] vdpa: Support transferring virtual addressing during DMA mapping

2021-03-22 Thread Jason Wang
mapping. And corresponding vma->vm_file and offset will be also passed as an opaque pointer. Suggested-by: Jason Wang Signed-off-by: Xie Yongji --- drivers/vdpa/ifcvf/ifcvf_main.c | 2 +- drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +- drivers/vdpa/vdpa.c | 9 +++- drivers/v

Re: [PATCH v5 06/11] vdpa: factor out vhost_vdpa_pa_map()

2021-03-22 Thread Jason Wang
在 2021/3/15 下午1:37, Xie Yongji 写道: The upcoming patch is going to support VA mapping. So let's factor out the logic of PA mapping firstly to make the code more readable. Suggested-by: Jason Wang Signed-off-by: Xie Yongji Acked-by: Jason Wang While at it, I think it's better

Re: [PATCH v5 03/11] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-03-22 Thread Jason Wang
在 2021/3/15 下午1:37, Xie Yongji 写道: Use vhost_dev->mutex to protect vhost device iotlb from concurrent access. Fixes: 4c8cf318("vhost: introduce vDPA-based backend") Signed-off-by: Xie Yongji Acked-by: Jason Wang Please cc stable for next version. Thanks --- drivers

Re: [PATCH v4 14/14] vdpa_sim_blk: add support for vdpa management tool

2021-03-17 Thread Jason Wang
"block", "mgmtdev": "vdpasim_blk", "vendor_id": 0, "max_vqs": 1, "max_vq_size": 256 } } } # Delete the vDPA device after its use $

Re: [PATCH v4 10/14] vhost/vdpa: Remove the restriction that only supports virtio-net devices

2021-03-17 Thread Jason Wang
failures. Signed-off-by: Xie Yongji Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- drivers/vhost/vdpa.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 7ae4080e57d8..850ed4b62942 100644 --- a/drivers

Re: [PATCH v4 09/14] vhost/vdpa: use get_config_size callback in vhost_vdpa_config_validate()

2021-03-17 Thread Jason Wang
在 2021/3/16 上午12:34, Stefano Garzarella 写道: Let's use the new 'get_config_size()' callback available instead of using the 'virtio_id' to get the size of the device config space. Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- drivers/vhost/vdpa

Re: [PATCH v4 08/14] vdpa: add get_config_size callback in vdpa_config_ops

2021-03-17 Thread Jason Wang
在 2021/3/16 上午12:34, Stefano Garzarella 写道: This new callback is used to get the size of the configuration space of vDPA devices. Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- include/linux/vdpa.h | 4 drivers/vdpa/ifcvf/ifcvf_main.c | 6

Re: [PATCH V5 7/7] vDPA/ifcvf: deduce VIRTIO device ID from pdev ids

2021-03-17 Thread Jason Wang
f (pdev->device < 0x1040) + ret = pdev->subsystem_device; + else + ret = pdev->device - 0x1040; + + return ret; } It would be better to keep the comment. But anyway Acked-by: Jason Wang static u32 ifcvf_vdpa_get_vendor_id(struct vdpa_device *vdpa_dev)

Re: [PATCH V4 7/7] vDPA/ifcvf: deduce VIRTIO device ID from pdev ids

2021-03-16 Thread Jason Wang
在 2021/3/15 下午3:45, Zhu Lingshan 写道: static u32 ifcvf_vdpa_get_device_id(struct vdpa_device *vdpa_dev) { - return VIRTIO_ID_NET; + struct ifcvf_hw *vf = vdpa_to_vf(vdpa_dev); + u32 ret = -EOPNOTSUPP; + + if (ifcvf_probed_virtio_net(vf)) + ret = VIRTIO_I

Re: [PATCH V4 6/7] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-16 Thread Jason Wang
ERR(ifcvf->pdev, "VIRTIO_F_ACCESS_PLATFORM not negotiated\n"); Should be "is not negotiated". Otherwise: Acked-by: Jason Wang + return -EINVAL; + } + + return 0; +} + void ifcvf_read_net_config(struct ifcvf_hw *hw, u64 offset,

Re: [PATCH V4 5/7] vDPA/ifcvf: fetch device feature bits when probe

2021-03-16 Thread Jason Wang
Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_base.c | 12 ++-- drivers/vdpa/ifcvf/ifcvf_base.h | 2 ++ drivers/vdpa/ifcvf/ifcvf_main.c | 2 ++ 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/ifcvf/ifcvf_base.c b/drivers/vdpa/ifcvf

Re: [PATCH V4 4/7] vDPA/ifcvf: remove the version number string

2021-03-15 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: This commit removes the version number string, using kernel version is enough. Signed-off-by: Zhu Lingshan Reviewed-by: Leon Romanovsky Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH V4 3/7] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-15 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-off-by: Zhu Lingshan Acked-by: Jason Wang If you want to have a general driver, you proba

Re: [PATCH V4 2/7] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-15 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_base.h | 5 + drivers/vdpa/ifcvf/ifcvf_main.c | 5 + 2 files changed, 10 insertions

Re: [PATCH V4 1/7] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-15 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 - 1 file changed, 4 insertions

Re: [PATCH] vhost: Fix vhost_vq_reset()

2021-03-15 Thread Jason Wang
_le(vq); vhost_disable_cross_endian(vq); And so user_be is used before being set. To fix that, reverse the lines order as there is no other dependency between them. Signed-off-by: Laurent Vivier Acked-by: Jason Wang --- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [net-next PATCH 07/10] virtio_net: Update driver to use ethtool_sprintf

2021-03-14 Thread Jason Wang
ethtool_sprintf(&p, "tx_queue_%u_%s", i, + virtnet_sq_stats_desc[j].desc); } break; } Acked-by: Jason Wang

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-11 Thread Jason Wang
On 2021/3/12 2:40 下午, Zhu, Lingshan wrote: On 3/12/2021 1:52 PM, Jason Wang wrote: On 2021/3/11 3:19 下午, Zhu, Lingshan wrote: On 3/11/2021 2:20 PM, Jason Wang wrote: On 2021/3/11 12:16 下午, Zhu Lingshan wrote: On 3/11/2021 11:20 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu

Re: [PATCH 2/2] vhost-vdpa: set v->config_ctx to NULL if eventfd_ctx_fdget() fails

2021-03-11 Thread Jason Wang
is case to avoid to use an invalid pointer in other functions such as vhost_vdpa_config_put(). Fixes: 776f395004d8 ("vhost_vdpa: Support config interrupt in vdpa") Cc: lingshan@intel.com Cc: sta...@vger.kernel.org Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- d

Re: [PATCH 1/2] vhost-vdpa: fix use-after-free of v->config_ctx

2021-03-11 Thread Jason Wang
y_SYSCALL_64_after_hwframe+0x44/0xae Fixes: 776f395004d8 ("vhost_vdpa: Support config interrupt in vdpa") Cc: lingshan@intel.com Cc: sta...@vger.kernel.org Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- drivers/vhost/vdpa.c | 4 +++- 1 file changed, 3 insertion

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-11 Thread Jason Wang
On 2021/3/11 3:19 下午, Zhu, Lingshan wrote: On 3/11/2021 2:20 PM, Jason Wang wrote: On 2021/3/11 12:16 下午, Zhu Lingshan wrote: On 3/11/2021 11:20 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: vDPA requres VIRTIO_F_ACCESS_PLATFORM as a must, this commit examines this

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-10 Thread Jason Wang
On 2021/3/11 12:16 下午, Zhu Lingshan wrote: On 3/11/2021 11:20 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: vDPA requres VIRTIO_F_ACCESS_PLATFORM as a must, this commit examines this when set features. Signed-off-by: Zhu Lingshan ---   drivers/vdpa/ifcvf/ifcvf_base.c

Re: [PATCH V3 3/6] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-10 Thread Jason Wang
On 2021/3/11 12:23 下午, Zhu Lingshan wrote: On 3/11/2021 11:25 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-o

Re: [PATCH V3 1/6] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-10 Thread Jason Wang
On 2021/3/11 12:21 下午, Zhu Lingshan wrote: On 3/11/2021 11:23 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan

Re: [PATCH V3 3/6] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-10 Thread Jason Wang
On 2021/3/10 5:00 下午, Zhu Lingshan wrote: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 8 drivers/vdpa/ifcvf/ifcvf_main

Re: [PATCH V3 1/6] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-10 Thread Jason Wang
On 2021/3/10 5:00 下午, Zhu Lingshan wrote: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-10 Thread Jason Wang
On 2021/3/10 5:00 下午, Zhu Lingshan wrote: vDPA requres VIRTIO_F_ACCESS_PLATFORM as a must, this commit examines this when set features. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.c | 8 drivers/vdpa/ifcvf/ifcvf_base.h | 1 + drivers/vdpa/ifcvf/ifcvf_main.c | 5

Re: [RFC v4 07/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-10 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: + + switch (cmd) { + case VDUSE_IOTLB_GET_FD: { + struct vduse_iotlb_entry entry; + struct vhost_iotlb_map *map; + struct vdpa_map_file *map_file; + struct file *f = NULL; + +

Re: [PATCH v7 net-next] virtio-net: support XDP when not more queues

2021-03-08 Thread Jason Wang
On 2021/3/9 10:31 上午, Xuan Zhuo wrote: On Tue, 9 Mar 2021 10:17:16 +0800, Jason Wang wrote: On 2021/3/8 4:52 下午, Xuan Zhuo wrote: The number of queues implemented by many virtio backends is limited, especially some machines have a large number of CPUs. In this case, it is often impossible

Re: [PATCH V2 2/4] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-08 Thread Jason Wang
On 2021/3/9 10:28 上午, Zhu, Lingshan wrote: On 3/9/2021 10:23 AM, Jason Wang wrote: On 2021/3/8 4:35 下午, Zhu Lingshan wrote: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA Signed-off-by: Zhu Lingshan ---   drivers/vdpa/ifcvf/ifcvf_base.h | 5 +   drivers/vdpa

Re: [PATCH V2 4/4] vDPA/ifcvf: remove the version number string

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: This commit removes the version number string, using kernel version is enough. Signed-off-by: Zhu Lingshan --- Acked-by: Jason Wang drivers/vdpa/ifcvf/ifcvf_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/vdpa/ifcvf

Re: [PATCH V2 3/4] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-off-by: Zhu Lingshan Acked-by: Jason Wang You probably need to rename the drive

Re: [PATCH V2 2/4] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 5 + drivers/vdpa/ifcvf/ifcvf_main.c | 5 + 2 files changed, 10 insertions(+) diff --git a/drivers/vdpa

Re: [PATCH V2 1/4] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 - 1 file changed, 4

Re: [PATCH v7 net-next] virtio-net: support XDP when not more queues

2021-03-08 Thread Jason Wang
(suggested by Jason Wang) v6: 1. use __netif_tx_acquire()/__netif_tx_release(). (suggested by Jason Wang) 2. add note for why not lock. (suggested by Jason Wang) 3. Use variable 'flag' to record with or without locked. It is not safe to use curr_queue_pairs in "vir

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-07 Thread Jason Wang
On 2021/3/8 3:16 下午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 3:02 PM Jason Wang wrote: On 2021/3/8 12:50 下午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 11:04 AM Jason Wang wrote: On 2021/3/5 4:12 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: On 2021/3/5 3:27 下午

Re: [PATCH v6 net-next] virtio-net: support XDP when not more queues

2021-03-07 Thread Jason Wang
On 2021/3/8 1:43 下午, Xuan Zhuo wrote: On Mon, 8 Mar 2021 11:41:03 +0800, Jason Wang wrote: On 2021/3/5 6:29 下午, Xuan Zhuo wrote: The number of queues implemented by many virtio backends is limited, especially some machines have a large number of CPUs. In this case, it is often impossible to

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-07 Thread Jason Wang
On 2021/3/8 1:05 下午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 11:52 AM Jason Wang wrote: On 2021/3/8 11:45 上午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 11:17 AM Jason Wang wrote: On 2021/3/5 3:59 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:27 PM Jason Wang wrote: On 2021/3/5 3:13 下

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-07 Thread Jason Wang
On 2021/3/8 12:50 下午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 11:04 AM Jason Wang wrote: On 2021/3/5 4:12 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: On 2021/3/5 3:27 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: On 2021/3/5 2:36 下午

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-07 Thread Jason Wang
On 2021/3/8 11:45 上午, Yongji Xie wrote: On Mon, Mar 8, 2021 at 11:17 AM Jason Wang wrote: On 2021/3/5 3:59 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:27 PM Jason Wang wrote: On 2021/3/5 3:13 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 2:52 PM Jason Wang wrote: On 2021/3/5 2:15 下午

Re: [PATCH v6 net-next] virtio-net: support XDP when not more queues

2021-03-07 Thread Jason Wang
Wang) 2. add note for why not lock. (suggested by Jason Wang) 3. Use variable 'flag' to record with or without locked. It is not safe to use curr_queue_pairs in "virtnet_put_xdp_sq", because it may changed after "virtnet_get_xdp_sq". v5

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-07 Thread Jason Wang
On 2021/3/5 3:59 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:27 PM Jason Wang wrote: On 2021/3/5 3:13 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 2:52 PM Jason Wang wrote: On 2021/3/5 2:15 下午, Yongji Xie wrote: Sorry if I've asked this before. But what's the reason for m

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-07 Thread Jason Wang
On 2021/3/5 4:12 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: On 2021/3/5 3:27 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: On 2021/3/5 2:36 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: On 2021/3/5 11:30 上午

Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-07 Thread Jason Wang
On 2021/3/5 10:19 下午, Zhu Lingshan wrote: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA. C5000X-PL vendor id 0x1AF4, device id 0x1000, subvendor id 0x8086, sub device id 0x0001 To distinguish C5000X-PL from other ifcvf driven devices, the original ifcvf device is named

Re: [PATCH 1/3] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-07 Thread Jason Wang
ifcvf_vdpa_get_vendor_id(struct vdpa_device *vdpa_dev) { - return IFCVF_SUBSYS_VENDOR_ID; + struct ifcvf_adapter *adapter = vdpa_to_adapter(vdpa_dev); + struct pci_dev *pdev = adapter->pdev; + + return pdev->subsystem_vendor; } Acked-by: Jason Wang stat

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Jason Wang
On 2021/3/5 3:27 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: On 2021/3/5 2:36 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: On 2021/3/5 11:30 上午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:05 AM Jason Wang wrote: On 2021/3/4 4:58 下

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-04 Thread Jason Wang
On 2021/3/5 3:13 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 2:52 PM Jason Wang wrote: On 2021/3/5 2:15 下午, Yongji Xie wrote: Sorry if I've asked this before. But what's the reason for maintaing a dedicated IOTLB here? I think we could reuse vduse_dev->iommu since the devi

Re: [PATCH v5 net-next] virtio-net: support XDP when not more queues

2021-03-04 Thread Jason Wang
On 2021/3/1 11:22 上午, Xuan Zhuo wrote: The number of queues implemented by many virtio backends is limited, especially some machines have a large number of CPUs. In this case, it is often impossible to allocate a separate queue for XDP_TX/XDP_REDIRECT, then xdp cannot be loaded to work, even xd

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Jason Wang
On 2021/3/5 2:36 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: On 2021/3/5 11:30 上午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:05 AM Jason Wang wrote: On 2021/3/4 4:58 下午, Yongji Xie wrote: On Thu, Mar 4, 2021 at 2:59 PM Jason Wang wrote: On 2021/2/23 7:50

Re: [RFC v4 11/11] vduse: Support binding irq to the specified cpu

2021-03-04 Thread Jason Wang
On 2021/3/5 11:37 上午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:11 AM Jason Wang wrote: On 2021/3/4 4:19 下午, Yongji Xie wrote: On Thu, Mar 4, 2021 at 3:30 PM Jason Wang wrote: On 2021/2/23 7:50 下午, Xie Yongji wrote: Add a parameter for the ioctl VDUSE_INJECT_VQ_IRQ to support

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Jason Wang
On 2021/3/5 11:30 上午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:05 AM Jason Wang wrote: On 2021/3/4 4:58 下午, Yongji Xie wrote: On Thu, Mar 4, 2021 at 2:59 PM Jason Wang wrote: On 2021/2/23 7:50 下午, Xie Yongji wrote: This patch introduces a workqueue to support injecting virtqueue&#

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-04 Thread Jason Wang
On 2021/3/4 1:12 下午, Yongji Xie wrote: On Thu, Mar 4, 2021 at 12:21 PM Jason Wang wrote: On 2021/2/23 7:50 下午, Xie Yongji wrote: This implements a MMU-based IOMMU driver to support mapping kernel dma buffer into userspace. The basic idea behind it is treating MMU (VA->PA) as IOMMU (I

Re: [RFC v4 07/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-04 Thread Jason Wang
On 2021/3/4 4:05 下午, Yongji Xie wrote: On Thu, Mar 4, 2021 at 2:27 PM Jason Wang wrote: On 2021/2/23 7:50 下午, Xie Yongji wrote: This VDUSE driver enables implementing vDPA devices in userspace. Both control path and data path of vDPA devices will be able to be handled in userspace. In the

Re: [RFC v4 11/11] vduse: Support binding irq to the specified cpu

2021-03-04 Thread Jason Wang
On 2021/3/4 4:19 下午, Yongji Xie wrote: On Thu, Mar 4, 2021 at 3:30 PM Jason Wang wrote: On 2021/2/23 7:50 下午, Xie Yongji wrote: Add a parameter for the ioctl VDUSE_INJECT_VQ_IRQ to support injecting virtqueue's interrupt to the specified cpu. How userspace know which CPU is this ir

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Jason Wang
On 2021/3/4 4:58 下午, Yongji Xie wrote: On Thu, Mar 4, 2021 at 2:59 PM Jason Wang wrote: On 2021/2/23 7:50 下午, Xie Yongji wrote: This patch introduces a workqueue to support injecting virtqueue's interrupt asynchronously. This is mainly for performance considerations which makes sur

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-04 Thread Jason Wang
On 2021/3/4 9:50 下午, Cornelia Huck wrote: On Thu, 4 Mar 2021 16:24:16 +0800 Jason Wang wrote: On 2021/3/3 4:29 下午, Cornelia Huck wrote: On Wed, 3 Mar 2021 12:01:01 +0800 Jason Wang wrote: On 2021/3/2 8:08 下午, Cornelia Huck wrote: On Mon, 1 Mar 2021 11:51:08 +0800 Jason Wang wrote

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-04 Thread Jason Wang
On 2021/3/3 4:29 下午, Cornelia Huck wrote: On Wed, 3 Mar 2021 12:01:01 +0800 Jason Wang wrote: On 2021/3/2 8:08 下午, Cornelia Huck wrote: On Mon, 1 Mar 2021 11:51:08 +0800 Jason Wang wrote: On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote: On Fri, Feb 26, 2021 at 04:19:16PM +0800, Jason

Re: [RFC v4 11/11] vduse: Support binding irq to the specified cpu

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: Add a parameter for the ioctl VDUSE_INJECT_VQ_IRQ to support injecting virtqueue's interrupt to the specified cpu. How userspace know which CPU is this irq for? It looks to me we need to do it at different level. E.g introduce some API in sys to all

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: This patch introduces a workqueue to support injecting virtqueue's interrupt asynchronously. This is mainly for performance considerations which makes sure the push() and pop() for used vring can be asynchronous. Do you have pref numbers for this patch

Re: [RFC v4 09/11] Documentation: Add documentation for VDUSE

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: VDUSE (vDPA Device in Userspace) is a framework to support implementing software-emulated vDPA devices in userspace. This document is intended to clarify the VDUSE design and usage. Signed-off-by: Xie Yongji --- Documentation/userspace-api/index.rst |

Re: [RFC v4 07/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: This VDUSE driver enables implementing vDPA devices in userspace. Both control path and data path of vDPA devices will be able to be handled in userspace. In the control path, the VDUSE driver will make use of message mechnism to forward the config opera

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: This implements a MMU-based IOMMU driver to support mapping kernel dma buffer into userspace. The basic idea behind it is treating MMU (VA->PA) as IOMMU (IOVA->PA). The driver will set up MMU mapping instead of IOMMU mapping for the DMA transfer so that t

Re: [RFC v4 05/11] vdpa: Support transferring virtual addressing during DMA mapping

2021-03-03 Thread Jason Wang
mapping. And corresponding vma->vm_file and offset will be also passed as an opaque pointer. Suggested-by: Jason Wang Signed-off-by: Xie Yongji --- drivers/vdpa/ifcvf/ifcvf_main.c | 2 +- drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +- drivers/vdpa/vdpa.c | 9 +++- driv

Re: [PATCH] vhost-vdpa: honor CAP_IPC_LOCK

2021-03-02 Thread Jason Wang
On 2021/3/2 5:51 下午, Michael S. Tsirkin wrote: On Tue, Mar 02, 2021 at 04:14:18AM -0500, Jason Wang wrote: When CAP_IPC_LOCK is set we should not check locked memory against rlimit as what has been implemented in mlock(). Signed-off-by: Jason Wang Indeed and it's not just

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-02 Thread Jason Wang
On 2021/3/2 5:47 下午, Michael S. Tsirkin wrote: On Mon, Mar 01, 2021 at 11:56:50AM +0800, Jason Wang wrote: On 2021/3/1 5:34 上午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 10:24:41AM -0800, Si-Wei Liu wrote: Detecting it isn't enough though, we will need a new ioctl to notif

[PATCH V2] vhost-vdpa: honor CAP_IPC_LOCK

2021-03-02 Thread Jason Wang
ility. " Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend") Signed-off-by: Jason Wang --- drivers/vhost/vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index ef688c8c0e0e..e93572e2e344 100644 --- a/

[PATCH] vhost-vdpa: honor CAP_IPC_LOCK

2021-03-02 Thread Jason Wang
When CAP_IPC_LOCK is set we should not check locked memory against rlimit as what has been implemented in mlock(). Signed-off-by: Jason Wang --- drivers/vhost/vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index

Re: [RFC v4 04/11] vdpa: Add an opaque pointer for vdpa_config_ops.dma_map()

2021-03-02 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: Add an opaque pointer for DMA mapping. Suggested-by: Jason Wang Signed-off-by: Xie Yongji Acked-by: Jason Wang --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 6 +++--- drivers/vhost/vdpa.c | 2 +- include/linux/vdpa.h | 2

Re: [RFC v4 03/11] vhost-iotlb: Add an opaque pointer for vhost IOTLB

2021-03-02 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: Add an opaque pointer for vhost IOTLB. And introduce vhost_iotlb_add_range_ctx() to accept it. Suggested-by: Jason Wang Signed-off-by: Xie Yongji Acked-by: Jason Wang --- drivers/vhost/iotlb.c | 20 include/linux

Re: [RFC v4 01/11] eventfd: Increase the recursion depth of eventfd_signal()

2021-03-02 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: Increase the recursion depth of eventfd_signal() to 1. This is the maximum recursion depth we have found so far. Signed-off-by: Xie Yongji Acked-by: Jason Wang It might be useful to explain how/when we can reach for this condition. Thanks

Re: [RFC v4 02/11] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-03-02 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: Use vhost_dev->mutex to protect vhost device iotlb from concurrent access. Fixes: 4c8cf318("vhost: introduce vDPA-based backend") Signed-off-by: Xie Yongji --- drivers/vhost/vdpa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/vhost/v

Re: [PATCH] vdpa/mlx5: Fix wrong use of bit numbers

2021-02-28 Thread Jason Wang
t;) Signed-off-by: Eli Cohen Acked-by: Jason Wang --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index dc7031132fff..7d21b857a94a 100644 --- a/drivers/vdp

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-28 Thread Jason Wang
On 2021/3/1 5:34 上午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 10:24:41AM -0800, Si-Wei Liu wrote: Detecting it isn't enough though, we will need a new ioctl to notify the kernel that it's a legacy guest. Ugh :( Well, although I think adding an ioctl is doable, may I know what the use

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-28 Thread Jason Wang
On 2021/3/1 5:30 上午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 05:30:37PM +0800, Jason Wang wrote: On 2021/2/24 4:43 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 04:26:43PM +0800, Jason Wang wrote: Basically on first guest access QEMU would tell kernel whether

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-28 Thread Jason Wang
On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote: On Fri, Feb 26, 2021 at 04:19:16PM +0800, Jason Wang wrote: On 2021/2/26 2:53 上午, Michael S. Tsirkin wrote: On Thu, Feb 25, 2021 at 12:36:07PM +0800, Jason Wang wrote: On 2021/2/24 7:12 下午, Cornelia Huck wrote: On Wed, 24 Feb 2021 17:29:07

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-26 Thread Jason Wang
On 2021/2/26 2:53 上午, Michael S. Tsirkin wrote: On Thu, Feb 25, 2021 at 12:36:07PM +0800, Jason Wang wrote: On 2021/2/24 7:12 下午, Cornelia Huck wrote: On Wed, 24 Feb 2021 17:29:07 +0800 Jason Wang wrote: On 2021/2/23 6:58 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 18:31:07 +0800 Jason

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-24 Thread Jason Wang
On 2021/2/24 7:12 下午, Cornelia Huck wrote: On Wed, 24 Feb 2021 17:29:07 +0800 Jason Wang wrote: On 2021/2/23 6:58 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 18:31:07 +0800 Jason Wang wrote: On 2021/2/23 6:04 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 17:46:20 +0800 Jason Wang

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-24 Thread Jason Wang
On 2021/2/23 6:17 下午, Jason Wang wrote: On 2021/2/23 6:01 下午, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 05:46:20PM +0800, Jason Wang wrote: On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: On 2/21/2021 8:14 PM, Jason Wang

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-24 Thread Jason Wang
On 2021/2/24 4:43 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 04:26:43PM +0800, Jason Wang wrote: Basically on first guest access QEMU would tell kernel whether guest is using the legacy or the modern interface. E.g. virtio_pci_config_read/virtio_pci_config_write will

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-24 Thread Jason Wang
On 2021/2/23 6:58 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 18:31:07 +0800 Jason Wang wrote: On 2021/2/23 6:04 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 17:46:20 +0800 Jason Wang wrote: On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/24 2:47 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 08:45:20AM +0200, Eli Cohen wrote: On Wed, Feb 24, 2021 at 12:17:58AM -0500, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 11:20:01AM +0800, Jason Wang wrote: On 2021/2/24 3:35 上午, Si-Wei Liu wrote: On 2/23/2021 5

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/24 2:46 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 02:04:36PM +0800, Jason Wang wrote: On 2021/2/24 1:04 下午, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/24 1:04 下午, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: On 2021/2/23 9:12 上午, Si-Wei Liu wrote: On 2/21/2021 11:34 PM, Michael S

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/24 1:17 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 11:20:01AM +0800, Jason Wang wrote: On 2021/2/24 3:35 上午, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: On 2021/2/23 9:12 上午, Si-Wei Liu

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/24 3:35 上午, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: On 2021/2/23 9:12 上午, Si-Wei Liu wrote: On 2/21/2021 11:34 PM, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 12:14:17PM +0800, Jason

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/23 6:04 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 17:46:20 +0800 Jason Wang wrote: On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: On 2/21/2021 8:14 PM, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu wrote

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/23 6:01 下午, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 05:46:20PM +0800, Jason Wang wrote: On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: On 2/21/2021 8:14 PM, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/23 下午5:26, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 08:05:26AM +0200, Eli Cohen wrote: On Sun, Feb 21, 2021 at 04:52:05PM -0500, Michael S. Tsirkin wrote: On Sun, Feb 21, 2021 at 04:44:37PM +0200, Eli Cohen wrote: On Fri, Feb 19, 2021 at 06:54:58AM -0500, Si-Wei Liu wrote:

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/23 下午5:25, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote: On 2/21/2021 8:14 PM, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu wrote: Commit 452639a64ad8 ("vdpa: make sure set_features is invoked for legacy") made an exception

Re: [PATCH 2/2 v1] vdpa/mlx5: Enable user to add/delete vdpa device

2021-02-22 Thread Jason Wang
name vdpa0 3. Show vdpa devices $ vdpa dev show vdpa0: type network mgmtdev pci/:3b:00.1 vendor_id max_vqs 16 \ max_vq_size 256 Signed-off-by: Eli Cohen Reviewed-by: Parav Pandit Acked-by: Jason Wang --- v0->v1: set mgtdev->ndev NULL on dev delete drivers/vdpa/ml

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-22 Thread Jason Wang
On 2021/2/23 1:09 上午, Si-Wei Liu wrote: On 2/21/2021 8:14 PM, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu wrote: Commit 452639a64ad8 ("vdpa: make sure set_features is invoked for legacy") made an exception for legacy guests to reset features to 0, when config space i

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-22 Thread Jason Wang
On 2021/2/23 9:12 上午, Si-Wei Liu wrote: On 2/21/2021 11:34 PM, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 12:14:17PM +0800, Jason Wang wrote: On 2021/2/19 7:54 下午, Si-Wei Liu wrote: Commit 452639a64ad8 ("vdpa: make sure set_features is invoked for legacy") made an exc

<    1   2   3   4   5   6   7   8   9   10   >