functions calling it. Updated header comments in affected functions to
reflect proper reality of locking requirements.
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_alb.c | 18 --
drivers/net/bonding/bond_main.c | 14 --
2 files chang
her locks. This is so that the lower level
mode-specific functions (notably for balance-alb mode) can release locks
down to just rtnl in order to call, e.g., dev_set_mac_address with the
locks it expects (rtnl only).
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
Signed-off-by: Andy Gospodare
Fix all call paths into alb_fasten_mac_swap to hold only RTNL.
Eliminates deadlock and silences warnings.
Patches are against the current netdev-2.6#upstream branch.
Please apply for 2.6.24.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL
t;>
>> >>
>> >>On Fri, 14 Dec 2007, Andy Gospodarek wrote:
>> >>
>> >>>On Fri, Dec 14, 2007 at 07:57:42PM +0100, Krzysztof Oledzki wrote:
>> >>>>
>> >>>>
>> >>>>On Fri, 14 Dec 2007, Andy Gosp
Jari Takkala <[EMAIL PROTECTED]> wrote:
>On Wednesday, January 02, 2008 17:24, Jay Vosburgh wrote:
>> What advantage does this have over:
>>
>> # echo +bond5 > /sys/class/net/bonding_masters
>>
>> which will create a new bonding maste
already-loaded
driver?
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
her locks. This is so that the lower level
mode-specific functions can release locks down to just rtnl in order to
call, e.g., dev_set_mac_address with the locks it expects (rtnl only).
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
diff --git a/drivers/net/bonding/bond_sysfs.c b/driver
igned-off-by: Ferenc Wagner <[EMAIL PROTECTED]>
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_sysfs.c | 21 +++--
1 files changed, 3 insertions(+), 18 deletions(-)
diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.
to return
nothing at all if not applicable, not even a '\n'.
I find this behaviour more usual, more useful, more efficient
and shorter to code from both sides.
Signed-off-by: Ferenc Wagner <[EMAIL PROTECTED]>
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/
From: Wagner Ferenc <[EMAIL PROTECTED]>
From: Wagner Ferenc <[EMAIL PROTECTED]>
Code for rendering multivalue sysfs files occurs three times
in this module. Rename 'buffer' to 'buf' in the first, for
the sake of consistency.
Signed-off-by: Ferenc Wagner &
From: Wagner Ferenc <[EMAIL PROTECTED]>
From: Wagner Ferenc <[EMAIL PROTECTED]>
Adhere to coding style: break line after the if condition
Signed-off-by: Ferenc Wagner <[EMAIL PROTECTED]>
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_sysfs.c |
y also have to swallow back a trailing
space.
Signed-off-by: Ferenc Wagner <[EMAIL PROTECTED]>
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_sysfs.c | 66 +
1 files changed, 30 insertions(+), 36 deletions(-)
diff --git a/
Add new hash for balance-xor and 802.3ad modes. Originally
submitted by "Glenn Griffin" <[EMAIL PROTECTED]>; modified by
Jay Vosburgh to move setting of hash policy out of line, tweak the
documentation update and add version update to 3.2.2.
Glenn's ori
From: David Sterba <[EMAIL PROTECTED]>
From: David Sterba <[EMAIL PROTECTED]>
Use macros for comparing jiffies. Jiffies' wrap caused missed events and hangs.
Module reinsert was needed to make bonding work again.
Signed-off-by: David Sterba <[EMAIL PROTECTED]>
Acked-b
Fixes a race condition in module unload. Without this change,
workqueue events may fire while bonding data structures are partially
freed but before bond_close() is invoked by unregister_netdevice().
Update version to 3.2.3.
Signed-off-by: Jay Vosburgh <[EMAIL PROTEC
g and querying xmit policy regardless of mode
[PATCH 6/8] bonding: Fix time comparison
[PATCH 7/8] bonding: Add new layer2+3 hash for xor/802.3ad modes
[PATCH 8/8] bonding: Fix race at module unload
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
--
To unsubscribe
o have the
bond_arp_send() function perform a neigh_lookup() prior to calling
arp_create(), and use the result of the lookup (if any) in the
arp_create() call.
So, no, with the caveat that I haven't tried it, I don't see a
reason that bonding couldn't do what you're looking
), and remove the mode test from
bonding_store_xmit_hash().
This would be consistent with the way the arp_ip_target option
is treated: the actual value is always displayed, even if it is not
used, and it is legal to change the value, regardless of the mode.
Other than this, I
PROTECTED]>.
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
diff --git a/Documentation/networking/bonding.txt
b/Documentation/networking/bonding.txt
index 1134062..eda0f06 100644
--- a/Documentation/networking/bonding.txt
+++ b/Documentation/networking/bondin
Fix bond_destroy and bond_free_all to not reference the
struct net_device after calling unregister_netdevice.
Bug and offending change reported by Moni Shoua <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
Copying DaveM since Jeff
levels of badness, as it were). Needed to fix a couple "no workee"
things first.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PR
zeroes.
Patches are against linux-2.6, and apply cleanly
to netdev-2.6#upstream-linus. Please apply for 2.6.24.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the
e dev->validate_addr to NULL. The master still can't
end up with an invalid address, as the set_mac_address function tests
for validity.
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_main.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff
l, and the
second correctly acquires and releases rtnl.
Bug reported by Moni Shoua <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_sysfs.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/
-2.6 git kernel, and I'm not seeing the failure you
describe. Can you provide some step by step instructions, including the
type of system, bonding mode, options, number and type of slaves, etc,
to induce the failure?
-J
---
-Jay Vosburgh, IBM Linux Technology Cente
standard term for what we're
talking about here, but it's a Cisco trademark. I'd guess that most
switch vendors don't come right out and call their "EtherChannel(tm)
compatible" mode exactly that; they call it something else, but it's
still meant to be compatibl
ll work for any peer
(some peers may not reply to an ARP with an IP source of all zeros). At
first glance, there doesn't seem to be much of a downside, but I'll have
to experiment with it a bit to see if the check should be optional or
simply removed entirely.
-J
---
-Jay V
or example, "trunking"
is also used to describe a type of switch port, and "aggregation" or
"link aggregation" is often used to refer to 802.3ad link aggregation,
which is compatible with bonding's 802.3ad mode, but not balance-rr.
Thoughts?
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Adrian Bunk <[EMAIL PROTECTED]> wrote:
>This patch fixes a cut'n'paste error in
>commit 1b76b31693d4a6088dec104ff6a6ead54081a3c2.
>
>Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Please apply.
-J
Acked-
one Signed-off and one Acked).
>2) vague subject line. [...]
Sorry about that; will keep it in mind next time.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
org); this isn't a feature add or a refactor just for
efficiency.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jay Vosburgh <[EMAIL PROTECTED]> wrote:
> 1- copy header_ops from slave to bonding for IPoIB slaves
> 2- move release and destroy logic to UNREGISTER from GOING_DOWN
> notifier to prevent double release
>
> Set bonding to version 3.2.1.
>-
Update ALB mode monitor to hold correct locks (RTNL and nothing
else) when calling dev_set_promiscuity.
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_alb.c | 19 ++-
1 files
Convert more lock acquisitions to _bh flavor to avoid deadlock
with workqueue activity and add acquisition of RTNL in appropriate places.
Affects ALB mode, as well as core bonding functions and sysfs.
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh &
sed).
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_main.c | 70 --
1 files changed, 51 insertions(+), 19 deletions(-)
diff --git a/drivers/net/bonding/bond_main.
Convert locking-related activity to new & improved system.
Convert some lock acquisitions to _bh and rework parts of ALB mode, both
to avoid deadlocks with workqueue activity.
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]&
Gospodarek <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_3ad.c |6 +-
drivers/net/bonding/bond_3ad.h |2 +-
drivers/net/bonding/bond_alb.c |6 +-
drivers/net/bonding/bond_alb.h |2 +-
drivers/net/bonding/bond_ma
lock ordering
constraints.
These changes were developed and extensively tested by Andy
Gospodarek <[EMAIL PROTECTED]> and myself over the last few months.
Patches are relative to linux-2.6.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED
1- copy header_ops from slave to bonding for IPoIB slaves
2- move release and destroy logic to UNREGISTER from GOING_DOWN
notifier to prevent double release
Set bonding to version 3.2.1.
---
drivers/net/bonding/bond_main.c | 11 +--
drivers/net/bonding
eliminates
a deadlock introduced by the conversion to work queues.
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_main.c | 25 -
drivers/net/bonding/bonding.h |1 +
2 files
Shoua
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_main.c | 11 +--
drivers/net/bonding/bonding.h |4 ++--
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index d
Jeff Garzik <[EMAIL PROTECTED]> wrote:
>Jay Vosburgh wrote:
>> Since I see you've just pushed it, do you want a patch to
>> correct just the two individual things, or would you rather have new
>> patches?
>
>
>On top of what was just pushed, please.
, do you want a patch to
correct just the two individual things, or would you rather have new
patches?
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jeff Garzik <[EMAIL PROTECTED]> wrote:
>Jay Vosburgh wrote:
>> Convert bonding timers to workqueues. This converts the various
>> monitor functions to run in periodic work queues instead of timers. This
>> patch introduces the framework and convers the
yncing: Fatal exception in interrupt
I haven't investigated this further. I'm using a BCM5704 card;
if this isn't a known problem and anyone is curious, I can supply
additional info.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECT
Convert more lock acquisitions to _bh flavor to avoid deadlock
with workqueue activity and add acquisition of RTNL in appropriate places.
Affects ALB mode, as well as core bonding functions and sysfs.
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh &
sed).
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_main.c | 70 --
1 files changed, 51 insertions(+), 19 deletions(-)
diff --git a/drivers/net/bonding/bond_main.
Update ALB mode monitor to hold correct locks (RTNL and nothing
else) when calling dev_set_promiscuity.
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_alb.c | 19 ++-
1 files
Gospodarek <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_3ad.c |6 +-
drivers/net/bonding/bond_3ad.h |2 +-
drivers/net/bonding/bond_alb.c |6 +-
drivers/net/bonding/bond_alb.h |2 +-
drivers/net/bonding/bond_ma
Convert locking-related activity to new & improved system.
Convert some lock acquisitions to _bh and rework parts of ALB mode, both
to avoid deadlocks with workqueue activity.
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]&
eliminates
a deadlock introduced by the conversion to work queues.
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_main.c | 25 -
drivers/net/bonding/bonding.h |1 +
2 files
lock ordering
constraints.
These changes were developed and extensively tested by Andy
Gospodarek <[EMAIL PROTECTED]> and myself over the last few months.
Patches are relative to netdev-2.6#upstream.
-J
---
-Jay Vosburgh, IBM Linux Technology Center,
s automatically enabled for IB
slaves), applicable only to active-backup mode.
Includes documentation update.
Updates bonding driver version to 3.2.0.
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
[ Fixed this copy; the previous posting lost the explan
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
Documentation/networking/bonding.txt | 33 +++
drivers/net/bonding/bond_main.c | 57 +
drivers/net/bonding/bond_sysfs.c | 49 +
drivers/net/b
s are still valid. Destroying the bond
when slave_cnt is zero
ensures that these functions be used anymore.
Signed-off-by: Moni Shoua
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_main.c | 38 ++
drivers/net/bonding/bo
ddress. This is b/c ip_eth_mc_map() is called
where for multicast joins taking place after the enslavement another
ip_xxx_mc_map()
is called (eg ip_ib_mc_map() when the bond type is ARPHRD_INFINIBAND)
Signed-off-by: Moni Shoua
Signed-off-by: Or Gerlitz
Acked-by: Jay Vosburgh <[EMAIL
From: Moni Shoua <[EMAIL PROTECTED]>
bonding sometimes uses Ethernet constants (such as MTU and address length) which
are not good when it enslaves non Ethernet devices (such as InfiniBand).
Signed-off-by: Moni Shoua
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers
From: Moni Shoua <[EMAIL PROTECTED]>
Delay sending a gratuitous_arp when LINK_STATE_LINKWATCH_PENDING bit
in dev->state field is on. This improves the chances for the arp packet to
be transmitted.
Signed-off-by: Moni Shoua
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
driv
by: Or Gerlitz
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_main.c | 33 +
1 files changed, 33 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 64bfec3..6ae4593
ent by bonding when fail-over occurs
(this is already done by the bonding code).
Signed-off-by: Moni Shoua
Signed-off-by: Or Gerlitz
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_main.c | 87 ++
drivers/net/bonding/bonding.h
From: Moni Shoua <[EMAIL PROTECTED]>
IPoIB uses a two layer neighboring scheme, such that for each struct neighbour
whose device is an ipoib one, there is a struct ipoib_neigh buddy which is
created on demand at the tx flow by an ipoib_neigh_alloc(skb->dst->neighbour)
call.
When using the bonding
From: Moni Shoua <[EMAIL PROTECTED]>
When the bonding device senses a carrier loss of its active slave it replaces
that slave with a new one. In between the times when the carrier of an IPoIB
device goes down and ipoib_neigh is destroyed, it is possible that the
bonding driver will send a packet o
9 patch series providing IPoIB support for bonding
This should correct the compile errors from the last posting; it
builds ok for me against netdev-2.6 upstream pulled about an hour ago.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To
email
>> > subject lines did not contain a notion of ordering "[PATCH 1/9] ...".
>> > But other than that, the git-send-email went flawlessly.
>>
>> unfortunately it does not seem to build flawlessly:
>
>Yeah it doesn't handle Stephen Hemmingers h
Jeff Garzik <[EMAIL PROTECTED]> wrote:
>Moni Shoua wrote:
>> Jay Vosburgh wrote:
>>> ACK patches 3 - 9.
>>>
>>> Roland, are you comfortable with the IB changes in patches 1 and 2?
>>>
>>> Jeff, when Roland acks patches 1 and 2,
ACK patches 3 - 9.
Roland, are you comfortable with the IB changes in patches 1 and 2?
Jeff, when Roland acks patches 1 and 2, please apply all 9.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
Moni Shoua <[EMAIL PROTECTED]>
e would make the ipoib module
dependent upon having the bonding module loaded (to resolve all of the
symbols)?
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
s automatically enabled for IB
slaves), applicable only to active-backup mode.
Includes documentation update.
Updates bonding driver version to 3.2.0.
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
Documentation/networking/bonding.txt | 33 +++
drivers
s are still valid. Destroying the bond
when slave_cnt is zero
ensures that these functions be used anymore.
Signed-off-by: Moni Shoua <[EMAIL PROTECTED]>
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_main.c | 45 +
From: Moni Shoua <[EMAIL PROTECTED]>
bonding sometimes uses Ethernet constants (such as MTU and address length) which
are not good when it enslaves non Ethernet devices (such as InfiniBand).
Signed-off-by: Moni Shoua <[EMAIL PROTECTED]>
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
From: Moni Shoua <[EMAIL PROTECTED]>
Delay sending a gratuitous_arp when LINK_STATE_LINKWATCH_PENDING bit
in dev->state field is on. This improves the chances for the arp packet to
be transmitted.
Signed-off-by: Moni Shoua <[EMAIL PROTECTED]>
Acked-by: Jay Vosburgh &l
ent by bonding when fail-over occurs
(this is already done by the bonding code).
Signed-off-by: Moni Shoua <[EMAIL PROTECTED]>
Signed-off-by: Or Gerlitz <[EMAIL PROTECTED]>
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_main.c | 87 +++
ddress. This is b/c ip_eth_mc_map() is called
where for multicast joins taking place after the enslavement another
ip_xxx_mc_map()
is called (eg ip_ib_mc_map() when the bond type is ARPHRD_INFINIBAND)
Signed-off-by: Moni Shoua <[EMAIL PROTECTED]>
Signed-off-by: Or Gerlitz <[EMAIL PROTECTED]
packet on a new slave that uses an old ipoib_neigh.
This patch detects and prevents this from happenning.
Signed-off-by: Moni Shoua <[EMAIL PROTECTED]>
Signed-off-by: Or Gerlitz <[EMAIL PROTECTED]>
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/infiniband/ulp/ipoib/ipoi
PROTECTED]>
Signed-off-by: Or Gerlitz <[EMAIL PROTECTED]>
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_main.c | 39 +++
1 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bonding/bond_main
Both changes are used in bonding slaves that wish to inform the bonding master
about coming detachment.
Signed-off-by: Moni Shoua <[EMAIL PROTECTED]>
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
include/linux/if.h |1 +
net/core/dev.c |1 +
2 files changed, 2 insertio
Following is patch set to provide IPoIB support for bonding in
active-backup mode. Patches 1 - 10 were originally posted by Moni Shoua
<[EMAIL PROTECTED]>. The changes look reasonable to me, but others (for
IB and net/core changes) probably need to ack.
Patch 11 modifies the IB "
ighbour dev one, when n->dev->flags has the
IFF_MASTER bit set.
Signed-off-by: Moni Shoua <[EMAIL PROTECTED]>
Signed-off-by: Or Gerlitz <[EMAIL PROTECTED]>
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/infiniband/ulp/ipoib/ipoib.h |4 +++-
drivers/
en the IPoIB net device is a
slave of a bonding master, let the master know that the IPoIB device is
about to unregister (but before calling unregister).
Signed-off-by: Moni Shoua <[EMAIL PROTECTED]>
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/infiniband/ulp/ipoib/i
but HEA is part of that, so it's probably got the answers you're
looking for.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
r type of function, and passing the carrier state of the
"external switch port" to the internal port.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
y
>+fi
>+IFS=$OLDIFS;
> done
>
> /sbin/ip link set dev ${DEVICE} up
That looks like it should do the right thing, although I didn't
actually try it. The other bonding sysfs thingies that use the "+" type
of syntax don't appear in B
rr
>> isn't much the rage these days).
>
>Are you OK with that block of text simply being yanked?
Mmm... I'm an easy sell for a "usually" or other suitable caveat
added in strategic places (avoiding absolute statements and all that).
The text does reflect the resu
h multiple 100Mb devices feeding either other sets of
100Mb devices or single gigabit devices. I'm willing to believe that
things have changed, and an N feeding into one configuration can
reorder, but I haven't seen it (or really looked for it; balance-rr
isn't much the rage these days).
ultiple instances of the arp_ip_target option; it doesn't work to put
multiple IP addresses as in the module option (i.e.,
"arp_ip_target=10.0.0.1,10.0.0.2").
This is necessary because ifup-eth isn't adding the "+" when it
translates the option for use with
Moni Shoua <[EMAIL PROTECTED]> wrote:
>Jay Vosburgh wrote:
>> Moni Shoua <[EMAIL PROTECTED]> wrote:
>>
>>> When bonding enslaves non Ethernet devices it takes pointers to functions
>>> in the module that owns the slaves. In this case it becomes uns
tic change I'd rather not introduce
if it's not necessary.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
bond_dev->hard_header_len);
Since non-IB bonding masters are run through ether_setup, which
sets hard_header_len to ETH_HLEN, the max() is probably unnecessary, and
I think this could just be bond_dev->hard_header_len.
-J
---
-Jay Vosburgh, IBM Linux Technol
ules is fairly invovled.
Andy and I have been through several iterations of a "final" patch, and
we keep finding regressions.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev&q
===
>--- net-2.6.orig/drivers/net/bonding/bonding.h 2007-07-25 15:20:10.0
>+0300
>+++ net-2.6/drivers/net/bonding/bonding.h 2007-07-26 18:42:43.652087660
>+0300
>@@ -203,6 +203,7 @@ struct bonding {
> struct vlan_group *vlgrp;
> struct packet_type arp_mon_pt;
> s8 do_set_mac_addr;
>+ int send_grat_arp;
This need not be a full int, and (this applies to
do_set_mac_addr, also) could probably be squeezed into gaps already
existing within the struct bonding somewhere.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
r its usage of IFF_SLAVE, but
I did not test it.
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 6287ffb..2bb70e0 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1390
gger a NULL pointer dereference in sysfs. I was not able to
induce the failure with the non-sysfs code path, but for consistency I
updated that code as well.
I also did some testing of the bonding /proc file being open
while the bond is being deleted, and didn't see any problems th
ually configured to be non-aggregatable) are enabled to operate as
individual IEEE 802.3 links."
Bug reported by Laurent Chavey <[EMAIL PROTECTED]>. This patch
is an updated version of his patch that changes the wording of
commentary and adds an update to the driver version.
Si
gger a NULL pointer dereference in sysfs. I was not able to
induce the failure with the non-sysfs code path, but for consistency I
updated that code as well.
I also did some testing of the bonding /proc file being open
while the bond is being deleted, and didn't see any problems th
Jeff, please apply wherever seems appropriate. It is a bug fix,
but for a pretty obscure bit of standards compliance.
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
-J
Laurent Chavey <[EMAIL PROTECTED]> wrote:
>Remove the requirement to have at least one con
Laurent Chavey <[EMAIL PROTECTED]> wrote:
>On 6/1/07, Jay Vosburgh <[EMAIL PROTECTED]> wrote:
[...]
>> Prior to the change in question, the carrier state of the master
>> device was always on, regardless of the state of the slaves (so even if
>> things di
cking the standard to see what it says, but I'm also
curious if this has some real-world impact, or is just something you
happened across?
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
ything (e.g., enslaving a VLAN device), but covers most
of the usual trouble cases.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index 7e03f41..c8394a0 100644
--- a/drivers/net/b
/0xa7 [8021q]
>> [] bond_update_speed_duplex+0x88/0xd7 [bonding]
>> [] bond_mii_monitor+0x0/0x403 [bonding]
>> [] bond_mii_monitor+0x373/0x403 [bonding]
>
>Jay Vosburgh and I have been working on something to address this and
>other issues related to possible sleeping activiti
ese to test with, I'm just
looking at the source and observing that dev_addr is only ever
referenced in the probe function, and that's only to read in the MAC
from the device.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this l
201 - 300 of 405 matches
Mail list logo
