Re: [REVISED PATCH] 3c59x: check return of pci_enable_device()

2007-08-31 Thread Jeff Garzik
Mark Hindley wrote: Revised patch for this. Mark commit 5cf33391eba81a49038fa8be8cbad8425b80bf7f Author: Mark Hindley <[EMAIL PROTECTED]> Date: Thu Aug 16 11:26:35 2007 +0100 Check return of pci_enable_device in vortex_up(). Also modify vortex_up to return error to callers. Han

Re: [PATCH 1/6] ibmveth: Enable TCP checksum offload

2007-08-31 Thread Jeff Garzik
Brian King wrote: This patchset enables TCP checksum offload support for IPV4 on ibmveth. This completely eliminates the generation and checking of the checksum for packets that are completely virtual and never touch a physical network. A simple TCP_STREAM netperf run on a virtual network with ma

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-31 Thread Jeff Garzik
Dan Williams wrote: On Thu, 2007-08-30 at 08:36 -0400, John W. Linville wrote: On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: 2007/8/28, Christoph Hellwig <[EMAIL PROTECTED]>: Also this whole patch seems rather pointless. It saves only very little and turns the driver into a

Re: [PATCH 2.6.24 3/3]S2io: Updating transceiver information in ethtool function

2007-08-31 Thread Jeff Garzik
Sreenivasa Honnur wrote: - Update transceiver information in ethtool function Signed-off-by: Sreenivasa Honnur <[EMAIL PROTECTED]> Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]> --- diff -urpN patch2/drivers/net/s2io.c patch3/drivers/net/s2io.c --- patch2/drivers/net/s2io.c 2007-08-18 07

Re: [PATCH 2.6.24 2/3]S2io: Support for add/delete/store/restore ethernet addresses

2007-08-31 Thread Jeff Garzik
Sreenivasa Honnur wrote: - Support to add/delete/store/restore 64 and 128 Ethernet addresses for Xframe I and Xframe II respectively. Signed-off-by: Sreenivasa Honnur <[EMAIL PROTECTED]> Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]> What is the purpose of this? We do not support more tha

Re: [PATCH 1/7] Generic bitbanged MDIO library

2007-08-31 Thread Jeff Garzik
Scott Wood wrote: Previously, bitbanged MDIO was only supported in individual hardware-specific drivers. This code factors out the higher level protocol implementation, reducing the hardware-specific portion to functions setting direction, data, and clock. Signed-off-by: Scott Wood <[EMAIL PROT

Re: [PATCH 2/7] fs_enet: Whitespace cleanup.

2007-08-31 Thread Jeff Garzik
Scott Wood wrote: Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c | 85 --- drivers/net/fs_enet/fs_enet.h |4 +- drivers/net/fs_enet/mac-fcc.c |1 - drivers/net/fs_enet/mii-fec.c |1 - 4 files chang

Re: [PATCH 3/6] ibmveth: Add ethtool TSO handlers

2007-08-31 Thread Jeff Garzik
Brian King wrote: Add handlers for get_tso and get_ufo to prevent errors being printed by ethtool. Signed-off-by: Brian King <[EMAIL PROTECTED]> --- linux-2.6-bjking1/drivers/net/ibmveth.c |2 ++ 1 file changed, 2 insertions(+) diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_get_tso drive

Re: [git patches] net driver fixes

2007-08-31 Thread Jeff Garzik
Satyam Sharma wrote: On Mon, 30 Jul 2007, Jeff Garzik wrote: true, we should just remove the dev==NULL check Patch below: [PATCH] nmclan_cs: Remove bogus (dev==NULL) check in mace_interrupt() The (dev == NULL) check in drivers/net/pcmcia/nmclan_cs.c:mace_interrupt() handler is always

Re: [REVISED PATCH] 3c59x: check return of pci_enable_device()

2007-08-31 Thread Jeff Garzik
Mark Hindley wrote: Revised patch for this. Mark commit 5cf33391eba81a49038fa8be8cbad8425b80bf7f Author: Mark Hindley <[EMAIL PROTECTED]> Date: Thu Aug 16 11:26:35 2007 +0100 Check return of pci_enable_device in vortex_up(). Also modify vortex_up to return error to callers. Han

Re: [PATCH 2.6.24 1/2]S2io: Change kmalloc+memset to k[zc]alloc

2007-08-31 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Changed kmalloc+memset to k[zc]alloc as per Mariusz's patch <[EMAIL PROTECTED]> Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]> ACK patches 1-2, but dropped due to previous dropped patches (presumed dependenc

Re: [PATCH 2.6.24 5/5]S2io: Optimize isr fast path

2007-08-31 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Optimized interrupt routine fast path. Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]> Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]> patch description is completely inadequate. how was it optimized? what

Re: [PATCH 2.6.24 4/5]S2io: Check for CARD_DOWN before handling traffic

2007-08-31 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Added check to return from the traffic handling function, if the card status is DOWN. Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]> Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]> --- diff -Nurp patch3/dr

Re: [PATCH 2.6.24 3/5]S2io: Cleanup - removed unused variable, intr_type

2007-08-31 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Removed the unused variable, intr_type, in device private structure. Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]> Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]> ACK (but dropped, since previous patches w

Re: [PATCH 2.6.24 2/5]S2io: Handle and monitor all of the device errors and alarms

2007-08-31 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Added support to poll entire set of device errors and alarams. - Replaced alarm_intr_handler() with s2io_handle_errors(). - Added statistic counters to monitor the alarms. Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> Signed-off-by: Santosh Rastapur <[EMAIL PROT

Re: [PATCH 2.6.24 1/5]S2io: Enable all the error and alarm indications

2007-08-31 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Added support to unmask entire set of device errors and alarms. Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]> Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]> --- diff -Nurp orig/drivers/net/s2io.c patch1/dri

Re: [PATCH] pcnet32: add suspend and resume capability

2007-08-31 Thread Jeff Garzik
Don Fry wrote: Add suspend and resume capability to the driver. Tested both to ram and to disk on x86_64 platform. Signed-off-by: Don Fry <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majord

Re: [patch]support for USB autosuspend in the asix driver

2007-08-31 Thread Jeff Garzik
Oliver Neukum wrote: Hi, this implements support for USB autosuspend in the asix USB ethernet driver. Regards Oliver Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> applied please put comments like "Hi," and "Regards Oliver" below the "---" terminator, otherwise the

Re: [PATCH 2.6.23 1/2] cxgb3 - Fix dev->priv usage

2007-08-31 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> cxgb3 used netdev_priv() and dev->priv for different purposes. In 2.6.23, netdev_priv() == dev->priv, cxgb3 needs a fix. This patch is a partial backport of Dave Miller's changes in the net-2.6.24 git branch. Without this fix, cxgb3 cr

Re: [PATCH 1/2] PS3: improve tx throughput for gelic driver

2007-08-31 Thread Jeff Garzik
Masakazu Mokuno wrote: Improve tx throughputs. netperf score gained approximately 20% This is a useless patch description. It does not adequately summarize the changes contained within the patch. Please resubmit patch with a useful patch description - To unsubscribe from this li

Re: [patch 1/7] s390: ungrouping a device must not be interruptible

2007-08-31 Thread Jeff Garzik
Applied patches 1-7, after changing the prefix back to "qeth: " "s390: " prefix should be applied to changes that affect S/390 architecture platform in general. This was a patchset specific to a single driver, thus the "qeth: " prefix is more informative when looking at a long list of one-lin

Re: [PATCH 1/3] netxen: Avoid firmware load in PCI probe

2007-08-31 Thread Jeff Garzik
applied patches 1-2 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] PS3: fix the bug that 'ifconfig down' would hang

2007-08-31 Thread Jeff Garzik
Masakazu Mokuno wrote: Fix the bug that 'ifconfig eth0 down' would hang up, reported by Stefan Assmann <[EMAIL PROTECTED]>. As we removed netif_poll_enable() from dev->open(), we should not use netif_poll_disable() in dev->stop(). Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]> CC: Geoff L

Re: [PATCH 3/3] netxen: ethtool fixes

2007-08-31 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: +static int netxen_nic_set_rx_csum(struct net_device *dev, u32 data) +{ + struct netxen_adapter *adapter = netdev_priv(dev); + adapter->rx_csum = 0; + return 0; +} Bug: 'data' ignored - To unsubscribe from this list: send the line "unsubscribe netdev

Re: [PATCH] spidernet: fix interrupt reason recognition

2007-08-31 Thread Jeff Garzik
Ishizaki Kou wrote: This patch solves a problem that the spidernet driver sometimes fails to handle IRQ. The problem happens because, - In Cell architecture, interrupts may arrive at an interrupt controller, even if they are masked by the setting on registers of devices. It happens when inte

Re: [PATCH 2.6.23 0/2] cxgb3 - Fix dev->priv usage

2007-08-29 Thread Jeff Garzik
Roland Dreier wrote: Looks OK to me but I would just roll up the second patch into the first patch and let Jeff merge it as one commit. There's no point in creating an intermediate tree that doesn't build -- it just breaks git bisect for no useful purpose. Agreed -- this needs to be in a singl

[git patches] net driver fixes

2007-08-25 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/dm9000.c| 25 --- drivers/net/ehea/ehea_main.c|8 ++-- drivers/net/ehea/ehea_qmr.c |

Re: [PATCH 1/3] e1000e: retire last_tx_tso workaround

2007-08-25 Thread Jeff Garzik
Auke Kok wrote: This TSO-related workaround is no longer needed since it's only applicable for 8254x silicon. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/e1000.h | 15 +++ drivers/net/e1000e/netdev.c | 20 ++-- 2 files changed, 5 insertio

Re: Please pull 'upstream-jgarzik' branch of wireless-2.6

2007-08-24 Thread Jeff Garzik
John W. Linville wrote: A few items intended for 2.6.24. Individual patches here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-jgarzik/ Thanks! John --- The following changes since commit 39d3520c92cf7a28c07229ca00cc35a1e8026c77: Linus Torvalds (1)

Re: [PATCH 2.6.23 RESEND] cxgb3 - Fix dev->priv usage

2007-08-24 Thread Jeff Garzik
Jeff Garzik wrote: Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> cxgb3 used netdev_priv() and dev->priv for different purposes. In 2.6.23, netdev_priv() == dev->priv, cxgb3 needs a fix. This patch is a partial backport of Dave Miller's changes in the net-2.6.24 git

Re: [PATCH 1/2] myri10ge: use pcie_get/set_readrq

2007-08-24 Thread Jeff Garzik
Brice Goglin wrote: Based on a patch from Peter Oruba, convert myri10ge to use pcie_get_readrq() and pcie_set_readrq() instead of our own PCI calls and arithmetics. These driver changes incorporate the proposed PCI-X / PCI-Express read byte count interface. Reading and setting those values does

Re: [PATCH 1/4] ehea: fix interface to DLPAR tools

2007-08-24 Thread Jeff Garzik
Jan-Bernd Themann wrote: Userspace DLPAR tool expects decimal numbers to be written to and read from sysfs entries. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> applied 1-3 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTE

Re: [NET] sgiseeq: Fix return type of sgiseeq_remove

2007-08-24 Thread Jeff Garzik
Ralf Baechle wrote: The driver remove method needs to return an int not void. This was just never noticed because usually this driver is not being built as a module. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" i

Re: [PATCH] phy layer: fix genphy_setup_forced (don't reset)

2007-08-24 Thread Jeff Garzik
Domen Puncer wrote: Writing BMCR_RESET bit will reset MII_BMCR to default values. This is clearly not what we want. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- drivers/net/phy/phy_device.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: work-powerpc.git/drivers/net/ph

Re: [PATCH] DM9000: fix interface hang under load

2007-08-24 Thread Jeff Garzik
Florian Westphal wrote: When transferring data at full speed, the DM9000 network interface sometimes stops sending/receiving data. Worse, ksoftirqd consumes 100% cpu and the net tx watchdog never triggers. Fix by spin_lock_irqsave() in dm9000_start_xmit() to prevent the interrupt handler from int

Re: [METH] Don't use GFP_DMA for zone allocation.

2007-08-24 Thread Jeff Garzik
Ralf Baechle wrote: IP32 doesn't even have a ZONE_DMA so no point in using GFP_DMA in any IP32-specific device driver. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] Mor

Re: [PATCH] ucc_geth: kill unused include

2007-08-24 Thread Jeff Garzik
Kumar Gala wrote: The ucc_geth_mii code is based on the gianfar_mii code that use to include ocp.h. ucc never need this and it causes issues when we want to kill arch/ppc includes from arch/powerpc. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- Jeff, if you issue with this for 2.6.23, I'd

Re: [PATCH 4/4] ehea: show physical port state

2007-08-24 Thread Jeff Garzik
Jan-Bernd Themann wrote: Introduces a module parameter to decide whether the physical port link state is propagated to the network stack or not. It makes sense not to take the physical port state into account on machines with more logical partitions that communicate with each other. This is alway

Re: [PATCH 1/2] [DM9000] Added support for big-endian hosts

2007-08-24 Thread Jeff Garzik
Laurent Pinchart wrote: This patch splits the receive status in 8bit wide fields and convert the packet length from little endian to CPU byte order. Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> --- drivers/net/dm9000.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-

Re: [PATCH] fix realtek phy id in forcedeth

2007-08-24 Thread Jeff Garzik
Willy Tarreau wrote: Hi Greg, On Thu, Aug 23, 2007 at 09:55:13AM -0700, Greg KH wrote: It might help if someone sends a real patch that can be applied :) This is getting really silly now :-) We're all wasting more time wondering who will send the patch than posting it. I've lost, I got fed up

Re: [PATCH 2.6.23 RESEND] cxgb3 - Fix dev->priv usage

2007-08-24 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> cxgb3 used netdev_priv() and dev->priv for different purposes. In 2.6.23, netdev_priv() == dev->priv, cxgb3 needs a fix. This patch is a partial backport of Dave Miller's changes in the net-2.6.24 git branch. Without this fix, cxgb3 cr

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-15 Thread Jeff Garzik
Steve Wise wrote: David Miller wrote: From: Sean Hefty <[EMAIL PROTECTED]> Date: Thu, 09 Aug 2007 14:40:16 -0700 Steve Wise wrote: Any more comments? Does anyone have ideas on how to reserve the port space without using a struct socket? How about we just remove the RDMA stack altogether?

Re: [2.6 patch] remove Documentation/networking/net-modules.txt

2007-08-14 Thread Jeff Garzik
Adrian Bunk wrote: According to git, the only one who touched this file during the last 5 years was me when removing drivers... modinfo offers less ancient information. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 23 Jul 2007 Documentation/networking/00-

[git patches] net driver fixes

2007-08-13 Thread Jeff Garzik
Minor stuff except for the xen-netfront fix. e1000 change is an adds-pci-ids-only change. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: MAINTAINERS |6 ++

Re: [PATCH] e1000: Add device IDs of new 82571 board variants

2007-08-13 Thread Jeff Garzik
Auke Kok wrote: This patch adds support for 2 new board variants: - A Quad port fiber 82571 board - A blade version of the 82571 quad copper board Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_ethtool.c |2 ++ drivers/net/e1000/e1000_hw.c |5 + driver

Re: [PATCH] xen-netfront: remove dead code

2007-08-13 Thread Jeff Garzik
Jeremy Fitzhardinge wrote: This patch removes some residual dead code left over from removing the "flip" receive mode. This patch doesn't change the generated output at all, since gcc already realized it was dead. This resolves the "regression" reported by Adrian. Signed-off-by: Jeremy Fitzhar

Re: [PATCH] xen-netfront: Avoid deref'ing skbafter it is potentially freed.

2007-08-13 Thread Jeff Garzik
Jeremy Fitzhardinge wrote: xennet_tx_bug_gc can free the skb before we use it, so make sure we don't. Jeff, this is -rc material. Signed-off-by: Keir Fraser <[EMAIL PROTECTED]> Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTE

Re: [PATCH] drivers/net/3c505: Convert to generic boolean

2007-08-13 Thread Jeff Garzik
Richard Knutsson wrote: Convert to generic boolean Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) Diffed against Linus' git-tree. Sent 2007-05-01, no replys applied - To unsubscribe from this list: send the line "un

Re: drivers/net/tokenring/3c359.c

2007-08-13 Thread Jeff Garzik
Surya Prabhakar N wrote: Hi, Replacing kmalloc with kzalloc and cleaning up memset in drivers/net/tokenring/3c359.c Signed-off-by: Surya Prabhakar <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTE

Re: [PATCH] drivers/net/tokenring: Convert to generic boolean

2007-08-13 Thread Jeff Garzik
Richard Knutsson wrote: Convert to generic boolean Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) Diffed against Linus' git-tree. Sent 2007-05-01, no replys applied - To unsubscribe from this list: send the line "un

Re: [PATCH 12/13] cxgb3 - log and clear PEX errors

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Clear pciE PEX errors late at module load time. Log details when PEX errors occur. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/t3_hw.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) ACK 10-12

Re: [PATCH 13/13] cxgb3 - test MSI capabilities

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Check that the HW in really in MSI/MSI-X mode when it was succesfully enabled. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c | 42 drivers/net/cxgb3/regs.h

Re: [PATCH 9/13] cxgb3 - Update internal memory management

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Set PM1 internal memory to round robin mode Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> why? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 8/13] cxgb3 - log adapter derial number

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Log HW serial number when cxgb3 module is loaded. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |2 ++ drivers/net/cxgb3/cxgb3_main.c |6 -- drivers/net/cxgb3/t3_hw.c |3 ++- 3 fi

Re: [PATCH 4/13] cxgb3 - use immediate data for offload Tx

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Send small TX_DATA work requests as immediate data even when there are fragments. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/sge.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) n

Re: [PATCH 5/13] cxgb3 - Expose HW memory page info

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Let the RDMA driver get HW page info to work around HW issues. Assign explicit enum values. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> "HW issues" -- you need to go into far more detail, when adding a new interface. what hw issues

Re: [PATCH 3/13] cxgb3 - SGE doorbell overflow warning

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Log doorbell Fifo overflow Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/regs.h |8 drivers/net/cxgb3/sge.c |4 2 files changed, 12 insertions(+), 0 deletions(-) ACK, but not applied since

Re: [PATCH 2/13] cxgb3 - Update rx coalescing length

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Set max Rx coalescing length to 12288 Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/cxgb3/common.h b/drivers/net/cxgb3

Re: [PATCH 1/13] cxgb3 - MAC workaround update

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Update the MAC workaround to deal with switches that do not honor pause frames. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |1 + drivers/net/cxgb3/xgmac.c | 22 +++--- 2 files ch

Re: [patch 17/18] 3c59x: fix duplex configuration

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Steffen Klassert <[EMAIL PROTECTED]> A special sequence of ifconfig up/down and plug/unplug the cable can break the duplex configuration of the driver. Setting vp->mii.full_duplex = vp->full_duplex in vortex_up should fix this. Addresses Bug 8575 3c59x duplex con

Re: [patch 18/18] 3c59x maintainer

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Steffen Klassert <[EMAIL PROTECTED]> Add 3c59x maintainer. Signed-off-by: Steffen Klassert <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- MAINTAINERS |6 ++ 1 files changed, 6 insertions(+) diff -puN MAINTAINERS~add-3c59x-maint

Re: [patch 13/18] natsemi: fix netdev error acounting

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Andrew Morton <[EMAIL PROTECTED]> When a detailed netdev error is counted, we also must account for it in the aggregated error count. Addresses http://bugzilla.kernel.org/show_bug.cgi?id=8106 Cc: Tim Hockin <[EMAIL PROTECTED]> Cc: Jeff Garzik <[

Re: [patch 15/18] drivers/net: remove superfluous memset

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Mariusz Kozlowski <[EMAIL PROTECTED]> This patch covers something like this: dev = alloc_*dev(... ... priv = netdev_priv(dev); memset(priv, 0, sizeof(*priv)); The memset() here is superfluous. alloc_netdev() uses kzalloc() to allocate needed memory so the

Re: [patch 12/18] e1000: #if 0 two functions

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Adrian Bunk <[EMAIL PROTECTED]> e1000_{read,write}_pci_cfg() are no longer used. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Cc: Auke Kok <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_hw.h |2 -- driver

Re: [patch 09/18] Clean up duplicate includes in drivers/net/

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Jesper Juhl <[EMAIL PROTECTED]> This patch cleans up duplicate includes in drivers/net/ Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> Acked-by: "John W. Linville" <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/atl1

Re: [patch 10/18] ax88796 printk fixes

2007-08-13 Thread Jeff Garzik
ize_t isn't size_t. Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/ax88796.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) applied - To unsubscribe from this list: send the line "unsubscribe netdev&qu

Re: [patch 08/18] 3c59x: check return of pci_enable_device()

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Mark Hindley <[EMAIL PROTECTED]> Check return of pci_enable_device in vortex_up(). Signed-off-by: Mark Hindley <[EMAIL PROTECTED]> Acked-by: Steffen Klassert <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/3c59x.c |8

Re: [patch 06/18] PCI-X/PCI-Express read control interfaces: use them in myrinet

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: "Peter Oruba" <[EMAIL PROTECTED]> These driver changes incorporate the proposed PCI-X / PCI-Express read byte count interface. Reading and setting those valuse doesn't take place "manually", instead wrapping functions are called to allow quirks for some PCI bridge

Re: [PATCH 1/1] Use the pause counter to avoid a needless device reset

2007-08-13 Thread Jeff Garzik
Brice Goglin wrote: Use the pause counter to avoid a needless device reset, and print a message telling the admin that our link partner is flow controlling us down to 0 pkts/sec. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c | 25 ++---

Re: [patch 04/18] via-rhine: disable rx_copybreak on archs that don't allow unaligned DMA access

2007-08-13 Thread Jeff Garzik
ess <[EMAIL PROTECTED]> Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Ivan Kokshaysky <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/via-rhine.c |6 ++ 1 files changed, 6 insertions(+)

Re: [patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation

2007-08-13 Thread Jeff Garzik
applied the ethtool part of this - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/6] e1000e: error handling for pci_map_single calls.

2007-08-13 Thread Jeff Garzik
Auke Kok wrote: index d14cc4b..0e80406 100644 --- a/drivers/net/e1000e/ethtool.c +++ b/drivers/net/e1000e/ethtool.c @@ -1042,6 +1044,10 @@ static int e1000_setup_desc_rings(struct e1000_adapter *adapter) tx_ring->buffer_info[i].dma = pci_map_single(pdev, s

Re: [PATCH 2/6] e1000e: remove namespace collisions with e1000

2007-08-13 Thread Jeff Garzik
Auke Kok wrote: To prevent future collisions we rename all extern's from e1000_ to e1000e_*. The list of changed symbols was taken from e1000.h Compile tested with CONFIG_E1000=y and CONFIG_E1000E=y. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/82571.c | 129 ++

Re: [PATCH 1/6] e1000e: Fix header includes [v2]

2007-08-13 Thread Jeff Garzik
Auke Kok wrote: Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/82571.c |4 drivers/net/e1000e/e1000.h |7 --- drivers/net/e1000e/es2lan.c |5 + drivers/net/e1000e/ethtool.c |3 ++- drivers/net/e1000e/hw.h |2 ++ drivers/net/e1000e/i

Re: [PATCH 2.6.24]S2io: Enhance device error/alarm handling

2007-08-13 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Added support to poll for entire set of device errors and alarms. - Optimized interrupt routine fast path. - Removed the unused variable, intr_type, in device private structure. Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]> Signed-off-by: Ramkrishna Vepa <[EMAIL PR

Re: [PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment

2007-08-13 Thread Jeff Garzik
Mariusz Kozlowski wrote: Hello, Unpatched version does sth like this: dev = alloc_etherdev(... private = netdev_priv(dev); ... dev->priv = private; which doesn't make much sense (does it?) because this is done in alloc_netdev() already. struct net_device *alloc_netdev(... { ...

Re: [PATCH 2.6.23 1/3]S2IO: Making MSIX as default intr_type

2007-08-13 Thread Jeff Garzik
applied 1-3 to #upstream (2.6.23), but we'll want to look into why NAPI and MSI-X aren't playing well for you. especially look at NAPI changes in net-2.6.24. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More m

Re: [patch]support for USB autosuspend in the asix driver

2007-08-13 Thread Jeff Garzik
Oliver Neukum wrote: Hi, this implements support for USB autosuspend in the asix USB ethernet driver. Regards Oliver Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> David, does this look OK to you? I never saw much comment from anybody, and cannot really comment on

Re: dm9000: add set_mac_address()

2007-08-12 Thread Jeff Garzik
set_mac_address should not write to the SROM, as Michael noted. The proper operations are: probe time: read MAC address from SROM dev open (interface up): write dev->dev_addr[] to RX filter (or identity) registers EEPROM update support is available separately, via an et

Re: Driver writer hints (was [PATCH 3/4] Add ETHTOOL_[GS]PFLAGS sub-ioctls)

2007-08-10 Thread Jeff Garzik
Rick Jones wrote: If we are getting (retrieving) flags: 3) Userland issues ETHTOOL_GPFLAGS, to obtain a 32-bit bitmap 4) Userland prints out a tag returned from ETHTOOL_GSTRINGS for each bit set to one in the bitmap. If a bit is set, but there is no string to describe it,

Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls

2007-08-10 Thread Jeff Garzik
Jeff Garzik wrote: diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 4a616d7..559a4dc 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -341,6 +341,7 @@ struct net_device #define NETIF_F_GSO2048/* Enable software GSO. */ #define

Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls

2007-08-10 Thread Jeff Garzik
All this is currently checked into the 'eflags' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git But when everybody is happy with it, IMO we should get it into net-2.6.24.git, as it enables LRO. Jeff - To unsubscribe from this list: send the line "unsubs

Driver writer hints (was [PATCH 3/4] Add ETHTOOL_[GS]PFLAGS sub-ioctls)

2007-08-10 Thread Jeff Garzik
Jeff Garzik wrote: commit 4901236cec047029b970261b95e47d6be60f523e Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Aug 10 15:52:06 2007 -0400 [ETHTOOL] Introduce ->{get,set}_priv_flags, ETHTOOL_[GS]PFLAGS Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> include/

[PATCH 4/4] ethtool: internal simplification

2007-08-10 Thread Jeff Garzik
commit 75856b3e7758a84e721998bce8f63855caca Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Aug 10 16:17:09 2007 -0400 [ETHTOOL] Internal cleanup of ethtool_value-related handlers Several get/set functions can be handled by a passing the ethtool_op function p

[PATCH 3/4] Add ETHTOOL_[GS]PFLAGS sub-ioctls

2007-08-10 Thread Jeff Garzik
Driver-private flags. Driver writer's guide will follow in a reply to this patch. commit 4901236cec047029b970261b95e47d6be60f523e Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Aug 10 15:52:06 2007 -0400 [ETHTOOL] Introduce ->{get,set}_priv_flags, ETHTOOL_[GS]PFLAGS

[PATCH 2/4] ethtool: introduce get_sset_count

2007-08-10 Thread Jeff Garzik
Required prep for the priv-flags changeset (next patch), which also uses ethtool string sets. commit 86fe0ff220a795c82aa9dea5dc4b7359519a1366 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Aug 10 15:49:21 2007 -0400 [ETHTOOL] Introduce get_sset_count. Obsolete get_stats

[PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls

2007-08-10 Thread Jeff Garzik
Also, adds support for the first flag, LRO. Earlier version of this patch posted about 12 hours ago. commit 84bf82f38dacde0fa86986e23c061728e819810e Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Aug 10 05:27:23 2007 -0400 [ETHTOOL] Add ETHTOOL_[GS]FLAGS sub-ioctls

Re: [PATCH 2.6.24]S2io: Default to IntA interrupt type when there are less than 4 CPUs in the system.

2007-08-10 Thread Jeff Garzik
Rick Jones wrote: Sivakumar Subramani wrote: - Default to IntA interrupt type when there are less than 4 CPUs in the system. It might be good to include _why_ in the comment(s). I certainly am curious to know the reason, and it would be good to have in there for "posterity" should the under

[PATCH][RFC] ethtool flags

2007-08-10 Thread Jeff Garzik
userland interface (ethtool(8)) will refer to flags by name, not by bit number. As we see with msg_enable, bitmap math on the command line is a pain. commit 3216337d7a6938df5b11935da5ee0045b0535d96 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Aug 10 05:27:23 2007

Re: [PATCH] [NET] ethtool: Add LRO support

2007-08-10 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 10 Aug 2007 04:42:44 -0400 I'll code this up, along with the associated generic helpers (net/core/ethtool.c), if there are no objections. No objections except I would give the driver private it's own set o

Re: [PATCH] [NET] ethtool: Add LRO support

2007-08-10 Thread Jeff Garzik
Auke Kok wrote: Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- include/linux/ethtool.h |8 +++ include/linux/netdevice.h |1 + net/core/ethtool.c| 53 + 3 files changed, 62 insertions(+), 0 deletions(-) diff --git a/include/l

Re: 2.6.23-rc2-mm1

2007-08-09 Thread Jeff Garzik
Andrew Morton wrote: umm, I was hoping to find out which of those two patches was the cuplrit. Almost surely it was 9ee6b32a47b9abc565466a9c3b127a5246b452e5? Highly likely it is my patch in #ALL. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: [PATCH 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-08-08 Thread Jeff Garzik
David Miller wrote: From: Jan-Bernd Themann <[EMAIL PROTECTED]> Date: Fri, 3 Aug 2007 14:41:14 +0200 I think this patch could be the final version for now. It has been tested on two platforms (power and x86_64) and works very well. I checked in the LRO patch and the two sample driver ports to

Re: [PATCH RFC]: napi_struct V5

2007-08-08 Thread Jeff Garzik
David Miller wrote: From: jamal <[EMAIL PROTECTED]> Date: Wed, 08 Aug 2007 11:32:34 -0400 Think of a box where you have other network interfaces, the way you are implementing currently implies you are going to be very unfair to the other interfaces on the box. This was the point I was tryin

Re: [PATCH] e1000e: Remove unused or empty labels

2007-08-08 Thread Jeff Garzik
Auke Kok wrote: Remove labels with only return, remove E1000_SUCCESS code and replace with 0. Remove most goto's. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/82571.c | 138 +- drivers/net/e1000e/defines.h |1 drivers/net/e1000e/es2lan.c | 162 ++

Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Jeff Garzik
Michael Buesch wrote: On Wednesday 08 August 2007 18:59:08 Jeff Garzik wrote: Michael Buesch wrote: writel doesn't guarantee flushing either. readl does. Not quite -- there are multiple kinds of flushing. You're thinking about flushing across PCI bridges, which is correct, bu

Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Jeff Garzik
Michael Buesch wrote: writel doesn't guarantee flushing either. readl does. Not quite -- there are multiple kinds of flushing. You're thinking about flushing across PCI bridges, which is correct, but you also have CPU write posting and CPU write ordering and such. Without taking all that

Re: [PATCH 68] drivers/net/s2io.c: kmalloc + memset conversion to k[cz]alloc

2007-08-08 Thread Jeff Garzik
Ramkrishna Vepa wrote: We have a few patches queued and can send this patch in along with ours. That would be great, thanks. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ker

Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Jeff Garzik
Michael Buesch wrote: On Wednesday 08 August 2007 18:18:31 Roland Dreier wrote: > But there are indeed a few cases that look wrong. yes... > arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val), target); eg this almost certainly wants to be writel(swab32(val), target);

Re: [PATCH RFC]: napi_struct V6

2007-08-08 Thread Jeff Garzik
Someone please make sure Documentation/networking/netdevices.txt remains correct with regards to APIs and locking. It -is- up to date, unlike NAPI howto. It should not change very much due to this napi_struct work though, if at all. Jeff - To unsubscribe from this list: send the l

<    3   4   5   6   7   8   9   10   11   12   >