Re: [PATCH] xen-netfront: remove dead code

2007-08-07 Thread Jeff Garzik
Jeremy Fitzhardinge wrote: Jeff Garzik wrote: Please send drivers/net/* through me and netdev... Sure. Did you pick this patch up? Yes. It's in my pending-for-2.6.24 folder, since it's not a bug fix. Jeff - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH 2/14] nes: device structures and defines

2007-08-07 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: +#ifndef PCI_VENDOR_ID_NETEFFECT/* not in pci.ids yet */ +#define PCI_VENDOR_ID_NETEFFECT 0x1678 this should be part of your patch +#define PCI_DEVICE_ID_NETEFFECT_NE020 0x0100 no need for a #define at all, just use the hex number if the ONLY place its

Re: [PATCH 3/14] nes: connection manager routines

2007-08-07 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: +atomic_t cm_connects; +atomic_t cm_accepts; +atomic_t cm_disconnects; +atomic_t cm_closes; +atomic_t cm_connecteds; +atomic_t cm_connect_reqs; +atomic_t cm_rejects; do you really want to take the hit of a LOCK prefix each time you increment a stat??? +static

Re: [PATCH 4/14] nes: connection manager structures and defines

2007-08-07 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: +struct ietf_mpa_frame { + u8 key[IETF_MPA_KEY_SIZE]; + u8 flags; + u8 rev; + u16 priv_data_len; + u8 priv_data[0]; use unsigned long, not u8, for proper alignment. plus, as noted in other emails, you should not ever be using 'u8' for

Re: [PATCH 5/14] nes: context structures and defines

2007-08-07 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: QP context structures and defines Signed-off-by: Glenn Grundstrom [EMAIL PROTECTED] --- diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_context.h --- NULL1969-12-31 18:00:00.0 -0600 +++ ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_context.h

Re: [PATCH 6/14] nes: hardware init

2007-08-07 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: +struct nes_adapter *nes_init_adapter(struct nes_device *nesdev, u8 hw_rev) { + struct nes_adapter *nesadapter = NULL; + unsigned long num_pds; + u32 u32temp; + u32 port_count; + u16 max_rq_wrs; + u16 max_sq_wrs; + u32 max_mr; +

Re: [PATCH] drivers/net/ibmveth.c: memset fix

2007-08-06 Thread Jeff Garzik
Brian King wrote: Mariusz Kozlowski wrote: Hello, Looks like memset() is zeroing wrong nr of bytes. Good catch, however, I think we can just remove this memset altogether since the memory gets allocated via kzalloc. Correct, that memset() is superfluous. Jeff - To

Re: [RFC 0/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-08-04 Thread Jeff Garzik
Michael Chan wrote: [BNX2]: Add iSCSI support to BNX2 devices. Modify bnx2 and add a cnic driver to support some offload functions needed by iSCSI. Add a new open-iscsi driver to support iSCSI offload on bnx2 devices. Signed-off-by: Anil Veerabhadrappa [EMAIL PROTECTED] Signed-off-by: Michael

Re: [TULIP] Need new maintainer

2007-08-02 Thread Jeff Garzik
Valerie Henson wrote: On Mon, Jul 30, 2007 at 03:31:58PM -0400, Kyle McMartin wrote: On Mon, Jul 30, 2007 at 01:04:13PM -0600, Valerie Henson wrote: The Tulip network driver needs a new maintainer! I no longer have time to maintain the Tulip network driver and I'm stepping down. Jeff Garzik

Re: net driver error accounting

2007-08-02 Thread Jeff Garzik
Andrew Morton wrote: Looking at http://bugzilla.kernel.org/show_bug.cgi?id=8106 Guys, could we please have a ruling here? When a net driver encounters a tx_fifo_error, should this also contribute to the tx_error count, or should it not? For each TX error, (a) tx_error is incremented and (b)

Re: [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet.

2007-08-01 Thread Jeff Garzik
Roland Dreier wrote: +{ PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_NX2_5710, +PCI_ANY_ID, PCI_ANY_ID, 0, 0, BCM5710 }, FWIW, this could be neater as { PCI_VDEVICE(BROADCOM, PCI_DEVICE_ID_NX2_5710), BCM5710 } Yes. And additionally, I prefer (but not require) that

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread Jeff Garzik
Seems pretty good to me, save for one minor detail: patches #1/#2 should be combined together for greater git-bisect happiness. Ditto for patches #3/#4. Largely harmless in this case, but keeps the git history pollution to a minimum. Caveat reviewer: I'm not an expert of net/ipv4/* code,

Re: [PATCH 2/4][RFC] lro: Kconfig and Makefile

2007-07-30 Thread Jeff Garzik
Stephen Hemminger wrote: Why make this a user selectable option at all? Unless you want to deal with out of tree drivers (not my problem), it should be hidden to avoid having to explain an support it. In this case it's an optional library kernel module. That seems to be a common setup for

Re: [PATCH] [2.6.22] Fix a potential NULL pointer dereference in write_bulk_callback() in drivers/net/usb/pegasus.c

2007-07-30 Thread Jeff Garzik
Micah Gruber wrote: This patch fixes a potential null dereference bug where we dereference pegasus before a null check. This patch simply moves the dereferencing after the null check. Signed-off-by: Micah Gruber [EMAIL PROTECTED] --- --- a/drivers/net/usb/pegasus.c +++

Re: [PATCH] gfar: Fix modpost warning

2007-07-30 Thread Jeff Garzik
Kumar Gala wrote: Fix the following modpost warning: WARNING: vmlinux.o(.init.text+0x1aa6c): Section mismatch: reference to .exit.text:gfar_mdio_exit (between 'gfar_init' and 'gfar_mdio_init') Signed-off-by: Kumar Gala [EMAIL PROTECTED] --- drivers/net/gianfar_mii.c |2 +-

Re: [PATCH][netdrvr] lib8390: comment on locking by Alan Cox Re: 2.6.20-2.6.21 - networking dies after random time

2007-07-30 Thread Jeff Garzik
by Alan Cox Additional explanation of problems with locking by Alan Cox. Signed-off-by: Jarek Poplawski [EMAIL PROTECTED] Cc: Alan Cox [EMAIL PROTECTED] Cc: Paul Gortmaker [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH] tulip: Remove tulip maintainer

2007-07-30 Thread Jeff Garzik
Valerie Henson wrote: Remove Val Henson as tulip maintainer and let her roam free, FREE! Signed-off-by: Val Henson [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] forcedeth: mac address correct

2007-07-30 Thread Jeff Garzik
Ayaz Abdulla wrote: Resending: In older chipsets, the mac address was stored in reversed order. However, in newer chipsets, the mac address is in correct order. This patch takes those newer chipsets into account and does not rely on a special bit setup by BIOS'. Signed-Off-By: Ayaz Abdulla

Re: [RESEND 1/2] netxen: re-init station address after h/w init

2007-07-30 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: This is a workaround for firmware bug with 2nd port of multiport adapter, where MAC address is reset. Driver just needs to overwrite it with the value read from PROM. Signed-off-by: Dhananjay Phadke [EMAIL PROTECTED] applied 1-2 - To unsubscribe from this list: send

Re: [PATCH] netxen: drop redudant spinlock

2007-07-30 Thread Jeff Garzik
Dhananjay Phadke wrote: Some leftover code that makes use of adapter-lock in tx_timeout function, which resets the interface under this lock. In close() when the workqueue is flushed, prints the warning about sleeping with interrupts disabled (when spinlock debug is enabled). The lock was

Re: [PATCH 2.6.22 1/3]S2io: Mask spurious interrupts

2007-07-30 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Mask single and double bit ETQ ecc errors to inhibit spurious interrupts. (Resending; Removed HTML sections in the patch) Signed-off-by: Santosh Rastapur [EMAIL PROTECTED] applied 1-3 - To unsubscribe from this list: send the line unsubscribe netdev in the body of

Re: [PATCH] [2.6.22] Fix a potential NULL pointer dereference in mace_interrupt() in drivers/net/pcmcia/nmclan_cs.c

2007-07-30 Thread Jeff Garzik
Micah Gruber wrote: This patch fixes a potential null dereference bug where we dereference DEV before a null check. This patch simply moves the dereferencing after the null check. Signed-off-by: Micah Gruber [EMAIL PROTECTED] applied (git-am worked!) - To unsubscribe from this list: send

Re: [PATCH 2.6.22 1/4]S2IO: Removing 3 buffer mode support from the driver

2007-07-30 Thread Jeff Garzik
Veena Parat wrote: - Removed 3 buffer mode support from driver - unused feature - Incorporated Jeff Garzik's comments on elimination of inline typecasting - Code cleanup : Removed a few extra spaces Signed-off-by: Veena Parat [EMAIL PROTECTED] applied 1-4 - To unsubscribe from this list:

Re: [PATCH] [drivers/net/cxgb3] removed several unneeded zero initilization

2007-07-30 Thread Jeff Garzik
Denis Cheng wrote: Cc: [EMAIL PROTECTED] Signed-off-by: Denis Cheng [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_main.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [NET] IOC3: Switch hw checksumming to ethtool configurable.

2007-07-30 Thread Jeff Garzik
Ralf Baechle wrote: Signed-off-by: Ralf Baechle [EMAIL PROTECTED] applied to #upstream (2.6.24) I've previously sent out this patch a long time ago. At that time I was told NETIF_F_IP_CSUM wouldn't make any sense without NETIF_F_SG. IOC3's S/G abilities are very limited; it can do upto

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik [EMAIL PROTECTED] Date: Mon, 30 Jul 2007 12:17:58 -0400 David, thoughts on merging? I'm not We could stick this into your tree or mine. Whether yours or mine, I would like to keep the driver and net-core patches together in the same git tree

Re: [PATCH RFC]: napi_struct V4

2007-07-28 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik [EMAIL PROTECTED] Date: Wed, 25 Jul 2007 22:00:31 -0400 David Miller wrote: From: Jeff Garzik [EMAIL PROTECTED] Date: Wed, 25 Jul 2007 21:55:08 -0400 I don't see any logic to your request, only added overhead for no reason. There may be some flawed

Re: [PATCH 1/1]ixgbe: Driver for Intel 82598 based 10GbE PCI Express family of adapters

2007-07-27 Thread Jeff Garzik
Stephen Hemminger wrote: Using module parameter for per device settings is bad idea. Please extend existing interfaces like ethtool, etc rather than committing to a bad inflexible API. I agreed with Stephen's comments here. In general, net driver policy is to use ethtool (per-interface

Re: [RFC 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-07-27 Thread Jeff Garzik
Just to chime in... In general, I like where this LRO effort is going, and I really appreciate you guys working on it. Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: sk98lin for 2.6.23-rc1

2007-07-27 Thread Jeff Garzik
Stephen Hemminger wrote: If anyone still has hang issues with sky2, please send me the hardware information (lspci, dmesg output), and capture the debugfs state after hang. At present the known open skge, sky2 issues are: Did you add Chris Stromsoe's skge-hangs problem to the list?

Re: [PATCH 1/1]ixgbe: Driver for Intel 82598 based 10GbE PCI Express family of adapters

2007-07-27 Thread Jeff Garzik
Veeraiyan, Ayyappan wrote: So, with driver/device supporting multiple Tx and Rx queues, I think, it would be very useful to have ethtool interface to manage the number of Tx and Rx queues of the interface. Absolutely! ethtool patches welcome :)

Re: [PATCH] ethtool: add register dump support for SMSC LAN911x/LAN921x

2007-07-26 Thread Jeff Garzik
Steve Glendinning wrote: This patch adds support for SMSC's LAN911x and LAN921x families of embedded ethernet controllers to ethtool's dump registers (-d) command. This patch is for use with the smsc911x driver. Signed-off-by: Steve Glendinning [EMAIL PROTECTED] --- Makefile.am|3 +-

ethtool version 6 released

2007-07-26 Thread Jeff Garzik
of ethtool.h. commit ee6a4ec9b23ae887d280f0f4eedb9a931f71d311 Author: Jeff Garzik [EMAIL PROTECTED] Date: Thu Jul 26 13:41:45 2007 -0400 Release version 6. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] commit f45bb4faddffed6de1932105b17e28d48f9c3127 Author: Jeff Garzik [EMAIL

Re: [-mm patch] one e1000 driver should be enough for everyone

2007-07-25 Thread Jeff Garzik
Adrian Bunk wrote: BTW: Unless I'm misunderstanding anything, the new driver should support a superset of what the old driver supported. Therefore, it would be good if the final merge into Linus' tree will do an rm -r drivers/net/e1000 mv drivers/net/e1000new drivers/net/e1000 Based on

Re: [PATCH 1/1] netxen: Load firmware during probe, dma watchdog fix.

2007-07-25 Thread Jeff Garzik
Dhananjay Phadke wrote: Jeff, You committed old patch, which I had asked to ignore for two newer patches. [PATCH 1/1] netxen: Load firmware during probe, dma watchdog fix. is wrong patch that went in, instead please commit: [PATCH 1/2] netxen: IMEZ multiport card 2nd port issue, dma watchdog

Re: [-mm patch] one e1000 driver should be enough for everyone

2007-07-25 Thread Jeff Garzik
Adrian Bunk wrote: I found the discussion, and Christoph's e1000e sounds like the best name (new doesn't say whether it's a new driver for old hardware or a driver for new hardware). Yeah, I think e1000new is a lame name. e1000e is good, or even e1001e if we wanted even more symmetry :) No

Re: [RESEND 1/2] netxen: re-init station address after h/w init

2007-07-25 Thread Jeff Garzik
Since we had a problem before, just wanted to let you know I received these two patches. Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [-mm patch] one e1000 driver should be enough for everyone

2007-07-25 Thread Jeff Garzik
Kok, Auke wrote: I'm working on e1000e right now... Cool :) I'll submit it with only ich9 id's at first, but it will be able to drive (sysfs bind) to some other devices too. This allows me to keep an eye out on the future structure that I want to give it without removing too much code

Re: [PATCH 1/2] [POWERPC] Add support of platforms without PHY to gianfar driver

2007-07-25 Thread Jeff Garzik
I'll let paulus and linuxppc merge this one (or not)... Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC]: napi_struct V4

2007-07-25 Thread Jeff Garzik
Stephen Hemminger wrote: The usage of NAPI on 8139cp and 8139too seems dodgy; these drivers expect this to work: local_irq_save(flags); cpw16_f(IntrMask, cp_intr_mask); __netif_rx_complete(dev); local_irq_restore(flags); It works

Re: [PATCH RFC]: napi_struct V4

2007-07-25 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik [EMAIL PROTECTED] Date: Wed, 25 Jul 2007 21:55:08 -0400 I don't see any logic to your request, only added overhead for no reason. There may be some flawed logic in what Stephen stated, but the change really is needed. It must be atomic to execute

Re: [PATCH RFX]: napi_struct V3

2007-07-24 Thread Jeff Garzik
Francois Romieu wrote: David Miller [EMAIL PROTECTED] : [...] I also didn't play with turning off NAPI in kconfig where drivers allow that, can we just get rid of that crap already? :-/ Would it be accepted for 2.6.23 or must it be considered post-2.6.23 ? The merge window is closed, so not

Re: [PATCH] [2.6.22] Fix a potential NULL pointer dereference in mace_interrupt() in drivers/net/pcmcia/nmclan_cs.c

2007-07-24 Thread Jeff Garzik
Micah Gruber wrote: This patch fixes a potential null dereference bug where we dereference DEV before a null check. This patch simply moves the dereferencing after the null check. Signed-off-by: Micah Gruber [EMAIL PROTECTED] --- --- a/drivers/net/pcmcia/nmclan_cs.c+++

Re: [PATCH 1/2] ucc_geth: add ethtool support

2007-07-24 Thread Jeff Garzik
Li Yang wrote: The patch enables statistics in ucc_geth and adds ethtool support to ucc_geth driver. Signed-off-by: Li Yang [EMAIL PROTECTED] --- drivers/net/Makefile |2 +- drivers/net/ucc_geth.c | 19 +- drivers/net/ucc_geth.h |6 +

Re: [PATCH 1/1] netxen: Load firmware during probe, dma watchdog fix.

2007-07-24 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: The firmware should be loaded after resetting hardware during PCI probe, besides module unload. This fixes issue with 2nd port of multiport adapter on powerpc blades. This patch also fixes a bug that PCI resources are not freed if dma watchdog shutdown failed. The dma

Re: [PATCH 1/10] ps3: fix wrong calculation of rx descriptor address

2007-07-24 Thread Jeff Garzik
Masakazu Mokuno wrote: Fixed the bug that calculation of the address of rx descriptor was wrong. Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED] --- drivers/net/ps3_gelic_net.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied 1-10 - To unsubscribe from this list: send the

Re: [PATCH 1/5] atl1: change tpd_avail function name

2007-07-24 Thread Jeff Garzik
Jay Cliburn wrote: Change tpd_avail() to atl1_tpd_avail(). Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- drivers/net/atl1/atl1_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) applied 1-5 - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [2.6 patch] drivers/net/acenic.c: fix check-after-use

2007-07-24 Thread Jeff Garzik
Adrian Bunk wrote: The Coverity checker noted that we've already dereferenced dev when we check whether it's NULL. Since it's impossible that dev is NULL at this place this patch removes the NULL check. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied - To unsubscribe from this

Re: [PATCH] eHEA: net_poll support

2007-07-24 Thread Jeff Garzik
Jan-Bernd Themann wrote: net_poll support for eHEA added Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c | 22 +- 2 files changed, 22 insertions(+), 2 deletions(-) applied - To unsubscribe

Re: [PATCH] defxx: Use __maybe_unused rather than a local hack

2007-07-24 Thread Jeff Garzik
Maciej W. Rozycki wrote: This is a change to remove a local hack in favour to __maybe_unused that has been recently added. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- Hi, It should be obvious. The code builds, therefore it works. Please apply, Maciej applied - To

Re: [PATCH 1/2] forcedeth: new device ids in pci_ids.h

2007-07-24 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch contains new device ids for MCP73 chipset. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] applied 1-2 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch 2/3] netdev: i82596 Ethernet needs asm/cacheflush.h

2007-07-24 Thread Jeff Garzik
Geert Uytterhoeven wrote: netdev: i82596 Ethernet needs asm/cacheflush.h on m68k drivers/net/82596.c: In function 'init_rx_bufs': drivers/net/82596.c:552: error: implicit declaration of function 'cache_clear' drivers/net/82596.c: In function 'i596_start_xmit': drivers/net/82596.c:1104: error:

Re: ANNOUNCE: igb: Intel 82575 Gigabit Ethernet driver (PCI-Express)

2007-07-20 Thread Jeff Garzik
Kok, Auke wrote: Jeff Garzik wrote: Kok, Auke wrote: http://foo-projects.org/~sofar/igb.patch [558K] http://foo-projects.org/~sofar/igb.patch.bz2 [98K] Just took a look at this. This has the same problem as in the other thread -- huge internal API -- except this time

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-18 Thread Jeff Garzik
Randy Dunlap wrote: On Wed, 18 Jul 2007 16:23:09 -0400 (EDT) Robert P. J. Day wrote: there's no point adding all that redundant content when it can all be done automatically. I like it. Are there any kconfig patches to support this plan? Speaking specifically to adding 'EXPERIMENTAL', I

Re: Please pull 'upstream-jgarzik' branch of wireless-2.6

2007-07-18 Thread Jeff Garzik
John W. Linville wrote: A few more for 2.6.23... Thanks! John --- The following changes since commit 4ad1366376bfef32ec0ffa12d1faa483d6f330bd: NeilBrown (1): md: change bitmap_unplug and others to void functions are available in the git repository at:

Re: [PATCH 1/4] ibmveth: Enable TCP checksum offload

2007-07-18 Thread Jeff Garzik
Brian King wrote: This patchset enables TCP checksum offload support for IPV4 on ibmveth. This completely eliminates the generation and checking of the checksum for packets that are completely virtual and never touch a physical network. A simple TCP_STREAM netperf run on a virtual network with

Re: [PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-07-18 Thread Jeff Garzik
Brian King wrote: This patch adds the appropriate ethtool hooks to allow for enabling/disabling of hypervisor assisted checksum offload for TCP. Signed-off-by: Brian King [EMAIL PROTECTED] --- linux-2.6-bjking1/drivers/net/ibmveth.c | 120 +++-

Re: [PATCH 4/4] ibmveth: Add ethtool driver stats hooks

2007-07-18 Thread Jeff Garzik
Brian King wrote: Add ethtool hooks to ibmveth to retrieve driver statistics. ACK patches 3-4 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] PHY fixed driver: rework release path and update phy_id notation

2007-07-18 Thread Jeff Garzik
Vitaly Bordug wrote: device_bind_driver() error code returning has been fixed. release() function has been written, so that to free resources in correct way; the release path is now clean. Before the rework, it used to cause Device '[EMAIL PROTECTED]:1' does not have a release() function,

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

2007-07-18 Thread Jeff Garzik
Where is the hard_start_xmit/TX-completion locking? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] fix wrong argument of tc35815_read_plat_dev_addr()

2007-07-18 Thread Jeff Garzik
Yoichi Yuasa wrote: Fix wrong argument of tc35815_read_plat_dev_addr() Signed-off-by: Yoichi Yuasa [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] eHEA: Fix bonding support

2007-07-18 Thread Jeff Garzik
Thomas Klein wrote: The driver didn't allow an interface's MAC address to be modified if the respective interface wasn't setup - a failing Hcall was the result. Thus bonding wasn't usable. The fix moves the failing Hcall which was registering a MAC address for the reception of BC packets in

Re: [PATCH try#6] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-18 Thread Jeff Garzik
[EMAIL PROTECTED] Cc: Mike Frysinger [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Cc: Christoph Hellwig [EMAIL PROTECTED] Cc: Dan Williams [EMAIL PROTECTED] Cc: Joe Perches [EMAIL PROTECTED] Cc: YOSHIFUJI Hideaki [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- MAINTAINERS

[git patches] net driver updates

2007-07-18 Thread Jeff Garzik
Nothing highly notable. Wireless pull, and new blackfin eth driver (didn't get merged with rest of blackfin, since additional review was requested). Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the

Re: ANNOUNCE: igb: Intel 82575 Gigabit Ethernet driver (PCI-Express)

2007-07-18 Thread Jeff Garzik
Kok, Auke wrote: All, We are pleased to announce a new Gigabit Ethernet product and its driver to the linux community. This product is the Intel(R) 82575 Gigabit Ethernet adapter family. Physical adapters will be available to the public soon. These adapters come in 2- and 4-port versions

Re: [PATCH] [2.6.22] Fix a potential NULL pointer dereference in free_shared_mem() in drivers/net/s2io.c

2007-07-16 Thread Jeff Garzik
Micah Gruber wrote: This patch fixes a potential null dereference bug where we dereference nic before a null check. This patch simply moves the dereferencing after the null check. Signed-off-by: Micah Gruber [EMAIL PROTECTED] --- a/drivers/net/s2io.c +++ b/drivers/net/s2io.c @@ -789,12

Re: Please pull 'upstream-jgarzik' branch of wireless-2.6

2007-07-16 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit 71780f59e127bb281a9302d430495ca9586c14e7: Linus Torvalds (1): Merge branch 'for-linus' of git://git.kernel.org/.../ieee1394/linux1394-2.6 are found in the git repository at:

Re: [PATCH 1/1] eHEA: Introducing support vor DLPAR memory add

2007-07-16 Thread Jeff Garzik
Thomas Klein wrote: This patch adds support for DLPAR memory add to the eHEA driver. To detect whether memory was added the driver uses its own memory mapping table and checks for kernel addresses whether they're located in already known memory sections. If not the function ehea_rereg_mrs() is

Re: [PATCH] Fix Tsi108 ethernet driver performance

2007-07-16 Thread Jeff Garzik
Alexandre Bounine wrote: From: Alexandre Bounine [EMAIL PROTECTED] This patch improves performance of the Tsi108 Ethernet driver by changing interrupt handling for frame receive path. It reduces number of interrupts generated for received frames and therefore lowers CPU utilization by the

Re: [patch 1/2] s390: scatter-gather for inbound traffic in qeth driver

2007-07-16 Thread Jeff Garzik
Ursula Braun wrote: From: Frank Blaschka [EMAIL PROTECTED] For large incoming packets PAGE_SIZE/2 qeth creates a fragmented skb by adding pointers to qdio pages to the fragment list of the skb. This avoids allocating big chunks of consecutive memory. Also copying data from the qdio buffer to

Re: [PATCH] macb: Use generic PHY layer

2007-07-16 Thread Jeff Garzik
applied both patches - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] EP93XX_ETH must select MII

2007-07-16 Thread Jeff Garzik
Adrian Bunk wrote: From: John Donoghue [EMAIL PROTECTED] CONFIG_EP93XX_ETH=y, CONFIG_MII=n results in an obvious link error. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: [PATCH] gianfar: kill unused header

2007-07-16 Thread Jeff Garzik
Kumar Gala wrote: A long time ago we used OCP with the gianfar driver. Eventually when we kill arch/ppc including this will cause issues so lets just kill it now. Signed-off-by: Kumar Gala [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [PATCH 1/1] myri10ge: Remove nonsensical limit in the tx done routine

2007-07-16 Thread Jeff Garzik
Brice Goglin wrote: Remove nonsensical limit in the tx done routine. Specifically, the loop will always terminate after processing = 1 rings worth of frames, as the mcp index is not refetched, so the removed conditional could never be true. Signed-off-by: Brice Goglin [EMAIL PROTECTED] ---

Re: [PATCH 1/1] 8139cp: implement the missing dev-tx_timeout

2007-07-16 Thread Jeff Garzik
Francois Romieu wrote: Signed-off-by: Mika Lansirinne [EMAIL PROTECTED] --- drivers/net/8139cp.c | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) applied, thanks for helping out Francois - To unsubscribe from this list: send the line unsubscribe netdev

Re: [linux-usb-devel] [PATCH]: cdc-subset to support new vendor/product ID

2007-07-16 Thread Jeff Garzik
jing xiang wrote: This patch is for cdc subset to support Mavell vendor/product ID. Signed-off-by: Jing Xiang [EMAIL PROTECTED] --- linux-2.6.21.5/drivers/usb/net/cdc_subset.c.orig2007-07-14 13:57:37.543028144 +0800 +++ linux-2.6.21.5/drivers/usb/net/cdc_subset.c 2007-07-14

Re: [PATCH 1/5] atl1: remove irq_sem

2007-07-16 Thread Jeff Garzik
Jay Cliburn wrote: Remove unnecessary irq_sem code. Signed-off-by: Chris Snook [EMAIL PROTECTED] Signed-off-by: Jay Cliburn [EMAIL PROTECTED] applied 1-5 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 1/3] forcedeth bug fix: cicada phy

2007-07-16 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch contains errata fixes for the cicada phy. It only renamed the defines to be phy specific. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] applied 1-3 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: [patch 37/44] xen: add virtual network device driver

2007-07-16 Thread Jeff Garzik
: Ian Pratt [EMAIL PROTECTED] Cc: Christian Limpach [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Cc: Stephen Hemminger [EMAIL PROTECTED] Cc: Christoph Hellwig [EMAIL PROTECTED] Cc: Rusty Russell [EMAIL PROTECTED] Cc: Herbert Xu [EMAIL PROTECTED] Cc: Keir Fraser [EMAIL PROTECTED] Cc: netdev

Re: [PATCH 2.6.22-rc7 0/4] phy/gianfar: Fixes for gianfar and vitesse RGMII-ID support

2007-07-16 Thread Jeff Garzik
Andy Fleming wrote: A few bugs in the Vitesse PHY driver were found on the 8641D HPCN board. Originally, they were masked by a bug in the PHY Lib which was fixed by patch 5f708dd91d15876e26d7a57f97a255cedffca463 (Fix phy_id for Vitesse 824x PHY). That patch allowed the Vitesse PHY to bind on

Re: [PATCH] NS83820: Handle multicast frames.

2007-07-16 Thread Jeff Garzik
YOSHIFUJI Hideaki / 吉藤英明 wrote: Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] applied all four patches - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-14 Thread Jeff Garzik
Michael Buesch wrote: Well, this bitfield _might_ be OK (although I don't like bitfields at all), but the above pointer casting stuff should really use leXX_to_cpu. It's so easy to use and it is easier to read and maintain the code afterwards. If the bitfield stays, a comment must be added.

Re: [PATCH] 7990 : Various fixes and cleanups

2007-07-13 Thread Jeff Garzik
Philippe De Muyter wrote: On Tue, Jul 10, 2007 at 12:38:45PM -0400, Jeff Garzik wrote: Philippe De Muyter wrote: This patch - avoids 7990 blocking when no tx buffer is available, [...] diff -r 6c0a10cc415a drivers/net/7990.c --- a/drivers/net/7990.cThu Jul 5 16:10:16 2007 -0700

Re: Splitting e1000 (Was: Re: e1000: backport ich9 support from 7.5.5 ?)

2007-07-13 Thread Jeff Garzik
Kok, Auke wrote: Sorry for not replying to this earlier (I was on vacation for 2 days). We had some internal discussions and all the noses appear to be facing in the proper direction. I'm very happy with this and it will be my highest priority to make this work. I will attempt to get a quick

Re: [PATCH 01/12] sky2: restore workarounds for lost interrupts

2007-07-10 Thread Jeff Garzik
Stephen Hemminger wrote: This patch restores a couple of workarounds from 2.6.16: * restart transmit moderation timer in case it expires during IRQ routine * default to having 10 HZ watchdog timer. At this point it more important not to hang than to worry about the power cost. Signed-off-by:

Re: [patch 3/7] atari_pamsnet.c: old declaration ritchie style fix

2007-07-10 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Yoann Padioleau [EMAIL PROTECTED] Use consistent function declaration style. Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/atari_pamsnet.c | 62 -- 1 files changed, 22 insertions(+), 40 deletions(-) applied

Re: [PATCH] spidernet: improve interrupt handling

2007-07-10 Thread Jeff Garzik
Linas Vepstas wrote: From: Ishizaki Kou [EMAIL PROTECTED] We intend this patch to improve spidernet interrupt handling to be more strict. We had following problem and this patch solves it. -when CONFIG_DEBUG_SHIRQ=y, request_irq() calls handler(). -when spider_net_open() is called, it calls

Re: [PATCH] PCMCIA: add Socket Ethernet card into pcnet_cs

2007-07-10 Thread Jeff Garzik
Marcin Juszkiewicz wrote: From: Marcin Juszkiewicz [EMAIL PROTECTED] One card submitted by Ångström user. Signed-off-by: Marcin Juszkiewicz [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] Fix typo in drivers/net/s2io.c

2007-07-10 Thread Jeff Garzik
Rolf Eike Beer wrote: Introduced in d796fdb708fc5b10112934cba43e832c36ce4923. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- commit 58056c2424917e90b86ca11c2c5d3fd35313d7b6 tree 854d63a14f96416aad64d12ea71cb331acfcc7db parent 87a2df362631d53fdc169a5d76969365aff69c10 author Rolf Eike Beer

Re: [2.6 patch] sis900_mii_probe() must be __devinit

2007-07-10 Thread Jeff Garzik
Adrian Bunk wrote: This patch fixes the following section mismatch: -- snip -- ... MODPOST vmlinux WARNING: drivers/built-in.o(.text+0x298170): Section mismatch: reference to .init.text:sis900_mii_probe (between 'sis900_probe' and 'sis900_default_phy') ... -- snip -- Signed-off-by:

Re: [2.6 patch] tokenring/3c359.c:xl_init() must be __devinit

2007-07-10 Thread Jeff Garzik
Adrian Bunk wrote: This patch fixes the following section mismatch: -- snip -- ... MODPOST vmlinux WARNING: drivers/built-in.o(.text+0x361ef1): Section mismatch: reference to .init.text:xl_init (between 'xl_probe' and 'xl_hw_reset') ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL

Re: [2.6 patch] rrunner.c:rr_init() must be __devinit

2007-07-10 Thread Jeff Garzik
Adrian Bunk wrote: This patch fixes the following section mismatch: -- snip -- ... MODPOST vmlinux WARNING: drivers/built-in.o(.text+0x26e3f2): Section mismatch: reference to .init.text:rr_init (between 'rr_init_one' and 'rr_remove_one') ... -- snip -- Signed-off-by: Adrian Bunk

Re: [PATCH] QE Ethernet driver writes to wrong register to mask interrupts

2007-07-10 Thread Jeff Garzik
Timur Tabi wrote: The QE Ethernet driver was writing to the wrong register to mask interrupts. In ucc_geth_stop(), it was clearing UCCE instead of UCCM. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- drivers/net/ucc_geth.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) applied

Re: [PATCH] e100: Fix Tyan motherboard e100 not receiving IPMI commands

2007-07-10 Thread Jeff Garzik
Auke Kok wrote: From: David Graham [EMAIL PROTECTED] The 82550 51 parts have an extended configuration block that includes a bit GMRC, required to enable the expected TCO behavior, in config byte offset 22d. The config block sent by the failing driver does include the extension area, but this

Re: [IOC3] Switch to pci refcounting safe APIs

2007-07-10 Thread Jeff Garzik
Ralf Baechle wrote: From: Alan Cox [EMAIL PROTECTED] Convert the IOC3 driver to use ref counting pci interfaces so that we can obsolete the (usually unsafe) pci_find_{slot/device} interfaces and avoid future authors writing hotplug-unsafe device drivers. Signed-off-by: Alan Cox [EMAIL

Re: [PATCH] 7990 : Various fixes and cleanups

2007-07-10 Thread Jeff Garzik
Philippe De Muyter wrote: This patch - avoids 7990 blocking when no tx buffer is available, [...] diff -r 6c0a10cc415a drivers/net/7990.c --- a/drivers/net/7990.cThu Jul 5 16:10:16 2007 -0700 +++ b/drivers/net/7990.cFri Jul 6 11:27:20 2007 +0200 [...] @@ -541,9 +546,6 @@

Re: [PATCH] AX88796 network driver

2007-07-10 Thread Jeff Garzik
Ben Dooks wrote: Support for the Asix AX88796 network controller, an NE2000 compatible 10/100 ethernet device with internal PHY. The driver supports PHY settings via either ioctl() or the ethtool driver ops. Signed-off-by: Ben Dooks [EMAIL PROTECTED] applied - To unsubscribe from this

Re: [PATCH] [1/2] phylib: cleanup marvell.c a bit

2007-07-10 Thread Jeff Garzik
Olof Johansson wrote: Simplify the marvell driver init a bit: Make the supported devices an array instead of explicitly registering each structure. This makes it considerably easier to add new devices down the road. Signed-off-by: Olof Johansson [EMAIL PROTECTED] applied 1-2 - To

Re: [PATCH] netxen: deinline and sparse fix

2007-07-10 Thread Jeff Garzik
Stephen Hemminger wrote: Get rid of dubious casts to (void *) which causes a sparse warning. And move largeish function from inline to the one file that uses the code, the compiler can then decide to inline it. Compile tested only. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] applied

Re: [PATCH 2.6.22-rc7] 8139cp: dev-tx_timeout

2007-07-10 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: (Resending the patch against 2.6.22-rc7) This patch implements the missing dev-tx_timeout for 8139cp driver Signed-off-by: Mika Lansirinne [EMAIL PROTECTED] ACK but still fails to apply - To unsubscribe from this list: send the line unsubscribe netdev in the body

<    4   5   6   7   8   9   10   11   12   13   >