the race is
by reading the sysctl variable using READ_ONCE.
Signed-off-by: Jiri Bohac <jbo...@suse.cz>
Reported-by: Julia Lawall <julia.law...@lip6.fr>
Fixes: 76506a986dc3 ("IPv6: fix DESYNC_FACTOR")
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index cc7c26d..06
, the
result of the check in such a situation would be not creating the
temporary address at all, which might be an even worse outcome
than the bogus lifetime.
Drop the faulty check.
Signed-off-by: Jiri Bohac <jbo...@suse.cz>
Reported-by: Julia Lawall <julia.law...@lip6.fr>
Fixes: 76506a986dc3
could underflow and the resulting
preferred lifetime could be almost infinity.
On the other hand, with this check, this situation will result
with the temporary address not being created at all, which might
be even worse. So if you prefer it, just drop the check.
Patch in a follow-up e-mail.
Th
Commit 76506a986dc31394fd1f2741db037d29c7e57843 (IPv6: fix
DESYNC_FACTOR) introduced a buggy check for underflow of
tmp_prefered_lft. tmp_prefered_lft is unsigned, so the condition
is always false.
Signed-off-by: Jiri Bohac <jbo...@suse.cz>
Reported-by: Julia Lawall <julia.law...@lip6.
oto err_release;
Signed-off-by: Jiri Bohac <jbo...@suse.cz>
---
include/net/if_inet6.h | 1 -
net/ipv6/addrconf.c| 61 --
2 files changed, 9 insertions(+), 53 deletions(-)
diff --git a/include/net/if_inet6.h b/include/net/if_inet6.h
inde
an the new upper bound, a new random value needs to be
re-generated.
And since we already have max_desync_factor configurable per interface, we
also need to calculate and store desync_factor per interface.
Signed-off-by: Jiri Bohac <jbo...@suse.cz>
---
include/net/if_inet6.h | 1 +
net
On Thu, Mar 17, 2016 at 01:03:59PM +0800, Herbert Xu wrote:
> On Wed, Mar 16, 2016 at 05:00:26PM +0100, Jiri Bohac wrote:
> > Prevent xfrm_output() from segmenting UFO packets so that they will be
> > fragmented after the xfrm transforms.
>
> Fair enough. But I won
(not to IP fragments).
Prevent xfrm_output() from segmenting UFO packets so that they will be
fragmented after the xfrm transforms.
Signed-off-by: Jiri Bohac <jbo...@suse.cz>
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 4355129..6f3e814 100644
--- a/include/linux/sk
err = ip6_ufo_append_data(sk, queue, getfrag, from, length,
hh_len, fragheaderlen,
I can't say which is better. Herbert originally seemed to like
the fix inside xfrm_output().
The IPv4 part is fixed by commit
c146066ab80267c3305de5dda6a4083f06df9265 (ipv4: Don't use uf
On Thu, Mar 17, 2016 at 11:24:59AM +0100, Steffen Klassert wrote:
> > > On Wed, Mar 16, 2016 at 05:00:26PM +0100, Jiri Bohac wrote:
> > Fixes my broken case.
>
> Is this IPv4 or IPv6? IPv4 should not create a GSO skb
> if IPsec is done. It checks for rt->dst.heade
nks,
--
Jiri Bohac <jbo...@suse.cz>
SUSE Labs, SUSE CZ
Hi,
On Sun, Sep 27, 2015 at 08:25:18PM +0300, Julian Anastasov wrote:
> On Fri, 25 Sep 2015, Jiri Bohac wrote:
>
> > if (!atomic_read(>n_control))
> > ip_vs_conn_expire_now(cp);
> > __ip_vs_conn_put(cp)
of the new connection
instead, like we do when the destination server is not available.
The timer will have deleted the old conntrack entry long before
the first packet of the new connection is retransmitted.
Signed-off-by: Jiri Bohac <jbo...@suse.cz>
diff --git a/net/netfilter/ipvs/ip_vs_co
.
The timer will have deleted the old conntrack entry long before
the first packet of the new connection is retransmitted.
Signed-off-by: Jiri Bohac <jbo...@suse.cz>
diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c
index d1d6b82..3f884b8 100644
--- a/net/net
a BUG in napi_enable().
This patch fixes the problem. Please apply.
Signed-off-by: Jiri Bohac [EMAIL PROTECTED]
diff --git a/drivers/net/amd8111e.c b/drivers/net/amd8111e.c
index eebf5bb..e7fdd81 100644
--- a/drivers/net/amd8111e.c
+++ b/drivers/net/amd8111e.c
@@ -1340,7 +1340,9 @@ static int
experimented with this? Is there any good reason why
we don't send NSs to all the links to find out which link the
destination LLA is on?
Regards,
--
Jiri Bohac [EMAIL PROTECTED]
SUSE Labs, SUSE CZ
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
Fixes a null pointer dereference when unloading the ipx module.
On initialization of the ipx module, registering certain packet
types can fail. When this happens, unloading the module later
dereferences NULL pointers. This patch fixes that. Please apply.
Signed-off-by: Jiri Bohac [EMAIL
17 matches
Mail list logo
