Re: [PATCH net-next v2] xen-netback: make copy batch size configurable

2018-01-04 Thread Joao Martins
On 12/26/2017 10:22 PM, David Miller wrote: > From: Joao Martins <joao.m.mart...@oracle.com> > Date: Thu, 21 Dec 2017 17:24:28 + > >> Commit eb1723a29b9a ("xen-netback: refactor guest rx") refactored Rx >> handling and as a result decreased max gran

[PATCH net-next v2] xen-netback: make copy batch size configurable

2017-12-21 Thread Joao Martins
er batches (i.e. for better throughput with big packets) as it was prior to the above mentioned commit. Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- Changes since v1: * move rx_copy.{idx,op} reallocation to separate helper Addressed Paul's comments: * rename xenvif_copy_

Re: [PATCH net-next v1] xen-netback: make copy batch size configurable

2017-11-13 Thread Joao Martins
On Mon, Nov 13, 2017 at 04:39:09PM +, Paul Durrant wrote: > > -Original Message- > > From: Joao Martins [mailto:joao.m.mart...@oracle.com] > > Sent: 13 November 2017 16:34 > > To: Paul Durrant <paul.durr...@citrix.com> > > Cc: netdev@vger.kernel.org

Re: [PATCH net-next v1] xen-netback: make copy batch size configurable

2017-11-13 Thread Joao Martins
On Mon, Nov 13, 2017 at 11:58:03AM +, Paul Durrant wrote: > On Mon, Nov 13, 2017 at 11:54:00AM +0000, Joao Martins wrote: > > On 11/13/2017 10:33 AM, Paul Durrant wrote: > > > On 11/10/2017 19:35 PM, Joao Martins wrote: [snip] > > >> diff --git a/drivers/net/

Re: [PATCH net-next v1] xen-netback: make copy batch size configurable

2017-11-13 Thread Joao Martins
On 11/13/2017 10:33 AM, Paul Durrant wrote: >> -Original Message- >> From: Joao Martins [mailto:joao.m.mart...@oracle.com] >> Sent: 10 November 2017 19:35 >> To: netdev@vger.kernel.org >> Cc: Joao Martins <joao.m.mart...@oracle.com>; Wei Liu &g

[PATCH net-next v1] xen-netback: make copy batch size configurable

2017-11-10 Thread Joao Martins
er batches (i.e. for better throughput with big packets) as it was prior to the above mentioned commit. Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- drivers/net/xen-netback/common.h| 6 -- drivers/net/xen-netback/interface.c | 25 - drivers

Re: [RFC PATCH 03/13] xen-netback: implement TX persistent grants

2015-06-03 Thread Joao Martins
On 02 Jun 2015, at 16:53, Wei Liu wei.l...@citrix.com wrote: On Fri, May 22, 2015 at 10:24:39AM +, Joao Martins wrote: On 19 May 2015, at 17:23, Wei Liu wei.l...@citrix.com wrote: On Tue, May 12, 2015 at 07:18:27PM +0200, Joao Martins wrote: Introduces persistent grants for TX path

Re: [RFC PATCH 04/13] xen-netback: implement RX persistent grants

2015-06-03 Thread Joao Martins
On 02 Jun 2015, at 17:07, Wei Liu wei.l...@citrix.com wrote: On Fri, May 22, 2015 at 10:25:10AM +, Joao Martins wrote: On 19 May 2015, at 17:32, Wei Liu wei.l...@citrix.com wrote: On Tue, May 12, 2015 at 07:18:28PM +0200, Joao Martins wrote: It starts by doing a lookup in the tree

Re: [Xen-devel] [RFC PATCH 00/13] Persistent grant maps for xen net drivers

2015-05-29 Thread Joao Martins
...@lists.xen.org] On Behalf Of Joao Martins Sent: Friday, May 22, 2015 6:27 PM To: Wei Liu Cc: ian.campb...@citrix.com; netdev@vger.kernel.org; david.vra...@citrix.com; xen-de...@lists.xenproject.org;boris.ostrov...@oracle.com Subject: Re: [Xen-devel] [RFC PATCH 00/13] Persistent grant maps

Re: [RFC PATCH 03/13] xen-netback: implement TX persistent grants

2015-05-22 Thread Joao Martins
On 19 May 2015, at 17:23, Wei Liu wei.l...@citrix.com wrote: On Tue, May 12, 2015 at 07:18:27PM +0200, Joao Martins wrote: Introduces persistent grants for TX path which follows similar code path as the grant mapping. It starts by checking if there's a persistent grant available for header

Re: [RFC PATCH 02/13] xen-netback: xenbus feature persistent support

2015-05-22 Thread Joao Martins
On 19 May 2015, at 17:19, Wei Liu wei.l...@citrix.com wrote: On Tue, May 12, 2015 at 07:18:26PM +0200, Joao Martins wrote: Checks for feature-persistent that indicates persistent grants support. Adds max_persistent_grants module param that specifies the max number of persistent grants, which

Re: [RFC PATCH 04/13] xen-netback: implement RX persistent grants

2015-05-22 Thread Joao Martins
On 19 May 2015, at 17:32, Wei Liu wei.l...@citrix.com wrote: On Tue, May 12, 2015 at 07:18:28PM +0200, Joao Martins wrote: It starts by doing a lookup in the tree for a gref. If no persistent grant is found on the tree, it will do grant copy and prepare the grant maps. Finally valides

Re: [RFC PATCH 00/13] Persistent grant maps for xen net drivers

2015-05-22 Thread Joao Martins
On 19 May 2015, at 17:39, Wei Liu wei.l...@citrix.com wrote: On Tue, May 12, 2015 at 07:18:24PM +0200, Joao Martins wrote: There have been recently[3] some discussions and issues raised on persistent grants for the block layer, though the numbers above show some significant improvements

Re: [RFC PATCH 06/13] xen-netback: copy buffer on xenvif_start_xmit()

2015-05-22 Thread Joao Martins
On 19 May 2015, at 17:35, Wei Liu wei.l...@citrix.com wrote: On Tue, May 12, 2015 at 07:18:30PM +0200, Joao Martins wrote: By introducing persistent grants we speed up the RX thread with the decreased copy cost, that leads to a throughput decrease of 20%. It is observed that the rx_queue

Re: [RFC PATCH 08/13] xen-netback: clone skb if skb-xmit_more is set

2015-05-22 Thread Joao Martins
On 19 May 2015, at 17:36, Wei Liu wei.l...@citrix.com wrote: On Tue, May 12, 2015 at 07:18:32PM +0200, Joao Martins wrote: On xenvif_start_xmit() we have an additional queue to the netback RX kthread that will sends the packet. When using burst1 pktgen sets skb-xmit_more to tell the driver

Re: [Xen-devel] [RFC PATCH 12/13] xen-netfront: implement TX persistent grants

2015-05-19 Thread Joao Martins
On 18 May 2015, at 17:55, David Vrabel david.vra...@citrix.com wrote: On 12/05/15 18:18, Joao Martins wrote: Instead of grant/revoking the buffer related to the skb, it will use an already granted page and memcpy to it. The grants will be mapped by xen-netback and reused overtime, but only

[RFC PATCH 06/13] xen-netback: copy buffer on xenvif_start_xmit()

2015-05-12 Thread Joao Martins
Mpps (burst 2, pkt_size 64) compared to using the kthread. Maximum with grant copy is 1.2 Mpps, irrespective of the burst. All of this, measured on an Intel(R) Xeon(R) CPU E5-1650 v2 @ 3.50GHz. Signed-off-by: Joao Martins joao.mart...@neclab.eu --- drivers/net/xen-netback/common.h| 2