On Tue, 2007-10-23 at 20:43 -0700, David Miller wrote:
From: Pavel Emelyanov [EMAIL PROTECTED]
Date: Tue, 23 Oct 2007 20:37:22 +0400
The /proc/net udp6, tcp6 and raw6 files print the IPs of
the connection ends. Make a NIP6Lxxx macros (L stands for
long) for making the printing code look
On Tue, 2007-10-23 at 21:10 -0700, David Miller wrote:
We'll break things if we change it.
Maybe, but definitely the macro names should
reflect this brokenness.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
It's a bit after 2.6.1 now...
Removes unnecessary if, uses 16 bit rotate left.
Performance improves ~30%
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index 7c0b515..1c50f4c 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
On Mon, 2007-10-22 at 18:43 -0700, David Miller wrote:
Ok, but again did you test it?
Nope. Stephen Hemminger did in 2003.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On Mon, 2007-10-22 at 17:35 -0700, David Miller wrote:
Your code is rotating bit 15 down by one bit and bits 0-14 up by one
bit.
Yes, a 16 bit rotate left.
There was a discussion a few years ago:
http://oss.sgi.com/archives/netdev/2003-10/msg00734.html
From the spec:
Implementers of DDP
On Mon, 2007-10-22 at 20:30 -0700, Stephen Hemminger wrote:
Corrected fast code is:
while (len--) {
sum += *data++;
sum = 1;
sum = (((sum 0x1) 16) + sum) 0x;
}
At least it is correct on the standalone
Prefix dprintk with KERN_DEBUG
Fix a bug with existing use of dprintk (PFX KERN_INFO PFX)
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 419c00c..9c11087 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -44,7 +44,8
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 419c00c..9c11087 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -2310,7 +2311,7 @@ static void rtl8169_reinit_task(struct work_struct *work)
ret = rtl8169_open(dev
remove buggy and unused vdbg macro
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/drivers/net/ucc_geth_mii.c b/drivers/net/ucc_geth_mii.c
index df884f0..a4b481c 100644
--- a/drivers/net/ucc_geth_mii.c
+++ b/drivers/net/ucc_geth_mii.c
@@ -46,13 +46,6 @@
#include ucc_geth_mii.h
On Fri, 2007-10-05 at 13:53 -0400, Jeff Garzik wrote:
diff --git a/drivers/net/e1000e/hw.h b/drivers/net/e1000e/hw.h
index 848217a..aa82f1a 100644
--- a/drivers/net/e1000e/hw.h
+++ b/drivers/net/e1000e/hw.h
@@ -852,7 +852,7 @@ struct e1000_hw {
#ifdef DEBUG
#define hw_dbg(hw,
On Mon, 2007-10-15 at 09:20 -0700, Kok, Auke wrote:
Instead the fix should be for the 2 existing bugs on macro:
o Comma after KERN_DEBUG
o Semicolon in macro
will push a patch, thanks.
Perhaps you could fix this one too?
$ grep -P -r --include=*.[ch] \bprintk\s*\(\s*KERN_[A-Z]+\s*\, *
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index c921ec3..40019aa 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -44,7 +44,8 @@
printk( Assertion failed! %s,%s,%s,line=%d\n, \
#expr,__FILE__
On Tue, 2007-10-02 at 12:57 -0400, Jeff Garzik wrote:
\ @@ -1924,7 +1925,7 @@ static void rtl_hw_start_8169(struct net_device *dev)
if ((tp-mac_version == RTL_GIGA_MAC_VER_02) ||
(tp-mac_version == RTL_GIGA_MAC_VER_03)) {
- dprintk(KERN_INFO PFX Set MAC Reg C+CR
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_wx.c
b/drivers/net/wireless/bcm43xx/bcm43xx_wx.c
index d6d9413..6acfdc4 100644
--- a/drivers/net/wireless/bcm43xx/bcm43xx_wx.c
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_wx.c
@@ -444,7 +444,7 @@ static
On Tue, 2007-09-25 at 19:29 -0700, David Miller wrote:
I'm going to hold on this for now, there is no universal
agreement that this is something we want to do and I'd
like to take care of getting the more certain stuff into
net-2.6.24 before iffy bits like this one.
Here's an argument for
On Wed, 2007-09-19 at 12:54 -0700, David Miller wrote:
Applied to net-2.6.24, thanks Joe!
Here is a patch that adds some type safety to print_mac
by using a struct print_mac_buf * instead of char *.
It also reduces the defconfig vmlinux size by 8 bytes.
Signed-off-by: Joe Perches [EMAIL
On Fri, 2007-09-21 at 12:35 +0200, Urs Thuermann wrote:
I didn't find a way with gcc-2.95 to make the format
string a separate macro argument (which I also wanted).
The old 2.x GCC workaround was to use
#define DBG(fmt, arg) printk(fmt , ## arg)
adding a space before the last comma.
I
In the same vein as print_mac, the implementations
introduce declaration macros:
DECLARE_IP_BUF(var)
DECLARE_IPV6_BUF(var)
and functions:
print_ip
print_ipv6
print_ipv6_nofmt
IPV4 Use:
DECLARE_IP_BUF(ipbuf);
__be32 addr;
This removes the uses of NIPQUAD and HIPQUAD in
drivers/net and net
IPV4 Use:
DECLARE_IP_BUF(ipbuf);
__be32 addr;
print_ip(ipbuf, addr)
Signed-off-by: Joe Perches [EMAIL PROTECTED]
please pull from:
git pull http://repo.or.cz/r/linux-2.6/trivial-mods.git print_ipv4
On Thu, 2007-09-20 at 07:55 -0700, Randy Dunlap wrote:
How large are the patches if you posted them for review instead
of just referencing gits for them? (which cuts down on review
possibilities)
The v4 is ~130kb, the v6 ~35kb.
There is a gitweb available at:
print_ip:
On Thu, 2007-09-20 at 20:43 +0200, Urs Thuermann wrote:
+#define DBG(...) (debug 1 ? \
+ (printk(KERN_DEBUG can-%s %s: , \
+ IDENT, __func__), printk(args)) : 0)
+#define DBG_FRAME(args...) (debug 2 ? can_debug_cframe(args) :
On Fri, 2007-09-21 at 01:05 +0200, Thomas Graf wrote:
What exactly is the advantage of this?
It makes the kernel image smaller and has consistency,
typechecking and sparse advantages.
print_mac(char *buf, const u8 *addr)
print_ip(char *buf, __be32 addr)
print_ipv6(char *buf, const u8 *addr)
allyesconfig
CC drivers/net/wireless/p54pci.o
LD drivers/net/wireless/built-in.o
drivers/net/wireless/b43legacy/built-in.o: In function `tsf_read_file':
drivers/net/wireless/b43legacy/debugfs.c:80: multiple definition of
`tsf_read_file'
On Mon, 2007-09-17 at 19:14 -0700, Joe Perches wrote:
On Mon, 2007-09-17 at 19:05 -0700, David Miller wrote:
Anyways, it would indeed help if you could rebase the patch
against net-2.6.24 It would save me a ton of time.
I'll rebase it tomorrow against whatever's in
your current net
On Mon, 2007-09-17 at 19:05 -0700, David Miller wrote:
Anyways, it would indeed help if you could rebase the patch
against net-2.6.24 It would save me a ton of time.
I'll rebase it tomorrow against whatever's in
your current net-2.6.24.
cheers, Joe
-
To unsubscribe from this list: send the
-by: Joe Perches [EMAIL PROTECTED]
--
include/linux/if_ether.h |7 +++
include/net/ieee80211.h |5 -
include/net/mac80211.h |4
3 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h
index 3213f6f
On Wed, 2007-09-12 at 11:44 -0700, Medve Emilian-EMMEDVE1 wrote:
First, this patch doesn't have the trailing \n problem that one had.
I expect all the kernel logging functions to be
overhauled eventually.
I'd prefer a mechanism that somehow supports
identifying complete messages. I think the
On Wed, 2007-09-05 at 15:23 +0100, Stephen Hemminger wrote:
--- a/drivers/net/3c59x.c 2007-09-05 15:15:16.0 +0100
+++ b/drivers/net/3c59x.c 2007-09-05 15:16:29.0 +0100
@@ -1122,7 +1122,7 @@ static int __devinit vortex_probe1(struc
On Tue, 2007-08-28 at 14:22 -0700, David Miller wrote:
From: Joe Perches [EMAIL PROTECTED]
Option 2:
DECLARE_MAC_BUF(mac);
printk(%s, print_mac(mac, dev-dev_addr));
I'm slightly leaning towards 2.
Here are the patches for this conversion.
Compiled successfully x86, defconfig
On Sat, 2007-09-01 at 00:32 +0200, Johannes Berg wrote:
I think you got a bit too trigger-happy:
p += sprintf(p, key[%d] alg=CCMP key_set=%d
-tx_pn=%02x%02x%02x%02x%02x%02x
-rx_pn=%02x%02x%02x%02x%02x%02x
+tx_pn=%s
+
On Wed, 2007-08-29 at 16:47 -0700, Joe Perches wrote:
On Wed, 2007-08-29 at 16:41 -0700, David Miller wrote:
From: Joe Perches [EMAIL PROTECTED]
Date: Wed, 29 Aug 2007 16:34:00 -0700
On Tue, 2007-08-28 at 17:59 -0700, David Miller wrote:
I pushed this fix into net-2.6.24 just now
On Thu, 2007-08-30 at 22:20 +0200, Jesper Juhl wrote:
Ok, I must admit I didn't check with sparse since it seemed pointless
- we usually never cast void pointers to other pointer types,
specifically because the C language nicely guarantees that the right
thing will happen without the cast.
On Wed, 2007-08-29 at 16:41 -0700, David Miller wrote:
From: Joe Perches [EMAIL PROTECTED]
Date: Wed, 29 Aug 2007 16:34:00 -0700
On Tue, 2007-08-28 at 17:59 -0700, David Miller wrote:
I pushed this fix into net-2.6.24 just now, thanks again.
This tree doesn't compile for me defconfig
On Tue, 2007-08-28 at 00:01 +, Linux Kernel Mailing List wrote:
+NETWORKING [LABELED] (NetLabel, CIPSO, Labeled IPsec, SECMARK)
+P: Paul Moore
+M: [EMAIL PROTECTED]
+L: netdev@vger.kernel.org
+S: Maintained
+
Aren't there now 2 subsystems in MAINTAINERS for the same thing?
On Tue, 2007-08-28 at 08:46 -0400, Paul Moore wrote:
If having both a labeled networking and NetLabel maintainer entry is a
problem then how about the patch below?
I don't think it is.
-NETWORKING [LABELED] (NetLabel, CIPSO, Labeled IPsec, SECMARK)
+NETWORKING [LABELED] (NetLabel/CIPSO,
On Mon, 2007-08-27 at 14:37 -0700, David Miller wrote:
From: Joe Perches [EMAIL PROTECTED]
My original patch had the equivalent of
char* print_mac(char* buf, const char* addr) {
sprintf(buf,%02x:..., addr[0]...)
return buf;
}
and used
On Tue, 2007-08-28 at 14:22 -0700, David Miller wrote:
Option 2:
DECLARE_MAC_BUF(mac);
printk(%s, print_mac(mac, dev-dev_addr));
Between them, 1 and 2 seem roughly the same, but I'm slightly leaning
towards 2.
2 it is then.
I thought you said Johannes' patch was reverted,
but so
On Mon, 2007-08-27 at 12:54 +0200, Johannes Berg wrote:
Thanks for this patch though, I'd have done it otherwise.
I had it, it was just a s/EUI48/MAC/ and copy/paste thing.
There are also the arch, drivers/[^net], and net directories
that have a few of these.
The patch also added the missing )
On Mon, 2007-08-27 at 13:41 -0700, David Miller wrote:
From: Johannes Berg [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 12:54:09 +0200
#define MAC_FMT %s
#define MAC_ARG(a) ({char __buf[18]; print_mac(a, __buf); __buf;})
I don't think this works.
$ cat test_fmt.c
#include stdio.h
#include
On Mon, 2007-08-27 at 13:41 -0700, David Miller wrote:
there are better approaches to this,
how about just calling:
print_mac(dev-dev_addr);
Sure, we'll have to split up printk() calls, but in the end it's
likely still smaller and better. And I think it's much cleaner
than this
On Sun, 2007-08-26 at 10:30 +0200, Geert Uytterhoeven wrote:
On Fri, 24 Aug 2007, Joe Perches wrote:
Corrected printk calls with multiple output lines which
did not correctly preface each line with KERN_level
Fixed uses of some single lines with too many KERN_level
--- a/arch/arm/kernel
On Wed, 2007-08-22 at 20:46 +0200, Johannes Berg wrote:
The two different wireless code bases both define macros to ease
printing MAC addresses:
There are also several different uses of the equivalent of
printk(%02x,addr[0])
for (i=1; i6; i++)
On Wed, 2007-08-15 at 19:58 -0400, Dave Jones wrote:
Signed-off-by: Dave Jones [EMAIL PROTECTED]
diff --git a/drivers/infiniband/hw/mlx4/mad.c
b/drivers/infiniband/hw/mlx4/mad.c
index 3330917..0ed02b7 100644
--- a/drivers/infiniband/hw/mlx4/mad.c
+++ b/drivers/infiniband/hw/mlx4/mad.c
@@
On Sun, 2007-08-12 at 23:36 -0700, David Miller wrote:
Ok, 374 patches is just rediculious.
So many patches eats up an enormous amount of mailing list resources,
and for these patches in particular there are few reasons to split
them up at all. The fact that the split up landed you at 300+
On Mon, 2007-08-13 at 00:18 -0700, David Miller wrote:
The posting limit is 400K for linux-kernel, netdev, and one
or two of the other lists.
Apologies. Posted it twice over 2 days.
Anyway, I supposed you could kill the spool entries if you want.
cheers, Joe
-
To unsubscribe from this list:
On Mon, 2007-08-13 at 11:49 +0100, Alan Cox wrote:
diff --git a/MAINTAINERS b/MAINTAINERS
index 90c1b81..ac2226b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -697,6 +697,7 @@ ARPD SUPPORT
P: Jonathan Layes
L: netdev@vger.kernel.org
S: Maintained
+F: net/ipv4/arp.c
NAK
On Mon, 2007-08-13 at 17:35 +0100, Alan Cox wrote:
I wouldn't add a pattern for this.
Back to:ARPD SUPPORT
P: Jonathan Layes
L: netdev@vger.kernel.org
S: Maintained
Actually I think the entire thing is a
bad idea but thats another matter.
Of course it's not an end-all
On Mon, 2007-08-13 at 10:45 -0500, Linas Vepstas wrote:
Note quite right. spider-pic is not part of spider_net.
SPIDERNET NETWORK DRIVER for CELL
P: Linas Vepstas
M: [EMAIL PROTECTED]
L: netdev@vger.kernel.org
S: Supported
F: Documentation/networking/spider_net.txt
F:
On Mon, 2007-07-30 at 16:05 -0700, David Miller wrote:
I still don't know about this patch. Instead of the simple
transformation:
- printk(foo);
+ printk(KERN_INFO foo);
we get this new macro, and the lines changes to use that macro.
Actually, I agree.
Many local macros could
Similar usage to ndev_ and dev_ printk macros
Adds KERN_level indicators to all printks.
Correct a spelling error
Format u64 subtraction to %llu and (unsigned long long)
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index b92a322..5a94cfc 100644
On Wed, 2007-07-18 at 15:49 -0700, David Miller wrote:
From: Joe Perches [EMAIL PROTECTED]
Date: Wed, 18 Jul 2007 15:14:13 -0700
-#define VERSION pktgen v2.68: Packet Generator for packet performance
testing.\n
+#define PKTGEN_NAMEpktgen
+#define PKTGEN_VERSION v2.68
+#define
On Mon, 2007-06-11 at 17:40 -0700, Auke Kok wrote:
+#define ndev_err(netdev, level, format, arg...) \
+ do { \
+ struct net_device *__nd = (netdev); \
+ if ((__nd)-msg_enable NETIF_MSG_##level) \
+ printk(KERN_ERR %s: %s: format, (__nd)-name,
I like the ndev_printk idea.
I think a ndev_level printks should take a const netdev*
as the first argument.
Also, better for the non-debug use of ndev_dbg is to have a
static inline function so printf args are verified.
For instance, dev_dbg does:
static inline int __attribute__ ((format
On Mon, 2007-06-11 at 14:37 -0700, Auke Kok wrote:
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 3a70f55..d185f41 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -540,6 +540,8 @@ struct net_device
struct device dev;
On Mon, 2007-06-11 at 15:01 -0700, Kok, Auke wrote:
msg_enable is more frequently defined in drivers/net as u32 not int.
yes, we're only using the bottom 15 bits anyway, but the net_device struct
consistently uses 'int' style members, leaving it up to the compiler to pick
an
appropriate
On Fri, 2007-02-16 at 11:50 +0100, Thomas Sailer wrote:
On Thu, 2007-02-15 at 19:36 -0800, Joe Perches wrote:
remove local random function, use random32() instead
Signed-off-by: Joe Perches [EMAIL PROTECTED]
Acked-By: Thomas Sailer [EMAIL PROTECTED]
There are a bunch of other drivers
Einar Lueck's email addresses bounce
[EMAIL PROTECTED][EMAIL PROTECTED]
Removed local random number generator function
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/net/ipv4/multipath_random.c b/net/ipv4/multipath_random.c
index b8c289f..6448e6c 100644
--- a/net/ipv4
remove local random function, use random32() instead
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/drivers/net/hamradio/baycom_epp.c
b/drivers/net/hamradio/baycom_epp.c
index 153b6dc..84aa211 100644
--- a/drivers/net/hamradio/baycom_epp.c
+++ b/drivers/net/hamradio/baycom_epp.c
On Sat, 2007-02-10 at 07:02 +0100, Michael Buesch wrote:
On Saturday 10 February 2007 02:27, Daniel Drake wrote:
Robert P.J. Day's recent commit (getting rid of all casts of k[cmz]alloc()
calls) introduced a sparse warning for zd1211rw, related to our
type-checking
of addresses.
On Tue, 2007-01-30 at 14:12 -0800, David Miller wrote:
Therefore we must decrement i twice before the first
free during the cleanup. One to undo the for() loop
increment, and one to skip the ifb_init_one() case which
failed.
Perhaps putting the error unwind inside the for loop
is
On Sat, 2006-02-11 at 19:30 -0500, Dave Jones wrote:
It's easy to trigger a flood of 'protocol not supported' messages,
and probably not much more work to trigger the others.
Signed-off-by: Dave Jones [EMAIL PROTECTED]
--- linux-2.6.15.noarch/include/net/irda/irda.h~ 2006-02-11
whitespace
use pr_debug
don't use tmp for different types in a single function
don't shift and mask MAC address multiple times
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/drivers/net/acenic.c b/drivers/net/acenic.c
index b508812..3f2fa86 100644
--- a/drivers/net/acenic.c
+++ b
assign out of an if
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index ee93abc..2d9a862 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -241,7 +241,7 @@ static void packet_sock_destruct(struct
BUG_TRAP
to use NIP6_FMT
fixes net/ipv6/ip6_flowlabel.c
adds NIPQUAD_FMT to kernel.h
fixes net/netfilter/nf_conntrack_ftp.c
changes a few uses of %u.%u.%u.%u to NIPQUAD_FMT for symmetry to
NIP6_FMT
signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/include/linux
801 - 864 of 864 matches
Mail list logo
