Re: [PATCH 2/3] net: ethernet: bgmac: Make IDM register space optional

On Mon, Jul 17, 2017 at 2:37 PM, Abhishek Shah wrote: > Hi Jon, > >> This also will need to be added to >> drivers/net/ethernet/broadcom/bgmac-bcma.c. Otherwise, the driver >> will no longer work for those platforms. Since this was already >> accepted, please push

Re: [PATCH 2/3] net: ethernet: bgmac: Make IDM register space optional

On Thu, Jul 13, 2017 at 3:04 PM, Abhishek Shah wrote: > IDM operations are usually one time ops and should be done in > firmware itself. Driver is not supposed to touch IDM registers. > > However, for some SoCs', driver is performing IDM read/writes. > So this patch

Re: [PATCH net] mdio: mux: fix parsing mux registers outside of the PHY address range

On Mon, Jul 10, 2017 at 8:56 AM, Andrew Lunn wrote: > On Mon, Jul 10, 2017 at 02:35:23PM +0200, Martin Blumenstingl wrote: >> mdio_mux_init parses the child nodes of the MDIO mux. When using >> "mdio-mux-mmioreg" the child nodes are describing the register value >> that is written

[PATCH net-next] of_mdio: move of_mdio_parse_addr to header file

-by: Liviu Dudau <li...@dudau.co.uk> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Fixes: 342fa1964439 ("mdio: mux: make child bus walking more permissive and errors more verbose") --- drivers/of/of_mdio.c| 22 -- include/linux/of_mdio.h | 24 +

Re: [PATCH net-next] net: phy: use of_mdio_parse_addr

On Wed, Jun 7, 2017 at 12:18 PM, Liviu Dudau <li...@dudau.co.uk> wrote: > On Fri, Jun 02, 2017 at 02:22:51PM -0400, David Miller wrote: >> From: Jon Mason <jon.ma...@broadcom.com> >> Date: Wed, 31 May 2017 15:43:30 -0400 >> >> > use of_mdio_parse_addr()

[PATCH net-next] mdio: mux: make child bus walking more permissive and errors more verbose

of the MDIO bus be fatal for all entries. Instead, we should provide verbose errors describing the error and then attempt to continue if it all possible. Also, use of_mdio_parse_addr() Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/phy/mdio-mux.c | 24 +

[PATCH net-next] net: phy: use of_mdio_parse_addr

use of_mdio_parse_addr() in place of an OF read of reg and a bounds check (which is litterally the exact same thing that of_mdio_parse_addr() does) Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/phy/mdio_bus.c | 15 ++- 1 file changed, 2 insertions(+), 13 del

Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

On Fri, May 12, 2017 at 6:52 PM, Florian Fainelli wrote: > On 05/12/2017 09:22 AM, David Miller wrote: >> From: Julia Lawall >> Date: Fri, 12 May 2017 22:54:23 +0800 (SGT) >> >>> Device node iterators put the previous value of the index variable, so an

[PATCH] mdio: mux: Correct mdio_mux_init error path issues

, I am adding it where necessary to make it uniform. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Fixes: f20e6657a875 ("mdio: mux: Enhanced MDIO mux framework for integrated multiplexers") Fixes: 0ca2997d1452 ("netdev/of/phy: Add MDIO bus multiplexer support.") ---

[PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error path

ath for mdio_mux_init() which calls mdiobus_unregister() prior to mdiobus_free(). Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs") --- drivers/net/phy/mdio-mux-bcm-iproc.c | 5 - 1 file changed, 4 insertions(+),

Re: [PATCH 2/2] ARM: dts: Add the ethernet and ethernet PHY to the cygnus core DT.

On Tue, Apr 25, 2017 at 11:23 AM, Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> wrote: > Hello! > > On 04/25/2017 06:15 PM, Jon Mason wrote: > >>>> Cygnus has a single amac controller connected to the B53 switch with 2 >>>> PHYs. On the BCM911360

Re: [PATCH 2/2] ARM: dts: Add the ethernet and ethernet PHY to the cygnus core DT.

On Tue, Apr 25, 2017 at 5:40 AM, Sergei Shtylyov wrote: > Hello. > > On 4/25/2017 12:50 AM, Eric Anholt wrote: > >> Cygnus has a single amac controller connected to the B53 switch with 2 >> PHYs. On the BCM911360_EP platform, those two PHYs are connected to >>

Re: [PATCH] net: ethernet: bgmac: Allow MAC address to be specified in DTB

TCH > net-next] or [PATCH net] in the subject, see the netdev-FAQ.txt for > details: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt I believe he wants this in net-next Acked-by: Jon Mason <jo

Re: [PATCH net v4 0/2] net: ethernet: bgmac: bug fixes

On Thu, Mar 02, 2017 at 12:56:05PM -0800, David Miller wrote: > From: David Miller <da...@davemloft.net> > Date: Thu, 02 Mar 2017 12:50:15 -0800 (PST) > > > From: Jon Mason <jon.ma...@broadcom.com> > > Date: Tue, 28 Feb 2017 13:41:49 -0500 > > > >&

[PATCH net v5 1/2] net: ethernet: bgmac: init sequence bug

it out of reset regardless of whether it was in reset or not). Also, removed unnecessary usleeps (as there is already a read present to flush the IDM writes). Signed-off-by: Zac Schroff <zschr...@broadcom.com> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Fixes: f6a95a24957 (&q

[PATCH net v5 2/2] net: ethernet: bgmac: mac address change bug

From: Hari Vyas <ha...@broadcom.com> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas <ha...@broadcom.com> Signed-off-b

[PATCH net v5 0/2] net: ethernet: bgmac: bug fixes

preserved (Per Rafal Mileki) * Style change to reorder the function variables in patch 2 (per Sergei Shtylyov) Bug fixes for bgmac driver Hari Vyas (1): net: ethernet: bgmac: mac address change bug Jon Mason (1): net: ethernet: bgmac: init sequence bug drivers/net/ethernet/broadcom/bgmac

[PATCH net-next v3 0/3] net: ethernet: bgmac: PM support and clean-ups

Jon Mason (2): net: ethernet: bgmac: use #defines for MAX size net: ethernet: bgmac: unify code of the same family drivers/net/ethernet/broadcom/bgmac-bcma.c | 64 +++--- drivers/net/ethernet/broadcom/bgmac-platform.c | 34 ++ drivers/net/ethernet/broadcom

[PATCH net-next v3 1/3] net: ethernet: bgmac: use #defines for MAX size

The maximum frame size is really just the standard ethernet frame size and FCS. So use those existing defines to make the code a little more beautiful. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac.h | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH net-next v3 3/3] net: ethernet: bgmac: driver power manangement

From: Joey Zhong <zho...@broadcom.com> Implement suspend/resume callbacks in the bgmac driver. This makes sure that we de-initialize and re-initialize the hardware correctly before entering suspend and when resuming. Signed-off-by: Joey Zhong <zho...@broadcom.com> Signed-off-b

[PATCH net-next v3 2/3] net: ethernet: bgmac: unify code of the same family

BCM471X and BCM535X are of the same family (from what I can derive from internal documents). Group them into the case statement together, which results in more code reuse. Also, use existing helper variables to make the code a little more readable too. Signed-off-by: Jon Mason <jon

[PATCH net v4 1/2] net: ethernet: bgmac: init sequence bug

it out of reset regardless of whether it was in reset or not). Also, removed unnecessary usleeps (as there is already a read present to flush the IDM writes). Signed-off-by: Zac Schroff <zschr...@broadcom.com> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Fixes: f6a95a24957 (&q

[PATCH net v4 0/2] net: ethernet: bgmac: bug fixes

Hari Vyas (1): net: ethernet: bgmac: mac address change bug Jon Mason (1): net: ethernet: bgmac: init sequence bug drivers/net/ethernet/broadcom/bgmac-platform.c | 27 +- drivers/net/ethernet/broadcom/bgmac.c | 6 +- drivers/net/ethernet/broadcom/bgmac.h

[PATCH net v4 2/2] net: ethernet: bgmac: mac address change bug

From: Hari Vyas <ha...@broadcom.com> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas <ha...@broadcom.com> Signed-off-b

Re: [PATCH] net: bgmac: store MAC address directly in netdev->dev_addr

_enet_probe(). Instead it can > directly be stored in netdev->dev_addr. > > Also use eth_hw_addr_random() instead of eth_random_addr() in case a > random MAC is nedded. This will make sure netdev->addr_assign_type will > be properly set. > > Signed-off-by: Tobias Klauser <

[PATCH net] net: phy: Initialize mdio clock at probe function

ed-off-by: Yendapally Reddy Dhananjaya Reddy <yendapally.re...@broadcom.com> Fixes: ddc24ae1 ("net: phy: Broadcom iProc MDIO bus driver") Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/phy/mdio-bcm-ipr

[PATCH net v3 0/2] net: ethernet: bgmac: bug fixes

the first match to make it more obvious what portions of the register were being preserved (Per Rafal Mileki) * Style change to reorder the function variables in patch 2 (per Sergei Shtylyov) Bug fixes for bgmac driver Hari Vyas (1): net: ethernet: bgmac: mac address change bug Jon Mason (1

[PATCH net-next v2 1/3] net: ethernet: bgmac: use #defines for MAX size

The maximum frame size is really just the standard ethernet frame size and FCS. So use those existing defines to make the code a little more beautiful. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac.h | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH net-next v2 0/3] net: ethernet: bgmac: PM support and clean-ups

Changes in v2: * Reworked the PM patch with Florian's suggestions Add code to support Power Management (only tested on NS2), and add some code clean-ups Joey Zhong (1): net: ethernet: bgmac: driver power manangement Jon Mason (2): net: ethernet: bgmac: use #defines for MAX size net

[PATCH net-next v2 3/3] net: ethernet: bgmac: driver power manangement

From: Joey Zhong <zho...@broadcom.com> Implement suspend/resume callbacks in the bgmac driver. This makes sure that we de-initialize and re-initialize the hardware correctly before entering suspend and when resuming. Signed-off-by: Joey Zhong <zho...@broadcom.com> Signed-off-b

[PATCH net-next v2 2/3] net: ethernet: bgmac: unify code of the same family

BCM471X and BCM535X are of the same family (from what I can derive from internal documents). Group them into the case statement together, which results in more code reuse. Also, use existing helper variables to make the code a little more readable too. Signed-off-by: Jon Mason <jon

[PATCH net v3 2/2] net: ethernet: bgmac: mac address change bug

From: Hari Vyas <ha...@broadcom.com> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas <ha...@broadcom.com> Signed-off-b

[PATCH net v3 1/2] net: ethernet: bgmac: init sequence bug

it out of reset regardless of whether it was in reset or not). Also, removed unnecessary usleeps (as there is already a read present to flush the IDM writes). Signed-off-by: Zac Schroff <zschr...@broadcom.com> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Fixes: f6a95a24957 (&q

Re: [PATCH 3/3] net: ethernet: bgmac: driver power manangement

On Fri, Feb 3, 2017 at 9:16 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 02/03/2017 01:39 PM, Jon Mason wrote: >> From: Joey Zhong <zho...@broadcom.com> >> >> Implements suspend/resume, external phy 54810 is assumed >> to remain powered up during

Re: [PATCH v2 1/2] net: ethernet: bgmac: init sequence bug

On Fri, Feb 3, 2017 at 4:41 PM, Rafał Miłecki <ra...@milecki.pl> wrote: > On 02/03/2017 10:08 PM, Jon Mason wrote: >> >> @@ -61,15 +60,20 @@ static bool platform_bgmac_clk_enabled(struct bgmac >> *bgmac) >> >> static void platform_bgmac_cl

Re: [PATCH 2/3] net: ethernet: bgmac: unify code of the same family

On Fri, Feb 3, 2017 at 4:48 PM, Rafał Miłecki <ra...@milecki.pl> wrote: > On 2017-02-03 22:39, Jon Mason wrote: >> >> BCM471X and BCM535X are of the same family (from what I can derive from >> internal documents). Group them into the case statement together, which &g

[PATCH net-next 0/3] net: ethernet: bgmac: PM support and clean-ups

Add code to support Power Management (only tested on NS2), and add some code clean-ups Joey Zhong (1): net: ethernet: bgmac: driver power manangement Jon Mason (2): net: ethernet: bgmac: use #defines for MAX size net: ethernet: bgmac: unify code of the same family drivers/net/ethernet

[PATCH 2/3] net: ethernet: bgmac: unify code of the same family

BCM471X and BCM535X are of the same family (from what I can derive from internal documents). Group them into the case statement together, which results in more code reuse. Also, use existing helper variables to make the code a little more readable too. Signed-off-by: Jon Mason <jon

[PATCH 1/3] net: ethernet: bgmac: use #defines for MAX size

The maximum frame size is really just the standard ethernet frame size and FCS. So use those existing defines to make the code a little more beautiful. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac.h | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH 3/3] net: ethernet: bgmac: driver power manangement

From: Joey Zhong <zho...@broadcom.com> Implements suspend/resume, external phy 54810 is assumed to remain powered up during deep-sleep for wake-on-lane. Signed-off-by: Joey Zhong <zho...@broadcom.com> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ether

[PATCH v2 1/2] net: ethernet: bgmac: init sequence bug

From: Zac Schroff <zschr...@broadcom.com> Fix a bug in the 'bgmac' driver init sequence that blind writes for init sequence where it should preserve most bits other than the ones it is deliberately manipulating. Signed-off-by: Zac Schroff <zschr...@broadcom.com> Signed-off-by: Jon M

[PATCH v2 2/2] net: ethernet: bgmac: mac address change bug

From: Hari Vyas <ha...@broadcom.com> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas <ha...@broadcom.com> Signed-off-b

[PATCH v2 0/2] net: ethernet: bgmac: bug fixes

Changes in v2: * Reworked the first match to make it more obvious what portions of the register were being preserved (Per Rafal Mileki) * Style change to reorder the function variables in patch 2 (per Sergei Shtylyov) Bug fixes for bgmac driver Hari Vyas (1): net: ethernet: bgmac: mac

Re: [PATCH v2 3/4] phy: Add USB3 PHY support for Broadcom NSP SoC

; we already have phy-bcm-ns-usb3.c! In fact Jon told me to rewrite my initial > driver to make is possible to reuse it on NSP and I did that! > > This is old comment from Jon: > > In 30 March 2016 at 23:31, Jon Mason <jon.ma...@broadcom.com> wrote: >> On Mon, Mar 28, 201

Re: [PATCH 1/2] net: ethernet: bgmac: init sequence bug

On Thu, Feb 2, 2017 at 3:15 PM, Rafał Miłecki wrote: > On 2017-02-02 01:31, Zac Schroff wrote: >> >> How about BCMA_IOCTL_PRESERVE_ACROSS_INIT? > > > I think wireless drivers may still set some these bits during init. > > I've a simpler idea: make it bgmac specific. Call it sth

Re: [PATCH 1/2] net: ethernet: bgmac: init sequence bug

On Wed, Feb 1, 2017 at 6:06 PM, Rafał Miłecki <ra...@milecki.pl> wrote: > On 02/01/2017 11:39 PM, Jon Mason wrote: >> >> From: Zac Schroff <zschr...@broadcom.com> >> >> Fix a bug in the 'bgmac' driver init sequence that blind writes for init >> sequ

Re: [PATCH 2/2] net: ethernet: bgmac: mac address change bug

On Wed, Feb 1, 2017 at 6:12 PM, Rafał Miłecki <ra...@milecki.pl> wrote: > On 02/01/2017 11:39 PM, Jon Mason wrote: >> >> From: Hari Vyas <ha...@broadcom.com> >> >> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to >> bgmac_set_mac_addr

[PATCH 2/2] net: ethernet: bgmac: mac address change bug

From: Hari Vyas <ha...@broadcom.com> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas <ha...@broadcom.com> Signed-off-b

[PATCH 0/2] net: ethernet: bgmac: bug fixes

Bug fixes for bgmac driver Hari Vyas (1): net: ethernet: bgmac: mac address change bug Zac Schroff (1): net: ethernet: bgmac: init sequence bug drivers/net/ethernet/broadcom/bgmac-platform.c | 10 +++--- drivers/net/ethernet/broadcom/bgmac.c | 6 +-

[PATCH 1/2] net: ethernet: bgmac: init sequence bug

From: Zac Schroff <zschr...@broadcom.com> Fix a bug in the 'bgmac' driver init sequence that blind writes for init sequence where it should preserve most bits other than the ones it is deliberately manipulating. Signed-off-by: Zac Schroff <zschr...@broadcom.com> Signed-off-by: Jon M

Re: [PATCH V2 3/3] net: bgmac: use PHY subsystem for initializing PHY

On Sat, Jan 28, 2017 at 10:08 PM, Florian Fainelli wrote: > > > On 01/28/2017 01:08 PM, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> This adds support for using bgmac with PHYs supported by standalone PHY >> drivers. Having any PHY initialization in

Re: [PATCH v6 7/7] arm64: dts: NS2: add AMAC ethernet support

On Fri, Nov 04, 2016 at 04:31:40PM +0300, Sergei Shtylyov wrote: > Hello. > > On 11/4/2016 8:11 AM, Jon Mason wrote: > > >Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device > >tree > > > >Signed-off-by: Jon Mason <jon.ma...@broad

[PATCH v6 7/7] arm64: dts: NS2: add AMAC ethernet support

Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device tree Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 + arch/arm64/boot/dts/broadcom/ns2.dtsi| 12 2 files changed, 17 insertions(+) diff --git

[PATCH v6 3/7] net: phy: broadcom: Add BCM54810 PHY entry

if it is applicable. Inspired-by: Vikas Soni <vs...@broadcom.com> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Reviewed-by: Andrew Lunn <and...@lunn.ch> --- drivers/net/phy/Kconfig| 2 +- drivers

[PATCH v6 2/7] Documentation: devicetree: add PHY lane swap binding

Add the documentation for PHY lane swapping. This is a boolean entry to notify the phy device drivers that the TX/RX lanes need to be swapped. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Reviewed-by: Andrew Lunn <

[PATCH v6 1/7] net: phy: broadcom: add bcm54xx_auxctl_read

Add a helper function to read the AUXCTL register for the BCM54xx. This mirrors the bcm54xx_auxctl_write function already present in the code. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/phy/bro

[PATCH v6 0/7] add NS2 support to bgmac

ndrew Lunn and Florian Fainelli) * Remove bgmac sleep (per Florian Fainelli) * Re-add bgmac chip reset (per Florian Fainelli and Ray Jui) * Rebased on latest net-next * Added patch for bcm54xx_auxctl_read, which is used in the BCM54810 Jon Mason (7): net: phy: broadcom: add bcm54xx_auxctl_read Doc

[PATCH v6 6/7] net: ethernet: bgmac: add NS2 support

of the pending interrupts on init is required due to observed issues on some platforms. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/ethernet/broadcom/bgmac-platform.c | 56 +- drivers/

[PATCH v6 4/7] Documentation: devicetree: net: add NS2 bindings to amac

Clean-up the documentation to the bgmac-amac driver, per suggestion by Rob Herring, and add details for NS2 support. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> --- Documentation/devicetree/bindings/net/brcm,a

[PATCH v6 5/7] net: ethernet: bgmac: device tree phy enablement

Change the bgmac driver to allow for phy's defined by the device tree Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac-bcma.c | 22 +++ drivers/net/ethernet/broadcom/bgmac-platform.c | 22 ++- drivers/net/et

Re: [PATCH v5 5/7] net: ethernet: bgmac: device tree phy enablement

On Thu, Nov 03, 2016 at 09:31:21AM +0100, Rafal Milecki wrote: > On 11/02/2016 06:08 PM, Jon Mason wrote: > >Change the bgmac driver to allow for phy's defined by the device tree > > This is a late review, I know, sorry... :( > > > >+static int bcma_phy_direct_

Re: [PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings to amac

On Wed, Nov 02, 2016 at 08:18:51PM +0300, Sergei Shtylyov wrote: > Hello. > > On 11/02/2016 08:08 PM, Jon Mason wrote: > > >Clean-up the documentation to the bgmac-amac driver, per suggestion by > >Rob Herring, and add details for NS2 support. > > >

[PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings to amac

Clean-up the documentation to the bgmac-amac driver, per suggestion by Rob Herring, and add details for NS2 support. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- Documentation/devicetree/bindings/net/brcm,amac.txt | 16 +++- 1 file changed, 11 insertions(+), 5 del

[PATCH v5 0/7] add NS2 support to bgmac

hy changes are in addition to the changes necessary to get NS2 working. Jon Mason (7): net: phy: broadcom: add bcm54xx_auxctl_read Documentation: devicetree: add PHY lane swap binding net: phy: broadcom: Add BCM54810 PHY entry Documentation: devicetree: net: add NS2 bindings to amac net

[PATCH v5 5/7] net: ethernet: bgmac: device tree phy enablement

Change the bgmac driver to allow for phy's defined by the device tree Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac-bcma.c | 48 drivers/net/ethernet/broadcom/bgmac-platform.c | 48 +++- drive

[PATCH v5 7/7] arm64: dts: NS2: add AMAC ethernet support

Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device tree Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 + arch/arm64/boot/dts/broadcom/ns2.dtsi| 12 2 files changed, 17 insertions(+) diff --git

[PATCH v5 6/7] net: ethernet: bgmac: add NS2 support

of the pending interrupts on init is required due to observed issues on some platforms. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac-platform.c | 56 +- drivers/net/ethernet/broadcom/bgmac.c | 3 ++ drive

[PATCH v5 2/7] Documentation: devicetree: add PHY lane swap binding

Add the documentation for PHY lane swapping. This is a boolean entry to notify the phy device drivers that the TX/RX lanes need to be swapped. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- Documentation/devicetree/bindings/net/phy.txt | 4 1 file changed, 4 insertions(+)

[PATCH v5 3/7] net: phy: broadcom: Add BCM54810 PHY entry

if it is applicable. Inspired-by: Vikas Soni <vs...@broadcom.com> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/phy/Kconfig| 2 +- drivers/net/phy/broadcom.c | 58 +- include/linux/brcmphy.h| 9 +++ 3 files changed, 67 inse

[PATCH v5 1/7] net: phy: broadcom: add bcm54xx_auxctl_read

Add a helper function to read the AUXCTL register for the BCM54xx. This mirrors the bcm54xx_auxctl_write function already present in the code. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/phy/broadcom.c | 10 ++ include/linux/brcmphy.h| 1 + 2 files chang

Re: [PATCH v4 6/7] net: ethernet: bgmac: add NS2 support

On Tue, Nov 01, 2016 at 05:05:13PM -0400, Jon Mason wrote: > On Tue, Nov 01, 2016 at 01:34:30PM -0700, Scott Branden wrote: > > One change in this patch > > > > On 16-11-01 01:04 PM, Jon Mason wrote: > > >Add support for the variant of amac hardware present in the

Re: [PATCH v4 6/7] net: ethernet: bgmac: add NS2 support

On Tue, Nov 01, 2016 at 01:34:30PM -0700, Scott Branden wrote: > One change in this patch > > On 16-11-01 01:04 PM, Jon Mason wrote: > >Add support for the variant of amac hardware present in the Broadcom > >Northstar2 based SoCs. Northstar2 requires an additional registe

Re: [PATCH v4 2/7] Documentation: devicetree: add PHY lane swap binding

On Tue, Nov 01, 2016 at 09:48:26PM +0100, Andrew Lunn wrote: > > +- enet-phy-lane-swap: If set, indicates the PHY device requires swapping > > the > > + TX/RX lanes to function properly. > > Is 'requires' the right word here? The PHY performs the actual swap of > the Tx/Rx lanes. What I'm

[PATCH v4 1/7] net: phy: broadcom: add bcm54xx_auxctl_read

Add a helper function to read the AUXCTL register for the BCM54xx. This mirrors the bcm54xx_auxctl_write function already present in the code. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/phy/broadcom.c | 10 ++ include/linux/brcmphy.h| 1 + 2 files chang

[PATCH v4 3/7] net: phy: broadcom: Add BCM54810 PHY entry

if it is applicable. Inspired-by: Vikas Soni <vs...@broadcom.com> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/phy/Kconfig| 2 +- drivers/net/phy/broadcom.c | 58 +- include/linux/brcmphy.h| 9 +++ 3 files changed, 67 inse

[PATCH v4 5/7] net: ethernet: bgmac: device tree phy enablement

Change the bgmac driver to allow for phy's defined by the device tree Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac-bcma.c | 48 drivers/net/ethernet/broadcom/bgmac-platform.c | 48 +++- drive

[PATCH v4 6/7] net: ethernet: bgmac: add NS2 support

of the pending interrupts on init is required due to observed issues on some platforms. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac-platform.c | 56 +- drivers/net/ethernet/broadcom/bgmac.c | 3 ++ drive

[PATCH v4 7/7] arm64: dts: NS2: add AMAC ethernet support

Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device tree Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 + arch/arm64/boot/dts/broadcom/ns2.dtsi| 12 2 files changed, 17 insertions(+) diff --git

[PATCH v4 4/7] Documentation: devicetree: net: add NS2 bindings to amac

Clean-up the documentation to the bgmac-amac driver, per suggestion by Rob Herring, and add details for NS2 support. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- Documentation/devicetree/bindings/net/brcm,amac.txt | 16 +++- 1 file changed, 11 insertions(+), 5 del

[PATCH v4 2/7] Documentation: devicetree: add PHY lane swap binding

Add the documentation for PHY lane swapping. This is a boolean entry to notify the phy device drivers that the TX/RX lanes need to be swapped. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- Documentation/devicetree/bindings/net/phy.txt | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH v4 0/7] add NS2 support to bgmac

Northstar2 SoC to the bgmac driver. This necessitates adding support to connect to an externally defined phy (as described in the device tree) in the driver. These phy changes are in addition to the changes necessary to get NS2 working. Jon Mason (7): net: phy: broadcom: add bcm54xx_a

Re: [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry

On Tue, Nov 01, 2016 at 07:46:39PM +0100, Andrew Lunn wrote: > Hi Jon > > > @@ -56,6 +57,8 @@ > > #define PHY_BRCM_EXT_IBND_TX_ENABLE0x2000 > > #define PHY_BRCM_CLEAR_RGMII_MODE 0x4000 > > #define PHY_BRCM_DIS_TXCRXC_NOENRGY0x8000 > > +#define

Re: [PATCH v3 0/6] add NS2 support to bgmac

On Tue, Nov 01, 2016 at 11:01:19AM -0700, Scott Branden wrote: > Hi Jon, > > On 16-11-01 10:51 AM, Jon Mason wrote: > >Changes in v3: > >* Clean-up the bgmac DT binding doc (per Rob Herring) > >* Document the lane swap binding and make it generic (Per Andrew Lunn) &

[PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry

if it is applicable. Inspired-by: Vikas Soni <vs...@broadcom.com> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/phy/Kconfig| 2 +- drivers/net/phy/broadcom.c | 58 +- include/linux/brcmphy.h| 10 3 files changed, 68 inse

[PATCH v3 4/6] net: ethernet: bgmac: device tree phy enablement

Change the bgmac driver to allow for phy's defined by the device tree Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac-bcma.c | 48 drivers/net/ethernet/broadcom/bgmac-platform.c | 48 +++- drive

[PATCH v3 0/6] add NS2 support to bgmac

evice tree) in the driver. These phy changes are in addition to the changes necessary to get NS2 working. Jon Mason (6): net: phy: broadcom: add bcm54xx_auxctl_read net: phy: broadcom: Add BCM54810 PHY entry Documentation: devicetree: net: add NS2 bindings to amac net: ethernet: bgmac: devic

[PATCH v3 5/6] net: ethernet: bgmac: add NS2 support

of the pending interrupts on init is required due to observed issues on some platforms. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac-platform.c | 56 +- drivers/net/ethernet/broadcom/bgmac.c | 3 ++ drive

[PATCH v3 6/6] arm64: dts: NS2: add AMAC ethernet support

Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device tree Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 + arch/arm64/boot/dts/broadcom/ns2.dtsi| 12 2 files changed, 17 insertions(+) diff --git

[PATCH v3 1/6] net: phy: broadcom: add bcm54xx_auxctl_read

Add a helper function to read the AUXCTL register for the BCM54xx. This mirrors the bcm54xx_auxctl_write function already present in the code. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/phy/broadcom.c | 10 ++ include/linux/brcmphy.h| 1 + 2 files chang

[PATCH v3 3/6] Documentation: devicetree: net: add NS2 bindings to amac

Clean-up the documentation to the bgmac-amac driver, per suggestion by Rob Herring, and add details for NS2 support. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- Documentation/devicetree/bindings/net/brcm,amac.txt | 16 +++- 1 file changed, 11 insertions(+), 5 del

Re: [PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry

On Tue, Nov 01, 2016 at 05:26:48PM +0100, Andrew Lunn wrote: > > > > + if (of_property_read_bool(np, "brcm,enet-phy-lane-swap")) { > > > > + /* Lane Swap - Undocumented register...magic! */ > > > > + ret = bcm_phy_write_exp(phydev, MII_BCM54XX_EXP_SEL_ER > > > >

Re: [PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry

On Sat, Oct 29, 2016 at 10:18:39AM +0200, Andrew Lunn wrote: > On Fri, Oct 28, 2016 at 04:56:55PM -0400, Jon Mason wrote: > > The BCM54810 PHY requires some semi-unique configuration, which results > > in some additional configuration in addition to the standard config. >

[PATCH v2 0/6] add NS2 support to bgmac

amac found in the Broadcom Northstar2 SoC to the bgmac driver.  This necessitates adding support to connect to an externally defined phy (as described in the device tree) in the driver. These phy changes are in addition to the changes necessary to get NS2 working. Jon Mason (6): net: phy: bro

[PATCH v2 5/6] net: ethernet: bgmac: add NS2 support

of the pending interrupts on init is required due to observed issues on some platforms. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac-platform.c | 56 +- drivers/net/ethernet/broadcom/bgmac.c | 3 ++ drive

[PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry

if it is applicable. Inspired-by: Vikas Soni <vs...@broadcom.com> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/phy/Kconfig| 2 +- drivers/net/phy/broadcom.c | 58 +- include/linux/brcmphy.h| 10 3 files changed, 68 inse

[PATCH v2 6/6] arm64: dts: NS2: add AMAC ethernet support

Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device tree Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 + arch/arm64/boot/dts/broadcom/ns2.dtsi| 12 2 files changed, 17 insertions(+) diff --git

[PATCH v2 4/6] net: ethernet: bgmac: device tree phy enablement

Change the bgmac driver to allow for phy's defined by the device tree Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac-bcma.c | 48 drivers/net/ethernet/broadcom/bgmac-platform.c | 48 +++- drive

[PATCH v2 3/6] Documentation: devicetree: net: add NS2 bindings to amac

Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- Documentation/devicetree/bindings/net/brcm,amac.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/net/brcm,amac.txt b/Documentation/devicetree/bindings/net/brcm,amac.txt

[PATCH v2 1/6] net: phy: broadcom: add bcm54xx_auxctl_read

Add a helper function to read the AUXCTL register for the BCM54xx. This mirrors the bcm54xx_auxctl_write function already present in the code. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/phy/broadcom.c | 10 ++ include/linux/brcmphy.h| 1 + 2 files chang

Re: [PATCH 1/5] net: phy: broadcom: Add BCM54810 phy entry

On Thu, Oct 27, 2016 at 11:15:05AM +0200, Andrew Lunn wrote: > On Wed, Oct 26, 2016 at 03:35:57PM -0400, Jon Mason wrote: > > From: Vikas Soni <vs...@broadcom.com> > > > > Add BCM54810 phy entry > > Hi Jon, Vikis > > The subject line is a bit misleading.

  1   2   >