Re: [PATCH v2] net: macb: do not scan PHYs manually

2016-05-02 Thread Josh Cartwright
On Mon, May 02, 2016 at 12:08:50PM -0700, Florian Fainelli wrote: > On 02/05/16 11:36, Josh Cartwright wrote: > > On Fri, Apr 29, 2016 at 02:40:53PM +0200, Nicolas Ferre wrote: > > [..] > >>> static int macb_mii_init(struct macb *bp) > >>> { &

Re: [PATCH v2] net: macb: do not scan PHYs manually

2016-05-02 Thread Josh Cartwright
On Fri, Apr 29, 2016 at 02:40:53PM +0200, Nicolas Ferre wrote: [..] > > static int macb_mii_init(struct macb *bp) > > { > > struct macb_platform_data *pdata; > > struct device_node *np; > > - int err = -ENXIO, i; > > + int err = -ENXIO; > > > > /* Enable management port */ > >

Re: [PATCH v2] net: macb: do not scan PHYs manually

2016-04-29 Thread Josh Cartwright
On Thu, Apr 28, 2016 at 07:34:59PM -0500, Josh Cartwright wrote: > On Thu, Apr 28, 2016 at 11:23:15PM +0200, Andrew Lunn wrote: > > On Thu, Apr 28, 2016 at 04:03:57PM -0500, Josh Cartwright wrote: > > > On Thu, Apr 28, 2016 at 08:59:32PM +0200, Andrew Lunn wrote: > > > &

Re: [PATCH v2] net: macb: do not scan PHYs manually

2016-04-28 Thread Josh Cartwright
On Thu, Apr 28, 2016 at 11:23:15PM +0200, Andrew Lunn wrote: > On Thu, Apr 28, 2016 at 04:03:57PM -0500, Josh Cartwright wrote: > > On Thu, Apr 28, 2016 at 08:59:32PM +0200, Andrew Lunn wrote: > > > On Thu, Apr 28, 2016 at 01:55:27PM -0500, Nathan Sullivan wrote: > > > &

Re: [PATCH v2] net: macb: do not scan PHYs manually

2016-04-28 Thread Josh Cartwright
On Thu, Apr 28, 2016 at 08:59:32PM +0200, Andrew Lunn wrote: > On Thu, Apr 28, 2016 at 01:55:27PM -0500, Nathan Sullivan wrote: > > On Thu, Apr 28, 2016 at 08:43:03PM +0200, Andrew Lunn wrote: > > > > I agree that is a valid fix for AT91, however it won't solve our > > > > problem, since > > > >

Re: [PATCH] net: macb: do not scan PHYs manually

2016-04-28 Thread Josh Cartwright
On Thu, Apr 28, 2016 at 09:19:47AM -0500, Nathan Sullivan wrote: > Since of_mdiobus_register and mdiobus_register will scan automatically, This is only partially true. of_mdiobus_register() only scans for PHYs with device tree presence (starting with nodes which specify an address, then

Re: [PATCH net 1/2] net: cadence: macb: Disable USRIO register on some platforms

2015-12-07 Thread Josh Cartwright
On Mon, Dec 07, 2015 at 11:58:33AM +0100, Neil Armstrong wrote: > On some platforms, the macb integration does not use the USRIO > register to configure the (R)MII port and clocks. > When the register is not implemented and the MACB error signal > is connected to the bus error, reading or writing

Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

2015-07-10 Thread Josh Cartwright
On Fri, Jul 10, 2015 at 07:06:23PM -0400, Chris Metcalf wrote: On 7/10/2015 6:45 PM, Josh Cartwright wrote: +static inline const struct cpumask *housekeeping_cpumask(void) +{ +#ifdef CONFIG_NO_HZ_FULL + if (tick_nohz_full_enabled()) + return housekeeping_mask; +#endif Just

Re: [PATCH v2 1/1] Added additional callback to ptp_clock_info:

2015-07-08 Thread Josh Cartwright
On Wed, Jul 08, 2015 at 01:54:34PM +0200, Richard Cochran wrote: On Mon, Jul 06, 2015 at 03:44:58PM -0500, Josh Cartwright wrote: It's difficult to make too many judgements without seeing how a driver might implement this; is there another patchset that shows how a driver implements

Re: [PATCH v2 1/1] Added additional callback to ptp_clock_info:

2015-07-06 Thread Josh Cartwright
On Thu, Jul 02, 2015 at 06:14:48PM -0700, Christopher Hall wrote: * getsynctime64() Hello Christopher- A couple comments below. This takes 2 arguments referring to system and device time With this callback drivers may provide both system time and device time to ensure precise