[PATCH v2 0/3] macb rx filter cleanups

Here's a proper patchset based on net-next. v1 -> v2: - Rebased on net-next - Add Nicolas's Acks - Reorder commits, putting the list_empty() cleanups prior to the others. - Added commit reverting the GFP_ATOMIC change. Julia Cartwright (3): net: macb: kill useless use of list_em

[PATCH v2 2/3] net: macb: reduce scope of rx_fs_lock-protected regions

et: macb: Added support for RX filtering") Cc: Rafal Ozieblo <raf...@cadence.com> Cc: Julia Lawall <julia.law...@lip6.fr> Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com> Signed-off-by: Julia Cartwright <ju...@ni.com> --- drivers/net/ethernet/cadence/macb_main

[PATCH v2 1/3] net: macb: kill useless use of list_empty()

The list_for_each_entry() macro already handles the case where the list is empty (by not executing the loop body). It's not necessary to handle this case specially, so stop doing so. Cc: Rafal Ozieblo <raf...@cadence.com> Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com> Signed-o

[PATCH v2 3/3] net: macb: change GFP_ATOMIC to GFP_KERNEL

Now that the rx_fs_lock is no longer held across allocation, it's safe to use GFP_KERNEL for allocating new entries. This reverts commit 81da3bf6e3f88 ("net: macb: change GFP_KERNEL to GFP_ATOMIC"). Cc: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Julia Cartwrig

[PATCH 1/2] net: macb: reduce scope of rx_fs_lock-protected regions

et: macb: Added support for RX filtering") Cc: Rafal Ozieblo <raf...@cadence.com> Cc: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Julia Cartwright <ju...@ni.com> --- While Julia Lawall's cocci-generated patch fixes the problem, the right solution is to obviate the pro

Re: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

On Sat, Oct 15, 2016 at 12:06:33AM +0200, Richard Cochran wrote: > On Fri, Oct 14, 2016 at 08:58:22AM +, Koehrer Mathias (ETAS/ESW5) wrote: > > @@ -753,7 +756,9 @@ u32 igb_rd32(struct e1000_hw *hw, u32 re > > if (E1000_REMOVED(hw_addr)) > > return ~value; > > > > +

Re: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

+linux-pci On Mon, Oct 17, 2016 at 08:39:40AM -0700, Alexander Duyck wrote: > On Mon, Oct 17, 2016 at 8:00 AM, Koehrer Mathias (ETAS/ESW5) > wrote: > > Hi Julia! > >> > > Have you tested on a vanilla (non-RT) kernel? I doubt there is > >> > > anything RT specific about

Re: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

On Fri, Oct 14, 2016 at 08:58:22AM +, Koehrer Mathias (ETAS/ESW5) wrote: > Hi Julia, > > > Have you tested on a vanilla (non-RT) kernel? I doubt there is anything RT > > specific > > about what you are seeing, but it might be nice to get confirmation. Also, > > bisection > > would probably

Re: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

Hey Mathias- On Thu, Oct 13, 2016 at 10:57:18AM +, Koehrer Mathias (ETAS/ESW5) wrote: [..] Interesting indeed! > > Here are some places where I added traces: > > In file igb_ptp.c: > > void igb_ptp_rx_hang(struct igb_adapter *adapter) { > > struct e1000_hw *hw = >hw; > >

Re: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

Hello Mathias- On Fri, Oct 07, 2016 at 08:58:08AM +, Koehrer Mathias (ETAS/ESW5) wrote: [..] > I modified the in-kernel's igb_main.c (function igb_watchdog_task) to comment > out > the access to the EICS registers: > > --- igb_main.c.orig 2016-10-07 10:43:37.855873754 +0200 > +++

Re: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

On Wed, Oct 05, 2016 at 07:02:21AM +, Koehrer Mathias (ETAS/ESW5) wrote: > Hi Julia, > > > > In the meanwhile I have detected another finding which might be relevant: > > > > > > With the 3.18 kernel the igb driver comes with two interrupts per > > > NIC (e.g. eth2 and eth2-TxRx0) with the