Re: [PATCH net-next,v4 01/12] flow_offload: add flow_rule and flow_match structures and use them (fwd)

Hello, It looks like the kfree on line 1573 should be moved down a few lines. julia -- Forwarded message -- Date: Sat, 1 Dec 2018 11:11:55 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH net-next, v4 01/12] flow_offload: add flow_rule

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

On Mon, 27 Aug 2018, Al Viro wrote: > On Sun, Aug 26, 2018 at 11:35:17PM -0400, Julia Lawall wrote: > > > * x = \(kmalloc\|kzalloc\|devm_kmalloc\|devm_kzalloc\)(...) > > I can name several you've missed right off the top of my head - > vmalloc, kvmalloc, kmem_cache_all

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

On Mon, 27 Aug 2018, Al Viro wrote: > On Sun, Aug 26, 2018 at 10:00:46PM -0400, Julia Lawall wrote: > > > > > > On Sun, 26 Aug 2018, Al Viro wrote: > > > > > On Sun, Aug 26, 2018 at 03:26:54PM -0700, Joe Perches wrote: > > > > On Sun, 2018-08-26

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

On Sun, 26 Aug 2018, Al Viro wrote: > On Sun, Aug 26, 2018 at 03:26:54PM -0700, Joe Perches wrote: > > On Sun, 2018-08-26 at 22:24 +0100, Al Viro wrote: > > > On Sun, Aug 26, 2018 at 11:57:57AM -0700, Joe Perches wrote: > > > > > > > > That, BTW, is why I hate the use of sizeof(*p) in kmalloc,

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

On Sun, 26 Aug 2018, Joe Perches wrote: > On Sun, 2018-08-26 at 22:24 +0100, Al Viro wrote: > > On Sun, Aug 26, 2018 at 11:57:57AM -0700, Joe Perches wrote: > > > > > > That, BTW, is why I hate the use of sizeof(*p) in kmalloc, etc. > > > > arguments. typeof is even worse in that respect. > >

[PATCH] mwifiex: delete unneeded include

Nothing that is defined in 11ac.h is referenced in cmdevt.c. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/net/wireless/marvell/mwifiex/cmdevt.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/m

Re: [PATCH V2] net/netlink: optimize seq_puts and seq_printf in af_netlink.c

On Thu, 3 May 2018, YU Bo wrote: > Before the patch, the command `cat /proc/net/netlink` will output like: > > https://clbin.com/BojZv > > After the patch: > > https://clbin.com/lnu4L > > The optimization will make convenience for using `cat /proc/net/netlink` > But,The checkpatch will give a

Re: [PATCH net-next 2/2] openvswitch: Support conntrack zone limit (fwd)

Line 1814 frees something that is dereferenced on the next line. julia -- Forwarded message -- Date: Tue, 17 Apr 2018 10:32:17 +0800 From: kbuild test robot <l...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH net-next 2/2]

Re: [PATCH 08/12] mmc: reduce use of block bounce buffers (fwd)

There is a duplicated test on line 360. julia -- Forwarded message -- Date: Mon, 16 Apr 2018 23:04:18 +0800 From: kbuild test robot <l...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH 08/12] mmc: reduce use of block bounce

Re: [PATCH v11 crypto 01/12] tls: support for Inline tls record (fwd)

ctx is dereferenced on line 258 but has been freed on line 229. julia -- Forwarded message -- Date: Sun, 18 Mar 2018 18:05:25 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v11

Re: [PATCH v11 crypto 12/12] crypto: chtls - Makefile Kconfig (fwd)

Please check the indentation on line 1655. thanks, julia -- Forwarded message -- Date: Sun, 18 Mar 2018 18:15:36 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v11 crypto 12/12] c

Re: [Outreachy kernel] Re: [PATCH v2] net: ethernet: Drop unnecessary continue

On Wed, 7 Mar 2018, Arushi Singhal wrote: > > > On Wed, Mar 7, 2018 at 9:09 PM, David Miller wrote: > From: Arushi Singhal > Date: Sat, 3 Mar 2018 21:44:56 +0530 > > > Continue at the bottom of a loop are removed. >

Re: [Outreachy kernel] [PATCH v3] staging: ipx: Replace printk() with appropriate net_*macro_ratelimited()

On Mon, 5 Mar 2018, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. > It's better to use actual device name as a prefix in error messages. > > Signed-off-by: Arushi Singhal > --- > changes in v2 > *In v1

Re: [Outreachy kernel] [PATCH v2] staging: Replace printk() with appropriate net_*macro_ratelimited()

On Mon, 5 Mar 2018, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. Why did you choose this function? > It's better to use actual device name as a prefix in error messages. What does this message relate to. > Indentation is also

Re: [Outreachy kernel] [PATCH] net: ethernet: Drop unnecessary continue

On Sat, 3 Mar 2018, Arushi Singhal wrote: > Continue at the bottom of a loop are removed. > Issue found using drop_continue.cocci Coccinelle script. In each case you leave an if with a single statement in the branch. In that case the { } should be dropped too. julia > > Signed-off-by:

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

On Tue, 6 Feb 2018, Dan Carpenter wrote: > That found 4 that I think Wolfram's grep missed. > > arch/um/drivers/vector_user.h |2 -- > drivers/gpu/drm/mxsfb/mxsfb_regs.h|2 -- > drivers/video/fbdev/mxsfb.c |2 -- > include/drm/drm_scdc_helper.h

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

On Tue, 6 Feb 2018, Wolfram Sang wrote: > Hi Julia, > > > and got the results below. I can make a version for the kernel shortly. > > It should probably take care of right-shifting, too? I did that too but got no results. Perhaps right shifting constants is pretty uncommon. I can put that

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

On Tue, 6 Feb 2018, Dan Carpenter wrote: > On Tue, Feb 06, 2018 at 02:15:51PM +0100, Julia Lawall wrote: > > > > > > On Tue, 6 Feb 2018, Dan Carpenter wrote: > > > > > On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote: > > > > In

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

On Tue, 6 Feb 2018, Dan Carpenter wrote: > On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote: > > In one Renesas driver, I found a typo which turned an intended bit shift > > ('<<') > > into a comparison ('<'). Because this is a subtle issue, I looked tree wide > > for > > similar

[PATCH] netfilter: nf_tables: fix odd_ptr_err.cocci warnings

tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: b4464bcab38d3f7fe995a7cb960eeac6889bec08 commit: 3b49e2e94e6ebb8b23d0955d9e898254455734f8 [8286/9035] netfilter: nf_tables: add flow table netlink frontend The following is a 0-day report generated by

Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

On Wed, 3 Jan 2018, Tariq Toukan wrote: > > > On 01/01/2018 10:46 PM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Mon, 1 Jan 2018 21:42:27 +0100 > > > > Omit an extra message for a memory allocation failure in these functions. > > > > This issue

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2 Jan 2018, Bart Van Assche wrote: > On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote: > > On Tue, 2 Jan 2018, Bob Peterson wrote: > > > - Original Message - > > > > - Original Message - > > > > > > > Still, the G

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2 Jan 2018, Bob Peterson wrote: > - Original Message - > | - Original Message - > | | Drop newline at the end of a message string when the printing function > adds > | | a newline. > | > | Hi Julia, > | > | NACK. > | > | As much as it's a pain when searching the source

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2 Jan 2018, Bob Peterson wrote: > - Original Message - > | Drop newline at the end of a message string when the printing function adds > | a newline. > > Hi Julia, > > NACK. > > As much as it's a pain when searching the source code for output strings, > this patch set goes

[PATCH 03/12] net: dccp: drop unneeded newline

DCCP_CRIT prints some other text and then a newline after the message string, so the message string does not need to include a newline explicitly. Done using Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- net/dccp/ackvec.c |2 +- 1 file changed, 1 insertion

[PATCH 05/12] openvswitch: drop unneeded newline

OVS_NLERR prints a newline at the end of the message string, so the message string does not need to include a newline explicitly. Done using Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- net/openvswitch/conntrack.c |4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH 00/12] drop unneeded newline

Drop newline at the end of a message string when the printing function adds a newline. The complete semantic patch that detects this issue is as shown below (http://coccinelle.lip6.fr/). It works in two phases - the first phase counts how many uses of a function involve a newline and how many

Pravin Shelar

The email address pshe...@nicira.com listed for Pravin Shelar in MAINTAINERS (OPENVSWITCH section) seems to bounce. julia

Re: [PATCH v4 net-next 6/6] ila: Route notify (fwd)

Hello, Another tab appears to be needed on line 358. julia -- Forwarded message -- Date: Sun, 17 Dec 2017 05:42:17 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v4 net-next 6/6

Re: [PATCH v2 3/3] net: macb: change GFP_ATOMIC to GFP_KERNEL

On Tue, 5 Dec 2017, Julia Cartwright wrote: > Now that the rx_fs_lock is no longer held across allocation, it's safe > to use GFP_KERNEL for allocating new entries. > > This reverts commit 81da3bf6e3f88 ("net: macb: change GFP_KERNEL to > GFP_ATOMIC"). > > Cc: Jul

[PATCH v2] net: macb: change GFP_KERNEL to GFP_ATOMIC

Function gem_add_flow_filter called on line 2958 inside lock on line 2949 but uses GFP_KERNEL Generated by: scripts/coccinelle/locks/call_kern.cocci Fixes: ae8223de3df5 ("net: macb: Added support for RX filtering") CC: Rafal Ozieblo <raf...@cadence.com> Signed-off-by: Julia L

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

On Thu, 23 Nov 2017, Greg Kroah-Hartman wrote: > On Wed, Nov 22, 2017 at 10:20:49PM +0100, Julia Lawall wrote: > > > > > > On Wed, 22 Nov 2017, Joe Perches wrote: > > > > > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > > > There

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

On Wed, 22 Nov 2017, Joe Perches wrote: > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that check that the module license

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

On Wed, 22 Nov 2017, Joe Perches wrote: > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that check that the module license

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

On Thu, 19 Oct 2017, Laurent Pinchart wrote: > Hi Christoph, > > On Thursday, 19 October 2017 17:06:57 EEST Christoph Hellwig wrote: > > > Now we have 9 const instances of the config_item_type structure that are > > > identical, with only the .ct_owner field set. Should they be all merged > > >

Re: [PATCH v2 00/15] make structure field, function arguments and structures const

On Tue, 17 Oct 2017, Greg KH wrote: > On Mon, Oct 16, 2017 at 05:18:39PM +0200, Bhumika Goyal wrote: > > Make the ci_type field and some function arguments as const. After this > > change, make config_item_type structures as const. > > > > * Changes in v2- Combine all the followup patches and

Re: [PATCH] net: phy: DP83822 initial driver submission (fwd)

DP83822_WOL_CLR_INDICATION appears twice on line 136. Perhaps this is not what is wanted. julia -- Forwarded message -- Date: Thu, 5 Oct 2017 21:38:28 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr>

Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

On Fri, 22 Sep 2017, Joe Perches wrote: > On Fri, 2017-09-22 at 12:06 +0200, Julia Lawall wrote: > > > > On Fri, 22 Sep 2017, Colin Ian King wrote: > > > > > On 22/09/17 11:03, Joe Perches wrote: > > > > On Fri, 2017-09-22 at 09:23 +0200, Julia Lawall

Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

On Fri, 22 Sep 2017, Colin Ian King wrote: > On 22/09/17 11:03, Joe Perches wrote: > > On Fri, 2017-09-22 at 09:23 +0200, Julia Lawall wrote: > >> > >> On Thu, 21 Sep 2017, Colin King wrote: > >> > >>> From: Colin Ian King <colin.k...@ca

Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

On Thu, 21 Sep 2017, Colin King wrote: > From: Colin Ian King > > Don't populate const array ac_to_fifo on the stack in an inlined > function, instead make it static. Makes the object code smaller > by over 800 bytes: > >text data bss dec hex

Re: [Outreachy kernel] [PATCH] Staging: irda: Use !x instead of NULL comparison

kmalloc_array\|devm_ioremap\| > usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...)); > > ( > if(!E) >S > | > -if(E==NULL) > +if(!E) > S > ) > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr>

Re: [Outreachy kernel] Re: [PATCH 2/2] Staging: irda: Remove parentheses on the right of assignment

On Fri, 15 Sep 2017, Joe Perches wrote: > On Sat, 2017-09-16 at 02:36 +0530, Srishti Sharma wrote: > > Parentheses are not needed on the right hand side of assignment > > statement in most cases. Done using the following semantic > > patch by coccinelle. > [] > > @@ > > identifier E,F,G,f; > >

Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use assignment inside if statement

On Sat, 16 Sep 2017, Srishti Sharma wrote: > On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > > > >> Write assignment statement outside the if statement. Do

Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use assignment inside if statement

; S > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > Changes in v2: > -Semicolon was missing in one of the statements of the > semantic patch > > drivers/staging/irda/drivers/irda-usb.c | 4 ++--

Re: [Outreachy kernel] [PATCH] Staging: irda: Don't use assignment inside if statement

On Sat, 16 Sep 2017, Srishti Sharma wrote: > Write assignment statement outside the if statement. Done using > the following semantic patch by coccinelle. > > @@ > identifier E; > expression F; > statement S; > @@ > > -if((E = F)) > +E = F The line above would need to end in a ; This ends up

Re: [Outreachy kernel] [PATCH] staging: irda: Remove typedef struct

edef > struct > + T2 > { ... } > -T > ; > > @r3@ > type r1.T; > identifier c1.T2; > @@ > -T > +struct T2 > > Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/ird

Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile (fwd)

It is intentional that the code on lines 122 and 124 is the same? julia -- Forwarded message -- Date: Thu, 17 Aug 2017 09:18:50 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH]

Re: [PATCH net-next 2/3] Add LAN743X to Kconfig and Makefile (fwd)

I don't think netdev_priv can return NULL, so lines 6641 to 6646 could just be dropped. julia -- Forwarded message -- Date: Mon, 14 Aug 2017 18:14:12 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr>

[PATCH] X25: constify null_x25_address

null_x25_address is only used to access the string it contains, so it can be const. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- net/x25/af_x25.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c index 5a1a98d..ac09593

[PATCH 1/2] Revert "ipv6: constify inet6_protocol structures"

This reverts commit 3a3a4e3054137c5ff5d4d306ec834f6d25d7f95b. inet6_add_protocol and inet6_del_protocol include casts that remove the effect of the const annotation on their parameter, leading to possible runtime crashes. Reported-by: Eric Dumazet <eric.duma...@gmail.com> Signed-off-by:

[PATCH 2/2] Revert "l2tp: constify inet6_protocol structures"

This reverts commit d04916a48ad4a3db892b664fa9c3a2a693c378ad. inet6_add_protocol and inet6_del_protocol include casts that remove the effect of the const annotation on their parameter, leading to possible runtime crashes. Reported-by: Eric Dumazet <eric.duma...@gmail.com> Signed-off-by:

[PATCH 0/2] Revert "ipv6: constify inet6_protocol structures"

inet6_add_protocol and inet6_del_protocol include casts that remove the effect of the const annotation on their parameter, leading to possible runtime crashes.

Re: [PATCH 1/2] ipv6: constify inet6_protocol structures

On Tue, 1 Aug 2017, David Ahern wrote: > On 7/31/17 11:59 PM, Julia Lawall wrote: > >> This change breaks the kernel if one of these sysctls are changed: > >> tcp_early_demux, udp_early_demux > > > > The other patch in the series has the same problem and should

[PATCH 1/1 v3 nf-next] netfilter: constify nf_conntrack_l3/4proto parameters

making some nf_conntrack_l3/4proto structures const subsequently. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- v3: Rebased against nf-next. Some functions, such as nf_ct_l3proto_pernet_register, are no longer defined, so they are no longer u

[PATCH 0/1 v3 nf-next] constify nf_conntrack_l3/4proto parameters

When a nf_conntrack_l3/4proto parameter is not on the left hand side of an assignment, its address is not taken, and it is not passed to a function that may modify its fields, then it can be declared as const. This change is useful from a documentation point of view, and can possibly facilitate

Re: [PATCH 1/2] ipv6: constify inet6_protocol structures

On Mon, 31 Jul 2017, Eric Dumazet wrote: > On Fri, 2017-07-28 at 22:18 +0200, Julia Lawall wrote: > > The inet6_protocol structure is only passed as the first argument to > > inet6_add_protocol or inet6_del_protocol, both of which are declared as > > const. Thus the ine

Re: [PATCH 1/2] ipv6: constify inet6_protocol structures

On Mon, 31 Jul 2017, Eric Dumazet wrote: > On Fri, 2017-07-28 at 22:18 +0200, Julia Lawall wrote: > > The inet6_protocol structure is only passed as the first argument to > > inet6_add_protocol or inet6_del_protocol, both of which are declared as > > const. Thus the ine

[PATCH 1/1 v2] netfilter: constify nf_conntrack_l3/4proto parameters

making some nf_conntrack_l3/4proto structures const subsequently. Done with the help of Coccinelle. Some spacing adjusted to fit within 80 characters. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- v2: Added consideration of array parameters. This adds transfor

[PATCH 0/1 v2] constify nf_conntrack_l3/4proto parameters

When a nf_conntrack_l3/4proto parameter is not on the left hand side of an assignment, its address is not taken, and it is not passed to a function that may modify its fields, then it can be declared as const. This change is useful from a documentation point of view, and can possibly facilitate

Re: [PATCH 1/1] netfilter: constify nf_conntrack_l3/4proto parameters

On Sat, 29 Jul 2017, Florian Westphal wrote: > Julia Lawall <julia.law...@lip6.fr> wrote: > > When a nf_conntrack_l3/4proto parameter is not on the left hand side > > of an assignment, its address is not taken, and it is not passed to a > > function that may mod

[PATCH 0/1] constify nf_conntrack_l3/4proto parameters

When a nf_conntrack_l3/4proto parameter is not on the left hand side of an assignment, its address is not taken, and it is not passed to a function that may modify its fields, then it can be declared as const. This change is useful from a documentation point of view, and can possibly facilitate

[PATCH 1/1] netfilter: constify nf_conntrack_l3/4proto parameters

making some nf_conntrack_l3/4proto structures const subsequently. Done with the help of Coccinelle. Some spacing adjusted to fit within 80 characters. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- include/net/netfilter/nf_conntrack_l3proto.h |6 +++--- include/net/net

[PATCH] net-next: stmmac: dwmac-sun8i: fix of_table.cocci warnings

Make sure (of/i2c/platform)_device_id tables are NULL terminated Generated by: scripts/coccinelle/misc/of_table.cocci Fixes: d5dbe1976d52 ("net-next: stmmac: dwmac-sun8i: choose internal PHY via compatible") CC: Corentin Labbe Signed-off-by: Fengguang Wu

Re: [PATCH 0/2] constify nf_hook_ops structures

On Sat, 29 Jul 2017, Florian Westphal wrote: > Julia Lawall <julia.law...@lip6.fr> wrote: > > On Sat, 29 Jul 2017, Florian Westphal wrote: > > > From a quick glance I don't see why we can't e.g. constify > > > nf_conntrack_l3/4_proto too. It is not going to b

Re: [PATCH 0/2] constify nf_hook_ops structures

On Sat, 29 Jul 2017, Florian Westphal wrote: > Julia Lawall <julia.law...@lip6.fr> wrote: > > > > > > On Sat, 29 Jul 2017, Florian Westphal wrote: > > > > > Julia Lawall <julia.law...@lip6.fr> wrote: > > > > The

Re: [PATCH 0/2] constify nf_hook_ops structures

On Sat, 29 Jul 2017, Florian Westphal wrote: > Julia Lawall <julia.law...@lip6.fr> wrote: > > The nf_hook_ops structure is only passed as the second argument to > > nf_register_net_hook or nf_unregister_net_hook, both of which are > > declared as const. Thus the n

[PATCH 2/2] netfilter: ipt_CLUSTERIP: constify nf_hook_ops structures

; @@ static +const struct nf_hook_ops i = { ... }; // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- net/ipv4/netfilter/ipt_CLUSTERIP.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/netfilter/ipt_CLUSTERIP.c b/net/ipv4/netfilter/ipt_CLUSTERIP.c

[PATCH 1/2] decnet: dn_rtmsg: constify nf_hook_ops structures

; @@ static +const struct nf_hook_ops i = { ... }; // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- net/decnet/netfilter/dn_rtmsg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/decnet/netfilter/dn_rtmsg.c b/net/decnet/netfilter/dn_rtmsg.c index a

[PATCH 0/2] constify nf_hook_ops structures

The nf_hook_ops structure is only passed as the second argument to nf_register_net_hook or nf_unregister_net_hook, both of which are declared as const. Thus the nf_hook_ops structure itself can be const. Done with the help of Coccinelle. --- net/decnet/netfilter/dn_rtmsg.c|2 +-

[PATCH 1/2] ipv4: constify net_protocol structures

= { ... }; // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- net/ipv4/af_inet.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index 5ce44fb..2e38624 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -1594,7 +1594,7

[PATCH 0/2] constify net_protocol structures

The net_protocol structure is only passed as the first argument to inet_add_protocol or inet_del_protocol, both of which are declared as const. Thus the net_protocol structure itself can be const. Done with the help of Coccinelle. --- net/ipv4/af_inet.c |4 ++-- net/l2tp/l2tp_ip.c |2

[PATCH 2/2] l2tp: constify net_protocol structures

+const struct net_protocol i = { ... }; // Also drop __read_mostly. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- net/l2tp/l2tp_ip.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/l2tp/l2tp_ip.c b/net/l2tp/l2tp_ip.c index 4d322c1..c8e4d85 100644 ---

[PATCH 0/2] constify inet6_protocol structures

The inet6_protocol structure is only passed as the first argument to inet6_add_protocol or inet6_del_protocol, both of which are declared as const. Thus the inet6_protocol structure itself can be const. Done with the help of Coccinelle. // @r disable optional_qualifier@ identifier i; position

[PATCH 1/2] ipv6: constify inet6_protocol structures

of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- net/ipv6/ip6_gre.c |2 +- net/ipv6/tcp_ipv6.c |2 +- net/ipv6/udp.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index 67ff2aa..33865d6

[PATCH 2/2] l2tp: constify inet6_protocol structures

. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- net/l2tp/l2tp_ip6.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/l2tp/l2tp_ip6.c b/net/l2tp/l2tp_ip6.c index 88b397c..d2efcd9 100644 --- a/net/l2tp/l2tp_ip6.c +++ b/net/l2tp/l2tp_ip6.c @@ -788,7 +788,7 @@ stat

Re: [RFC] tls: length check correct in do_tls_getsockopt_tx()?

On Wed, 5 Jul 2017, Dan Carpenter wrote: > On Wed, Jul 05, 2017 at 03:10:53AM -0400, Matthias Rosenfelder wrote: > > Hi, > > > > In do_tls_getsockopt_tx(): > > > > if (len == sizeof(crypto_info)) { > > > > should be > > > > if (len == sizeof(*crypto_info)) { > > > > as crypto_info is of pointer

Re: [PATCH net-next] cxgb4: Add PTP Hardware Clock (PHC) support (fwd)

The complete context isn't shown, but it seems likely that there is a goto out_free under line 1207, with no unlock on >ptp_lock. julia -- Forwarded message -- Date: Fri, 30 Jun 2017 11:54:23 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org

Re: [PATCH net 3/3] netvsc: fix RCU warning from set_multicast (fwd)

Please check the indentation of lines 73 onward. thanks, julia -- Forwarded message -- Date: Tue, 6 Jun 2017 14:40:59 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH net 3/3] net

Re: [PATCH][V2] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value

On Mon, 5 Jun 2017, Colin King wrote: > From: Colin Ian King > > The current comparison of entry < 0 will never be true since entry is an > unsigned integer. Make entry an int to ensure -ve error return values > from the call to jumbo_frm are correctly being caught.

Re: [PATCH] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value

On Sat, 3 Jun 2017, Colin Ian King wrote: > On 03/06/17 16:55, Andy Shevchenko wrote: > > On Fri, Jun 2, 2017 at 5:58 PM, Colin King wrote: > >> The current comparison of entry < 0 will never be true since entry is an > >> unsigned integer. Cast entry to an int to

[PATCH] dsa: mv88e6xxx: fix returnvar.cocci warnings

Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Andrew Lunn <and...@lunn.ch> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> --- It's a minor issue, but since

Re: [PATCH v3 1/2] net: phy: Add Cortina CS4340 driver (fwd)

The u32 values on lines 73 and 79 will not be less than 0. julia -- Forwarded message -- Date: Fri, 26 May 2017 19:31:28 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v3 1/2] n

[net:master 9/12] net/ipv6/ip6_offload.c:120:7-21: WARNING: Unsigned expression compared with zero: unfrag_ip6hlen < 0 (fwd)

o: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: [net:master 9/12] net/ipv6/ip6_offload.c:120:7-21: WARNING: Unsigned expression compared with zero: unfrag_ip6hlen < 0 CC: kbuild-...@01.org CC: netdev@vger.kernel.org TO: Craig Gallek <kr...@google.com> tree: h

Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

On Fri, 12 May 2017, Florian Fainelli wrote: > On 05/12/2017 09:22 AM, David Miller wrote: > > From: Julia Lawall <julia.law...@lip6.fr> > > Date: Fri, 12 May 2017 22:54:23 +0800 (SGT) > > > >> Device node iterators put the previous value of the index vari

[PATCH] mdio: mux: fix device_node_continue.cocci warnings

/iterators/device_node_continue.cocci CC: Jon Mason <jon.ma...@broadcom.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-ne

Re: [PATCH] net: dsa: loop: Free resources if initialization is deferred

On Wed, 10 May 2017, Christophe JAILLET wrote: > Free some devm'allocated memory in case of deferred driver initialization. > This avoid to waste some memory in such a case. I really think it would be helpful to mention the special behavior of -EPROBE_DEFER. It doesn't take much space, and it

Re: [PATCH] net: dsa: loop: Check for memory allocation failure

On Mon, 8 May 2017, Florian Fainelli wrote: > On 05/08/2017 04:46 PM, Julia Lawall wrote: > > > > > > On Mon, 8 May 2017, Joe Perches wrote: > > > >> On Mon, 2017-05-08 at 20:32 +0800, Julia Lawall wrote: > >>> > >>> On Mon, 8 May 201

Re: [PATCH] net: dsa: loop: Check for memory allocation failure

On Mon, 8 May 2017, Joe Perches wrote: > On Mon, 2017-05-08 at 20:32 +0800, Julia Lawall wrote: > > > > On Mon, 8 May 2017, David Laight wrote: > > > > > From: Christophe JAILLET > > > > Sent: 06 May 2017 06:30 > > > > If 'devm_kzalloc' fail

RE: [PATCH] net: dsa: loop: Check for memory allocation failure

On Mon, 8 May 2017, David Laight wrote: > From: Christophe JAILLET > > Sent: 06 May 2017 06:30 > > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced. > > Return -ENOMEM instead, as done for some other memory allocation just a > > few lines above. > ... > > ---

Re: [PATCH 04/22] target: Make use of the new sg_map function at 16 call sites (fwd)

It looks like >cmdr_lock should be released at line 512 if it has not been released otherwise. The lock was taken at line 438. julia -- Forwarded message -- Date: Fri, 14 Apr 2017 22:21:44 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Jul

Re: [PATCH 2/4 v2 net-next] net: stmmac: adding multiple buffers for RX (fwd)

It looks like an infinite loop, if queue is unsigned. julia -- Forwarded message -- Date: Thu, 6 Apr 2017 11:49:01 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH 2/4 v2 net-next]

Re: [PATCH net-next v6 01/11] bpf: Add eBPF program subtype and is_valid_subtype() verifier (fwd)

Size is unsigned, so not negative. julia -- Forwarded message -- Date: Wed, 29 Mar 2017 23:06:01 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH net-next v6 01/11] bpf: Add eBPF pro

Re: [Outreachy kernel] [PATCH] net: netfilter: remove unused variable

On Wed, 29 Mar 2017, Arushi Singhal wrote: > This patch uses the following coccinelle script to remove > a variable that was simply used to store the return > value of a function call before returning it: > > @@ > identifier len,f; > @@ > > -int len; > ... when != len > when strict > -len

Re: [Outreachy kernel] [PATCH] net: Remove unnecessary cast on void pointer

On Tue, 28 Mar 2017, simran singhal wrote: > The following Coccinelle script was used to detect this: > @r@ > expression x; > void* e; > type T; > identifier f; > @@ > ( > *((T *)e) > | > ((T *)x)[...] > | > ((T*)x)->f > | > > - (T*) > e > ) > > Signed-off-by: simran singhal

Re: [PATCH net-next 1/8] net: stmicro: multiple queues dt configuration (fwd)

This is just pointing out that lines 200 and 202 are identical. julia -- Forwarded message -- Date: Fri, 10 Mar 2017 04:50:01 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH net-n

Re: [patch] net/mlx4: && vs & typo

On Tue, 28 Feb 2017, Bart Van Assche wrote: > On 02/28/2017 02:23 PM, Joe Perches wrote: > > On Tue, 2017-02-28 at 15:35 +, Bart Van Assche wrote: > >> On Tue, 2017-02-28 at 15:02 +0300, Dan Carpenter wrote: > >>> Bitwise & was obviously intended here. > > [] > >>> diff --git

[PATCH] rtlwifi: btcoexist: fix semicolon.cocci warnings

Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Larry Finger <larry.fin...@lwfinger.net> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> --- halbtc8821a2ant.c |2 +- 1 file ch

Re: [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 (fwd)

mv88e6xxx_6341_family is checked twice, on line 2606 and 2607. julia -- Forwarded message -- Date: Fri, 20 Jan 2017 19:38:12 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v5 2

Re: [patch net-next] stmmac: indent an if statement

On Tue, 17 Jan 2017, Alexandre Torgue wrote: > Hi Julia > > On 01/16/2017 11:10 PM, Julia Lawall wrote: > > > > > > On Tue, 17 Jan 2017, Dan Carpenter wrote: > > > > > On Mon, Jan 16, 2017 at 10:46:22PM +0100, Julia Lawall wrote: > > > > &g

[PATCH] stmmac: add missing of_node_put

ust after the end of stmmac_remove_config_dt. Thus, add an of_node_put on plat->mdio_node in stmmac_remove_config_dt. It is possible that the field mdio_node is never initialized, but of_node_put is NULL-safe, so it is also safe to call of_node_put in that case. Signed-off-by: Julia Lawall <

  1   2   3   >