Re: [PATCH net-next] sun: Add SPDX license tags to Sun network drivers

way to do this, but it's exceptionally ugly. Also, shouldn't the SPDX line _replace_ the usual "this program is free software" license paragraphs? My understanding is that the SPDX line is functionally equivalent to having the terms spelled out. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH 1/3] net: stmmac: dwmac-sun8i: drop V3s compatible and add V3 one

s variant around for compatibility with existing device trees? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 5/5] wlcore: Use common error handling code in wl1271_op_suspend()

utex_unlock(>mutex); > > - if (ret < 0) { > - wl1271_warning("couldn't prepare device to suspend"); "couldn't enable power saving"? > - return ret; > - } > + if (ret < 0) > + goto report_prepa

Re: [PATCH 4/5] wlcore: Use common error handling code in wlcore_set_beacon_template()

tter > reused at the end of this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> However, > --- > drivers/net/wireless/ti/w

Re: [PATCH 3/5] wlcore: Return directly after a failed ieee80211_beacon_get() in wlcore_set_beacon_template()

iled at the beginning. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 1/5] wlcore: Use common error handling code in wlcore_nvs_cb()

_off(wl); > + goto out_free_nvs; Why not put this in front of the out_free_nvs label? It looks weird here. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 2/5] wlcore: Delete an unnecessary check statement in wlcore_set_beacon_template()

y without the specification of useful actions between. > Thus remove such unnecessary source code at the end of this function. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Looks good to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> -- Julia

Re: [PATCH 28/44] sparc: remove arch specific dma_supported implementations

nc_sg_for_cpu= sbus_sync_sg_for_cpu, > .sync_sg_for_device = sbus_sync_sg_for_device, > + .dma_supported = sbus_dma_supported, > }; > > static int __init sparc_register_ioport(void) Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] mwifiex: fix null pointer deference when adapter is null

nter dereference. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 2/2] mwifiex: simplify length computation for some memset

T <christophe.jail...@wanadoo.fr> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] ath10k: Spelling and miscellaneous neatening

hes <j...@perches.com> This all looks correct to me. I wish you'd put the code changes in a separate patch, however it's all noted in the commit log, so... Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] rtl8xxxu: fix spelling mistake "firmare" -> "firmware"

Hi All, On Sun, Sep 4, 2016 at 2:43 AM, Colin King <colin.k...@canonical.com> wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistakes in dev_dbg message. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Revie

Re: [PATCH] ath10k: fix spelling mistake "montior" -> "monitor"

Hi All, On Sat, Aug 27, 2016 at 4:08 AM, Colin King <colin.k...@canonical.com> wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in ath10k_warn message. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Revie

Re: [PATCH] zd1211rw: fix spelling mistake "firmeware" -> "firmware"

right to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

goto out; > - } else if (ap_ioctl) > + else if (ap_ioctl) > ret = 0; > } > > - out: Does this change make any difference to the compiled code? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback

> interface") > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Looks correct to me as Dan Carpenter submitted the same fix. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 0/4] Mesh mpm fixes and enhancements

sely Patches that you send must be signed off by you, not ack'd by you. I.e. From: Random Developer <random.develo...@company.com> . Signed-off-by: Random Developer <random.develo...@company.com> Signed-off-by: Patch Sender <patch.sen...@company.com> Thanks, --

Re: [PATCH] [linux-next] rtlwifi: Fix typo in printk

Hi All, On Wed, Jun 29, 2016 at 1:37 PM, Masanari Iida <standby2...@gmail.com> wrote: > This patch fix spelling typos found in drivers/net/wireless/realtek. > > Signed-off-by: Masanari Iida <standby2...@gmail.com> Looks right to me. Reviewed-by: Julian Calaby <julian.c

Re: [PATCH 7/8] mwifiex: don't print an error if an optional DT property is missing

Hi Javier, On Wed, Jun 1, 2016 at 11:51 PM, Javier Martinez Canillas <jav...@osg.samsung.com> wrote: > Hello Julian, > > Thanks a lot for your feedback and reviews. > > On 06/01/2016 12:20 AM, Julian Calaby wrote: >> Hi All, >> >> On Sat, May 28, 2016 at 12:

Re: [PATCH 8/8] mwifiex: use better message and error code when OF node doesn't match

ppropriate one. > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> This looks sensible to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++-- > 1 file changed, 2 insertions(+)

Re: [PATCH 7/8] mwifiex: don't print an error if an optional DT property is missing

the property being missed shouldn't be treated as an error. Have you checked whether it is truly optional? I.e. nothing else breaks if this property isn't set? > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Other than that, this looks sensible to me. Reviewed-by: Juli

Re: [PATCH 6/8] mwifiex: check if mwifiex_sdio_probe_of() fails and return error

av...@osg.samsung.com> This looks sensible to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Thanks, -- Julian Calaby Email: julian.cal...@gmail.c

Re: [PATCH 4/8] mwifiex: consolidate mwifiex_sdio_probe() error paths

t; > This also has the nice side effect that the cleanup operations are made > in the inverse order of their counterparts, which was not the case for > the mwifiex_add_card() error path. > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> This looks sens

Re: [PATCH 3/8] mwifiex: propagate mwifiex_add_card() errno code in mwifiex_sdio_probe()

the first function that failed. > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> This looks sensible to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 8 > 1 file changed,

Re: [PATCH 5/8] mwifiex: use dev_err() instead of pr_err() in mwifiex_sdio_probe()

Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas <jav...@osg.samsung.com> wrote: > It's better to have the device name prefixed in the error message. > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> This looks right to me. Revie

Re: [PATCH 2/8] mwifiex: propagate sdio_enable_func() errno code in mwifiex_sdio_probe()

actually failed. > > Since the driver/device core prints the value returned by .probe in its > error message propagate what was returned by sdio_enable_func() at fail. > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> This looks sensible to me. Reviewed-by: Ju

Re: [PATCH 1/8] mwifiex: only call mwifiex_sdio_probe_of() if dev has an OF node

c2:0001:1: sdio platform data not available > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> This looks sensible to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > drivers/net/wireless/marvell/mwifiex/sdio.c | 6 +++--- > 1 file changed, 3 inserti

Re: [PATCH] net/wireless: Fix 'multiple blank lines' check

ted patch. > > Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com> Looks right to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > --- > net/wireless/ap.c | 1 - > net/wireless/chan.c| 3 --- > net/wireless/core.h| 2 -- >

Re: [PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

d-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com> With Kirtika's explanation, this is: Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, Julian Calaby > --- > net/wireless/nl80211.c | 103 > ++--- > 1 file cha

Re: [PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

his patch also contains two hunks to fix > 'line over 80 characters', > that are spacing related". This is the second hunk, the first being > the comments in the nl80211_fam > definition. Should I resend with these two hunks omitted, or fix my wording? That explains it, I m

Re: [PATCH v2 10/10] nl80211: Prefer kcalloc over kzalloc

> Looks right to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, Julian Calaby > --- > net/wireless/nl80211.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c > index 46757af..2964406

Re: [PATCH v2 09/10] nl80211: Fix checkpatch.pl warning

Hi All, On Mon, May 30, 2016 at 12:54 PM, Kirtika Ruchandani <kirtika.ruchand...@gmail.com> wrote: > This patch fixes the checkpatch.pl warning "foo * bar should be > foo *bar" > > Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com> Looks right

Re: [PATCH v2 08/10] nl80211: Fix spelling

Hi All, On Mon, May 30, 2016 at 12:54 PM, Kirtika Ruchandani <kirtika.ruchand...@gmail.com> wrote: > Fix 'implementation' spelling, reported by checkpatch.pl > > Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com> Looks right to me. Reviewed-by: Juli

Re: [PATCH v2 07/10] nl80211: Avoid multiple assignments on same line

m not sure I agree with checkpatch here, but this looks right to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, Julian Calaby > --- > net/wireless/nl80211.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/wireless/nl80211.c b

Re: [PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

->wiphy.regulatory_flags & > +REGULATORY_WIPHY_SELF_MANAGED) && > +nla_put_flag(msg, NL80211_ATTR_WIPHY_SELF_MANAGED_REG)) Adding the brackets around the & expression doesn't look spacing related to me. What's the exact warning this is

Re: [PATCH v2 05/10] nl80211: Fix checkpatch.pl NULL comparison warning

> Looks right to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, Julian Calaby > --- > net/wireless/nl80211.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c > index 945405d.

Re: [PATCH v2 04/10] nl80211: Fix checkpatch.pl warning about braces

ail.com> Looks right to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, Julian Calaby > --- > net/wireless/nl80211.c | 23 +++ > 1 file changed, 15 insertions(+), 8 deletions(-) > > diff --git a/net/wireless/nl80211.c b/net/wirel

Re: [PATCH v2 03/10] nl80211: Prefer ether_addr_copy

right to me, but doesn't ether_addr_copy() have alignment requirements? Could someone more familiar with that review these changes to ensure they're met? Thanks, Julian Calaby > --- > net/wireless/nl80211.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/net/wi

Re: [PATCH 3/3] nl80211: Various checkpatch.pl fixes

nd the whole patch-set or just patch 3/3 in > this one as a separate set? Re-send the entire set, make sure you mark it as v2, include a changelog in the cover letter or below the "---" in the patches themselves, and don't forget to include the reviewed-bys for any unchanged patches. Th

Re: [PATCH 3/3] nl80211: Various checkpatch.pl fixes

ement Multiple assignments: > - multiple assignments should be avoided ether_addr_copy: > - prefer ether_addr_copy over memcpy Spelling: > - correct spelling - 'implementation' NULL comparisons: > - comparison to NULL could be written as !foo kcalloc vs kzalloc: > - prefer kcalloc over

Re: [PATCH 2/3] nl80211: Fix checkpatch warnings about blank lines

after declarations > > Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com> Looks sensible to me Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, Julian Calaby > --- > net/wireless/nl80211.c | 22 ++ > 1 file changed, 10

Re: [PATCH 1/3] nl80211: Fix checkpatch warnings

'*/' on a separate line > > Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com> The change and logic behind it are sound, so it gets my: Reviewed-by: Julian Calaby <julian.cal...@gmail.com> however I'm concerned that this file is a deliberate exception to the

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

ddr variable. >> >> Signed-off-by: Byeoungwook Kim <quddnr...@gmail.com> >> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > > Doesn't apply: > > Applying: rtlwifi: Fix reusable codes in core.c > fatal: sha1 information is lacking or useless > (dr

Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

Hi Kalle, On Fri, Apr 15, 2016 at 10:09 PM, Kalle Valo <kv...@codeaurora.org> wrote: > Julian Calaby <julian.cal...@gmail.com> writes: > >> Hi Kalle, >> >> On Sat, Jan 2, 2016 at 5:25 AM, SF Markus Elfring >> <elfr...@users.sourcefor

Re: [PATCH] ath9k: remove duplicate assignment of variable ah

;colin.k...@canonical.com> Looks right to me. Signed-off-by: Julian Calaby <julian.cal...@gmail.com> Thanks, > --- > drivers/net/wireless/ath/ath9k/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath9k/init.c

Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

nning > by a conditional assignment. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> This looks sane to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, Julian Calaby > --- > drivers/net/wireless/ath/ath9k/htc_drv_main.c | 7 ++--

Re: [PATCH] brcmfmac: sdio: remove unused variable retry_limit

ff-by: Colin Ian King <colin.k...@canonical.com> Looks right to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/wireless/bro

Re: [PATCH][V3] mt7601u: do not free dma_buf when ivp allocation fails

t; garbage on the stack, so the freeing will cause issues when the > urb, buf and dma fields are free'd. Fix this by not free'ing the > dma_buf if the ivp allocation fails. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Looks right to me. Reviewed-by: Julian Calaby &l

Re: [PATCH][V2] mt7601u: do not free dma_buf when ivp allocation fails

usb_alloc_buf(dev, MCU_FW_URB_SIZE, _buf)) { > - ret = -ENOMEM; > + if (!ivb) > + return -ENOMEM; > + if (mt7601u_usb_alloc_buf(dev, MCU_FW_URB_SIZE, _buf)) > goto error; Are you sure this is right? Isn't ret unset here and consequently re

Re: [PATCH] mwifiex: Use to_delayed_work()

make > this change is: > > // > @@ > expression a; > symbol work; > @@ > - container_of(a, struct delayed_work, work) > + to_delayed_work(a) > // > > Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> Looks right to me. Reviewed-by: Julian Calaby <julian.ca

Re: [PATCH] ath10k: fix erroneous return value

This looks right to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > --- > drivers/net/wireless/ath/ath10k/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/pci.c > b/drivers/net/wireless/

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

ll_event.soft". If > the caller has not acquired the airplane-mode control beforehand, the > operation fails. > > Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com> This looks sane to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks,

Re: [PATCH 2/9] rfkill: Remove extra blank line

Hi João, On Tue, Feb 9, 2016 at 2:41 AM, João Paulo Rechi Vita <jprv...@gmail.com> wrote: > Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com> Looks sane to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > --- > net/rfkill/core.c | 1 - &g

Re: [PATCH 1/9] rfkill: Improve documentation language

Hi João, On Tue, Feb 9, 2016 at 2:41 AM, João Paulo Rechi Vita <jprv...@gmail.com> wrote: > Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com> Looks right to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > --- > net/rfkill/core.c | 4 ++-- >

Re: [PATCH 3/9] rfkill: Point to the correct deprecated doc location

dlessm.com> Looks right to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > --- > Documentation/ABI/stable/sysfs-class-rfkill | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/ABI/stable/sysfs-class-rfkill > b/Documen

Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

s[RFKILL_TYPE_ALL].cur; > + > + rfkill_apm_owned = false; > + data->is_apm_owner = false; > + rfkill_apm_led_trigger_event(state); Also, this code is duplicated from the _RELEASE op above. Would it make sense to factor it out into a separate function? > + } > + > list_del(>list); > + (extra line) > mutex_unlock(_global_mutex); > > mutex_destroy(>mtx); Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 5/9] rfkill: Factor rfkill_global_states[].cur assignments

ks sane to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > --- > net/rfkill/core.c | 38 +- > 1 file changed, 17 insertions(+), 21 deletions(-) > > diff --git a/net/rfkill/core.c b/net/rfkill/core.c > index 56d79cb..8b96869 100

Re: [PATCH] rtlwifi: Fix reusable codes in core.c

0xfb) { > - udelay(50); > - } else if (addr == 0xfa) { > - udelay(5); > - } else if (addr == 0xf9) { > - udelay(1); > + if (addr >= 0xf9 && addr <= 0xfe) { > + rtl_addr_delay(addr); > } else { > rtl_set_bbreg(hw, addr, MASKDWORD, data); > udelay(1); Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] rtlwifi: Fix reusable codes in core.c

t; but i agree with your answers of some parts. I think that i should divide > into separate patch. > Thanks for your assists! Not a problem! Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

t;quddnr...@gmail.com> > Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Just a note for the future, you have to explicitly be given a reviewed-by, you can't just assume that someone who has made comments on a patch has reviewed it. In this case, I have reviewed it, so formally: Revie

Re: [PATCH 1/2] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

Hi Byeounwook, On Wed, Feb 3, 2016 at 12:59 PM, Byeoungwook Kim <quddnr...@gmail.com> wrote: > Conditional codes in rtl_addr_delay() were improved in readability and > performance by using switch codes. > > Signed-off-by: Byeoungwook Kim <quddnr...@gmail.com> >

Re: [PATCH] mac80211: fix memory leak

Hi Sudip, On Mon, Feb 1, 2016 at 8:33 PM, Sudip Mukherjee <sudipm.mukher...@gmail.com> wrote: > On Mon, Feb 01, 2016 at 11:28:37AM +0200, Kalle Valo wrote: >> Sudip Mukherjee <sudipm.mukher...@gmail.com> writes: >> >> > On Mon, Feb 01, 2016 at 11:03:35AM +1100,

Re: [PATCH] mac80211: fix memory leak

rr; > } Looks sane to me. I must note that the bug this is fixing is only in the mac80211-next tree. Fixes: 5fe74014172d ("mac80211: avoid excessive stack usage in sta_info") Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] mac80211: fix memory leak

Hi Sudip, On Mon, Feb 1, 2016 at 3:25 PM, Sudip Mukherjee <sudipm.mukher...@gmail.com> wrote: > On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote: >> Hi Sudip, >> >> On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee >> <sudipm.mukher...@gmail

Re: [PATCH v2 net] nfc: use GFP_USER for user-controlled kmalloc

el.com> >> Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com> >> --- > > Note that the issue is not OOM the kernel (as the allocation is > attempted even after your patch), but having a way to > spill stack traces in the syslog. > > Acked-by: Eric Dumazet <e

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

GFP_KERNEL); > + msg_data = kzalloc(len, GFP_USER | __GFP_NOWARN); > if (msg_data == NULL) > return -ENOMEM; Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

Hi Cong, On Wed, Jan 27, 2016 at 10:12 AM, Cong Wang <xiyou.wangc...@gmail.com> wrote: > On Tue, Jan 26, 2016 at 2:55 PM, Julian Calaby <julian.cal...@gmail.com> > wrote: >> Hi Cong, >> >> On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang <xiyou.wangc...@gmail.c

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

Hi Arend, On Tue, Jan 26, 2016 at 2:39 AM, Arend van Spriel <aspr...@gmail.com> wrote: > On 25-01-16 12:06, Julian Calaby wrote: >> Hi Sjoerd, >> >> On Mon, Jan 25, 2016 at 9:47 PM, Sjoerd Simons >> <sjoerd.sim...@collabora.co.uk> wrote: >>> On a

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

y: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> Looks sane to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wire

Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

patches to remove conditions before kfree() and friends, etc. You need to change you attitude: just because you can see some benefit from your patches doesn't mean others do and it doesn't mean that they're willing to accept them. Thanks, -- Julian Calaby Email: julian.cal...@gmail.c

Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

most all of the changes you've proposed that have seen any discussion whatsoever fall into the latter category. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

ead_hwaddr(wl, addr, block, > wl->fw_mem_block_size, false); > > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majord...@vger.kernel.org

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

Hi Nicholas, On Tue, Dec 22, 2015 at 6:29 PM, Nicholas Mc Guire <der.h...@hofr.at> wrote: > On Tue, Dec 22, 2015 at 09:56:10AM +1100, Julian Calaby wrote: >> Hi, >> >> On Tue, Dec 22, 2015 at 3:47 AM, Nicholas Mc Guire <hof...@osadl.org> wrote: >> >