Latitude 5495's tg3 hangs under heavy load

2018-12-07 Thread Kai Heng Feng
Hi tg3 maintainers, I’ve encountered network freeze when using tg3 in gigabits net. The issue can be easily reproduced when using scp to transfer files in local network. The symptom is pretty similar to what this commit is trying to solve: commit 3a498606bb04af603a46ebde8296040b2de350d1

[PATCH] igb: Fix an issue that PME is not enabled during runtime suspend

2018-12-02 Thread Kai-Heng Feng
es the PCI PME. To fix the issue, let's not to save PCI states when it's runtime suspend, to let the PCI subsytem enables PME. Fixes: 42eca2302146 ("PCI: Don't touch card regs after runtime suspend D3") Signed-off-by: Kai-Heng Feng --- drivers/net/ethernet/intel/igb/igb_main.c | 8 +--

[PATCH] r8169: Clear RTL_FLAG_TASK_*_PENDING when clearing RTL_FLAG_TASK_ENABLED

2018-09-10 Thread Kai-Heng Feng
ing RTL_FLAG_TASK_ENABLED, also clears other flags. Cc: Heiner Kallweit Signed-off-by: Kai-Heng Feng --- drivers/net/ethernet/realtek/r8169.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index b08d51bf7

Re: tg3 crashes under high load, when using 100Mbits

2018-04-14 Thread Kai-Heng Feng
Hi Satish, > On 2018Mar21, at 00:57, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: > > Satish Baddipadige <satish.baddipad...@broadcom.com> wrote: > >> On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam >> <siva.kal...@broadcom.com> wrote: >&g

[PATCH] sky2: Increase D3 delay to sky2 stops working after suspend

2018-03-31 Thread Kai-Heng Feng
sta...@vger.kernel.org> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/net/ethernet/marvell/sky2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c index 9fe85300e7b6..5754116

Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving

2018-03-22 Thread Kai-Heng Feng
Kai Heng Feng <kai.heng.f...@canonical.com> wrote: Hopefully Hayes (or Realtek) can shed more lights on the issue. Apparently ALDPS and ASPM for r8169 is enabled in different commercial products, just not in Linux mainline. Hayes and Realtek folks, How do we make this patch going forwa

Re: tg3 crashes under high load, when using 100Mbits

2018-03-20 Thread Kai-Heng Feng
Satish Baddipadige <satish.baddipad...@broadcom.com> wrote: On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam <siva.kal...@broadcom.com> wrote: On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam <siva.kal...@broadcom.com> wrote: On Fri, Feb 9, 2018 at 10:41 AM, Kai Hen

Re: [PATCH] ath9k: turn on btcoex_enable as default

2018-02-11 Thread Kai Heng Feng
> On 10 Feb 2018, at 10:05 PM, Felix Fietkau <n...@nbd.name> wrote: > > On 2018-02-10 14:56, Kai Heng Feng wrote: >> >>> On 9 Feb 2018, at 3:16 PM, Kalle Valo <kv...@codeaurora.org> wrote: >>> Sure, but we have to make sure that we don't create reg

Re: [PATCH] ath9k: turn on btcoex_enable as default

2018-02-10 Thread Kai Heng Feng
> On 9 Feb 2018, at 3:16 PM, Kalle Valo wrote: > Sure, but we have to make sure that we don't create regressions on > existing systems. For example, did you test this with any system which > don't support btcoex? (just asking, haven't tested this myself) No not really, but

tg3 crashes under high load, when using 100Mbits

2018-02-08 Thread Kai Heng Feng
Hi Broadcom folks, We are now enabling a new platform with tg3 nic, unfortunately we observed the bug [1] that dated back to 2015. I tried commit 4419bb1cedcd ("tg3: Add workaround to restrict 5762 MRRS to 2048”) but it does’t work. Do you have any idea how to solve the issue? [1]

Re: [PATCH] ath9k: turn on btcoex_enable as default

2018-02-08 Thread Kai Heng Feng
Hi Felix, On Feb 8, 2018, at 7:02 PM, Felix Fietkau <n...@nbd.name> wrote: On 2018-02-08 06:28, Kai-Heng Feng wrote: Without btcoex_enable, WiFi activies make both WiFi and Bluetooth unstable if there's a bluetooth connection. Enable this option when bt_ant_diversity is disabled. B

[PATCH] ath9k: turn on btcoex_enable as default

2018-02-07 Thread Kai-Heng Feng
Without btcoex_enable, WiFi activies make both WiFi and Bluetooth unstable if there's a bluetooth connection. Enable this option when bt_ant_diversity is disabled. BugLink: https://bugs.launchpad.net/bugs/1746164 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drive

Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

2018-01-18 Thread Kai Heng Feng
> On 18 Jan 2018, at 10:50 PM, David Miller wrote: > > From: Hayes Wang > Date: Thu, 18 Jan 2018 03:04:08 + > >> [...] r8153 on Dell TB15/16 dock corrupts rx packets. This change is suggested by Realtek. They guess that the XHCI

Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

2018-01-17 Thread Kai Heng Feng
> On 18 Jan 2018, at 11:04 AM, Hayes Wang wrote: > > [...] >>> r8153 on Dell TB15/16 dock corrupts rx packets. >>> >>> This change is suggested by Realtek. They guess that the XHCI >>> controller doesn't have enough buffer, and their guesswork is correct, >>> once the RX

[PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

2018-01-16 Thread Kai-Heng Feng
Limonciello <mario.limoncie...@dell.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v2: - Disable RX aggregation instead of disable RX checksum - Use bcdDevice and iSerialNumber to uniquely identify Dell TB16 drivers/net/usb/r8152.c | 13 + 1 file

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-28 Thread Kai Heng Feng
> On 27 Nov 2017, at 11:13 PM, > wrote: > > This is quite surprising to me too. The externally plugged in r8153 dongle, > was it connected over type C port or over type A port? AFAIK Type C port is > actually Alpine ridge pass through

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-24 Thread Kai Heng Feng
> Also the MAC address is different, can you just trigger off of Dell's > MAC address space instead of the address space of the dongle device? A really good idea, never thought of this. Thanks for the hint :) Still, I need to ask Dell folks to get all the answers. Kai-Heng

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-24 Thread Kai Heng Feng
> On 24 Nov 2017, at 4:28 PM, Greg KH wrote: > > The bcdDevice is different between the dock device and the "real" > device, why not use that? Yea, I’ll poke around and see if bcdDevice alone can be a good predicate. > Then there is still a bug. Who as ASMedia is

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-23 Thread Kai Heng Feng
> On 23 Nov 2017, at 5:24 PM, Greg KH <gre...@linuxfoundation.org> wrote: > > On Thu, Nov 23, 2017 at 04:53:41PM +0800, Kai Heng Feng wrote: >> >> What I want to do here is to finding this connection: >> Realtek r8153 <-> SMSC hub (USD ID: 0424:5537)

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-23 Thread Kai Heng Feng
> On 23 Nov 2017, at 3:58 PM, Greg KH <gre...@linuxfoundation.org> wrote: > > On Thu, Nov 23, 2017 at 01:38:38AM -0500, Kai-Heng Feng wrote: >> r8153 on Dell TB dock corrupts rx packets. >> >> The root cause is not found yet, but disabling rx checksumming can &g

[PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-22 Thread Kai-Heng Feng
bugs/1729674 Cc: Mario Limonciello <mario.limoncie...@dell.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/net/usb/r8152.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drive

Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving

2017-11-15 Thread Kai Heng Feng
> On 15 Nov 2017, at 6:53 PM, David Miller <da...@davemloft.net> wrote: > > From: Kai-Heng Feng <kai.heng.f...@canonical.com> > Date: Wed, 15 Nov 2017 04:00:18 -0500 > >> Commit ("r8169: enable ALDPS for power saving") caused a regression on &g

[PATCH 2/2] r8169: reinstate internal ASPM and clock request settings

2017-11-15 Thread Kai-Heng Feng
: Francois Romieu <rom...@fr.zoreil.com> Cc: Hayes Wang <hayesw...@realtek.com> Cc: Jörg Otte <jrg.o...@gmail.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/net/ethernet/realtek/r8169.c | 28 ++-- 1 file changed, 22 inserti

[PATCH 1/2] r8169: reinstate ALDPS for power saving

2017-11-15 Thread Kai-Heng Feng
omieu <rom...@fr.zoreil.com> Cc: Hayes Wang <hayesw...@realtek.com> Cc: Jörg Otte <jrg.o...@gmail.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/net/ethernet/realtek/r8169.c | 58 +--- 1 file changed, 48 insertions(+), 10

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-16 Thread Kai-Heng Feng
On Mon, Nov 14, 2016 at 3:34 PM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: > On Fri, Nov 11, 2016 at 10:44 PM, Mathias Nyman > <mathias.ny...@linux.intel.com> wrote: >> On 10.11.2016 13:22, Oliver Neukum wrote: >>> >>> On Thu, 2016-11-10 at 12

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-09 Thread Kai-Heng Feng
Hi, On Wed, Nov 9, 2016 at 8:32 PM, Bjørn Mork wrote: > Oliver Neukum writes: > >> On Tue, 2016-11-08 at 13:44 -0500, Alan Stern wrote: >> >>> These problems could very well be caused by running at SuperSpeed >>> (USB-3) instead of high speed (USB-2). Yes, it's

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-07 Thread Kai-Heng Feng
Hi, On Mon, Nov 7, 2016 at 7:02 PM, Oliver Neukum <oneu...@suse.com> wrote: > On Fri, 2016-11-04 at 17:57 +0800, Kai-Heng Feng wrote: >> Sometimes cdc_mbim failed to probe if runtime pm is enabled: >> [9.305626] cdc_mbim: probe of 2-2:1.12 failed with error -22 >

[PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-04 Thread Kai-Heng Feng
Sometimes cdc_mbim failed to probe if runtime pm is enabled: [9.305626] cdc_mbim: probe of 2-2:1.12 failed with error -22 This can be solved by increase its pm usage counter. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/net/usb/usbnet.c | 7 ++- 1 file c