Re: [PATCH net v2] net: Do not hold the reference for the same sk_rx_dst

2017-03-20 Thread Kaiwen Xu
On Sun, Mar 19, 2017 at 09:09:38PM -0700, Cong Wang wrote: > On Sat, Mar 18, 2017 at 9:03 PM, Kaiwen Xu <kaiwen...@hulu.com> wrote: > > On Sat, Mar 18, 2017 at 08:49:43PM -0700, Cong Wang wrote: > >> On Sat, Mar 18, 2017 at 6:48 PM, Kevin Xu <kaiwen...@hulu.com> wr

Re: [PATCH net v2] net: Do not hold the reference for the same sk_rx_dst

2017-03-18 Thread Kaiwen Xu
On Sat, Mar 18, 2017 at 08:49:43PM -0700, Cong Wang wrote: > On Sat, Mar 18, 2017 at 6:48 PM, Kevin Xu wrote: > > In some rare cases, inet_sk_rx_dst_set() may be called multiple times > > on the same dst, causing double refcounting. Eventually, it > > prevents net_device to be

Re: [PATCH] [PATCH net] net: Do not hold the reference for the same sk_rx_dst.

2017-03-16 Thread Kaiwen Xu
On Thu, Mar 16, 2017 at 11:45:03AM +0100, Jakub Sitnicki wrote: > On Thu, Mar 16, 2017 at 10:12 AM GMT, Kevin Xu wrote: > > Do you mean the message looping endlessly? > > No, the message is emitted just once. Around 100 seconds after > destroying a few namespaces. Occurs not so often, maybe once

Re: loopback device reference count leakage

2017-02-09 Thread Kaiwen Xu
t 6:32 PM, Kaiwen Xu <ke...@kevxu.net> wrote: > > Hi Cong, > > > > I did some more testing, seems like your second assumption is correct. > > There is indeed some things holding the references to a particular dst > > which preventing it to be gc'ed. > > Exc

Re: loopback device reference count leakage

2017-01-26 Thread Kaiwen Xu
On Thu, Jan 26, 2017 at 05:01:38PM -0800, Cong Wang wrote: > I'd suggest to you add some debugging printk's to the dst refcount functions, > or maybe just inside dst_gc_task(). I think the last dst referring to > the loopback > dev is still being referred at that point, which prevents GC from

Re: loopback device reference count leakage

2017-01-26 Thread Kaiwen Xu
] [] ? kthread_park+0x60/0x60 Jan 19 19:44:00 kernel: [ 1507.052786] [] ret_from_fork+0x3f/0x70 Jan 19 19:44:00 kernel: [ 1507.052788] [] ? kthread_park+0x60/0x60 Thanks, Kaiwen On Wed, Jan 25, 2017 at 11:50:25AM -0800, Cong Wang wrote: > Hello, > > On Mon, Jan 23, 2017 at 9:17 PM, Kaiw

loopback device reference count leakage

2017-01-23 Thread Kaiwen Xu
Hi netdev folks, I am currently experiencing an issue related with the loopback during network devices shutdown inside a network namespace, which mainfested as unregister_netdevice: waiting for lo to become free. Usage count = 1 showing up every 10 seconds or so in the kernel log. It