[PATCH 09/58] net/irda: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
Cc: Stephen Hemminger <step...@networkplumber.org> Cc: Johannes Berg <johannes.b...@intel.com> Cc: Ingo Molnar <mi...@kernel.org> Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- .../staging/irda/include/net/irda/irlmp_event.h| 6 +--

[PATCH 13/58] ethernet/broadcom: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
uot;David S. Miller" <da...@davemloft.net> Cc: Arnd Bergmann <a...@arndb.de> Cc: Jarod Wilson <ja...@redhat.com> Cc: netdev@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- drivers/net/ethernet/broadcom/bcm63xx

[PATCH 08/58] net/wireless/ray_cs: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
Signed-off-by: Kees Cook <keesc...@chromium.org> --- drivers/net/wireless/ray_cs.c | 53 --- 1 file changed, 24 insertions(+), 29 deletions(-) diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c index 170cd504e8ff..d8afcdf

[PATCH 14/58] net: tulip: de2104x: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
lt;yuval.sh...@oracle.com> Cc: Tobias Klauser <tklau...@distanz.ch> Cc: Jarod Wilson <ja...@redhat.com> Cc: Philippe Reynes <trem...@gmail.com> Cc: netdev@vger.kernel.org Cc: linux-par...@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> Reviewed-by: Tobias Kla

[PATCH 06/58] net/ti/tlan: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Samuel Chessman <chess...@tux.org> Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook

[PATCH 15/58] pcmcia/electra_cf: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Michael Ellerman <m...@ellerman.id.au> Cc: linux-pcm...@lists.infradead.org Signed-off-by: Kee

[PATCH 07/58] net/usb/usbnet: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
Signed-off-by: Kees Cook <keesc...@chromium.org> --- drivers/net/usb/usbnet.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 6510e5cc1817..80348b6a8646 100644 --- a/drivers/net/usb/usbnet.c +++ b/dri

[PATCH 20/58] atm: idt77252: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
Williams <3ch...@gmail.com> Cc: linux-atm-gene...@lists.sourceforge.net Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- drivers/atm/idt77252.c | 21 - drivers/atm/idt77252.h | 3 +++ 2 files changed, 15 insertions(+), 9 deletions(-)

[PATCH 23/58] drivers/net/3com: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
.@davemloft.net> Cc: Jarod Wilson <ja...@redhat.com> Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- drivers/net/ethernet/3com/3c574_cs.c | 12 +--- drivers/net/ethernet/3com/3c589_cs.c | 10 +- drivers/net/ethernet/3com/3c59x.c

[PATCH 42/58] isdnloop: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
Miller" <da...@davemloft.net> Cc: Al Viro <v...@zeniv.linux.org.uk> Cc: Stephen Hemminger <step...@networkplumber.org> Cc: Arnd Bergmann <a...@arndb.de> Cc: Johannes Berg <johannes.b...@intel.com> Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@ch

[PATCH 53/58] net: atm: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
c: Augusto Mecking Caringi <augustocari...@gmail.com> Cc: Jarod Wilson <ja...@redhat.com> Cc: Kalle Valo <kv...@codeaurora.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Alexey Dobriyan <adobri...@gmail.com> Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@

[PATCH 51/58] ethernet/intel: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
irs...@intel.com> Cc: intel-wired-...@lists.osuosl.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- drivers/net/ethernet/intel/e100.c | 6 +++--- drivers/net/ethernet/intel/e1000e/netdev.c| 14 ++ drivers/net/ethernet

[PATCH 43/58] net: ethernet: apple: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
m> Cc: Jarod Wilson <ja...@redhat.com> Cc: Rob Herring <r...@kernel.org> Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- drivers/net/ethernet/apple/bmac.c | 12 +--- drivers/net/ethernet/apple/mace.c | 12 +--- 2 files changed, 10 in

[PATCH 48/58] net: usb: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
...@mork.no> Cc: "Stefan BrĂ¼ns" <stefan.bru...@rwth-aachen.de> Cc: Alexey Dobriyan <adobri...@gmail.com> Cc: Greg Ungerer <g...@linux-m68k.org> Cc: linux-...@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- drivers/net/us

[PATCH 49/58] net: neterion: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Jon Mason <jdma...@kudzu.us> Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chr

[PATCH 30/58] mISDN: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
id S. Miller" <da...@davemloft.net> Cc: Masahiro Yamada <yamada.masah...@socionext.com> Cc: Andrew Morton <a...@linux-foundation.org> Cc: Anton Vasilyev <vasil...@ispras.ru> Cc: Ingo Molnar <mi...@kernel.org> Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <

[PATCH 01/58] net/decnet: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
gt; Cc: David Ahern <d...@cumulusnetworks.com> Cc: linux-decnet-u...@lists.sourceforge.net Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- include/net/dn.h| 7 --- include/net/dn_nsp.h| 1 - net/decnet/af_decnet.c | 4 net/decnet/d

[PATCH] wireless: iwlegacy: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
linux-wirel...@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- drivers/net/wireless/intel/iwlegacy/3945-mac.c | 2 +- drivers/net/wireless/intel/iwlegacy/3945-rs.c | 10 +++--- drivers/net/wireless/intel/iwlegacy/4965-mac.c | 9 - drivers/

[PATCH] rtlwifi: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
: Kalle Valo <kv...@codeaurora.org> Cc: Ping-Ke Shih <pks...@realtek.com> Cc: Arvind Yadav <arvind.yadav...@gmail.com> Cc: Souptick Joarder <jrdr.li...@gmail.com> Cc: linux-wirel...@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org>

[PATCH] wireless: qtnfmac: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
; Cc: Sergey Matyukevich <smatyukev...@quantenna.com> Cc: Kalle Valo <kv...@codeaurora.org> Cc: Kamlesh Rath <kr...@quantenna.com> Cc: linux-wirel...@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- drivers/net/wireless/quantenna/qtn

[PATCH] mac80211: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
et> Cc: linux-wirel...@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- net/mac80211/ibss.c | 7 +++ net/mac80211/ieee80211_i.h | 3 ++- net/mac80211/led.c | 11 ++- net/mac80211/main.c | 3 +-- net/

[PATCH] mac80211: aggregation: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
, along with the tid index itself. Cc: Johannes Berg <johan...@sipsolutions.net> Cc: "David S. Miller" <da...@davemloft.net> Cc: linux-wirel...@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- This has been the least trivial

Re: [PATCH] rtl8xxxu: mark expected switch fall-throughs

2017-10-11 Thread Kees Cook
the compiler help us not make mistakes is quite handy, and with Gustavo grinding through all the Coverity warnings, he's found actual bugs with missing "break"s, so I think this has a demonstrable benefit to the code-base as a whole. It makes things unambiguous to someone else reviewing the code. -Kees -- Kees Cook Pixel Security

[PATCH] hdlc: Convert timers to use timer_setup()

2017-10-10 Thread Kees Cook
and .data fields. Cc: David S. Miller <da...@davemloft.net> Cc: Krzysztof Halasa <k...@pm.waw.pl> Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type&quo

[PATCH 1/3] atm: idt77105: Drop needless setup_timer()

2017-10-10 Thread Kees Cook
Calling setup_timer() is redundant when DEFINE_TIMER() has been used. Cc: Chas Williams <3ch...@gmail.com> Cc: linux-atm-gene...@lists.sourceforge.net Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- This is intended to go via the timer tree. Acks

Re: net/wireless/ray_cs: Convert timers to use

2017-10-10 Thread Kees Cook
On Tue, Oct 10, 2017 at 1:26 AM, Kalle Valo <kv...@codeaurora.org> wrote: > Kees Cook <keesc...@chromium.org> wrote: > >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and fro

[PATCH] timer: Remove meaningless .data/.function assignments

2017-10-09 Thread Kees Cook
p.com> Cc: Ganesh Krishna <ganesh.kris...@microchip.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: Jens Axboe <ax...@fb.com> Cc: netdev@vger.kernel.org Cc: linux-wirel...@vger.kernel.org Cc: de...@driverdev.osuosl.org Signed-off-by: Kees Cook <keesc...@chromium.

Re: [PATCH] net: can: Convert timers to use timer_setup()

2017-10-09 Thread Kees Cook
On Mon, Oct 9, 2017 at 10:53 AM, Marc Kleine-Budde <m...@pengutronix.de> wrote: > On 10/05/2017 02:51 AM, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and fr

Re: [PATCH v2] isdn/gigaset: Convert timers to use timer_setup()

2017-10-09 Thread Kees Cook
On Mon, Oct 9, 2017 at 2:15 AM, David Laight <david.lai...@aculab.com> wrote: > From: Kees Cook >> Sent: 06 October 2017 20:40 > ... >> I'm in no rush for any specific change. There are about 900 call sites >> I'm making my way through, about 2/3rd are pretty tr

Re: [PATCH v2] isdn/gigaset: Convert timers to use timer_setup()

2017-10-06 Thread Kees Cook
On Fri, Oct 6, 2017 at 12:00 PM, Paul Bolle <pebo...@tiscali.nl> wrote: > On Thu, 2017-10-05 at 12:31 -0700, Kees Cook wrote: >> --- a/drivers/isdn/gigaset/bas-gigaset.c >> +++ b/drivers/isdn/gigaset/bas-gigaset.c > >> -static void cmd_in_timeout(unsigned long data)

Re: [PATCH] net/mlx4_core: Convert timers to use timer_setup()

2017-10-06 Thread Kees Cook
On Thu, Oct 5, 2017 at 2:38 AM, Leon Romanovsky <l...@kernel.org> wrote: > On Wed, Oct 04, 2017 at 05:51:54PM -0700, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_s

[PATCH v2] isdn/gigaset: Convert timers to use timer_setup()

2017-10-05 Thread Kees Cook
id S. Miller" <da...@davemloft.net> Cc: Johan Hovold <jo...@kernel.org> Cc: gigaset307x-com...@lists.sourceforge.net Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer call

[PATCH] isdn/gigaset: Use kzalloc instead of open-coded field zeroing

2017-10-05 Thread Kees Cook
kernel.org> Cc: gigaset307x-com...@lists.sourceforge.net Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- drivers/isdn/gigaset/bas-gigaset.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/

Re: [PATCH] isdn/gigaset: Convert timers to use timer_setup()

2017-10-05 Thread Kees Cook
On Thu, Oct 5, 2017 at 12:58 AM, Paul Bolle <pebo...@tiscali.nl> wrote: > Hi Kees, > > On Wed, 2017-10-04 at 17:52 -0700, Kees Cook wrote: >> Also uses kzmalloc to replace open-coded field assignments to NULL and zero. > > If I'm allowed to whine (chances that I'm al

[PATCH v2] netfilter: ipset: Convert timers to use timer_setup()

2017-10-05 Thread Kees Cook
ghalsimr...@gmail.com> Cc: Muhammad Falak R Wani <falakre...@gmail.com> Cc: netfilter-de...@vger.kernel.org Cc: coret...@netfilter.org Cc: netdev@vger.kernel.org Cc: Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> Acked-by: Jozs

Re: [PATCH] netfilter: ipset: Convert timers to use timer_setup()

2017-10-05 Thread Kees Cook
On Thu, Oct 5, 2017 at 6:58 AM, Jozsef Kadlecsik <kad...@blackhole.kfki.hu> wrote: > Hi, > > On Wed, 4 Oct 2017, Kees Cook wrote: > >> In preparation for unconditionally passing the struct timer_list pointer >> to all timer callbacks, switch to using the new t

[PATCH v2] net/mac80211/mesh_plink: Convert timers to use timer_setup()

2017-10-05 Thread Kees Cook
: Johannes Berg <johan...@sipsolutions.net> Cc: "David S. Miller" <da...@davemloft.net> Cc: linux-wirel...@vger.kernel.org Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fe

Re: [PATCH] net/mac80211/mesh_plink: Convert timers to use

2017-10-05 Thread Kees Cook
On Wed, Oct 4, 2017 at 11:47 PM, Johannes Berg <johan...@sipsolutions.net> wrote: > On Wed, 2017-10-04 at 17:49 -0700, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list >> pointer to all timer callbacks, switch to using the new timer_setu

[PATCH] net/decnet: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
gt; Cc: David Ahern <d...@cumulusnetworks.com> Cc: linux-decnet-u...@lists.sourceforge.net Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to chang

[PATCH] net/rose: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
ft.net> Cc: linux-h...@vger.kernel.org Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, but should be ot

[PATCH] net/lapb: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
com> Cc: "Reshetova, Elena" <elena.reshet...@intel.com> Cc: linux-...@vger.kernel.org Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change

[PATCH] net/mac80211/mesh_plink: Convert timers to use

2017-10-04 Thread Kees Cook
: Johannes Berg <johan...@sipsolutions.net> Cc: "David S. Miller" <da...@davemloft.net> Cc: linux-wirel...@vger.kernel.org Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fe

[PATCH] net/irda-usb: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
this in the future. Cc: Samuel Ortiz <sam...@sortiz.org> Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-

[PATCH] net/irda: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
Cc: Stephen Hemminger <step...@networkplumber.org> Cc: Johannes Berg <johannes.b...@intel.com> Cc: Ingo Molnar <mi...@kernel.org> Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 68

[PATCH] net/usb/usbnet: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, but should be otherwise stand-alone. --- drivers/net/usb/usbnet.c | 12 +++

[PATCH] net/ti/tlan: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
tronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, but should be otherwise stand-alone. --- drivers/net/ethernet/ti/tlan.c | 32 +--- 1

[PATCH] net/wireless/ray_cs: Convert timers to use

2017-10-04 Thread Kees Cook
org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, but should be otherwise stand-alone. --- driver

[PATCH] isdn/hisax: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
id S. Miller" <da...@davemloft.net> Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, but

[PATCH] xfrm: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
rg.au> Cc: "David S. Miller" <da...@davemloft.net> Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type&

[PATCH] net: tulip: de2104x: Convert timers to use

2017-10-04 Thread Kees Cook
lt;yuval.sh...@oracle.com> Cc: Tobias Klauser <tklau...@distanz.ch> Cc: Jarod Wilson <ja...@redhat.com> Cc: Philippe Reynes <trem...@gmail.com> Cc: netdev@vger.kernel.org Cc: linux-par...@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <k

[PATCH] net/hamradio/6pack: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
el.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, but should be otherwise stand-alone. --- drive

[PATCH] ethernet/broadcom: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
uot;David S. Miller" <da...@davemloft.net> Cc: Arnd Bergmann <a...@arndb.de> Cc: Jarod Wilson <ja...@redhat.com> Cc: netdev@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium

[PATCH] net/cw1200: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
linux-wirel...@vger.kernel.org Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, but should be otherwise stand-a

[PATCH] net: ethernet: stmmac: Convert timers to use

2017-10-04 Thread Kees Cook
; Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, but should be otherwise stand-alone. --- d

[PATCH] drivers/atm/suni: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
m-gene...@lists.sourceforge.net Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, but should be otherwise s

[PATCH] atm: idt77252: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
Williams <3ch...@gmail.com> Cc: linux-atm-gene...@lists.sourceforge.net Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argum

[PATCH] net: tulip: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
.com> Cc: netdev@vger.kernel.org Cc: linux-par...@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, b

[PATCH] chelsio: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
m> Cc: Eric Dumazet <eduma...@google.com> Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, but

[PATCH] net: can: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
Cc: "David S. Miller" <da...@davemloft.net> Cc: linux-...@vger.kernel.org Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer call

[PATCH] net: amd8111e: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
; Cc: Jarod Wilson <ja...@redhat.com> Cc: Philippe Reynes <trem...@gmail.com> Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change time

[PATCH] drivers/net/3com: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
.@davemloft.net> Cc: Jarod Wilson <ja...@redhat.com> Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type")

[PATCH] net/mlx4_core: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, but should be otherwise stand-alone. --- drivers/net/ethernet/mellanox/mlx4/cat

[PATCH] net: dl2k: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
Tobias Klauser <tklau...@distanz.ch> Cc: Philippe Reynes <trem...@gmail.com> Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change time

[PATCH] mISDN: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
id S. Miller" <da...@davemloft.net> Cc: Masahiro Yamada <yamada.masah...@socionext.com> Cc: Andrew Morton <a...@linux-foundation.org> Cc: Anton Vasilyev <vasil...@ispras.ru> Cc: Ingo Molnar <mi...@kernel.org> Cc: netdev@vger.kernel.org Cc: Thomas Gleixner

[PATCH] net: ksz884x: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
m> Cc: Jarod Wilson <ja...@redhat.com> Cc: Masahiro Yamada <yamada.masah...@socionext.com> Cc: Philippe Reynes <trem...@gmail.com> Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires

[PATCH] isdn/gigaset: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
ebo...@tiscali.nl> Cc: Karsten Keil <i...@linux-pingi.de> Cc: "David S. Miller" <da...@davemloft.net> Cc: Johan Hovold <jo...@kernel.org> Cc: gigaset307x-com...@lists.sourceforge.net Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-

[PATCH] net: sched: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
gmail.com> Cc: Jiri Pirko <j...@resnulli.us> Cc: "David S. Miller" <da...@davemloft.net> Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("ti

[PATCH] inet/connection_sock: Convert timers to use

2017-10-04 Thread Kees Cook
; Cc: Alexey Kuznetsov <kuz...@ms2.inr.ac.ru> Cc: Hideaki YOSHIFUJI <yoshf...@linux-ipv6.org> Cc: netdev@vger.kernel.org Cc: d...@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef92

[PATCH] netfilter: ipset: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
ghalsimr...@gmail.com> Cc: Muhammad Falak R Wani <falakre...@gmail.com> Cc: netfilter-de...@vger.kernel.org Cc: coret...@netfilter.org Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686f

[PATCH] inet: frags: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
..@strlen.de> Cc: linux-w...@vger.kernel.org Cc: netdev@vger.kernel.org Cc: netfilter-de...@vger.kernel.org Cc: coret...@netfilter.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change

[PATCH] net/core: Collapse redundant sk_timer callback data

2017-10-04 Thread Kees Cook
.kernel.org Cc: linux-...@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, but should be otherwise stand-alone. --- net/c

[PATCH] forcedeth: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
t; Cc: Philippe Reynes <trem...@gmail.com> Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, but

[PATCH] bna: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
gt; Cc: dept-gelinuxnic...@cavium.com Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, but should be o

[PATCH] net: vxge: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
iroslav Lichvar <mlich...@redhat.com> Cc: Jarod Wilson <ja...@redhat.com> Cc: Eric Dumazet <eduma...@google.com> Cc: stephen hemminger <step...@networkplumber.org> Cc: netdev@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Kees Cook <keesc

[PATCH] net/irda/bfin_sir: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
tronix.de> Signed-off-by: Kees Cook <keesc...@chromium.org> --- This requires commit 686fef928bba ("timer: Prepare to change timer callback argument type") in v4.14-rc3, but should be otherwise stand-alone. --- drivers/staging/irda/drivers/bfin_sir.c | 12 +++- 1 file

[PATCH 00/13] timer: Start conversion to timer_setup()

2017-10-04 Thread Kees Cook
Hi, This is the first of many timer infrastructure cleanups to simplify the timer API[1]. All of these patches are expected to land via the timer tree, so Acks (or corrections) appreciated. These patches refactor various users of timer API that are NOT just using init_timer() or setup_timer()

[PATCH 04/13] timer: Remove init_timer_pinned() in favor of timer_setup()

2017-10-04 Thread Kees Cook
This refactors the only users of init_timer_pinned() to use the new timer_setup() and from_timer(). Drops the definition of init_timer_pinned(). Cc: Chris Metcalf <cmetc...@mellanox.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: netdev@vger.kernel.org Signed-off-by: Kees

[PATCH 03/13] timer: Remove init_timer_on_stack() in favor of timer_setup_on_stack()

2017-10-04 Thread Kees Cook
<m...@sgi.com> Cc: "James E.J. Bottomley" <j...@linux.vnet.ibm.com> Cc: "Martin K. Petersen" <martin.peter...@oracle.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: linux...@vger.kernel.org Cc: linux1394-de...@lists.sourceforge.net Cc: linux-s...@vger.kernel.

[PATCH 01/13] timer: Convert schedule_timeout() to use from_timer()

2017-10-04 Thread Kees Cook
is eliminated. Cc: John Stultz <john.stu...@linaro.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Stephen Boyd <sb...@codeaurora.org> Signed-off-by: Kees Cook <keesc...@chromium.org> --- include/linux/timer.h | 8 kernel/time/timer.c | 26 +++

[PATCH 08/13] timer: Remove unused static initializer macros

2017-10-04 Thread Kees Cook
This removes the now unused TIMER_*INITIALIZER macros: TIMER_INITIALIZER TIMER_PINNED_INITIALIZER TIMER_DEFERRED_INITIALIZER TIMER_PINNED_DEFERRED_INITIALIZER Signed-off-by: Kees Cook <keesc...@chromium.org> --- include/linux/timer.h | 12 1 file changed, 12 deletions(-)

[PATCH 05/13] timer: Remove init_timer_deferrable() in favor of timer_setup()

2017-10-04 Thread Kees Cook
@kernel.org> Cc: Harish Patil <harish.pa...@cavium.com> Cc: Manish Chopra <manish.cho...@cavium.com> Cc: Kalle Valo <kv...@qca.qualcomm.com> Cc: linuxppc-...@lists.ozlabs.org Cc: netdev@vger.kernel.org Cc: linux-wirel...@vger.kernel.org Signed-off-by: Kees Cook <keesc...@ch

[PATCH 02/13] timer: Remove init_timer_pinned_deferrable() in favor of timer_setup()

2017-10-04 Thread Kees Cook
u...@linaro.org> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> Cc: Paul Mackerras <pau...@samba.org> Cc: Michael Ellerman <m...@ellerman.id.au> Cc: Thomas Gleixner <t...@linutronix.de> Cc: linux...@vger.kernel.org Cc: linuxppc-...@lists.ozlabs.org Signed-off-by:

[PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

2017-10-04 Thread Kees Cook
Drop the arguments from the macro and adjust all callers with the following script: perl -pi -e 's/DEFINE_TIMER\((.*), 0, 0\);/DEFINE_TIMER($1);/g;' \ $(git grep DEFINE_TIMER | cut -d: -f1 | sort -u | grep -v timer.h) Signed-off-by: Kees Cook <keesc...@chromium.org> Acked-by:

[PATCH 12/13] kthread: Convert callback to use from_timer()

2017-10-04 Thread Kees Cook
org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Oleg Nesterov <o...@redhat.com> Signed-off-by: Kees Cook <keesc...@chromium.org> --- include/linux/kthread.h | 10 +- kernel/kthread.c| 10 -- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git

[PATCH 13/13] workqueue: Convert callback to use from_timer()

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch workqueue to use from_timer() and pass the timer pointer explicitly. Cc: Tejun Heo <t...@kernel.org> Cc: Lai Jiangshan <jiangshan...@gmail.com> Signed-off-by: Kees Cook <keesc.

[PATCH 11/13] timer: Remove expires argument from __TIMER_INITIALIZER()

2017-10-04 Thread Kees Cook
The expires field is normally initialized during the first mod_timer() call. It was unused by all callers, so remove it from the macro. Signed-off-by: Kees Cook <keesc...@chromium.org> --- include/linux/kthread.h | 2 +- include/linux/timer.h | 5 ++--- include/linux/workqueue.h | 2

[PATCH 09/13] timer: Remove users of expire and data arguments to DEFINE_TIMER

2017-10-04 Thread Kees Cook
broeck <w...@iguana.be> Cc: Guenter Roeck <li...@roeck-us.net> Cc: Geert Uytterhoeven <ge...@linux-m68k.org> Cc: linux-m...@linux-mips.org Cc: linux-watch...@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- arch/mips/mti-malta/malta-display.

[PATCH 07/13] timer: Remove last user of TIMER_INITIALIZER

2017-10-04 Thread Kees Cook
Drops the last user of TIMER_INITIALIZER and adapts timer.h to use the internal version. Cc: Arnd Bergmann <a...@arndb.de> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: Mark Gross <mark.gr...@intel.com> Cc: Thomas Gleixner <t...@linutronix.de> Signed-

[PATCH 06/13] timer: Remove users of TIMER_DEFERRED_INITIALIZER

2017-10-04 Thread Kees Cook
t; Cc: Tejun Heo <t...@kernel.org> Cc: Lai Jiangshan <jiangshan...@gmail.com> Cc: linux-s...@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- arch/s390/kernel/lgr.c | 6 +++--- arch/s390/kernel/topology.c | 6 +++--- kernel/workqueue.c |

Re: [kernel-hardening] Re: [PATCH v3 03/31] usercopy: Mark kmalloc caches as usercopy caches

2017-09-21 Thread Kees Cook
On Thu, Sep 21, 2017 at 9:04 AM, Christopher Lameter <c...@linux.com> wrote: > On Thu, 21 Sep 2017, Kees Cook wrote: > >> > So what is the point of this patch? >> >> The DMA kmalloc caches are not whitelisted: > > The DMA kmalloc caches are pretty obsolete

Re: [kernel-hardening] Re: [PATCH v3 03/31] usercopy: Mark kmalloc caches as usercopy caches

2017-09-21 Thread Kees Cook
On Thu, Sep 21, 2017 at 8:27 AM, Christopher Lameter <c...@linux.com> wrote: > On Wed, 20 Sep 2017, Kees Cook wrote: > >> --- a/mm/slab.c >> +++ b/mm/slab.c >> @@ -1291,7 +1291,8 @@ void __init kmem_cache_init(void) >>*/ >> kmalloc

[PATCH v2 20/31] net/core: Collapse redundant sk_timer callback data assignments

2017-09-20 Thread Kees Cook
...@google.com> Cc: Paolo Abeni <pab...@redhat.com> Cc: David Howells <dhowe...@redhat.com> Cc: Colin Ian King <colin.k...@canonical.com> Cc: Ingo Molnar <mi...@kernel.org> Cc: linzhang <xiaolou4...@gmail.com> Cc: netdev@vger.kernel.org Cc: linux-h...@vger.kernel.o

[PATCH v2 30/31] appletalk: Remove unneeded synchronization

2017-09-20 Thread Kees Cook
. Cc: David Howells <dhowe...@redhat.com> Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- drivers/net/appletalk/ltpc.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/appletalk/ltpc.c b/drivers/net/appletalk/ltpc.c index e4aa374caa4d..

[PATCH v2 19/31] timer: Remove open-coded casts for .data and .function

2017-09-20 Thread Kees Cook
ev@vger.kernel.org Cc: linux-s...@vger.kernel.org Cc: linuxppc-...@lists.ozlabs.org Signed-off-by: Kees Cook <keesc...@chromium.org> Acked-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> # for ibmvscsi --- drivers/scsi/ibmvscsi/ibmvfc.c | 14 ++ drivers/scsi/ibmvscsi/ibmvscsi.c

[PATCH v2 13/31] timer: Remove meaningless .data/.function assignments

2017-09-20 Thread Kees Cook
p.com> Cc: Ganesh Krishna <ganesh.kris...@microchip.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: Jens Axboe <ax...@fb.com> Cc: netdev@vger.kernel.org Cc: linux-wirel...@vger.kernel.org Cc: de...@driverdev.osuosl.org Signed-off-by: Kees Cook <keesc...@chromium.

[PATCH v2 25/31] net/atm/mpc: Use separate static data field with with static timer

2017-09-20 Thread Kees Cook
t;Reshetova, Elena" <elena.reshet...@intel.com> Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- net/atm/mpc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/atm/mpc.c b/net/atm/mpc.c index 63138c8c2269..3b59a053b7cb 10064

[PATCH v2 31/31] timer: Switch to testing for .function instead of .data

2017-09-20 Thread Kees Cook
t;hal.rosenst...@gmail.com> Cc: Dmitry Torokhov <dmitry.torok...@gmail.com> Cc: Jeff Kirsher <jeffrey.t.kirs...@intel.com> Cc: linux...@vger.kernel.org Cc: linux-r...@vger.kernel.org Cc: linux-in...@vger.kernel.org Cc: intel-wired-...@lists.osuosl.org Cc: netdev@vger.kernel.org Signed-off-b

Re: [PATCH v3 14/31] vxfs: Define usercopy region in vxfs_inode slab cache

2017-09-20 Thread Kees Cook
0-patch timer_list series. ;) Do you want me to resend the full series to you, or would you prefer something else like a patchwork bundle? (I'll explicitly add you to CC for any future versions, though.) -Kees -- Kees Cook Pixel Security

[PATCH v3 03/31] usercopy: Mark kmalloc caches as usercopy caches

2017-09-20 Thread Kees Cook
om> Cc: Andrew Morton <a...@linux-foundation.org> Cc: linux...@kvack.org Cc: linux-...@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- mm/slab.c| 3 ++- mm/slab.h| 3 ++- mm/slab_common.c | 10 ++ 3 files changed, 10 insertions(+), 6

[PATCH v3 04/31] dcache: Define usercopy region in dentry_cache slab cache

2017-09-20 Thread Kees Cook
Cc: Alexander Viro <v...@zeniv.linux.org.uk> Cc: linux-fsde...@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> --- fs/dcache.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index f90141387f01..5f5e7c1fcf4b 100644 --- a/fs/dcache.c +++

<    1   2   3   4   5   6   7   >