Remove some enums from the UAPI definition that were only used
internally and are NOT part of the UAPI.
Signed-off-by: Kevin Darbyshire-Bryant
---
include/net/tc_act/tc_ctinfo.h| 5 +
include/uapi/linux/tc_act/tc_ctinfo.h | 5 -
2 files changed, 5 insertions(+), 5 deletions
So even with this kernel fix to do
things correctly you still cannot instantiate a new 'strict'
nla_parse_nested based action such as act_ctinfo with iproute2's tc.
Signed-off-by: Kevin Darbyshire-Bryant
---
net/sched/act_ctinfo.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
validation before action creation.
As an inexperienced developer I've learned that
copy/pasting/backporting/forward porting code correctly is hard. If I
ever get to a developer conference I shall don the cone of shame.
Signed-off-by: Kevin Darbyshire-Bryant
---
net/sched/act_ctinfo.c | 1 +
1 file c
dation of
NLA_F_NESTED flag") and 8cb081746c03 ("netlink: make validation more
configurable for future strictness”) which led to the policy validation
fix, which then led to the action creation fix both contained in this
series.
If I ever get to a developer conference please feel free to
ta
Use extack error reporting mechanism in addition to returning -EINVAL
NL_SET_ERR_* code shamelessy copy/paste/adjusted from act_pedit &
sch_cake and used as reference as to what I should have done in the
first place.
Signed-off-by: Kevin Darbyshire-Bryant
---
net/sched/act_ctinfo.c
> On 11 Jun 2019, at 16:15, Paul Blakey wrote:
>
>
> On 6/11/2019 4:59 PM, Toke Høiland-Jørgensen wrote:
>> Paul Blakey writes:
>>
>>> Allow sending a packet to conntrack and set conntrack zone, mark,
>>> labels and nat parameters.
>> How is this different from the newly merged ctinfo action
Use extack error reporting mechanism in addition to returning -EINVAL
Signed-off-by: Kevin Darbyshire-Bryant
---
net/sched/act_ctinfo.c | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/net/sched/act_ctinfo.c b/net/sched/act_ctinfo.c
index e78b60e47c0f
tics:
+Sent 32890260 bytes 120441 pkt (dropped 0, overlimits 0 requeues 0)
+backlog 0b 0p requeues 0
+.br
+.SH SEE ALSO
+.BR tc (8),
+.BR tc-cake (8)
+.BR tc-connmark (8)
+.BR tc-mirred (8)
+.SH AUTHORS
+ctinfo was written by Kevin Darbyshire-Bryant.
diff --git a/tc/Makefile b/tc/Mak
is the bitmask to determine conditional restoring
cpmark MASK mask applied to restored packet mark
ZONE is the conntrack zone
CONTROL := reclassify | pipe | drop | continue | ok |
goto chain
Signed-off-by: Kevin Darbyshire-Bryant
Reviewed-by: Toke
is the bitmask to determine conditional restoring
cpmark MASK mask applied to restored packet mark
ZONE is the conntrack zone
CONTROL := reclassify | pipe | drop | continue | ok |
goto chain
Signed-off-by: Kevin Darbyshire-Bryant
---
v2 - fix whitespace
is the bitmask to determine conditional restoring
cpmark MASK mask applied to restored packet mark
ZONE is the conntrack zone
CONTROL := reclassify | pipe | drop | continue | ok |
goto chain
Signed-off-by: Kevin Darbyshire-Bryant
---
v2 - fix whitespace
> On 15 Jun 2018, at 21:57, David Woodhouse wrote:
>
>
>
> On Fri, 2018-06-15 at 20:49 +, Kevin Darbyshire-Bryant wrote:
>>
>>> That does end up being quite hairy. I don't think it's worth doing.
>>>
>>> This should probably suf
at needs to be killed with fire
> anyway. It's utterly pointless as discussed.
I had already done so as part of the last pastebin debug info round :-)
As regards your patch… MAGIC! Works an absolute treat. Will get that
submitted along with the ‘nuke ifx_atm_alloc_skb’ patch to OpenWrt
> On 23 May 2018, at 23:40, Toke Høiland-Jørgensen wrote:
>
>
> Hmm, and we still have an issue with ingress filtering (where cake is
> running on an ifb interface). That runs pre-NAT in the conntrack case,
> and we can't do the RX trick. Here we do the lookup manually in
> conntrack (and thi
> On 18 May 2018, at 05:27, Cong Wang wrote:
>
> On Thu, May 17, 2018 at 4:23 AM, Toke Høiland-Jørgensen wrote:
>> Eric Dumazet writes:
>>
>>> On 05/16/2018 01:29 PM, Toke Høiland-Jørgensen wrote:
The ACK filter is an optional feature of CAKE which is designed to improve
performanc
> On 30 Mar 2018, at 15:57, David Ahern wrote:
>
>
> My comment was to send separate patches - bug fix only for iproute2
> master and then a separate one for enhancements going to -next. If the
> enhancements overlap the bug fix then it needs to wait for the merge.
> This is really no differen
> On 29 Mar 2018, at 22:02, Stephen Hemminger
> wrote:
>
> On Thu, 29 Mar 2018 20:22:20 +0100
> Kevin Darbyshire-Bryant wrote:
>
>> print_int used 'int' type internally, whereas print_uint used 'uint64_t'
>>
>> These helper functio
> On 29 Mar 2018, at 22:03, Stephen Hemminger
> wrote:
>
> On Thu, 29 Mar 2018 20:32:10 +0100
> Kevin Darbyshire-Bryant wrote:
>
>> Introduce print helper functions for int, uint, explicit int32, uint32,
>> int64 & uint64.
>>
>> print_int used
> On 26 Mar 2018, at 16:03, David Ahern wrote:
>
> On 3/18/18 2:40 AM, Kevin Darbyshire-Bryant wrote:
>>
>>
>>> On 16 Mar 2018, at 20:34, Stephen Hemminger
>>> wrote:
>>>>
>>>> print_uint64(PRINT_ANY, "refcnt", "
teger sizes.
To portably use these formats you should use the relevant PRIdN or PRIuN
formats as defined in inttypes.h
e.g.
print_uint64(PRINT_ANY, "refcnt", "refcnt %" PRIu64 " ", t->tcm_info)
Signed-off-by: Kevin Darbyshire-Bryant
---
include/json_print.h
big endian
architectures where 'vfprintf' would be looking in the middle of an
int64 type.
print_u/int now stick with native int size.
Signed-off-by: Kevin Darbyshire-Bryant
---
include/json_print.h | 2 +-
lib/json_print.c | 2 +-
2 files changed, 2 insertions(+), 2 deletio
> On 16 Mar 2018, at 20:34, Stephen Hemminger
> wrote:
>>
>> print_uint64(PRINT_ANY, "refcnt", "refcnt %" PRIu64 " ", t->tcm_info)
>>
>> Signed-off-by: Kevin Darbyshire-Bryant
>
> I am fine with this. But since there is n
print_u/int32 & print
u/int64 functions offer explicit integer sizes.
To portably use these formats you should use the relevant PRIdN or PRIuN
formats as defined in inttypes.h
e.g.
print_uint64(PRINT_ANY, "refcnt", "refcnt %" PRIu64 " ", t->tcm_info)
Sig
On 06/05/16 10:42, Jesper Dangaard Brouer wrote:
> Hi Felix,
>
> This is an important fix for OpenWRT, please read!
>
> OpenWRT changed the default fq_codel sch->limit from 10240 to 1024,
> without also adjusting q->flows_cnt. Eric explains below that you must
> also adjust the buckets (q->flows
24 matches
Mail list logo
