Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/ixgb/ixgb_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
index 770eef2..b1cf852 100644
--- a/drivers/net/ixgb/ixgb_main.c
+++
After removing the hardware CRC stripping which causes problems with
SOL and related issues, we need to compensate for this changed size.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c | 10 +-
1 files
Bump the version to 7.1.9-k4 to indicate three extra changes.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index
A panic was reported when receiving 1522 size packets if using
the default MTU. we should set the initial rx buffer length to the
value that e1000changemtu sets so that we can receive any packet
that would not be dropped by LPE=0.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by:
Jeff,
Please pull the following patches from
git://lost.foo-projects.org/~ahkok/git/netdev-2.6 upstream-fixes-jgarzik
(based on 22e1170310ec6afa41e0dc7ac9dfac735d82dcab)
To receive the following fixes for e1000:
[01]: Redo netpoll fix
[02]: remove CRC bytes from measured packet length
[03]:
The original suggested fix for netpoll was found to be racy on SMP
kernels. While it is highly unlikely that this race would ever be seen
in the real world due to current netpoll usage models, we implemented
this updated fix to address concerns.
Signed-off-by: Mitch Williams [EMAIL PROTECTED]
Smart Power Down is a power saving feature in newer e1000 hardware. We
disable it because it causes time to link to be long, but make it a
user choice.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000.h |1 +
We can take uninitialized values into account which minimizes code
and allows us to simplify the parameter checking code greatly.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_param.c | 167
CRC stripping is breaking SMBUS-connected BMC's. We disable this
feature to make it work. This fixes related bugs regarding SOL.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |7 ++-
1 files changed, 6
e1000_suspend is called even when !CONFIG_PM. The non-PM code inside of it
is properly #ifdef'd. This fixes the compiler warnings when !CONFIG_PM.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |6 --
1
buffer_info is already filled at the end of this while() loop.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000/e1000_main.c
Ethtool was reporting that loopback failed randomly on esb2
systems. Upon study it was found that the phy manual was changed
with respect to the loopback mode bits. The new value fixes it.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
Hi,
A large number of e1000 patches this update, including the release of
the integrated NIC in the ICH8 motherboard chipset, which has been
officially released into the public. Also known as i965, the lan
chipset on this motherboard is fully supported by this driver.
The motherboard actually
In relation to the irq work done earlier we also move the PHY powerup
and powerdown functions into separate functions and move the calls to
_close and _open, making the PHY stay in it's power state as long as
the device is _up.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by:
A certain AMD64 bridge (8132) has an option to turn on write combining
which breaks our adapter. To circumvent this we need to flush every write.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_hw.c | 24
Several e1000 adapters were not blinking correctly or inconsistently. This
patch cleans this up and makes them all behave the same as far as possible.
Signed-off-by: Jeff Kirsher [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_ethtool.c | 15
After studying the driver mac reset code it was found that there
were multiple race conditions possible to reset the unit twice or
bring it e1000_up() double. This fixes all occurences where the
driver needs to reset the mac.
We also remove irq requesting/releasing into _open and _close so
that
Changing a printk message to make clear that this message is originating
from e1000.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
Recycle an skb to improve performance a bit.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000/e1000_main.c
This adds a private symbol to signify endianess in our driver.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_hw.h|2 +-
drivers/net/e1000/e1000_osdep.h |3 +++
2 files changed, 4 insertions(+), 1 deletions(-)
The workaround for the ich8 lock loss problem is only needed for
a very small amount of systems. This adds an option for the user
to disable the workaround.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_param.c | 21
M88 rev 2 PHY needs a longer downshift to function properly. This adds
a much longer downshift counter for this specific device.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_hw.c | 46
Hardware is reported to have problems with ERT. We disable it for
all hardware to make sure we are not seeing unexplainable user
problems.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |3 ---
1 files changed,
Increment the version to 7.1.9-k2
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000/e1000_main.c
We were not checking the return value of get_speed_and_duplex
properly, whih may contain an error value.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_hw.c |8 ++--
1 files changed, 6 insertions(+), 2
Add the device ID's of the supported ICH8 LAN devices.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/net/e1000/e1000_main.c
Netpoll was broken due to the earlier addition of multiqueue.
Signed-off-by: Mitch Williams [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git
Hi,
This patch series implements two e1000 fixes:
1: fix netpoll with NAPI
2: fix ARM prefetch failure by removing risky prefetches
These changes are available through git:
git://lost.foo-projects.org/~ahkok/git/netdev-2.6 upstream-fixes
these patches are against
netdev-2.6#upstream-fixes
It was brought to our attention that the prefetches break e1000 traffic
on xscale/arm architectures. Remove them for now. We'll let them
stay in mm for a while, or find a better solution to enable.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
There seemed to be another bug introduced as well as a performance hit
with the addtion of the sentinel descriptor workaround. Removal of
this workaround appears to prevent the hang. We'll take a risk
and remove it, as we had never seen the originally reported bug
under linux.
Signed-off-by:
In order to help correct window size growth, use the MFS register
to limit the packet sizes received and allocate only the buffer
size necessary
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
index
Hi,
Here are the ixgb driver updates for 1.0.109-k2. This corresponds with
the release of 1.0.109 on e1000.sf.net, and fixes several issues.
e1000 update will come soon...
Summary:
[1] fix smp polling race condition
[2] fix interface losing macaddr on ifdn/up
[3] revert an unwanted fix
Moved interrupt masking to before requesting the interrupt from the OS.
Moved interrupt enable to after netif_poll_enable. This fixes a racy
BUG() where polling would be running on another CPU at the same time
that netif_poll_enable would run.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
user contributed fix for LAA across down/up, from [EMAIL PROTECTED]
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/ixgb/ixgb_main.c |1 +
1 files changed, 1 insertions(+), 0
same as e1000 - remove the changelog from the driver code itself.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/ixgb/ixgb_main.c | 16
1 files changed, 0
deinline a few large functions as to allow the compiler to pick.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/ixgb/ixgb_main.c | 16
1 files changed, 8 insertions(+),
fix netdev-priv == netdev_priv(netdev)
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/ixgb/ixgb_ethtool.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git
increase the year dates to 2006 and bump the version to 1.0.109-k2
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/ixgb/Makefile |2 +-
drivers/net/ixgb/ixgb.h |2 +-
drivers/net/ixgb/ixgb_ee.c |2 +-
This mimics a change made in the e1000 driver that imitates a slick
tg3 way of avoiding grabbing the lock around restarting the tx queue.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
o modify the rx refill logic and tail bump
o add counter for failures
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/ixgb/ixgb.h |1 +
drivers/net/ixgb/ixgb_main.c | 74
o use rx copybreak/skb recycle
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/ixgb/ixgb_main.c | 20
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git
Hi,
This is a resend/updated set of patches for ixgb. They were originally
sent earlier on 2005-04-21 by Jeff Kirsher. Some modifications were made
after comments, and this series does not include 2 of the patches sent
at that time (I will resend those modified later).
Summary:
[1] fix rare
Make default flow control only have *sending* of flow control packets
enabled, and fix to disable / enable flow control correctly. Set flow
control defaults to disable receiving flow control from the link
partner, to fix the transmit fifo overlow errata
Signed-off-by: Jesse Brandeburg [EMAIL
Increment the driver version to 1.0.104-k2
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/ixgb/ixgb_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
This adds a TX timeout counter to the ethtool stats, a tx timeout
debug message, and sets the timer to 5 seconds.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/ixgb/ixgb.h |1
Fix rare early completion when using TSO. This essentially is the
e1000 fix, with code that was mostly already written. Another skb frag
was also needed.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
add NETIF_F_LLTX code like e1000 has
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/ixgb/ixgb_main.c | 31 +--
1 files changed, 29 insertions(+), 2
Use DPRINTK and msglvl, and ethtool to control it. Add proper names
to netdev structs and mappings.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/ixgb/ixgb.h |8 ++-
This adds a define for an awkward and uncommented value.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/ixgb/ixgb_ethtool.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
Removed duplicate code. Create ixgb_set_speed_duplex function to contain
duplicate code.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/ixgb/ixgb_ethtool.c | 35
This honours the request to remove the changelog in the driver code.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c | 39 ---
1 files changed, 0 insertions(+), 39 deletions(-)
diff --git a/drivers/net/e1000/e1000_main.c
Some leading and trailing whitespace made it into the driver code here.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_ethtool.c | 44 +--
drivers/net/e1000/e1000_hw.c | 88 +++--
drivers/net/e1000/e1000_hw.h
Hi,
These e1000 patches include a fix for WOL and some driver cleanups:
[1]: add shutdown handler back to fix WOL
[2]: remove backslash r debug printfs
[3]: remove leading and trailing whitespace.
[4]: Fix date string in Makefile
[5]: remove changelog in driver
[6]: bump version to 7.0.38-k4
This removes unwanted characters in the debug output that should have
never been there.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_hw.c | 24
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/net/e1000/e1000_hw.c
I forgot to update the date string in the Makefile last time.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/Makefile |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile
index 92823ac..5dea2b7 100644
Update skb with the real packet size.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git
Hi,
This patch was already merged in Jeff Garzik's netdev upstream branch but
needs to go into 12.6.16.y and 2.6.17rc* as it fixes a critical buffersize
skb bug that is exposed by an earlier patch by Dave Miller and Herbert
Xiu. I'm therefore resending it:
Please apply to 2.6.16.y and queue for
Hi,
This patch series implements two e100 fixes for an old and new patch mishap.
[1] fix mispatch for media type detect.
[2] fix mismerge skb_put.
These changes are available through git.
git://63.64.152.142/~ahkok/git/netdev-2.6 e1000-7.0.38-k2-fixes
these patches are against
Recent patch was mismerged in the miitool path. e1000_media_type_copper
was being compared with the phy type instead of the media type.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |2 +-
1 files changed, 1
Seems there was a bit of a fix needed to due a bad merge in the legacy
receive path. Fixes a panic due to skb_over_panic.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |3 +--
1 files changed, 1
Update skb with the real packet size.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git
De-inline functions to benefit from compiler smartness
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c | 30 +++---
1 files changed, 15
Hi,
This patch series implements two fixes, a series of cleanups and
two optimization patches.
The version of the driver was bumped to 7.0.38-k2. Year changes to 2006.
As I'm taking over patch duties from Jeff Kirsher, I added myself
to the MAINTAINERS file.
These changes are available
Esb2 link didn't return after wol disable. The code previously assumed
that writing reset to PHY_CTRL phy register turned the phy back on.
In the ESB2 phy case that didn't occur.
Add ESB2 to acquire/release_hw functions upon review it was
discovered that esb2 was skipped on these functions
Made an adapter struct variable into a local (txb2b)
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
drivers/net/e1000/e1000.h |1 -
drivers/net/e1000/e1000_main.c | 10 +-
2 files
remove DPRINTKs that were printing warnings about power management on
2.4 kernels. Since we really don't react differently these printk
statements are not needed. This code was originally added to fix
some compile time warnings that got fixed by newer kernels.
Signed-off-by: Jesse Brandeburg
Removal of unused rx_dropped counter.
Removed reference to E1000_CTRL_EXT_CANC which is no longer valid,
replaced with E1000_CTRL_EXT_INT_TIMER_CLR
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
Implement more efficient locking (avoid the lock) when checking for
a stopped queue. Also don't wake the queue unless the threshold is
reached to avoid queue on/off thrash.
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak
Remove multi-descriptor support from legacy recieve path
Add memory usage efficiency by using more correct size descriptors for
small MTU sizes and optimize using LPE for = 1522 byte frame sizes
An extra performance fix that effected our TCP window size growth
as a receiver. Set our initial
This adds Auke Kok to the list of maintainers for the Intel NICs.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
---
MAINTAINERS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index
401 - 470 of 470 matches
Mail list logo