[PATCH] staging: rtl8723bs: Fix incorrect sense of ether_addr_equal

ecvframe_attrib().") Cc: Stable Cc: youling257 Cc: u.srikant.patn...@gmail.com Reported-and-tested-by: youling257 Signed-off-by: Larry Finger --- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal

[PATCH v2 2/2] staging: rtl8712u: Fix compiler warning about strncpy

When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. Using strlcpy() rather than strncpy() forces a null at the end and quiets the warning. Signed-off-by: Larry Finger --- v2 - No changes. --- drivers/staging/rtl8712

[PATCH v2 0/2] staging: Fix some warnings from strncpy()

When the size argument in a call to strncpy() is the size of the destimation, gcc8 issues a warning. These patches fix the potential problem. Signed-off-by: Larry Finger v2 - The code is changed to implement the comments of David Laight. Larry Finger (2): staging: rtl8192e: Fix compiler

[PATCH v2 1/2] staging: rtl8192e: Fix compiler warning from strncpy()

When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. This section is completely reworked to use the known lengths of the strings. Signed-off-by: Larry Finger --- v2 - David Laight's comments are implemented

[PATCH 2/2] staging: rtl8712u: Fix compiler warning about strncpy

When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. Using strlcpy() rather than strncpy() forces a null at the end and quiets the warning. Signed-off-by: Larry Finger --- drivers/staging/rtl8712

[PATCH 1/2] staging: rtl8192e: Fix compiler warning about strncpy

When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. Using strlcpy() rather than strncpy() forces a null at the end and quiets the warning. Signed-off-by: Larry Finger --- drivers/staging/rtl8192e/rtllib_softmac.c

[PATCH 0/2] staging: Fix some warnings from strncpy()

When the size argument in a call to strncpy() is the size of the destimation, gcc8 issues a warning. These patches fix the potential problem by replacing the strncpy() with strlcpy(). Signed-off-by: Larry Finger Larry Finger (2): staging: rtl8192e: Fix compiler warning about strncpy

Re: RTL8723BE performance regression

On 04/03/2018 09:37 PM, João Paulo Rechi Vita wrote: On Tue, Apr 3, 2018 at 7:28 PM, Larry Finger <larry.fin...@lwfinger.net> wrote: (...) As the antenna selection code changes affected your first bisection, do you have one of those HP laptops with only one antenna and the incorrect

Re: RTL8723BE performance regression

On 04/03/2018 08:51 PM, João Paulo Rechi Vita wrote: Hello, I've been trying to track a performance regression on the RTL8723BE WiFi adapter, which mainly affects the upload bandwidth (although we can see a decreased download performance as well, the effect on upload is more drastic). This was

Re: [PATCH] rtlwifi: rtl8821ae: fix spelling mistake: "Aboslute" -> "Absolute"

--- 1 file changed, 8 insertions(+), 8 deletions(-) Acked-by: Larry Finger <larry.fin...@lwfinger.net?

Re: [RESEND PATCH] rsi: Remove stack VLA usage

On 03/11/2018 08:43 PM, Tobin C. Harding wrote: The kernel would like to have all stack VLA usage removed[1]. rsi uses a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size is defined using a magic number. We can use a pre-processor defined constant and declare the array to

[PATCH] rtl_bt: Add firmware and configuration files for the Bluetooth parts of RTL8821C and RTL8723D

These devices are new models from Realtek. Updates to driver btrtl will soon be submitted to the kernel. These files were provided by the Realtek developer. Signed-off-by: 陆朱伟 <alex...@realsil.com.cn> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- WHENCE

Re: [PATCH] rtlwifi: rtl8192cu: remove pointless memcpy

(u32)hdr->addr1[4], (u32)hdr->addr1[5]); - memcpy(IEEE80211_SKB_RXCB(skb), rx_status, sizeof(*rx_status)); ieee80211_rx(hw, skb); } Argh. Once again I got tripped up on pointers. Yes, this patch is correct. Acked-by: Larry Finger <larry.fin...@lwfinger.net> Sorry about the noise. Larry

Re: [PATCH] rtlwifi: rtl8192cu: remove pointless memcpy

On 02/09/2018 07:24 AM, Arnd Bergmann wrote: gcc-8 points out that source and destination of the memcpy() are always the same pointer, so the effect of memcpy() is undefined here (its arguments must not overlap): drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c: In function

Re: [PATCH v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

with the self-assignment. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v2: - Delete the 'else if' branch entirely drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c | 3 --- 1 file changed, 3 deletions(-) Acked-by: Larry Finger <larry.fin...@lwfinger.net>

Re: [PATCH] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

On 02/07/2018 02:26 PM, Matthias Kaehlcke wrote: In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal is assigned to itself in an if ... else statement, apparently only to document that the branch condition is handled and that a previously read value should be returned

Re: [PATCH] wireless: broadcom: radio_2056: delete duplicated macro definitions

On 01/08/2018 03:26 PM, Rasmus Villemoes wrote: Ctrl-V was hit twice when these macros were inserted: $ sed -n '9,527p' ./drivers/net/wireless/broadcom/b43/radio_2056.h | md5sum 4db53450c59d9939e903d4e4ba6bc9b1 - $ sed -n '528,1046p' ./drivers/net/wireless/broadcom/b43/radio_2056.h | md5sum

Re: [PATCH v2] b43: Replace mdelay with usleep_range in b43_radio_2057_init_post

mdelay with usleep_range, instead of msleep in v1. Thank Larry for good advice. --- I agree that a sleep of 2-3 ms should be OK here. Acked-by: Larry Finger <larry.fin...@lwfinger.net> Larry drivers/net/wireless/broadcom/b43/phy_n.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH][next] rtlwifi: btcoexist: remove redundant variable fw_ps_state

On 01/09/2018 10:43 AM, Colin King wrote: From: Colin Ian King <colin.k...@canonical.com> Variable fw_ps_state is assigned a value but it is never read, hence it is redundant and can be removed. Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, Larry Cleans up c

Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post

On 01/08/2018 10:21 AM, Kalle Valo wrote: Jia-Ju Bai wrote: b43_radio_2057_init_post is not called in an interrupt handler nor holding a spinlock. The function mdelay in it can be replaced with msleep, to reduce busy wait. Signed-off-by: Jia-Ju Bai

[PATCH] rtlwifi: rtl8723de: Add firmware for new driver/device

A driver for the RTL8723DE is nearing submission to staging. This commit supplies the firmware for it. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@realtek.com> --- WHENCE | 9 + rtlwifi/rtl8723defw.bin | Bin 0 ->

Re: [PATCH] b43: Replace mdelay with msleep in b43_radio_2057_init_post

On 12/30/2017 05:08 AM, Jia-Ju Bai wrote: b43_radio_2057_init_post is not called in an interrupt handler nor holding a spinlock. The function mdelay in it can be replaced with msleep, to reduce busy wait. Signed-off-by: Jia-Ju Bai checkpatch.pl reports the following

Re: [PATCH 1/1] rtlwifi: always initialize variables given to RT_TRACE()

f-by: Nicolas Iooss <nicolas.iooss_li...@m4x.org> Looks good. Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, Larry --- drivers/net/wireless/realtek/rtlwifi/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwi

[PATCH V2] staging: rtl8188eu: Fix incorrect response to SIOCGIWESSID

is not a wireless interface and therefore it fails to work correctly with it thereafter. This problem was reported and tested at https://github.com/lwfinger/rtl8188eu/issues/234. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- v2 - completed missing subject drivers/staging/rtl

[PATCH] staging: rtl8188eu:

is not a wireless interface and therefore it fails to work correctly with it thereafter. This problem was reported and tested at https://github.com/lwfinger/rtl8188eu/issues/234. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.

Re: [PATCH 1/3] rtlwifi: fix uninitialized rtlhal->last_suspend_sec time

nd_sec is not all that important, but it does get used, so we probably want the patch backported to stable kernels. Cc: sta...@vger.kernel.org Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82839 Signed-off-by: Arnd Bergmann <a...@arndb.de> For all three of these patches: Acked-by: Larry Finge

Re: [PATCH] rtlwifi: remove redundant initialization to cfg_cmd

reless/realtek/rtlwifi/core.c:1750:22: warning: Value stored to 'cfg_cmd' during its initialization is never read Signed-off-by: Colin Ian King <colin.k...@canonical.com> Looks OK to me. Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, Larry --- drivers/net/wirele

[PATCH] rtlwifi: Fix typo in if ... else if ... else construct

The kbuild test robot reports two conditions with no effect (if == else). These are the result of copy and paste typographical errors. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@realtek.com> Cc: Yan-Hsuan Chuang <yhchu...@realtek.com> Cc:

[PATCH] staging: rtl8822be: Keep array subscript no lower than zero

vel]); This condition is caused when a loop falls through. The fix is to pin max_level to be >= 0. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> c: kbuild test robot <fengguang...@intel.com> Fixes: 9ce99b04b5b82fdf11e4c76b60a5f82c1e541297 staging: r8822be: Add

Re: RTL8192EE PCIe Wireless Network Adapter crashed with linux-4.13

On 09/21/2017 06:37 AM, Zwindl wrote: Hi, I've reported to archlinux's bugzilla, and finally found out the flag which caused that issue, it's the `CONFIG_INTEL_IOMMU_DEFAULT_ON=y` flag, I think may this is a kernel bug, more details at https://bugs.archlinux.org/task/55665 My standard kernel

Re: RTL8192EE PCIe Wireless Network Adapter crashed with linux-4.13

On 09/16/2017 06:27 AM, Zwindl wrote: Hi, I've done the test, and the weird thing happened. The kernel buit with this config file https://ptpb.pw/HF1g which is from https://aur.archlinux.org/packages/linux-git/  can run properly, the wifi can connect, despite which version it is, but, with

Re: RTL8192EE PCIe Wireless Network Adapter crashed with linux-4.13

On 09/15/2017 12:12 PM, Zwindl wrote: Thanks for your patient and advice, I'll keep that in mind. I do want help, and I got 1 day to build the system, but I can't recall how to compile it, The last time I compile kernel is 2013, so, maybe I'll ask you so many stupid questions during the build

Re: RTL8192EE PCIe Wireless Network Adapter crashed with linux-4.13

On 09/15/2017 05:10 AM, Zwindl wrote: Original Message Subject: Re: RTL8192EE PCIe Wireless Network Adapter crashed with linux-4.13 Local Time: 14 September 2017 6:05 PM UTC Time: 14 September 2017 18:05 From: larry.fin...@lwfinger.net To: Zwindl ,

Re: RTL8192EE PCIe Wireless Network Adapter crashed with linux-4.13

On 09/14/2017 08:30 AM, Zwindl wrote: Dear developers: I'm using Arch Linux with testing enabled, the current kernel version and details are `Linux zwindl 4.13.2-1-ARCH #1 SMP PREEMPT Thu Sep 14 02:57:34 UTC 2017 x86_64 GNU/Linux`. The wireless card can't work properly from the kernel 4.13.

Re: [PATCH] rtlwifi: refactor code in halbtcoutsrc module

On 08/30/2017 11:46 AM, Gustavo A. R. Silva wrote: Function halbtc_get_wifi_rssi always returns rtlpriv->dm.undec_sm_pwdb. So this function can be removed and the value of rtlpriv->dm.undec_sm_pwdb assigned to *s32_tmp directly. This issue was first reported by Coverity as "identical code for

Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1226788 Signed-off-by: Gustavo A. R. Silva --- This issue was reported

Re: [PATCH] rtlwifi: rtl8723be: fix duplicated code for different branches

On 08/30/2017 12:04 PM, Gustavo A. R. Silva wrote: Refactor code in order to avoid identical code for different branches. Addresses-Coverity-ID: 1248728 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> According to Realtek, this change is OK. Acked-by: Larry Finger <

[PATCH 0/2] staging: r8822be: Remove some left-over debug code

Some useless debugging code from the initial writing of the driver was not removed before it was submitted. That oversight is now fixed and the remaining code in routine deinit_priv() is simplified. Larry Larry Finger (2): staging: r8822be: Remove some dead code staging: r8822be: Simplify

[PATCH 1/2] staging: r8822be: Remove some dead code

The code found inside an #ifdef CONFIG_RTL_DEBUG ... #endif section is left over from debugging of the original driver, and should be deleted. Reported by: Andreas Ziegler <andreas.zieg...@fau.de> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@

[PATCH 2/2] staging: r8822be: Simplify deinit_priv()

Now that the extraneous debugging code is removed, routine deinit_priv() clearly contains code that serves no useful purpose. A null test before a call to kfree() and a spurious cast are also removed. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@re

Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1226788 Signed-off-by: Gustavo A. R. Silva --- This issue was reported

Re: [PATCH] staging: r8822be: Fix typo for CONFIG_RTLWIFI_DEBUG

On 08/30/2017 02:58 AM, Andreas Ziegler wrote: Indeed, sorry I missed that as well. So what should we make of that #ifdef? The code inside it doesn't compile (anymore? I didn't find any development history for that patch except the original mail), as there is no definition of struct submit_ctx

Re: [PATCH] staging: r8822be: Fix typo for CONFIG_RTLWIFI_DEBUG

On 08/29/2017 06:30 AM, Andreas Ziegler wrote: The debugging output in deinit_priv is guarded by an #ifdef using CONFIG_RTL_DEBUG. This symbol does not exist and should be CONFIG_RTLWIFI_DEBUG instead. Signed-off-by: Andreas Ziegler NACK. Yes, there is a problem;

[PATCH] rtlwifi: rtl8822be: Add firmware for new driver/device

A driver for the RTL8822BE has been added to staging. This commit supplies the firmware for it. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- WHENCE | 9 + rtlwifi/rtl8822befw.bin | Bin 0 -> 127496 bytes 2 files changed, 9 insertions(+) cr

Re: [PATCH] staging: rtlwifi: Improve debugging by using debugfs

On 08/24/2017 08:54 PM, Andrew Lunn wrote: netdev frowns upon debugfs. You should try to keep this altogether, making it easy to throw away before the driver is moved out of staging. You might want to look at ethtool -d. That will be accepted. Andrew, What is the problem with debugfs?

[PATCH] staging: rtlwifi: Improve debugging by using debugfs

common status. 2. remove obsolete field bt_exist Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Yan-Hsuan Chuang <yhchu...@realtek.com> Cc: Birming Chiu <birm...@realtek.com> Cc: Shaofu <sha...@realtek.co

Re: Thoughts on staging and on fixing up drivers?

On 08/17/2017 04:07 PM, tedheadster wrote: Larry, you've migrated a bunch of staging code, and tried various approaches. Do you have any lessons on what has worked and what hasn't and if there is anything we can do to make the process better? I am also quite interested in such work. We asked

[PATCH 8/8] staging: rtlwifi: Reviewers fixes

This commit adds the TODO file and implements some reviewers comments made against some patches to the wireless tree. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@realtek.com> Cc: Yan-Hsuan Chuang <yhchu...@realtek.com> Cc: Birming Chiu <bi

[PATCH 7/8] staging: r8822be: Add Makefiles and Kconfig for new driver

into a single module r8822be. When this driver is moved to the wireless tree, halmac, phydm, and rtl8822be will become new modules. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@realtek.com> Cc: Yan-Hsuan Chuang <yhchu...@realtek.com> Cc:

[PATCH 2/8] staging: r8822be: Copy existing btcoexist code into staging

. There are no changes other than removing all EXPORT statements, and the fixing of checkpatch messages. The latter will be backported to the wireless tree. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@realtek.com> Cc: Yan-Hsuan Chuang <yhchu...@realtek.c

[PATCH 0/8] staging: Add new driver for RTL8822BE

the code into the main wireless tree in small pieces. To minimize interference between the rtlwifi drivers in the wireless tree and this new driver, the new one can only be built as a module. In addition, all code is built into a single module. Larry Finger Signed-off-by: Larry Finger <larry.

Re: [PATCH 33/35] wireless: realtek: rtl8192cu: constify usb_device_id

Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, Larry drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192c

Re: [PATCH] rtlwifi: remove useless code

ged, 6 deletions(-) Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, Larry

Re: [PATCH 01/11] rtlwifi: rtl8192de: constify pci_device_id.

dav...@gmail.com> Acked-by: Larry Finger <larry.fin...@lwfinger.net> This applies to all 11. Thanks, Larry

Re: [PATCH 0/5] rtlwifi: Neatening

On 06/19/2017 03:18 PM, Joe Perches wrote: Joe Perches (5): rtlwifi: Use temporary ops variable to reduce code size rtlwifi: Use temporary variable btc_ops for rtlpriv->btcoexist.btc_ops rtlwifi: Add and use convenience macro rtl_btc realtek: btcoexist: Make the rtl_btc_ops struct

Re: [PATCH] rtlwifi: rtl8821ae: remove unused variable

On 06/13/2017 03:42 PM, Gustavo A. R. Silva wrote: Remove unused variable rtlhal. Addresses-Coverity-ID: 1248810 Signed-off-by: Gustavo A. R. Silva --- NACK!! That variable is used in file core.c in driver rtlwifi, which is loaded and used by rtl8821ae. Please do

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

On 06/01/2017 11:11 AM, Jonathan Corbet wrote: On Thu, 01 Jun 2017 09:05:07 +0800 Jia-Ju Bai wrote: I admit my patches are not well tested, and they may not well fix the bugs. I am looking forward to opinions and suggestions :) May I politely suggest that sending out

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

) will use mutex instead. Signed-off-by: Michael Buesch <m...@bu3sch.de> Tested-by: Larry Finger <larry.fin...@lwfinger.net> Signed-off-by: John W. Linville <linvi...@tuxdriver.com> I vaguely remember this patch. Although it is roughly a 1000-line fix, I will try to p

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

On 05/31/2017 05:29 AM, Jia-Ju Bai wrote: The driver may sleep under a spin lock, and the function call path is: b43legacy_attr_interfmode_store (acquire the lock by spin_lock_irqsave) b43legacy_radio_set_interference_mitigation b43legacy_radio_interference_mitigation_disable

Re: [net-realtek-btcoexist] question about identical code for different branches

On 05/17/2017 04:52 PM, Gustavo A. R. Silva wrote: Hello everybody, While looking into Coverity ID 1362263 I ran into the following piece of code at drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1000: 1000void exhalbtc_set_ant_num(struct rtl_priv *rtlpriv, u8 type, u8

Re: 4.10.9 nok with realtek wlan, atom

On 04/16/2017 01:09 PM, rupert THURNER wrote: On Sun, Apr 16, 2017 at 6:02 PM, Larry Finger <larry.fin...@lwfinger.net> wrote: On 04/16/2017 05:23 AM, rupert THURNER wrote: On Sat, Apr 15, 2017 at 10:40 PM, Larry Finger <larry.fin...@lwfinger.net> wrote: On 04/14/2017 03:2

Re: 4.10.9 nok with realtek wlan, atom

On 04/16/2017 05:23 AM, rupert THURNER wrote: On Sat, Apr 15, 2017 at 10:40 PM, Larry Finger <larry.fin...@lwfinger.net> wrote: On 04/14/2017 03:26 PM, rupert THURNER wrote: On Thu, Feb 9, 2017 at 9:09 PM, Larry Finger <larry.fin...@lwfinger.net> wrote: On 02/09/2017 01:43 PM, B

Re: 4.10.9 nok with realtek wlan, atom

On 04/14/2017 03:26 PM, rupert THURNER wrote: On Thu, Feb 9, 2017 at 9:09 PM, Larry Finger <larry.fin...@lwfinger.net> wrote: On 02/09/2017 01:43 PM, Bjorn Helgaas wrote: [+cc rtl8192ce folks in case they've seen this] On Thu, Feb 09, 2017 at 03:45:01PM +0100, rupert THURNER wrote

[PATCH] rtl_bt: Update firmware for BT part of rtl8822be

These files were supplied by Realtek. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- WHENCE | 3 ++- rtl_bt/rtl8822b_config.bin | Bin 32 -> 14 bytes rtl_bt/rtl8822b_fw.bin | Bin 51756 -> 51176 bytes 3 files changed, 2 insertions(+), 1 delet

Re: [PATCH] net: rfkill: gpio: Add OBDA8723 ACPI HID

On 04/09/2017 07:11 AM, Marcel Holtmann wrote: Hi Hans, The OBDA8723 ACPI HID is used on quite a few Bay Trail based tablets for bluetooth rfkill functionality. Tested-by: russianneuroman...@ya.ru Signed-off-by: Hans de Goede ---

Re: [PATCH 06/22] staging: rtl8723bs: Fix various errors in os_dep/ioctl_cfg80211.c

On 04/09/2017 10:28 AM, Bastien Nocera wrote: On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote: Smatch lists the following: CHECK drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:470 rtw_cfg80211_ibss_indicate_connect() error: we

[PATCH 20/22] staging rtl8723bs: Fix indenting errors and an off-by-one mistake in core/rtw_mlme_ext.c

hanges. The error at line 1595 was the result of an off-by-one error in a for loop. The error at line 4969 was not fixed as that code lies inside a block of code that only is needed for 5G channels. This chip only works at 2.4 GHz. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- dri

[PATCH 19/22] staging: rtl8723bs: Fix white-space errors in core/rtw_recv.c

/rtw_recv.c:1547 validate_recv_frame() warn: inconsistent indenting Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/core/rtw_recv.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8723b

[PATCH 13/22] staging: rtl8723bs: Fix indenting mistake in core/rtw_ap.c

Smatch reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_ap.c drivers/staging/rtl8723bs/core/rtw_ap.c:382 expire_timeout_chk() warn: inconsistent indenting Fixing this requires changing the indentatikon of a long for loop. Signed-off-by: Larry Finger <larry.

[PATCH 21/22] staging: rtl8723bs: Fix indenting problems in core/rtw_odm.c

-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/core/rtw_odm.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_odm.c b/drivers/staging/rtl8723bs/core/rtw_odm.c index 5bc573386ad1..3144e8ec2fa2

[PATCH 15/22] staging: rtl8723bs: Fix indenting mistakes in core/rtw_mlme.c

All of there are simple white-space errors. A typo is also fixed. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 37 +++ 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723b

[PATCH 17/22] staging: rtl8723bs: Fix indenting problem in core/rtw_sta_mgt.c

Sparse reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_sta_mgt.c drivers/staging/rtl8723bs/core/rtw_sta_mgt.c:25 _rtw_init_stainfo() warn: inconsistent indenting This problem is fixed with a white-spcae change. Signed-off-by: Larry Finger <larry.fin...@lwfinger.

[PATCH 16/22] staging: rtl8723bs: Fix some indenting problems and a potential data overrun

drivers/staging/rtl8723bs/core/rtw_wlan_util.c:815 rtw_camid_alloc() warn: should '1 << (cam_id)' be a 64 bit type? The first two are fixed with white-space changes. The third is fixed by restricting cam_id to be less than 32. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net>

[PATCH 18/22] staging: rtl8723bs: Fix some white-space errors in core/rtw_security.c

:1809 aes_decipher() warn: inconsistent indenting All of the above are fixed with white-space changes. A few unneeded blank lines are deleted. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/core/rtw_security.c | 469 +-

[PATCH 22/22] staging: rtl8723bs: Fix indenting error in core/rtw_pwrctrl.c

Smatch reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_pwrctrl.c drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:641 LeaveAllPowerSaveModeDirect() warn: inconsistent indenting Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723b

[PATCH 07/22] staging: rtl8723bs: Fix potential usage while NULL error in hal/rtl8723b_hal_init.c

from this routine. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723

[PATCH 10/22] staging: rtl8723bs: Fix indenting problem for hal/hal_com.c

Smatch lists the following: CHECK drivers/staging/rtl8723bs/hal/hal_com_phycfg.c drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2090 Hal_ChannelPlanToRegulation() warn: inconsistent indenting Fixed by changing the white space. Signed-off-by: Larry Finger <larry.fin...@lwfinger.

[PATCH 14/22] staging: rtl8723bs: Fix indenting mistakes in core/rtw_ieee80211.c

not indented These warnings are fixed with white-space changes. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723b

[PATCH 09/22] staging: rtl8723bs: Fix indening problem in hal/hal_com_phycfg.c

Smatch reports the following: CHECK drivers/staging/rtl8723bs/hal/hal_com_phycfg.c drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2090 Hal_ChannelPlanToRegulation() warn: inconsistent indenting This warning is fixed with a white-space change. Signed-off-by: Larry Finger <larry.

[PATCH 05/22] staging: rtl8723bs: Fix indenting mistake in os_dep/mlme_linux.c

Smatch reports the following warning: CHECK drivers/staging/rtl8723bs/os_dep/mlme_linux.c drivers/staging/rtl8723bs/os_dep/mlme_linux.c:149 rtw_os_indicate_disconnect() warn: inconsistent indenting Again, a simple change in the white space fixes this problem. Signed-off-by: Larry Finger

[PATCH 12/22] staging: rtl8723bs: Fix possible usage of NULL pointer in core/rtw_debug.c

: variable dereferenced before check 'phead' (see line 454) In the code, there are two successive calls to get_head(). The second is removed. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/core/rtw_debug.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH 06/22] staging: rtl8723bs: Fix various errors in os_dep/ioctl_cfg80211.c

ould be null required an immediate exit from the routine at that point. A similar fix was required where 'skb' could be null. The two buffer overflow errors were caused by off-by-one errors. While locating these problems, another one was found in os_dep/ioctl_linux.c. Signed-off-by: Larry Finge

[PATCH 08/22] staging: rtl8723bs: Fix indenting problems in hal/HalHWImg8723B_BB.c

ODM_ReadAndConfig_MP_8723B_PHY_REG() warn: for statement not indented drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c:586 ODM_ReadAndConfig_MP_8723B_PHY_REG() warn: inconsistent indenting These were all fixed with white-space changes. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723

[PATCH 11/22] staging: rtl8723bs: Fix indenting problems in core/rtw_xmit.c

/rtl8723bs/core/rtw_xmit.c:295 _rtw_free_xmit_priv() warn: inconsistent indenting drivers/staging/rtl8723bs/core/rtw_xmit.c:946 xmitframe_addmic() warn: inconsistent indenting These are fixed with white-space changes. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/s

[PATCH 01/22] staging: rtl8723bs: Fix indenting warning in os_dep/xmit_linux.c

Smatch issues the warning CHECK drivers/staging/rtl8723bs/os_dep/xmit_linux.c drivers/staging/rtl8723bs/os_dep/xmit_linux.c:42 _rtw_pktfile_read() warn: inconsistent indenting A simple indent changes fixes this. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/s

[PATCH 02/22] staging: rtl8723bs: Fix indenting warning in os_dep/rtw_proc.c

Smatch lists the following warning: CHECK drivers/staging/rtl8723bs/os_dep/rtw_proc.c drivers/staging/rtl8723bs/os_dep/rtw_proc.c:102 rtw_drv_proc_open() warn: inconsistent indenting This warning is fixed with a simple change in the white space. Signed-off-by: Larry Finger <larry.

[PATCH 03/22] staging: rtl8723bs: Fix dereference before check warning in os_dep/recv_linux.c

. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c index c677a5

[PATCH 04/22] staging: rtl8723bs: Fix indenting warning in os_dep/os_intfs.c

Smatch logs the following warning: CHECK drivers/staging/rtl8723bs/os_dep/os_intfs.c drivers/staging/rtl8723bs/os_dep/os_intfs.c:1082 ips_netdrv_open() warn: inconsistent indenting A simple change in the white space handles this warning. Signed-off-by: Larry Finger <larry.

[PATCH 00/22] staging: rtl87232bs: Fix errors and warnings detected by Smatch

A number of routines have indenting, off by one, and possible usage while null warnings or errors listed by Smatch. This set of patches fix all but one of these, and it is in code that will be removed in a subsequent patch. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Larry

Re: [PATCH][V2] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "though"

1 insertion(+), 1 deletion(-) Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, Larry diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c index de98d88..dcb5d83 100644 --- a/drivers/net/wireless/realtek/rtlwi

Re: [PATCH] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "although"

On 02/26/2017 09:19 AM, Colin King wrote: From: Colin Ian King trivial fix to spelling mistake in RT_TRACE message Signed-off-by: Colin Ian King Bad fix. It should be althougth => through. Please read the context. NACK. Larry ---

Re: [PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling s/wrtie_addr/write_addr/

On 02/17/2017 10:19 AM, Geert Uytterhoeven wrote: Hi Larry, On Fri, Feb 17, 2017 at 5:14 PM, Larry Finger <larry.fin...@lwfinger.net> wrote: On 02/17/2017 09:36 AM, Geert Uytterhoeven wrote: As per symmetry with _rtl8821ae_dbi_read(), "wrtie" is not a funky register acron

Re: [PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling s/wrtie_addr/write_addr/

On 02/17/2017 09:36 AM, Geert Uytterhoeven wrote: As per symmetry with _rtl8821ae_dbi_read(), "wrtie" is not a funky register acronym, but a simple misspelling of "write". Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Cc: Larry Finger <larry.fin...@

Re: [PATCH 6/7] staging: r8712u: Fix Sparse warnings in rtl871x_ioctl_linux.c

On 02/13/2017 05:27 AM, David Laight wrote: From: Larry Finger Sent: 11 February 2017 03:30 Sparse reports the following: CHECK drivers/staging/rtl8712/rtl871x_ioctl_linux.c drivers/staging/rtl8712/rtl871x_ioctl_linux.c:1422:46: warning: restricted __le16 degrades to integer drivers

Re: [PATCH] rtlwifi: btcoexist: fix semicolon.cocci warnings

On 02/09/2017 02:12 PM, Julia Lawall wrote: Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Larry Finger <larry.fin...@lwfinger.net> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com>

[PATCH 3/7] staging: r8712u: Fix macros used to read/write the TX/RX descriptors

Although the driver works on big-endian hardware, Sparse generates a lot of warnings. Many of these are the result of incorrect coding of these macros. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8712/wifi.h | 109 --

[PATCH 7/7] staging: r8712u: Fix Sparse warnings in rtl871x_mlme.c

] cap_info drivers/staging/rtl8712/rtl871x_mlme.c:1712:35:got int Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8712/rtl871x_mlme.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/d

[PATCH 1/7] staging: rtl8712: Fix some Sparse endian messages

: warning: cast from restricted __le32 Each of these cases is transferring a quantity that is little-endian. There is no need for conversion. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8712/rtl8712_xmit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

[PATCH 2/7] staging: rtl8712u: Fix endian settings for structs describing network packets

The headers describing a number of network packets do not have the correct endian settings for several types of data. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8712/ieee80211.h | 84 ++--- 1 file changed, 42 insertions(

[PATCH 4/7] staging: r8712u: Fix Sparse warning in rtl871x_xmit.c

/rtl871x_xmit.c:580:36:expected unsigned short [unsigned] [short] [usertype] drivers/staging/rtl8712/rtl871x_xmit.c:580:36:got restricted __be16 [usertype] Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8712/rtl871x_xmit.c | 7 --- 1 file changed, 4 inse

  1   2   3   4   5   >