David Miller írta:
From: Laszlo Attila Toth <[EMAIL PROTECTED]>
Date: Fri, 1 Feb 2008 17:07:33 +0100
The do_setlink() function is protected by rtnl, additional locks are
unnecessary.
and the set_operstate() function is called from protected parts. Locks removed
from both functions
implies address
change, some programs may expect the original notification. It remains
for compatibity.
If set_operstate() is called from do_setlink(), it doesn't send
a notification, only if it is called from rtnl_create_link() as earlier.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]&g
implies address
change, some programs may expect the original notification. It remains
for compatibity.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
net/core/rtnetlink.c | 27 ---
1 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/net/core/rtnet
of the changes is protected by set_lock_bh() except
inside set_operstate(), different locking scheme is not necessary
for the operstate.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
net/core/rtnetlink.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git
Hi Dave,
These two patches remove unnecessary locks from rtnetlink, it was managed in
an inconsistent way, and change notification. The latter is always sent
if anything is changed but for compatibility the old nofification is also kept.
Regards,
Attila
--
To unsubscribe from this list: send
A userspace program may wish to set the mark for each packets its send
without using the netfilter MARK target. Changing the mark can be used
for mark based routing without netfilter or for packet filtering.
It requires CAP_NET_ADMIN capability.
Signed-off-by: Laszlo Attila Toth <[EM
A userspace program may wish to set the mark for each packets its send
without using the netfilter MARK target. Changing the mark can be used
mark based routing without netfilter or for packet filtering.
It requires CAP_NET_ADMIN capability.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTEC
David Miller wrote:
Over the past day I've put together the following set of bug fixes for
the Cassini driver.
At least with my setup it appears to basically work fine, not leak
memory, and the SKB BUG messages go away too.
I'll be honest and say that I've devoted a couple days to this work,
an
implies address change, some programs
may
expect the original notification. It remains for compatibity.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
net/core/rtnetlink.c | 27 ---
1 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/ne
Interfaces can be grouped and each group has an unique positive integer ID.
It can be set via ip link. Symbolic names can be specified in
/etc/iproute2/rt_ifgroup. Any value of unsigned int32 is valid.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h
of the changes is protected by set_lock_bh() except
inside set_operstate(), different locking scheme is not necessary
for the operstate.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
net/core/rtnetlink.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git
Hello,
we got the following message:
SKB BUG: Invalid truesize (376) len=514, sizeof(sk_buff)=248
It only occurs on larger traffic (at speed 100 Mbps: always), but not
when downloading a small web page.
In cas_rx_process_pkt() the the skb's truesize is only set via skb_put()
but it is not us
Laszlo Attila Toth wrote:
When we use cassini driver without VLANs, it works as expected but when
about 100 VLANs are configured on this interface, the hardware checksum
fails.
I tried it that I "disable" the checksum on the hardver side, in fact, I
used CHECKSUM_NONE instead of C
Jarek Poplawski írta:
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
The do_setlink function is protected by rtnl, additional locks are unnecessary,
and the set_operstate() function is called from protected parts. Locks removed
from both functions.
It doesn't look like in accordance
Jarek Poplawski írta:
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
In do_setlink() a single ntification is sent at the end of the function
if any modification occured. If the address has been changed, another
notification is sent.
...
@@ -858,6 +859,7 @@ static int do_setlink(struct
Patrick McHardy írta:
Laszlo Attila Toth wrote:
Hello,
This is the 7th version of our interface group patches.
Patches:
[1/5] Remove unnecessary locks from rtnetlink (in do_setlink)
[2/5] rtnetlink: send a single notification on device state changes
[3/5] Interface group: core (netlink
Patrick McHardy írta:
Laszlo Attila Toth wrote:
Lutz Jaenicke írta:
On Tue, Nov 20, 2007 at 02:14:28PM +0100, Laszlo Attila Toth wrote:
Interface group values can be checked on both input and output
interfaces
with optional mask.
Index: extensions/libxt_ifgroup.c
Interface group values can be checked on both input and output interfaces
with optional mask.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
extensions/Makefile |2
extensions/libxt_ifgroup.c | 201 +++
exte
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
diff --git a/include/linux/if_link.h b/include/linux/if_link.h
index 23b3a8e..c948395 100644
--- a/include/linux/if_link.h
+++ b/include/linux/if_link.h
@@ -78,6 +78,7 @@ enum
IFLA_LINKMODE,
IFLA_LINKINFO,
#
The ifgroup member of each net device can be read and changed in sysfs.
Author: Lutz Jaenicke <[EMAIL PROTECTED]>
---
net/core/net-sysfs.c | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 61ead1d..5bd6d35 10
Interfaces can be grouped and each group has an unique positive integer ID.
It can be set via ip link. Symbolic names can be specified in
/etc/iproute2/rt_ifgroup. Any value of unsigned int32 is valid.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
diff --git a/include/linux/if_li
The do_setlink function is protected by rtnl, additional locks are unnecessary,
and the set_operstate() function is called from protected parts. Locks removed
from both functions.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
net/core/rtnetlink.c |4
1 files chan
Interface groups let handle different interfaces together.
Modified net device structure and netlink interface.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |2 ++
include/linux/netdevice.h |2 ++
net/core/rtnetlink.c | 11
Interface group values can be checked on both input and output interfaces.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/netfilter/xt_ifgroup.h | 17 +
net/netfilter/Kconfig| 10 +++
net/netfilter/Makefile |1
net/net
In do_setlink() a single ntification is sent at the end of the function
if any modification occured. If the address has been changed, another
notification is sent.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
net/core/rtnetlink.c | 27 ---
1 files c
dev&m=119556459514598&w=2
--
Laszlo Attila Toth
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Lutz Jaenicke írta:
On Tue, Nov 20, 2007 at 02:14:28PM +0100, Laszlo Attila Toth wrote:
Interface group values can be checked on both input and output interfaces
with optional mask.
Index: extensions/libxt_ifgroup.c
Hello,
When we use cassini driver without VLANs, it works as expected but when
about 100 VLANs are configured on this interface, the hardware checksum
fails.
What is its reason or how can we debug it?
--
Attila
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body o
David Miller írta:
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed, 21 Nov 2007 01:25:54 +0100
I'm working on the incremental ruleset changing API BTW :)
One of the changes will be that interface matching is not
a default part of every rule, and without wildcards it will
use the ifindex. Bu
Jan Engelhardt írta:
On Nov 20 2007 14:14, Laszlo Attila Toth wrote:
This is the 6th version of our interface group patches.
The interface group value can be used to manage different interfaces
at the same time such as in netfilter/iptables.
I take it you could not use...?
iptables
Interfaces can be grouped and each group has an unique positive integer ID.
It can be set via ip link. Symbolic names can be specified in
/etc/iproute2/rt_ifgroup.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |2 +
include/rt_names.h |2
Interface group values can be checked on both input and output interfaces
with optional mask.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
extensions/Makefile |2
extensions/libxt_ifgroup.c | 201 +++
exte
Interface group values can be checked on both input and output interfaces.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/netfilter/xt_ifgroup.h | 17 +
net/netfilter/Kconfig| 10 +++
net/netfilter/Makefile |1 +
net/net
[2/3] Interface group: core (netlink) part
[3/3] Netfilter Interface group match
[iptables]Interface group match
[iproute 1/2] Added IFLA_NET_NS_PID as in kernel v2.6.24-rc1
[iproute 2/2] Interface group as new ip link optio
--
Laszlo Attila Toth
-
To unsubscribe from this list: send the line &quo
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/if_link.h b/include/linux/if_link.h
index 23b3a8e..c948395 100644
--- a/include/linux/if_link.h
+++ b/include/linux/if_
Interface groups let handle different interfaces together.
Modified net device structure and netlink interface.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |2 ++
include/linux/netdevice.h |2 ++
net/core/rtnetlink.c | 11
In do_setlink the device changes don't need to be protected. Notification
is sent at the end of the function once if any modification occured
and once if an address has been changed.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
net/core/rtnetli
Interface group values can be checked on both input and output interfaces.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/netfilter/xt_ifgroup.h | 18 +
net/netfilter/Kconfig| 16 +
net/netfilter/Makefile |1 +
net/net
Interface groups let handle different interfaces together
especially in netfilter modules.
Modified net device structure and netlink interface.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |2 ++
include/linux/netdevice.h |2 ++
net/core/rtnet
Interface group values can be checked on both input and output interfaces
with optional mask.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
Makefile |2
libip6t_ifgroup.man | 36 +++
libipt_ifgroup.man | 36 +++
libxt_ifg
Interfaces can be grouped and each group has an unique positive integer ID.
It can be set via ip link. Symbolic names can be specified in
/etc/iproute2/rt_ifgroup.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |2 +
include/rt_names.h |2
In do_setlink the device changes don't need to be protected. Notification
is sent at the end of the function once if any modification occured
and once if an address has been changed.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
net/core/rtnetli
ingle notification
[2/3] Interface group: core (netlink) part
[3/3] Netfilter Interface group match
[iptables] Interface group match
[iproute 1/2] Added IFLA_NET_NS_PID as in kernel v2.6.24-rc1
[iproute 2/2] Interface group as new ip link option
--
Laszlo Attila Toth
-
To unsubscribe from this list: sen
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/if_link.h b/include/linux/if_link.h
index 23b3a8e..c948395 100644
--- a/include/linux/if_link.h
+++ b/include/linux/if_
Patrick McHardy írta:
Laszlo Attila Toth wrote:
Interface groups let handle different interfaces together
especially in netfilter modules.
Modified net device structure and netlink interface.
@@ -891,6 +895,13 @@ static int do_setlink(struct net_device *dev,
struct ifinfomsg *ifm
Interface group values can be checked on both input and output interfaces
with optional mask.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
Makefile |2
libip6t_ifgroup.man | 36 +++
libipt_ifgroup.man | 36 +++
libxt_ifg
Interface group values can be checked on both input and output interfaces.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/netfilter/xt_ifgroup.h | 18 +
net/netfilter/Kconfig| 16 +
net/netfilter/Makefile |1 +
net/net
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/if_link.h b/include/linux/if_link.h
index 23b3a8e..c948395 100644
--- a/include/linux/if_link.h
+++ b/include/linux/if_
Interface groups let handle different interfaces together
especially in netfilter modules.
Modified net device structure and netlink interface.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |2 ++
include/linux/netdevice.h |2 ++
net/core/rtnet
Interfaces can be grouped and each group has an unique positive integer ID.
It can be set via ip link. Symbolic names can be specified in
/etc/iproute2/rt_ifgroup.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |2 +
include/rt_names.h |2
In do_setlink the device changes are atomic and notifications will be sent
at the end of the function once if any modification occured and once if
address has been changed.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
net/core/rtnetlink.c | 34 ---
Hi Dave,
This is the 4th version of our interface group patches. The only difference
from the previous one is in the first patch (single notification and atomic
changes in rtnetlink) plus in iptables code: parameter in-ifgroup changed to
ifgroup-in (and ifgroup-out).
I had to add IFLA_NET_NS_PID
In do_setlink the device changes are atomic and notifications will be sent
at the end of the function once if any modification occured and once if
address has been changed.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
net/core/rtnetlink.c | 23 ---
1
Interfaces can be grouped and each group has an unique positive integer ID.
It can be set via ip link. Symbolic names can be specified in
/etc/iproute2/rt_ifgroup.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |2 +
include/rt_names.h |2
Interface group values can be checked on both input and output interfaces.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/netfilter/xt_ifgroup.h | 18 +
net/netfilter/Kconfig| 16 +
net/netfilter/Makefile |1 +
net/net
Matching ifgroup value of incoming and/or outgoing interface.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
extensions/Makefile |2 +-
extensions/libip6t_ifgroup.man | 36 +++
extensions/libipt_ifgroup.man| 36 +++
exte
Interface groups let handle different interfaces together
especially in netfilter modules.
Modified net device structure and netlink interface.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |2 ++
include/linux/netdevice.h |2 ++
net/core/rtnet
Hello,
This is the 3rd version of interface group patches.
Each net_device structure has a non-negative ifgroup member indicating
the group it belongs to. In the ip tool it is between 0 and 256 where
0 means it is unset.
Usage:
ip link set eth0 group 4
ip lonk set eth0 group 0# to
Patrick McHardy írta:
Laszlo Attila Toth wrote:
@@ -846,6 +850,12 @@ static int do_setlink(struct net_device *dev,
struct ifinfomsg *ifm,
write_unlock_bh(&dev_base_lock);
}
+if (tb[IFLA_IFGROUP]) {
+write_lock_bh(&dev_base_lock);
+dev->ifgroup =
Patrick McHardy írta:
Laszlo Attila Toth wrote:
Hello,
Here is the new version of ifgroup patches.
The interface group value is u_int32_t in net_device which should be
enough.
Previously it was an int.
Usage:
ip link set eth0 group 4
but currently it cannot be unset, only changed to
group value should be
matched
(with optional masks).
The following patches are:
kernel: core part
kernel: netfilter module, ifgroup match
iproute2: showing and set ifgroup value
iptables: ifgroup match
--
Laszlo Attila Toth
-
To unsubscribe from this list: send the line "unsubscribe n
Interface group values can be checked on both input and output interfaces.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/netfilter/xt_ifgroup.h | 18 ++
net/netfilter/Kconfig| 16 +
net/netfilter/Makefile |1 +
net/net
Interfaces can be grouped and each group has an unique positive integer ID.
It can be set via ip link. Symbolic names can be specified in
/etc/iproute2/rt_ifgroup.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |2 +
include/rt_names.h |2
Matching ifgroup value of incoming and/or outgoing interface.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
extensions/Makefile |2 +-
extensions/libip6t_ifgroup.man | 36 +++
extensions/libipt_ifgroup.man| 36 +++
exte
Interface groups let handle different interfaces together
especially in netfilter modules.
Modified net device structure and netlink interface.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |2 ++
include/linux/netdevice.h |2 ++
net/core/rtnet
Patrick McHardy írta:
Laszlo Attila Toth wrote:
+static int match(const struct sk_buff *skb,
+ const struct net_device *in,
+ const struct net_device *out,
+ const struct xt_match *match,
+ const void *matchinfo,
+ int offset,
+ unsigned int protoff,
+ int
jamal írta:
On Tue, 2007-16-10 at 13:05 +0200, Laszlo Attila Toth wrote:
That sounds great but for what whould you like to use? It may help me
for the implementation.
For example i may want to add a tc rule to a group of interfaces.
tc BNF roughly looks like:
tc
Where targe is :=
It may
jamal írta:
On Tue, 2007-16-10 at 11:03 +0200, Laszlo Attila Toth wrote:
Interfaces can be grouped and each group has an unique positive integer ID.
It can be set via ip link.
Feature request: Can you also implement a get operation. Perhaps
something that returns from the kernel a list of
Philip Craig írta:
Laszlo Attila Toth wrote:
Hello,
Different network interfaces can be grouped using the same group ID. With this
patch fewer netfilter rules are necessary but it may also be used by routing.
This allows an interface to belong to only one group. I expect there are
Patrick McHardy írta:
Laszlo Attila Toth wrote:
+static int match(const struct sk_buff *skb,
+ const struct net_device *in,
+ const struct net_device *out,
+ const struct xt_match *match,
+ const void *matchinfo,
+ int offset,
+ unsigned int protoff,
+ int
Patrick McHardy írta:
Laszlo Attila Toth wrote:
diff --git a/man/man8/ip.8 b/man/man8/ip.8
index c74440a..8e6a9a3 100644
--- a/man/man8/ip.8
+++ b/man/man8/ip.8
@@ -511,6 +511,11 @@ already configured.
@@ -1835,3 +1840,6 @@ was written by Alexey N. Kuznetsov and added in
Linux 2.2.
.SH
Interfaces can be grouped and each group has an unique positive integer ID.
It can be set via ip link.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |2 +
include/rt_names.h |2 +
ip/ipaddress.c |4 +++
ip/iplink.c
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/netfilter/xt_ifgroup.h | 11 +
net/netfilter/Kconfig| 16 +++
net/netfilter/Makefile |1 +
net/netfilter/xt_ifgroup.c | 78 ++
4
Interfaces can be grouped and each group has an unique positive integer ID.
It can be set via ip link.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED](none)>
---
include/linux/if_link.h |2 +
include/rt_names.h |2 +
ip/ipaddress.c |4 +++
ip/ip
'ifgroup' netfilter match.
ip link set eth0 group 4
iptables -A INPUT -m ifgroup --if-group 4 -j ACCEPT
--
Laszlo Attila Toth
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.
Interface groups let handle different interfaces with one (netfilter) rule.
Modified net device structure and netlink interface.
Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]>
---
include/linux/if_link.h |2 ++
include/linux/netdevice.h |2 ++
net/core/rtnetlink.c
76 matches
Mail list logo
