Re: [PATCH net-next] net: dsa: Simplify dsa_slave_phy_setup()

2017-10-26 Thread Martin Hundebøll
On 2017-10-26 18:45, Florian Fainelli wrote: On 10/26/2017 04:07 AM, Martin Hundebøll wrote: On 2017-10-26 02:32, Florian Fainelli wrote: Remove the code that tried to identify if a PHY designated by Device Tree required diversion through the DSA-created MDIO bus. This was created mainly

Re: [PATCH net-next] net: dsa: Simplify dsa_slave_phy_setup()

2017-10-26 Thread Martin Hundebøll
461cd1b03e32 ("net: dsa: bcm_sf2: Register our slave MDIO bus"). Signed-off-by: Florian Fainelli<f.faine...@gmail.com> Tested-by: Martin Hundebøll <m...@prevas.dk> Thanks, Martin

Re: [net-next] dsa: slave: support phy devices on external MII bus

2017-10-18 Thread Martin Hundebøll
On 2017-10-18 18:51, Florian Fainelli wrote: On 10/18/2017 09:21 AM, Andrew Lunn wrote: Hi Martin Sorry for starting a new thread. I deleted the patchset from my mailbox. Florian said: The logic goes like this: - try to connect to the PHY via phy-handle - if we have a PHY we are

Re: [PATCH net-next] dsa: slave: support phy devices on external MII bus

2017-10-16 Thread Martin Hundebøll
On 2017-10-16 14:32, Andrew Lunn wrote: So this used to work. I have a 10G phy connected to the external MII bus on a 6390. I wonder when this got broken? Supporting phy-handle is old code, so when i added the external MII i don't think i needed to change any generic code. It could look like

Re: [PATCH net-next] dsa: slave: support phy devices on external MII bus

2017-10-16 Thread Martin Hundebøll
On 2017-10-16 14:32, Andrew Lunn wrote: On Mon, Oct 16, 2017 at 12:45:25PM +0200, Martin Hundebøll wrote: When configuring a switch port to use an external phy, the phy is connected to external switch MII bus: So this is a 6390? 6390X So this used to work. I have a 10G phy connected

Re: [PATCH net-next] dsa: slave: support phy devices on external MII bus

2017-10-16 Thread Martin Hundebøll
Hi Andrew, On 2017-10-16 14:40, Andrew Lunn wrote: /* internal MII */ mdio { switch0phy1@1 { reg = <1>; }; }; /* external MII */ mdio1 { switch0phy0: switch0phy0@0 { reg = <0>; }; Hi Martin You are

[PATCH net-next] dsa: slave: support phy devices on external MII bus

2017-10-16 Thread Martin Hundebøll
085 f1072004.mdio-mii:02: Failed to create slave 0: -19 Fix this by using the phy of-handle to obtain a reference to the parent mdio_bus, which is then used to connect the phy. Signed-off-by: Martin Hundebøll <m...@prevas.dk> --- net/dsa/slave.c | 13 + 1 file changed, 9 ins

[PATCH] net: dsa: mv88e6xxx: Enable CMODE config support for 6390X

2017-07-19 Thread Martin Hundebøll
mode() to the .port_set_cmode function pointer in mv88e6390x_ops too. Signed-off-by: Martin Hundebøll <m...@prevas.dk> --- drivers/net/dsa/mv88e6xxx/chip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 947ea352a57a..7f