Re: [PATCH net v2 0/3] Bugfix for the netsec driver

2018-10-23 Thread Masahisa Kojima
Hi Florian, Ard, Yes, that is my mistake. Thank you very much for pointing out, Ard. On Tue, 23 Oct 2018 at 20:32, Ard Biesheuvel wrote: > > (+ Florian) > > On 23 October 2018 at 08:24, wrote: > > From: Masahisa Kojima > > > > This patch series include

[PATCH net v2 3/3] net: socionext: Reset tx queue in ndo_stop

2018-10-23 Thread masahisa . kojima
From: Masahisa Kojima We observed that packets and bytes count are not reset when user performs interface down. Eventually, tx queue is exhausted and packets will not be sent out. To avoid this problem, resets tx queue in ndo_stop. Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer N

[PATCH net v2 1/3] net: socionext: Stop PHY before resetting netsec

2018-10-23 Thread masahisa . kojima
From: Masahisa Kojima In ndo_stop, driver resets the netsec ethernet controller IP. When the netsec IP is reset, HW running mode turns to NRM mode and driver has to wait until this mode transition completes. But mode transition to NRM will not complete if the PHY is in normal operation state

[PATCH net v2 2/3] net: socionext: Add dummy PHY register read in phy_write()

2018-10-23 Thread masahisa . kojima
From: Masahisa Kojima There is a compatibility issue between RTL8211E implemented in Developerbox and netsec ethernet controller IP. Our MDIO controller stops MDC clock right after the write access, but RTL8211E expects MDC clock must be kept toggling for several clock cycle with MDIO high

[PATCH net v2 0/3] Bugfix for the netsec driver

2018-10-23 Thread masahisa . kojima
From: Masahisa Kojima This patch series include bugfix for the netsec ethernet controller driver, fix the problem in interface down/up. changes in v2: - change the place to perform the PHY power down - use the MACROs defiend in include/uapi/linux/mii.h - update commit comment Masahisa

Re: [PATCH 2/3] net: socionext: Add dummy PHY register read in phy_write()

2018-10-19 Thread Masahisa Kojima
On Fri, 19 Oct 2018 at 12:01, Florian Fainelli wrote: > > > > On 10/18/2018 6:08 PM, masahisa.koj...@linaro.org wrote: > > From: Masahisa Kojima > > > > There is a compatibility issue between RTL8211E implemented > > in Developerbox and netsec network cont

Re: [PATCH 1/3] net: socionext: Stop PHY before resetting netsec

2018-10-19 Thread Masahisa Kojima
down is not proper. I will consider the right place to do. On Fri, 19 Oct 2018 at 11:59, Florian Fainelli wrote: > > > > On 10/18/2018 6:08 PM, masahisa.koj...@linaro.org wrote: > > From: Masahisa Kojima > > > > After resetting netsec IP, driver have to wait unti

[PATCH 2/3] net: socionext: Add dummy PHY register read in phy_write()

2018-10-18 Thread masahisa . kojima
From: Masahisa Kojima There is a compatibility issue between RTL8211E implemented in Developerbox and netsec network controller IP(F_GMAC4). RTL8211E expects MDC clock must be kept toggling for several clock cycle with MDIO high before entering the IDLE state. To meet this requirement, netsec

[PATCH 3/3] net: socionext: Reset tx queue in ndo_stop

2018-10-18 Thread masahisa . kojima
From: Masahisa Kojima Without resetting tx queue in ndo_stop, packets and bytes count are not reset when the interface is down. Eventually, tx queue is exhausted and packets will not be sent out. Signed-off-by: Masahisa Kojima Signed-off-by: Yoshitoyo Osaki --- drivers/net/ethernet/socionext

[PATCH 1/3] net: socionext: Stop PHY before resetting netsec

2018-10-18 Thread masahisa . kojima
From: Masahisa Kojima After resetting netsec IP, driver have to wait until netsec mode turns to NRM mode. But sometimes mode transition to NRM will not complete if the PHY is in normal operation state. To avoid this situation, stop PHY before resetting netsec. Signed-off-by: Masahisa Kojima

[PATCH 0/3] Bugfix for the netsec driver

2018-10-18 Thread masahisa . kojima
From: Masahisa Kojima This patch series include bugfix for the netsec ethernet controller driver, fix the problem in interface down/up. Masahisa Kojima (3): net: socionext: stop PHY before resetting netsec net: socionext: Add dummy PHY register read in phy_write() net: socionext: reset tx