[PATCH] net: hns: Fix ethtool private flags

The driver implementation returns support for private flags, while no private flags are present. When asked for the number of private flags it returns the number of statistic flag names. Fix this by returning EOPNOTSUPP for not implemented ethtool flags. Signed-off-by: Matthias Brugger <mb

Re: [PATCH] net: ethernet: mediatek: add NULL check on of_match_device() return value

On 07/07/2017 09:11 AM, Gustavo A. R. Silva wrote: Check return value from call to of_match_device() in order to prevent a NULL pointer dereference. In case of NULL print error message and return -ENODEV Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- Reviewed-by: Ma

Re: [PATCH net-next v5 1/2] net: hns: support deferred probe when can not obtain irq

driver. So we need to support deferred probe. Signed-off-by: lipeng <lipeng...@huawei.com> Reviewed-by: Yisen Zhuang <yisen.zhu...@huawei.com> Reviewed-by: Matthias Brugger <mbrug...@suse.com> Looks good now, so you can keep my Reviewed-by. --- change log: V4 -> V5: 1. Floa

Re: [PATCH net v4 1/3] net: hns: support deferred probe when can not obtain irq

driver. So we need to support deferred probe. Signed-off-by: lipeng <lipeng...@huawei.com> Reviewed-by: Yisen Zhuang <yisen.zhu...@huawei.com> Reviewed-by: Matthias Brugger <mbrug...@suse.com> --- change log: V3 -> V4: 1. Delete redundant commit message; 2. add Reviewed-

Re: [PATCH net v3 2/3] net: hns: support deferred probe when no mdio

probe deferral in the mac init, so we not init DSAF when there is no mdio, and free all resource, to later learn that we need to defer the probe. Signed-off-by: lipeng <lipeng...@huawei.com> Reviewed-by: Yisen Zhuang <yisen.zhu...@huawei.com> Reviewed-by: Matthias Brugger

Re: [PATCH net v3 1/3] net: hns: support deferred probe when can not obtain irq

driver. So we need to support deferred probe. We check for probe deferral in the hw layer probe, so we not probe into the main layer and memories, etc., to later learn that we need to defer the probe. This paragraph does not hold any more and should be deleted. Other then this: Reviewed-by: Ma

Re: [PATCH net v2 1/3] net: hns: support deferred probe when can not obtain irq

On 24/04/17 13:43, lipeng (Y) wrote: On 2017/4/24 18:28, Matthias Brugger wrote: On 21/04/17 09:44, Yankejian wrote: From: lipeng <lipeng...@huawei.com> In the hip06 and hip07 SoCs, the interrupt lines from the DSAF controllers are connected to mbigen hw module. The mbigen

Re: [PATCH net v2 1/3] net: hns: support deferred probe when can not obtain irq

On 21/04/17 09:44, Yankejian wrote: From: lipeng In the hip06 and hip07 SoCs, the interrupt lines from the DSAF controllers are connected to mbigen hw module. The mbigen module is probed with module_init, and, as such, is not guaranteed to probe before the HNS driver. So

Re: [PATCH net-next 2/3] net: hns: support deferred probe when no mdio

On 18/04/17 12:12, Yankejian wrote: From: lipeng In the hip06 and hip07 SoCs, phy connect to mdio bus.The mdio module is probed with module_init, and, as such, is not guaranteed to probe before the HNS driver. So we need to support deferred probe. We check for probe

Re: [PATCH 1/2] Documentation: devicetree: change the mediatek ethernet compatible string

com> Signed-off-by: John Crispin <j...@phrozen.org> --- sounds reasonable to me: Reviewed-by: Matthias Brugger <matthias@gmail.com> Documentation/devicetree/bindings/net/mediatek-net.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/d

Re: [PATCH 0/5] net: thunderx: Miscellaneous fixes

On 11/14/2016 06:32 PM, David Miller wrote: From: Matthias Brugger <mbrug...@suse.com> Date: Mon, 14 Nov 2016 13:01:25 +0100 On 14/11/16 11:54, sunil.kovv...@gmail.com wrote: From: Sunil Goutham <sgout...@cavium.com> This patchset includes fixes for incorrect LMAC credits

Re: [PATCH 0/5] net: thunderx: Miscellaneous fixes

On 14/11/16 11:54, sunil.kovv...@gmail.com wrote: From: Sunil Goutham This patchset includes fixes for incorrect LMAC credits, unreliable driver statistics, memory leak upon interface down e.t.c Are these fixes relevant to for older kernels as well? If so, please add

Re: [PATCH v3 2/5] drivers: net: xgene: Backward compatibility with older firmware

;toa...@apm.com> Tested-by: Matthias Brugger <mbrug...@suse.com> --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 60 +++- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 165 +++--- drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 2 + driver

Re: [PATCH v3 3/5] drivers: net: phy: Add MDIO driver

and SGMII based 1G interfaces, so adding this driver to manage MDIO bus. This driver registers the mdio bus and registers the PHYs connected to it. Signed-off-by: Iyappan Subramanian <isubraman...@apm.com> Tested-by: Fushen Chen <fc...@apm.com> Tested-by: Toan Le <toa...@apm.com> T

Re: [PATCH v3 1/5] drivers: net: xgene: MAC and PHY configuration changes

sed on pdata->mdio_driver flag Signed-off-by: Iyappan Subramanian <isubraman...@apm.com> Tested-by: Fushen Chen <fc...@apm.com> Tested-by: Toan Le <toa...@apm.com> Tested-by: Matthias Brugger <mbrug...@suse.com> --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 190 ++

Re: [PATCH v1 5/6] dtb: xgene: Remove clock nodes

On 27/05/16 09:22, Iyappan Subramanian wrote: Since the MDIO will be responsible for clock reset, removing the clock nodes from shadowcat xge0 and storm sgenet1. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le

Re: [PATCH v1 1/6] drivers: net: xgene: MAC and PHY configuration changes

On 27/05/16 09:22, Iyappan Subramanian wrote: This patch fixes MAC configuration to support 10/100GbE for SGMII and link_state call back. It also sets pdata->mdio_driver flag based on ethernet mdio subnode and prepare for MDIO driver support. In summary, following are the changes, - Added

Re: [PATCH v1 0/6] drivers: net: xgene: Fix 1G hot-plug and module support

d both issues are fixed, so you can add Tested-by: Matthias Brugger <mbrug...@suse.com> But I think the way the series is split in different patches is not correct. Patch 1 on its own won't compile and get fixed in patch 2. Although I think backward compatibility to older firmware sh

[PATCH] drivers: net: xgene: Fix error handling

When probe bails out with an error, we try to unregister the netdev before we have even registered it. Fix the goto statements for that. Signed-off-by: Matthias Brugger <mbrug...@suse.com> --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 7 --- 1 file changed, 4 insertions

Re: [PATCH] net: mediatek: fix checking for NULL instead of IS_ERR() in .probe

polskiy <v...@mleia.com> --- Reviewed-by: Matthias Brugger <mbrug...@suse.com> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c