[PATCH net-next 00/14] bnxt_en: Updates for net-next.

of VF MAC address, and a better parent switchdev ID for dual-port devices. Michael Chan (11): bnxt_en: Update firmware interface to 1.9.0. bnxt_en: Refactor bnxt_close_nic(). bnxt_en: Restore MSIX after disabling SRIOV. bnxt_en: Refactor hardware resource data structures. bnxt_en: Add

Re: [PATCH] bnxt_en: don't update cpr->rx_bytes with uninitialized length len

a8788f25625 ("bnxt_en: add support for software dynamic interrupt > moderation") > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks. Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH][next] bnxt_en: ensure len is ininitialized to zero

On Fri, Jan 12, 2018 at 9:46 AM, Colin King wrote: > From: Colin Ian King > > In the case where cmp_type == CMP_TYPE_RX_L2_TPA_START_CMP the > exit return path is via label next_rx_no_prod and cpr->rx_bytes > is being updated by an

Re: [PATCH net-next v3 09/10] bnxt_en: add support for software dynamic interrupt moderation

tional counters in the receive path, but testing shows > that any additional instructions are offset by throughput gain when the > default configuration is for low latency. > > Signed-off-by: Andy Gospodarek <go...@broadcom.com> > Cc: Michael Chan <mc...@broadcom.com> Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH net-next v2 09/10] bnxt_en: add support for software dynamic interrupt moderation

On Fri, Jan 5, 2018 at 2:58 PM, Andy Gospodarek wrote: > @@ -5705,7 +5748,13 @@ static void bnxt_enable_napi(struct bnxt *bp) > int i; > > for (i = 0; i < bp->cp_nr_rings; i++) { > + struct bnxt_cp_ring_info *cpr = >bnapi[i]->cp_ring; >

Re: [bpf-next V4 PATCH 07/14] bnxt_en: setup xdp_rxq_info

gs. > > Tested on actual hardware. > > Cc: Andy Gospodarek <a...@greyhouse.net> > Cc: Michael Chan <michael.c...@broadcom.com> > Signed-off-by: Jesper Dangaard Brouer <bro...@redhat.com> Looks good, thanks. Just one comment below. > --- > drivers/net/

[PATCH net 0/2] bnxt_en: 2 small bug fixes.

The first one fixes the TC Flower flow parameter passed to firmware. The 2nd one fixes the VF index range checking for iproute2 SRIOV related commands. Sunil Challa (1): bnxt_en: Fix population of flow_type in bnxt_hwrm_cfa_flow_alloc() Venkat Duvvuru (1): bnxt_en: Fix the 'Invalid VF' id

[PATCH net 2/2] bnxt_en: Fix the 'Invalid VF' id check in bnxt_vf_ndo_prep routine.

nvalid pointer. Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.") Signed-off-by: Venkat Devvuru <venkatkumar.duvv...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 2 +- 1 file change

[PATCH net 1/2] bnxt_en: Fix population of flow_type in bnxt_hwrm_cfa_flow_alloc()

ds") Signed-off-by: Sunil Challa <sunilkumar.cha...@broadcom.com> Reviewed-by: Sathya Perla <sathya.pe...@broadcom.com> Reviewed-by: Venkat Duvvuru <venkatkumar.duvv...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadc

Re: [net-next 09/10] bnxt_en: add support for software dynamic interrupt moderation

tional counters in the receive path, but testing shows > that any additional instructions are offset by throughput gain when the > default configuration is for low latency. > > Signed-off-by: Andy Gospodarek <go...@broadcom.com> > Cc: Michael Chan <mc...@broadcom.com> Andy

Re: [PATCH net-next v5 0/5] Introduce NETIF_F_GRO_HW

On Fri, Dec 29, 2017 at 7:12 AM, Alexander Duyck wrote: > On Fri, Dec 29, 2017 at 4:43 AM, Sabrina Dubroca wrote: >> 2017-12-22, 10:14:32 -0800, Alexander Duyck wrote: >>> On Fri, Dec 22, 2017 at 6:57 AM, Sabrina Dubroca

[PATCH net-next] net: Clarify dev_weight documentation for LRO and GRO_HW.

Reported-by: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- Documentation/sysctl/net.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/sysctl/net.txt b/Documentation/sysctl/n

Re: [PATCH net-next v5 0/5] Introduce NETIF_F_GRO_HW

On Tue, Dec 19, 2017 at 11:04 AM, Marcelo Ricardo Leitner wrote: > Can we clarify on the meaning/expectations of dev_weight? The > documentation currently says: > The maximum number of packets that kernel can handle on a NAPI > interrupt, it's a Per-CPU variable. > > I

[PATCH net-next v5 5/5] qede: Use NETIF_F_GRO_HW.

ior <ariel.el...@cavium.com> Cc: everest-linux...@cavium.com Acked-by: Manish Chopra <manish.cho...@cavium.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/qlogic/qede/qede.h | 2 ++ drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 3 +++

[PATCH net-next v5 4/5] bnx2x: Use NETIF_F_GRO_HW.

disable_tpa will continue to disable LRO and GRO_HW. Preserve the original behavior of enabling LRO by default. User has to run ethtool -K to explicitly enable GRO_HW. Cc: Ariel Elior <ariel.el...@cavium.com> Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan <michael.c...@bro

[PATCH net-next v5 1/5] net: Introduce NETIF_F_GRO_HW.

if we decide to propagate GRO/ GRO_HW/RXCSUM from upper to lower devices. Cc: Ariel Elior <ariel.el...@cavium.com> Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- Documentation/networking/netdev-features.txt | 9 + include/linux/netde

[PATCH net-next v5 2/5] net: Disable GRO_HW when generic XDP is installed on a device.

Hardware should not aggregate any packets when generic XDP is installed. Cc: Ariel Elior <ariel.el...@cavium.com> Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- net/core/dev.c | 18 ++ 1 file changed, 18 insertions(+) diff

[PATCH net-next v5 3/5] bnxt_en: Use NETIF_F_GRO_HW.

aggregation. During chip init, turn on or off hardware GRO based on NETIF_F_GRO_HW in features flag. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-)

[PATCH net-next v5 0/5] Introduce NETIF_F_GRO_HW

. - Use ndo_fix_features() on all 3 drivers to drop GRO_HW when it is not supported Michael Chan (5): net: Introduce NETIF_F_GRO_HW. net: Disable GRO_HW when generic XDP is installed on a device. bnxt_en: Use NETIF_F_GRO_HW. bnx2x: Use NETIF_F_GRO_HW. qede: Use NETIF_F_GRO_HW. Documentation

Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.

On Thu, Dec 14, 2017 at 11:07 PM, Chopra, Manish wrote: > Michael, I checked it on again, I tried to set LRO in dev->features and > dev->hw_features. > Somehow, it gets disabled after register_netdevice(). Any idea why ? > Although, I am not running any

Re: [PATCH net-next v4 0/5] Introduce NETIF_F_GRO_HW

On Thu, Dec 14, 2017 at 8:34 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Mon, Dec 11, 2017 at 1:41 PM, Michael Chan <michael.c...@broadcom.com> > wrote: >> Introduce NETIF_F_GRO_HW feature flag and convert drivers that support >> hardware GRO to use the new f

Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.

On Wed, Dec 13, 2017 at 11:46 PM, Chopra, Manish wrote: > > 2). In bnx2x_fix_features() we used to do before these changes - > > /* TPA requires Rx CSUM offloading */ > if (!(features & NETIF_F_RXCSUM)) { > features &= ~NETIF_F_LRO; >

Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.

On Wed, Dec 13, 2017 at 1:08 AM, Chopra, Manish wrote: > > Hi Michael, There seems a behavioral change here. This driver support two HW > aggregation modes [LRO and GRO] > With the changes, Interfaces come with HW GRO enabled and LRO disabled by > default as opposed

[PATCH net-next v4 5/5] qede: Use NETIF_F_GRO_HW.

ior <ariel.el...@cavium.com> Cc: everest-linux...@cavium.com Acked-by: Manish Chopra <manish.cho...@cavium.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/qlogic/qede/qede.h | 2 ++ drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 3 +++

[PATCH net-next v4 3/5] bnxt_en: Use NETIF_F_GRO_HW.

aggregation. During chip init, turn on or off hardware GRO based on NETIF_F_GRO_HW in features flag. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-)

[PATCH net-next v4 0/5] Introduce NETIF_F_GRO_HW

). - NETIF_F_GRO_HW depends on NETIF_F_GRO and NETIF_F_RXCSUM. - Add dev_disable_gro_hw() to disable GRO_HW for generic XDP. - Use ndo_fix_features() on all 3 drivers to drop GRO_HW when it is not supported Michael Chan (5): net: Introduce NETIF_F_GRO_HW. net: Disable GRO_HW when generic XDP is installed

[PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.

<ariel.el...@cavium.com> Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 19 --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 4 +++- 2 files changed, 15 insertions(+),

[PATCH net-next v4 1/5] net: Introduce NETIF_F_GRO_HW.

if we decide to propagate GRO/ GRO_HW/RXCSUM from upper to lower devices. Cc: Ariel Elior <ariel.el...@cavium.com> Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- Documentation/networking/netdev-features.txt | 8 include/linux/netde

[PATCH net-next v4 2/5] net: Disable GRO_HW when generic XDP is installed on a device.

Hardware should not aggregate any packets when generic XDP is installed. Cc: Ariel Elior <ariel.el...@cavium.com> Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- net/core/dev.c | 18 ++ 1 file changed, 18 insertions(+) diff

Re: [PATCH net-next v3 1/5] net: Introduce NETIF_F_GRO_HW.

On Sun, Dec 10, 2017 at 9:02 AM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Sat, Dec 9, 2017 at 10:40 PM, Michael Chan <michael.c...@broadcom.com> > wrote: >> It is possible that if you have incoming packets 1, 2, 3, 4, 5 for a >> TCP connection, HW_GRO

Re: [PATCH net-next v3 2/5] net: Disable GRO_HW when generic XDP is installed on a device.

On Sat, Dec 9, 2017 at 2:37 PM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Sat, Dec 9, 2017 at 1:40 PM, Michael Chan <michael.c...@broadcom.com> > wrote: >> On Sat, Dec 9, 2017 at 10:56 AM, Alexander Duyck >> <alexander.du...@gmail.com>

Re: [PATCH net-next v3 1/5] net: Introduce NETIF_F_GRO_HW.

On Sat, Dec 9, 2017 at 2:04 PM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Sat, Dec 9, 2017 at 1:31 PM, Michael Chan <michael.c...@broadcom.com> > wrote: >> On Sat, Dec 9, 2017 at 10:50 AM, Alexander Duyck >> <alexander.du...@gmail.com> wrote: &

Re: [PATCH net-next v3 2/5] net: Disable GRO_HW when generic XDP is installed on a device.

On Sat, Dec 9, 2017 at 10:56 AM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Fri, Dec 8, 2017 at 10:27 PM, Michael Chan <michael.c...@broadcom.com> > wrote: >> Hardware should not aggregate any packets when generic XDP is installed. >> >> Cc: Ariel

Re: [PATCH net-next v3 1/5] net: Introduce NETIF_F_GRO_HW.

On Sat, Dec 9, 2017 at 10:50 AM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Fri, Dec 8, 2017 at 10:27 PM, Michael Chan <michael.c...@broadcom.com> > wrote: >> Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware >> GRO. With this flag,

[PATCH net-next v3 3/5] bnxt_en: Use NETIF_F_GRO_HW.

on NETIF_F_GRO_HW in features flag. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/et

[PATCH net-next v3 1/5] net: Introduce NETIF_F_GRO_HW.

ed-off-by: Michael Chan <michael.c...@broadcom.com> --- Documentation/networking/netdev-features.txt | 8 include/linux/netdev_features.h | 3 +++ net/core/dev.c | 12 net/core/ethtool.c | 1 + 4 files

[PATCH net-next v3 0/5] Introduce NETIF_F_GRO_HW

and lower devices not required (see patch 1). - NETIF_F_GRO_HW depends on NETIF_F_GRO and NETIF_F_RXCSUM. - Add dev_disable_gro_hw() to disable GRO_HW for generic XDP. - Use ndo_fix_features() on all 3 drivers to drop GRO_HW when it is not supported Michael Chan (5): net: Introduce NETIF_F_GRO_HW

[PATCH net-next v3 2/5] net: Disable GRO_HW when generic XDP is installed on a device.

Hardware should not aggregate any packets when generic XDP is installed. Cc: Ariel Elior <ariel.el...@cavium.com> Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- net/core/dev.c | 24 1 file changed, 24 insertions(+)

[PATCH net-next v3 4/5] bnx2x: Use NETIF_F_GRO_HW.

com> Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 19 --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 4 +++- 2 files changed, 15 insertions(+), 8 deletions(-) diff --g

[PATCH net-next v3 5/5] qede: Use NETIF_F_GRO_HW.

um.com> Cc: everest-linux...@cavium.com Acked-by: Manish Chopra <manish.cho...@cavium.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/qlogic/qede/qede.h | 2 ++ drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 3 +++ drivers/net

Re: [PATCH net-next v2 5/5] qede: Use NETIF_F_GRO_HW.

On Fri, Dec 8, 2017 at 2:09 PM, Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> wrote: > Hi, > > On Thu, Dec 07, 2017 at 03:03:35AM -0500, Michael Chan wrote: >> --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c >> +++ b/drivers/net/ethernet/qlogic/qede/qede_et

Re: [PATCH] bnxt_en: Fix sources of spurious netpoll warnings

s > 0. Fix this by only bumping rx_pkts if we were actually > given a non-zero budget. > > Signed-off-by: Calvin Owens <calvinow...@fb.com> Thanks. Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

On Thu, Dec 7, 2017 at 6:36 PM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Thu, Dec 7, 2017 at 4:05 PM, Michael Chan <michael.c...@broadcom.com> > wrote: >> I see. But this won't happen. Because the bonding driver is not >> advertising NET

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

On Thu, Dec 7, 2017 at 3:35 PM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Thu, Dec 7, 2017 at 3:17 PM, Michael Chan <michael.c...@broadcom.com> > wrote: >> I don't get this. I don't see how TSO is related. > > It isn't. That is the point. If I chan

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

On Thu, Dec 7, 2017 at 2:43 PM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Thu, Dec 7, 2017 at 2:08 PM, Michael Chan <michael.c...@broadcom.com> > wrote: >> On the bond, you can have LRO enabled and it is propagated to lower >> devices so that

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

On Thu, Dec 7, 2017 at 1:35 PM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Thu, Dec 7, 2017 at 10:44 AM, Michael Chan <michael.c...@broadcom.com> > wrote: >> On Thu, Dec 7, 2017 at 10:13 AM, Alexander Duyck >> <alexander.du...@gmail.com> wrote:

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

On Thu, Dec 7, 2017 at 10:13 AM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Thu, Dec 7, 2017 at 12:03 AM, Michael Chan <michael.c...@broadcom.com> > wrote: >> @@ -7405,6 +7405,23 @@ static netdev_features_t netdev_fix_features(struct >> net_device *de

Re: [PATCH net-next] bnxt: Don't print message, if DAC isn't connected on both ends

On Thu, Dec 7, 2017 at 1:14 AM, Thomas Bogendoerfer <tbogendoer...@suse.de> wrote: > On Wed, 6 Dec 2017 11:27:31 -0800 > Michael Chan <michael.c...@broadcom.com> wrote: > >> On Tue, Dec 5, 2017 at 4:33 AM, Thomas Bogendoerfer >> <tbogendoer...@suse.de>

[PATCH net-next v2 0/5] Introduce NETIF_F_GRO_HW

() to disable GRO_HW for generic XDP. - Use ndo_fix_features() on all 3 drivers to drop GRO_HW when it is not supported Michael Chan (5): net: Introduce NETIF_F_GRO_HW. net: Disable GRO_HW when generic XDP is installed on a device. bnxt_en: Use NETIF_F_GRO_HW. bnx2x: Use NETIF_F_GRO_HW. qede: Use

[PATCH net-next v2 4/5] bnx2x: Use NETIF_F_GRO_HW.

com> Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 17 ++--- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 4 +++- 2 files changed, 13 insertions(+), 8 deletions(-) diff --g

[PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

it is a subset of GRO. In other words, a lower device can independent have GRO/GRO_HW enabled or disabled and no feature propagation is required. This will preserve the current GRO behavior. Cc: Ariel Elior <ariel.el...@cavium.com> Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan <

[PATCH net-next v2 5/5] qede: Use NETIF_F_GRO_HW.

um.com> Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/qlogic/qede/qede.h | 2 ++ drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 3 +++ drivers/net/ethernet/qlogic/qede/qede_filter.c | 20 +-

[PATCH net-next v2 3/5] bnxt_en: Use NETIF_F_GRO_HW.

on NETIF_F_GRO_HW in features flag. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/et

[PATCH net-next v2 2/5] net: Disable GRO_HW when generic XDP is installed on a device.

Hardware should not aggregate any packets when generic XDP is installed. Cc: Ariel Elior <ariel.el...@cavium.com> Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- net/core/dev.c | 24 1 file changed, 24 insertions(+)

Re: [PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO_HW.

On Tue, Dec 5, 2017 at 10:10 AM, Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> wrote: > On Mon, Dec 04, 2017 at 04:07:15PM -0800, Michael Chan wrote: >> As already pointed out, GRO_HW is a subset of GRO. Packets that >> cannot be aggregated in hardware (due to hardware

Re: [PATCH net-next] bnxt: Don't print message, if DAC isn't connected on both ends

On Tue, Dec 5, 2017 at 4:33 AM, Thomas Bogendoerfer wrote: > bnxt driver spams logfiles with > > [ 541.003065] bnxt_en :5d:00.1 eth5: Link speed -1 no longer supported > > if a direct attached cable (DAC) is plugged into the bnxt card and is > unplugged on the other

Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()

to zero here so we can just remove > the check. > > Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap > offload") > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Thanks. Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH net-next 4/4] qede: Use NETIF_F_GRO_HW.

On Tue, Dec 5, 2017 at 4:32 AM, Chopra, Manish wrote: > > Since we are now differentiating HW gro with distinct feature bit, I think we > should consider this feature bit everywhere where driver disables > HW gro internally [not explicitly using ethtool]. This is not

Re: [PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO_HW.

On Mon, Dec 4, 2017 at 2:00 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Mon, 2017-12-04 at 23:06 +0200, Or Gerlitz wrote: >> On Mon, Dec 4, 2017 at 8:11 PM, Michael Chan <michael.chan@broadcom.c >> om> wrote: >> >> > All the logic is alread

Re: [PATCH net-next 1/4] net: Introduce NETIF_F_GRO_HW

On Mon, Dec 4, 2017 at 12:58 PM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Mon, Dec 4, 2017 at 11:52 AM, Michael Chan <michael.c...@broadcom.com> > wrote: >> NETIF_F_GRO_HW is a flag that depends on NETIF_F_GRO. In some ways, >> it is similar

Re: [PATCH net-next 4/4] qede: Use NETIF_F_GRO_HW.

On Mon, Dec 4, 2017 at 1:48 PM, Yuval Mintz <yuv...@mellanox.com> wrote: >> Advertise NETIF_F_GRO_HW and turn on or off hardware GRO based on >> NETIF_F_GRO_FW flag. >> >> Cc: Ariel Elior <ariel.el...@cavium.com> >> Cc: everest-linux...@cavium.com

Re: [PATCH net-next 1/4] net: Introduce NETIF_F_GRO_HW

On Mon, Dec 4, 2017 at 2:15 PM, Yuval Mintz wrote: >> @@ -96,6 +98,7 @@ enum { >> #define NETIF_F_FRAGLIST __NETIF_F(FRAGLIST) >> #define NETIF_F_FSO __NETIF_F(FSO) >> #define NETIF_F_GRO __NETIF_F(GRO) >> +#define NETIF_F_GRO_HW

Re: [PATCH net-next 1/4] net: Introduce NETIF_F_GRO_HW

On Mon, Dec 4, 2017 at 10:43 AM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Mon, Dec 4, 2017 at 10:23 AM, Michael Chan <michael.c...@broadcom.com> > wrote: >> On Mon, Dec 4, 2017 at 8:47 AM, Alexander Duyck >> <alexander.du...@gmail.com> wrote

Re: [PATCH net-next 1/4] net: Introduce NETIF_F_GRO_HW

On Mon, Dec 4, 2017 at 8:47 AM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Mon, Dec 4, 2017 at 3:12 AM, Michael Chan <michael.c...@broadcom.com> > wrote: >> Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware >> GRO. With this flag,

Re: [PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO_HW.

On Mon, Dec 4, 2017 at 8:35 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Mon, Dec 4, 2017 at 1:12 PM, Michael Chan <michael.c...@broadcom.com> > wrote: >> Advertise NETIF_F_GRO_HW if hardware GRO is supported. Turn on or off >> hardware GRO based on NETIF_F

[PATCH net-next 1/4] net: Introduce NETIF_F_GRO_HW

.el...@cavium.com> Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- Documentation/networking/netdev-features.txt | 7 +++ include/linux/netdev_features.h | 5 - net/core/dev.c | 13 +++

[PATCH net-next 4/4] qede: Use NETIF_F_GRO_HW.

Advertise NETIF_F_GRO_HW and turn on or off hardware GRO based on NETIF_F_GRO_FW flag. Cc: Ariel Elior <ariel.el...@cavium.com> Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/qlogic/qede/qede_filter.c | 9 ++---

[PATCH net-next 0/4] Introduce NETIF_F_GRO_HW

Introduce NETIF_F_GRO_HW feature flag and convert drivers that support hardware GRO to use the flag. Michael Chan (4): net: Introduce NETIF_F_GRO_HW bnxt_en: Use NETIF_F_GRO_HW. bnx2x: Use NETIF_F_GRO_HW. qede: Use NETIF_F_GRO_HW. Documentation/networking/netdev-features.txt | 7

[PATCH net-next 3/4] bnx2x: Use NETIF_F_GRO_HW.

Advertise NETIF_F_GRO_HW and turn on TPA_MODE_GRO when NETIF_F_GRO_HW is set. Cc: Ariel Elior <ariel.el...@cavium.com> Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 10 +++---

[PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO_HW.

Advertise NETIF_F_GRO_HW if hardware GRO is supported. Turn on or off hardware GRO based on NETIF_F_GRO_HW. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/d

[PATCH net 2/4] bnxt_en: wildcard smac while creating tunnel decap filter

uot;bnxt_en: add hwrm FW cmds for cfa_encap_record and decap_filter") Signed-off-by: Sunil Challa <sunilkumar.cha...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 7 ++- 1 file changed, 2 insertions(+)

[PATCH net 3/4] bnxt_en: fix dst/src fid for vxlan encap/decap actions

Perla <sathya.pe...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 48 +++- 1 file changed, 26 insertions(+), 22 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/driver

[PATCH net 0/4] bnxt_en: Fixes.

A shutdown fix for SMARTNIC, 2 fixes related to TC Flower vxlan filters, and the last one fixes an out-of-scope variable when sending short firmware messages. Ray Jui (1): bnxt_en: Need to unconditionally shut down RoCE in bnxt_shutdown Sathya Perla (1): bnxt_en: fix dst/src fid for vxlan

[PATCH net 4/4] bnxt_en: Fix a variable scoping in bnxt_hwrm_do_send_msg()

ar due to this issue. Fixes: e605db801bde ("bnxt_en: Support for Short Firmware Message") Signed-off-by: Vasundhara Volam <vasundhara-v.vo...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 inser

[PATCH net 1/4] bnxt_en: Need to unconditionally shut down RoCE in bnxt_shutdown

c65c92 ("bnxt_en: Add a callback to inform RDMA driver during PCI shutdown.") Signed-off-by: Ray Jui <ray@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(

Re: [PATCH 2/2] bnxt_en: Add ETH_RESET_AP support

On Thu, Nov 30, 2017 at 11:36 AM, Scott Branden <scott.bran...@broadcom.com> wrote: > Add ETH_RESET_AP support handling to reset the internal > Application Processor(s) of the SmartNIC card. > > Signed-off-by: Scott Branden <scott.bran...@broadcom.com> Acked-by:

Re: [PATCH] bnxt_en: Fix an error handling path in 'bnxt_get_module_eeprom()'

On Tue, Nov 28, 2017 at 7:56 AM, David Miller wrote: > From: Christophe JAILLET > Date: Tue, 21 Nov 2017 20:46:49 +0100 > >> Error code returned by 'bnxt_read_sfp_module_eeprom_info()' is handled a >> few lines above when reading the A0 portion

Re: linux-4.14/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:1009]: (style) Expression is always false

On Mon, Nov 13, 2017 at 4:12 AM, David Binderman wrote: > > Hello there, > > Source code is > > BNXT_FW_TO_ETHTOOL_SPDS(fw_speeds, 0, lk_ksettings, supported); > > and > > if ((fw_pause) & BNXT_LINK_PAUSE_RX) { \ >

Re: [RFC 9/9] bnxt_en: add support for software adaptive interrupt moderation

On Sun, Nov 5, 2017 at 9:44 PM, Andy Gospodarek wrote: > From: Andy Gospodarek > > This implements the changes needed for the bnxt_en driver to add support > for adaptive interrupt moderation per ring. > > This does add additional counters in the receive

[PATCH net-next 2/2] bnxt_en: Fix IRQ coalescing regression.

xt_en: Refactor and simplify coalescing code.") Reported-by: Andy Gospodarek <go...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH net-next 0/2] bnxt_en: Fix IRQ coalescing regressions.

There was a typo and missing guard-rail against illegal values in the recent code clean up. All reported by Andy Gospodarek. Andy Gospodarek (1): bnxt_en: fix typo in bnxt_set_coalesce Michael Chan (1): bnxt_en: Fix IRQ coalescing regression. drivers/net/ethernet/broadcom/bnxt/bnxt.c

[PATCH net-next 1/2] bnxt_en: fix typo in bnxt_set_coalesce

com.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c i

Re: [PATCH net-next 11/14] bnxt_en: add support for Flower based vxlan encap/decap offload

On Sun, Oct 29, 2017 at 11:22 AM, kbuild test robot wrote: > All warnings (new ones prefixed by >>): > >drivers/net//ethernet/broadcom/bnxt/bnxt_tc.c: In function > 'bnxt_tc_resolve_tunnel_hdrs': >drivers/net//ethernet/broadcom/bnxt/bnxt_tc.c:882:10: error: implicit >

Re: [PATCH net-next] bnxt_en: Fix randconfig build errors.

On Fri, Oct 27, 2017 at 11:15 PM, Jakub Kicinski <kubak...@wp.pl> wrote: > On Sat, 28 Oct 2017 14:05:04 +0800, Yunsheng Lin wrote: >> Hi, Michael >> >> On 2017/10/28 13:56, Michael Chan wrote: >> > Fix undefined symbols when CONFIG_VLAN_8021Q or CON

[PATCH net-next] bnxt_en: Fix randconfig build errors.

Fix undefined symbols when CONFIG_VLAN_8021Q or CONFIG_INET is not set. Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload") Reported-by: Jakub Kicinski <kubak...@wp.pl> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers

Re: [PATCH net-next 11/14] bnxt_en: add support for Flower based vxlan encap/decap offload

On Fri, Oct 27, 2017 at 8:18 PM, Jakub Kicinski <kubak...@wp.pl> wrote: > On Thu, 26 Oct 2017 11:51:29 -0400, Michael Chan wrote: >> From: Sathya Perla <sathya.pe...@broadcom.com> >> >> This patch adds IPv4 vxlan encap/decap action support to TC-flower >> off

[PATCH net-next 05/14] bnxt_en: Get firmware package version one time.

the less useful interface spec version. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 +-- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 30 --- 2 files changed, 18 insertions(+), 16 deletions(-) diff

[PATCH net-next 04/14] bnxt_en: Check for zero length value in bnxt_get_nvram_item().

Return -EINVAL if the length is zero and not proceed to do essentially nothing. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_eth

[PATCH net-next 03/14] bnxt_en: adding PCI ID for SMARTNIC VF support

From: Rob Miller <rmil...@broadcom.com> Signed-off-by: Rob Miller <rmil...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net

[PATCH net-next 06/14] bnxt_en: Optimize .ndo_set_mac_address() for VFs.

No need to call bnxt_approve_mac() which will send a message to the PF if the MAC address hasn't changed. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drive

[PATCH net-next 12/14] bnxt_en: add hwrm FW cmds for cfa_encap_record and decap_filter

From: Sathya Perla <sathya.pe...@broadcom.com> Add routines for issuing the hwrm_cfa_encap_record_alloc/free and hwrm_cfa_decap_filter_alloc/free FW cmds needed for supporting vxlan encap/decap offload. Signed-off-by: Sathya Perla <sathya.pe...@broadcom.com> Signed-off-by:

[PATCH net-next 11/14] bnxt_en: add support for Flower based vxlan encap/decap offload

sathya.pe...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 9 + drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 566 +- dr

[PATCH net-next 10/14] bnxt_en: Refactor and simplify coalescing code.

accurately set in hardware. The max_timer is set to coal_ticks value. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 81 +-- 1 file changed, 35 insertions(+), 46 deletions(-) diff --git a/drivers/net/et

[PATCH net-next 09/14] bnxt_en: Reorganize the coalescing parameters.

of coalescing parameters. Adjust the default coal_ticks to 14 us and 28 us for RX and TX. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 60 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.h

[PATCH net-next 02/14] bnxt_en: Add PCIe device ID for bcm58804

From: Ray Jui <ray@broadcom.com> Add new PCIe device ID and chip number for bcm58804 Signed-off-by: Ray Jui <ray@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++ drivers/net/ethernet/broadc

[PATCH net-next 13/14] bnxt_en: query cfa flow stats periodically to compute 'lastused' attribute

From: Sathya Perla <sathya.pe...@broadcom.com> This patch implements periodic querying of cfa flow stats in batches to compute the 'lastused' attribute of TC flow stats. Signed-off-by: Sathya Perla <sathya.pe...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.co

[PATCH net-next 14/14] bnxt_en: alloc tc_info{} struct only when tc flower is enabled

From: Sathya Perla <sathya.pe...@broadcom.com> TC flower is not enabled on VFs and when there's no FW support. Alloc the tc_info{} struct at init time only when TC flower is being enabled. Signed-off-by: Sathya Perla <sathya.pe...@broadcom.com> Signed-off-by: Michael Cha

[PATCH net-next 08/14] bnxt_en: Add ethtool reset method

From: Vasundhara Volam <vasundhara-v.vo...@broadcom.com> This is a firmware internal reset after driver is unloaded. Signed-off-by: Vasundhara Volam <vasundhara-v.vo...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/b

[PATCH net-next 01/14] bnxt_en: Update firmware interface to 1.8.3.1

Vxlan encap/decap filters are added to this firmware spec. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 420 -- 1 file changed, 396 insertions(+), 24 deletions(-) diff --git a/drivers/net/ethernet/br

[PATCH net-next 00/14] bnxt_en: Updates for net-next.

This series includes firmware interface update, some optimizations, some new PCI IDs, new MTU checks, ethtool reset method, interrupt coalescing code cleanup, and TC flower offload for vxlan encap/decap from Sathya Perla. Michael Chan (7): bnxt_en: Update firmware interface to 1.8.3.1

<    1   2   3   4   5   6   7   8   9   10   >