[PATCH net-next 12/14] bnxt_en: Set default completion ring for async events.

bnxt_en allocates the completion rings. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/br

[PATCH net-next 06/14] bnxt_en: Add function to get vnic capability.

The new vnic RSS capability will enhance NTUPLE support, to be added in subsequent patches. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 22 + drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + drivers/net/et

[PATCH net-next 04/14] bnxt_en: Fix and clarify link_info->advertising.

from the firmware yet. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 ++-- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 5 +++-- 3 files changed, 6 insertions

[PATCH net-next 11/14] bnxt_en: Implement new scheme to reserve tx rings.

will use the new scheme when the firmware interface spec is 1.6.1 or newer. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 59 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 + drivers/net/ethernet/br

[PATCH net-next 07/14] bnxt_en: Refactor code that determines RFS capability.

Add function bnxt_rfs_supported() that determines if the chip supports RFS. Refactor the existing function bnxt_rfs_capable() that determines if run-time conditions support RFS. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.

[PATCH net-next 09/14] bnxt_en: Assign additional vnics to VFs.

Assign additional vnics to VFs whenever possible so that NTUPLE can be supported on the VFs. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/et

[PATCH net-next 08/14] bnxt_en: Add new hardware RFS mode.

. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 27 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnx

[PATCH net-next 01/14] bnxt_en: Remove busy poll logic in the driver.

Use native NAPI polling instead. The next patch will complete the work by switching to use napi_complete_done() Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 53 + drivers/net/ethernet/broadcom/bnxt/bnxt.

[PATCH net-next 14/14] MAINTAINERS: Add bnxt_en maintainer info.

Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index cfff2c9..11904a9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2605,6 +2605,12 @@ L: netdev@vger.kernel.org S: Suppor

[PATCH net-next 03/14] bnxt_en: Improve the IRQ disable sequence during shutdown.

. Rearrange the code to avoid forward declaration. Signed-off-by: Michael Chan <michael.c...@broadocm.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 89 --- 1 file changed, 46 insertions(+), 43 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/

[PATCH net-next 02/14] bnxt_en: Use napi_complete_done()

For better busy polling and GRO support. Do not re-arm IRQ if napi_complete_done() returns false. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/et

[PATCH net-next 10/14] bnxt_en: Add IPV6 hardware RFS support.

Accept ipv6 flows in .ndo_rx_flow_steer() and support ETHTOOL_GRXCLSRULE ipv6 flows. Signed-off-by: Michael Chan <michael.c...@broadocm.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 32 +++--- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.

[PATCH net-next 00/14] bnxt_en: updates for net-next.

the firmware is implemented for newer chips and firmware. Plus some misc. cleanups, minor fixes, and to add the maintainer entry. Please review. Michael Chan (14): bnxt_en: Remove busy poll logic in the driver. bnxt_en: Use napi_complete_done() bnxt_en: Improve the IRQ disable sequence

[PATCH net-next 05/14] bnxt_en: Refactor TPA code path.

Call tcp_gro_complete() in the common code path instead of the chip- specific method. The newer 5731x method is missing the call. Signed-off-by: Michael Chan <michael.c...@broadcmo.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

On Mon, Dec 12, 2016 at 8:52 PM, Selvin Xavier wrote: >> CHECK drivers/infiniband/hw/bnxtre/bnxt_qplib_rcfw.c >> CHECK drivers/infiniband/hw/bnxtre/bnxt_qplib_sp.c >> CHECK drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c >>

Re: 4.9.0-rc8: tg3 dead after resume

On Wed, Dec 7, 2016 at 7:20 AM, Billy Shuman wrote: > After resume on 4.9.0-rc8 tg3 is dead. > > In logs I see: > kernel: tg3 :44:00.0: phy probe failed, err -19 > kernel: tg3 :44:00.0: Problem fetching invariants of chip, aborting -19 is -ENODEV which means tg3

[PATCH net-next v2 4/7] bnxt_en: Improve completion ring allocation for VFs.

bnxt_restore_pf_fw_resources() to restore FW resources. Later on we need to add some logic to account for RDMA resources. Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.

[PATCH net-next v2 6/7] bnxt_en: Refactor the driver registration function with firmware.

for the RDMA driver. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 34 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 ++ 2 files changed, 31 insertions(+), 5 deletions(-) diff --git a/drivers/net/et

[PATCH net-next v2 5/7] bnxt_en: Reserve RDMA resources by default.

compile warning when BNXT_CONFIG_SRIOV is not set. Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 58 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.h |

[PATCH net-next v2 7/7] bnxt_en: Add interface to support RDMA driver.

the RDMA driver calls bnxt_request_msix() function pointer. 6. When the RDMA driver calls bnxt_unregister_device(), all RDMA resources will be cleaned up. v2: Fixed 2 uninitialized variable warnings. Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Michael Chan <

[PATCH net-next v2 2/7] bnxt_en: Enable MSIX early in bnxt_init_one().

<somnath.ko...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 183 +++--- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + 2 files changed, 115 insertions(+), 69 deletions(-) diff --git a

[PATCH net-next v2 3/7] bnxt_en: Move function reset to bnxt_init_one().

do function reset as well. Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 25 ++--- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 - 2 files changed,

[PATCH net-next v2 1/7] bnxt_en: Add bnxt_set_max_func_irqs().

By refactoring existing code into this new function. The new function will be used in subsequent patches. v2: Fixed compile warning when CONFIG_BNXT_SRIOV is not set. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.

[PATCH net-next v2 0/7] bnxt_en: Add interface to support RDMA driver.

messages, and receive some notifications. v2: Fixed kbuild test robot warnings. David, please consider this series for net-next. Thanks. Michael Chan (7): bnxt_en: Add bnxt_set_max_func_irqs(). bnxt_en: Enable MSIX early in bnxt_init_one(). bnxt_en: Move function reset to bnxt_init_one

[PATCH net-next 4/7] bnxt_en: Improve completion ring allocation for VFs.

bnxt_restore_pf_fw_resources() to restore FW resources. Later on we need to add some logic to account for RDMA resources. Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.

[PATCH net-next 6/7] bnxt_en: Refactor the driver registration function with firmware.

for the RDMA driver. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 34 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 ++ 2 files changed, 31 insertions(+), 5 deletions(-) diff --git a/drivers/net/et

[PATCH net-next 5/7] bnxt_en: Reserve RDMA resources by default.

-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 58 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 9 + 2 files changed, 66 insertions(+), 1 deletion(-)

[PATCH net-next 3/7] bnxt_en: Move function reset to bnxt_init_one().

do function reset as well. Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 25 ++--- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 - 2 files changed,

[PATCH net-next 7/7] bnxt_en: Add interface to support RDMA driver.

the RDMA driver calls bnxt_request_msix() function pointer. 6. When the RDMA driver calls bnxt_unregister_device(), all RDMA resources will be cleaned up. Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/

[PATCH net-next 1/7] bnxt_en: Add bnxt_set_max_func_irqs().

By refactoring existing code into this new function. The new function will be used in subsequent patches. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 17 +++-- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + 2

[PATCH net-next 2/7] bnxt_en: Enable MSIX early in bnxt_init_one().

bnxt_init_int_mode(). bnxt_init_int_mode() is called during bnxt_init_one() to enable MSIX. The remaining logic in bnxt_setup_int_mode() to map the IRQs to the completion rings is called during bnxt_open(). Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Michael Chan <

[PATCH net-next 0/7] bnxt_en: Add interface to support RDMA driver.

messages, and receive some notifications. David, please consider this series for net-next. Thanks. Michael Chan (7): bnxt_en: Add bnxt_set_max_func_irqs(). bnxt_en: Enable MSIX early in bnxt_init_one(). bnxt_en: Move function reset to bnxt_init_one(). bnxt_en: Improve completion ring

Re: [PATCH 01/28] bnxt_en: Add bnxt_set_max_func_irqs().

On Mon, Dec 5, 2016 at 8:47 AM, David Miller wrote: > > It really doesn't make any sense to only send 7 out of 28 of these > patches to the networking list. > > In fact I would say that you need to split this series into two > components. OK. I will resend those bnxt_en

Re: [PATCH 1/1] netdev: broadcom: propagate error code

> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188661 > > Signed-off-by: Pan Bian <bianpan2...@163.com> Acked-by: Michael Chan <michael.c...@broadcom.com>

[PATCH net-next v2 1/4] bnxt_en: Re-factor bnxt_setup_tc().

Add a new function bnxt_setup_mq_tc() to handle MQPRIO. This new function will be called during ETS setup when we add DCBNL in the next patch. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 18 ++ drivers/net/et

[PATCH net-next v2 2/4] bnxt_en: Update firmware header file to latest 1.6.0.

Latest interface has the latest DCB command structs. Get and store the max number of lossless TCs the hardware can support. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 +- drivers/net/ethernet/broadcom/bnxt/

[PATCH net-next v2 4/4] bnxt_en: Add PFC statistics.

Report PFC statistics to ethtool -S and DCBNL. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 7 +++ drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 14 +- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.

[PATCH net-next v2 3/4] bnxt_en: Implement DCBNL to support host-based DCBX.

Support only IEEE DCBX initially. Add IEEE DCBNL ops and functions to get and set the hardware DCBX parameters. The DCB code is conditional on Kconfig CONFIG_BNXT_DCB. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/Kconfig | 10 + drive

[PATCH net-next v2 0/4] bnxt_en: Add DCBNL support.

This series adds DCBNL operations to support host-based IEEE DCBX. v2: Updated to the latest firmware interface spec. David, please consider this series for net-next. Michael Chan (4): bnxt_en: Re-factor bnxt_setup_tc(). bnxt_en: Update firmware header file to latest 1.6.0. bnxt_en

[PATCH net-next 4/4] bnxt_en: Add PFC statistics.

Report PFC statistics to ethtool -S and DCBNL. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 7 +++ drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 14 +- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.

[PATCH net-next 0/4] bnxt_en: Add DCBNL support.

This series adds DCBNL operations to support host-based IEEE DCBX. Michael Chan (4): bnxt_en: Re-factor bnxt_setup_tc(). bnxt_en: Update firmware header file to include DCB command structs. bnxt_en: Implement DCBNL to support host-based DCBX. bnxt_en: Add PFC statistics. drivers/net

[PATCH net-next 2/4] bnxt_en: Update firmware header file to include DCB command structs.

Get and store the max number of lossless TCs the hardware can support. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 + drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h

[PATCH net-next 3/4] bnxt_en: Implement DCBNL to support host-based DCBX.

Support only IEEE DCBX initially. Add IEEE DCBNL ops and functions to get and set the hardware DCBX parameters. The DCB code is conditional on Kconfig CONFIG_BNXT_DCB. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/Kconfig | 10 + drive

[PATCH net-next 1/4] bnxt_en: Re-factor bnxt_setup_tc().

Add a new function bnxt_setup_mq_tc() to handle MQPRIO. This new function will be called during ETS setup when we add DCBNL in the next patch. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 18 ++ drivers/net/et

[PATCH ethtool] ethtool: Fix the "advertise" parameter logic.

From: Michael Chan <mc...@broadcom.com> The current code ignores the value of the advertise parameter. For example, ethtool -s ethx advertise 0x1000 The full_advertising_wanted parameter of 0x1000 is not passed to the kernel. The reason is that advertising_wanted is NULL in thi

Re: [PATCH net] bnxt: do not busy-poll when link is down

hwrm_ring_free rx failed. rc:-1 >> >> These were resolved by checking for link status and returning if link >> was not up. >> >> Signed-off-by: Andy Gospodarek <go...@broadcom.com> >> Signed-off-by: Michael Chan <michael.c...@broadcom.com> >> Tes

Re: [PATCH] bnxt_en: Fix a VXLAN vs GENEVE issue

Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Thanks. Acked-by: Michael Chan <michael.c...@broadcom.com>

[PATCH net-next 1/4] bnxt_en: Update firmware interface spec to 1.5.4.

Use the new FORCE_LINK_DWN bit to shutdown link during close. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 ++- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 91 +-- 2 files changed, 94 insertions

[PATCH net-next 0/4] bnxt_en: Updates.

New firmware spec. update, autoneg update, and UDP RSS support. Michael Chan (4): bnxt_en: Update firmware interface spec to 1.5.4. bnxt_en: Enhance autoneg support. bnxt_en: Add UDP RSS support for 57X1X chips. bnxt_en: Add ethtool -n|-N rx-flow-hash support. drivers/net/ethernet

[PATCH net-next 4/4] bnxt_en: Add ethtool -n|-N rx-flow-hash support.

To display and modify the RSS hash. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 167 +- 1 file changed, 164 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtoo

[PATCH net-next 2/4] bnxt_en: Enhance autoneg support.

On some dual port NICs, the speed setting on one port can affect the available speed on the other port. Add logic to detect these changes and adjust the advertised speed settings when necessary. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadco

[PATCH net-next 3/4] bnxt_en: Add UDP RSS support for 57X1X chips.

The newer chips have proper support for 4-tuple UDP RSS. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 21 ++--- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 3 ++- 2 files changed, 16 insertions(+), 8 deletions(-)

Re: [PATCH net] : add a missing rcu synchronization

race > period. > > Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.") > Signed-off-by: Eric Dumazet <eduma...@google.com> > Cc: Michael Chan <michael.c...@broadcom.com> Thanks. Subject line is missing the driver name. Other than that, Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH v2 2/2] bnx2: Wait for in-flight DMA to complete at probe stage

void it look up > into the newly created io-page table at probe stage. > > Suggested-by: Michael Chan <michael.c...@broadcom.com> > Signed-off-by: Baoquan He <b...@redhat.com> Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH 0/2] bnx2: Hard reset bnx2 chip at probe stage

On Fri, Nov 11, 2016 at 6:02 AM, Baoquan He wrote: > On 11/11/16 at 09:46pm, Baoquan He wrote: >> Hi bnx2 experts, >> >> In commit 3e1be7a ("bnx2: Reset device during driver initialization"), >> firmware requesting code was moved from open stage to probe stage. >> The reason is

[PATCH net 0/2] bnxt_en: 2 bug fixes.

Bug fixes in bnxt_setup_tc() and VF vitual link state. Michael Chan (2): bnxt_en: Fix ring arithmetic in bnxt_setup_tc(). bnxt_en: Fix VF virtual link state. drivers/net/ethernet/broadcom/bnxt/bnxt.c | 11 ++- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 4 ++-- 2 files

[PATCH net 1/2] bnxt_en: Fix ring arithmetic in bnxt_setup_tc().

The logic is missing the check on whether the tx and rx rings are sharing completion rings or not. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drive

[PATCH net 2/2] bnxt_en: Fix VF virtual link state.

treat link as down when the link_status != LINK. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c b/drivers/net/ethern

Re: [PATCH net-next 1/2] bnxt_en: do not call napi_hash_add()

igned-off-by: Eric Dumazet <eduma...@google.com> > Cc: Michael Chan <michael.c...@broadcom.com> Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH net v2] tg3: Avoid NULL pointer dereference in tg3_io_error_detected()

NIP [c07e33f8] tg3_io_error_detected+0x308/0x340 > [1.404265] LR [c07e3164] tg3_io_error_detected+0x74/0x340 > > This patch avoids the NULL pointer dereference by moving the access after > the netdev NULL pointer check on tg3_io_error_detected(). Also, we add a > ch

Re: [PATCH net] tg3: Avoid NULL pointer dereference in tg3_io_error_detected()

On Tue, Sep 27, 2016 at 2:27 PM, Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> wrote: > On 09/27/2016 05:58 PM, Michael Chan wrote: >> >> On Tue, Sep 27, 2016 at 1:05 PM, Guilherme G. Piccoli >> <gpicc...@linux.vnet.ibm.com> wrote: >>> &

Re: [PATCH net] tg3: Avoid NULL pointer dereference in tg3_io_error_detected()

On Tue, Sep 27, 2016 at 1:05 PM, Guilherme G. Piccoli wrote: > From: Milton Miller > > While the driver is probing the adapter, an error may occur before the > netdev structure is allocated and attached to pci_dev. In this case, > not only netdev

Re: [PATCH] net: tg3: use new api ethtool_{get|set}_link_ksettings

On Sun, Sep 25, 2016 at 2:31 PM, Philippe Reynes <trem...@gmail.com> wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes <trem...@gmail.com> Looks good to me. Thanks

[PATCH net-next] MAINTAINERS: Update b44 maintainer.

Taking over as maintainer since Gary Zambrano is no longer working for Broadcom. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ce80b36..7626f7836 100644 --- a/MAINT

[PATCH net-next] bnxt_en: Fix build error for kernesl without RTC-LIB

m> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index cbc0b8a..a9f9f37 100644 --- a/dr

Re: [PATCH net-next 00/10] bnxt: update for net-next.

On Mon, Sep 19, 2016 at 6:32 PM, David Miller <da...@davemloft.net> wrote: > From: Michael Chan <michael.c...@broadcom.com> > Date: Mon, 19 Sep 2016 03:57:59 -0400 > >> Misc. changes and minor bug fixes for net-next. Please review. > > Series applied,

[PATCH net-next v2 06/10] bnxt_en: Re-arrange bnxt_hwrm_func_qcaps().

Re-arrange the code so that the generation of the random MAC address for the VF is at the end of the function. The next patch will add one more step to call bnxt_approve_mac() to get the firmware to approve the random MAC address. Signed-off-by: Michael Chan <michael.c...@broadcom.

[PATCH net-next v2 07/10] bnxt_en: Call firmware to approve the random VF MAC address.

before calling bnxt_approve_mac(). We can do that because we are at the end of the function and all the previous firmware response data has been copied. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 +++-- 1 file changed, 7 inse

[PATCH net-next v2 05/10] bnxt_en: Fix ethtool -l|-L inconsistent channel counts.

off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index ae4458d

[PATCH net-next v2 09/10] bnxt_en: Support for "ethtool -r" command

From: Deepak Khungar <deepak.khun...@broadcom.com> Restart autoneg if autoneg is enabled. Signed-off-by: Deepak Khungar <deepak.khun...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 20 ++

[PATCH net-next v2 10/10] bnxt_en: Fixed the VF link status after a link state change

event will trigger the VF to update the link status. Signed-off-by: Eddie Wai <eddie@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 84 - 1 file changed, 42 insertions(+), 42 deleti

[PATCH net-next v2 04/10] bnxt_en: Added support for Secure Firmware Update

instead of '== 0'. Signed-off-by: Rob Swindell <rob.swind...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + drivers/net/ethernet/broadc

[PATCH net-next v2 03/10] bnxt_en: Update to firmware interface spec 1.5.1.

Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c |3 + drivers/net/ethernet/broadcom/bnxt/bnxt.h | 14 +- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 1251 +++-- 3 files changed, 760 insertions(+

[PATCH net-next v2 08/10] bnxt_en: Pad TX packets below 52 bytes.

The hardware has a limitation that it won't pass host to BMC loopback packets below 52-bytes. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/br

[PATCH net-next v2 00/10] bnxt: update for net-next.

Misc. changes and minor bug fixes for net-next. Please review. v2: Updated "bnxt_en: Added support for Secure Firmware Update" patch. Deepak Khungar (1): bnxt_en: Support for "ethtool -r" command Eddie Wai (1): bnxt_en: Fixed the VF link status after a link state cha

[PATCH net-next v2 01/10] bnxt_en: Use RSS flags defined in the bnxt_hsi.h file.

And remove redundant definitions of the same flags. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 - 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drive

[PATCH net-next v2 02/10] bnxt_en: Simplify PCI device names and add additinal PCI IDs.

hristensen <david.christen...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 68 --- 1 file changed, 36 insertions(+), 32 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt

Re: [PATCH net] MAINTAINERS: Gary Zambrano's email is bouncing

On Mon, Sep 19, 2016 at 12:54 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 09/17/2016 04:39 PM, Michael Chan wrote: >> On Sat, Sep 17, 2016 at 4:17 PM, Florian Fainelli <f.faine...@gmail.com> >> wrote: >>> 2016-09-17 15:51 GMT-07:00 Joe Perches <

Re: [PATCH net-next 05/10] bnxt_en: Fix ethtool -l|-L inconsistent channel counts.

On Mon, Sep 19, 2016 at 2:51 AM, Mintz, Yuval wrote: >> >> If the user chooses 2 rx and 1 tx, he will use 3 msix vectors (3 completion >> rings, >> etc). If the user chooses 2 combined (1 with rx/tx, >> 1 with rx only), he will use 2 msix vectors (2 completion rings,

Re: [PATCH net-next 05/10] bnxt_en: Fix ethtool -l|-L inconsistent channel counts.

On Mon, Sep 19, 2016 at 2:21 AM, Mintz, Yuval wrote: >> >> The existing code is inconsistent in reporting and accepting the >> >> combined channel count. bnxt_get_channels() reports maximum combined >> >> as the maximum rx count. bnxt_set_channels() accepts combined

Re: [PATCH net-next 04/10] bnxt_en: Added support for Secure Firmware Update

On Mon, Sep 19, 2016 at 1:16 AM, Mintz, Yuval wrote: >> + if (bp->hwrm_spec_code < 0x10400) >> + return -EOPNOTSUPP; > Don't you use defines for these kind of version values? No we don't. In this case, firmware spec version 1.4.0 has added this new

Re: [PATCH net-next 05/10] bnxt_en: Fix ethtool -l|-L inconsistent channel counts.

On Mon, Sep 19, 2016 at 1:33 AM, Mintz, Yuval wrote: >> The existing code is inconsistent in reporting and accepting the combined >> channel count. bnxt_get_channels() reports maximum combined as the >> maximum rx count. bnxt_set_channels() accepts combined count that

[PATCH net-next 08/10] bnxt_en: Pad TX packets below 52 bytes.

The hardware has a limitation that it won't pass host to BMC loopback packets below 52-bytes. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/br

[PATCH net-next 06/10] bnxt_en: Re-arrange bnxt_hwrm_func_qcaps().

Re-arrange the code so that the generation of the random MAC address for the VF is at the end of the function. The next patch will add one more step to call bnxt_approve_mac() to get the firmware to approve the random MAC address. Signed-off-by: Michael Chan <michael.c...@broadcom.

[PATCH net-next 03/10] bnxt_en: Update to firmware interface spec 1.5.1.

Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c |3 + drivers/net/ethernet/broadcom/bnxt/bnxt.h | 14 +- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 1251 +++-- 3 files changed, 760 insertions(+

[PATCH net-next 05/10] bnxt_en: Fix ethtool -l|-L inconsistent channel counts.

off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index 4a430b6

[PATCH net-next 09/10] bnxt_en: Support for "ethtool -r" command

From: Deepak Khungar <deepak.khun...@broadcom.com> Restart autoneg if autoneg is enabled. Signed-off-by: Deepak Khungar <deepak.khun...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 20 ++

[PATCH net-next 10/10] bnxt_en: Fixed the VF link status after a link state change

event will trigger the VF to update the link status. Signed-off-by: Eddie Wai <eddie@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 84 - 1 file changed, 42 insertions(+), 42 deleti

[PATCH net-next 07/10] bnxt_en: Call firmware to approve the random VF MAC address.

before calling bnxt_approve_mac(). We can do that because we are at the end of the function and all the previous firmware response data has been copied. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 +++-- 1 file changed, 7 inse

[PATCH net-next 04/10] bnxt_en: Added support for Secure Firmware Update

e also introduce use of the new firmware command FW_SET_TIME so that the NVM-resident package installation log contains valid time-stamps. Signed-off-by: Rob Swindell <rob.swind...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadc

[PATCH net-next 02/10] bnxt_en: Simplify PCI device names and add additinal PCI IDs.

hristensen <david.christen...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 68 --- 1 file changed, 36 insertions(+), 32 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt

[PATCH net-next 01/10] bnxt_en: Use RSS flags defined in the bnxt_hsi.h file.

And remove redundant definitions of the same flags. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 - 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drive

[PATCH net-next 00/10] bnxt: update for net-next.

Misc. changes and minor bug fixes for net-next. Please review. Deepak Khungar (1): bnxt_en: Support for "ethtool -r" command Eddie Wai (1): bnxt_en: Fixed the VF link status after a link state change Michael Chan (7): bnxt_en: Use RSS flags defined in the bnxt_hsi.h file.

Re: [PATCH net] MAINTAINERS: Gary Zambrano's email is bouncing

On Sat, Sep 17, 2016 at 4:17 PM, Florian Fainelli wrote: > 2016-09-17 15:51 GMT-07:00 Joe Perches : >> On Sat, 2016-09-17 at 15:27 -0700, Florian Fainelli wrote: >>> Gary has not been with Broadcom for some time now, replace his address >>> with the

[PATCH net] bnxt_en: Fix TX push operation on ARM64.

There is a code path where we are calling __iowrite64_copy() on an address that is not 64-bit aligned. This causes an exception on some architectures such as arm64. Fix that code path by using __iowrite32_copy(). Reported-by: JD Zheng <jiandong.zh...@broadcom.com> Signed-off-by: Michae

Re: [PATCH net v2] tg3: Fix for disallow tx coalescing time to be 0

; Cc: siva.kal...@broadcom.com > Cc: michael.c...@broadcom.com > Signed-off-by: Ivan Vecera <ivec...@redhat.com> Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH net] tg3: Fix for disallow tx coalescing time to be 0

On Wed, Aug 31, 2016 at 2:27 AM, Ivan Vecera <ivec...@redhat.com> wrote: > Dne 30.8.2016 v 17:46 Michael Chan napsal(a): >> >> On Tue, Aug 30, 2016 at 7:38 AM, Ivan Vecera <ivec...@redhat.com> wrote: >>> >>> The recent commit 087d7a8c disallows to set

Re: [PATCH net] tg3: Fix for disallow tx coalescing time to be 0

On Tue, Aug 30, 2016 at 7:38 AM, Ivan Vecera wrote: > The recent commit 087d7a8c disallows to set Rx coalescing time to be 0 > as this stops generating interrupts for the incoming packets. I found > the zero Tx coalescing time stops generating interrupts similarly for >

Re: [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G

On Sun, Aug 21, 2016 at 7:44 AM, Yuval Mintz wrote: >> Ping? >> >> On Tue, Aug 02, 2016 at 03:49:57PM -0400, John W. Linville wrote: >> > Are these revised patches still on their way? >> > >> > John >> > >> > On Sun, Jul 24, 2016 at 01:57:14AM -0700, Vidya Sagar Ravipati

Re: [PATCH net 1/2] tg3: Fix for diasllow rx coalescing time to be 0

On Wed, Aug 3, 2016 at 9:04 AM, Rick Jones wrote: > > Should anything then happen with: > > /* No rx interrupts will be generated if both are zero */ > if ((ec->rx_coalesce_usecs == 0) && > (ec->rx_max_coalesced_frames == 0)) >

<    1   2   3   4   5   6   7   8   9   10   >