Cc: Ariel Levkovich
Cc: Saeed Mahameed
Signed-off-by: Miroslav Lichvar
---
drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c
b/drivers/net/ethernet/mellanox/mlx5/core
Read the system time right before and immediately after reading the low
register of the internal timer. This adds support for the
PTP_SYS_OFFSET_EXTENDED ioctl.
Cc: Richard Cochran
Cc: Saeed Mahameed
Signed-off-by: Miroslav Lichvar
---
.../ethernet/mellanox/mlx5/core/lib/clock.c | 20
This is a pair of patches for the mlx5 driver related to the PTP clock.
The first patch fixes a potential issue causing backward jumps due to a
late update of the PHC timecounter.
The second patch adds support for the PTP_SYS_OFFSET_EXTENDED ioctl.
Miroslav Lichvar (2):
mlx5: update
This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl.
Cc: Richard Cochran
Cc: Jacob Keller
Cc: Jeff Kirsher
Signed-off-by: Miroslav Lichvar
---
drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 54
1 file changed, 44 insertions(+), 10 deletions(-)
diff --git a/drivers
This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl.
Cc: Richard Cochran
Cc: Michael Chan
Signed-off-by: Miroslav Lichvar
---
drivers/net/ethernet/broadcom/tg3.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/tg3.c
b
This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl.
Cc: Richard Cochran
Cc: Jacob Keller
Cc: Jeff Kirsher
Signed-off-by: Miroslav Lichvar
---
drivers/net/ethernet/intel/e1000e/e1000.h | 3 ++
drivers/net/ethernet/intel/e1000e/netdev.c | 42 --
drivers/net/ethernet
This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl.
Cc: Richard Cochran
Cc: Jacob Keller
Cc: Jeff Kirsher
Signed-off-by: Miroslav Lichvar
---
drivers/net/ethernet/intel/igb/igb_ptp.c | 65
1 file changed, 55 insertions(+), 10 deletions(-)
diff --git a/drivers
When a driver provides gettimex64(), use it in the PTP_SYS_OFFSET ioctl
and POSIX clock's gettime() instead of gettime64(). Drivers should
provide only one of the functions.
Cc: Richard Cochran
Cc: Jacob Keller
Signed-off-by: Miroslav Lichvar
---
drivers/ptp/ptp_chardev.c| 5
Cc: Jacob Keller
Cc: Marcelo Tosatti
Signed-off-by: Miroslav Lichvar
---
drivers/ptp/ptp_chardev.c| 33
include/linux/ptp_clock_kernel.h | 31 ++
include/uapi/linux/ptp_clock.h | 12
3 files changed, 76
750 ns
- with an X550 (ixgbe) the delay was reduced from 1950 to 650 ns
- with a BCM5720 (tg3) the delay was reduced from 2400 to 1200 ns
Miroslav Lichvar (8):
ptp: reorder declarations in ptp_ioctl()
ptp: check gettime64 return code in PTP_SYS_OFFSET ioctl
ptp: add PTP_SYS_OFFSET_EXTEN
If a gettime64 call fails, return the error and avoid copying data back
to user.
Cc: Richard Cochran
Cc: Jacob Keller
Signed-off-by: Miroslav Lichvar
---
drivers/ptp/ptp_chardev.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp
Reorder declarations of variables as reversed Christmas tree.
Cc: Richard Cochran
Suggested-by: Richard Cochran
Signed-off-by: Miroslav Lichvar
---
drivers/ptp/ptp_chardev.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/ptp/ptp_chardev.c b/drivers
On Wed, Oct 31, 2018 at 12:42:47PM -0700, Jeff Kirsher wrote:
> From: Miroslav Lichvar
>
> The timecounter needs to be updated at least once per ~550 seconds in
> order to avoid a 40-bit SYSTIM timestamp to be misinterpreted as an old
> timestamp.
>
> Since commit 50046
On Wed, Oct 31, 2018 at 07:40:03AM -0700, Richard Cochran wrote:
> On Mon, Oct 29, 2018 at 02:31:09PM +0100, Miroslav Lichvar wrote:
> > I think there could be a flag in ptp_system_timestamp, or a parameter
> > of gettimex64(), which would enable/disable reading of the system
>
On Tue, Oct 30, 2018 at 07:29:16PM -0700, Richard Cochran wrote:
> On Fri, Oct 26, 2018 at 06:27:41PM +0200, Miroslav Lichvar wrote:
> > +static int igb_ptp_gettimex(struct ptp_clock_info *ptp,
> > + struct ptp_system_timestamp *sts)
> > +{
> >
On Fri, Oct 26, 2018 at 04:54:57PM +, Keller, Jacob E wrote:
> > -Original Message-
> > From: Miroslav Lichvar [mailto:mlich...@redhat.com]
> > Sent: Friday, October 26, 2018 9:28 AM
> > To: netdev@vger.kernel.org
> > Cc: intel-wired-...@lis
sysoff_extended = memdup_user((void __user *)arg,
> > + sizeof(*sysoff_extended));
>
> Looks like you forgot to free 'sysoff_extended', no?
Oh, I did. Thanks for catching that. I'll fix it in the next version.
--
Miroslav Lichvar
82580/I350/I354 being off by
~1100 seconds for few seconds every ~9 minutes.
Cc: Jacob Keller
Cc: Richard Cochran
Cc: Thomas Gleixner
Signed-off-by: Miroslav Lichvar
---
drivers/net/ethernet/intel/igb/igb_ptp.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/d
Cc: Richard Cochran
Cc: Jacob Keller
Signed-off-by: Miroslav Lichvar
---
drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 57
1 file changed, 57 insertions(+)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
index
Cc: Richard Cochran
Cc: Jacob Keller
Signed-off-by: Miroslav Lichvar
---
drivers/net/ethernet/intel/e1000e/e1000.h | 3 ++
drivers/net/ethernet/intel/e1000e/netdev.c | 48 +-
drivers/net/ethernet/intel/e1000e/ptp.c| 21 ++
3 files changed, 62 insertions(+), 10
of the PHC
timestamp
Cc: Richard Cochran
Cc: Jacob Keller
Signed-off-by: Miroslav Lichvar
---
drivers/ptp/ptp_chardev.c| 39
include/linux/ptp_clock_kernel.h | 26 +
include/uapi/linux/ptp_clock.h | 12 ++
3 files changed
Cc: Richard Cochran
Cc: Jacob Keller
Signed-off-by: Miroslav Lichvar
---
drivers/net/ethernet/intel/igb/igb_ptp.c | 43
1 file changed, 43 insertions(+)
diff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c
b/drivers/net/ethernet/intel/igb/igb_ptp.c
index
, mixing
SYSTIM and "system time" in the code will probably be confusing.
I wasn't able to find a better name for the ioctl, the structures, and
the driver function. If anyone has suggestions, please let me know.
Miroslav Lichvar (4):
ptp: add PTP_SYS_OFFSET_EXTENDED ioctl
e1000e: a
On Fri, Oct 12, 2018 at 07:05:30AM -0700, Richard Cochran wrote:
> On Fri, Oct 12, 2018 at 01:13:39PM +0200, Miroslav Lichvar wrote:
> > Since commit 500462a9d ("timers: Switch to a non-cascading wheel"),
> > scheduling of delayed work seems to be less accurate and a r
t -14 s2 freq +89 delay 1301
phc offset -86 s2 freq +13 delay 1296
phc offset -21 s2 freq +52 delay 1298
--
Miroslav Lichvar
On Mon, Oct 22, 2018 at 03:48:02PM -0700, Richard Cochran wrote:
> On Fri, Oct 19, 2018 at 11:51:37AM +0200, Miroslav Lichvar wrote:
> > The extra timestamp doesn't fit the API of the PTP_SYS_OFFSET ioctl,
> > so it would need to shift the timestamp it returns by the missin
register reads sensitive
to the PCIe delay.
What do you think?
--
Miroslav Lichvar
ochran
Cc: Thomas Gleixner
Signed-off-by: Miroslav Lichvar
---
drivers/net/ethernet/intel/igb/igb_ptp.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c
b/drivers/net/ethernet/intel/igb/igb_ptp.c
index 9f4d700e09df..29ced6b74
ere is also the possibility that the NIC clock is not synchronized
to anything. For synchronization of the system clock it's easier to
leave it free running and only track its phase/frequency offset to
allow conversion between the PHC and system time.
--
Miroslav Lichvar
is a
no-op on AF_INET6 sockets.
--
Miroslav Lichvar
t a public NTP
server could be sending millions of packets per second in traffic
peaks (typically at *:00:00) over multiple interfaces.
--
Miroslav Lichvar
On Mon, Feb 12, 2018 at 02:39:06PM -0800, Jesus Sanchez-Palencia wrote:
> On 01/18/2018 12:42 AM, Miroslav Lichvar wrote:
> > Please keep in mind that the PHCs and the system clock don't have to
> > be synchronized to each other. If I understand the rest of the serie
ponses as soon
as they are assembled.
I think it would be nice the sendmmsg() calls didn't have to be split
by clockid_t.
--
Miroslav Lichvar
but wouldn't it be better to make it consistent with the
timestamping API using timespec? Or is it just better to avoid the
64/32-bit mess of time_t?
--
Miroslav Lichvar
nd the system clock don't have to
be synchronized to each other. If I understand the rest of the series
correctly, there is an assumption that the PHCs are keeping time in
TAI and CLOCK_TAI can be used as a fallback.
--
Miroslav Lichvar
240 |
>
> Using so_txtime, the peak to peak jitter is about 100 nanoseconds,
Nice!
--
Miroslav Lichvar
Add HWTSTAMP_FILTER_NTP_ALL to the list of hardware receive
filters which can be printed by ethtool -T.
CC: Richard Cochran <richardcoch...@gmail.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
ethtool.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
These two patches update ethtool to be able to print the new NTP
timestamping filter in the ethtool -T command.
Miroslav Lichvar (2):
net_tstamp.h: sync with net-next
ethtool: add support for HWTSTAMP_FILTER_NTP_ALL
ethtool.c | 3 ++-
net_tstamp-copy.h | 52
This covers kernel changes up to:
commit b50a5c70ffa4fd6b6da324ab54c84adf48fb17d9
Author: Miroslav Lichvar <mlich...@redhat.com>
Date: Fri May 19 17:52:40 2017 +0200
net: allow simultaneous SW and HW transmit timestamping
Add SOF_TIMESTAMPING_OPT_TX_SWHW option to allow an ou
message only when the skb has no software
timestamp or it is an incoming packet.
While changing sw_tx_timestamp(), inline it in skb_tx_timestamp() as
there are no other users.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miro
skb_tx_timestamp().
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 3 +--
drivers/net/ethernet/intel/e1000e/netdev.c| 4 ++--
dr
a SCM_TIMESTAMP(NS) message.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
Documentation/networking/timestamping.txt | 8 +++-
1 file changed, 7 insertions(+), 1 delet
index will be returned in the control message.
CC: Richard Cochran <richardcoch...@gmail.com>
Acked-by: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
Documentation/networking/timestamping.txt | 10 ++
include/uapi/as
Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 1 +
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 +
drivers/net/ethernet/cavium/liquidio/lio_main.c| 1 +
drivers/net/ethern
d-by: Willem de Bruijn <will...@google.com>
Acked-by: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
include/linux/netdevice.h | 1 +
include/linux/skbuff.h| 9 +
net/core/dev.c| 26 ++
3 fil
uest both software and hardware
timestamps for outgoing packets. The seventh patch updates drivers that
assumed software timestamping cannot be used together with hardware
timestamping.
The patches have been tested on x86_64 machines with igb and e1000e
drivers.
Miroslav Lichvar (7):
net: define
Add HWTSTAMP_FILTER_NTP_ALL to the hwtstamp_rx_filters enum for
timestamping of NTP packets. There is currently only one driver
(phyter) that could support it directly.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Li
On Thu, May 18, 2017 at 03:38:30PM -0400, Willem de Bruijn wrote:
> On Thu, May 18, 2017 at 10:07 AM, Miroslav Lichvar <mlich...@redhat.com>
> wrote:
> > +Note that if the SO_TIMESTAMP or SO_TIMESTAMPNS option is enabled
> > +together with SO_TIMESTAMPING using SOF_TIMEST
On Thu, May 18, 2017 at 04:20:53PM -0400, Willem de Bruijn wrote:
> On Thu, May 18, 2017 at 10:07 AM, Miroslav Lichvar <mlich...@redhat.com>
> wrote:
> > +SOF_TIMESTAMPING_OPT_PKTINFO:
> > +
> > + Enable the SCM_TIMESTAMPING_PKTINFO control message for incomin
On Thu, May 18, 2017 at 04:16:26PM -0400, Willem de Bruijn wrote:
> On Thu, May 18, 2017 at 9:06 AM, Miroslav Lichvar <mlich...@redhat.com> wrote:
> > +/* On transmit, software and hardware timestamps are returned
> > independently.
> > + * As the two skb clones s
message only when the skb has no software
timestamp or it is an incoming packet.
While changing sw_tx_timestamp(), inline it in skb_tx_timestamp() as
there are no other users.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miro
he patches have been tested on x86_64 machines with igb and e1000e
drivers.
Miroslav Lichvar (7):
net: define receive timestamp filter for NTP
net: ethernet: update drivers to handle HWTSTAMP_FILTER_NTP_ALL
net: add function to retrieve original skb device using NAPI ID
net: add new
d-by: Willem de Bruijn <will...@google.com>
Acked-by: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
include/linux/netdevice.h | 1 +
include/linux/skbuff.h| 9 +
net/core/dev.c| 26 ++
3 fil
index will be returned in the control message.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
Documentation/networking/timestamping.txt | 9 +
include/uapi/asm-generic/soc
a SCM_TIMESTAMP(NS) message.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
Documentation/networking/timestamping.txt | 8 +++-
1 file changed, 7 insertions(+), 1 delet
Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 1 +
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 +
drivers/net/ethernet/cavium/liquidio/lio_main.c| 1 +
drivers/net/ethern
skb_tx_timestamp().
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 3 +--
drivers/net/ethernet/intel/e1000e/netdev.c| 4 ++--
dr
Add HWTSTAMP_FILTER_NTP_ALL to the hwtstamp_rx_filters enum for
timestamping of NTP packets. There is currently only one driver
(phyter) that could support it directly.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Li
On Thu, May 18, 2017 at 02:58:23PM +0200, Miroslav Lichvar wrote:
> Changes v3->v4:
> - added reserved fields to struct scm_ts_pktinfo
Of course, I forgot to initialize the new reserved fields. I'll send a
new series.
--
Miroslav Lichvar
index will be returned in the control message.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
Documentation/networking/timestamping.txt | 9 +
include/uapi/asm-generic/soc
h adds a new option to request both software and hardware
timestamps for outgoing packets. The seventh patch updates drivers that
assumed software timestamping cannot be used together with hardware
timestamping.
The patches have been tested on x86_64 machines with igb and e1000e
drivers.
Mirosla
message only when the skb has no software
timestamp or it is an incoming packet.
While changing sw_tx_timestamp(), inline it in skb_tx_timestamp() as
there are no other users.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miro
Add HWTSTAMP_FILTER_NTP_ALL to the hwtstamp_rx_filters enum for
timestamping of NTP packets. There is currently only one driver
(phyter) that could support it directly.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Li
Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 1 +
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 +
drivers/net/ethernet/cavium/liquidio/lio_main.c| 1 +
drivers/net/ethern
skb_tx_timestamp().
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 3 +--
drivers/net/ethernet/intel/e1000e/netdev.c| 4 ++--
dr
a SCM_TIMESTAMP(NS) message.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
Documentation/networking/timestamping.txt | 8 +++-
1 file changed, 7 insertions(+), 1 delet
d-by: Willem de Bruijn <will...@google.com>
Acked-by: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
include/linux/netdevice.h | 1 +
include/linux/skbuff.h| 9 +
net/core/dev.c| 26 ++
3 fil
On Tue, May 16, 2017 at 06:34:38PM -0400, Willem de Bruijn wrote:
> On Tue, May 16, 2017 at 8:44 AM, Miroslav Lichvar <mlich...@redhat.com> wrote:
> > If software timestamping is enabled by the SO_TIMESTAMP(NS) option
> > when a message without timestamp is already
index will be returned in the control message.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
Documentation/networking/timestamping.txt | 9 +
include/uapi/asm-generic/soc
jn <will...@google.com>
Suggested-by: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
include/linux/netdevice.h | 1 +
include/linux/skbuff.h| 9 +
net/core/dev.c| 26 ++
3 files changed
message only when the skb has no software
timestamp or it is an incoming packet.
While changing sw_tx_timestamp(), inline it in skb_tx_timestamp() as
there are no other users.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miro
skb_tx_timestamp().
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 3 +--
drivers/net/ethernet/intel/e1000e/netdev.c| 4 ++--
dr
timestamp
only if it's for a received packet (i.e. it's not in the error queue).
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
net/socket.c | 3 ++-
1 file changed, 2 insertions(+), 1
Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 1 +
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 +
drivers/net/ethernet/cavium/liquidio/lio_main.c| 1 +
drivers/net/ethern
Add HWTSTAMP_FILTER_NTP_ALL to the hwtstamp_rx_filters enum for
timestamping of NTP packets. There is currently only one driver
(phyter) that could support it directly.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Li
en tested on x86_64 machines with igb and e1000e
drivers.
Miroslav Lichvar (7):
net: define receive timestamp filter for NTP
net: ethernet: update drivers to handle HWTSTAMP_FILTER_NTP_ALL
net: add function to retrieve original skb device using NAPI ID
net: add new control message for in
On Tue, May 02, 2017 at 12:16:13PM -0400, Willem de Bruijn wrote:
> On Tue, May 2, 2017 at 6:10 AM, Miroslav Lichvar <mlich...@redhat.com> wrote:
> > /**
> > + * dev_get_by_napi_id - find a device by napi_id
> > + * @napi_id: ID of the NAPI struct
The driver doesn't support timestamping of all received packets and
should return error when trying to enable the HWTSTAMP_FILTER_ALL
filter.
Cc: WingMan Kwok <w-kw...@ti.com>
Cc: Richard Cochran <richardcoch...@gmail.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
Hm, I see that net-next was closed. I missed the annoucement. Sorry
for the spam.
On Tue, May 02, 2017 at 02:46:02PM +0200, Miroslav Lichvar wrote:
> Changes v1->v2:
> - added separate patch for new NAPI functions
> - split code from __sock_recv_timestamp() for better readability
&
Add HWTSTAMP_FILTER_NTP_ALL to the hwtstamp_rx_filters enum for
timestamping of NTP packets. There is currently only one driver
(phyter) that could support it directly.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Li
message only when the skb has no software
timestamp or it is an incoming packet.
While changing sw_tx_timestamp(), inline it in skb_tx_timestamp() as
there are no other users.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miro
jn <will...@google.com>
Suggested-by: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
include/linux/netdevice.h | 1 +
include/linux/skbuff.h| 9 +
net/core/dev.c| 26 ++
3 files changed
Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 1 +
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 +
drivers/net/ethernet/cavium/liquidio/lio_main.c| 1 +
drivers/net/ethern
timestamp
only if it's for a received packet (i.e. it's not in the error queue).
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
net/socket.c | 3 ++-
1 file changed, 2 insertions(+), 1
using napi, but it should cover all current MAC drivers that
support hardware timestamping.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
Documentation/networking/tim
skb_tx_timestamp().
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 3 +--
drivers/net/ethernet/intel/e1000e/netdev.c| 4 ++--
dr
x86_64 machines with igb and e1000e
drivers.
Miroslav Lichvar (7):
net: define receive timestamp filter for NTP
net: ethernet: update drivers to handle HWTSTAMP_FILTER_NTP_ALL
net: add function to retrieve original skb device using NAPI ID
net: add new control message for incoming HW-times
On Fri, Apr 28, 2017 at 04:07:29PM -0400, Willem de Bruijn wrote:
> On Fri, Apr 28, 2017 at 12:23 PM, Miroslav Lichvar <mlich...@redhat.com>
> wrote:
> > On Fri, Apr 28, 2017 at 11:50:28AM -0400, Willem de Bruijn wrote:
> >> A more elegant solution would be t
On Fri, Apr 28, 2017 at 11:50:28AM -0400, Willem de Bruijn wrote:
> On Fri, Apr 28, 2017 at 4:54 AM, Miroslav Lichvar <mlich...@redhat.com> wrote:
> >> if (skb_shinfo(skb)->tx_flags & SKBTX_SW_TSTAMP &&
> >> -!(skb_shinfo(skb)->tx_flags &a
gt;tx_flags & SKBTX_IN_PROGRESS)) ||
> + (skb->sk && skb->sk->sk_tsflags & SOF_TIMESTAMPING_OPT_TX_SWHW)
I'm not sure if this can work. sk_buff.h would need to include sock.h
in order to get the definition of struct sock. Any suggestions?
--
Miroslav Lichvar
mp(skb) || !skb_is_err_queue(skb)) &&
ktime_to_timespec_cond(shhwtstamps->hwtstamp, tss.ts + 2)) {
where skb_is_hwtx_tstamp() has
return skb->tstamp == 0 && skb_is_err_queue(skb);
I was just not sure about the unnecessary skb_is_err_queue() call.
--
Miroslav Lichvar
uld suggest another helper function
> skb_is_hwtx_tstamp with a concise comment about the race condition
> between tx software and hardware timestamps (as in the last sentence of
> the commit message).
Should it include also the skb_is_err_queue() check? If it returned
true for both TX and RX HW timestamps, maybe it could be called
skb_has_hw_tstamp?
--
Miroslav Lichvar
v2
> that extends in_pktinfo. Just a thought.
The struct would contain both the original and last interface index,
and the length as well? And similarly with in6_pktinfo?
If there is an agreement that the information would useful also for
other things than timestamping, I can try that. If not, I think it
would be better to keep it tied to HW timestamping.
--
Miroslav Lichvar
On Wed, Apr 26, 2017 at 06:54:35PM +0200, Richard Cochran wrote:
> On Wed, Apr 26, 2017 at 04:50:29PM +0200, Miroslav Lichvar wrote:
> > This patchset adds new options to the timestamping API that will be
> > useful for NTP implementations and possibly other applications.
>
message only when the skb has no software
timestamp or it is an incoming packet.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
Documentation/networking/tim
dds a new option to request both software and hardware
timestamps for outgoing packets. The sixth patch updates drivers that
assumed software timestamping cannot be used together with hardware
timestamping.
The patches have been tested on x86_64 machines with igb and e1000e
drivers.
Miroslav Lichvar
Add HWTSTAMP_FILTER_NTP_ALL to the hwtstamp_rx_filters enum for
timestamping of NTP packets. There is currently only one driver
(phyter) that could support it directly.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Li
with enabled CONFIG_NET_RX_BUSY_POLL and drivers using napi,
which should cover all current MAC drivers that support hardware
timestamping.
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlic
Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 1 +
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 +
drivers/net/ethernet/cavium/liquidio/lio_main.c| 1 +
drivers/net/ethern
timestamp
only if it's for a received packet (i.e. it's not in the error queue).
CC: Richard Cochran <richardcoch...@gmail.com>
CC: Willem de Bruijn <will...@google.com>
Signed-off-by: Miroslav Lichvar <mlich...@redhat.com>
---
net/socket.c | 3 ++-
1 file changed, 2 insertions(+), 1
1 - 100 of 126 matches
Mail list logo
