Since the proper way to check the hw lro capability is by the chip id,
hwlro property in the device tree should be removed.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
Documentation/devicetree/bindings/net/mediatek-net.txt | 2 --
1 file changed, 2 deletions(-)
diff
Because hw lro started to be supported from MT7623, the proper way to check if
the feature is capable is to judge by the chip id instead of by the dtsi.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 14 --
drive
is capable is to judge by the chip id instead of by the dtsi.
Nelson Chang (3):
net: ethernet: mediatek: get the chip id by ETHDMASYS registers
net: ethernet: mediatek: get hw lro capability by the chip id instead
of by the dtsi
net: ethernet: mediatek: remove hwlro property in the device
The driver gets the chip id by ETHSYS_CHIPID0_3/ETHSYS_CHIPID4_7 registers
in mtk_probe().
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 29 +
drivers/net/ethernet/mediatek/mtk_eth_soc.h | 5 +
2
nal Message-
From: David Laight [mailto:david.lai...@aculab.com]
Sent: Wednesday, October 05, 2016 9:07 PM
To: Nelson Chang (張家祥); sergei.shtyl...@cogentembedded.com;
j...@phrozen.org; da...@davemloft.net
Cc: n...@openwrt.org; netdev@vger.kernel.org;
linux-media...@lists.infradead.org; nelso
tembedded.com]
Sent: Wednesday, October 05, 2016 8:18 PM
To: Nelson Chang (張家祥); j...@phrozen.org; da...@davemloft.net
Cc: n...@openwrt.org; netdev@vger.kernel.org;
linux-media...@lists.infradead.org; nelsonch...@gmail.com
Subject: Re: [PATCH net-next v2 2/3] net: ethernet: mediatek: get hw lro
cap
Hi Sergei,
Thanks for your comments.
Modified.
Nelson
-Original Message-
From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
Sent: Wednesday, October 05, 2016 8:18 PM
To: Nelson Chang (張家祥); j...@phrozen.org; da...@davemloft.net
Cc: n...@openwrt.org; netdev
The driver gets the chip id by ETHSYS_CHIPID0_3/ETHSYS_CHIPID4_7 registers
in mtk_probe().
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 29 +
drivers/net/ethernet/mediatek/mtk_eth_soc.h | 5 +
2
Since the proper way to check the hw lro capability is by the chip id,
hwlro property in the device tree should be removed.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
Documentation/devicetree/bindings/net/mediatek-net.txt | 2 --
1 file changed, 2 deletions(-)
diff
Because hw lro started to be supported from MT7623, the proper way to check if
the feature is capable is to judge by the chip id instead of by the dtsi.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 12 ++--
drivers/net/et
.
Nelson Chang (3):
net: ethernet: mediatek: get the chip id by ETHDMASYS registers
net: ethernet: mediatek: get hw lro capability by the chip id instead
of by the dtsi
net: ethernet: mediatek: remove hwlro property in the device tree
.../devicetree/bindings/net/mediatek-net.txt | 2
.
Nelson Chang (3):
net: ethernet: mediatek: get the chip id by ETHDMASYS registers
net: ethernet: mediatek: get hw lro capability by the chip id instead
of by the dtsi
net: ethernet: mediatek: remove hwlro property in the device tree
.../devicetree/bindings/net/mediatek-net.txt | 2
Since the proper way to check the hw lro capability is by the chip id,
hwlro property in the device tree should be removed.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
Documentation/devicetree/bindings/net/mediatek-net.txt | 2 --
1 file changed, 2 deletions(-)
diff
The driver gets the chip id by ETHSYS_CHIPID0_3/ETHSYS_CHIPID4_7 registers
in mtk_probe().
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 29 +
drivers/net/ethernet/mediatek/mtk_eth_soc.h | 5 +
2
Because hw lro started to be supported from MT7623, the proper way to check if
the feature is capable is to judge by the chip id instead of by the dtsi.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 12 ++--
drivers/net/et
o:j...@phrozen.org]
Sent: Tuesday, October 04, 2016 3:19 AM
To: Nelson Chang (張家祥); da...@davemloft.net
Cc: netdev@vger.kernel.org; n...@openwrt.org;
linux-media...@lists.infradead.org; nelsonch...@gmail.com
Subject: Re: [PATCH net-next 2/3] net: ethernet: mediatek: get hw lro
capability by the chip
e *pdev)
{
...
err = mtk_get_chip_id(eth, >chip_id);
if (err)
return err;
...
}
Nelson
-Original Message-
From: John Crispin [mailto:j...@phrozen.org]
Sent: Tuesday, October 04, 2016 3:17 AM
To: Nelson Chang (張家祥); da...@da
Since the proper way to check the hw lro capability is by the chip id,
hwlro property in the device tree should be removed.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
Documentation/devicetree/bindings/net/mediatek-net.txt | 2 --
1 file changed, 2 deletions(-)
diff
The driver gets the chip id by ETHSYS_CHIPID0_3/ETHSYS_CHIPID4_7 registers
in mtk_probe().
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 27 +++
drivers/net/ethernet/mediatek/mtk_eth_soc.h | 5 +
2
The series modify to check if hw lro is supported by the chip id.
Because hw lro started to be supported from MT7623, the proper way to check if
the feature is capable is to judge by the chip id instead of by the dtsi.
Nelson Chang (3):
net: ethernet: mediatek: get the chip id by ETHDMASYS
Because hw lro started to be supported from MT7623, the proper way to check if
the feature is capable is to judge by the chip id instead of by the dtsi.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 12 ++--
drivers/net/et
Got it. I'll notice that for later patches.
Thanks David.
-Original Message-
From: David Miller [mailto:da...@davemloft.net]
Sent: Tuesday, September 27, 2016 9:42 PM
To: Nelson Chang (張家祥)
Cc: j...@phrozen.org; n...@openwrt.org; netdev@vger.kernel.org;
linux-media...@lists.infradead.org
Hi Sergei,
Because these modifications are both related to LRO relinquishments, I
put them in a single patch.
Nelson
-Original Message-
From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
Sent: Monday, September 26, 2016 7:21 PM
To: Nelson Chang (張家祥); j...@phrozen.org
Stop PDMA while the frame engine is going to stop.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
b/drivers/net/ethernet/me
(1) Modify the register settings for LRO relinquishments
(2) Jump out from the waiting loop while LRO relinquishments are done
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 +
drivers/net/ethernet/mediatek/mtk_eth_soc.h | 4 +
1) Add to stop PDMA while stopping the frame engine
2) Modify the register settings for LRO relinquishments
3) Jump out from the waiting loop while LRO relinquishments are done
Nelson Chang (2):
net: ethernet: mediatek: add to stop PDMA while stopping the frame
engine
net: ethernet
NETIF_F_LRO off while RX flow is programmed
- Rephrase the dts property is a capability if the hardware supports LRO
changes since v1:
- Add HW LRO support
- Add ethtool hooks to set LRO RX flows
Nelson Chang (3):
net: ethernet: mediatek: add HW LRO functions of PDMA RX rings
net: ethernet
Add the dts property for the capability if the hardware supports LRO.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
Documentation/devicetree/bindings/net/mediatek-net.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindin
set total four destination IPs, each
GMAC (GMAC1/GMAC2) can set two IPs separately at most.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 236
1 file changed, 236 insertions(+)
diff --git a/drivers/net/et
.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 215 +---
drivers/net/ethernet/mediatek/mtk_eth_soc.h | 75 +-
2 files changed, 265 insertions(+), 25 deletions(-)
diff --git a/drivers/net/ethernet/me
NETIF_F_LRO off while RX flow is programmed
- Rephrase the dts property is a capability if the hardware supports LRO
changes since v1:
- Add HW LRO support
- Add ethtool hooks to set LRO RX flows
Nelson Chang (3):
net: ethernet: mediatek: add HW LRO functions of PDMA RX rings
net: ethernet
Thanks David!
I'll respin the patch and submit the newer version.
-Original Message-
From: David Miller [mailto:da...@davemloft.net]
Sent: Saturday, September 17, 2016 9:46 PM
To: Nelson Chang (張家祥)
Cc: j...@phrozen.org; f.faine...@gmail.com; n...@openwrt.org;
netdev@vger.kernel.org
changes since v1:
- Add HW LRO support
- Add ethtool hooks to set LRO RX flows
Nelson Chang (3):
net: ethernet: mediatek: add HW LRO functions of PDMA RX rings
net: ethernet: mediatek: add ethtool functions to configure RX flows
of HW LRO
net: ethernet: mediatek: add dts configuration
.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 215 +---
drivers/net/ethernet/mediatek/mtk_eth_soc.h | 75 +-
2 files changed, 265 insertions(+), 25 deletions(-)
diff --git a/drivers/net/ethernet/me
Add the dts property for the capability if the hardware supports LRO.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
Documentation/devicetree/bindings/net/mediatek-net.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/mediatek-net.
set total four destination IPs, each
GMAC (GMAC1/GMAC2) can set two IPs separately at most.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 236
1 file changed, 236 insertions(+)
diff --git a/drivers/net/et
[mailto:f.faine...@gmail.com]
Sent: Wednesday, September 14, 2016 2:27 AM
To: Nelson Chang (張家祥); j...@phrozen.org; da...@davemloft.net
Cc: n...@openwrt.org; netdev@vger.kernel.org;
linux-media...@lists.infradead.org; nelsonch...@gmail.com
Subject: Re: [PATCH net-next 2/3] net: ethernet: mediatek: add ethtool
, September 14, 2016 2:25 AM
To: Nelson Chang (張家祥); j...@phrozen.org; da...@davemloft.net
Cc: n...@openwrt.org; netdev@vger.kernel.org;
linux-media...@lists.infradead.org; nelsonch...@gmail.com
Subject: Re: [PATCH net-next 3/3] net: ethernet: mediatek: add dts
configuration to enable HW LRO
On 09/13/2016
.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 215 +---
drivers/net/ethernet/mediatek/mtk_eth_soc.h | 75 +-
2 files changed, 265 insertions(+), 25 deletions(-)
diff --git a/drivers/net/ethernet/me
Add the configuration of HW LRO in the binding document.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
Documentation/devicetree/bindings/net/mediatek-net.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/mediatek-net.
set total four destination IPs, each
GMAC (GMAC1/GMAC2) can set two IPs separately at most.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 218
1 file changed, 218 insertions(+)
diff --git a/drivers/net/et
The patches add the large receive offload (LRO) functions by hardware and
the ethtool functions to configure RX flows of HW LRO.
Nelson Chang (3):
net: ethernet: mediatek: add HW LRO functions of PDMA RX rings
net: ethernet: mediatek: add ethtool functions to configure RX flows
of HW LRO
Because the PDMA has richer features than the QDMA for Ethernet RX
(such as multiple RX rings, HW LRO, etc.),
the patch modifies to use the PDMA to handle Ethernet RX.
Acked-by: John Crispin <j...@phrozen.org>
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/
Because we change to use the PDMA as the Ethernet RX DMA engine,
the patch modifies to set GDM to send packets to PDMA for RX.
Acked-by: John Crispin <j...@phrozen.org>
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 3 +--
1
and interrupt settings in mtk_poll_rx()
changes since v1:
- Modify to use the PDMA instead of the QDMA for Ethernet RX
Nelson Chang (2):
net: ethernet: mediatek: modify to use the PDMA instead of the QDMA
for Ethernet RX
net: ethernet: mediatek: modify GDM to send packets to the PDMA for RX
drivers
Because the PDMA has richer features than the QDMA for Ethernet RX
(such as multiple RX rings, HW LRO, etc.),
the patch modifies to use the PDMA to handle Ethernet RX.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.
This patch set fixes the following issues
v1 -> v2: Fix the bugs of PDMA cpu index and interrupt settings in mtk_poll_rx()
v2 -> v3: Add GDM hardware settings to send packets to PDMA for RX
Nelson Chang (2):
net: ethernet: mediatek: modify to use the PDMA instead of the QDMA
for Et
Because the PDMA has richer features than the QDMA for Ethernet RX
(such as multiple RX rings, HW LRO, etc.),
the patch modifies to use the PDMA to handle Ethernet RX.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.
Because the PDMA has richer features than the QDMA for Ethernet RX
(such as multiple RX rings, HW LRO, etc.),
the patch modifies to use the PDMA to handle Ethernet RX.
Signed-off-by: Nelson Chang <nelson.ch...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.
49 matches
Mail list logo
