Re: [PATCH net-next v2 0/3] net: bridge: convert multicast to generic rhashtable

On 12/4/18 5:01 PM, Nikolay Aleksandrov wrote: > Hi, > The current bridge multicast code uses a custom rhashtable > implementation which predates the generic rhashtable API. Patch 01 > converts it to use the generic kernel rhashtable which simplifies the > code a lot and rem

[PATCH net-next v2 1/3] net: bridge: convert multicast to generic rhashtable

to be a power of 2. v2: handle when IGMP snooping is undefined, add br_mdb_init/uninit placeholders Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_device.c| 10 + net/bridge/br_mdb.c | 120 +--- net/bridge/br_multicast.c | 403 ++ net/bridge

[PATCH net-next v2 3/3] net: bridge: increase multicast's default maximum number of entries

bridge's default hash_max was 512 which is rather conservative, now that we're using the generic rhashtable API which autoshrinks let's increase it to 4096 and move it to a define in br_private.h. Signed-off-by: Nikolay Aleksandrov --- v2: no change net/bridge/br_multicast.c | 2 +- net/bridge

[PATCH net-next v2 2/3] net: bridge: mark hash_elasticity as obsolete

-by: Nikolay Aleksandrov --- v2: no change net/bridge/br_multicast.c | 1 - net/bridge/br_netlink.c | 11 --- net/bridge/br_private.h | 1 - net/bridge/br_sysfs_br.c | 6 +++--- 4 files changed, 7 insertions(+), 12 deletions(-) diff --git a/net/bridge/br_multicast.c b/net/bridge

[PATCH net-next v2 0/3] net: bridge: convert multicast to generic rhashtable

with the default hash maximum so patch 03 increases it to 4096 and moves it to a define in br_private.h. v2: send the latest version of the set which handles when IGMP snooping is not defined, changes are in patch 01 Thanks, Nik Nikolay Aleksandrov (3): net: bridge: convert multicast to generic

Re: [PATCH net-next 0/3] net: bridge: convert multicast to generic rhashtable

On 04/12/2018 16:44, Nikolay Aleksandrov wrote: > Hi, > The current bridge multicast code uses a custom rhashtable > implementation which predates the generic rhashtable API. Patch 01 > converts it to use the generic kernel rhashtable which simplifies the > code a lot and rem

[PATCH net-next 2/3] net: bridge: mark hash_elasticity as obsolete

-by: Nikolay Aleksandrov --- net/bridge/br_multicast.c | 1 - net/bridge/br_netlink.c | 11 --- net/bridge/br_private.h | 1 - net/bridge/br_sysfs_br.c | 6 +++--- 4 files changed, 7 insertions(+), 12 deletions(-) diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index

[PATCH net-next 3/3] net: bridge: increase multicast's default maximum number of entries

bridge's default hash_max was 512 which is rather conservative, now that we're using the generic rhashtable API which autoshrinks let's increase it to 4096 and move it to a define in br_private.h. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_multicast.c | 2 +- net/bridge/br_private.h

[PATCH net-next 0/3] net: bridge: convert multicast to generic rhashtable

with the default hash maximum so patch 03 increases it to 4096 and moves it to a define in br_private.h. Thanks, Nik Nikolay Aleksandrov (3): net: bridge: convert multicast to generic rhashtable net: bridge: mark hash_elasticity as obsolete net: bridge: increase multicast's default maximum number

[PATCH net-next 1/3] net: bridge: convert multicast to generic rhashtable

to be a power of 2. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_device.c| 11 ++ net/bridge/br_mdb.c | 120 +--- net/bridge/br_multicast.c | 402 ++ net/bridge/br_private.h | 33 ++-- 4 files changed, 139 insertions(+), 427 deletions(-) diff

Re: [net:master 17/19] net//bridge/br_multicast.c:1432:32: error: 'union ' has no member named 'ip6'; did you mean 'ip4'?

On 27/10/2018 03:50, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master > head: aab456dfa404f3a16d6f1780e62a6a8533c4d008 > commit: 5a2de63fd1a59c30c02526d427bc014b98adf508 [17/19] bridge: do not add > port to router list when receives query

Re: [PATCH net] net: ipmr: fix unresolved entry dumps

On 17/10/2018 22:34, Nikolay Aleksandrov wrote: > If the skb space ends in an unresolved entry while dumping we'll miss > some unresolved entries. The reason is due to zeroing the entry counter > between dumping resolved and unresolved mfc entries. We should just > keep counting unt

[PATCH net] net: ipmr: fix unresolved entry dumps

have a separate table counter. Reported-by: Colin Ian King Fixes: 8fb472c09b9d ("ipmr: improve hash scalability") Signed-off-by: Nikolay Aleksandrov --- Dropped Yuval's mail because it bounces. net/ipv4/ipmr_base.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ipv4/ipmr_ba

Re: ipmr, ip6mr: Unite dumproute flows

Incrementing e. The value of e is now 1. >incr: Incrementing e. The value of e is now 2. > > 336 e++; > > > Note that the zero'ing of e and s_e for ipmr and ip6mr was added in by > earlier commits: > > commit 8fb472c09b9df478a062eacc7841448e40fc3c17

Re: [PATCH iproute2 net-next] bridge: add support for backup port

On October 12, 2018 6:40:28 PM GMT+03:00, Stephen Hemminger wrote: >On Fri, 12 Oct 2018 14:42:55 +0300 >Nikolay Aleksandrov wrote: > >> This patch adds support for the new backup port option that can be >set >> on a bridge port. If the port's carrier goes down al

[PATCH iproute2 net-next] bridge: add support for backup port

for vlan_tunnel in ip-link man page (to be consistent with the rest) Signed-off-by: Nikolay Aleksandrov --- bridge/link.c| 26 ++ ip/iplink_bridge_slave.c | 18 ++ man/man8/bridge.8| 13 - man/man8/ip-link.8.in| 14

Re: [PATCH] MAINTAINERS: change bridge maintainers

drivers/net/ethernet/agere/ > > ETHERNET BRIDGE > -M: Stephen Hemminger > +M: Roopa Prabhu > +M: Nikolay Aleksandrov > L: bri...@lists.linux-foundation.org (moderated for non-subscribers) > L: netdev@vger.kernel.org > W: http://www.linuxfoundation.org/en/Net:Bridge > Thank you, Acked-by: Nikolay Aleksandrov

[PATCH iproute2 net-next] bridge: fdb: add support for sticky flag

Add support for the new sticky flag that can be set on fdbs and update the man page. CC: David Ahern Signed-off-by: Nikolay Aleksandrov --- bridge/fdb.c | 9 +++-- man/man8/bridge.8 | 6 +- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/bridge/fdb.c b/bridge/fdb.c

[PATCH net-next] selftests: forwarding: test for bridge sticky flag

This test adds an fdb entry with the sticky flag and sends traffic from a different port with the same mac as a source address expecting the entry to not change ports if the flag is operating correctly. Signed-off-by: Nikolay Aleksandrov --- .../selftests/net/forwarding/bridge_sticky_fdb.sh

[PATCH net-next] net: bridge: explicitly zero is_sticky in fdb_create

We need to explicitly zero is_sticky when creating a new fdb, otherwise we might get a stale value for a new entry. Fixes: 435f2e7cc0b7 ("net: bridge: add support for sticky fdb entries") Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_fdb.c | 1 + 1 file changed, 1 insertio

[PATCH net-next] bonding: don't cast const buf in sysfs store

As was recently discussed [1], let's avoid casting the const buf in bonding_sysfs_store_option and use kstrndup/kfree instead. [1] http://lists.openwall.net/netdev/2018/07/22/25 Signed-off-by: Nikolay Aleksandrov --- drivers/net/bonding/bond_sysfs.c | 7 ++- 1 file changed, 6 insertions

Re: 答复: [PATCH][net-next] bridge: clean up mtu_set_by_user setting to false and comments

On 13/07/18 12:11, Li,Rongqing wrote: > > >> -邮件原件----- >> 发件人: Nikolay Aleksandrov [mailto:niko...@cumulusnetworks.com] >> 发送时间: 2018年7月13日 16:01 >> 收件人: Li,Rongqing ; netdev@vger.kernel.org >> 主题: Re: [PATCH][net-next] bridge: clean up mtu_set_by_u

[PATCH net-next] net: ipmr: add support for passing full packet on wrong vif

. Signed-off-by: Nikolay Aleksandrov --- We have been running with this patch for over an year and FRRouting fully supports this WRVIFWHOLE message officially. Actually it uses both WRONGVIF and WRVIFWHOLE for different purposes right now. include/linux/mroute_base.h | 1 + include/uapi/linux/mroute.h

Re: [PATCH][net-next] bridge: clean up mtu_set_by_user setting to false and comments

s and the bridge follows the minimum MTU. ... " > and br_mtu_auto_adjust will run only if mtu_set_by_user is > false, so not need to set it to false again > > Cc: Nikolay Aleksandrov > Signed-off-by: Li RongQing > --- > net/bridge/br_device.c | 1 - > net/bridge/br_if.c | 4

[PATCH net-next 1/2] selftests: forwarding: lib: extract ping and ping6 so they can be reused

Extract ping and ping6 command execution so the return value can be checked by the caller, this is needed for port isolation tests that are intended to fail. Signed-off-by: Nikolay Aleksandrov --- tools/testing/selftests/net/forwarding/lib.sh | 22 -- 1 file changed, 16

[PATCH iproute2 net-next] bridge: add support for isolated option

isolated on $ bridge link set dev eth0 isolated on Signed-off-by: Nikolay Aleksandrov --- bridge/link.c| 11 +++ ip/iplink_bridge_slave.c | 9 + man/man8/bridge.8| 6 ++ man/man8/ip-link.8.in| 6 -- 4 files changed, 30 insertions(+), 2 deletions

[PATCH net-next 2/2] selftests: forwarding: test for bridge port isolation

. Signed-off-by: Nikolay Aleksandrov --- .../net/forwarding/bridge_port_isolation.sh| 151 + 1 file changed, 151 insertions(+) create mode 100755 tools/testing/selftests/net/forwarding/bridge_port_isolation.sh diff --git a/tools/testing/selftests/net/forwarding

[PATCH net-next 0/2] bridge: iproute2 isolated port and selftests

Add support to iproute2 for port isolation config and selftests for it. Nikolay Aleksandrov (2): selftests: forwarding: lib: extract ping and ping6 so they can be reused selftests: forwarding: test for bridge port isolation .../net/forwarding/bridge_port_isolation.sh| 151

Re: [PATCH net-next] net: bridge: Lock before br_fdb_find()

On 28/05/18 18:52, Nikolay Aleksandrov wrote: > On 28/05/18 18:44, Petr Machata wrote: >> Callers of br_fdb_find() need to hold the hash lock, which >> br_fdb_find_port() doesn't do. Add the missing lock/unlock >> pair. >> >> Signed-off-by: Petr Machata <pe...

Re: [PATCH net-next] net: bridge: Lock before br_fdb_find()

return NULL; > > br = netdev_priv(br_dev); > + spin_lock_bh(>hash_lock); > f = br_fdb_find(br, addr, vid); > if (f && f->dst) > dev = f->dst->dev; > + spin_unlock_bh(>hash_lock); > >

Re: [PATCH net-next 6/7] net: bridge: Notify about bridge VLANs

on orig_dev to determine whether the > notification is about a bridge port or a bridge. > > Signed-off-by: Petr Machata <pe...@mellanox.com> > --- > net/bridge/br_vlan.c | 14 ++ > 1 file changed, 14 insertions(+) > Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

+++- > 1 file changed, 23 insertions(+), 21 deletions(-) > Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

[PATCH net-next] net: bridge: add support for port isolation

port test in should_deliver. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/linux/if_bridge.h| 1 + include/uapi/linux/if_link.h | 1 + net/bridge/br_forward.c | 3 ++- net/bridge/br_input.c| 1 + net/bridge/br_netlink.c | 9 - net/

Re: [PATCH net] ipmr: properly check rhltable_init() return value

ockopt net/socket.c:1911 [inline] > __x64_sys_setsockopt+0xbe/0x150 net/socket.c:1911 > do_syscall_64+0x1b1/0x800 arch/x86/entry/common.c:287 > entry_SYSCALL_64_after_hwframe+0x49/0xbe > > Fixes: 8fb472c09b9d ("ipmr: improve hash scalability") > Fixes: 0bbbf0e7d0e7 ("ipmr, ip6mr: Uni

Re: [PATCH net-next 1/4] net: bridge: Allow bridge master in br_vlan_get_info()

rtnl(dev); > if (p) > vg = nbp_vlan_group(p); > + else if (netif_is_bridge_master(dev)) > + vg = br_vlan_group(netdev_priv(dev)); > else > return -EINVAL; > > Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next] net: dsa: fix added_by_user switchdev notification

_work, - fdb_info)) + if (dsa_slave_switchdev_fdb_work_init(switchdev_work, ptr)) goto err_fdb_work_init; dev_hold(dev); break; Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next mlxsw v2 2/2] net: bridge: Notify about !added_by_user FDB entries

etions(-) Thanks, looks good to me! In the future please add the reviewers to the CC list when sending a v2, I actually missed the v2 set and saw your reply to the cover letter patch later. Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

[PATCH net-next] net: bridge: avoid duplicate notification on up/down/change netdev events

, check if one has already been sent (i.e. br_stp_enable/disable_port have been called). The patch is based on a change by Satish Ashok. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- We've been running with a similar patch for over an year, it's been thoroughly tested. S

Re: [PATCH net-next 1/2] switchdev: Add fdb.added_by_user to switchdev notifications

lave.c | 5 - 5 files changed, 18 insertions(+), 4 deletions(-) Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next 2/2] net: bridge: Notify about !added_by_user FDB entries

On 01/05/18 20:04, Petr Machata wrote: Do not automatically bail out on sending notifications about activity on non-user-added FDB entries. Instead, notify about this activity except for cases where the activity itself originates in a notification, to avoid sending duplicate notifications.

Re: [PATCH net-next v3 6/6] mlxsw: spectrum_span: Allow bridge for gretap mirror

rum_span.c| 95 -- .../net/ethernet/mellanox/mlxsw/spectrum_span.h| 1 + 2 files changed, 90 insertions(+), 6 deletions(-) Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next v3 1/6] net: bridge: Publish bridge accessor functions

x/if_bridge.h | 28 net/bridge/br_fdb.c | 22 ++ net/bridge/br_private.h | 11 +++ net/bridge/br_vlan.c | 39 +++ 4 files changed, 100 insertions(+) Looks good, Signed-off-by: Nikolay

Re: [PATCHv2 net] bridge: check iface upper dev when setting master via ioctl

g devices that dislike that (e.g. wireless) */ Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next v2 1/6] net: bridge: Publish bridge accessor functions

On 27/04/18 19:08, Petr Machata wrote: > Nikolay Aleksandrov <niko...@cumulusnetworks.com> writes: > >> On 27/04/18 18:11, Ido Schimmel wrote: >>> From: Petr Machata <pe...@mellanox.com> >>> >>> Add a couple new functions to allow querying FDB an

Re: [PATCH net-next v2 6/6] mlxsw: spectrum_span: Allow bridge for gretap mirror

t; --- > .../net/ethernet/mellanox/mlxsw/spectrum_span.c| 95 > -- > .../net/ethernet/mellanox/mlxsw/spectrum_span.h| 1 + > 2 files changed, 90 insertions(+), 6 deletions(-) > Looks good, thanks! Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next v2 1/6] net: bridge: Publish bridge accessor functions

nged, 100 insertions(+) > Thanks! This looks good to me although the new exported helpers could've taken both bridge or port and return the result. Usually when adding a port-only functions we name them with nbp_ prefix instead of br_. Anyway this can be done later since the API is internal, Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net] bridge: check iface upper dev when setting master via ioctl

On 27/04/18 04:31, Hangbin Liu wrote: Hi Nikolay, Thanks for the comments. On Thu, Apr 26, 2018 at 05:22:46PM +0300, Nikolay Aleksandrov wrote: Not all upper devs are masters. This can break some setups. Ah, like vlan device.. So how about + if (netdev_master_upper_dev_get(dev

Re: [PATCH net-next] bridge: use hlist_entry_safe

)lport > (unsigned long)rport) { > port = lport; > Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net] bridge: check iface upper dev when setting master via ioctl

On 26/04/18 17:00, Nikolay Aleksandrov wrote: > On 26/04/18 16:56, Hangbin Liu wrote: >> When we set a bond slave's master to bridge via ioctl, we only check >> the IFF_BRIDGE_PORT flag. Although we will find the slave's real master >> at netdev_master_upper_dev_link() later,

Re: [PATCH net] bridge: check iface upper dev when setting master via ioctl

On 26/04/18 16:56, Hangbin Liu wrote: > When we set a bond slave's master to bridge via ioctl, we only check > the IFF_BRIDGE_PORT flag. Although we will find the slave's real master > at netdev_master_upper_dev_link() later, it already does some settings > and allocates some resources. So it

Re: WARNING: kobject bug in br_add_if

On 26/04/18 14:49, Nikolay Aleksandrov wrote: On 26/04/18 13:37, Hangbin Liu wrote: On Thu, Apr 26, 2018 at 10:04:16AM +0200, Dmitry Vyukov wrote: On Thu, Apr 26, 2018 at 8:13 AM, Hangbin Liu <liuhang...@gmail.com> wrote: On Wed, Apr 11, 2018 at 05:18:23PM +0200, Dmitry Vyukov wrote:

Re: WARNING: kobject bug in br_add_if

On 26/04/18 13:37, Hangbin Liu wrote: On Thu, Apr 26, 2018 at 10:04:16AM +0200, Dmitry Vyukov wrote: On Thu, Apr 26, 2018 at 8:13 AM, Hangbin Liu wrote: On Wed, Apr 11, 2018 at 05:18:23PM +0200, Dmitry Vyukov wrote: On Wed, Apr 11, 2018 at 5:15 PM, syzbot

Re: [PATCH net-next 6/6] mlxsw: spectrum_span: Allow bridge for gretap mirror

On 26/04/18 12:06, Ido Schimmel wrote: From: Petr Machata When handling mirroring to a gretap or ip6gretap netdevice in mlxsw, the underlay address (i.e. the remote address of the tunnel) may be routed to a bridge. In that case, look up the resolved neighbor Ethernet

Re: [RFC PATCH] net: bridge: multicast querier per VLAN support

On April 18, 2018 6:54:07 PM GMT+03:00, Stephen Hemminger <step...@networkplumber.org> wrote: >On Wed, 18 Apr 2018 16:14:26 +0300 >Nikolay Aleksandrov <niko...@cumulusnetworks.com> wrote: > >> On 18/04/18 16:07, Joachim Nilsson wrote: >> > On Wed, Apr 1

Re: [RFC PATCH] net: bridge: multicast querier per VLAN support

On 18/04/18 16:07, Joachim Nilsson wrote: > On Wed, Apr 18, 2018 at 03:31:57PM +0300, Nikolay Aleksandrov wrote: >> On 18/04/18 15:07, Joachim Nilsson wrote: >>> - First of all, is this patch useful to anyone >> Obviously to us as it's based on our patch. :-) >> We ac

Re: [RFC PATCH] net: bridge: multicast querier per VLAN support

On 18/04/18 15:07, Joachim Nilsson wrote: This RFC patch¹ is an attempt to add multicast querier per VLAN support to a VLAN aware bridge. I'm posting it as RFC for now since non-VLAN aware bridges are not handled, and one of my questions is if that is complexity we need to continue supporting?

Re: [PATCH] net: bridge: add missing NULL checks

On 08/04/18 20:49, Laszlo Toth wrote: br_port_get_rtnl() can return NULL Signed-off-by: Laszlo Toth <lasz...@gmail.com> --- net/bridge/br_netlink.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) Nacked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH] net: bond: skip vlan header when do layer 3+4 hash policy

On 31/03/18 12:14, liujia...@huawei.com wrote: From: liujian When the hash policy is BOND_XMIT_POLICY_LAYER34 mode and skb protocol is 802.1q VLAN, the policy will be degenerated to LAYER2 mode; Now, change it to get the next layer protocol to ensure that it worked in

[PATCH net-next 2/2] net: bridge: disable bridge MTU auto tuning if it was set manually

. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- net/bridge/br.c | 2 +- net/bridge/br_device.c | 5 ++--- net/bridge/br_if.c | 36 +--- net/bridge/br_private.h | 3 ++- 4 files changed, 26 insertions(+), 20 deletions(-)

[PATCH net-next 1/2] net: bridge: set min MTU on port events and allow user to set max

Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- net/bridge/br.c | 2 +- net/bridge/br_device.c | 3 ++- net/bridge/br_if.c | 43 ++- net/bridge/br_private.h | 2 +- 4 files changed, 18 insertions(+), 32 deletions(-)

[PATCH net-next 0/2] net: bridge: MTU handling changes

are intentionally split like this, so that if they get accepted and there are any complaints patch 02 can be reverted. Thanks, Nik Nikolay Aleksandrov (2): net: bridge: set min MTU on port events and allow user to set max net: bridge: disable bridge MTU auto tuning if it was set manually net

Re: [bpf-next PATCH] net: br_vlan build error

27 +-- > 1 file changed, 17 insertions(+), 10 deletions(-) > I'm not sure what the rules about merging are, but just in case I already fixed this in net-next couple of days ago. commit 82792a070b16 Author: Nikolay Aleksandrov <niko...@cumulusnetworks.com> Date:

Re: [PATCH net 0/3] bonding: a bunch of fixes for dev hwaddr sync in bond_enslave

On 25/03/18 20:16, Xin Long wrote: This patchset is mainly to fix a crash when adding vlan as slave of bond which is also the parent link in patch 2/3, and also fix some err process problems in bond_enslave in patch 1/3 and 3/3. Xin Long (3): bonding: fix the err path for dev hwaddr sync in

Re: [PATCH net 1/3] bonding: fix the err path for dev hwaddr sync in bond_enslave

tions with the standard ones") Signed-off-by: Xin Long <lucien@gmail.com> --- drivers/net/bonding/bond_main.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) Seems I've missed the err path back then. Thanks, Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

[PATCH net-next] net: bridge: fix direct access to bridge vlan_enabled and use helper

ing: control reaches end of non-void function [-Wreturn-type] } ^ scripts/Makefile.build:324: recipe for target 'net/bridge//br_if.o' failed Fixes: 419d14af9e07 ("bridge: Allow max MTU when multiple VLANs present") Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com&

Re: [PATCH net-next] bridge: Allow max MTU when multiple VLANs present

On 23/03/18 18:17, David Miller wrote: > From: Chas Williams <3ch...@gmail.com> > Date: Thu, 22 Mar 2018 11:34:06 -0400 > >> If the bridge is allowing multiple VLANs, some VLANs may have >> different MTUs. Instead of choosing the minimum MTU for the >> bridge interface, choose the maximum MTU of

Re: [PATCH net-next] bridge: Allow max MTU when multiple VLANs present

ge/br_private.h | 2 +- > 4 files changed, 25 insertions(+), 7 deletions(-) > Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH v3 net-next 09/10] net: Remove unused get_hash_from_flow functions

> --- > include/net/flow.h| 16 > net/core/flow_dissector.c | 16 > 2 files changed, 32 deletions(-) > Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH v3 net-next 07/10] net/ipv6: Add support for path selection using hash of 5-tuple

| 2 +- > net/ipv6/route.c | 68 > ++ > net/ipv6/sysctl_net_ipv6.c | 27 ++ > 7 files changed, 91 insertions(+), 19 deletions(-) > LGTM, Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH v3 net-next 06/10] net/ipv6: Pass skb to route lookup

> Indeed, I remember this requirement back when I was making the IPv4 changes and looked into how IPv6 is handled, skb wasn't passed down until now. Looks good to me! Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH v3 net-next 05/10] net: Rename NETEVENT_MULTIPATH_HASH_UPDATE

x.com> > --- > drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +- > include/net/netevent.h| 2 +- > net/ipv4/sysctl_net_ipv4.c| 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH v3 net-next 04/10] net/ipv6: Make rt6_multipath_hash similar to fib_multipath_hash

++ > 1 file changed, 10 insertions(+), 4 deletions(-) > Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH v3 net-next 03/10] net/ipv4: Simplify fib_multipath_hash with optional flow keys

t; Reviewed-by: Ido Schimmel <ido...@mellanox.com> > --- > net/ipv4/route.c | 24 ++-- > 1 file changed, 10 insertions(+), 14 deletions(-) > Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH v3 net-next 02/10] net: Align ip_multipath_l3_keys and ip6_multipath_l3_keys

ltipath_hash. > > Signed-off-by: David Ahern <dsah...@gmail.com> > Reviewed-by: Ido Schimmel <ido...@mellanox.com> > --- > net/ipv4/route.c | 20 +++- > net/ipv6/route.c | 4 ++-- > 2 files changed, 13 insertions(+), 11 deletions

Re: [PATCH v3 net-next 01/10] net/ipv4: Pass net to fib_multipath_hash instead of fib_info

> --- > include/net/ip_fib.h | 2 +- > net/ipv4/fib_semantics.c | 2 +- > net/ipv4/route.c | 5 ++--- > 3 files changed, 4 insertions(+), 5 deletions(-) > Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH v2 net-next 06/11] ipmr, ip6mr: Make mfc_cache a common structure

et/ipv6/ip6mr.c | 248 > +++--- > 6 files changed, 312 insertions(+), 303 deletions(-) > Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH v2 net-next 07/11] ipmr, ip6mr: Unite logic for searching in MFC cache

+-- > net/ipv4/ipmr.c | 71 ++- > net/ipv4/ipmr_base.c| 54 +++-- > net/ipv6/ip6mr.c| 74 > +++-- > 4 files changed, 134 inser

Re: [PATCH net-next v2 5/5] ipv6: route: dissect flow in input path if fib rules need it

+++- > 6 files changed, 72 insertions(+), 12 deletions(-) > Looks good, Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next v2 4/5] ipv4: route: dissect flow in input path if fib rules need it

require flow dissect > are installed. Also passes the dissected hash keys to the multipath > hash function when applicable to avoid dissecting the flow again. > icmp packets will continue to use inner header for hash > calculations (Thanks to Nikolay Aleksandrov for some review here). >

Re: [PATCH net-next v2 2/5] ipv4: fib_rules: support match on sport, dport and ip proto

_set(>sport_range) && > + !fib_rule_port_inrange(>sport_range, fl4->fl4_sport)) > + return 0; > + > + if (fib_rule_port_range_set(>dport_range) && > + !fib_rule_port_inrange(>dport_range, fl4->fl4_dport)) > + return 0; > + > return 1; > } > > Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next v2 3/5] ipv6: fib6_rules: support for match on sport, dport and ip proto

_set(>sport_range) && > + !fib_rule_port_inrange(>sport_range, fl6->fl6_sport)) > + return 0; > + > + if (fib_rule_port_range_set(>dport_range) && > + !fib_rule_port_inrange(>dport_range, fl6->fl6_dport)) > + return 0; > + > return 1; > } > > Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next v2 1/5] net: fib_rules: support for match on ip_proto, sport and dport

36 - > include/uapi/linux/fib_rules.h | 8 > net/core/fib_rules.c | 92 > +- > 3 files changed, 133 insertions(+), 3 deletions(-) > Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next 11/11] ipmr, ip6mr: Unite dumproute flows

- > 4 files changed, 230 insertions(+), 239 deletions(-) > Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next 09/11] ipmr, ip6mr: Unite vif seq functions

ns(+), 89 deletions(-) > LGTM, Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next 10/11] ip6mr: Remove MFC_NOTIFY and refactor flags

net/ipv6/ip6mr.c| 3 --- > 4 files changed, 9 insertions(+), 15 deletions(-) > Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next 08/11] ipmr, ip6mr: Unite mfc seq logic

> 4 files changed, 143 insertions(+), 178 deletions(-) > Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next 07/11] ipmr, ip6mr: Unite logic for searching in MFC cache

On 27/02/18 20:58, Yuval Mintz wrote: > ipmr and ip6mr utilize the exact same methods for searching the > hashed resolved connections, difference being only in the construction > of the hash comparison key. > > In order to unite the flow, introduce an mr_table operation set that > would contain

Re: [PATCH net-next 06/11] ipmr, ip6mr: Make mfc_cache a common structure

et/ipv6/ip6mr.c | 241 > +++--- > 6 files changed, 312 insertions(+), 297 deletions(-) > I feel uneasy about these casts all over the place, anyway functionally the patch looks fine. Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next 05/11] ipmr, ip6mr: Unite creation of new mr_table

I don't like the function definition broken with the name and type on different rows, but I guess it's a personal preference, the patch looks okay. Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next 04/11] mroute*: Make mr_table a common struct

t/netns/ipv6.h| 2 +- > net/ipv4/ipmr.c | 2 - > net/ipv6/ip6mr.c| 301 > > 6 files changed, 186 insertions(+), 187 deletions(-) > Nice, Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next 03/11] ip6mr: Align hash implementation to ipmr

; This looks like my ipmr patch ported for v6, pretty straightforward and for a long time on my TODO list. :-) Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next 02/11] ip6mr: Make mroute_sk rcu-based

net/ipv6/ip6mr.c| 45 +++-- > 3 files changed, 31 insertions(+), 22 deletions(-) LGTM, though do we need the write_lock when changing mroute6_sk after RCUfying it ? In any case that can be resolved later, Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next 01/11] ipmr,ipmr6: Define a uniform vif_device

tions(+), 63 deletions(-) > create mode 100644 include/linux/mroute_base.h > create mode 100644 net/ipv4/ipmr_base.c > Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net] bridge: Fix VLAN reference count problem

gt;refcnt, 1); > + return masterv; > } > refcount_inc(>refcnt); > > Good catch, Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next 1/5] net: fib_rules: support for match on ip_proto, sport and dport

On 25/02/18 17:04, Nikolay Aleksandrov wrote: > On 25/02/18 07:44, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> uapi for ip_proto, sport and dport range match >> in fib rules. >> >> Signed-off-by: Roopa Prabhu <ro...@c

Re: [PATCH net-next 5/5] ipv6: route: dissect flow in input path if fib rules need it

On 25/02/18 07:44, Roopa Prabhu wrote: > From: Roopa Prabhu > > Dissect flow in fwd path if fib rules require it. Controlled by > a flag to avoid penatly for the common case. Flag is set when fib > rules with sport, dport and proto match that require flow dissect > are

Re: [PATCH net-next 4/5] ipv4: route: dissect flow in input path if fib rules need it

require flow dissect > are installed. Also passes the dissected hash keys to the multipath > hash function when applicable to avoid dissecting the flow again. > icmp packets will continue to use inner header for hash > calculations (Thanks to Nikolay Aleksandrov for some review here). >

Re: [PATCH net-next 1/5] net: fib_rules: support for match on ip_proto, sport and dport

On 25/02/18 07:44, Roopa Prabhu wrote: > From: Roopa Prabhu > > uapi for ip_proto, sport and dport range match > in fib rules. > > Signed-off-by: Roopa Prabhu > --- > include/net/fib_rules.h| 31 +- >

Re: [PATCH net] net: ipv4: Set addr_type in hash_keys for forwarded case

keys.addrs.v4addrs.src; > hash_keys.addrs.v4addrs.dst = keys.addrs.v4addrs.dst; > hash_keys.ports.src = keys.ports.src; > Good catch, Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH] net: bridge: Fix uninitialized error in br_fdb_sync_static()

t ndmsg *ndm, struct nlattr *tb[], > int br_fdb_sync_static(struct net_bridge *br, struct net_bridge_port *p) > { > struct net_bridge_fdb_entry *f, *tmp; > - int err; > + int err = 0; > > ASSERT_RTNL(); > > Thanks, Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

  1   2   3   4   5   6   7   8   9   10   >