Re: [PATCH iproute2 net-next 4/5] iplink: bridge: add support for IFLA_BR_MCAST_IGMP_VERSION

++ > 1 file changed, 13 insertions(+) > Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH iproute2 net-next 0/5] add latest bridge netlink options

On 17/01/17 10:32, Hangbin Liu wrote: > Add the bridge netlink attributes added to kernel recently. > > Hangbin Liu (5): > iplink: bridge: add support for IFLA_BR_FDB_FLUSH > iplink: bridge: add support for IFLA_BR_VLAN_STATS_ENABLED > iplink: bridge: add support for

Re: [PATCH iproute2 net-next 2/5] iplink: bridge: add support for IFLA_BR_VLAN_STATS_ENABLED

On 17/01/17 10:32, Hangbin Liu wrote: > This patch implements support for the IFLA_BR_VLAN_STATS_ENABLED > attribute in iproute2 so it can change the vlan state. > > Signed-off-by: Hangbin Liu > --- Again it is not state, it is _stats_. Please change the name to something

Re: [PATCH iproute2 net-next 3/5] iplink: bridge: add support for IFLA_BR_MCAST_STATS_ENABLED

On 17/01/17 10:32, Hangbin Liu wrote: > This patch implements support for the IFLA_BR_MCAST_STATS_ENABLED > attribute in iproute2 so it can change the mcast state. > > Signed-off-by: Hangbin Liu > --- It is not state, it is _stats_. Calling it mcast_state is completely

[PATCH iproute2] bridge: fdb: add state filter support

This patch adds a new argument to the bridge fdb show command that allows to filter by entry state. Also update the man page to include all available show arguments. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- bridge/fdb.c | 32 ++-

[PATCH net-next] ipmr: improve hash scalability

with 2000 entries before. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/linux/mroute.h | 57 --- net/ipv4/ipmr.c| 255 +++-- 2 files changed, 182 insertions(+), 130 deletions(-) diff --git a/include

Re: [PATCH net-next] bridge: multicast to unicast

On 02/01/17 20:32, Linus Lüssing wrote: Implements an optional, per bridge port flag and feature to deliver multicast packets to any host on the according port via unicast individually. This is done by copying the packet per host and changing the multicast destination MAC to a unicast one

[PATCH net-next] ipmr, ip6mr: add RTNH_F_UNRESOLVED flag to unresolved cache entries

them add a new RTNH_F_UNRESOLVED flag which is set when sending an unresolved cache entry to user-space. Suggested-by: Roopa Prabhu <ro...@cumulusnetworks.com> Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/uapi/linux/rtnetlink.h | 1 + net

[PATCH net-next 0/2] bridge: add support for IGMPv3 and MLDv2 querier

o sort out. Thank you, Nik Nikolay Aleksandrov (2): bridge: mcast: add IGMPv3 query support bridge: mcast: add MLDv2 querier support include/uapi/linux/if_link.h | 2 + net/bridge/br_multicast.c| 166 +-- net/bridge/br_netlink.c | 34

[PATCH net-next 1/2] bridge: mcast: add IGMPv3 query support

adjustments in br_multicast_new_group and br_multicast_add_group. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/uapi/linux/if_link.h | 1 + net/bridge/br_multicast.c| 79 ++-- net/bridge/br_netlink.c | 15

[PATCH net-next 2/2] bridge: mcast: add MLDv2 querier support

This patch adds basic support for MLDv2 queries, the default is MLDv1 as before. A new multicast option - multicast_mld_version, adds the ability to change it between 1 and 2 via netlink and sysfs. The MLD option is disabled if CONFIG_IPV6 is disabled. Signed-off-by: Nikolay Aleksandrov <n

Re: [PATCH net-next] bridge: add igmpv3 and mldv2 query support

On 18/11/16 11:09, Nikolay Aleksandrov wrote: On 18/11/16 11:04, Nikolay Aleksandrov wrote: (+CC Roopa) Hi Hangbin, This patch is not correct, you should not use the net device IGMP config in the bridge. * bridge net device, sorry not port These packets may never make it to the host

Re: [PATCH net-next] bridge: add igmpv3 and mldv2 query support

On 18/11/16 11:04, Nikolay Aleksandrov wrote: On 18/11/16 08:32, Hangbin Liu wrote: Add bridge IGMPv3 and MLDv2 query support. But before we think it is stable enough, only enable it when declare in force_igmp/mld_version. Signed-off-by: Hangbin Liu <liuhang...@gmail.com> --- net/

Re: [PATCH net-next] bridge: add igmpv3 and mldv2 query support

On 18/11/16 08:32, Hangbin Liu wrote: Add bridge IGMPv3 and MLDv2 query support. But before we think it is stable enough, only enable it when declare in force_igmp/mld_version. Signed-off-by: Hangbin Liu --- net/bridge/br_multicast.c | 203

[PATCH net-next 1/4] net: pim: add common pimhdr struct and helpers

Add the common pimhdr structure and helpers to access it, also cleanup the format of the header file. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/linux/pim.h | 44 1 file changed, 36 insertions(+), 8 deletions(-)

[PATCH net-next 4/4] bridge: mcast: add router port on PIM hello message

this traffic out the port to leaf-13 Suggested-by: Daniel Walton <dwal...@cumulusnetworks.com> Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- net/bridge/br_multicast.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git

[PATCH net-next 2/4] net: pim: add a helper to check for IPv4 all pim routers address

Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/linux/pim.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/pim.h b/include/linux/pim.h index 354235a2691b..1b6c0dbba94e 100644 --- a/include/linux/pim.h +++ b/include/linux/pim.h @@ -57,4

[PATCH net-next 0/4] bridge: add support for PIM hello router ports

. Thanks, Nik Nikolay Aleksandrov (4): net: pim: add common pimhdr struct and helpers net: pim: add a helper to check for IPv4 all pim routers address net: pim: add all RFC7761 message types bridge: mcast: add router port on PIM hello message include/linux/pim.h | 81

[PATCH net-next 3/4] net: pim: add all RFC7761 message types

Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/linux/pim.h | 31 ++- net/ipv4/ipmr.c | 2 +- net/ipv6/ip6mr.c| 2 +- 3 files changed, 32 insertions(+), 3 deletions(-) diff --git a/include/linux/pim.h b/include/linux/pim.h

[PATCH net v2] bridge: multicast: restore perm router ports on multicast enable

...@cumulusnetworks.com> Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- v2: just call br_multicast_enable_port for all ports and use br_multicast_open net/bridge/br_multicast.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --

Re: [PATCH net] bridge: multicast: restore perm router ports on multicast enable

On 18/10/16 15:10, Nikolay Aleksandrov wrote: > Satish reported a problem with the perm multicast router ports not getting > reenabled after some series of events, in particular if it happens that the > multicast snooping has been disabled and the port goes to disab

[PATCH net] bridge: multicast: restore perm router ports on multicast enable

snetworks.com> Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- net/bridge/br_multicast.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index c5fea9393946..1bc807f1d633 100644 --- a/n

[PATCH iproute2] bridge: add support for the multicast flood flag

Recently a new per-port flag was added which controls the flooding of unknown multicast, this patch adds support for controlling it via iproute2. It also updates the man pages with information about the new flag. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --

[PATCH net] net: bridge: add the multicast_flood flag attribute to brport_attrs

When I added the multicast flood control flag, I also added an attribute for it for sysfs similar to other flags, but I forgot to add it to brport_attrs. Fixes: b6cb5ac8331b ("net: bridge: add per-port multicast flood flag") Signed-off-by: Nikolay Aleksandrov <niko...@cumulu

[PATCH iproute2 net-next] bridge: vlan: remove wrong stats help

to display per-vlan statistics") Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- The commit is only in iproute2 net-next branch. bridge/vlan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/bridge/vlan.c b/bridge/vlan.c index 0b6c69077160..ebcdacee309b 100644

[PATCH net] ipmr, ip6mr: fix scheduling while atomic and a deadlock with ipmr_get_route

670] [] ? early_idt_handler_array+0x120/0x120 [ 7858.221894] [] x86_64_start_reservations+0x2a/0x2c [ 7858.222113] [] x86_64_start_kernel+0x13b/0x14a Fixes: 2942e9005056 ("[RTNETLINK]: Use rtnl_unicast() for rtnetlink unicasts") Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- I like t

[PATCH iproute2 net-next] ipmroute: add support for age dumping

Add support to dump the mroute cache entry age if the show_stats (-s) switch is provided. Example: $ ip -s mroute (0.0.0.0, 239.10.10.10) Iif: eth0 Oifs: eth0 0 packets, 0 bytes, Age 245.44 Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- ip/ipmroute

[PATCH net v2] ipmr, ip6mr: return lastuse relative to now

...@cumulusnetworks.com> Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- v2: make sure lastuse is before or equal to jiffies as per David Laight's comment I realize that this changes the way it is exported, but since it hasn't been in a release yet and we're most

[PATCH net] ipmr, ip6mr: return lastuse relative to now

...@cumulusnetworks.com> Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- I realize that this changes the way it is exported, but since it hasn't been in a release yet and we're most probably the only users, I think it is worth fixing. This change allows user-space dae

Re: [patch net-next v10 2/3] net: core: Add offload stats to if_stats_msg

111 +-- > 2 files changed, 116 insertions(+), 4 deletions(-) > > Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [patch net-next v10 1/3] netdevice: Add offload statistics ndo

; include/linux/netdevice.h | 12 ++++ > 1 file changed, 12 insertions(+) > Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [patch net-next v9 2/3] net: core: Add offload stats to if_stats_msg

> On Sep 14, 2016, at 12:28 PM, Jiri Pirko wrote: > > From: Nogah Frankel > > Add a nested attribute of offload stats to if_stats_msg > named IFLA_STATS_LINK_OFFLOAD_XSTATS. > Under it, add SW stats, meaning stats only per packets that went via >

Re: [patch net-next v8 2/3] net: core: Add offload stats to if_stats_msg

> On Sep 8, 2016, at 9:19 AM, Jiri Pirko wrote: > > From: Nogah Frankel > > Add a nested attribute of offload stats to if_stats_msg > named IFLA_STATS_LINK_OFFLOAD_XSTATS. > Under it, add SW stats, meaning stats only per packets that went via > slowpath

Re: [patch net-next v8 2/3] net: core: Add offload stats to if_stats_msg

> On Sep 9, 2016, at 4:36 PM, Nikolay Aleksandrov <niko...@cumulusnetworks.com> > wrote: > >> >> On Sep 8, 2016, at 9:19 AM, Jiri Pirko <j...@resnulli.us> wrote: >> >> From: Nogah Frankel <nog...@mellanox.com> >> >> A

Re: [patch net-next v8 2/3] net: core: Add offload stats to if_stats_msg

else > + nla_nest_end(skb, attr); > + > + if ((err) && (err != -ENODATA)) > + goto nla_put_failure; Hi, Sorry I’m a little late to the party, one minor nit though - could you please drop the extra braces here. Over

Re: [PATCH iproute2] ip link: fix up bond/bridge slave id

> On Sep 6, 2016, at 10:44 AM, Hangbin Liu wrote: > > Signed-off-by: Hangbin Liu > --- > ip/iplink_bond_slave.c | 2 +- > ip/iplink_bridge_slave.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ip/iplink_bond_slave.c

[PATCH net-next v3 2/2] net: bridge: add per-port multicast flood flag

Add a per-port flag to control the unknown multicast flood, similar to the unknown unicast flood flag and break a few long lines in the netlink flag exports. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- v3: don't change br_auto_mask v2: no change include

[PATCH net-next v3 0/2] net: bridge: add per-port unknown multicast flood control

01 are the slight reduction of tests in the fast-path and a few minor checkpatch fixes. v3: don't change br_auto_mask as that will change user-visible behaviour v2: make pkt_type an enum as per Stephen's comment Thanks, Nik Nikolay Aleksandrov (2): net: bridge: change unicast boolean to exact

[PATCH net-next v3 1/2] net: bridge: change unicast boolean to exact pkt_type

Remove the unicast flag and introduce an exact pkt_type. That would help us for the upcoming per-port multicast flood flag and also slightly reduce the tests in the input fast path. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- v3: no change v2: make pkt_type an enum

Re: [PATCH net] bridge: re-introduce 'fix parsing of MLDv2 reports'

>grec_mca, vid); > - if (!err) > + if (err) > break; > } > } > Indeed, good catch. Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [Bridge] [PATCH net-next v2 2/2] net: bridge: add per-port multicast flood flag

On 31/08/16 08:02, Nikolay Aleksandrov wrote: > On 31/08/16 03:37, Linus Lüssing wrote: >> On Tue, Aug 30, 2016 at 05:23:08PM +0200, Nikolay Aleksandrov via Bridge >> wrote: >>> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c >>> index 1da3221845f1..ed0dd33

Re: [Bridge] [PATCH net-next v2 2/2] net: bridge: add per-port multicast flood flag

On 31/08/16 03:37, Linus Lüssing wrote: > On Tue, Aug 30, 2016 at 05:23:08PM +0200, Nikolay Aleksandrov via Bridge > wrote: >> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c >> index 1da3221845f1..ed0dd3340084 100644 >> --- a/net/bridge/br_if.c >> +++ b/n

[PATCH net] net: bridge: don't increment tx_dropped in br_do_proxy_arp

minger <step...@networkplumber.org> CC: bri...@lists.linux-foundation.org Fixes: 958501163ddd ("bridge: Add support for IEEE 802.11 Proxy ARP") Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- net/bridge/br_input.c | 7 ++- 1 file changed, 2 insertions(+), 5 del

[PATCH net-next v2 0/2] net: bridge: add per-port unknown multicast flood control

01 are the slight reduction of tests in the fast-path and a few minor checkpatch fixes. v2: make pkt_type an enum as per Stephen's comment Thanks, Nik Nikolay Aleksandrov (2): net: bridge: change unicast boolean to exact pkt_type net: bridge: add per-port multicast flood flag include/linux

[PATCH net-next v2 1/2] net: bridge: change unicast boolean to exact

Remove the unicast flag and introduce an exact pkt_type. That would help us for the upcoming per-port multicast flood flag and also slightly reduce the tests in the input fast path. pkt_type Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- v2: make pkt_type an enum

[PATCH net-next v2 2/2] net: bridge: add per-port multicast flood flag

Add a per-port flag to control the unknown multicast flood, similar to the unknown unicast flood flag and break a few long lines in the netlink flag exports. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- v2: no change include/linux/if_bridge.h| 3 ++- includ

Re: [PATCH net-next 1/2] net: bridge: change unicast boolean to exact pkt_type

On 30/08/16 17:00, Nikolay Aleksandrov wrote: > On 30/08/16 16:59, Stephen Hemminger wrote: [snip] >>> if (p->state == BR_STATE_LEARNING) >>> goto drop; >>> >>> BR_INPUT_SKB_CB(skb)->brdev = br->dev; >>&

Re: [PATCH net-next 1/2] net: bridge: change unicast boolean to exact pkt_type

On 30/08/16 16:59, Stephen Hemminger wrote: > On Tue, 30 Aug 2016 15:08:58 +0200 > Nikolay Aleksandrov <niko...@cumulusnetworks.com> wrote: > >> -if (!is_broadcast_ether_addr(dest) && is_multicast_ether_addr(dest) && >> -br_multicast_rcv(

Re: [PATCH net-next 1/2] net: bridge: change unicast boolean to exact pkt_type

On 30/08/16 16:56, Stephen Hemminger wrote: > On Tue, 30 Aug 2016 15:08:58 +0200 > Nikolay Aleksandrov <niko...@cumulusnetworks.com> wrote: > >> /* br_forward.c */ >> +enum { >> +BR_PKT_UNICAST, >> +BR_PKT_MULTICAST, >> +BR_PKT_BROADCAST

[PATCH net-next 1/2] net: bridge: change unicast boolean to exact pkt_type

Remove the unicast flag and introduce an exact pkt_type. That would help us for the upcoming per-port multicast flood flag and also slightly reduce the tests in the input fast path. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- net/bridge/br_device.c | 8 ---

[PATCH net-next 2/2] net: bridge: add per-port multicast flood flag

Add a per-port flag to control the unknown multicast flood, similar to the unknown unicast flood flag and break a few long lines in the netlink flag exports. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/linux/if_bridge.h| 3 ++- include/uapi/linux/if_

[PATCH net-next 0/2] net: bridge: add per-port unknown multicast flood control

01 are the slight reduction of tests in the fast-path and a few minor checkpatch fixes. Thanks, Nik Nikolay Aleksandrov (2): net: bridge: change unicast boolean to exact pkt_type net: bridge: add per-port multicast flood flag include/linux/if_bridge.h| 3 ++- include/uapi/linux

[PATCH net-next] net: bridge: export also pvid flag in the xstats flags

When I added support to export the vlan entry flags via xstats I forgot to add support for the pvid since it is manually matched, so check if the entry matches the vlan_group's pvid and set the flag appropriately. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- net/

[PATCH iproute2 net-next v3] bridge: vlan: add support to display per-vlan statistics

TX: 0 bytes 0 packets The format is the same as bridge vlan show but with stats, even though under the hood the calls done to the kernel are different. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- v3: Make the output like "bridge vlan show&q

[PATCH iproute2] ip: route: fix multicast route dumps

oto static iif eth0 Also fix a minor whitespace error and switch to tabs. Reported-by: Satish Ashok <sas...@cumulusnetworks.com> Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/utils.h | 1 + ip/ipmroute.c | 2 +- ip/iproute.c| 12 +++-

[PATCH net-next 0/2] net: bridge: export vlan stats per-port with flags

vlan stats. That is needed because that call was implemented when the stats API didn't have slave dumping capabilities and it dumps all vlan stats (for both bridge and port entries). We also need it in order to print the vlan flags when dumping the stats. Cheers, Nik Nikolay Aleksandrov (2

[PATCH net-next 1/2] net: bridge: consolidate bridge and port linkxstats calls

the vlan stats also via the slave call which is in preparation for the upcoming per-port vlan stats and vlan flag dumping. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- net/bridge/br_netlink.c | 114 +--- 1 file changed, 39 inse

[PATCH net-next 2/2] net: bridge: export vlan flags with the stats

Use one of the vlan xstats padding fields to export the vlan flags. This is needed in order to be able to distinguish between master (bridge) and port vlan entries in user-space when dumping the bridge vlan stats. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- includ

[PATCH net-next v2] net: ipmr/ip6mr: update lastuse on entry change

Currently lastuse is updated on entry creation and cache hit, but it should also be updated on entry change. Since both on add and update the ttl array is updated we can simply update the lastuse in ipmr_update_thresholds. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> CC:

[PATCH net-next] net: ipmr/ip6mr: update lastuse on entry change

Currently lastuse is updated on entry creation and cache hit, but it should also be updated on entry change. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> CC: Roopa Prabhu <ro...@cumulusnetworks.com> CC: Donald Sharp <sha...@cumulusnetworks.com> CC: D

Re: [PATCH net-next 3/3] virtio: use kcalloc and kmalloc_array

On 26/07/16 18:20, Stephen Hemminger wrote: > Preferred style is to use kcalloc and kmalloc_array. > > Signed-off-by: Stephen Hemminger > > --- a/drivers/net/virtio_net.c2016-07-26 09:13:19.805400983 -0700 > +++ b/drivers/net/virtio_net.c2016-07-26

Re: [PATCH net-next v2] net: ipmr/ip6mr: add support for keeping an entry age

> On Jul 15, 2016, at 10:56 PM, David Miller <da...@davemloft.net> wrote: > > From: Nikolay Aleksandrov <niko...@cumulusnetworks.com> > Date: Thu, 14 Jul 2016 19:28:27 +0300 > >> In preparation for hardware offloading of ipmr/ip6mr we need an >> interface

[PATCH net-next v2] net: ipmr/ip6mr: add support for keeping an entry age

he members in that cache line are written to along with the age. Since all new users are encouraged to use ipmr via netlink, this is exported via the RTA_EXPIRES attribute. Also do a minor local variable declaration style adjustment - arrange them longest to shortest. Signed-off-by: Nikolay Aleksan

Re: [PATCH net-next] net: ipmr/ip6mr: add support for keeping an entry age

> On Jul 14, 2016, at 8:08 AM, Nikolay Aleksandrov > <niko...@cumulusnetworks.com> wrote: > > In preparation for hardware offloading of ipmr/ip6mr we need an > interface that allows to check (and later update) the age of entries. > Relying on stats alone can show act

[PATCH net-next] net: ipmr/ip6mr: add support for keeping an entry age

of minutes or seconds. Since all new users are encouraged to use ipmr via netlink, this is exported via the RTA_CACHEINFO attribute which has rta_lastuse entry. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> CC: Roopa Prabhu <ro...@cumulusnetworks.com> CC:

Re: [PATCH net-next 2/4] net: bridge: rearrange flood vs unicast receive paths

> On Jul 15, 2016, at 10:35 AM, Cong Wang <xiyou.wangc...@gmail.com> wrote: > > On Wed, Jul 13, 2016 at 8:10 PM, Nikolay Aleksandrov > <niko...@cumulusnetworks.com> wrote: >> This patch removes one conditional from the unicast path by using the fact >> t

[PATCH net-next 4/4] net: bridge: remove _deliver functions and consolidate forward code

was locally originated and use that to perform the necessary checks in __br_forward. This gives a minor performance improvement but more importantly consolidates the forwarding paths. Also add a kernel doc comment to explain the exported br_forward()'s arguments. Signed-off-by: Nikolay Aleksandrov

[PATCH net-next 3/4] net: bridge: drop skb2/skb0 variables and use a local_rcv boolean

. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- net/bridge/br_forward.c | 35 ++- net/bridge/br_input.c | 25 ++--- net/bridge/br_private.h | 10 +- 3 files changed, 33 insertions(+), 37 deletions(-) diff --git

[PATCH net-next 0/4] net: bridge: simplify receive path and consolidate forwarding paths

/mcast dst). Functionally everything should stay the same after this set. I've done basic tests with unicast/multicast/broadcast Tx/Rx. Please review carefully. Thank you, Nik Nikolay Aleksandrov (4): net: bridge: minor style adjustments in br_handle_frame_finish net: bridge: rearrange flood vs unica

[PATCH net-next 1/4] net: bridge: minor style adjustments in br_handle_frame_finish

Trivial style changes in br_handle_frame_finish. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- net/bridge/br_input.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c index a7817e

[PATCH net-next 2/4] net: bridge: rearrange flood vs unicast receive paths

This patch removes one conditional from the unicast path by using the fact that skb is NULL only when the packet is multicast or is local. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- net/bridge/br_input.c | 29 ++--- 1 file changed, 14 inse

[PATCH net-next] net: bridge: extend MLD/IGMP query stats

/rfc3376#section-7 [2] https://tools.ietf.org/html/rfc3810#section-8.1 Suggested-by: Linus Lüssing <linus.luess...@c0d3.blue> Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/uapi/linux/if_bridge.h | 7 -- net/bridge/br_forward.c| 7 ++ net/bridg

Re: [PATCH v2 net-next 1/1] net sched actions: mirred add support for setting Dst MAC address

4 +++- > include/uapi/linux/tc_act/tc_mirred.h | 7 --- > net/sched/act_mirred.c| 24 +++- > 3 files changed, 30 insertions(+), 5 deletions(-) > LGTM, thanks! Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next 1/1] net sched actions: mirred add support for setting Dst MAC address

On 02/07/16 16:02, Jamal Hadi Salim wrote: > On 16-07-02 09:49 AM, Nikolay Aleksandrov wrote: >> On 02/07/16 15:26, Jamal Hadi Salim wrote: >>> From: Jamal Hadi Salim <j...@mojatatu.com> >>> >>> Often redirecting or mirroring requires that we set the M

Re: [PATCH net-next 1/1] net sched actions: mirred add support for setting Dst MAC address

On 02/07/16 15:26, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > Often redirecting or mirroring requires that we set the MAC address > of the target device. While it is possible to pipe to a pedit action > this obsoletes the need for that. This is justified feature

Re: [PATCH iproute2 net-next] bridge: vlan: add support to display per-vlan statistics

On 01/07/16 02:06, Stephen Hemminger wrote: > On Tue, 21 Jun 2016 18:11:59 +0200 > Nikolay Aleksandrov <niko...@cumulusnetworks.com> wrote: > >>>> Thanks, this is a useful tool, but I think the formatting of output may >>>> need to be >>>> rew

Re: [PATCH v2 net] bonding: prevent out of bound accesses

y Vyukov <dvyu...@google.com> > --- > drivers/net/bonding/bond_3ad.c | 11 +++ > drivers/net/bonding/bond_alb.c |7 ++- > include/net/bonding.h |7 ++- > 3 files changed, 15 insertions(+), 10 deletions(-) > +CC bonding maintainers For v2, Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net] bonding: prevent out of bound accesses

duma...@google.com> > Reported-by: Dmitry Vyukov <dvyu...@google.com> > --- > drivers/net/bonding/bond_3ad.c | 11 +++ > drivers/net/bonding/bond_alb.c |3 --- > include/net/bonding.h | 7 ++++++- > 3 files changed, 13 insertions(+), 8 deletions(-) > Good catch, Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

[PATCH net-next v2 1/2] net: rtnetlink: add support for the IFLA_STATS_LINK_XSTATS_SLAVE attribute

-port vlan stats in the future, possibly other statistics as well. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- v2: new patch include/net/rtnetlink.h | 5 ++-- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c

[PATCH net-next v2 2/2] net: bridge: add support for IGMP/MLD stats and export them via netlink

with bridges. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- v2: use the new API, also in addition counters for IGMP/MLD parse errors have been added and members are added for per-port multicast traffic stats. The multicast counting has been slightly optimized (moved the

[PATCH net-next v2 0/2] net: bridge: add support for IGMP/MLD stats

of the multicast traffic path (both IGMP and other). Thank you, Nik Nikolay Aleksandrov (2): net: rtnetlink: add support for the IFLA_STATS_LINK_XSTATS_SLAVE attribute net: bridge: add support for IGMP/MLD stats and export them via netlink include/net/rtnetlink.h| 5

Re: [PATCH net-next] net: bridge: add support for IGMP/MLD stats and export them via netlink

On 27/06/16 20:10, Nikolay Aleksandrov wrote: > This patch adds stats support for the currently used IGMP/MLD types by the > bridge. The stats are per-port (plus one stat per-bridge) and per-direction > (RX/TX). The stats are exported via netlink via the new linkxstats API > (

Re: [Bridge] [PATCH net-next] net: bridge: add support for IGMP/MLD stats and export them via netlink

On 28/06/16 13:03, Linus Lüssing wrote: > On Mon, Jun 27, 2016 at 08:10:48PM +0200, Nikolay Aleksandrov via Bridge > wrote: >> These are invaluable when monitoring or debugging complex multicast setups >> with bridges. > > Indeed! Great patch :). Especially if people are

[PATCH net-next] net: bridge: add support for IGMP/MLD stats and export them via netlink

with bridges. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/uapi/linux/if_bridge.h | 27 +++ include/uapi/linux/if_link.h | 1 + net/bridge/br_device.c | 10 ++- net/bridge/br_forward.c| 13 ++- net/bridge/br_if.c |

[PATCH net] net: bridge: fix vlan stats continue counter

I made a dumb off-by-one mistake when I added the vlan stats counter dumping code. The increment should happen before the check, not after otherwise we miss one entry when we continue dumping. Fixes: a60c090361ea ("bridge: netlink: export per-vlan stats") Signed-off-by: Nikolay Aleksan

[PATCH iproute2 net-next v2] bridge: vlan: add support to display per-vlan statistics

packets Note that it will print the per-vlan statistics for all vlans in a bridge even if the vlan is only added to ports. Later when we add per-port per-vlan statistics support, we'll be able to print the exact ports each vlan belongs to, not only the bridge. Signed-off-by: Nikolay Aleksandrov <n

Re: [PATCH iproute2 net-next v2] bridge: vlan: add support to display per-vlan statistics

On 21/06/16 20:07, Nikolay Aleksandrov wrote: > This patch adds support for the stats argument to the bridge > vlan command which will display the per-vlan statistics and the bridge > device each vlan belongs to. The supported command filtering options are > dev and vid. Also

Re: [PATCH iproute2 net-next] bridge: vlan: add support to display per-vlan statistics

On 21/06/16 18:01, Stephen Hemminger wrote: > On Mon, 20 Jun 2016 12:13:19 +0200 > Nikolay Aleksandrov <niko...@cumulusnetworks.com> wrote: > >> This patch adds support for the -statistics (-s) argument to the bridge >> vlan show command which will display the per-vla

Re: [PATCH iproute2 net-next] bridge: vlan: add support to display per-vlan statistics

On 21/06/16 18:10, Nikolay Aleksandrov wrote: > On 21/06/16 18:01, Stephen Hemminger wrote: >> On Mon, 20 Jun 2016 12:13:19 +0200 >> Nikolay Aleksandrov <niko...@cumulusnetworks.com> wrote: >> >>> This patch adds support for the -statistics (-s) argument to th

[PATCH iproute2 net-next] bridge: vlan: add support to display per-vlan statistics

. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- bridge/vlan.c| 103 --- include/libnetlink.h | 8 lib/libnetlink.c | 20 ++ man/man8/bridge.8| 6 +++ 4 files changed, 123 insertions(

Re: [Bridge] [PATCH net-next v2] bridge: Synchronize unicast filtering with FDB

On 13/06/16 13:13, Toshiaki Makita wrote: On 2016/06/12 15:35, Toshiaki Makita wrote: On 16/06/12 (日) 1:17, Nikolay Aleksandrov via Bridge wrote: On 06/11/2016 07:35 AM, David Miller wrote: From: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp> Date: Mon, 6 Jun 2016 21:20:13 +0900 P

Re: [PATCH net-next v2] bridge: Synchronize unicast filtering with FDB

automatically so admin do not need to manually add an fdb entry. >> This effectively supports IFF_UNICAST_FLT in bridge, thus adding an >> macvlan device would not place bridge into promiscuous mode as well. >> >> v2: >> - Test vlan with br_vlan_should_use() in br_fdb_sync_uc() as

Re: [PATCH net] bridge: Don't insert unnecessary local fdb entry on changing mac address

ixes: 2594e9064a57 ("bridge: vlan: add per-vlan struct and move to > rhashtables") > Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp> > --- Good catch, Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next] bridge: Synchronize unicast filtering with FDB

> On Jun 3, 2016, at 5:54 PM, Nikolay Aleksandrov <niko...@cumulusnetworks.com> > wrote: > >> >> On Jun 3, 2016, at 11:33 AM, Toshiaki Makita <makita.toshi...@lab.ntt.co.jp> >> wrote: >> >> Patrick Schaaf reported that flooding due

Re: [PATCH net-next] bridge: Synchronize unicast filtering with FDB

> On Jun 3, 2016, at 11:33 AM, Toshiaki Makita > wrote: > > Patrick Schaaf reported that flooding due to a missing fdb entry of > the address of macvlan on the bridge device caused high CPU > consumption of an openvpn process behind a tap bridge port. > Adding an

Re: [PATCH net-next v2 2/2] net: vrf: Add l3mdev rules on first device create

> On Jun 3, 2016, at 4:22 AM, David Ahern wrote: > > Add l3mdev rule per address family when the first VRF device is > created. Remove them when the last is deleted. > > Signed-off-by: David Ahern > --- > v2 > - added EXCL flag and EEXISTS

Re: [patch net-next 3/4] net: core: add SW stats to if_stats_msg

> On May 12, 2016, at 12:59 PM, Jiri Pirko wrote: > > From: Nogah Frankel > > If there is a dedicated ndo to return SW stats - use > it. Otherwise (indicates that there is no HW stats) use > the default stats ndo. > Return results under

[PATCH net] net: bridge: fix old ioctl unlocked net device walk

an use rcu to safely walk the net device list. Also remove the wrong rtnl comment above. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- AFAICT this has been present since the beginning of git history thus no fixes tag. net/bridge/br_ioctl.c | 5 +++-- 1 file changed, 3

[PATCH net-next v3 3/4] bridge: vlan: learn to count

restricted to exactly 0 and 1 since other values will be used in the future for different purposes (e.g. per-port stats). Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- v3: make stats accounting optional with default to off v2: no change include/uapi/linux/if_link.

[PATCH net-next v3 1/4] net: rtnetlink: allow rtnl_fill_statsinfo to save private state counter

by Roopa Prabhu. Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- v3: no change v2: improve the error check in rtnl_fill_statsinfo, rename lidx to prividx, squash patch 2 into this one and save the current idx user instead of restricting only one net/core/rtnetlink.

<    1   2   3   4   5   6   7   8   9   10   >