Re: [PATCH] enic: Store permanent MAC address during probe()

2017-03-21 Thread PJ Waskiewicz
On Mon, Mar 20, 2017 at 6:49 PM, Govindarajulu Varadarajan <gvara...@cisco.com> wrote: > On Mon, 20 Mar 2017, PJ Waskiewicz wrote: > >> On Mon, Mar 20, 2017 at 5:33 PM, Govindarajulu Varadarajan >> <gvara...@cisco.com> wrote: >>> >>> On Mon, 20

Re: [PATCH] enic: Store permanent MAC address during probe()

2017-03-20 Thread PJ Waskiewicz
On Mon, Mar 20, 2017 at 5:33 PM, Govindarajulu Varadarajan <gvara...@cisco.com> wrote: > On Mon, 20 Mar 2017, PJ Waskiewicz wrote: > >> From: PJ Waskiewicz <pjwaskiew...@gmail.com> >> >> The permanent MAC address is useful to store for things like eth

[PATCH] enic: Store permanent MAC address during probe()

2017-03-20 Thread PJ Waskiewicz
From: PJ Waskiewicz <pjwaskiew...@gmail.com> The permanent MAC address is useful to store for things like ethtool, and when bonding with modes such as active/passive or LACP. This follows the model of other Ethernet drivers, such as ixgbe. This was verified on a C220 chassis with the Cisc

[PATCH] [IPROUTE2] Update various classifiers' help output for expected CLASSID syntax

2008-02-13 Thread PJ Waskiewicz
update: Fix the spelling of hexidecimal This updates the help output to specify that CLASSID should be hexidecimal. This makes sure that a user entering flowid 1:10 gets his flow put into band 15 (0x10) and knows why. Signed-off-by: Peter P Waskiewicz Jr [EMAIL PROTECTED] ---

[PATCH] [NET 2.6.26]: Add per-connection option to set max TSO frame size

2008-02-13 Thread PJ Waskiewicz
Update: changed max_gso_frame_size and sk_gso_max_size from signed to unsigned - thanks Stephen! This patch adds the ability for device drivers to control the size of the TSO frames being sent to them, per TCP connection. By setting the netdevice's max_gso_frame_size value, the socket layer will

[PATCH] [IPROUTE2] Update various classifiers' help output for expected CLASSID syntax

2008-02-12 Thread PJ Waskiewicz
This updates the help output to specify that CLASSID should be hexidecimal. This makes sure that a user entering flowid 1:10 gets his flow put into band 15 (0x10) and knows why. Signed-off-by: Peter P Waskiewicz Jr [EMAIL PROTECTED] --- doc/actions/actions-general |3 +++ tc/f_basic.c

[PATCH] [NET]: Add per-connection option to set max TSO frame size

2008-02-12 Thread PJ Waskiewicz
This patch adds the ability for device drivers to control the size of the TSO frames being sent to them, per TCP connection. By setting the netdevice's max_gso_frame_size value, the socket layer will set the GSO frame size based on that value. This will propogate into the TCP layer, and send

[PATCH] [TC U32] Fix input parsing to support more than 9 flow id's correctly

2008-02-12 Thread PJ Waskiewicz
From: PJ Waskiewicz [EMAIL PROTECTED] Using strtoul with a base of 16 converts flowid 10 into 0x10, which makes it flowid 16. This is interpreted by the kernel incorrectly, and causes traffic flows above 9 to be classified into band 0 on multiband qdiscs. This changes the base to 10, which

[PATCH] SCHED: Fix unnecesary driver entries when queue is stopped

2007-11-13 Thread PJ Waskiewicz
. Thanks, -- PJ Waskiewicz [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] PATCH 2/2 [SCHED 2.6.23-stable]: Check subqueue state before hard_start_xmit

2007-11-13 Thread PJ Waskiewicz
The only qdiscs that check subqueue state before dequeue'ing are PRIO and RR. The other qdiscs, including the default pfifo_fast qdisc, will allow traffic bound for subqueue 0 through to hard_start_xmit. The check for netif_queue_stopped() is done above in pkt_sched.h, so it is unnecessary for

[PATCH] PATCH 1/2 [SCHED 2.6.24]: Check subqueue status before calling hard_start_xmit

2007-11-13 Thread PJ Waskiewicz
The only qdiscs that check subqueue state before dequeue'ing are PRIO and RR. The other qdiscs, including the default pfifo_fast qdisc, will allow traffic bound for subqueue 0 through to hard_start_xmit. The check for netif_queue_stopped() is done above in pkt_sched.h, so it is unnecessary for

[PATCH] [AF_PACKET]: Allow multicast traffic to be caught by ORIGDEV when bonded

2007-11-06 Thread PJ Waskiewicz
The socket option for packet sockets to return the original ifindex instead of the bonded ifindex will not match multicast traffic. Since this socket option is the most useful for layer 2 traffic and multicast traffic, make the option multicast-aware. Signed-off-by: Peter P Waskiewicz Jr [EMAIL

[PATCH] DOC: Update networking/multiqueue.txt with correct information.

2007-09-07 Thread PJ Waskiewicz
Updated the multiqueue.txt document to call out the correct kernel options to select to enable multiqueue. Signed-off-by: Peter P Waskiewicz Jr [EMAIL PROTECTED] --- Documentation/networking/multiqueue.txt | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git

[PATCH] iproute2: sch_rr support in tc

2007-08-14 Thread PJ Waskiewicz
to 2.6.23, so we'll need these patches to manage the new kernel features. These patches are unmodified from the version that was approved. They've been applied to the latest iproute2 commit. -- PJ Waskiewicz [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev

[PATCH 1/2] IPROUTE2: RTNETLINK nested attributes

2007-08-14 Thread PJ Waskiewicz
From: Patrick McHardy [EMAIL PROTECTED] This adds capability for iproute2 to send nested attributes to the kernel, while maintaining backwards compatibility. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- include/libnetlink.h |9 + lib/libnetlink.c | 46

[PATCH 2/2] iproute2: sch_rr support in tc

2007-08-14 Thread PJ Waskiewicz
is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version + * 2 of the License, or (at your option) any later version. + * + * Authors:PJ

[PATCH 1/2] NET: Fix sch_api to properly set sch-parent on the root qdisc

2007-07-24 Thread PJ Waskiewicz
From: Patrick McHardy [EMAIL PROTECTED] Fix sch_api to correctly set sch-parent for both ingress and egress qdiscs in qdisc_create(). Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Signed-off-by: Peter P Waskiewicz Jr [EMAIL PROTECTED] --- net/sched/sch_api.c | 17 - 1

[PATCH 2/2] NET: Fix sch_prio to properly detect the root qdisc on multiqueue

2007-07-24 Thread PJ Waskiewicz
Fix the check in prio_tune() to see if sch-parent is TC_H_ROOT instead of sch-handle to load or reject the qdisc for multiqueue devices. Signed-off-by: Peter P Waskiewicz Jr [EMAIL PROTECTED] --- net/sched/sch_prio.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git

[FIX] NET: Fix sch_api and sch_prio to properly set and detect the root qdisc

2007-07-24 Thread PJ Waskiewicz
), the parent handle should be the value TC_H_ROOT. This fixes sch_api to set this correctly on qdisc_create() for both ingress and egress qdiscs. Change this check in prio_tune() so that only the root qdisc can be multiqueue-enabled; use sch-parent instead of sch-handle. -- PJ Waskiewicz [EMAIL PROTECTED

[PATCH] NET: Fix sch_prio to detect the root qdisc loading

2007-07-21 Thread PJ Waskiewicz
The sch-parent handle will be NULL for the scheduler that is TC_H_ROOT. Change this check in prio_tune() so that only the root qdisc can be multiqueue-enabled. Signed-off-by: Peter P Waskiewicz Jr [EMAIL PROTECTED] --- net/sched/sch_prio.c |6 -- 1 files changed, 4 insertions(+), 2

[PATCH 2/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-28 Thread PJ Waskiewicz
Updated: Fixed allocation of subqueues in alloc_netdev_mq() to allocate all subqueues, not num - 1. Added checks for netif_subqueue_stopped() to netpoll, pktgen, and software device dev_queue_xmit(). This will ensure external events to these subsystems will be handled correctly if a subqueue is

[PATCH] iproute2: sch_rr support in tc

2007-06-28 Thread PJ Waskiewicz
version. + * + * Authors:PJ Waskiewicz, [EMAIL PROTECTED] + * Original Authors: Alexey Kuznetsov, [EMAIL PROTECTED] (from PRIO) + * + * Changes: + * + * Ole Husgaard [EMAIL PROTECTED]: 990513: prio2band map was always reset. + * J Hadi Salim [EMAIL PROTECTED]: 990609: priomap fix

[PATCH] NET: Multiple queue hardware support

2007-06-23 Thread PJ Waskiewicz
, Qdisc changes, and core stack changes. The requested e1000 changes are still being resolved, and will be sent at a later date. The patches to iproute2 for tc will be sent separately, to support sch_rr. -- PJ Waskiewicz [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe

[PATCH 2/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-23 Thread PJ Waskiewicz
Updated: Added checks for netif_subqueue_stopped() to netpoll, pktgen, and software device dev_queue_xmit(). This will ensure external events to these subsystems will be handled correctly if a subqueue is shut down. Add the multiqueue hardware device support API to the core network stack. Allow

[PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue

2007-06-23 Thread PJ Waskiewicz
Updated: This patch applies on top of Patrick McHardy's RTNETLINK nested compat attribute patches. These are required to preserve ABI for iproute2 when working with the multiqueue qdiscs. Add the new sch_rr qdisc for multiqueue network device support. Allow sch_prio and sch_rr to be compiled

[PATCH 1/3] NET: [DOC] Multiqueue hardware support documentation

2007-06-23 Thread PJ Waskiewicz
Add a brief howto to Documentation/networking for multiqueue. It explains how to use the multiqueue API in a driver to support multiqueue paths from the stack, as well as the qdiscs to use for feeding a multiqueue device. Signed-off-by: Peter P Waskiewicz Jr [EMAIL PROTECTED] ---

[PATCH] iproute2: sch_rr support in tc

2007-06-23 Thread PJ Waskiewicz
+ * as published by the Free Software Foundation; either version + * 2 of the License, or (at your option) any later version. + * + * Authors:PJ Waskiewicz, [EMAIL PROTECTED] + * Original Authors: Alexey Kuznetsov, [EMAIL PROTECTED] (from PRIO) + * + * Changes: + * + * Ole Husgaard [EMAIL

[PATCH] NET: Multiple queue hardware support

2007-06-21 Thread PJ Waskiewicz
will be sent separately, to support sch_rr. -- PJ Waskiewicz [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] NET: [DOC] Multiqueue hardware support documentation

2007-06-21 Thread PJ Waskiewicz
Add a brief howto to Documentation/networking for multiqueue. It explains how to use the multiqueue API in a driver to support multiqueue paths from the stack, as well as the qdiscs to use for feeding a multiqueue device. Signed-off-by: Peter P Waskiewicz Jr [EMAIL PROTECTED] ---

[PATCH 2/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-21 Thread PJ Waskiewicz
Add the multiqueue hardware device support API to the core network stack. Allow drivers to allocate multiple queues and manage them at the netdev level if they choose to do so. Added a new field to sk_buff, namely queue_mapping, for drivers to know which tx_ring to select based on OS

[PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue

2007-06-21 Thread PJ Waskiewicz
Add the new sch_rr qdisc for multiqueue network device support. Allow sch_prio to be compiled with or without multiqueue hardware support. sch_rr is part of sch_prio, and is referenced from MODULE_ALIAS. This was done since sch_prio and sch_rr only differ in their dequeue routine.

[PATCH] iproute2: sch_rr support in tc

2007-06-21 Thread PJ Waskiewicz
multiqueue submission. Thanks. -- PJ Waskiewicz [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] iproute2: Added support for RR qdisc (sch_rr)

2007-06-21 Thread PJ Waskiewicz
it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version + * 2 of the License, or (at your option) any later version. + * + * Authors:PJ Waskiewicz, [EMAIL PROTECTED] + * Original Authors

[PATCH] iproute2: sch_rr support in tc

2007-06-18 Thread PJ Waskiewicz
multiqueue submission. Thanks. -- PJ Waskiewicz [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] iproute2: Added support for RR qdisc (sch_rr)

2007-06-18 Thread PJ Waskiewicz
Public License + * as published by the Free Software Foundation; either version + * 2 of the License, or (at your option) any later version. + * + * Authors:PJ Waskiewicz, [EMAIL PROTECTED] + * Original Authors: Alexey Kuznetsov, [EMAIL PROTECTED] (from PRIO

[PATCH] NET: Multiple queue hardware support

2007-06-18 Thread PJ Waskiewicz
to check the subqueue status either. The patches to iproute2 for tc will be sent separately, to support sch_rr. -- PJ Waskiewicz [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

[PATCH 2/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue

2007-06-18 Thread PJ Waskiewicz
on sch_prio. -dequeue() is where + * this scheduler functionally differs. + * + * Author: PJ Waskiewicz, [EMAIL PROTECTED] + * + * Original Authors (from PRIO): Alexey Kuznetsov, [EMAIL PROTECTED] + * Fixes: 19990609: J Hadi Salim [EMAIL PROTECTED]: + * Init -- EINVAL when

[PATCH 1/3] NET: [DOC] Multiqueue hardware support documentation

2007-06-18 Thread PJ Waskiewicz
Add a brief howto to Documentation/networking for multiqueue. It explains how to use the multiqueue API in a driver to support multiqueue paths from the stack, as well as the qdiscs to use for feeding a multiqueue device. Signed-off-by: Peter P Waskiewicz Jr [EMAIL PROTECTED] ---

[PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-18 Thread PJ Waskiewicz
Add the multiqueue hardware device support API to the core network stack. Allow drivers to allocate multiple queues and manage them at the netdev level if they choose to do so. Signed-off-by: Peter P Waskiewicz Jr [EMAIL PROTECTED] --- include/linux/etherdevice.h |3 +-

[RFC] NET: Multiple queue hardware support

2007-06-04 Thread PJ Waskiewicz
in hardware to continue using sch_prio if they wish to have some notion of scheduling priority. The patches to iproute2 for tc will be sent separately, to support sch_rr. I'm soliciting feedback for a 2.6.23 submission. Thanks. -- PJ Waskiewicz [EMAIL PROTECTED] - To unsubscribe from this list

[PATCH] NET: Multiqueue network device support.

2007-06-04 Thread PJ Waskiewicz
later version. + * + * The core part of this qdisc is based on sch_prio. -dequeue() is where + * this scheduler functionally differs. + * + * Author: PJ Waskiewicz, [EMAIL PROTECTED] + * + * Original Authors (from PRIO): Alexey Kuznetsov, [EMAIL PROTECTED] + * Fixes: 19990609: J Hadi Salim

[RFC] iproute2: sch_rr support in tc

2007-06-04 Thread PJ Waskiewicz
multiqueue submission. Thanks. -- PJ Waskiewicz [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] iproute2: Added support for RR qdisc (sch_rr)

2007-06-04 Thread PJ Waskiewicz
Public License + * as published by the Free Software Foundation; either version + * 2 of the License, or (at your option) any later version. + * + * Authors:PJ Waskiewicz, [EMAIL PROTECTED] + * Original Authors: Alexey Kuznetsov, [EMAIL PROTECTED] (from PRIO