[PATCH 2/9] ipvs: call rtnl_lock early

2015-08-28 Thread Pablo Neira Ayuso
From: Julian Anastasov j...@ssi.bg When the sync damon is started we need to hold rtnl lock while calling ip_mc_join_group. Currently, we have a wrong locking order because the correct one is rtnl_lock-__ip_vs_mutex. It is implied from the usage of __ip_vs_mutex in ip_vs_dst_event() which is

[PATCH 5/9] netfilter: nf_dup: fix sparse warnings

2015-08-28 Thread Pablo Neira Ayuso
fengguang...@intel.com Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/ipv4/netfilter/nft_dup_ipv4.c |2 +- net/ipv6/netfilter/nf_dup_ipv6.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv4/netfilter/nft_dup_ipv4.c b/net/ipv4/netfilter/nft_dup_ipv4

[PATCH 8/9] Revert netfilter: xtables: compute exact size needed for jumpstack

2015-08-28 Thread Pablo Neira Ayuso
-by: Hannes Frederic Sowa han...@stressinduktion.org Signed-off-by: Florian Westphal f...@strlen.de Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/ipv4/netfilter/arp_tables.c | 19 +++ net/ipv4/netfilter/ip_tables.c | 28 ++-- net/ipv6/netfilter

[PATCH 7/9] netfilter: ip6t_REJECT: added missing icmpv6 codes

2015-08-28 Thread Pablo Neira Ayuso
forwarded to it that use an address from a prefix that has been invalidated. Codes 5 and 6 are more informative subsets of code 1. Signed-off-by: Andreas Herz a...@geekosphere.org Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/uapi/linux/netfilter_ipv6/ip6t_REJECT.h |4 +++- net

[PATCH 6/9] netfilter: xt_TEE: use IS_ENABLED(CONFIG_NF_DUP_IPV6)

2015-08-28 Thread Pablo Neira Ayuso
robot fengguang...@intel.com Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/xt_TEE.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/xt_TEE.c b/net/netfilter/xt_TEE.c index 49fee6a..fd980aa 100644 --- a/net/netfilter/xt_TEE.c +++ b/net

[PATCH 9/9] netfilter: reduce sparse warnings

2015-08-28 Thread Pablo Neira Ayuso
-by: Florian Westphal f...@strlen.de Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/bridge/netfilter/ebtables.c|2 +- net/ipv6/netfilter/ip6t_SYNPROXY.c |2 +- net/netfilter/core.c |3 --- net/netfilter/nf_synproxy_core.c |6 +++--- 4 files changed, 5

Re: [PATCH v2 net-next] netfilter: ipset: Fixing unnamed union initg

2015-08-28 Thread Pablo Neira Ayuso
On Sat, Aug 22, 2015 at 08:44:48PM +0200, Pablo Neira Ayuso wrote: [...] I'll wait for some little time just in case someone raises any concern. JFYI, I'll be passing up this patch to David via the nf tree soon. Thanks. -- To unsubscribe from this list: send the line unsubscribe netdev

Re: [GIT PULL nf-next] Second Round of IPVS Updates for v4.3

2015-08-26 Thread Pablo Neira Ayuso
On Fri, Aug 21, 2015 at 09:23:38AM -0700, Simon Horman wrote: Hi Pablo, please consider these IPVS Updates for v4.3. I realise these are a little late in the cycle, so if you would prefer me to repost them for v4.4 then just let me know. Pulled, thanks Simon. Let me see if this gets into

Re: [RFC] netlink: netlink_ack send a capped message in case of error

2015-08-24 Thread Pablo Neira Ayuso
://patchwork.ozlabs.org/patch/290976/ Do you think this one is acceptable ? I am not sure to understand David last comment. I think David suggests something like the (completely untested) attached patch. From 3aa0deafb5648427d154e26920d9d85f89dab190 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso pa

Re: [PATCH v2 net-next] netfilter: ipset: Fixing unnamed union init

2015-08-22 Thread Pablo Neira Ayuso
Cc'ing Andrew, since he's got a similar patch in mmotm [1]. On Sat, Aug 22, 2015 at 08:11:18PM +0200, Jozsef Kadlecsik wrote: On Sat, 22 Aug 2015, Elad Raz wrote: In continue to proposed Vinson Lee's post [1], this patch fixes compilation issues founded at gcc 4.4.7. The initialization of

[PATCH 12/15] netfilter: nf_conntrack: push zone object into functions

2015-08-20 Thread Pablo Neira Ayuso
call-sites. No functional changes in this patch. The default zone becomes a global const object, namely nf_ct_zone_dflt and will be returned directly in various cases, one being, when there's f.e. no zoning support. Signed-off-by: Daniel Borkmann dan...@iogearbox.net Signed-off-by: Pablo Neira

[PATCH 07/15] netfilter: nft_limit: factor out shared code with per-byte limiting

2015-08-20 Thread Pablo Neira Ayuso
This patch prepares the introduction of per-byte limiting. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nft_limit.c | 86 - 1 file changed, 53 insertions(+), 33 deletions(-) diff --git a/net/netfilter/nft_limit.c b/net

[PATCH 10/15] netfilter: nft_limit: add per-byte limiting

2015-08-20 Thread Pablo Neira Ayuso
. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/uapi/linux/netfilter/nf_tables.h |7 net/netfilter/nft_limit.c| 63 -- 2 files changed, 66 insertions(+), 4 deletions(-) diff --git a/include/uapi/linux/netfilter/nf_tables.h b

[PATCH 11/15] netfilter: nfacct: per network namespace support

2015-08-20 Thread Pablo Neira Ayuso
objects Signed-off-by: Andreas Schultz aschu...@tpip.net Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/linux/netfilter/nfnetlink_acct.h |3 +- include/net/net_namespace.h |3 ++ net/netfilter/nfnetlink_acct.c | 71

[PATCH 05/15] netfilter: nft_limit: rename to nft_limit_pkts

2015-08-20 Thread Pablo Neira Ayuso
To prepare introduction of bytes ratelimit support. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nft_limit.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/netfilter/nft_limit.c b/net/netfilter/nft_limit.c index 435c1cc..d0788e1

[PATCH 15/15] netfilter: nft_payload: work around vlan header stripping

2015-08-20 Thread Pablo Neira Ayuso
. Signed-off-by: Florian Westphal f...@strlen.de Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nft_payload.c | 57 ++- 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/net/netfilter/nft_payload.c b/net/netfilter

[PATCH 08/15] netfilter: nft_limit: add burst parameter

2015-08-20 Thread Pablo Neira Ayuso
This patch adds the burst parameter. This burst indicates the number of packets that can exceed the limit. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/uapi/linux/netfilter/nf_tables.h |2 ++ net/netfilter/nft_limit.c| 20 ++-- 2 files

[PATCH 03/15] netfilter: factor out packet duplication for IPv4/IPv6

2015-08-20 Thread Pablo Neira Ayuso
Extracted from the xtables TEE target. This creates two new modules for IPv4 and IPv6 that are shared between the TEE target and the new nf_tables dup expressions. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/net/netfilter/ipv4/nf_dup_ipv4.h |7 ++ include/net/netfilter

[PATCH 14/15] netfilter: nf_conntrack: add efficient mark to zone mapping

2015-08-20 Thread Pablo Neira Ayuso
a minimal implementation for a possible mapping. In order to not add/expose an extra ct-status bit, the zone structure has been extended to carry a flag for deriving the mark. Signed-off-by: Daniel Borkmann dan...@iogearbox.net Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/net

[PATCH 06/15] netfilter: nft_limit: convert to token-based limiting at nanosecond granularity

2015-08-20 Thread Pablo Neira Ayuso
Rework the limit expression to use a token-based limiting approach that refills the bucket gradually. The tokens are calculated at nanosecond granularity instead jiffies to improve precision. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nft_limit.c | 42

[PATCH 04/15] netfilter: nf_tables: add nft_dup expression

2015-08-20 Thread Pablo Neira Ayuso
. Based on the original tee expression from Arturo Borrero Gonzalez, although this patch has diverted quite a bit from this initial effort due to the change to support maps. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/net/netfilter/nft_dup.h |9 +++ include/uapi

[PATCH 02/15] netfilter: xt_TEE: get rid of WITH_CONNTRACK definition

2015-08-20 Thread Pablo Neira Ayuso
Use IS_ENABLED(CONFIG_NF_CONNTRACK) instead. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/xt_TEE.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/net/netfilter/xt_TEE.c b/net/netfilter/xt_TEE.c index c5d6556..0ed9fb6 100644 --- a/net

[PATCH 01/15] netfilter: nft_counter: convert it to use per-cpu counters

2015-08-20 Thread Pablo Neira Ayuso
This patch converts the existing seqlock to per-cpu counters. Suggested-by: Eric Dumazet eric.duma...@gmail.com Suggested-by: Patrick McHardy ka...@trash.net Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nft_counter.c | 97 ++- 1

[PATCH 00/15] Netfilter updates for net-next

2015-08-20 Thread Pablo Neira Ayuso
into functions netfilter: nf_conntrack: add direction support for zones netfilter: nf_conntrack: add efficient mark to zone mapping Florian Westphal (1): netfilter: nft_payload: work around vlan header stripping Pablo Neira Ayuso (11): netfilter: nft_counter: convert

[PATCH 02/15] netfilter: xt_TEE: get rid of WITH_CONNTRACK definition

2015-08-19 Thread Pablo Neira Ayuso
Use IS_ENABLED(CONFIG_NF_CONNTRACK) instead. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/xt_TEE.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/net/netfilter/xt_TEE.c b/net/netfilter/xt_TEE.c index c5d6556..0ed9fb6 100644 --- a/net

[PATCH 10/15] netfilter: nft_limit: add per-byte limiting

2015-08-19 Thread Pablo Neira Ayuso
. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/uapi/linux/netfilter/nf_tables.h |7 net/netfilter/nft_limit.c| 63 -- 2 files changed, 66 insertions(+), 4 deletions(-) diff --git a/include/uapi/linux/netfilter/nf_tables.h b

[PATCH 14/15] netfilter: nf_conntrack: add efficient mark to zone mapping

2015-08-19 Thread Pablo Neira Ayuso
a minimal implementation for a possible mapping. In order to not add/expose an extra ct-status bit, the zone structure has been extended to carry a flag for deriving the mark. Signed-off-by: Daniel Borkmann dan...@iogearbox.net Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/net

[PATCH 03/15] netfilter: factor out packet duplication for IPv4/IPv6

2015-08-19 Thread Pablo Neira Ayuso
Extracted from the xtables TEE target. This creates two new modules for IPv4 and IPv6 that are shared between the TEE target and the new nf_tables dup expressions. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/net/netfilter/ipv4/nf_dup_ipv4.h |7 ++ include/net/netfilter

[PATCH 01/15] netfilter: nft_counter: convert it to use per-cpu counters

2015-08-19 Thread Pablo Neira Ayuso
This patch converts the existing seqlock to per-cpu counters. Suggested-by: Eric Dumazet eric.duma...@gmail.com Suggested-by: Patrick McHardy ka...@trash.net Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nft_counter.c | 97 ++- 1

[PATCH 07/15] netfilter: nft_limit: factor out shared code with per-byte limiting

2015-08-19 Thread Pablo Neira Ayuso
This patch prepares the introduction of per-byte limiting. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nft_limit.c | 86 - 1 file changed, 53 insertions(+), 33 deletions(-) diff --git a/net/netfilter/nft_limit.c b/net

[PATCH 11/15] netfilter: nfacct: per network namespace support

2015-08-19 Thread Pablo Neira Ayuso
objects Signed-off-by: Andreas Schultz aschu...@tpip.net Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/linux/netfilter/nfnetlink_acct.h |3 +- include/net/net_namespace.h |3 ++ net/netfilter/nfnetlink_acct.c | 71

[PATCH 13/15] netfilter: nf_conntrack: add direction support for zones

2015-08-19 Thread Pablo Neira Ayuso
://paste.fedoraproject.org/242835/65657871/ Signed-off-by: Daniel Borkmann dan...@iogearbox.net Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/net/netfilter/nf_conntrack_zones.h | 31 +++- include/uapi/linux/netfilter/nfnetlink_conntrack.h |1 + include/uapi/linux/netfilter/xt_CT.h

[PATCH 12/15] netfilter: nf_conntrack: push zone object into functions

2015-08-19 Thread Pablo Neira Ayuso
call-sites. No functional changes in this patch. The default zone becomes a global const object, namely nf_ct_zone_dflt and will be returned directly in various cases, one being, when there's f.e. no zoning support. Signed-off-by: Daniel Borkmann dan...@iogearbox.net Signed-off-by: Pablo Neira

[PATCH 00/15] Netfilter updates for net-next

2015-08-19 Thread Pablo Neira Ayuso
): netfilter: nf_conntrack: push zone object into functions netfilter: nf_conntrack: add direction support for zones netfilter: nf_conntrack: add efficient mark to zone mapping Florian Westphal (1): netfilter: nft_payload: work around vlan header stripping Pablo Neira Ayuso (10

[PATCH 06/15] netfilter: nft_limit: convert to token-based limiting at nanosecond granularity

2015-08-19 Thread Pablo Neira Ayuso
Rework the limit expression to use a token-based limiting approach that refills the bucket gradually. The tokens are calculated at nanosecond granularity instead jiffies to improve precision. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nft_limit.c | 42

[PATCH 04/15] netfilter: nf_tables: add nft_dup expression

2015-08-19 Thread Pablo Neira Ayuso
. Based on the original tee expression from Arturo Borrero Gonzalez, although this patch has diverted quite a bit from this initial effort due to the change to support maps. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/net/netfilter/nft_dup.h |9 +++ include/uapi

[PATCH 15/15] netfilter: nft_payload: work around vlan header stripping

2015-08-19 Thread Pablo Neira Ayuso
. Signed-off-by: Florian Westphal f...@strlen.de Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nft_payload.c | 57 ++- 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/net/netfilter/nft_payload.c b/net/netfilter

[PATCH 05/15] netfilter: nft_limit: rename to nft_limit_pkts

2015-08-19 Thread Pablo Neira Ayuso
To prepare introduction of bytes ratelimit support. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nft_limit.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/netfilter/nft_limit.c b/net/netfilter/nft_limit.c index 435c1cc..d0788e1

[PATCH 08/15] netfilter: nft_limit: add burst parameter

2015-08-19 Thread Pablo Neira Ayuso
This patch adds the burst parameter. This burst indicates the number of packets that can exceed the limit. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/uapi/linux/netfilter/nf_tables.h |2 ++ net/netfilter/nft_limit.c| 20 ++-- 2 files

[PATCH 09/15] netfilter: nft_limit: constant token cost per packet

2015-08-19 Thread Pablo Neira Ayuso
The cost per packet can be calculated from the control plane path since this doesn't ever change. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nft_limit.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/net/netfilter

[PATCH 3/5] netfilter: conntrack: Use flags in nf_ct_tmpl_alloc()

2015-08-10 Thread Pablo Neira Ayuso
Neira Ayuso pa...@netfilter.org --- net/netfilter/nf_conntrack_core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c index f168099..3c20d02 100644 --- a/net/netfilter/nf_conntrack_core.c +++ b/net

[PATCH 4/5] netfilter: ip6t_SYNPROXY: fix NULL pointer dereference

2015-08-10 Thread Pablo Neira Ayuso
From: Phil Sutter p...@nwl.cc This happens when networking namespaces are enabled. Suggested-by: Patrick McHardy ka...@trash.net Signed-off-by: Phil Sutter p...@nwl.cc Acked-by: Patrick McHardy ka...@trash.net Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/ipv6/netfilter

[PATCH 1/5] netfilter: nf_conntrack: silence warning on falling back to vmalloc()

2015-08-10 Thread Pablo Neira Ayuso
Since 88eab472ec21 (netfilter: conntrack: adjust nf_conntrack_buckets default value), the hashtable can easily hit this warning. We got reports from users that are getting this message in a quite spamming fashion, so better silence this. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org Acked

[PATCH 0/5] Netfilter fixes for net

2015-08-10 Thread Pablo Neira Ayuso
update to client (2015-08-10 13:55:07 +0200) Dan Carpenter (1): netfilter: nf_conntrack: checking for IS_ERR() instead of NULL Joe Stringer (1): netfilter: conntrack: Use flags in nf_ct_tmpl_alloc() Pablo Neira Ayuso (1

[PATCH 2/5] netfilter: nf_conntrack: checking for IS_ERR() instead of NULL

2015-08-10 Thread Pablo Neira Ayuso
-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nf_synproxy_core.c |4 +--- net/netfilter/xt_CT.c|5 +++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/net/netfilter/nf_synproxy_core.c b/net/netfilter

[PATCH 5/5] netfilter: SYNPROXY: fix sending window update to client

2015-08-10 Thread Pablo Neira Ayuso
a window probe is being sent). Signed-off-by: Phil Sutter p...@nwl.cc Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/ipv4/netfilter/ipt_SYNPROXY.c |3 ++- net/ipv6/netfilter/ip6t_SYNPROXY.c |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/net/ipv4

Re: [PATCH v2 2/2] netfilter: ip6t_SYNPROXY: fix sending window update to client

2015-08-10 Thread Pablo Neira Ayuso
On Mon, Aug 10, 2015 at 10:06:07AM +0200, Patrick McHardy wrote: On 09.08, Phil Sutter wrote: This is the identical fix as netfilter: ipt_SYNPROXY: fix sending window update to client but for the IPv6 variant which obviously suffers from the same issue. Looks fine to me. Acked-by:

[PATCH 11/18] netfilter: Fix memory leak in nf_register_net_hook

2015-08-04 Thread Pablo Neira Ayuso
. Fixes: 085db2c04557 (netfilter: Per network namespace netfilter hooks.) Reported-by: kbu...@01.org Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Eric W. Biederman ebied...@xmission.com Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/core.c |4

[PATCH 08/18] netfilter: xtables: don't save/restore jumpstack offset

2015-08-04 Thread Pablo Neira Ayuso
, e.g. 1000 -- in this case it would be feasible to allocate the entire stack in the percpu area which would avoid one dereference. Signed-off-by: Florian Westphal f...@strlen.de Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/linux/netfilter/x_tables.h |1 - net/ipv4/netfilter

[PATCH 17/18] netfilter: bridge: do not initialize statics to 0 or NULL

2015-08-04 Thread Pablo Neira Ayuso
From: Bernhard Thaler bernhard.tha...@wvnet.at Fix checkpatch.pl ERROR: do not initialise statics to 0 or NULL for all statics explicitly initialized to 0. Signed-off-by: Bernhard Thaler bernhard.tha...@wvnet.at Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/bridge

[PATCH 09/18] netfilter: add and use jump label for xt_tee

2015-08-04 Thread Pablo Neira Ayuso
From: Florian Westphal f...@strlen.de Don't bother testing if we need to switch to alternate stack unless TEE target is used. Suggested-by: Eric Dumazet eric.duma...@gmail.com Signed-off-by: Florian Westphal f...@strlen.de Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/linux

[PATCH 07/18] netfilter: move tee_active to core

2015-08-04 Thread Pablo Neira Ayuso
dependency from nft to xtables core its put into core.c instead of the x_tables core. Signed-off-by: Florian Westphal f...@strlen.de Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/linux/netfilter.h | 11 +++ net/netfilter/core.c |3 +++ net/netfilter/xt_TEE.c| 13

[PATCH 02/18] netfilter: Simply the tests for enabling and disabling the ingress queue hook

2015-08-04 Thread Pablo Neira Ayuso
increments together. Signed-off-by: Eric W. Biederman ebied...@xmission.com Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/core.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/net/netfilter/core.c b/net/netfilter/core.c index

[PATCH 05/18] netfilter: nftables: Only run the nftables chains in the proper netns

2015-08-04 Thread Pablo Neira Ayuso
From: Eric W. Biederman ebied...@xmission.com - Register the nftables chains in the network namespace that they need to run in. - Remove the hacks that stopped chains running in the wrong network namespace. Signed-off-by: Eric W. Biederman ebied...@xmission.com Signed-off-by: Pablo Neira

[PATCH 06/18] netfilter: xtables: compute exact size needed for jumpstack

2015-08-04 Thread Pablo Neira Ayuso
. The stacksize is then set to the largest chain depth seen. Signed-off-by: Florian Westphal f...@strlen.de Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/ipv4/netfilter/arp_tables.c | 19 --- net/ipv4/netfilter/ip_tables.c | 28 ++-- net/ipv6/netfilter

[PATCH 00/18] Netfilter updates for net-next

2015-08-04 Thread Pablo Neira Ayuso
: xtables: remove __pure annotation netfilter: bridge: reduce nf_bridge_info to 32 bytes again Michal Kubeček (1): netfilter: nf_ct_sctp: minimal multihoming support Pablo Neira Ayuso (3): netfilter: nf_queue: fix nf_queue_nf_hook_drop() netfilter: fix possible removal

[PATCH 13/18] netfilter: fix possible removal of wrong hook

2015-08-04 Thread Pablo Neira Ayuso
cause us problems in the future, so better address this problem now by keeping a reference to the original nf_hook_ops structure to make sure we delete the right hook from nf_unregister_net_hook(). Fixes: 085db2c04557 (netfilter: Per network namespace netfilter hooks.) Signed-off-by: Pablo Neira Ayuso

[PATCH 04/18] netfilter: Per network namespace netfilter hooks.

2015-08-04 Thread Pablo Neira Ayuso
From: Eric W. Biederman ebied...@xmission.com - Add a new set of functions for registering and unregistering per network namespace hooks. - Modify the old global namespace hook functions to use the per network namespace hooks in their implementation, so their remains a single list that

[PATCH 10/18] netfilter: xtables: remove __pure annotation

2015-08-04 Thread Pablo Neira Ayuso
-by: Florian Westphal f...@strlen.de Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/ipv4/netfilter/arp_tables.c |2 +- net/ipv4/netfilter/ip_tables.c |2 +- net/ipv6/netfilter/ip6_tables.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv4

[PATCH 01/18] netfilter: kill nf_hooks_active

2015-08-04 Thread Pablo Neira Ayuso
From: Eric W. Biederman ebied...@xmission.com The function obscures what is going on in nf_hook_thresh and it's existence requires computing the hook list twice. Signed-off-by: Eric W. Biederman ebied...@xmission.com Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/linux

[PATCH 03/18] netfilter: Factor out the hook list selection from nf_register_hook

2015-08-04 Thread Pablo Neira Ayuso
of nf_hook_mutex as nothing in the selection requires the hook list, and error handling is simpler if a mutex is not held. Signed-off-by: Eric W. Biederman ebied...@xmission.com Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/core.c | 32

[PATCH 16/18] netfilter: bridge: reduce nf_bridge_info to 32 bytes again

2015-08-04 Thread Pablo Neira Ayuso
. Signed-off-by: Florian Westphal f...@strlen.de Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- include/linux/netfilter_bridge.h | 12 +--- include/linux/skbuff.h| 19 +-- net/bridge/br_netfilter_hooks.c | 14

[PATCH 18/18] netfilter: ip6t_REJECT: Remove debug messages from reject_tg6()

2015-08-04 Thread Pablo Neira Ayuso
From: Subash Abhinov Kasiviswanathan subas...@codeaurora.org Make it similar to reject_tg() in ipt_REJECT. Suggested-by: Pablo Neira Ayuso pa...@netfilter.org Signed-off-by: Subash Abhinov Kasiviswanathan subas...@codeaurora.org Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/ipv6

[PATCH 14/18] netfilter: rename local nf_hook_list to hook_list

2015-08-04 Thread Pablo Neira Ayuso
085db2c04557 (netfilter: Per network namespace netfilter hooks.) introduced a new nf_hook_list that is global, so let's avoid this overlap. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org Acked-by: Eric W. Biederman ebied...@xmission.com --- include/linux/netfilter.h | 14

[PATCH 15/18] netfilter: nf_ct_sctp: minimal multihoming support

2015-08-04 Thread Pablo Neira Ayuso
) HEARTBEAT_ACKED: 210 seconds (hb_interval * path_max_retry + max_rto) (We cannot expect to see the shutdown sequence so that, unlike ESTABLISHED, the HEARTBEAT_ACKED timeout shouldn't be too long.) Signed-off-by: Michal Kubecek mkube...@suse.cz Signed-off-by: Pablo Neira Ayuso pa

[PATCH 12/18] netfilter: nf_queue: fix nf_queue_nf_hook_drop()

2015-08-04 Thread Pablo Neira Ayuso
for this netns, not for every netns. Reported-by: Fengguang Wu fengguang...@intel.com Fixes: 085db2c04557 (netfilter: Per network namespace netfilter hooks.) Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org Acked-by: Eric W. Biederman ebied...@xmission.com --- net/netfilter/core.c |2 +- net

Re: [PATCH] netfilter: ipt_SYNPROXY: fix sending window update to client

2015-08-04 Thread Pablo Neira Ayuso
On Tue, Jul 28, 2015 at 12:53:26AM +0200, Phil Sutter wrote: Upon receipt of SYNACK from the server, ipt_SYNPROXY first sends back an ACK to finish the server handshake, then calls nf_ct_seqadj_init() to initiate sequence number adjustment of forwarded packets to the client and finally

Re: [patch -master] netfilter: xt_CT: checking for IS_ERR() instead of NULL

2015-08-03 Thread Pablo Neira Ayuso
On Mon, Aug 03, 2015 at 11:30:16AM -0700, Joe Stringer wrote: On 3 August 2015 at 11:29, Joe Stringer joestrin...@nicira.com wrote: On 30 July 2015 at 04:57, Pablo Neira Ayuso pa...@netfilter.org wrote: On Tue, Jul 28, 2015 at 01:42:28AM +0300, Dan Carpenter wrote: We recently changed

Re: [patch -master] netfilter: xt_CT: checking for IS_ERR() instead of NULL

2015-07-30 Thread Pablo Neira Ayuso
On Thu, Jul 30, 2015 at 03:01:08PM +0300, Dan Carpenter wrote: On Thu, Jul 30, 2015 at 01:57:43PM +0200, Pablo Neira Ayuso wrote: I have also appended this chunk, since synproxy is also affected: Thanks. I have rechecked my scripts and I *should* have caught that. I'm not sure what went

Re: [patch -master] netfilter: xt_CT: checking for IS_ERR() instead of NULL

2015-07-30 Thread Pablo Neira Ayuso
On Tue, Jul 28, 2015 at 01:42:28AM +0300, Dan Carpenter wrote: We recently changed this from nf_conntrack_alloc() to nf_ct_tmpl_alloc() so the error handling needs to changed to check for NULL instead of IS_ERR(). Fixes: 0838aa7fcfcd ('netfilter: fix netns dependencies with conntrack

Re: [PATCH nf-next v2] netfilter: nf_ct_sctp: minimal multihoming support

2015-07-30 Thread Pablo Neira Ayuso
On Fri, Jul 17, 2015 at 04:17:56PM +0200, Michal Kubecek wrote: Currently nf_conntrack_proto_sctp module handles only packets between primary addresses used to establish the connection. Any packets between secondary addresses are classified as invalid so that usual firewall configurations drop

Re: [PATCH nf 0/6] IPVS Fixes for v4.2

2015-07-22 Thread Pablo Neira Ayuso
Hi Simon, On Thu, Jul 16, 2015 at 11:14:07AM +0900, Simon Horman wrote: Hi Pablo, please consider this fix for v4.2. For reasons that are not clear to me it is a bumper crop. It seems to me that they are all relevant to stable. Please let me know if you need my help to get the fixes into

Re: [PATCH nf] netfilter: Support expectations in different zones

2015-07-22 Thread Pablo Neira Ayuso
On Tue, Jul 21, 2015 at 09:37:31PM -0700, Joe Stringer wrote: When zones were originally introduced, the expectation functions were all extended to perform lookup using the zone. However, insertion was not modified to check the zone. This means that two expectations which are intended to apply

[PATCH 06/10] ipvs: skb_orphan in case of forwarding

2015-07-22 Thread Pablo Neira Ayuso
From: Alex Gartrell agartr...@fb.com It is possible that we bind against a local socket in early_demux when we are actually going to want to forward it. In this case, the socket serves no purpose and only serves to confuse things (particularly functions which implicitly expect sk_fullsock to be

[PATCH 10/10] netfilter: nf_conntrack: Support expectations in different zones

2015-07-22 Thread Pablo Neira Ayuso
connections that have the same tuple but exist in different zones cannot both be tracked. Fixes: 5d0aa2ccd4 (netfilter: nf_conntrack: add support for conntrack zones) Signed-off-by: Joe Stringer joestrin...@nicira.com Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter

[PATCH 07/10] ipvs: fix crash with sync protocol v0 and FTP

2015-07-22 Thread Pablo Neira Ayuso
From: Julian Anastasov j...@ssi.bg Fix crash in 3.5+ if FTP is used after switching sync_version to 0. Fixes: 749c42b620a9 (ipvs: reduce sync rate with time thresholds) Signed-off-by: Julian Anastasov j...@ssi.bg Signed-off-by: Simon Horman ho...@verge.net.au --- net/netfilter/ipvs/ip_vs_sync.c

[PATCH 03/10] ipvs: fix ipv6 route unreach panic

2015-07-22 Thread Pablo Neira Ayuso
From: Alex Gartrell agartr...@fb.com Previously there was a trivial panic unshare -n /bin/bash EOF ip addr add dev lo face::1/128 ipvsadm -A -t [face::1]:15213 ipvsadm -a -t [face::1]:15213 -r b00c::1 echo boom | nc face::1 15213 EOF This patch allows us to replicate the net logic above and

[PATCH 01/10] netfilter: ctnetlink: put back references to master ct and expect objects

2015-07-22 Thread Pablo Neira Ayuso
We have to put back the references to the master conntrack and the expectation that we just created, otherwise we'll leak them. Fixes: 0ef71ee1a5b9 (netfilter: ctnetlink: refactor ctnetlink_create_expect) Reported-by: Tim Wiess tim.wi...@watchguard.com Signed-off-by: Pablo Neira Ayuso pa

[PATCH 02/10] netfilter: IDLETIMER: fix lockdep warning

2015-07-22 Thread Pablo Neira Ayuso
trace 41d156354d18c039 ]--- Signed-off-by: Dmitry Torokhov d...@google.com Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/xt_IDLETIMER.c |1 + 1 file changed, 1 insertion(+) diff --git a/net/netfilter/xt_IDLETIMER.c b/net/netfilter/xt_IDLETIMER.c index f407ebc1..29d2c31

[PATCH 00/10] Netfilter/IPVS fixes for net

2015-07-22 Thread Pablo Neira Ayuso
protocol v0 and FTP ipvs: call skb_sender_cpu_clear Pablo Neira Ayuso (3): netfilter: ctnetlink: put back references to master ct and expect objects netfilter: fix netns dependencies with conntrack templates Merge tag 'ipvs-fixes-for-v4.2' of https://git.kernel.org/.../horms/ipvs

[PATCH 09/10] netfilter: fix netns dependencies with conntrack templates

2015-07-22 Thread Pablo Neira Ayuso
is removed. Reported-by: Daniel Borkmann dan...@iogearbox.net Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org Tested-by: Daniel Borkmann dan...@iogearbox.net --- include/net/netfilter/nf_conntrack.h |2 +- include/net/netns/conntrack.h|1 - net/netfilter/nf_conntrack_core.c

[PATCH 04/10] ipvs: do not use random local source address for tunnels

2015-07-22 Thread Pablo Neira Ayuso
From: Julian Anastasov j...@ssi.bg Michael Vallaly reports about wrong source address used in rare cases for tunneled traffic. Looks like __ip_vs_get_out_rt in 3.10+ is providing uninitialized dest_dst-dst_saddr.ip because ip_vs_dest_dst_alloc uses kmalloc. While we retry after seeing EINVAL from

[PATCH 05/10] ipvs: fix crash if scheduler is changed

2015-07-22 Thread Pablo Neira Ayuso
From: Julian Anastasov j...@ssi.bg I overlooked the svc-sched_data usage from schedulers when the services were converted to RCU in 3.10. Now the rare ipvsadm -E command can change the scheduler but due to the reverse order of ip_vs_bind_scheduler and ip_vs_unbind_scheduler we provide new

[PATCH 08/10] ipvs: call skb_sender_cpu_clear

2015-07-22 Thread Pablo Neira Ayuso
From: Julian Anastasov j...@ssi.bg Reset XPS's sender_cpu on forwarding. Signed-off-by: Julian Anastasov j...@ssi.bg Fixes: 2bd82484bb4c (xps: fix xps for stacked devices) Signed-off-by: Simon Horman ho...@verge.net.au --- net/netfilter/ipvs/ip_vs_xmit.c |6 ++ 1 file changed, 6

Re: [PATCH -next 0/6] Per network namespace netfilter chains

2015-07-16 Thread Pablo Neira Ayuso
On Wed, Jul 15, 2015 at 03:05:00PM -0500, Eric W. Biederman wrote: Pablo Neira Ayuso pa...@netfilter.org writes: [...] There are lots of other possible and desirable cleanups but this one is a core change needed to make the other changes independent small changes. The state-net field

Re: [PATCH -next 0/6] Per network namespace netfilter chains

2015-07-15 Thread Pablo Neira Ayuso
On Fri, Jul 10, 2015 at 06:11:46PM -0500, Eric W. Biederman wrote: By maintining a set of functions to register and unregister netfilter hooks both globally and per network namespace I have managed to write a compact patchset that maintain per network netfilter chains, and registers the

Re: [PATCH -next 5/6] netfilter: Per network namespace netfilter hooks.

2015-07-15 Thread Pablo Neira Ayuso
On Fri, Jul 10, 2015 at 06:15:06PM -0500, Eric W. Biederman wrote: @@ -102,13 +112,35 @@ int nf_register_hook(struct nf_hook_ops *reg) #endif return 0; } -EXPORT_SYMBOL(nf_register_hook); +EXPORT_SYMBOL(nf_register_net_hook); -void nf_unregister_hook(struct nf_hook_ops *reg)

Re: [PATCH nf-next] net-ipvs: Delete an unnecessary check before the function call module_put

2015-07-15 Thread Pablo Neira Ayuso
On Fri, Jul 10, 2015 at 03:42:49PM +0900, Simon Horman wrote: From: Markus Elfring elfr...@users.sourceforge.net The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the

Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support

2015-07-15 Thread Pablo Neira Ayuso
On Tue, Jul 14, 2015 at 06:28:50PM +0200, Michal Kubecek wrote: On Tue, Jul 14, 2015 at 05:38:47PM +0200, Pablo Neira Ayuso wrote: On Tue, Jul 14, 2015 at 02:23:11PM +0200, Michal Kubecek wrote: @@ -658,6 +696,18 @@ static struct ctl_table sctp_sysctl_table[] = { .mode

Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support

2015-07-14 Thread Pablo Neira Ayuso
On Tue, Jul 14, 2015 at 02:23:11PM +0200, Michal Kubecek wrote: @@ -658,6 +696,18 @@ static struct ctl_table sctp_sysctl_table[] = { .mode = 0644, .proc_handler = proc_dointvec_jiffies, }, + { + .procname =

Re: [PATCH] nf: IDLETIMER: fix lockdep warning

2015-07-13 Thread Pablo Neira Ayuso
On Thu, Jul 09, 2015 at 05:15:01PM -0700, Dmitry Torokhov wrote: Dynamically allocated sysfs attributes should be initialized with sysfs_attr_init() otherwise lockdep will be angry with us: [ 45.468653] BUG: key ffc030fad4e0 not in .data! [ 45.468655] [ cut here

Re: [PATCH] nf: IDLETIMER: fix lockdep warning

2015-07-13 Thread Pablo Neira Ayuso
On Mon, Jul 13, 2015 at 08:02:36AM -0700, Dmitry Torokhov wrote: On Mon, Jul 13, 2015 at 6:20 AM, Pablo Neira Ayuso pa...@netfilter.org wrote: On Thu, Jul 09, 2015 at 05:15:01PM -0700, Dmitry Torokhov wrote: Dynamically allocated sysfs attributes should be initialized with sysfs_attr_init

[PATCH 2/7] netfilter: bridge: fix CONFIG_NF_DEFRAG_IPV4/6 related warnings/errors

2015-07-08 Thread Pablo Neira Ayuso
: forward IPv6 fragmented packets) Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Bernhard Thaler bernhard.tha...@wvnet.at Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/bridge/br_netfilter_hooks.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH 0/7] Netfilter fixes for net

2015-07-08 Thread Pablo Neira Ayuso
: bridge: don't leak skb in error paths Julien Grall (1): netfilter: bridge: Use __in6_dev_get rather than in6_dev_get in br_validate_ipv6 Pablo Neira Ayuso (2): netfilter: nfnetlink: keep going batch handling on missing modules MAINTAINER: add bridge netfilter MAINTAINERS

[PATCH 3/7] netfilter: arptables: use percpu jumpstack

2015-07-08 Thread Pablo Neira Ayuso
Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/ipv4/netfilter/arp_tables.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c index 95c9b6e..92305a1 100644 --- a/net/ipv4

Re: [PATCH v2] net/bridge: Use __in6_dev_get rather than in6_dev_get in br_validate_ipv6

2015-07-08 Thread Pablo Neira Ayuso
...@wvnet.at Cc: Pablo Neira Ayuso pa...@netfilter.org Cc: f...@strlen.de Cc: ian.campb...@citrix.com Cc: wei.l...@citrix.com Cc: Bob Liu bob@oracle.com --- Note that it's impossible to create new guest after this message. I'm not sure if it's normal. Changes in v2

[PATCH 5/7] netfilter: nfnetlink: keep going batch handling on missing modules

2015-07-08 Thread Pablo Neira Ayuso
synchronize_rcu() call in a row. This patch changes the policy to keep full batch processing on missing modules errors so we abort only once. Reported-by: Eric Leblond e...@regit.org Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/netfilter/nfnetlink.c | 38

[PATCH 4/7] netfilter: bridge: don't leak skb in error paths

2015-07-08 Thread Pablo Neira Ayuso
packets) Signed-off-by: Florian Westphal f...@strlen.de Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- net/bridge/br_netfilter_hooks.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/net/bridge/br_netfilter_hooks.c b/net/bridge/br_netfilter_hooks.c index

[PATCH 6/7] MAINTAINER: add bridge netfilter

2015-07-08 Thread Pablo Neira Ayuso
So scripts/get_maintainer.pl shows the Netfilter mailing lists. Reported-by: Julien Grall julien.gr...@citrix.com Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 993d4cf..8183b465 100644

[PATCH 7/7] netfilter: bridge: Use __in6_dev_get rather than in6_dev_get in br_validate_ipv6

2015-07-08 Thread Pablo Neira Ayuso
: unregister_netdevice: waiting for vif1.0 to become free. Usage count = 1 Signed-off-by: Julien Grall julien.gr...@citrix.com Cc: Bernhard Thaler bernhard.tha...@wvnet.at Cc: Pablo Neira Ayuso pa...@netfilter.org Cc: f...@strlen.de Cc: ian.campb...@citrix.com Cc: wei.l...@citrix.com Cc: Bob Liu bob

<    17   18   19   20   21   22   23   24   >