From: Palmer Dabbelt
e1000e_check_me is only used under CONFIG_PM_SLEEP but exists
unconditionally, which triggers a warning.
Signed-off-by: Palmer Dabbelt
---
drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/e1000e
On Tue, 15 Jan 2019 00:35:15 PST (-0800), bjorn.to...@gmail.com wrote:
Hi!
I've been hacking on a RV64G eBPF JIT compiler, and would like some
feedback.
Codewise, it needs some refactoring. Currently there's a bit too much
copy-and-paste going on, and I know some places where I could optimize
t
On Fri, 25 Jan 2019 17:33:50 PST (-0800), Jim Wilson wrote:
On Fri, Jan 25, 2019 at 12:21 PM Palmer Dabbelt wrote:
Jim, would you be opposed to something like this?
This looks OK to me.
OK, thanks. I'll send some patches around :)
+builtin_define_with_int_
On Tue, 15 Jan 2019 08:06:47 PST (-0800), bjorn.to...@gmail.com wrote:
Den tis 15 jan. 2019 kl 16:39 skrev Christoph Hellwig :
Hmm, while the RISC-V spec requires misaligned load/store support,
who says they are efficient? Maybe add a little comment that says
on which cpus they are efficient.
On Tue, 15 Jan 2019 08:03:18 PST (-0800), bjorn.to...@gmail.com wrote:
Den tis 15 jan. 2019 kl 16:40 skrev Christoph Hellwig :
Hi Björn,
at least for me patch 3 didn't make it to the list.
Hmm, held back: "Your message to linux-riscv awaits moderator
approval". Exceeded the 40k limit.
I'll
On Wed, 28 Nov 2018 18:28:58 PST (-0800), and...@lunn.ch wrote:
This is all fine as long as Linux doesn't go and reset the phy again. Until
bafbdd527d56 ("phylib: Add device reset GPIO support") was the case. After
that commit I believe phylib is resetting the phy while attempting to enter
unman
On Wed, 28 Nov 2018 13:33:47 PST (-0800), f.faine...@gmail.com wrote:
+Andrew, Heiner,
On 11/28/18 10:15 AM, Atish Patra wrote:
On 11/28/18 2:11 AM, Andreas Schwab wrote:
The PHY probing of the macb driver appears to be rather unreliable.
Most of the time it doesn't work the first time, I have
shim does not initialize PCI bus */
#define pcibios_assign_all_busses() 1
-/* We do not have an IOMMU */
-#define PCI_DMA_BUS_IS_PHYS 1
-
extern int isa_dma_bridge_buggy;
#ifdef CONFIG_PCI
Thanks!
Acked-by: Palmer Dabbelt (For the RISC-V change)
On Thu, 15 Mar 2018 03:42:25 PDT (-0700), Arnd Bergmann wrote:
On Thu, Mar 15, 2018 at 10:59 AM, Hannes Reinecke wrote:
On 03/15/2018 10:42 AM, David Howells wrote:
Do we have anything left that still implements NOMMU?
RISC-V ?
(evil grin :-)
Is anyone producing a chip that includes enough
On Thu, 10 Sep 2015 04:18:05 PDT (-0700), dhowe...@redhat.com wrote:
> David Howells wrote:
>
>> Rather than iterating through all the rest of your patches and saying the
>> same
>> thing, if there's something in a UAPI header that needs wrapping in
>> __KERNEL__
>> to exclude it from userspace'
and the ELF core dump
note payload are exactly the same layout.
"
seems to indicate that it's possible to see this sometimes. Since
this would only be visible to userspace in a somewhat convoluted
manner, I'm going to try and keep it as it was.
Signed-off-by: Palmer Dabbelt
Reviewe
This used to just be behind an #ifdef COMPAT_COMPAT, so most of
userspace wouldn't have seen the definition before. This change just
makes the __KERNEL__ part explicit to quiet the header checker.
Signed-off-by: Palmer Dabbelt
Reviewed-by: Andrew Waterman
Reviewed-by: Albert Ou
---
in
I cut the RISC-V stuff, but I intend to reply to it later. As you
said, it's just a different topic.
>>> However, I did see a lot of similar bugs now that you point me to it:
>>>
>>> $ grep -r \\\>> obj-tmp/usr/include/asm-generic/fcntl.h:#ifndef CONFIG_64BIT
>>> obj-tmp/usr/include/asm-generic/
ys in with F_SETLK64 was being defined
(there's some more in glibc, but that's a whole different story... :))
is the result of CONFIG_64BIT showing up in this user-visible header.
confirms this isn't sane, so I replaced it
with a __BITS_PER_LONG check.
Signed-off-by: Palmer Dabbelt
Rev
I think this change actually doesn't do anything: __NR_fork was still
being defined either way, and on my machine fork() in comes
from libc.
That said, I don't think there's any way to determine this
automatically, so this at least quiets the checker.
Signed-off-by: Palmer Dabbe
vices (i.e., devices where one
has complete control of the contents of user memory).
and since the only time it shows up in my /usr/include is in this
header I believe this should have been visible to userspace (as
non-zero, which wouldn't do anything when or'd into the flags) all
along.
S
This doesn't make any sense to expose to userspace.
Signed-off-by: Palmer Dabbelt
Reviewed-by: Andrew Waterman
Reviewed-by: Albert Ou
---
include/uapi/linux/eventpoll.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/uapi/linux/eventpoll.h b/include/uapi/linux/eventpoll.h
I'm not sure what this is, but it doesn't feel like something that
should be exposed to userspace here. I'm assuming this file was
exposed for the structure in it, which doesn't depend on
MAX_SHARED_LIBS.
Signed-off-by: Palmer Dabbelt
Reviewed-by: Andrew Waterman
Re
I think this actually isn't a good idea, but I can't find anything
outside of the kernel that's using this so I'm going to hide it.
Signed-off-by: Palmer Dabbelt
Reviewed-by: Andrew Waterman
Reviewed-by: Albert Ou
---
arch/x86/include/uapi/asm/auxvec.h | 2 ++
1 file c
ff-by: Palmer Dabbelt
Reviewed-by: Andrew Waterman
Reviewed-by: Albert Ou
---
scripts/headers_check.pl | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl
index 62320f93e903..dd413ad9c850 100755
--- a/sc
I don't think this was ever intended to be exposed to userspace.
Signed-off-by: Palmer Dabbelt
Reviewed-by: Andrew Waterman
Reviewed-by: Albert Ou
---
include/uapi/linux/pktcdvd.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/uapi/linux/pktcdvd.h b/include/uapi/linux/pktc
isn't set, but that feels like it'd
be more invasive.
Here I took the simple and fail-fast route to hide all the
definitions.
Signed-off-by: Palmer Dabbelt
Reviewed-by: Andrew Waterman
Reviewed-by: Albert Ou
---
include/uapi/linux/hw_breakpoint.h | 4 +++-
1 file changed, 3 insertions
I don't think this was ever meant to be exposed to userspace.
Signed-off-by: Palmer Dabbelt
Reviewed-by: Andrew Waterman
Reviewed-by: Albert Ou
---
include/uapi/linux/raw.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/uapi/linux/raw.h b/include/uapi/linux/raw.h
Nothing else in the kernel defines this, and this header is visible to
userspace. Rather than hiding it in an #ifdef, I think it's sane to
just make this visible to userspace.
Signed-off-by: Palmer Dabbelt
Reviewed-by: Andrew Waterman
Reviewed-by: Albert Ou
---
include/uapi/linux/fb.
24 matches
Mail list logo
