Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Parag Warudkar
On Dec 20, 2007 3:04 PM, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > I think it is reasonable for Network driver watchdogs to use a > > deferrable timer - if the machine is 100% IDLE there is no one needing > > the network to be up. If there is something running even on the other > > CPU - that

Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Parag Warudkar
On Dec 20, 2007 2:22 PM, Kok, Auke <[EMAIL PROTECTED]> wrote: > ok, that's just bad and if there's no user-defineable limit to the deferral I > definately don't like this change. > > Can I safely assume that any irq will cause all deferred timers to run? I think even other causes for wakeup like p

Re: [PATCH 2/2] net: neighbor timer power saving

2007-12-20 Thread Parag Warudkar
On Dec 20, 2007 12:10 PM, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > Thinking about it more, this looks like a case for just using round_jiffies(). > The GC timer needs to run to clean up under DoS attack, and deferring it > probably > isn't a good idea. But what are the chances that a DoSed

Re: [PATCH] sky2: Use deferrable timer for watchdog

2007-12-20 Thread Parag Warudkar
On Dec 20, 2007 12:51 PM, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > Quit top-posting! > > If this is the case then the whole usage of round_jiffies() is bogus. All > users of round_jiffies() > should just be converted to deferrable?? I am a bit concerned that if > deferrable gets used eve

Re: [PATCH] e1000e: Use deferrable timer for watchdog

2007-12-20 Thread Parag Warudkar
On Dec 20, 2007 12:05 PM, Kok, Auke <[EMAIL PROTECTED]> wrote: > > I can't even apply this patch and the e1000 one... not only is it whitespace > damaged it is also not properly formatted as patch at all. If you want me to > take > these patches seriously, then please fix the formatting issues. S

Re: [PATCH] e1000: Use deferrable timer for watchdog

2007-12-19 Thread Parag Warudkar
On Dec 19, 2007 4:38 PM, Kok, Auke <[EMAIL PROTECTED]> wrote: > Parag Warudkar wrote: > > On 12/19/07, Kok, Auke <[EMAIL PROTECTED]> wrote: > > why would this patch reduce wakeups even more than round_jiffies()? Does it > make > our ~2 second update interval not

Re: [PATCH] e1000: Use deferrable timer for watchdog

2007-12-19 Thread Parag Warudkar
time and haven't seen any problem at all and powertop shows it reduces the wakeups-from-idle. But whatever - no big deal since it already uses round_jiffies(). Parag > > > > Signed-off-by: Parag Warudkar <[EMAIL PROTECTED]> > > > > --- linux-2.6/drive

[PATCH] e1000e: Use deferrable timer for watchdog

2007-12-18 Thread Parag Warudkar
Reduce wakeups from idle per second. Signed-off-by: Parag Warudkar <[EMAIL PROTECTED]> --- linux-2.6/drivers/net/e1000e/netdev.c 2007-12-07 10:04:39.0 -0500 +++ linux-2.6-work/drivers/net/e1000e/netdev.c 2007-12-18 20:45:59.0 -0500 @@ -3899,7 +

[PATCH] e1000: Use deferrable timer for watchdog

2007-12-18 Thread Parag Warudkar
Use deferrable timer for watchdog. Reduces wakeups from idle per second. Signed-off-by: Parag Warudkar <[EMAIL PROTECTED]> --- linux-2.6/drivers/net/e1000/e1000_main.c2007-12-07 10:04:39.0 -0500 +++ linux-2.6-work/drivers/net/e1000/e1000_main.c 2007-12-18 20:38:38.000

[PATCH] sky2: Use deferrable timer for watchdog

2007-12-18 Thread Parag Warudkar
sky2 can use deferrable timer for watchdog - reduces wakeups from idle per second. Signed-off-by: Parag Warudkar <[EMAIL PROTECTED]> --- linux-2.6/drivers/net/sky2.c2007-12-07 10:04:39.0 -0500 +++ linux-2.6-work/drivers/net/sky2.c 2007-12-18 20:07:58.0

[PATCH] sch_generic.c: Make dev_watchdog use deferrable timer

2007-12-18 Thread Parag Warudkar
Reduces the number of wakeups from idle per second, makes powertop happy. Signed-off-by: Parag Warudkar <[EMAIL PROTECTED]> --- linux-2.6/net/sched/sch_generic.c 2007-12-07 10:04:43.0 -0500 +++ linux-2.6-work/net/sched/sch_generic.c 2007-12-16 17:57:05.0 -0500 @@

Re: init_timer_deferrable conversion

2007-12-17 Thread Parag Warudkar
On Dec 17, 2007 9:29 AM, Eric Dumazet <[EMAIL PROTECTED]> wrote: > Parag, could you please try this patch ? > > [NET] ARP : Convert neigh garbage collection from softirq to workqueue > I will - a little later. Thanks Parag -- To unsubscribe from this list: send the line "unsubscribe netdev" in t

Re: init_timer_deferrable conversion

2007-12-17 Thread Parag Warudkar
On Dec 17, 2007 1:13 PM, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > On Mon, 17 Dec 2007 12:47:59 -0500 > "Parag Warudkar" <[EMAIL PROTECTED]> wrote: > > > > On Dec 17, 2007 12:00 PM, Stephen Hemminger > > <[EMAIL PROTECTED]> wrote: > >

Re: init_timer_deferrable conversion

2007-12-17 Thread Parag Warudkar
On Dec 17, 2007 12:00 PM, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > > > > > > > a) drivers/net/sky2.c - watchdog_timer. This was showing up high on > > > > Powertop's list of things that cause routine wakeups from idle. After > > > > converting to init_timer_deferrable() the wakeups went dow

Re: Unexpected Acknowledgement / Stalled Connections

2007-02-04 Thread Parag Warudkar
On 2/4/07, Parag Warudkar <[EMAIL PROTECTED]> wrote: I am running 2.6.20 and have trouble with stalled connections. For instance, if I try to download a debian ISO image using wget, the connection runs fine for few seconds and then stalls for ever. In my router logs I see a ton of message