.h
> +++ b/drivers/soc/fsl/qbman/dpaa_sys.h
>
> +#define CONFIG_TRY_BETTER_MEMCPY
Please replace the CONFIG_ prefix with something else.
> +#ifdef CONFIG_TRY_BETTER_MEMCPY
This will always be true, right?
> [...]
> +#else
> +#define copy_words memcpy
> +#define copy_shorts memcpy
> +#define copy_bytes memcpy
> +#endif
> --- /dev/null
> +++ b/include/soc/fsl/bman.h
> +static inline int bman_reserve_bpid(u32 bpid)
> +{
> + return bman_reserve_bpid_range(bpid, 1);
> +}
Unused.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
t("ASSERT: (%s:%d) %s\n", __FILE__, __LINE__, \
> + __stringify_1(x)); \
> + dump_stack(); \
> + panic("assertion failure"); \
Not my call, but why panic() here?
> + } \
> +
^
cc1: some warnings being treated as errors
scripts/Makefile.build:264: recipe for target
'[...]/drivers/soc/fsl/qbman/bman.o' failed
make[1]: *** [[...]/drivers/soc/fsl/qbman/bman.o] Error 1
Makefile:1568: recipe for target 'bman.ko' failed
make: *** [bman.ko] Error 2
make:
I
couldn't find the struct platform_device's that would, in short, fire
off the corresponding "MODALIAS=platform:mv88e6[...]" uevent when
they're created. Where should I look for those struct platform_device's?
Thanks,
Paul Bolle
--
To unsubscribe from this
# CONFIG_FOO is not set
will be printed if FOO's dependencies are met and FOO either has a
"prompt" or a default of 'n'.
Hope this helps,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord
sock_init);
> +module_exit(hvsock_exit);
Any specific reason not to mark these functions __init and __exit?
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2015-06-25 at 19:59 -0500, Scott Wood wrote:
> On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote:
> > (Evolution 3.16 is basically unbearable for replying to patches.
> > Anyone
> > else running into this?)
You replied with Evolution v3.16, didn't you? Loo
On Fri, 2015-06-26 at 01:53 +0200, Paul Bolle wrote:
> So I decided to pick one subject: exports. I think I had something to
> comment on all eight of them.
s/eight/twelve/
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a m
lmost 20K lines.
So I decided to pick one subject: exports. I think I had something to
comment on all eight of them.
I'm not sure if I'll try another scan with a different subject.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the
rt_disable(struct fm_port_t *p_fm_port)
> +{
> + [...]
> +}
> +EXPORT_SYMBOL(fm_port_disable);
This exports a function that I think is only used inside this file.
> +int fm_port_enable(struct fm_port_t *p_fm_port)
> +{
> + [...]
> +}
> +EXPORT_SYMBOL(fm_port_enab
use_cfg);
This exports a function that is only used in this file. Why?
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
longer?).
Perhaps pcbit, and the other I4L drivers, should be (finally) tossed
out? That was discussed last year too, but nothing really was decided.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
Mo
So I couldn't help having yet another look at the code, just to drive
home my point.
On Thu, 2015-06-11 at 10:55 +0200, Paul Bolle wrote:
> > +void *fm_drv_init(void)
>
> static.
>
> > +{
> > + memset(&fm_drvs, 0, sizeof(fm_drvs));
fm_drvs is an external v
_drv)
static.
> +{
> + platform_driver_unregister(&fm_driver);
> + mutex_destroy(&fm_drv_mutex);
> +
> + return 0;
> +}
And p_fm_drv is unused in the function (and see below).
> +static void *p_fm_drv;
> +static int __init __cold fm_load(void)
>
PL v2.
> +MODULE_LICENSE("GPL");
And, according to include/linux/module.h, this states the license is GPL
v2 or later. So I think that either the comment at the top of this file
or the ident used in the MODULE_LICENSE() macro needs to change.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the MODULE_LICENSE() macro needs to
change.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ING OUT OF
> + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
I have no idea which license this is.
> +MODULE_LICENSE("GPL");
But I do know that it's not GPL v2 or later (see
include/linux/module.h).
Paul Bolle
--
To unsubscribe from this list: se
; srcdir=$(srcdir)$@$(SEPARATOR) to_keep=$(to_keep) print 2>/dev/null
When I did
make ARCH=lib menuconfig
I saw (among other things):
arch/lib/Makefile.print:41: target `trace/' given more than once in the
same rule.
arch/lib/Makefile.print:41: target `trace/' given more th
101 - 118 of 118 matches
Mail list logo
