Re: [PATCH v5 04/19] net: e100: Replace PCI pool old API

igned-off-by: Romain Perier <romain.per...@collabora.com> > > Acked-by: Peter Senna Tschudin <peter.se...@collabora.com> > > Tested-by: Peter Senna Tschudin <peter.se...@collabora.com> > > --- > >  drivers/net/ethernet/intel/e100.c | 12 ++-- > >  

Re: [PATCH v3 12/20] scsi: mpt3sas: Replace PCI pool old API

On Sun, Feb 26, 2017 at 08:24:17PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Reviewed-by: Peter Senna Tschudin <peter.se...@collabora.com> > Signed-off

Re: [PATCH v3 17/20] usb: gadget: pch_udc: Replace PCI pool old API

On Sun, Feb 26, 2017 at 08:24:22PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Reviewed-by: Peter Senna Tschudin <peter.se...@collabora.com> > Signed-off

Re: [PATCH v3 13/20] scsi: mvsas: Replace PCI pool old API

On Sun, Feb 26, 2017 at 08:24:18PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Reviewed-by: Peter Senna Tschudin <peter.se...@collabora.com> > Signed-off

Re: [PATCH v3 11/20] scsi: megaraid: Replace PCI pool old API

On Sun, Feb 26, 2017 at 08:24:16PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Reviewed-by: Peter Senna Tschudin <peter.se...@collabora.com> > Signed-off

Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API

hes did sent some comments for this one, did you address them? Reviewed-by: Peter Senna Tschudin <peter.se...@collabora.com> > Signed-off-by: Romain Perier <romain.per...@collabora.com> > --- > scripts/checkpatch.pl | 9 - > 1 file changed, 8 insertions(+), 1 d

Re: [PATCH v3 19/20] PCI: Remove PCI pool macro functions

On Sun, Feb 26, 2017 at 08:24:24PM +0100, Romain Perier wrote: > Now that all the drivers use dma pool API, we can remove the macro > functions for PCI pool. > Reviewed-by: Peter Senna Tschudin <peter.se...@collabora.com> > Signed-off-by: Romain Perier <romain

Re: [PATCH v3 00/20] Replace PCI pool by DMA pool API

On Sun, Feb 26, 2017 at 08:24:05PM +0100, Romain Perier wrote: > The current PCI pool API are simple macro functions direct expanded to > the appropriated dma pool functions. The prototypes are almost the same > and semantically, they are very similar. I propose to use the DMA pool > API directly

Re: [PATCH v3 07/20] wireless: ipw2200: Replace PCI pool old API

On Sun, Feb 26, 2017 at 08:24:12PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Reviewed-by: Peter Senna Tschudin <peter.se...@collabora.com> > Signed-off

Re: [PATCH v3 09/20] scsi: csiostor: Replace PCI pool old API

t; Reviewed-by: Peter Senna Tschudin <peter.se...@collabora.com> > Signed-off-by: Romain Perier <romain.per...@collabora.com> > --- > drivers/scsi/csiostor/csio_hw.h | 2 +- > drivers/scsi/csiostor/csio_init.c | 11 ++- > drivers/scsi/csiostor/csio_scsi.c | 6 +

Re: [PATCH v3 18/20] usb: host: Remove remaining pci_pool in comments

On Sun, Feb 26, 2017 at 08:24:23PM +0100, Romain Perier wrote: > This replaces remaining occurences of pci_pool by dma_pool, as > this is the new API that could be used for that purpose. > Reviewed-by: Peter Senna Tschudin <peter.se...@collabora.com> > Signed-off-by: Romain

Re: [PATCH v3 06/20] mlx5: Replace PCI pool old API

On Sun, Feb 26, 2017 at 08:24:11PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Reviewed-by: Peter Senna Tschudin <peter.se...@collabora.com> > Signed-off

Re: [PATCH v3 10/20] scsi: lpfc: Replace PCI pool old API

On Sun, Feb 26, 2017 at 08:24:15PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. It also updates > some comments, accordingly. > Reviewed-by: Peter Senna Tschud

Re: [RFC v2 11/20] scsi: megaraid: Replace PCI pool old API

On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Did not apply on linux-next-20170217 > > Signed-off-by: Romain Perier

Re: [RFC v2 00/20] Replace PCI pool by DMA pool API

On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote: Tested all patches by compilation and checkpatch. All of them compile fine, but patches 11 and 12 need some fixes. You can resend as PATCH instead of RFC. > The current PCI pool API are simple macro functions direct expanded to > the

Re: [RFC v2 12/20] scsi: mpt3sas: Replace PCI pool old API

On Sat, Feb 18, 2017 at 09:35:48AM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Please run checkpatch, fix the style issue and resend. > > Signed-off-by: Romain Perier

Re: [RFC v2 11/20] scsi: megaraid: Replace PCI pool old API

On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote: Hi Romain, Checkpatch gives some warnings you can fix related to NULL tests before dma_pool_destroy(), and you changed indentation style in some of your changes. Some times it is important to keep consistency within a file even if

Re: [RFC v2 01/20] block: DAC960: Replace PCI pool old API

<romain.per...@collabora.com> > Acked-by: Peter Senna Tschudin <peter.se...@collabora.com> > Tested-by: Peter Senna Tschudin <peter.se...@collabora.com> > --- > drivers/block/DAC960.c | 36 ++-- > drivers/block/DAC960.h | 4 ++-- >

Re: [RFC 11/19] scsi: megaraid: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:49PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- >

Re: [RFC 10/19] scsi: lpfc: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:48PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/lpfc/lpfc.h |

Re: [RFC 19/19] checkpatch: warn for use of old PCI pool API

On Wed, Feb 08, 2017 at 05:34:57PM +0100, Romain Perier wrote: > pci_pool_*() functions should be replaced by the corresponding functions > in the DMA pool API. This adds support to check for use of these pci > functions and display a warning when it is the case. Don't know if relevant, but did

Re: [RFC 00/19] Replace PCI pool by DMA pool API

On Wed, Feb 08, 2017 at 05:34:38PM +0100, Romain Perier wrote: Hi Romain, Nice set of patches! Thank you. I sent a few comments, but basically you missed to run checkpatch.pl on your patches. Also you can take the chance to fix some white space issues that are on the lines you are changing like

Re: [RFC 04/19] net: e100: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:42PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Tested by compilation only. Acked-by: Peter Senna Tschudin <peter.se...@collabora.co

Re: [RFC 05/19] mlx4: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:43PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Tested by compilation only. Acked-by: Peter Senna Tschudin <peter.se...@collabora.co

Re: [RFC 18/19] PCI: Remove PCI pool macro functions

On Wed, Feb 08, 2017 at 05:34:56PM +0100, Romain Perier wrote: > Now that all the drivers use dma pool API, we can remove the macro > functions for PCI pool. Good news: make allyesconfig;make succeed after the changes until this point, but: $ grep -R pci_pool ...

Re: [RFC 15/19] usb: gadget: amd5536udc: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:53PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin <peter.se...@collabora

Re: [RFC 14/19] scsi: pmcraid: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:52PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin <peter.se...@collabora

Re: [RFC 17/19] usb: gadget: pch_udc: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:55PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- >

Re: [RFC 02/19] dmaengine: pch_dma: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:40PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin <peter.se...@collabora

Re: [RFC 13/19] scsi: mvsas: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:51PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/mvsas/mv_init.c |

Re: [RFC 16/19] usb: gadget: net2280: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:54PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin <peter.se...@collabora

Re: [RFC 12/19] scsi: mpt3sas: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:50PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- >

Re: [RFC 03/19] IB/mthca: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:41PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Tested by compilation only. Acked-by: Peter Senna Tschudin <peter.se...@collabora.co

Re: [RFC 01/19] block: DAC960: Replace PCI pool old API

ilation only. Some whitespace errors, but the patch do not add new ones. Acked-by: Peter Senna Tschudin <peter.se...@collabora.com> Tested-by: Peter Senna Tschudin <peter.se...@collabora.com> > --- > drivers/block/DAC960.c | 36 ++-- > drivers/block/DA

Re: [RFC 06/19] mlx5: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:44PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- >

Re: [RFC 09/19] scsi: csiostor: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:47PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/csiostor/csio_hw.h

Re: [RFC 08/19] scsi: be2iscsi: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:46PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin <peter.se...@collabora

Re: [RFC 07/19] wireless: ipw2200: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:45PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- >

[PATCH 1/1] igb: Fix hw_dbg logging in igb_update_flash_i210

From: Hannu Lounento <hannu.loune...@ge.com> Fix an if statement with hw_dbg lines where the logic was inverted with regards to the corresponding return value used in the if statement. Signed-off-by: Hannu Lounento <hannu.loune...@ge.com> Signed-off-by: Peter Senna Tschud