[PATCH] arch/x86: Initialize __max_smt_threads to 1

2017-12-06 Thread Prarit Bhargava
A single socket, single core, single thread system has __max_smt_threads set to 0 since smp_callin() is not called. __max_smt_threads must be a minimum of 1. Fixes: b1cbacc8663a ("x86/smpboot: Do not use smp_num_siblings in __max_logical_packages calculation) Signed-off-by: Prarit Bhargava

Re: b1cbacc866 ("x86/smpboot: Do not use smp_num_siblings in .."): divide error: 0000 [#1] SMP DEBUG_PAGEALLOC

2017-12-05 Thread Prarit Bhargava
threads set to 0 since smp_callin() is not called. __max_smt_threads must be a minimum of 1. Fixes: b1cbacc8663a ("x86/smpboot: Do not use smp_num_siblings in __max_logical_packages calculation) Signed-off-by: Prarit Bhargava <pra...@redhat.com> Cc: Jakub Kicinski <kubak..

Re: [bisected] x86 boot still broken on -rc2

2017-12-04 Thread Prarit Bhargava
On 12/04/2017 08:13 AM, Prarit Bhargava wrote: > > > x86: Booting SMP configuration: > node #0, CPUs:#1 #2 #3 #4 > node #1, CPUs:#5 #6 #7 #8 #9 > node #0, CPUs: #10 #11 #12 #13 #14 > node #1, CPUs: #15 #16 #17 #18 #19 > smp

Re: [bisected] x86 boot still broken on -rc2

2017-12-04 Thread Prarit Bhargava
On 12/04/2017 07:28 AM, Prarit Bhargava wrote: > > > On 12/03/2017 08:28 PM, Jakub Kicinski wrote: >> Same thing on rc2, bisected down to: >> >> commit b4c0a7326f5dc0ef7a64128b0ae7d081f4b2cbd1 (refs/bisect/bad) >> Author: Prarit Bhargava <pra...@redhat.com&

Re: [bisected] x86 boot still broken on -rc2

2017-12-04 Thread Prarit Bhargava
On 12/03/2017 08:28 PM, Jakub Kicinski wrote: > Same thing on rc2, bisected down to: > > commit b4c0a7326f5dc0ef7a64128b0ae7d081f4b2cbd1 (refs/bisect/bad) > Author: Prarit Bhargava <pra...@redhat.com> > Date: Tue Nov 14 07:42:57 2017 -0500 > > x86/smpboot:

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

2016-07-15 Thread Prarit Bhargava
On 07/15/2016 07:25 AM, Stanislaw Gruszka wrote: > On Thu, Jul 14, 2016 at 09:44:22AM +, Grumbach, Emmanuel wrote: >>> If I understad correctly this error happen 100% of the time, not only during >>> init. Hence seems there is an issue here, i.e. cur_ucode is not marked >>> correctly as

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

2016-07-13 Thread Prarit Bhargava
On 07/13/2016 03:24 AM, Luca Coelho wrote: > On Wed, 2016-07-13 at 09:50 +0300, Kalle Valo wrote: >> Prarit Bhargava <pra...@redhat.com> writes: >> >>>> We implement thermal zone because we do support it, but the >>>> problem is >>>> th

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

2016-07-13 Thread Prarit Bhargava
On 07/13/2016 02:50 AM, Kalle Valo wrote: > Prarit Bhargava <pra...@redhat.com> writes: > >>> We implement thermal zone because we do support it, but the problem is >>> that we need the firmware to be loaded for that. So you can argue that >>> we sh

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

2016-07-11 Thread Prarit Bhargava
On 07/11/2016 02:27 PM, Grumbach, Emmanuel wrote: > On Mon, 2016-07-11 at 14:19 -0400, Prarit Bhargava wrote: >> >> On 07/11/2016 02:00 PM, Emmanuel Grumbach wrote: >>> On Mon, Jul 11, 2016 at 6:18 PM, Prarit Bhargava <pra...@redhat.com >>>> wrote: >

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

2016-07-11 Thread Prarit Bhargava
On 07/11/2016 02:00 PM, Emmanuel Grumbach wrote: > On Mon, Jul 11, 2016 at 6:18 PM, Prarit Bhargava <pra...@redhat.com> wrote: >> >> Didn't get any feedback or review comments on this patch. Resending ... >> >> P. > > This change is obviousl

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

2016-07-11 Thread Prarit Bhargava
On 07/11/2016 12:07 PM, Coelho, Luciano wrote: > On Mon, 2016-07-11 at 11:18 -0400, Prarit Bhargava wrote: >> Didn't get any feedback or review comments on this patch. Resending >> ... >> >> P. > > Sorry, this got flooded down my inbox. NP, Luciano -- My w

[PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

2016-07-11 Thread Prarit Bhargava
ime. This patch moves the firmware check to iwl_mvm_thermal_zone_register() and stops the thermal zone from being created if the ucode hasn't been loaded. Signed-off-by: Prarit Bhargava <pra...@redhat.com> Cc: Johannes Berg <johannes.b...@intel.com> Cc: Emmanuel Grumbach <emmanuel.grumb...@i

[PATCH] iwlwifi, Do not implement thermal zone unless ucode is loaded

2016-07-06 Thread Prarit Bhargava
from being created if the ucode hasn't been loaded. Signed-off-by: Prarit Bhargava <pra...@redhat.com> Cc: Johannes Berg <johannes.b...@intel.com> Cc: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Cc: Luca Coelho <luciano.coe...@intel.com> Cc: Intel Linux Wireless <lin

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-22 Thread Prarit Bhargava
On 10/21/2015 03:52 PM, Michal Marek wrote: > Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): >> On 10/15/2015 04:16 PM, Michal Marek wrote: >>> Otherwise make tags can't parse them: >>> >>> ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-22 Thread Prarit Bhargava
On 10/22/2015 08:06 AM, Michal Marek wrote: > On 2015-10-22 13:31, Prarit Bhargava wrote: >> >> >> On 10/21/2015 03:52 PM, Michal Marek wrote: >>> Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): >>>> On 10/15/2015 04:16 PM, Michal Marek wrote:

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-21 Thread Prarit Bhargava
On 10/15/2015 04:16 PM, Michal Marek wrote: > Otherwise make tags can't parse them: > > ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern "\1" > ctags: Warning: drivers/xen/events/events_2l.c:41: null expansion of name > pattern "\1" > ctags: Warning: