Re: [PATCH] net: phy: xgene: disable clk on error paths

2017-12-17 Thread Quan Nguyen
On Sat, Dec 16, 2017 at 4:52 AM, Alexey Khoroshilov wrote: > > There are several error paths in xgene_mdio_probe(), > where clk is left undisabled. The patch fixes them. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov

Re: [PATCH net-next] drivers: net: xgene: Check all RGMII phy mode variants

2017-05-17 Thread Quan Nguyen
On Thu, May 18, 2017 at 3:26 AM, Andrew Lunn wrote: >> +bool is_xgene_enet_phy_mode_rgmii(struct net_device *ndev) >> +{ >> + struct xgene_enet_pdata *pdata = netdev_priv(ndev); >> + int phy_mode = pdata->phy_mode; >> + bool ret; >> + >> + ret = phy_mode ==

Re: [PATCH net-next 10/10] Documentation: dtb: xgene: Add rxlos GPIO mapping

2016-08-02 Thread Quan Nguyen
On Mon, Aug 1, 2016 at 11:35 PM, Rob Herring <r...@kernel.org> wrote: > On Fri, Jul 29, 2016 at 05:34:03PM -0700, Iyappan Subramanian wrote: >> Signed-off-by: Quan Nguyen <qngu...@apm.com> >> Signed-off-by: Iyappan Subramanian <isubraman...@apm.com> >>

Re: [PATCH net-next 08/10] drivers: net: xgene: Poll link status via GPIO

2016-07-31 Thread Quan Nguyen
s via an > GPIO to determine whether to ignore the link status register and report > link down. > > Signed-off-by: Quan Nguyen <qngu...@apm.com> > Signed-off-by: Iyappan Subramanian <isubraman...@apm.com> > Tested-by: Fushen Chen <fc...@apm.com> > --- >