Re: [PATCH net-next 2/7] net: phy: mscc: add support for VSC8584 PHY

2018-10-01 Thread Quentin Schulz
Hi Andrew, On Fri, Sep 14, 2018 at 07:27:54PM +0200, Andrew Lunn wrote: > > > struct vsc8531_private { > > int rate_magic; > > u16 supp_led_modes; > > @@ -181,6 +354,7 @@ struct vsc8531_private { > > struct vsc85xx_hw_stat *hw_stats; > > u64 *stats; > > int nstats; > > +

[PATCH v2] net: fec: add post PHY reset delay DT property

2017-05-23 Thread Quentin Schulz
. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- v2: - return -EINVAL when phy-reset-post-delay is greater than 1000ms instead of defaulting to 1ms, - remove `default to 1ms` when phy-reset-post-delay > 1000Ms from DT binding doc and commit log, - move

Re: [PATCH] net: fec: add post PHY reset delay DT property

2017-05-22 Thread Quentin Schulz
Hi Andrew On 22/05/2017 15:57, Andrew Lunn wrote: > On Mon, May 22, 2017 at 11:15:17AM +0200, Quentin Schulz wrote: >> Some PHY require to wait for a bit after the reset GPIO has been >> toggled. This adds support for the DT property `phy-reset-post-delay` >> which gives the

[PATCH] net: fec: add post PHY reset delay DT property

2017-05-22 Thread Quentin Schulz
and are default to 1ms. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- Documentation/devicetree/bindings/net/fsl-fec.txt | 5 + drivers/net/ethernet/freescale/fec_main.c | 17 +++-- 2 files changed, 20 insertions(+), 2 deletions(-) diff

Re: [PATCH v4 1/4] can: m_can: move Message RAM initialization to function

2017-05-12 Thread Quentin Schulz
Hi all, On 05/05/2017 15:50, Quentin Schulz wrote: > To avoid possible ECC/parity checksum errors when reading an > uninitialized buffer, the entire Message RAM is initialized when probing > the driver. This initialization is done in the same function reading the > Device Tre

[PATCH v4 1/4] can: m_can: move Message RAM initialization to function

2017-05-05 Thread Quentin Schulz
it can be called separately from device initialization from Device Tree. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- v4: - remove unused variables from m_can_of_parse_mram, drivers/net/can/m_can/m_can.c | 26 +++--- 1 file changed, 15 inse

[PATCH v4 3/4] can: m_can: factorize clock gating and ungating

2017-05-05 Thread Quentin Schulz
This creates a function to ungate M_CAN clocks and another to gate the same clocks, then swaps all gating/ungating code with their respective function. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- added in v4 drivers/net/can/m_can/m_can.

[PATCH v4 4/4] can: m_can: add deep Suspend/Resume support

2017-05-05 Thread Quentin Schulz
This adds Power Management deep Suspend/Resume support for Bosch M_CAN chip. When entering deep sleep, the clocks are gated, the interrupts are disabled. When resuming from deep sleep, the chip needs to be reinitialized, the clocks ungated and the interrupts enabled. Signed-off-by: Quentin

[PATCH v4 2/4] can: m_can: make m_can_start and m_can_stop symmetric

2017-05-05 Thread Quentin Schulz
This moves clocks gating outside of the m_can_stop function as the m_can_start function does not (and cannot, at least in current implementation) ungate clocks. This way, both functions can now be used symmetrically. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> ---

[PATCH v3 1/2] can: m_can: move Message RAM initialization to function

2017-05-05 Thread Quentin Schulz
it can be called separately from device initialization from Device Tree. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- drivers/net/can/m_can/m_can.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/net/can/m_can/m_c

[PATCH v3 2/2] can: m_can: add deep Suspend/Resume support

2017-05-05 Thread Quentin Schulz
This adds Power Management deep Suspend/Resume support for Bosch M_CAN chip. When entering deep sleep, the clocks are gated, the interrupts are disabled. When resuming from deep sleep, the chip needs to be reinitialized, the clocks ungated and the interrupts enabled. Signed-off-by: Quentin

Re: [PATCH v2 2/2] can: m_can: add deep Suspend/Resume support

2017-05-03 Thread Quentin Schulz
Hum, forgot the changelog. On 03/05/2017 14:37, Quentin Schulz wrote: > This adds Power Management deep Suspend/Resume support for Bosch M_CAN > chip. > > When the system resumes from deep sleep, the chip needs to be fully > reinitialized (RAM, chip, clocks, irq, candev, ...) t

[PATCH v2 1/2] can: m_can: move Message RAM initialization to function

2017-05-03 Thread Quentin Schulz
it can be called separately from device initialization from Device Tree. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- drivers/net/can/m_can/m_can.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/net/can/m_can/m_c

[PATCH v2 2/2] can: m_can: add deep Suspend/Resume support

2017-05-03 Thread Quentin Schulz
This adds Power Management deep Suspend/Resume support for Bosch M_CAN chip. When the system resumes from deep sleep, the chip needs to be fully reinitialized (RAM, chip, clocks, irq, candev, ...) to be functional. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- d

Re: [PATCH 2/2] can: m_can: add deep Suspend/Resume support

2017-05-03 Thread Quentin Schulz
Hi Marc, On 03/05/2017 14:16, Marc Kleine-Budde wrote: > On 05/03/2017 02:11 PM, Quentin Schulz wrote: >> This adds Power Management deep Suspend/Resume support for Bosch M_CAN >> chip. >> >> When the chip resumes from deep sleep, the RAM needs to be initialized >&

[PATCH 1/2] can: m_can: move Message RAM initialization to function

2017-05-03 Thread Quentin Schulz
it can be called separately from device initialization from Device Tree. Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- drivers/net/can/m_can/m_can.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/net/can/m_can/m_c

[PATCH 2/2] can: m_can: add deep Suspend/Resume support

2017-05-03 Thread Quentin Schulz
This adds Power Management deep Suspend/Resume support for Bosch M_CAN chip. When the chip resumes from deep sleep, the RAM needs to be initialized as it is done when the driver probes. The net interface also needs to be closed and reopened to be fully functional. Signed-off-by: Quentin Schulz

Re: [PATCH v2] can: m_can: enable transmission of FD frame on latest version

2017-04-07 Thread Quentin Schulz
;; Wenyou Yang - A41535 >> <wenyou.y...@microchip.com>; Wolfgang Grandegger <w...@grandegger.com> >> Cc: Alexandre Belloni <alexandre.bell...@free-electrons.com>; Florian >> Fainelli >> <f.faine...@gmail.com>; Quentin Schulz <quentin.sch...@free-electrons.

[RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest silicon

2017-02-15 Thread Quentin Schulz
Tested with a SAMA5D2 SoC (CREL = 0x31040730) Signed-off-by: Florian Vallee <fval...@eukrea.fr> Tested-by: Quentin Schulz <quentin.sch...@free-electrons.com> --- drivers/net/can/m_can/m_can.c | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) di