Tested-by: Guillaume Nault <g.na...@alphalink.fr>
Signed-off-by: R. Parameswaran <rpara...@brocade.com>
---
include/linux/net.h | 2 +-
net/l2tp/l2tp_eth.c | 2 ++
net/socket.c| 2 +-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/linux/net.h b/include
Hi Guillaume,
Please see inline:
On Wed, Apr 12, 2017 at 12:53 AM, Guillaume Nault <g.na...@alphalink.fr> wrote:
> On Tue, Apr 11, 2017 at 08:14:37PM -0700, R. Parameswaran wrote:
>>
>> The MTU overhead calculation in L2TP device set-up
Hi Dave,
Please see inline:
On Wed, Apr 12, 2017 at 7:13 AM, David Miller <da...@davemloft.net> wrote:
> From: "R. Parameswaran" <parameswaran...@gmail.com>
> Date: Tue, 11 Apr 2017 20:14:37 -0700 (PDT)
>
>>
>> The MTU overhead calculation
The MTU overhead calculation in L2TP device set-up
merged via commit b784e7ebfce8cfb16c6f95e14e8532d0768ab7ff
needs to be adjusted to lock the tunnel socket while
referencing the sub-data structures to derive the
socket's IP overhead.
---
include/linux/net.h | 2 +-
net/l2tp/l2tp_eth.c | 2 ++
Hi Guillaume,
Please see inline:
On Tue, Apr 11, 2017 at 10:05 AM, Guillaume Nault <g.na...@alphalink.fr> wrote:
> On Tue, Apr 11, 2017 at 09:39:58AM -0700, R Parameswaran wrote:
>> Hi Guillaume,
>>
>> On Tue, Apr 11, 2017 at 3:40 AM, Guillaume Nault <g.na...@alphal
Hi Guillaume,
On Tue, Apr 11, 2017 at 3:40 AM, Guillaume Nault <g.na...@alphalink.fr> wrote:
> On Wed, Apr 05, 2017 at 05:00:07PM -0700, R. Parameswaran wrote:
>>
>> Change-set here uses the new kernel function, kernel_sock_ip_overhead(),
>> to factor the outer IP
.
Fixed the kbuild test robot error in the previous posting.
R. Parameswaran (2):
New kernel function to get IP overhead on a socket.
L2TP:Adjust intf MTU, add underlay L3, L2 hdrs.
include/linux/net.h | 3 +++
net/l2tp/l2tp_eth.c | 55
uses the new kernel function, kernel_sock_ip_overhead(),
to factor the outer IP overhead on the L2TP tunnel socket (including
IP Options, if any) when calculating the default MTU for an Ethernet
pseudowire, along with consideration of the inner Ethernet header.
Signed-off-by: R. Parameswaran <rp
in the L2TP code path to compute the
total outer IP overhead on the L2TP tunnel socket when
calculating the default MTU for Ethernet pseudowires.
Signed-off-by: R. Parameswaran <rpara...@brocade.com>
---
include/linux/net.h | 3 +++
net/socket.c
Hi Dave,
Please see inline:
On Mon, 3 Apr 2017, David Miller wrote:
> From: "R. Parameswaran" <parameswaran...@gmail.com>
> Date: Mon, 3 Apr 2017 13:28:11 -0700 (PDT)
>
> > Can I take this to mean that we do need to factor in IP options in
> > th
Hi James, Dave,
Sorry for the delay (was away), please see inline:
On Fri, 24 Mar 2017, James Chapman wrote:
> On 24/03/17 01:51, R. Parameswaran wrote:
> > Hi Dave,
> >
> > Please see inline:
> >
> > On Thu, 23 Mar 2017, David Miller wrote:
> >
>
Hi Dave,
Please see inline:
On Thu, 23 Mar 2017, David Miller wrote:
> From: "R. Parameswaran" <parameswaran...@gmail.com>
> Date: Wed, 22 Mar 2017 15:59:13 -0700 (PDT)
>
> > A new function, kernel_sock_ip_overhead(), is provided
> > to calculate the
in the L2TP code path to compute the
total outer IP overhead on the L2TP tunnel socket when
calculating the default MTU for Ethernet pseudowires.
Signed-off-by: R. Parameswaran <rpara...@brocade.com>
---
include/linux/net.h | 3 +++
net/socket.c
.
Signed-off-by: R. Parameswaran <rpara...@brocade.com>
R. Parameswaran (2):
New kernel function to get IP overhead on a socket.
L2TP:Adjust intf MTU, add underlay L3, L2 hdrs.
include/linux/net.h | 3 +++
net/l2tp/l2tp_eth.c | 55 +---
uses a new kernel function, kernel_sock_ip_overhead,
to factor the outer IP overhead on the L2TP tunnel socket (including
IP Options, if any) when calculating the default MTU for an Ethernet
pseudowire, along with consideration of the inner Ethernet header.
Signed-off-by: R. Parameswaran <rp
A new function, kernel_sock_ip_overhead(), is provided
to calculate the cumulative overhead imposed by the IP
Header and IP options, if any, on a socket's payload.
The new function returns an overhead of zero for sockets
that do not belong to the IPv4 or IPv6 address families.
Signed-off-by: R
vidually generating each
commit's patch. I just figured out how to generate a cover letter and
multiple patches in one shot with git format-patch, will update with the
suggested changes in a day or so. I also tested the latest patch,
verified it to be working correctly.
thanks,
Ramkumar
d review/comment on. I'll re-post with changes after
that.
thanks,
Ramkumar
>
> On 18/03/17 02:00, R. Parameswaran wrote:
> > In existing kernel code, when setting up the L2TP interface, all of the
> > tunnel encapsulation headers are not taken into account
packet), to size the MTU on the L2TP
logical device to its correct value.
Signed-off-by: R. Parameswaran <rpara...@brocade.com>
---
net/l2tp/l2tp_eth.c | 55 +
1 file changed, 51 insertions(+), 4 deletions(-)
diff --git a/net/l2tp/l2tp_eth.c
[Posting a v4 patch-set shortly based on additional code review
comments received in internal review, please disregard the v3 patches]
On Thu, Mar 16, 2017 at 9:33 PM, R. Parameswaran
<parameswaran...@gmail.com> wrote:
>
>
> In existing kernel code, when setting up the L2TP
on the inner L2TP packet prior to encapsulation.
Change-set here (1/2) introduces a new kernel API to compute the IP overhead
on an IPv4 or IPv6 socket, which is then used in the L2TP code-path.
Signed-off-by: R. Parameswaran <rpara...@brocade.com>
---
include/linux/net.h | 3 +++
net/so
of
which the encapsulation headers are factored in). Ethernet MTU is
assumed as a fallback only if this fails.
Picked up review comments from James Chapman, added a function
to compute ip header + ip option overhead on a socket, and factored it
into L2TP change-set.
Signed-off-by: R. Parameswaran
of
which the encapsulation headers are factored in). Ethernet MTU is
assumed as a fallback only if this fails.
Picked up review comments from James Chapman, added a function
to compute ip header + ip option overhead on a socket, and factored it
into L2TP change-set.
Signed-off-by: R. Parameswaran
the new API from part 1]
>From f4066da53e781ef167055c1e89ca1a7819215a40 Mon Sep 17 00:00:00 2001
From: "R. Parameswaran" <rpara...@brocade.com>
Date: Sun, 16 Oct 2016 20:27:20 -0700
In existing kernel code, when setting up the L2TP interface, all of the
tunnel encapsulation he
rom 30c4b3900d09deb912fc6ce4af3c19e870f84e14 Mon Sep 17 00:00:00 2001
From: "R. Parameswaran" <rpara...@brocade.com>
Date: Sun, 16 Oct 2016 20:19:38 -0700
In existing kernel code, when setting up the L2TP interface, all of the
tunnel encapsulation headers are not taken into account when setting
up the MTU o
Hi James,
Please see inline, thanks for the reply:
On Sat, 1 Oct 2016, James Chapman wrote:
> On 30/09/16 03:39, R. Parameswaran wrote:
> >
> >>> + /* Adjust MTU, factor overhead - underlay L3 hdr, overlay L2 hdr*/
> >>> + if (tunnel->sock->sk_fami
Hi James,
On Thu, 29 Sep 2016, James Chapman wrote:
> On 22/09/16 21:52, R. Parameswaran wrote:
> > From ed585bdd6d3d2b3dec58d414f514cd764d89159d Mon Sep 17 00:00:00 2001
> > From: "R. Parameswaran" <rpara...@brocade.com>
> > Date: Thu, 22 Sep 20
Hi David,
Please see inline:
On Wed, 28 Sep 2016, David Miller wrote:
> From: "R. Parameswaran" <parameswaran...@gmail.com>
> Date: Tue, 27 Sep 2016 12:17:21 -0700 (PDT)
>
> > Later, in vxlan_dev_configure(), called from vxlan_dev_create(), it gets
> >
Hi David,
Thanks for the reply, please see inline:
On Tue, 27 Sep 2016, David Miller wrote:
> From: "R. Parameswaran" <parameswaran...@gmail.com>
> Date: Thu, 22 Sep 2016 13:52:43 -0700 (PDT)
>
> > From ed585bdd6d3d2b3dec58d414f514cd764d89159d Mon Se
On Thu, 22 Sep 2016, Derek Fawcus wrote:
> On Wed, Sep 21, 2016 at 02:11:04pm -0700, R. Parameswaran wrote:
> >
> [snip]
>
> > @@ -206,6 +209,46 @@ static void l2tp_eth_show(struct seq_file *m, void
> > *arg)
> > }
> > #endif
> [snip]
>
> >
>From ed585bdd6d3d2b3dec58d414f514cd764d89159d Mon Sep 17 00:00:00 2001
From: "R. Parameswaran" <rpara...@brocade.com>
Date: Thu, 22 Sep 2016 13:19:25 -0700
Subject: [PATCH] L2TP:Adjust intf MTU,factor underlay L3,overlay L2
Take into account all of the tunnel encapsulation h
Take into account all of the tunnel encapsulation headers when setting
up the MTU on the L2TP logical interface device. Otherwise, packets
created by the applications on top of the L2TP layer are larger
than they ought to be, relative to the underlay MTU, leading to
needless fragmentation once
32 matches
Mail list logo
