[PATCH 7/8] kernel-doc: fix network header warnings

2008-02-03 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Add missing structure kernel-doc descriptions to sock.h skbuff.h to fix kernel-doc warnings. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- include/linux/skbuff.h |2 ++ include/net/sock.h |1 + 2 files changed, 3 insertions(+) ---

[PATCH 8/8] kernel-doc: fix sunrpc warnings

2008-02-03 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Use updated file list for docbook files and fix kernel-doc warnings in sunrpc: Warning(linux-2.6.24-git12//net/sunrpc/rpc_pipe.c:689): No description found for parameter 'rpc_client' Warning(linux-2.6.24-git12//net/sunrpc/rpc_pipe.c:765): No description

Re: [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

2006-11-02 Thread Randy.Dunlap
On Thu, 2 Nov 2006, David Brownell wrote: On Thursday 02 November 2006 6:27 pm, Adrian Bunk wrote: It seems to lack the select MII at the USB_RTL8150 option that was in Randy's first patch? I was just addressing the usbnet issues ... that driver doesn't use the usbnet framework. and

Re: [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

2006-10-26 Thread Randy.Dunlap
Adrian Bunk wrote: On Wed, Oct 25, 2006 at 04:58:58PM -0700, Randy Dunlap wrote: ... Build tested with CONFIG_MII=y, m, n. ... --- linux-2619-rc3-pv.orig/drivers/usb/net/usbnet.c +++ linux-2619-rc3-pv/drivers/usb/net/usbnet.c @@ -47,6 +47,12 @@ #define DRIVER_VERSION 22-Aug-2005 +#if

Re: [PATCH 1/2] !CONFIG_NET_ETHERNET unsets CONFIG_PHYLIB, but CONFIG_USB_USBNET also needs CONFIG_PHYLIB

2006-10-25 Thread Randy.Dunlap
David Brownell wrote: On Wednesday 25 October 2006 4:59 pm, Randy Dunlap wrote: On Wed, 25 Oct 2006 15:27:09 -0700 David Brownell wrote: The other parts are right, this isn't. Instead, usbnet.c should #ifdef the relevant ethtool hooks according to CONFIG_MII ... since it's completely legit

Re: How to grab a block of binary data w/out using ioctls?

2006-10-24 Thread Randy.Dunlap
Jeff Garzik wrote: On Tue, Oct 24, 2006 at 09:35:49PM -0700, Randy Dunlap wrote: Please grep for sysfs_create_bin_file, you will find plenty of examples. Hm, I thought that sysfs binary files were supposed to be for transparent blobs of data, not for structured data. E.g., a firmware blob

Re: How to grab a block of binary data w/out using ioctls?

2006-10-24 Thread Randy.Dunlap
Jeff Garzik wrote: On Tue, Oct 24, 2006 at 09:52:15PM -0700, Randy.Dunlap wrote: Thanks. It's not the only one like that. Also these 3 uses are incorrect AFAICT: ./drivers/firmware/dell_rbu.c:721: rc = sysfs_create_bin_file(rbu_device-dev.kobj, rbu_data_attr); this is ok ack, thanks

Re: [PATCH] atm: fix horizon init section usage

2006-10-23 Thread Randy.Dunlap
David Miller wrote: From: Randy.Dunlap [EMAIL PROTECTED] Date: Sun, 22 Oct 2006 21:32:20 -0700 David Miller wrote: From: Randy Dunlap [EMAIL PROTECTED] Date: Sun, 22 Oct 2006 19:13:09 -0700 From: Randy Dunlap [EMAIL PROTECTED] hrz_init() is called from the probe function, which

Re: How to grab a block of binary data w/out using ioctls?

2006-10-23 Thread Randy.Dunlap
Jeff Garzik wrote: On Mon, Oct 23, 2006 at 09:54:48PM -0700, Randy Dunlap wrote: Similarly, sysfs is desirable in some circumstances, but not for blocks of binary data. sysfs specifically has APIs for binary data... Ack that, sorry about that. -- ~Randy - To unsubscribe from this list:

Re: [PATCH] atm: fix horizon init section usage

2006-10-22 Thread Randy.Dunlap
David Miller wrote: From: Randy Dunlap [EMAIL PROTECTED] Date: Sun, 22 Oct 2006 19:13:09 -0700 From: Randy Dunlap [EMAIL PROTECTED] hrz_init() is called from the probe function, which is __devinit and could be called after init. WARNING: drivers/atm/horizon.o - Section mismatch: reference to

[PATCH] netdev config: revert part of previous patch

2006-09-22 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Net devices should depend on NETDEVICES, so revert part of Paolo's previous patch. See http://marc.theaimsgroup.com/?l=linux-kernelm=115566326218740w=2 for history. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/net/Kconfig |5 + 1 files

Re: [PATCH]:[XFRM] BEET mode

2006-09-14 Thread Randy.Dunlap
On Thu, 14 Sep 2006 13:25:49 +0300 (EEST) Miika Komu wrote: Below is a fixed version of the announced patch. I hope this one is ok. Yes, the split line is fixed now. I suppose that this applies to Dave's netdev git tree? That would explain why I get lots of patch errors when I try to apply it

Re: [PATCH]:[XFRM] BEET mode

2006-09-14 Thread Randy.Dunlap
On Thu, 14 Sep 2006 18:52:26 +0300 Diego Beltrami wrote: I suppose that this applies to Dave's netdev git tree? That would explain why I get lots of patch errors when I try to apply it to 2.6.18-rc7... Actually we made the patch against linux/kernel/git/acme/net-2.6.19.git is that

Re: [PATCH]:[XFRM] BEET mode

2006-09-13 Thread Randy.Dunlap
On Wed, 13 Sep 2006 19:26:19 +0300 Diego Beltrami wrote: Looks like IMP (? or something else along the way?) split a long line into 2 lines for you (same thing in 2 places). See below. diff --git a/net/ipv4/xfrm4_mode_beet.c b/net/ipv4/xfrm4_mode_beet.c new file mode 100644 index

Re: [PATCH 1/7] bonding: Add 10 Gig support

2006-09-06 Thread Randy.Dunlap
On Wed, 06 Sep 2006 12:53:42 -0400 Jeff Garzik wrote: Mitch Williams wrote: Add 10 Gig support to bonding. Resent due to corrupt patch. Signed-off-by: Mitch Williams [EMAIL PROTECTED] Acked-by: Jay Vosburgh [EMAIL PROTECTED] Did you test with git-applymbox first? It's still

Re: [PATCH] IP1000A: IC Plus update 2006-08-22

2006-08-22 Thread Randy.Dunlap
On Tue, 22 Aug 2006 13:37:14 -0400 Jesse Huang wrote: Dear All: I had regenerate this patch from: git://git.kernel.org/pub/scm/linux/kernel/git/penberg/netdev-ipg-2.6.git And, submit those modifications as one patch. Add: Remove and add some whitespace From: Jesse Huang [EMAIL

Re: [PATCH 4/4] IP100A: Solve host error problem in low performance embedded system when continune down and up.

2006-08-22 Thread Randy.Dunlap
On Tue, 22 Aug 2006 14:31:32 -0400 Jesse Huang wrote: From: Jesse Huang [EMAIL PROTECTED] Change Logs: - Solve host error problem in low performance embedded system when continune down and up. Signed-off-by: Jesse Huang [EMAIL PROTECTED] --- sundance.c | 30

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Randy.Dunlap
On Tue, 22 Aug 2006 14:13:02 -0700 Nicholas Miell wrote: On Wed, 2006-08-23 at 00:16 +0400, Evgeniy Polyakov wrote: On Tue, Aug 22, 2006 at 12:57:38PM -0700, Nicholas Miell ([EMAIL PROTECTED]) wrote: On Tue, 2006-08-22 at 14:03 +0400, Evgeniy Polyakov wrote: Of course, since you

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Randy.Dunlap
On Tue, 22 Aug 2006 15:58:12 -0700 Nicholas Miell wrote: On Tue, 2006-08-22 at 14:37 -0700, Randy.Dunlap wrote: On Tue, 22 Aug 2006 14:13:02 -0700 Nicholas Miell wrote: On Wed, 2006-08-23 at 00:16 +0400, Evgeniy Polyakov wrote: On Tue, Aug 22, 2006 at 12:57:38PM -0700, Nicholas Miell

Re: [PATCH] IP1000A: IC Plus update

2006-08-21 Thread Randy.Dunlap
On Mon, 21 Aug 2006 16:32:07 -0400 Jesse Huang wrote: Dear All: I had regenerate this patch from: git://git.kernel.org/pub/scm/linux/kernel/git/penberg/netdev-ipg-2.6.git And, submit those modifications as one patch. From: Jesse Huang [EMAIL PROTECTED] Change Logs: - update

Re: [PATCH] IP1000A: IC Plus update

2006-08-21 Thread Randy.Dunlap
that is not need for new version of IP1000A, so I remove those. OK, I see. ~Randy Thanks for help. Jesse - Original Message - From: Randy.Dunlap [EMAIL PROTECTED] To: Jesse Huang [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-kernel

Re: [PATCH 7/7] [I/OAT] Add entries to MAINTAINERS for the DMA memcpy subsystem and ioatdma

2006-08-15 Thread Randy.Dunlap
On Tue, 15 Aug 2006, Chris Leech wrote: Signed-off-by: Chris Leech [EMAIL PROTECTED] --- MAINTAINERS | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 21116cc..9ae73c9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -881,6

Re: [PATCH] eth: docbook comments

2006-08-15 Thread Randy.Dunlap
On Tue, 15 Aug 2006, Stephen Hemminger wrote: Acked-by: Randy Dunlap [EMAIL PROTECTED] --- net/ethernet/eth.c | 90 + 1 file changed, 64 insertions(+), 26 deletions(-) --- net-2.6.19.orig/net/ethernet/eth.c +++

Re: [PATCH 0/5] net socket family patches

2006-08-10 Thread Randy.Dunlap
On Thu, 10 Aug 2006 05:36:13 + (UTC) Alexey Toptygin wrote: On Wed, 9 Aug 2006, David Miller wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 09 Aug 2006 11:31:38 -0700 These patches cleanup the net socket family interface and convert it to RCU. This is new stuff that

[PATCH] tiacx sparse cleanups

2006-08-07 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] tiacx sparse cleanups: - use NULL instead of 0 for pointer value - use C99 struct initializers - use ANSI function declaration Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/net/wireless/tiacx/common.c |2 drivers/net/wireless/tiacx/ioctl.c

Re: [PATCH -rt DO NOT APPLY] Fix for tg3 networking lockup

2006-08-03 Thread Randy.Dunlap
On Thu, 3 Aug 2006 12:32:05 -0400 Theodore Tso wrote: On Thu, Aug 03, 2006 at 08:00:35PM +1000, Herbert Xu wrote: Theodore Tso [EMAIL PROTECTED] wrote: I'm sending this on mostly because it was a bit of a pain to track down, and hopefully it will save time if anyone else hits this

Re: Runtime power management for network interfaces

2006-07-30 Thread Randy.Dunlap
On Tue, 25 Jul 2006 09:20:06 -0700 Auke Kok wrote: Alan Stern wrote: During a Power Management session at the Ottawa Linux Symposium, it was generally agreed that network interface drivers ought to automatically suspend their devices (if possible) whenever: (1) The interface is

Re: [DOC]: generic netlink

2006-07-13 Thread Randy.Dunlap
On Mon, 19 Jun 2006 09:41:22 -0400 jamal wrote: Folks, Attached is a document that should help people wishing to use generic netlink interface. It is a WIP so a lot more to go if i see interest. Hi, I have a few random questions about gen-netlink. 1. Provider IDs (numbers) and names

Re: [PATCH 2/2] correct dev_alloc_skb kerneldoc

2006-07-13 Thread Randy.Dunlap
On Thu, 13 Jul 2006 22:36:16 +0200 Christoph Hellwig wrote: ... I gave converting the dev_alloc_skb prototype everywhere a spin and it doesn't look too bad. There's only a few places that don't have a netdevice at hand, and all these look bogus: ... -

Re: [DOC]: generic netlink

2006-07-11 Thread Randy.Dunlap
On Tue, 20 Jun 2006 10:50:13 -0400 jamal wrote: PS:- I dont have a good place to put this doc and point to, hence the 17K attachment http://www.kernel.org/pub/linux/kernel/people/hadi/ ? (unless your permissions have been revoked for lack of use ! :-) I am only allowed

xfrm6: move define/ifdef check order and add a Kconfig option

2006-07-03 Thread Randy.Dunlap
On Mon, 03 Jul 2006 19:46:55 -0700 (PDT) David Miller wrote: Yes, indeed. Nothing named CONFIG_* should be defined explicitly by the source files, only through Kconfig. I would rather address that than apply this patch. by adding a Kconfig option or not? This patch adds one. From: Randy

[PATCH] xfrm6: move define/ifdef check order

2006-07-02 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] The first check for #ifdef XFRM6_TUNNEL_SPI_MAGIC needs to come after the optional #define of it, otherwise the variable won't be there for the rest of the code to use. Shouldn't that CONFIG_IPV6_XFRM6_TUNNEL_DEBUG be part of Kconfig or have its name changed?

[PATCH] net: add+use poison defines

2006-07-02 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Add and use poison defines in net/. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- include/linux/poison.h |4 net/atm/clip.c |3 ++- net/ipv6/netfilter/ip6_tables.c |3 ++- 3 files changed, 8 insertions(+), 2

[PATCH 2/2] ATM: add+use poison defines

2006-07-02 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] ATM: add and use POISON define values. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/atm/ambassador.c |3 ++- drivers/atm/idt77252.c |3 ++- include/linux/poison.h |1 + 3 files changed, 5 insertions(+), 2 deletions(-) ---

[PATCH] IOAT: fix header file kernel-doc

2006-06-30 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix kernel-doc problems in include/linux/dmaengine.h: - add some fields/parameters - expand some descriptions - fix typos Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- include/linux/dmaengine.h | 43 +-- 1 files

[PATCH] IOAT: fix kernel-doc in source files

2006-06-30 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix kernel-doc warnings in drivers/dma/: - use correct function parameter names - add descriptions where omitted Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/dma/dmaengine.c | 20 drivers/dma/ioatdma.c |8 +---

[PATCH] fix net-core kernel-doc

2006-06-22 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Warning(/var/linsrc/linux-2617-g4//include/linux/skbuff.h:304): No description found for parameter 'dma_cookie' Warning(/var/linsrc/linux-2617-g4//include/net/sock.h:1274): No description found for parameter 'copied_early'

Re: [PATCH] [2.6.17-rc6] Section mismatch in drivers/net/ne.o during modpost

2006-06-13 Thread Randy.Dunlap
On Tue, 13 Jun 2006 15:35:29 +1000 Keith Owens wrote: Mikael Pettersson (on Sun, 11 Jun 2006 02:51:21 +0200 (MEST)) wrote: On Sat, 10 Jun 2006 12:13:35 -0700, Randy.Dunlap wrote: On Sat, 10 Jun 2006 14:11:42 +0200 (MEST) Mikael Pettersson wrote: While compiling 2.6.17-rc6 for a 486

Re: [PATCH] wan/sdla section fixes

2006-06-12 Thread Randy.Dunlap
On Mon, 12 Jun 2006 19:50:22 +0200 Krzysztof Halasa wrote: Hi, Randy.Dunlap [EMAIL PROTECTED] writes: Priority: tossup. netdev-set_config can be called at any time, so these references to __initdata would be a real problem. However, problem has not been observed AFAIK. Fix

[PATCH] [2.6.17-rc6] Section mismatch in drivers/net/ne.o during modpost

2006-06-10 Thread Randy.Dunlap
On Sat, 10 Jun 2006 14:11:42 +0200 (MEST) Mikael Pettersson wrote: While compiling 2.6.17-rc6 for a 486 with an NE2000 ISA ethernet card, I got: WARNING: drivers/net/ne.o - Section mismatch: reference to .init.data:isapnp_clone_list from .text between 'init_module' (at offset 0x158) and

[PATCH] hp ethernet: fix section mismatches

2006-06-10 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Priority: not critical; makes init code discardable. Fix section mismatch warnings: WARNING: drivers/net/hp-plus.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0x387) and 'cleanup_card' WARNING: drivers/net/hp.o -

[PATCH] smc ethernet: fix section mismatch warnings

2006-06-10 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Priority: not critical; makes init code discardable. Removes one duplicate assignment. Fix section mismatch warnings: WARNING: drivers/net/smc-ultra.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0x369) and

Re: Updated sysctl documentation take #2

2006-06-10 Thread Randy.Dunlap
On Thu, 8 Jun 2006 00:18:06 +0200 Diego Calleja wrote: El Wed, 7 Jun 2006 13:06:53 -0700, Randy.Dunlap [EMAIL PROTECTED] escribió: OK, that's all for the README file. I'll look at the rest of it sometime this week. I don't think that it's quite ready to be merged. Thank's for your

Re: [PATCH 5/5] ehea: makefile and Kconfig

2006-06-08 Thread Randy.Dunlap
On Thu, 08 Jun 2006 11:56:05 +0200 Jan-Bernd Themann wrote: Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] drivers/net/ehea/Kconfig |6 ++ drivers/net/ehea/Makefile |7 +++ 2 files changed, 13 insertions(+) ---

Re: [RFT] Realtek 8168 ethernet support

2006-06-08 Thread Randy.Dunlap
On Thu, 1 Jun 2006 21:02:00 +0100 (BST) Daniel Drake wrote: I've produced this patch which should allow the r8169 driver to work with the new Realtek 8168 chips. These are found in PCI-Express form and onboard some newer motherboards. Does anyone own this hardware? I'm looking for someone

Re: [RFT] Realtek 8168 ethernet support

2006-06-08 Thread Randy.Dunlap
On Thu, 08 Jun 2006 22:40:05 -0400 Jeff Garzik wrote: Randy.Dunlap wrote: Conversely, any reason to use the RealTek r1000 driver? FWIW, RealTek emailed me about merging r1000. I suggested that, if the register sets were similar, that r8169 should be updated instead, to preserve

[PATCH] wan/sdla section fixes

2006-06-08 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Priority: tossup. netdev-set_config can be called at any time, so these references to __initdata would be a real problem. However, problem has not been observed AFAIK. Fix section mismatch warnings: WARNING: drivers/net/wan/sdla.o - Section mismatch:

Re: [PATCH 4/4] ehea: Kconfig and Makefile

2006-06-07 Thread Randy.Dunlap
On Wed, 07 Jun 2006 19:06:03 +0200 Jan-Bernd Themann wrote: Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] drivers/net/ehea/Kconfig |6 ++ drivers/net/ehea/Makefile | 45 + 2 files changed, 51 insertions(+) ---

Re: Updated sysctl documentation take #2

2006-06-07 Thread Randy.Dunlap
On Wed, 7 Jun 2006 20:53:16 +0200 Diego Calleja wrote: Since people didn't like the many small files approach, I've moved it to directories containing index.txt files: Documentation/sysctl/vm/index.txt Documentation/sysctl/net/core/index.txt Documentation/sysctl/net/unix/index.txt

Re: new driver for IBM ethernet chip

2006-06-02 Thread Randy.Dunlap
On Fri, 2 Jun 2006 13:02:37 +0200 Christoph Raisch wrote: We're currently developing a new Ethernet device driver for a 10G IBM chip for System p. (ppc64) A later version of the driver should end up in mainline kernel. How should we proceed to get first comments by the community? Either

[PATCH] arlan: fix section mismatch warnings

2006-05-25 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix section mismatch warnings: WARNING: drivers/net/wireless/arlan.o - Section mismatch: reference to .init.text:arlan_probe from .text between 'init_module' (at offset 0x3526) and 'cleanup_module' WARNING: drivers/net/wireless/arlan.o - Section mismatch:

[PATCH] wavelan: fix section mismatch

2006-05-25 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix section mismatch warning: WARNING: drivers/net/wireless/wavelan.o - Section mismatch: reference to .init.text: from .text between 'init_module' (at offset 0x371e) and 'cleanup_module' Signed-off-by: Randy Dunlap [EMAIL PROTECTED] ---

Re: [PATCH] wavelan: fix section mismatch

2006-05-25 Thread Randy.Dunlap
On Thu, 25 May 2006 11:39:49 -0700 Jean Tourrilhes wrote: On Thu, May 25, 2006 at 11:09:21AM -0700, Randy.Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Fix section mismatch warning: WARNING: drivers/net/wireless/wavelan.o - Section mismatch: reference to .init.text: from .text

Re: [PATCH 2/4] myri10ge - Driver header files

2006-05-17 Thread Randy.Dunlap
On Wed, 17 May 2006 18:04:35 -0400 Brice Goglin wrote: [PATCH 2/4] myri10ge - Driver header files myri10ge_mcp.h| 205 ++ myri10ge_mcp_gen_header.h | 58 + Please use diffstat -p 1 -w 70 is documented in

Re: [RFC] changing value of NETDEV_ALIGN to cacheline size

2006-05-15 Thread Randy.Dunlap
On Mon, 15 May 2006 14:08:29 +0200 Christian Borntraeger wrote: while digging through the alloc_netdev function I asked myself why there is a fixed alignment for netdevices. Is there a special reason for choosing 32? If yes, I suggest to add a comment to the definition. If not, I suspect

Re: [PATCH] Documentation: add missing operstates.txt

2006-05-12 Thread Randy.Dunlap
On Sun, 7 May 2006 12:18:59 +0200 Stefan Rompf wrote: Hi, seems documentation got lost when the RFC2863-patch was applied. Having documentation is good, so I resend it ;-) I have a few comments/questions about this. --- /dev/null 2005-03-19 20:36:14.0 +0100 +++

Re: [PATCH] irda-usb: use NULL instead of 0

2006-05-01 Thread Randy.Dunlap
I could be mistaken, but wasn't the usb_control_msg timeout type changed in kernel 2.6.12? The timeout value is no longer in jiffies but in msecs. ugh, correct. Here's a new patch. Thanks. --- From: Randy Dunlap [EMAIL PROTECTED] Use NULL instead of 0 for a null pointer value (sparse

Re: [PATCH] compile error in ieee80211_ioctl.c

2006-04-23 Thread Randy.Dunlap
On Sun, 23 Apr 2006 17:26:39 -0700 (PDT) Alex Davis wrote: Hello: I cloned git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-dev.git last night and got compile errors while compiling net/d80211/ieee80211_ioctl.c into a module. This patch fixes it. Signed-off-by: Alex

Re: [PATCH 2.6.17-rc1] Fix RtNetlink ENCODE security permissions

2006-04-14 Thread Randy.Dunlap
On Fri, 14 Apr 2006 10:47:26 -0700 Jean Tourrilhes wrote: Hi John, I've just realised that the RtNetlink code does not check the permission for SIOCGIWENCODE and SIOCGIWENCODEEXT, which means that any user can read the encryption keys. The fix is trivial and should go in 2.6.17

[PATCH] bcm43 wireless: fix printk format warnings

2006-04-11 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix printk format warnings: drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c:456: warning: format ‘%u’ expects type ‘unsigned int’, but argument 3 has type ‘size_t’ drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c:460: warning: format ‘%08x’ expects type

[PATCH] bcm43: fix config menu alignment

2006-04-11 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Use depends on to make all bcm43 driver options be listed at the same level. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/net/wireless/bcm43xx/Kconfig |3 +++ 1 files changed, 3 insertions(+) ---

Re: 2.4.32: unresolved symbol unregister_qdisc

2006-04-09 Thread Randy.Dunlap
On Sun, 9 Apr 2006 22:05:33 -0400 (EDT) George P Nychis wrote: On Sun, 9 Apr 2006 13:37:25 -0400 (EDT) George P Nychis wrote: Thanks for the help. Here is the makefile: http://rafb.net/paste/results/auchPH75.html And here is the full errors I receive:

Re: 2.4.32: unresolved symbol unregister_qdisc

2006-04-09 Thread Randy.Dunlap
On Sun, 9 Apr 2006 22:49:50 -0400 (EDT) George P Nychis wrote: On Sun, 9 Apr 2006 22:05:33 -0400 (EDT) George P Nychis wrote: On Sun, 9 Apr 2006 13:37:25 -0400 (EDT) George P Nychis wrote: Thanks for the help. Here is the makefile: http://rafb.net/paste/results/auchPH75.html

Re: 2.4.32: unresolved symbol unregister_qdisc

2006-04-09 Thread Randy.Dunlap
On Sun, 9 Apr 2006 23:20:01 -0400 (EDT) George P Nychis wrote: On Sun, 9 Apr 2006 22:49:50 -0400 (EDT) George P Nychis wrote: On Sun, 9 Apr 2006 22:05:33 -0400 (EDT) George P Nychis wrote: On Sun, 9 Apr 2006 13:37:25 -0400 (EDT) George P Nychis wrote: Thanks for the help.

Re: 2.4.32: unresolved symbol unregister_qdisc

2006-04-08 Thread Randy.Dunlap
On Sat, 8 Apr 2006 19:18:47 -0400 (EDT) George P Nychis wrote: Yeah, this module is unfortunately not under the GPL, it was made for research and i am not the author, I was only given the code for my own research. I enabled that support in the kernel, and then tried to recompile and get

gcc warnings on 2.6.17-rc1: wireless

2006-04-03 Thread Randy.Dunlap
on x86-64 and gcc 4.0.2: drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c:456: warning: format ‘%u’ expects type ‘unsigned int’, but argument 3 has type ‘size_t’ drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c:460: warning: format ‘%08x’ expects type ‘unsigned int’, but argument 2 has type

Re: [PATCH] acenic: fix section mismatches

2006-04-03 Thread Randy.Dunlap
On Sun, 2 Apr 2006 23:12:03 +0200 Sam Ravnborg wrote: On Mon, Mar 27, 2006 at 02:32:14PM -0800, Randy.Dunlap wrote: Sam, I am now seeing this error (not a WARNING like the previous ones were): drivers/net/typhoon.c:137: error: version causes a section type conflict but I

Re: [PATCH] acenic: fix section mismatches

2006-04-03 Thread Randy.Dunlap
On Mon, 3 Apr 2006 19:27:25 +0200 Sam Ravnborg wrote: On Mon, Apr 03, 2006 at 10:27:32AM -0700, Randy.Dunlap wrote: On Sun, 2 Apr 2006 23:12:03 +0200 Sam Ravnborg wrote: On Mon, Mar 27, 2006 at 02:32:14PM -0800, Randy.Dunlap wrote: Sam, I am now seeing this error

[PATCH] softmac uses Wiress Ext.

2006-04-03 Thread Randy.Dunlap
I still get this on 2.6.17-rc1... Did anyone on netdev pick it up last week? Date: Mon, 27 Mar 2006 14:53:41 -0800 From: Randy.Dunlap [EMAIL PROTECTED] To: netdev netdev@vger.kernel.org Cc: [EMAIL PROTECTED] Subject: [PATCH] softmac uses Wiress Ext. From: Randy Dunlap [EMAIL PROTECTED

[PATCH] net drivers: fix section attributes for gcc

2006-04-03 Thread Randy.Dunlap
From: Randy Dunlap [EMAIL PROTECTED] If CONFIG_HOTPLUG=n, gcc doesn't like some __initdata to be const (rodata) and other __initdata not const, so make the non-const __initdata const. gcc errors: drivers/net/bnx2.c:66: error: version causes a section type conflict drivers/net/starfire.c:338:

Re: [PATCH] acenic: fix section mismatches

2006-03-28 Thread Randy.Dunlap
On Tue, 28 Mar 2006 07:10:30 +0200 Sam Ravnborg wrote: On Mon, Mar 27, 2006 at 02:32:14PM -0800, Randy.Dunlap wrote: Nope, only with HOTPLUG enabled. I can try without also (but disabling it is a pain :). ugh, FW_LOADER is the beast (not CONFIG_HOTPLUG itself). Sam, I

Re: net TODO

2006-03-27 Thread Randy.Dunlap
On Mon, 20 Mar 2006 19:36:25 -0800 Stephen Hemminger wrote: On Mon, 20 Mar 2006 19:30:17 -0800 Randy.Dunlap [EMAIL PROTECTED] wrote: in Documentation/networking/TODO, the Jamal netdev Rx polling API change is done, right? (NAPI) Are any of the others done? Should this TODO file

Re: [PATCH] acenic: fix section mismatches

2006-03-27 Thread Randy.Dunlap
On Mon, 27 Mar 2006 22:36:25 +0200 Sam Ravnborg wrote: On Mon, Mar 27, 2006 at 12:26:12PM -0800, Randy.Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Fix section mismatches in acenic driver: WARNING: drivers/net/acenic.o - Section mismatch: reference to .init.data:tigon2FwText

Re: [PATCH] acenic: fix section mismatches

2006-03-27 Thread Randy.Dunlap
On Mon, 27 Mar 2006 13:19:41 -0800 Randy.Dunlap wrote: On Mon, 27 Mar 2006 22:36:25 +0200 Sam Ravnborg wrote: On Mon, Mar 27, 2006 at 12:26:12PM -0800, Randy.Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Fix section mismatches in acenic driver: WARNING: drivers/net/acenic.o

Re: [PATCH] acenic: fix section mismatches

2006-03-27 Thread Randy.Dunlap
On Mon, 27 Mar 2006 13:19:41 -0800 Randy.Dunlap wrote: On Mon, 27 Mar 2006 22:36:25 +0200 Sam Ravnborg wrote: On Mon, Mar 27, 2006 at 12:26:12PM -0800, Randy.Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Fix section mismatches in acenic driver: WARNING: drivers/net/acenic.o

Re: [PATCH] acenic: fix section mismatches

2006-03-27 Thread Randy.Dunlap
On Mon, 27 Mar 2006 14:11:56 -0800 Randy.Dunlap wrote: On Mon, 27 Mar 2006 13:19:41 -0800 Randy.Dunlap wrote: On Mon, 27 Mar 2006 22:36:25 +0200 Sam Ravnborg wrote: On Mon, Mar 27, 2006 at 12:26:12PM -0800, Randy.Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Fix

Re: netconsole: no IP address for eth0, aborting

2006-03-14 Thread Randy.Dunlap
On Mon, 13 Mar 2006 22:29:12 -0600 Matt Mackall wrote: On Sun, Mar 12, 2006 at 04:27:51PM -0800, Randy.Dunlap wrote: hardware: e1000 NIC in ThinkPad T42 kernel: 2.6.16-rc5-mm3 I always get $subject message. I changed the delay in net/core/netpoll.c from 4 seconds to 9 seconds

Re: Router stops routing after changing MAC Address

2006-03-13 Thread Randy.Dunlap
On Mon, 13 Mar 2006 15:27:26 -0500 linux-os \(Dick Johnson\) wrote: On Mon, 13 Mar 2006, Stephen Hemminger wrote: There still is a bug in the 3c59x driver. It doesn't include any code to handle changing the mac address. It will work if you take the device down, change address, then

netconsole: no IP address for eth0, aborting

2006-03-12 Thread Randy.Dunlap
hardware: e1000 NIC in ThinkPad T42 kernel: 2.6.16-rc5-mm3 I always get $subject message. I changed the delay in net/core/netpoll.c from 4 seconds to 9 seconds, but it doesn't matter, the e1000 always finds Link is Up immediately after $subject message. I suppose this is a consequence of

Re: [PATCH] compat. ifconf: fix limits

2006-03-08 Thread Randy.Dunlap
On Wed, 08 Mar 2006 16:46:27 -0800 (PST) David S. Miller wrote: From: Randy.Dunlap [EMAIL PROTECTED] Date: Wed, 8 Mar 2006 09:16:08 -0800 From: Randy Dunlap [EMAIL PROTECTED] A recent change to compat. dev_ifconf() in fs/compat_ioctl.c causes ifconf data to be truncated 1 entry too

Re: [PATCH] powerpc: ibmveth: Harden driver initilisation for kexec

2006-03-02 Thread Randy.Dunlap
On Fri, 3 Mar 2006 12:10:47 +1100 Michael Ellerman wrote: On Fri, 3 Mar 2006 11:34, Randy.Dunlap wrote: On Fri, 3 Mar 2006 11:22:45 +1100 Michael Ellerman wrote: Hi Jeff, I realise it's late, but it'd be really good if you could send this up for 2.6.16, we're hosed without

Re: p8023 taints kernel

2006-02-11 Thread Randy.Dunlap
On Sat, 11 Feb 2006 19:19:08 -0500 Dave Jones wrote: Missing license tag. I've assumed this is GPL. (It could also use a MODULE_AUTHOR) Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6.15.noarch/net/802/p8023.c~ 2006-02-11 19:17:26.0 -0500 +++

Re: p8023 taints kernel

2006-02-11 Thread Randy.Dunlap
On Sat, 11 Feb 2006 19:37:19 -0800 (PST) David S. Miller wrote: From: Dave Jones [EMAIL PROTECTED] Date: Sat, 11 Feb 2006 21:17:38 -0500 On Sat, Feb 11, 2006 at 06:11:48PM -0800, Randy.Dunlap wrote: needs quotes: GPL Indeed. Dave, please type make patches you submit, thanks

Re: [PATCH] ppp: don't use 0 in pointer context

2006-02-08 Thread Randy.Dunlap
On Wed, 8 Feb 2006, David S. Miller wrote: From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 09 Feb 2006 10:49:37 +1100 The difference between gcc -pedantic and sparse is that it doesn't warn about obviously correct cases like p != 0 or p = 0. So obviously correct that you left out an equals

Re: [PATCH] TNETW1450: successful device initialization

2006-02-01 Thread Randy.Dunlap
On Wed, 01 Feb 2006 10:38:28 +0100 Jean-Baptiste Note wrote: Hi Denis, Do you have a HOWTO sniff USB under Windows or URL to it? May be helpful for other potential developers. One page which I found very usefull for prism54softmac USB sniffing under windows is this one :

Re: [git patches] 2.6.x net driver updates

2006-01-13 Thread Randy.Dunlap
On Sat, 14 Jan 2006 03:29:49 +0100 Adrian Bunk wrote: On Fri, Jan 13, 2006 at 08:28:13PM +0100, Sam Ravnborg wrote: On Fri, Jan 13, 2006 at 08:23:16PM +0100, Jens Axboe wrote: 'select' is really cool as a concept, but when you can't figure out why you cannot disable CONFIG_FOO

Re: [PATCH 2/4 rev2] mv643xx: Add multicast support

2005-12-29 Thread Randy.Dunlap
On Wed, 28 Dec 2005 17:48:15 -0700 Dale Farnsworth wrote: On Wed, Dec 28, 2005 at 11:04:06PM +, Randy.Dunlap wrote: Just FMI (for my info), what are the semantics of the Special Multicast Table? Is this done in conformance with some RFC or other standard? Thanks. The table

Re: [PATCH 2/4 rev2] mv643xx: Add multicast support

2005-12-29 Thread Randy.Dunlap
On 30 Dec 2005 02:55:57 - Dale Farnsworth wrote: In article [EMAIL PROTECTED] you write: That doesn't quite answer my question of what the Special Multicast Table for MAC addresses of the form 0x01-00-5E-00-00-XX means (below). Do you (or anyone else) have any info on this?

Re: [PATCH 2/4] mv643xx: Add multicast support

2005-12-28 Thread Randy.Dunlap
On Wed, 28 Dec 2005, Dale Farnsworth wrote: From: Dale Farnsworth [EMAIL PROTECTED] Add multicast support the the Marvell mv643xx ethernet driver. This code is adapted from code in a ppc-specific version of the driver. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] Index:

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Randy.Dunlap
On Mon, 19 Dec 2005, John W. Linville wrote: On Mon, Dec 19, 2005 at 04:43:51PM +0100, Lennert Buytenhek wrote: On Mon, Dec 19, 2005 at 10:09:32AM -0500, John W. Linville wrote: @@ -633,7 +643,7 @@ static int __devinit sundance_probe1 (st np-phys[0] = 1;

Re: where is ethtool source hosted now?

2005-08-10 Thread Randy.Dunlap
On Wed, 10 Aug 2005, Jeff Garzik wrote: Randy.Dunlap wrote: On Wed, 10 Aug 2005, Jesse Brandeburg wrote: where is the ethtool source hosted now? I wanted to make some patches against the latest version. It used to be in bitkeeper but i don't see it at http://www.kernel.org/git