Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-10-13 Thread Richard Sailer
> Signed-off-by: Kleber Sacilotto de Souza Acked-bd: Richard Sailer Implementation and concept looks fine to me signature.asc Description: OpenPGP digital signature

Re: [PATCH 2/2] Revert "dccp: don't free ccid2_hc_tx_sock struct in dccp_disconnect()"

2020-10-13 Thread Richard Sailer
t()) > Reported-by: Hadar Manor > Signed-off-by: Thadeu Lima de Souza Cascardo > Signed-off-by: Kleber Sacilotto de Souza > --- Acked-by: Richard Sailer signature.asc Description: OpenPGP digital signature

Re: [PATCH net-next v5] net: dccp: Add SIOCOUTQ IOCTL support (send buffer fill)

2020-07-23 Thread Richard Sailer
> > Applied, but I wonder if you'll also need something like tcp's SIOCOUTQNSD? > A good question. SIOCOUTQNSD is not mentioned in man 7 tcp and I didn't know and consider it. Now that I looked it up (bytes of unsent packets in send buffer) maybe this patch's ioctl should be renamed SIOCOUTQNSD,

[PATCH net-next v5] net: dccp: Add SIOCOUTQ IOCTL support (send buffer fill)

2020-07-20 Thread Richard Sailer
P and always 0, even in test on highly congested paths. Therefore this uses sk_wmem_alloc like in UDP. Signed-off-by: Richard Sailer --- v5: More infos into dccp.rst, +empty line after declarations --- Documentation/networking/dccp.rst | 3 +++ net/dccp/proto.c | 9 + 2

Re: [PATCH net-next v4] net: dccp: Add SIOCOUTQ IOCTL support (send buffer fill)

2020-07-16 Thread Richard Sailer
On 16/07/2020 21:56, Jakub Kicinski wrote: > On Mon, 13 Jul 2020 00:55:20 +0200 Richard Sailer wrote: >> This adds support for the SIOCOUTQ IOCTL to get the send buffer fill >> of a DCCP socket, like UDP and TCP sockets already have. >> >> Regarding the used data

[PATCH net-next v4] net: dccp: Add SIOCOUTQ IOCTL support (send buffer fill)

2020-07-12 Thread Richard Sailer
P and always 0, even in test on highly congested paths. Therefore this uses sk_wmem_alloc like in UDP. Signed-off-by: Richard Sailer --- v4: Update to apply to .rst doc file --- Documentation/networking/dccp.rst | 2 ++ net/dccp/proto.c | 8 2 files changed, 10 inser

[PATCH v3] net: dccp: Add SIOCOUTQ IOCTL support (send buffer fill)

2020-06-03 Thread Richard Sailer
P and always 0, even in test on highly congested paths. Therefore this uses sk_wmem_alloc like in UDP. Signed-off-by: Richard Sailer --- v3: whitespace fixes --- Documentation/networking/dccp.txt | 2 ++ net/dccp/proto.c | 8 2 files changed, 10 insertions(+) diff --

[PATCH v2] net: dccp: Add SIOCOUTQ IOCTL support (send buffer fill)

2020-05-30 Thread Richard Sailer
From: Richard Sailer This adds support for the SIOCOUTQ IOCTL to call send buffer fill from the DCCP socket, like UDP and TCP already have. Regarding the used data field. DCCP uses per packet sequence numbers, not per byte, so sequence numbers can't be used like in TCP. sk_wmem_queued i

[PATCH] net: dccp: Add SIOCOUTQ IOCTL support (send buffer fill)

2020-05-30 Thread Richard Sailer
From: Richard Sailer This adds support for the SIOCOUTQ IOCTL to call send buffer fill from the DCCP socket, like UDP and TCP already have. Regarding the used data field. DCCP uses per packet sequence numbers, not per byte, so sequence numbers can't be used like in TCP. sk_wmem_queued i

[PATCH net-next 2/3] tcp: Move cc algorithms to own subdirectory

2017-10-03 Thread Richard Sailer
the source tree more well structured and self explaining. Signed-off-by: Richard Sailer --- net/ipv4/tcp/Makefile | 18 ++ net/ipv4/tcp/cc_algos/Makefile | 21 + net/ipv4/tcp/{ => cc_algos}/tcp_bbr.c | 0 net/ipv4/

[PATCH net-next 3/3] Move shared tcp code to net/ipv4v6shared

2017-10-03 Thread Richard Sailer
: Richard Sailer --- net/Kconfig| 1 + net/Makefile | 6 +- net/ipv4/Kconfig | 321 net/ipv4/Makefile | 4 +- net/ipv4v6_shared

[PATCH net-next 1/3] net/ipv4: Move shared tcp code to own subdirectory

2017-10-03 Thread Richard Sailer
. Note: This only affects the TCP Code shared by IPv4 and IPv6, the IPv4 specific part (tcp_ipv4.c and tcp_offload.c) is left in net/ipv4/. This creates the directory, moves the files and updates the Makefiles acordingly. Signed-off-by: Richard Sailer --- net/ipv4/Makefile | 25

[PATCH net-next 0/3] A own subdirectory for shared TCP code

2017-10-03 Thread Richard Sailer
net/ipv4 currently contains around 100 source files containing the IP implementation and lots of other functionality (UDP, TCP, xfrm, etc.) # 1/3 To make the networking source tree more self documenting and well structured 1/3 moves the 30 shared TCP source files to a own subdirectory of net/ipv

[PATCH net v2] tcp_timer.c: Add kernel-doc function descriptions

2016-07-15 Thread Richard Sailer
This adds kernel-doc style descriptions for 6 functions and fixes 1 typo. Signed-off-by: Richard Sailer --- Changes from v1: * All comments are indented consistently * Consistently no "." at end of function short description line net/ipv4/tcp_ti

[PATCH net] tcp_timer.c: Add kernel-doc function descriptions

2016-07-08 Thread Richard Sailer
This adds kernel-doc style descriptions for 6 functions and fixes 1 typo. Signed-off-by: Richard Sailer --- net/ipv4/tcp_timer.c | 66 +--- 1 file changed, 57 insertions(+), 9 deletions(-) diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c

[PATCH net] tcp: change type of alive from int to bool

2015-10-08 Thread Richard Sailer
is a tcp_timer.c local function no change in any other file or header is necessary. Signed-off-by: Richard Sailer --- net/ipv4/tcp_timer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c index 7149ebc..c9c716a 100644 --- a/net